GNU bug report logs - #43328
[PATCH] Make ERC desktop notifications lenient to invalid XML

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make ERC desktop notifications lenient to invalid XML
Date: Fri, 11 Sep 2020 11:41:54 +0200

[Message part 1 (text/plain, inline)]

Hi,

Currently, ‘erc-notifications-notify’ signals an error if the message
contains invalid XML characters.  These characters can be either either
IRC control codes (e.g., ^B for bold text or ^C6,12 for colored text) or
just plain invalid data.

This patch changes the behavior so that they are stripped instead.  To
test, try sending yourself a message such as

   /msg <nick> ^BHi!

where <nick> is your own nick.  The current version will signal an error
whereas this patch won’t.

The proposed patch is attached to this message.

[0001-Make-ERC-desktop-notifications-lenient-to-invalid-XM.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Best regards,
Dario

-- 
dario.gjorgjevski <at> gmail.com :: +49 1525 8666837
%   gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \
\`>     --recv-keys '744A4F0B4F1C9371'

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.