From unknown Sat Aug 16 11:11:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Resent-From: Caio Henrique Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 43315@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159976256317905 (code B ref -1); Thu, 10 Sep 2020 18:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Sep 2020 18:29:23 +0000 Received: from localhost ([127.0.0.1]:41161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRJy-0004ej-Qg for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:29:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:50516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRJx-0004ec-L8 for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:29:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGRJx-00019P-Ca for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:29:21 -0400 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]:37279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGRJv-000428-Kq for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:29:21 -0400 Received: by mail-qt1-x842.google.com with SMTP id k25so5671517qtu.4 for ; Thu, 10 Sep 2020 11:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5wwTokQNIe9vDxyMkxGA5YO00HP5EXuvfh0J0atTqKA=; b=Ry500V+2xeeih+x949gmox+DOsZ1fasszTKnxCX1c2tGIg6Iq3KJxqrQEFIPsAyOvP cm8fR4XqrFWEgMN/VCf0+kW1XInLIihi2B5M1b8V7YFqrulRZ2PqzdHdoy4zowjCvDLI gb8tEjYQtNSVSgQ/SOFpCMrAWFDHokDFzo7WjxKM4vCaq55nU9iOiQk2w1OMRrx22ApO 2+ckvuLcysYBerSFuM0l8hQDKtVLV+ON18cGz/YTRJDSy6tY2o+4AYcHT/crxfTDcBRw u4ijRSGg51RjYNRqGhtSTAA+/1fyNMzeIdq24oW8CBQG5nypKqpqxrmohfQyz9iSG6ew V2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5wwTokQNIe9vDxyMkxGA5YO00HP5EXuvfh0J0atTqKA=; b=Cz7ziUNPt2QaFoq0i9kpfdGZnkz8L1exhe55kgjeHu8OuvsjYdlqZBSIc8xuoCC5H6 X5WAt/lgBEJMk4b3rFohomIEj7n+p0hhZiUjXPr7n03MQ5P5wka8UbZ/n0OSxviuXcMq A6soyWt2gKg+FQB+l9+C4/bPz+9DvKuha3XNQzwFo1WN6bUxuznbGSMA1fEFx1GEbzJ/ 6ERyNsmY8ylsR+IPwKTB6zlWkjkYJJh+CRQOagzyhXwNnjGSP1iMk1eBL79UPO/l53A9 pbO/uIU3U5tY9qAuyTfC4StqQoFs6d5FifsOEtoIRlEoltIgi9AMTaWX0+v33L3Qx3KI 3a6Q== X-Gm-Message-State: AOAM5312/Rxdc5enG0PgzAb0dvOk3Mse5Fwzv+eaSana+mBWS0bEUElJ QLnxsuyYu/cXqcZxV6toFoFEcPwdi/E= X-Google-Smtp-Source: ABdhPJxWqXLMWPnKyYgnnpEodTtqX1su5XHzFrDIatun4uiT3/m3OKwoKEkf51/1KIWQrSK4e/iAeA== X-Received: by 2002:ac8:5d43:: with SMTP id g3mr9518270qtx.295.1599762557916; Thu, 10 Sep 2020 11:29:17 -0700 (PDT) Received: from localhost.localdomain ([181.223.151.236]) by smtp.gmail.com with ESMTPSA id u66sm7738278qka.136.2020.09.10.11.29.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 11:29:17 -0700 (PDT) From: Caio Henrique X-Google-Original-From: Caio Henrique Date: Thu, 10 Sep 2020 15:29:11 -0300 Message-ID: <87o8mdzds8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::842; envelope-from=caiohcs0@gmail.com; helo=mail-qt1-x842.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi, After the recent discussions to improve discoverability of Emacs, I analyzed the Emacs menu-bar and the menu bar of other text editors. They all have a "Redo" option close to the "Undo". Here are some examples: 1. nano When you launch nano on the terminal, you can see the text on the bottom that says "M-E Redo", right bellow "Undo". 2. libreoffice write When you open the Edit menu, you will find that the first option is "Undo" and the second is "Redo". 3. Notepad++ Same as libreoffice write. 4. Visual Studio Code Same as libreoffice write. Here is my proposal: I'm not used to the default undo system since I use undo-tree, but it seems that Emacs 28 has added a function called undo-redo to the simple.el file, right? My proposal is to add it to the menu-bar, right bellow "Undo": _____ diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index bc094c9050..30d86c7f17 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -536,6 +536,12 @@ menu-bar-edit-menu (if (featurep 'ns) (bindings--define-key menu [separator-undo] menu-bar-separator)) + (bindings--define-key menu [undo-redo] + '(menu-item "Redo" undo-redo + :enable (and (not buffer-read-only) + (undo--last-change-was-undo-p buffer-undo-list)) + :help "Undo last undo")) + (bindings--define-key menu [undo] '(menu-item "Undo" undo :enable (and (not buffer-read-only) ____ Cordially, Caio Henrique From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 16:54:42 2020 Received: (at control) by debbugs.gnu.org; 10 Sep 2020 20:54:42 +0000 Received: from localhost ([127.0.0.1]:41388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGTac-0001sO-9z for submit@debbugs.gnu.org; Thu, 10 Sep 2020 16:54:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGTab-0001sC-CG for control@debbugs.gnu.org; Thu, 10 Sep 2020 16:54:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xOJgtyYQQ9E0egMHWehHm9PqBNoAbBlAmBKo61bc7GY=; b=Y35UYH2PXYqxk0bl2L6yV5ykfb eZaAhW0wZm2vHjMaDC+sxImXawHH8yL7dYiITk+LGUKrbBJ8jDf0g3WtKA/FOOnM57Ow2XMpJsLXO mtznOMNJ4Hl/BnILOyIxhQ3V/4sPMeTKmw2c6p5dDfq14HZhdQZOQ9jrfuUjmrqcB0ns=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGTaT-00029N-JH for control@debbugs.gnu.org; Thu, 10 Sep 2020 22:54:35 +0200 Date: Thu, 10 Sep 2020 22:54:32 +0200 Message-Id: <871rj95p4n.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43315 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43315 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43315 + patch quit From unknown Sat Aug 16 11:11:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 21:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Caio Henrique Cc: 43315@debbugs.gnu.org Received: via spool by 43315-submit@debbugs.gnu.org id=B43315.15997715697664 (code B ref 43315); Thu, 10 Sep 2020 21:00:02 +0000 Received: (at 43315) by debbugs.gnu.org; 10 Sep 2020 20:59:29 +0000 Received: from localhost ([127.0.0.1]:41397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGTfE-0001zY-TR for submit@debbugs.gnu.org; Thu, 10 Sep 2020 16:59:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGTfD-0001zL-NF for 43315@debbugs.gnu.org; Thu, 10 Sep 2020 16:59:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sOQQSGk8WatVOKweCoQVLLS3pvIwB2n9E4NibtakDaA=; b=G5uq2joO3xo2arBHHAr95qIp/b 3eYtuGNrxobuG//yLcW+bOX9Dx/sYYRMP5b+EpM3toOr9d+puYg5p35h66OLpeywegIl2FLNeuZHO +ruE+Zk4yBTf4qXEG3uXGo4/5O+c2cacyfWTU/XsSSzCuMxvbjoFRbZgLisM9cLENyz0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGTf2-0002As-BG; Thu, 10 Sep 2020 22:59:21 +0200 From: Lars Ingebrigtsen References: <87o8mdzds8.fsf@gmail.com> X-Now-Playing: Jon Eberson Group's _City Visions_: "My Mind's On You" Date: Thu, 10 Sep 2020 22:59:15 +0200 In-Reply-To: <87o8mdzds8.fsf@gmail.com> (Caio Henrique's message of "Thu, 10 Sep 2020 15:29:11 -0300") Message-ID: <87wo114acc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Caio Henrique writes: > Here is my proposal: > I'm not used to the default undo system since I use undo-tree, but it > seems that Emacs 28 has added a function called undo-redo to the > simple.el file, right? My proposal i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Caio Henrique writes: > Here is my proposal: > I'm not used to the default undo system since I use undo-tree, but it > seems that Emacs 28 has added a function called undo-redo to the > simple.el file, right? My proposal is to add it to the menu-bar, right > bellow "Undo": Makes sense to me, so I've applied your patch to Emacs 28. It's small enough to do without a copyright assignment to the FSF, but if it's likely/possible that you'll be submitting more patches in the future, it might make sense to start the assignment process now. Would you be willing to assign the copyright on Emacs patches to the FSF? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 16:59:34 2020 Received: (at control) by debbugs.gnu.org; 10 Sep 2020 20:59:34 +0000 Received: from localhost ([127.0.0.1]:41400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGTfK-0001zs-6w for submit@debbugs.gnu.org; Thu, 10 Sep 2020 16:59:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGTfI-0001zR-SR for control@debbugs.gnu.org; Thu, 10 Sep 2020 16:59:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vz2NQd1+pHm1GoI4HBkrxKVa5YAGuSEvVU9vMpAO1DA=; b=scQSDLk/+0vovwIFzdqW6PkIVG BDeNg96ALtzSTCOuPmtLR/Rfwx+CIJliJPRGIKamNUjVOetT5fltNCEyHRjYACND6QSu1U1m1zWGu hVTqfH4CZByJfn5nqJd9QWW/0eRj6Cc9V/HMqCa2oy9SpTWZntxtK/S3OAI77xBNhf50=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGTfB-0002B1-1i for control@debbugs.gnu.org; Thu, 10 Sep 2020 22:59:27 +0200 Date: Thu, 10 Sep 2020 22:59:23 +0200 Message-Id: <87v9gl4ac4.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43315 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43315 fixed close 43315 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43315 fixed close 43315 28.1 quit From unknown Sat Aug 16 11:11:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Resent-From: Caio Henrique Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: 43315@debbugs.gnu.org, Caio Henrique Received: via spool by 43315-submit@debbugs.gnu.org id=B43315.159977648116398 (code B ref 43315); Thu, 10 Sep 2020 22:22:01 +0000 Received: (at 43315) by debbugs.gnu.org; 10 Sep 2020 22:21:21 +0000 Received: from localhost ([127.0.0.1]:41654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGUwT-0004GP-Hy for submit@debbugs.gnu.org; Thu, 10 Sep 2020 18:21:21 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:38474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGUwR-0004GB-KX for 43315@debbugs.gnu.org; Thu, 10 Sep 2020 18:21:20 -0400 Received: by mail-qt1-f194.google.com with SMTP id c18so6214521qtw.5 for <43315@debbugs.gnu.org>; Thu, 10 Sep 2020 15:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FLA2Eo3u+irLWUvXNGkmHMyU4B+4NErHjwGJBVuaIPU=; b=jpm+u5HKSu+U9YfhkkkTU3ixKlYhJo3nU6TP1DMrd0kWXVQQc3KQAccJZkjdhn1ZON lrEXUMoAlrdgDLn125ha7zIzxv2lJElmj7TxhuUCP3USSUwpBOioF7loZz/Q2/91JHuD kfmNXkcG/4KKrqHMU3TrioDEKD5w5NuaZ/v35VmcUhl+52Ve90cSQjEwrIVkz6o9cPPL +8VKL4WaPfbKHPzR1tIL7kIGd4kTFhyfEsWtMIai2OLC0zNhpXS53wCSiFrX7J65oLVr KLXKWU4xxE4X9ouU5t4sc2fTdF7xSG2KaIWqu/9lKiXRlFSFWXjDImXupGMw93gkKV59 /lpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FLA2Eo3u+irLWUvXNGkmHMyU4B+4NErHjwGJBVuaIPU=; b=Nr65Gp3k8qECXWoGZ6BQ2uHkjSAzAWNHVj3tj5h+3Yqg5VuL35VzegEx//kaKbCkNj ha3tC2YZ6qU2So1BCat3NSOpmhZX9CUO2Gr48wDCVCnfsPEj1IGq95lQHViPcr5nFpUD CIE+bowk28+ODhePfZ9nBl+5dan0aMAHEsLRnPwWLq5I6Ucd4NkmE99+wSuVhP2VOnje Tq9xGWjWl2+3KEB09Fgw9VwOwuBTslN9WCxsJm872je4rQOV+QqSExO+afvZUNJkSnd/ sa4j104viamzpqAZWuIxKiEjrCn/2SBEitTOaVL+NuidFZzKjcnrrB/lKNEGNXpsQzju z5ZA== X-Gm-Message-State: AOAM5338sGEbbmwayiNU1bkXKtuHN49DzFULOBQognlWird1y5+e6S3b fgrE5M3gKboJBaqGy0SQ/NmzY0WJGBo= X-Google-Smtp-Source: ABdhPJwgpKwGEkWNLxy/2bYprmUwpAOFWJQ5ffFPKPMO0WKffwg9qdBXdeYFpzty+P5d9w+8UJn1Uw== X-Received: by 2002:ac8:3fee:: with SMTP id v43mr10104933qtk.192.1599776473948; Thu, 10 Sep 2020 15:21:13 -0700 (PDT) Received: from localhost.localdomain ([181.223.151.236]) by smtp.gmail.com with ESMTPSA id z3sm469019qkj.0.2020.09.10.15.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 15:21:13 -0700 (PDT) From: Caio Henrique X-Google-Original-From: Caio Henrique References: <87o8mdzds8.fsf@gmail.com> <87wo114acc.fsf@gnus.org> Date: Thu, 10 Sep 2020 19:21:07 -0300 In-Reply-To: <87wo114acc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 10 Sep 2020 22:59:15 +0200") Message-ID: <87363pw9ws.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Lars Ingebrigtsen writes: > Would you be willing to assign the copyright on Emacs patches to the FSF? Yes, can you send me the instructions/documents? Thanks! From unknown Sat Aug 16 11:11:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Resent-From: Richard Stallman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Sep 2020 04:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Caio Henrique Cc: 43315@debbugs.gnu.org Reply-To: rms@gnu.org Received: via spool by 43315-submit@debbugs.gnu.org id=B43315.159979789416578 (code B ref 43315); Fri, 11 Sep 2020 04:19:02 +0000 Received: (at 43315) by debbugs.gnu.org; 11 Sep 2020 04:18:14 +0000 Received: from localhost ([127.0.0.1]:41999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGaVp-0004JK-RJ for submit@debbugs.gnu.org; Fri, 11 Sep 2020 00:18:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGaVo-0004J7-PR for 43315@debbugs.gnu.org; Fri, 11 Sep 2020 00:18:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46629) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGaVj-0001uv-Hn; Fri, 11 Sep 2020 00:18:07 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kGaVh-0005BK-IM; Fri, 11 Sep 2020 00:18:05 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman In-Reply-To: <87o8mdzds8.fsf@gmail.com> (message from Caio Henrique on Thu, 10 Sep 2020 15:29:11 -0300) References: <87o8mdzds8.fsf@gmail.com> Message-Id: Date: Fri, 11 Sep 2020 00:18:05 -0400 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > + (bindings--define-key menu [undo-redo] > + '(menu-item "Redo" undo-redo > + :enable (and (not buffer-read-only) > + (undo--last-change-was-undo-p buffer-undo-list)) > + :help "Undo last undo")) > + There is no harm putting it in the menu. But I doubt we can find a key for it. -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From unknown Sat Aug 16 11:11:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Sep 2020 06:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: 43315@debbugs.gnu.org, caiohcs0@gmail.com Received: via spool by 43315-submit@debbugs.gnu.org id=B43315.159980394726298 (code B ref 43315); Fri, 11 Sep 2020 06:00:01 +0000 Received: (at 43315) by debbugs.gnu.org; 11 Sep 2020 05:59:07 +0000 Received: from localhost ([127.0.0.1]:42101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGc5S-0006q6-JC for submit@debbugs.gnu.org; Fri, 11 Sep 2020 01:59:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGc5Q-0006pc-S8 for 43315@debbugs.gnu.org; Fri, 11 Sep 2020 01:59:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGc5L-0006ou-E4; Fri, 11 Sep 2020 01:58:59 -0400 Received: from [176.228.60.248] (port=1097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kGc5K-0007Df-5x; Fri, 11 Sep 2020 01:58:58 -0400 Date: Fri, 11 Sep 2020 08:59:04 +0300 Message-Id: <837dt0j1lj.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87wo114acc.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 10 Sep 2020 22:59:15 +0200) References: <87o8mdzds8.fsf@gmail.com> <87wo114acc.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-From: Lars Ingebrigtsen > Original-Sender: "Debbugs-submit" > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > From: Lars Ingebrigtsen > Date: Thu, 10 Sep 2020 22:59:15 +0200 > Cc: 43315@debbugs.gnu.org > > Caio Henrique writes: > > > Here is my proposal: > > I'm not used to the default undo system since I use undo-tree, but it > > seems that Emacs 28 has added a function called undo-redo to the > > simple.el file, right? My proposal is to add it to the menu-bar, right > > bellow "Undo": > > Makes sense to me, so I've applied your patch to Emacs 28. Thanks. However, when we put a command on a menu item, we should make sure its documentation is clear enough for newbies. In this case, the doc string was so terse it was beyond obscure, and needed fixing to be clear enough for a menu command. (I fixed it.) From unknown Sat Aug 16 11:11:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Sep 2020 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Caio Henrique Cc: larsi@gnus.org, 43315@debbugs.gnu.org, caiohcs0@gmail.com Received: via spool by 43315-submit@debbugs.gnu.org id=B43315.159980617129758 (code B ref 43315); Fri, 11 Sep 2020 06:37:02 +0000 Received: (at 43315) by debbugs.gnu.org; 11 Sep 2020 06:36:11 +0000 Received: from localhost ([127.0.0.1]:42134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGcfL-0007jt-0L for submit@debbugs.gnu.org; Fri, 11 Sep 2020 02:36:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGcfH-0007jd-P2 for 43315@debbugs.gnu.org; Fri, 11 Sep 2020 02:36:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47885) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGcfC-0003Sv-DK; Fri, 11 Sep 2020 02:36:02 -0400 Received: from [176.228.60.248] (port=3353 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kGcfB-0005Vp-PW; Fri, 11 Sep 2020 02:36:02 -0400 Date: Fri, 11 Sep 2020 09:36:08 +0300 Message-Id: <831rj8izvr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87363pw9ws.fsf@gmail.com> (message from Caio Henrique on Thu, 10 Sep 2020 19:21:07 -0300) References: <87o8mdzds8.fsf@gmail.com> <87wo114acc.fsf@gnus.org> <87363pw9ws.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Caio Henrique > Date: Thu, 10 Sep 2020 19:21:07 -0300 > Cc: 43315@debbugs.gnu.org, Caio Henrique > > Lars Ingebrigtsen writes: > > > Would you be willing to assign the copyright on Emacs patches to the FSF? > > Yes, can you send me the instructions/documents? Thanks! Form and instructions sent off-list. Thanks.