GNU bug report logs - #43315
28.0.50; Improvements to menu-bar Edit: add redo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43315 in the body.
You can then email your comments to 43315 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Caio Henrique <caiohcs0 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Improvements to menu-bar Edit: add redo
Date: Thu, 10 Sep 2020 15:29:11 -0300

Hi,

After the recent discussions to improve discoverability of Emacs, I
analyzed the Emacs menu-bar and the menu bar of  other text
editors. They all have a "Redo" option close to the "Undo".

Here are some examples:

1. nano
When you launch nano on the terminal, you can see the text on the bottom
that says "M-E Redo", right bellow "Undo".

2. libreoffice write
When you open the Edit menu, you will find that the first option is "Undo"
and the second is "Redo".

3. Notepad++
Same as libreoffice write.

4. Visual Studio Code
Same as libreoffice write.

Here is my proposal:
I'm not used to the default undo system since I use undo-tree, but it
seems that Emacs 28 has added a function called undo-redo to the
simple.el file, right? My proposal is to add it to the menu-bar, right
bellow "Undo":

_____
diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index bc094c9050..30d86c7f17 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -536,6 +536,12 @@ menu-bar-edit-menu
     (if (featurep 'ns)
         (bindings--define-key menu [separator-undo] menu-bar-separator))
 
+    (bindings--define-key menu [undo-redo]
+      '(menu-item "Redo" undo-redo
+                  :enable (and (not buffer-read-only)
+                           (undo--last-change-was-undo-p buffer-undo-list))
+                  :help "Undo last undo"))
+
     (bindings--define-key menu [undo]
       '(menu-item "Undo" undo
                   :enable (and (not buffer-read-only)
____

Cordially,
Caio Henrique

Message #10 received at 43315 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Caio Henrique <caiohcs0 <at> gmail.com>
Cc: 43315 <at> debbugs.gnu.org
Subject: Re: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo
Date: Thu, 10 Sep 2020 22:59:15 +0200

Caio Henrique <caiohcs0 <at> gmail.com> writes:

> Here is my proposal:
> I'm not used to the default undo system since I use undo-tree, but it
> seems that Emacs 28 has added a function called undo-redo to the
> simple.el file, right? My proposal is to add it to the menu-bar, right
> bellow "Undo":

Makes sense to me, so I've applied your patch to Emacs 28.

It's small enough to do without a copyright assignment to the FSF, but
if it's likely/possible that you'll be submitting more patches in the
future, it might make sense to start the assignment process now.  Would
you be willing to assign the copyright on Emacs patches to the FSF?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 43315 <at> debbugs.gnu.org (full text, mbox):

From: Caio Henrique <caiohcs0 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43315 <at> debbugs.gnu.org, Caio Henrique <caiohcs0 <at> gmail.com>
Subject: Re: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo
Date: Thu, 10 Sep 2020 19:21:07 -0300

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Would you be willing to assign the copyright on Emacs patches to the FSF?

Yes, can you send me the instructions/documents? Thanks!

Message #20 received at 43315 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Caio Henrique <caiohcs0 <at> gmail.com>
Cc: 43315 <at> debbugs.gnu.org
Subject: Re: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo
Date: Fri, 11 Sep 2020 00:18:05 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > +    (bindings--define-key menu [undo-redo]
  > +      '(menu-item "Redo" undo-redo
  > +                  :enable (and (not buffer-read-only)
  > +                           (undo--last-change-was-undo-p buffer-undo-list))
  > +                  :help "Undo last undo"))
  > +

There is no harm putting it in the menu.  But I doubt we can find a key for it.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message #23 received at 43315 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43315 <at> debbugs.gnu.org, caiohcs0 <at> gmail.com
Subject: Re: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo
Date: Fri, 11 Sep 2020 08:59:04 +0300

> Resent-From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs <at> gnu.org
> Resent-Sender: help-debbugs <at> gnu.org
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Thu, 10 Sep 2020 22:59:15 +0200
> Cc: 43315 <at> debbugs.gnu.org
> 
> Caio Henrique <caiohcs0 <at> gmail.com> writes:
> 
> > Here is my proposal:
> > I'm not used to the default undo system since I use undo-tree, but it
> > seems that Emacs 28 has added a function called undo-redo to the
> > simple.el file, right? My proposal is to add it to the menu-bar, right
> > bellow "Undo":
> 
> Makes sense to me, so I've applied your patch to Emacs 28.

Thanks.

However, when we put a command on a menu item, we should make sure its
documentation is clear enough for newbies.  In this case, the doc
string was so terse it was beyond obscure, and needed fixing to be
clear enough for a menu command.  (I fixed it.)

Message #26 received at 43315 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Caio Henrique <caiohcs0 <at> gmail.com>
Cc: larsi <at> gnus.org, 43315 <at> debbugs.gnu.org, caiohcs0 <at> gmail.com
Subject: Re: bug#43315: 28.0.50; Improvements to menu-bar Edit: add redo
Date: Fri, 11 Sep 2020 09:36:08 +0300

> From: Caio Henrique <caiohcs0 <at> gmail.com>
> Date: Thu, 10 Sep 2020 19:21:07 -0300
> Cc: 43315 <at> debbugs.gnu.org, Caio Henrique <caiohcs0 <at> gmail.com>
> 
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> 
> > Would you be willing to assign the copyright on Emacs patches to the FSF?
> 
> Yes, can you send me the instructions/documents? Thanks!

Form and instructions sent off-list.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.