GNU bug report logs - #43308
28.0.50; Improvements to Edit->Search menu

Previous Next

Full log

Message #77 received at 43308 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43308 <at> debbugs.gnu.org, yantar92 <at> gmail.com, drew.adams <at> oracle.com,
 stefankangas <at> gmail.com
Subject: Re: bug#43308: 28.0.50; Improvements to Edit->Search menu
Date: Tue, 22 Sep 2020 21:10:13 +0300

>> >> Why no keybindings are shown for nonincremental menu items?
>> >> They still have keybindings, e.g. nonincremental forward search
>> >> can be started with 'C-s RET', nonincremental backward search
>> >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc.
>> >
>> > I suppose I could add some explicitly, with :keys.
>> > That makes sense.  Unfortunately, none show up
>> > automatically.  It would be good to somehow fix that.
>>
>> How about the following patch?
>
> But the keys this will show don't invoke the same commands, they
> invoke slightly different commands, don't they?  I don't think we ever
> show keys that invoke a different command, why do this here?

The comment in 'nonincremental-search-forward' says:

  ;; Ideally, this whole command would be equivalent to `C-s RET'.

This seems to imply that currently it's not equivalent.
Then indeed displaying wrong keys would be misleading.

>> Another problem is that selecting "Continue Tags Search"
>> signals the error:
>>
>> emacs -Q
>> Select "Edit" -> "Search" -> "Continue Tags Search"
>>
>>   Lisp error: (wrong-type-argument commandp fileloop-continue)
>
> I guess this is a leftover from migration to Xref.

Do you mean these obsolete menu items should be removed since
now there are Xref commands in the "Go To" submenu?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.