GNU bug report logs - #43296
Gnome Builder doesn't install.

Previous Next

Full log

Message #17 received at 43296 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 43296 <at> debbugs.gnu.org
Subject: Re: bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
Date: Thu, 10 Sep 2020 20:23:53 +0200

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE.  To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
> ---
>  gnu/packages/gnome.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 31c5b0319c..ff4cb8a383 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -11336,6 +11336,12 @@ libraries.  Applications do not need to be recompiled--or even restarted.")
>                  (string-append (assoc-ref inputs "python-pygobject")
>                                 "/lib")))
>               #t))
> +         (add-after 'configure 'fix-ninja
> +           (lambda _
> +             ;; #43296: meson(?) incorrectly assumes we want to link
> +             ;;         this PIE against a static libselinux.
> +             (substitute* "build.ninja"
> +               (("libselinux\\.a") "libselinux.so"))))

Please end the phase on #t, because “substitute*” has no specified
return value.

Other than that it looks good to me, thanks!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.