From unknown Sat Jun 21 12:29:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43281: 27.1; Opening a bad GIF segfaults Emacs Resent-From: nnoodle Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2020 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 43281@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159958049016424 (code B ref -1); Tue, 08 Sep 2020 15:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Sep 2020 15:54:50 +0000 Received: from localhost ([127.0.0.1]:56111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFfxK-0004Gj-50 for submit@debbugs.gnu.org; Tue, 08 Sep 2020 11:54:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:54780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFdpX-000696-Pz for submit@debbugs.gnu.org; Tue, 08 Sep 2020 09:38:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFdpX-00046o-GQ for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 09:38:39 -0400 Received: from chiru.no ([142.4.209.132]:47736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kFdpV-00004v-O4 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 09:38:39 -0400 Received: from [192.168.0.151] (unknown [202.80.116.253]) by chiru.no (Postfix) with ESMTPSA id 8DFEA128001B for ; Tue, 8 Sep 2020 13:38:35 +0000 (UTC) From: nnoodle Message-ID: <069b5dfe-a34b-e91a-88a3-ade53e9a97d3@chiru.no> Date: Tue, 8 Sep 2020 20:38:30 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: none client-ip=142.4.209.132; envelope-from=nnoodle@chiru.no; helo=chiru.no X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 09:38:36 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: To reproduce: $ echo 'GIF89a; ' > bad.gif $ emacs -Q bad.gif The result will be a segmentation fault. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-09-05 built on pc Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 Syste [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [202.80.116.253 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Mailman-Approved-At: Tue, 08 Sep 2020 11:54:48 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) To reproduce: $ echo 'GIF89a;' > bad.gif $ emacs -Q bad.gif The result will be a segmentation fault. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-09-05 built on pc Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.5 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --prefix=/home/me/.local/stow/emacs --with-modules --with-file-notification=inotify --with-mailutils --with-x=yes --with-x-toolkit=gtk3 --with-xwidgets --with-lcms2 --with-cairo --with-json --with-harfbuzz --with-threads' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: en_US.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib dired dired-loaddefs tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 49247 10632) (symbols 48 6010 1) (strings 32 15626 1765) (string-bytes 1 512136) (vectors 16 9296) (vector-slots 8 125074 13210) (floats 8 22 37) (intervals 56 904 0) (buffers 1000 13)) From unknown Sat Jun 21 12:29:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43281: 27.1; Opening a bad GIF segfaults Emacs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2020 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: nnoodle Cc: 43281@debbugs.gnu.org Received: via spool by 43281-submit@debbugs.gnu.org id=B43281.159958189427266 (code B ref 43281); Tue, 08 Sep 2020 16:19:01 +0000 Received: (at 43281) by debbugs.gnu.org; 8 Sep 2020 16:18:14 +0000 Received: from localhost ([127.0.0.1]:56191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFgJx-00075i-Mx for submit@debbugs.gnu.org; Tue, 08 Sep 2020 12:18:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFgJv-00075U-9M for 43281@debbugs.gnu.org; Tue, 08 Sep 2020 12:18:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43493) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFgJp-0007F6-OK; Tue, 08 Sep 2020 12:18:05 -0400 Received: from [176.228.60.248] (port=4036 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFgJo-0008Sq-Ui; Tue, 08 Sep 2020 12:18:05 -0400 Date: Tue, 08 Sep 2020 19:18:04 +0300 Message-Id: <83wo14kzsz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <069b5dfe-a34b-e91a-88a3-ade53e9a97d3@chiru.no> (message from nnoodle on Tue, 8 Sep 2020 20:38:30 +0700) References: <069b5dfe-a34b-e91a-88a3-ade53e9a97d3@chiru.no> X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > From: nnoodle > Date: Tue, 8 Sep 2020 20:38:30 +0700 > > > To reproduce: > $ echo 'GIF89a;' > bad.gif > $ emacs -Q bad.gif > > The result will be a segmentation fault. Thanks, fixed. From unknown Sat Jun 21 12:29:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43281: 27.1; Opening a bad GIF segfaults Emacs Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2020 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: nnoodle Cc: 43281@debbugs.gnu.org Received: via spool by 43281-submit@debbugs.gnu.org id=B43281.15995850638318 (code B ref 43281); Tue, 08 Sep 2020 17:12:01 +0000 Received: (at 43281) by debbugs.gnu.org; 8 Sep 2020 17:11:03 +0000 Received: from localhost ([127.0.0.1]:56301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFh95-0002A6-8l for submit@debbugs.gnu.org; Tue, 08 Sep 2020 13:11:03 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:40296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFh94-00029c-27 for 43281@debbugs.gnu.org; Tue, 08 Sep 2020 13:11:02 -0400 Received: by mail-wr1-f50.google.com with SMTP id j2so19935468wrx.7 for <43281@debbugs.gnu.org>; Tue, 08 Sep 2020 10:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=MUoZ9+IwH+aEIAr4lcDvnHyAUpGivPuYnAOYfRSa3zA=; b=fkukvV2OF8rOy1tBZc9Grn3sLm5TESeGkoJ1QLcSctBw0+NRKblseLi6VHIdvFpB08 zaivC6KtS3Q+f/8dYSuS98sxbnCG4saGsfui4H6nGNmxnAUxMlnfo+ws8E7iz3TMlnmU yHHPMd/pH9IXryC37XH/SJWpFhH8cO/rM9Dy3M7xaZF1LgTJG8ZxYjzqv3f06n1t8NV0 Iq/M2tIeUQzm46kIQ6vngBhDb4Yo9eVUPjPrMp7OxwVrZPvYNZCNnhXmXdC7xfDQJw4c vq6qW0pZWUre8Fl7l7fRoVhX9IVIbpnZzRLbEMROYWTg0cxkzYcETzcP4lLXl9nP5qsS enQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=MUoZ9+IwH+aEIAr4lcDvnHyAUpGivPuYnAOYfRSa3zA=; b=oEauCwjOvkkj4bMg9g2rvJ9VlAGCktJhWBVeYRSap7K1PT6oOyIbHC9pXAxOyC1cho 8yQ1cW3Wga9s+8vZCVtznNH5cjvhRaWZcyMcj3vI3/3hpm6m1sClZD18vzhLK1F3r9Vd KbJuLGOrVFnQxiaCEf1oPqTsf8DHOBdbPiICvNIj1zr1A+kIRCB/wPdD353eN3HR8WgK 06f7XF/2Ecq+M446F2qcjI/EcAJbBZEjGdWixwxwutvUN0M32O4moSz/pydWeQNArJeU hl3tN3YqOU4qcoKv0Y97riSOl1EV12tRLhPjQswEwhXCZQ2tM0AkRdqznd8cBoVpxKm+ FxJg== X-Gm-Message-State: AOAM5334TA/3oNZZdvUay3VpxOD/NRbeIqPFsOmPPYHW4NOKUSEzWF80 ppJ4s8yBYBwbtRG6AdQ9tb9/5jTlSSw= X-Google-Smtp-Source: ABdhPJz+zwZ10QcoB8NP/tJxwGw8GfL1KqnkTUxBU8kRgEIAOk0qvJAkKjsA1ZhkDuU9ZlFhFAl8LA== X-Received: by 2002:a5d:61d2:: with SMTP id q18mr617008wrv.404.1599585056024; Tue, 08 Sep 2020 10:10:56 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:d0f7:b506:b95d:6344]) by smtp.gmail.com with ESMTPSA id s5sm147333wrm.33.2020.09.08.10.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 10:10:55 -0700 (PDT) From: Robert Pluim References: <069b5dfe-a34b-e91a-88a3-ade53e9a97d3@chiru.no> Date: Tue, 08 Sep 2020 19:10:53 +0200 In-Reply-To: <069b5dfe-a34b-e91a-88a3-ade53e9a97d3@chiru.no> (nnoodle@chiru.no's message of "Tue, 8 Sep 2020 20:38:30 +0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 8 Sep 2020 20:38:30 +0700, nnoodle said: nnoodle> To reproduce: nnoodle> $ echo 'GIF89a;' > bad.gif nnoodle> $ emacs -Q bad.gif nnoodle> The result will be a segmentation fault. This should fix it, can you test it? Thanks Robert diff --git a/src/image.c b/src/image.c index d8c34669cc..6e3b71a869 100644 --- a/src/image.c +++ b/src/image.c @@ -8251,7 +8251,7 @@ gif_load (struct frame *f, struct image *img) Lisp_Object specified_file = image_spec_value (img->spec, QCfile, NULL); Lisp_Object specified_data = image_spec_value (img->spec, QCdata, NULL); EMACS_INT idx; - int gif_err; + int gif_err = 0; if (NILP (specified_data)) { @@ -8277,7 +8277,8 @@ gif_load (struct frame *f, struct image *img) { #if HAVE_GIFERRORSTRING image_error ("Cannot open `%s': %s", - file, build_string (GifErrorString (gif_err))); + file, gif_err ? build_string (GifErrorString (gif_err)) + : build_string ("Unknown error from gif library")); #else image_error ("Cannot open `%s'", file); #endif From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 05:40:58 2020 Received: (at control) by debbugs.gnu.org; 9 Sep 2020 09:40:58 +0000 Received: from localhost ([127.0.0.1]:57196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFwb4-00011W-9V for submit@debbugs.gnu.org; Wed, 09 Sep 2020 05:40:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFwb2-00011H-9j for control@debbugs.gnu.org; Wed, 09 Sep 2020 05:40:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vfe6UnzPKoYbRziqO9bdPxduPpqzErxQPtuL1WJnoVo=; b=ueYqpn8Iz+FfOj/gL3sfhfJZjt 5a4LMWXyIUWXYSiVo83VpdM1B0k4mhvX7u9g1+XUqaJCEMeF7GS8b2CW9IUJeXJIjWIMuV1nZjFyI 2G06wBQqW3wkrzE1mWhlWO6I7YDwdsuXdkVk5BlckKUQ9QKXGYXwArLdRGY495mfwnWw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFwau-0007TS-8j for control@debbugs.gnu.org; Wed, 09 Sep 2020 11:40:50 +0200 Date: Wed, 09 Sep 2020 11:40:47 +0200 Message-Id: <87zh5zffts.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43281 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43281 fixed close 43281 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43281 fixed close 43281 28.1 quit