Subject: bug#43274: fdisk fails to build on armhf

From: Andreas Enge <[email-masked]>
Date: Tue, 8 Sep 2020 23:00:56 +0200

Hello Timotej,

On Tue, Sep 08, 2020 at 07:50:58PM +0200, Timotej Lazar wrote:
> genimage tests fail on arm64 due to differently signed char. The fix¹
> is in upstream master but has not been released yet. Maybe we can add
> it to the current Guix package until then?
> ¹ https://github.com/pengutronix/genimage/commit/f4524ddc

great, thanks a lot! I applied and pushed this patch, and dropped fdisk
from the inputs. I am happy to report that genimage now builds on all
our four architectures, instead of just x86_64.

So, do we drop fdisk, which now is a leaf package?

Also, I tried updating genimage to version 12, but there is still a test
failure even on x86_64:
   FAIL: test/basic-images.test 7 - mke2fs
Here is the diff of the test:
--- /tmp/guix-build-genimage-12.drv-0/genimage-12-checkout/test/mke2fs.dump     2020-09-08 20:57:40.650216225 +0000
+++ dump        2020-09-08 20:57:47.962216531 +0000
@@ -11,7 +11,7 @@
 Inode count:              8192
 Block count:              32768
 Reserved block count:     1638
-Free blocks:              27592
+Free blocks:              27590
 Free inodes:              8141
 First block:              1
 Block size:               1024
@@ -29,7 +29,7 @@
 Maximum mount count:      -1
 Last checked:             Sat Jan  1 00:00:00 2000
 Check interval:           0 (<none>)
-Lifetime writes:          123 kB
+Lifetime writes:          125 kB
 Reserved blocks uid:      0 (user unknown)
 Reserved blocks gid:      0 (group unknown)
 First inode:              11
@@ -47,13 +47,13 @@
 Journal start:            0

-Group 0: (Blocks 1-8192) csum 0x62cb [ITABLE_ZEROED]
+Group 0: (Blocks 1-8192) csum 0xe083 [ITABLE_ZEROED]
   Primary superblock at 1, Group descriptors at 2-2
++ func_check
-  Block bitmap at 3 (+2), csum 0xb4967804
+  Block bitmap at 3 (+2), csum 0x0fddd371
   Inode bitmap at 7 (+6), csum 0xb1052088
   Inode table at 11-266 (+10)
-  7117 free blocks, 1997 free inodes, 18 directories, 1997 unused inodes
-  Free blocks: 1076-8192
+  7115 free blocks, 1997 free inodes, 18 directories, 1997 unused inodes
+  Free blocks: 1078-8192
   Free inodes: 52-2048
++ local ret=1
 Group 1: (Blocks 8193-16384) csum 0x7d4b [INODE_UNINIT, BLOCK_UNINIT, ITABLE_ZEROED]
++ set +x
Failed to execute 'check_ext'!
   Backup superblock at 8193, Group descriptors at 8194-8194
not ok 7 - mke2fs
FAIL: test/basic-images.test 7 - mke2fs

Andreas