From unknown Sat Aug 16 20:58:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43261 <43261@debbugs.gnu.org> To: bug#43261 <43261@debbugs.gnu.org> Subject: Status: [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options Reply-To: bug#43261 <43261@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:58:40 +0000 retitle 43261 [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' opti= ons reassign 43261 guix-patches submitter 43261 zimoun severity 43261 normal tag 43261 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 14:02:57 2020 Received: (at submit) by debbugs.gnu.org; 7 Sep 2020 18:02:57 +0000 Received: from localhost ([127.0.0.1]:50778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLTk-0001JR-Py for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:02:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:38160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLTj-0001JJ-00 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:02:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFLTi-0002pp-QY for guix-patches@gnu.org; Mon, 07 Sep 2020 14:02:54 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:41494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFLTh-0002BR-8E for guix-patches@gnu.org; Mon, 07 Sep 2020 14:02:54 -0400 Received: by mail-wr1-x431.google.com with SMTP id w5so16619634wrp.8 for ; Mon, 07 Sep 2020 11:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Do2XwWA7UicSCEYd2uH680JGcJY/QKZdjyOSwIOigpM=; b=bShEnn3G/XXZDtWR3cdvShPSUvA60AIhB5AdkMZxRBF/FSGY3654Vb8lJfA5nEuoiY C6F4zHCPGwMkhWI06fRzZo46YVGN4nNjGtAQNEloF4ZCelpY2tmeiQhOBUlnTS5i8h+0 1YHQiNpFn1Qpej42/udjZiyOYc2NL802JviBPLrrQWOKslkrodp85er/poMajcW9JmOG SZoZpTjizQFU4wJERvRMh1RqWqoQfO+1lGcKxyN1AqxVxUT9VgGLshS5yb7KNGAfRwNe o1uY4Q2UoV/xzvWR+WyOx1/PWkfrOoKX3E4snv+lEKvg5VxZcRgy0/7YDHYuD41cjI8R itXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Do2XwWA7UicSCEYd2uH680JGcJY/QKZdjyOSwIOigpM=; b=MYL+8JMYAAc+UiVOtPliiXpHRFywthDlJd16ZpipMhhWYf/e4lqDQbOXtxE+h80blv hdATJJtl7SiSvpI/l5fLfBqZ8A92vJnDGlWEkvutKGkT6kP2uFaAdXY82mDF7oKTPiSD yEMuvTd73EBDY+Nao39qvZOeHX2DABTem3IUQIeMOJj5cQJMJALmIj8YuCc8PBfjGrDq lHEsRZJqKWv81kmLwMiZjK5vWCWzbjsZUkfZz6YpEnmSISW9AIKxsWRsJP8VB0/2iCxo +HS0p+iCIYVH7xMQLThmCbTnX9v4DD3W6/in09lKnT/oQ7XTRp0FosxjCrHcA6wC+WCY NCjg== X-Gm-Message-State: AOAM531FTpc3auiiqlBUp3nzRh2sg7ygQAWgZRE8d0vR7/K7AelDsFFm S5RaZYFm5mDsUsaIgDWjZRJkYnedJUw= X-Google-Smtp-Source: ABdhPJwzCllSo2buU/h7Dx6pmMa08+WjXFSF3vHz/KikO2mFVnbucZT6AJCMD3HeGAw7xcBWdewlMw== X-Received: by 2002:adf:91e1:: with SMTP id 88mr22181979wri.305.1599501771109; Mon, 07 Sep 2020 11:02:51 -0700 (PDT) Received: from pfiuh02.univ-paris-diderot.fr ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id 59sm9703052wro.82.2020.09.07.11.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 11:02:50 -0700 (PDT) From: zimoun To: guix-patches@gnu.org Subject: [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options Date: Mon, 7 Sep 2020 20:02:29 +0200 Message-Id: <20200907180229.29475-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x431.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Dear, The first patch fixes the unexpected behaviour of "guix lint": guix lint -c description -n vs guix lint -n -c description Now, if '--no-network' and any checkers are provided using '--checkers' then the ones requiring Internet access are turned off. The second patch adds the '--no-checkers' option discussed some time ago. I am not convinced by the 'option-checker' helper function. What could be better? Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. Last, note that '--list-checkers' operates as a dry-run: --8<---------------cut here---------------start------------->8--- ./pre-inst-env guix lint -c description,formatting,synopsis -n -x description -l Available checkers: - formatting: Look for formatting issues in the source --8<---------------cut here---------------end--------------->8--- All the best, simon zimoun (2): lint: Fix '--no-network' option. lint: Add '--no-checkers' option. doc/guix.texi | 9 +++++++ guix/scripts/lint.scm | 55 +++++++++++++++++++++++++++---------------- 2 files changed, 44 insertions(+), 20 deletions(-) base-commit: 89e1e4481382d18033a9773b90c09345fa33d6cb -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 14:04:27 2020 Received: (at 43261) by debbugs.gnu.org; 7 Sep 2020 18:04:27 +0000 Received: from localhost ([127.0.0.1]:50784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLVD-0001MQ-6e for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:04:27 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:46949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLVA-0001M6-8m for 43261@debbugs.gnu.org; Mon, 07 Sep 2020 14:04:25 -0400 Received: by mail-wr1-f51.google.com with SMTP id o5so16584409wrn.13 for <43261@debbugs.gnu.org>; Mon, 07 Sep 2020 11:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TqJpf9ZCl7ZusvCtIL8lnD8WVlsfz9Wzym0ncMqmpW8=; b=RjkqbHTpi4BSHW37RHplcsBUmDCQCnYPUVh4Vmx5HVHdFxU4RtGg2vYa9AnHJNdqAX Eo5vIjLZw27hQ4k+Qe2jzTcz9NtmOotb9Vt98tJhtsg3KCPhZ5fynJ9dy2kFE8xpiiW0 ShAsu8SLJECoaLKuQv4WQ1pcZ5PFG6X2Iwishm9nmTIuSTpcwFsUreqPYqxIalpfSM2B AGfc4MwEoHNyhzQVsQAvQgPsHCnafhZWXtTZRN8wbWJO6gW4gXxYYytXdPHrtwk5F71g XhpNwXu/Kr0Yee7if5Fk7d4Sr7neYAe7Qq92yDi4P01y3L4zNlGPBd2RgT/4ObNVJlXY YLtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TqJpf9ZCl7ZusvCtIL8lnD8WVlsfz9Wzym0ncMqmpW8=; b=HCU7A9N5tl2qWI4FyJja6SqHJyf0hhIVD1wDBNncl0wrgjYab7hYD/Yz2bA0XLZ/ut oexrR/HaiItn+BpAKrukJnRFbZhbU4TCkbgmMtoX/EtrhSJ1I/IUJNx7Tzf1Wf8lVt0W gv1z7oVLUogCHYvABIytggPFybbQ3HhaWrcC4OAaDqTgh1IDkKnCoZwXsI9Rgi+0dN4b bU2LVS67F+mvZ6CBCiXJceDTEtWsvuLmY1EdKdPzOyK0JNhOZuqmFOcvIr870Gqf6lwT TaGP69l3QfYN/vEW8MgXqgr60/Bm9OvZnUmDz7ncT1ehRCteeAg3qOFzyUIQ0KGs66al FFoQ== X-Gm-Message-State: AOAM530C4A7bcdeUDnJOpmaL8cKM9pipMKmF1Q2eyRtCAsFmYNZVlp0y Y3PbFaFx0HuLZhCnJAMuf+WO5Mxnob4= X-Google-Smtp-Source: ABdhPJxvekgFiJpDffGZ5J8aN0w2x88f4M+bCwrZpXaajzraokhTaBAaZzlaEV0QViBxOpSlOrABkg== X-Received: by 2002:a5d:69c2:: with SMTP id s2mr22797082wrw.389.1599501858058; Mon, 07 Sep 2020 11:04:18 -0700 (PDT) Received: from pfiuh02.univ-paris-diderot.fr ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id u126sm35778838wmu.9.2020.09.07.11.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 11:04:17 -0700 (PDT) From: zimoun To: 43261@debbugs.gnu.org Subject: [PATCH 1/2] lint: Fix '--no-network' option. Date: Mon, 7 Sep 2020 20:04:14 +0200 Message-Id: <20200907180415.30140-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/lint.scm: (show-help): Add '--no-network' option message. (%options, parse-options): Fix argument order. * doc/guix.texi: Document it. --- doc/guix.texi | 4 ++++ guix/scripts/lint.scm | 18 ++++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index f224e356bc..ea2aa1581e 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -10632,6 +10632,10 @@ and exit. Only enable the checkers specified in a comma-separated list using the names returned by @option{--list-checkers}. +@item --no-network +@itemx -n +Only enable the checkers which do not dependent on Internet access. + @item --load-path=@var{directory} @itemx -L @var{directory} Add @var{directory} to the front of the package module search path diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 5168a1ca17..c56576fcbd 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -9,7 +9,7 @@ ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2017, 2018 Efraim Flashner ;;; Copyright © 2018, 2019 Arun Isaac -;;; Copyright © 2019 Simon Tournier +;;; Copyright © 2019, 2020 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -98,6 +98,9 @@ run the checkers on all packages.\n")) (display (G_ " -c, --checkers=CHECKER1,CHECKER2... only run the specified checkers")) + (display (G_ " + -n, --no-network only run checkers which do not access to network")) + (display (G_ " -L, --load-path=DIR prepend DIR to the package module search path")) (newline) @@ -132,10 +135,7 @@ run the checkers on all packages.\n")) result)))) (option '(#\n "no-network") #f #f (lambda (opt name arg result) - (alist-cons 'checkers - %local-checkers - (alist-delete 'checkers - result)))) + (alist-cons 'no-network? #t result))) (find (lambda (option) (member "load-path" (option-names option))) %standard-build-options) @@ -169,7 +169,13 @@ run the checkers on all packages.\n")) value) (_ #f)) (reverse opts))) - (checkers (or (assoc-ref opts 'checkers) %all-checkers))) + (the-checkers (or (assoc-ref opts 'checkers) %all-checkers)) + (checkers + (if (assoc-ref opts 'no-network?) + (filter (lambda (checker) + (member checker %local-checkers)) + the-checkers) + the-checkers))) (when (assoc-ref opts 'list?) (list-checkers-and-exit checkers)) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 14:04:29 2020 Received: (at 43261) by debbugs.gnu.org; 7 Sep 2020 18:04:29 +0000 Received: from localhost ([127.0.0.1]:50786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLVF-0001MZ-HT for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:04:29 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:43502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLVC-0001M9-FJ for 43261@debbugs.gnu.org; Mon, 07 Sep 2020 14:04:26 -0400 Received: by mail-wr1-f42.google.com with SMTP id k15so16586317wrn.10 for <43261@debbugs.gnu.org>; Mon, 07 Sep 2020 11:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0+gBuyxHRQR/4An91U5JdjYh2yhy0EhPtR0Wm9zPOKw=; b=pSJlKt3vfMKnuFJnRkG7dtuKUf8Ki7l93ea+q3xUGlpxwv7vZbZGQNnovHW/jp8zVV a1VLMTNysUHU/maCV0ky/x3Pu6i+FH+mLjyLKwwYd8vEi/CWXtWc5c9GtblPLZWnuq+A MjLiOG8WMe7GZg5kwg5Dg8qCNZ+htou7SKUkrkfIy/VrQC01aRTC//YcegT5bLwYGkpy gBaUY8rhCLTzH3DGEklJukC7HmBiYK4cIw58KtCkxJ4s0NyL1pF7tuebSF10uq0hDxD8 jfu9709eV/kC5SJrTRgVKYpObjnV/gZLRGD1TH5OfD/Xl7RtJK5yeV76vmduzO4ChKYA 6iiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0+gBuyxHRQR/4An91U5JdjYh2yhy0EhPtR0Wm9zPOKw=; b=GbzqiNe2evTJx+/YZXu+AnmSbhngUJ/ythxw+T6NWTY5ZwLr5cOrmwJUkJrR6Sxisk wgjg9SnQ+rto+BGLv5yxijkN4QwnZn6KDHFgvZe439GR2+gKCXKme3IWkYbE1neOYqLG O9IMuu4pZQux32Z7xzahl8KwsgRlxaTav7kFvNEornbI/08bgqxjUzmpaU/BhnG7YwCM 5hxzpa4JP3kD+dPXG74z12s2S2eIQTztA/9WCEmE1aOzEdLhbH5wjl9ZEl4zywjlOYgt bDcB9L5fLMSWG7x1Y0ZZE5XpeZ1lgNB2g9rPQiF5MYzFhMbuE5X4zSXtOvJKqvaojuvA jmBw== X-Gm-Message-State: AOAM5337pL95olA9s2q6PuKOMmuzJSm8ITN0rhhMyLLnRQxXW0j7sylH 7coYfXbM3wG9pKjK1Tq4ntOjCoXn790= X-Google-Smtp-Source: ABdhPJx+lYLXfl2RcUkG3TeHrKaLqLfv7zFUDkM3pWkkrqG86LzxlMQJ720Z08nY/6Wt+ltEFyKYtw== X-Received: by 2002:a5d:4246:: with SMTP id s6mr22465498wrr.414.1599501860639; Mon, 07 Sep 2020 11:04:20 -0700 (PDT) Received: from pfiuh02.univ-paris-diderot.fr ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id u126sm35778838wmu.9.2020.09.07.11.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 11:04:20 -0700 (PDT) From: zimoun To: 43261@debbugs.gnu.org Subject: [PATCH 2/2] lint: Add '--no-checkers' option. Date: Mon, 7 Sep 2020 20:04:15 +0200 Message-Id: <20200907180415.30140-2-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907180415.30140-1-zimon.toutoune@gmail.com> References: <20200907180415.30140-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/lint.scm (%options, parse-options): Add '--no-checkers' option. * doc/guix.texi: Document it. --- doc/guix.texi | 5 +++++ guix/scripts/lint.scm | 39 ++++++++++++++++++++++++--------------- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index ea2aa1581e..bcc6fe8324 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -10632,6 +10632,11 @@ and exit. Only enable the checkers specified in a comma-separated list using the names returned by @option{--list-checkers}. +@item --no-checkers +@itemx -x +Only disable the checkers specified in a comma-separated list using the +names returned by @option{--list-checkers}. + @item --no-network @itemx -n Only enable the checkers which do not dependent on Internet access. diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index c56576fcbd..0007e18bcd 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -99,6 +99,9 @@ run the checkers on all packages.\n")) -c, --checkers=CHECKER1,CHECKER2... only run the specified checkers")) (display (G_ " + -x, --no-checkers=CHECKER1,CHECKER2... + exclude the specified checkers")) + (display (G_ " -n, --no-network only run checkers which do not access to network")) (display (G_ " @@ -113,26 +116,29 @@ run the checkers on all packages.\n")) (newline) (show-bug-report-information)) +(define (option-checker short-long) + (option short-long #t #f + (lambda (opt name arg result) + (let ((names (map string->symbol (string-split arg #\,))) + (checker-names (map lint-checker-name %all-checkers))) + (for-each (lambda (c) + (unless (memq c checker-names) + (leave (G_ "~a: invalid checker~%") c))) + names) + (alist-cons (string->symbol (cadr short-long)) + (filter (lambda (checker) + (member (lint-checker-name checker) + names)) + %all-checkers) + result))))) (define %options ;; Specification of the command-line options. ;; TODO: add some options: ;; * --certainty=[low,medium,high]: only run checkers that have at least this ;; 'certainty'. - (list (option '(#\c "checkers") #t #f - (lambda (opt name arg result) - (let ((names (map string->symbol (string-split arg #\,))) - (checker-names (map lint-checker-name %all-checkers))) - (for-each (lambda (c) - (unless (memq c checker-names) - (leave (G_ "~a: invalid checker~%") c))) - names) - (alist-cons 'checkers - (filter (lambda (checker) - (member (lint-checker-name checker) - names)) - %all-checkers) - result)))) + (list (option-checker '(#\c "checkers")) + (option-checker '(#\x "no-checkers")) (option '(#\n "no-network") #f #f (lambda (opt name arg result) (alist-cons 'no-network? #t result))) @@ -169,7 +175,10 @@ run the checkers on all packages.\n")) value) (_ #f)) (reverse opts))) - (the-checkers (or (assoc-ref opts 'checkers) %all-checkers)) + (no-checkers (or (assoc-ref opts 'no-checkers) '())) + (the-checkers (filter (lambda (checker) + (not (member checker no-checkers))) + (or (assoc-ref opts 'checkers) %all-checkers))) (checkers (if (assoc-ref opts 'no-network?) (filter (lambda (checker) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 03:57:18 2020 Received: (at 43261) by debbugs.gnu.org; 8 Sep 2020 07:57:18 +0000 Received: from localhost ([127.0.0.1]:51775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFYVC-0003UV-Cc for submit@debbugs.gnu.org; Tue, 08 Sep 2020 03:57:18 -0400 Received: from flashner.co.il ([178.62.234.194]:42682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFYVA-0003UG-CS for 43261@debbugs.gnu.org; Tue, 08 Sep 2020 03:57:17 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id 9D4544034D; Tue, 8 Sep 2020 07:57:09 +0000 (UTC) Date: Tue, 8 Sep 2020 10:56:36 +0300 From: Efraim Flashner To: zimoun Subject: Re: [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options Message-ID: <20200908075636.GF1643@E5400> References: <20200907180229.29475-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pql/uPZNXIm1JCle" Content-Disposition: inline In-Reply-To: <20200907180229.29475-1-zimon.toutoune@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: 43261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Pql/uPZNXIm1JCle Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 07, 2020 at 08:02:29PM +0200, zimoun wrote: > Dear, >=20 > The first patch fixes the unexpected behaviour of "guix lint": >=20 > guix lint -c description -n > vs > guix lint -n -c description >=20 > Now, if '--no-network' and any checkers are provided using '--checkers' t= hen > the ones requiring Internet access are turned off. >=20 I was going to say I didn't like the '-n' flag but I see it's already there, just not documented in the help message. >=20 > The second patch adds the '--no-checkers' option discussed some time ago.= I > am not convinced by the 'option-checker' helper function. What could be > better? >=20 > Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. >=20 how about '--skip' >=20 > Last, note that '--list-checkers' operates as a dry-run: >=20 > --8<---------------cut here---------------start------------->8--- > ./pre-inst-env guix lint -c description,formatting,synopsis -n -x descrip= tion -l > Available checkers: > - formatting: Look for formatting issues in the source > --8<---------------cut here---------------end--------------->8--- >=20 >=20 > All the best, > simon >=20 > zimoun (2): > lint: Fix '--no-network' option. > lint: Add '--no-checkers' option. >=20 > doc/guix.texi | 9 +++++++ > guix/scripts/lint.scm | 55 +++++++++++++++++++++++++++---------------- > 2 files changed, 44 insertions(+), 20 deletions(-) >=20 >=20 > base-commit: 89e1e4481382d18033a9773b90c09345fa33d6cb > --=20 > 2.28.0 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Pql/uPZNXIm1JCle Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9XOTQACgkQQarn3Mo9 g1EpkxAArAlR8q/hLeSzsAbRmHG/eaYB+VuUYB2f3k03r30te3Q4W5+2BaBpO8B8 YFkHSyxtq1OOtmy1mhXHyzd/+QEbkkzFPETXk4P6qKAXtEbS18jTaSTV50ladt0V runmhZ9JbL7sPcqdiIsTHmO/SNOUN0AuM8XzxViv/VnyEccSCFMoGurFSm/Bz0gR F4Lpjr9tkUUrXw2XsV6bGxFcvIrtSsu1pUVdDF08VF5V4cum4RKIqwxJbksXDMXh PNbsPOp6sfUXLhcZ0e38XaSu6T9nK3Bh0wNOblwtpUrYvCFVRmAp4CG/S5CW/mpc 86SVfKo4Yruvp53w4z1/1LPjQmE8rBpJVn2I802iI21Po2DpjoPqIjc62breFxK/ LoKnhHjnfL0oP/LTuhaTp29B8FkOyPR7lIK2zgPscpfS6UVtpJRglr4QhKBNXgG0 va0raIxmh6m1Ef4FZFEzsKl0Ger176HQ/sjwvtqEw8e73IqKU/Mp43YtLH/SNAdC FgvZvpGUtKy94LXtfkj0iCfrKdwU7X6ZOyPkHhkdD0EYy4UycPMLWo1Rx/4HTdOy zbW9I+a7Rb+Kyzj5EZ4YMxKIqg43xRzOS/vdUYsUKMFwvUS/EOTqtGXqlN2JDw55 AyNBajhaoRrl6+5jTfqZDR6B0Ir/vDkUeu63/bWKhfQHV2xB1E0= =c/4w -----END PGP SIGNATURE----- --Pql/uPZNXIm1JCle-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 05:17:13 2020 Received: (at 43261) by debbugs.gnu.org; 8 Sep 2020 09:17:13 +0000 Received: from localhost ([127.0.0.1]:51966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZkW-0005W1-QY for submit@debbugs.gnu.org; Tue, 08 Sep 2020 05:17:12 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZkW-0005Vp-12 for 43261@debbugs.gnu.org; Tue, 08 Sep 2020 05:17:12 -0400 Received: by mail-qv1-f65.google.com with SMTP id di5so7404196qvb.13 for <43261@debbugs.gnu.org>; Tue, 08 Sep 2020 02:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=exGgAad0iw2ekmdBJnCP6C91XqJv6Ym3deM3O3QnFkk=; b=jpZLi5fbIgWoCCc9Yl7S9NKZZ9yRirKRjVDKuCHp4U7+Ag83LWGLCp7EdpNeG8v8Vp fMJGOhNAyYMdYbVPDSUT2BcZKXVGB3ArFnilf19Dxlp48yuqShGZYc6/YR45YzAmD13Q u2ZCnj6ydD2Iir0Qt3IF9CT6z+xNIXnjjguHIaiiQSbkD6Cf4387BdrSEerP2iOj6mps /GfqdJS9RBM0xqaQczfkye7sbhjBvp7QCueTjJz9gPVd7EcMEYo1hwIZWCt0i3VlxGFJ +UZ3uUI7KdvR1MnMlFZvIJThDNwiX08xtUSHrs1v1g4+CTv1NOUlvx67tZCnTFOfD0Zw GtXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=exGgAad0iw2ekmdBJnCP6C91XqJv6Ym3deM3O3QnFkk=; b=AuPMl+v5IObnK2DNvniV+rw+2RPnrsbtKn2GltA+/VaKLZwzMQFwsEURNDPn+gPIK/ YBTFLxAjBlUcIUJIcGtcybflg0Sne1cWXmzPPIfoeIla3fo1ssNrunvtWfmFvkWMSQzQ ENTaN2ewMnjWFpgaloAivtT6zvpT52tib3psa3wSb2HxeNud/yfDPqamRBgeNdCL1rZ1 pQwISiGBa5VECucBPWewCDAurjx9Nf6ibikO+v5l9xLGna7Q3o7dqshOhXd6ZfhMC4Rz Ay3JEr7n0FiOj3QjNG+F+qxjUh2NqRcYO7PuxntHAs3XRA5Zj15aZc18o9F3Vqv6Ujur 8wOA== X-Gm-Message-State: AOAM530elULfv9q8czNDJ/cV4KqDkdFCgppQ2LaF2yoWzdQRQuH/rNfx vO/ve6t/IBiWT020WgrB3Yi5Dg1Jyj/NcDA/XY2wwCh/ X-Google-Smtp-Source: ABdhPJwcnUbe6YBNV1s0lmGKYEbdkSRw3PrC2dQdNOu9OS8zryAe6O7PaBkKPbf2kk691Fu2/xpy6om4TbVYDY+6Xcw= X-Received: by 2002:a0c:cc13:: with SMTP id r19mr12977623qvk.15.1599556626547; Tue, 08 Sep 2020 02:17:06 -0700 (PDT) MIME-Version: 1.0 References: <20200907180229.29475-1-zimon.toutoune@gmail.com> <20200908075636.GF1643@E5400> In-Reply-To: <20200908075636.GF1643@E5400> From: zimoun Date: Tue, 8 Sep 2020 11:16:55 +0200 Message-ID: Subject: Re: [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options To: Efraim Flashner Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: 43261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) HI Efraim, Thank you for the feedback. On Tue, 8 Sep 2020 at 09:57, Efraim Flashner wrote: > I was going to say I didn't like the '-n' flag but I see it's already > there, just not documented in the help message. Me neither. Since it is still undocumented, maybe we could change the short name. Well, I do not have a strong opinion. > > The second patch adds the '--no-checkers' option discussed some time ago. I > > am not convinced by the 'option-checker' helper function. What could be > > better? > > > > Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. > > how about '--skip' With the short name '-s' or still '-x' ? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 09 16:39:13 2020 Received: (at 43261) by debbugs.gnu.org; 9 Oct 2020 20:39:13 +0000 Received: from localhost ([127.0.0.1]:36368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQzAW-0000PQ-T5 for submit@debbugs.gnu.org; Fri, 09 Oct 2020 16:39:13 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQzAT-0000PC-L0 for 43261@debbugs.gnu.org; Fri, 09 Oct 2020 16:39:10 -0400 Received: by mail-wm1-f67.google.com with SMTP id k18so11035407wmj.5 for <43261@debbugs.gnu.org>; Fri, 09 Oct 2020 13:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=7ZFB3c4LLuxraVK3YaT4WpC2ZGdHRK339dnZRMJNcQQ=; b=CcXWOOZVk4PGGHq7fjZjcuDEqOfcaH5cMx9eaQ0EwlYDUbA7KmUqwqxlgP5vwHRFda OHtGxu9tVma8v3Ye6v9MkkUJKCv8lZBt0hEgaeksMzUiOjOI1AaJJv0XcSTEPgJEj0Ei aRKAhS0EM2mvBftW6bycP0dnhDSRS5VgLTry1F0Dtjwor/ehG0cXiK2t/4EOz81KN3aI PfKG7T0LzEVTBmasn3RHFwmFvAfkrBOfpzInOg8IVFrKQT79KmHv4oqwf9mY05uP/yF8 FLCl76cFWbcnXsVDvfZwXVtsCCPusX0C1jAhopkdPlflvquAySOWdRHRi4I2m4v6X9oR Rdkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7ZFB3c4LLuxraVK3YaT4WpC2ZGdHRK339dnZRMJNcQQ=; b=POGibUgqzb55vilZtRqcxAGRtEBSf08/e1G7D726VPyYMCMfcY/ERQD5/Dw3wPYDbF 9q9Vgy7Ok9LafpJexBQQTfv9ArTkUa1gk0D4Uy1XRJLbUeHfKhDwKuqA8BowwFfl/+3Q r/UUKSglCh66JXv/sfLzmbBBtgPQqxBdeYkq8bvhjhsSZoeUdzM4VWehG81EGZTYbi2X 5D8klQmfaaOTuw1HLDWA3lrH4fBsmF5Lrb8I9YaUC1xUmb/zv/He1FROJoQSSRABuuXr 0I+ZL+JER1pYB65jLb/4VchNgB59a5p7nVlzsHXQtfpkedUJP3GDyCpsKF8wQQs8Hj64 4zPA== X-Gm-Message-State: AOAM53358kbC1JZx3lGfcVj0Xa+yt2Lf3DdC3TzJqcJ4JrgIdkY5MfQF Vke7SqKjg/G+hvKz7PpwrLRjZ1j1gag= X-Google-Smtp-Source: ABdhPJytJLaxDOofMv03N1xj0Q0kjRGRj4nwjz/gRaJaYvrCCWCNiRNtBGiGkON0332l+KtII69W1A== X-Received: by 2002:a7b:c148:: with SMTP id z8mr15677102wmi.135.1602275943379; Fri, 09 Oct 2020 13:39:03 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id p4sm7957688wrf.67.2020.10.09.13.39.02 for <43261@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 13:39:03 -0700 (PDT) From: zimoun To: 43261@debbugs.gnu.org Subject: Re: [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options References: <20200907180229.29475-1-zimon.toutoune@gmail.com> Date: Fri, 09 Oct 2020 22:39:01 +0200 In-Reply-To: <20200907180229.29475-1-zimon.toutoune@gmail.com> (zimoun's message of "Mon, 7 Sep 2020 20:02:29 +0200") Message-ID: <86ft6nqgm2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) friendly ping On Mon, 07 Sep 2020 at 20:02, zimoun wrote: > Dear, > > The first patch fixes the unexpected behaviour of "guix lint": > > guix lint -c description -n > vs > guix lint -n -c description > > Now, if '--no-network' and any checkers are provided using '--checkers' then > the ones requiring Internet access are turned off. > > > The second patch adds the '--no-checkers' option discussed some time ago. I > am not convinced by the 'option-checker' helper function. What could be > better? > > Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. > > > Last, note that '--list-checkers' operates as a dry-run: > > ./pre-inst-env guix lint -c description,formatting,synopsis -n -x description -l > Available checkers: > - formatting: Look for formatting issues in the source > > > All the best, > simon > > zimoun (2): > lint: Fix '--no-network' option. > lint: Add '--no-checkers' option. > > doc/guix.texi | 9 +++++++ > guix/scripts/lint.scm | 55 +++++++++++++++++++++++++++---------------- > 2 files changed, 44 insertions(+), 20 deletions(-) > > > base-commit: 89e1e4481382d18033a9773b90c09345fa33d6cb From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 11:14:09 2020 Received: (at 43261) by debbugs.gnu.org; 28 Oct 2020 15:14:09 +0000 Received: from localhost ([127.0.0.1]:50136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXn9N-0002LM-8I for submit@debbugs.gnu.org; Wed, 28 Oct 2020 11:14:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXn9L-0002Ky-37 for 43261@debbugs.gnu.org; Wed, 28 Oct 2020 11:14:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46035) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXn9F-0005gu-Oz; Wed, 28 Oct 2020 11:14:01 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44636 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kXn9F-0003GZ-2Q; Wed, 28 Oct 2020 11:14:01 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options References: <20200907180229.29475-1-zimon.toutoune@gmail.com> <20200908075636.GF1643@E5400> Date: Wed, 28 Oct 2020 16:13:59 +0100 In-Reply-To: <20200908075636.GF1643@E5400> (Efraim Flashner's message of "Tue, 8 Sep 2020 10:56:36 +0300") Message-ID: <87h7qe1iyw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43261 Cc: 43261@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Efraim Flashner skribis: > On Mon, Sep 07, 2020 at 08:02:29PM +0200, zimoun wrote: [...] >> The second patch adds the '--no-checkers' option discussed some time ago= . I >> am not convinced by the 'option-checker' helper function. What could be >> better? >>=20 >> Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. >>=20 > > how about '--skip' I=E2=80=99d suggest =E2=80=98--exclude=E2=80=99 + =E2=80=98-x=E2=80=99, whi= ch is similar to what =E2=80=98guix hash=E2=80=99 does for instance. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 11:18:30 2020 Received: (at 43261) by debbugs.gnu.org; 28 Oct 2020 15:18:31 +0000 Received: from localhost ([127.0.0.1]:50150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXnDa-0002Sk-EQ for submit@debbugs.gnu.org; Wed, 28 Oct 2020 11:18:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXnDY-0002SZ-IB for 43261@debbugs.gnu.org; Wed, 28 Oct 2020 11:18:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46152) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXnDT-0006Hu-04; Wed, 28 Oct 2020 11:18:23 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44638 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kXnDK-0003dZ-SE; Wed, 28 Oct 2020 11:18:22 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#43261] [PATCH 2/2] lint: Add '--no-checkers' option. References: <20200907180415.30140-1-zimon.toutoune@gmail.com> <20200907180415.30140-2-zimon.toutoune@gmail.com> Date: Wed, 28 Oct 2020 16:18:13 +0100 In-Reply-To: <20200907180415.30140-2-zimon.toutoune@gmail.com> (zimoun's message of "Mon, 7 Sep 2020 20:04:15 +0200") Message-ID: <87d0121iru.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43261 Cc: 43261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, zimoun skribis: > * guix/scripts/lint.scm (%options, parse-options): Add '--no-checkers' op= tion. > * doc/guix.texi: Document it. Please mention the section name (in the manual) and variable names. > +(define (option-checker short-long) > + (option short-long #t #f Indentation is off. Also please add a docstring. > + (lambda (opt name arg result) > + (let ((names (map string->symbol (string-split arg #\,))) > + (checker-names (map lint-checker-name %all-checkers)= )) > + (for-each (lambda (c) > + (unless (memq c checker-names) > + (leave (G_ "~a: invalid checker~%") c))) > + names) > + (alist-cons (string->symbol (cadr short-long)) Use =E2=80=98match=E2=80=99 instead of =E2=80=98cadr=E2=80=99, or maybe mak= e it a parameter of this procedure? Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 12:51:29 2020 Received: (at 43261) by debbugs.gnu.org; 28 Oct 2020 16:51:29 +0000 Received: from localhost ([127.0.0.1]:50387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXofZ-0004yz-3x for submit@debbugs.gnu.org; Wed, 28 Oct 2020 12:51:29 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:33037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXofW-0004yd-U7 for 43261@debbugs.gnu.org; Wed, 28 Oct 2020 12:51:28 -0400 Received: by mail-wr1-f47.google.com with SMTP id b8so6488258wrn.0 for <43261@debbugs.gnu.org>; Wed, 28 Oct 2020 09:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cHH8s23wTNCPGK2CbwHM4rOyLtc7Hm8Pz25od2Hcdk4=; b=WPD8gjp01v3qSyLchrFQgYyAUUk3K2h94pCMmaCvLLUsmRdWsgEXeJiECIrixDxbaa OxJRpsYu5A7AbSPxJPb3aMDCHgWnUwYZA94tipPAn/ATkk5Vs6dlk7ok5oAY6TSvs3s9 ho3OReYjnbv1wWYDJTk1Pa2aVX2Y5WhlZszIyH/4Slx2JeDdwtaB7JeLamalEYQbis3N AciXPa3f1d42ohvqy3ZfKhic1pRSPJ+By9CI7LIUmdiko7UkHWZISEBLbii47YqYn4hh o++9/ARghNRDnsEpIAxmcr9jU4Wq4b/BXghxf+yI0Gprzz0I+bSxOeuh+oLBAX9CWTfX tZSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cHH8s23wTNCPGK2CbwHM4rOyLtc7Hm8Pz25od2Hcdk4=; b=Km+262Eb1G5ohcRv399v2i86Krs7fJIGmEnK7aOmjIiMVi/WIbvJpfPGgfphs7Ab7P hFvzSQBxL833/tLsrsQ1lH+44w4Abcp1JkKQ7C0ZVtao5radVQLPqED5yoXg6hBnyq6O Vg+85lv2sWFZpruvtVnpY1hakIaaJBW+COYRj4dGFvn/TtD3sZ1Pn+4ZbnK7+D1zRSCx 3t4NsZiy1CzxILEjNabvd+lx06g8ordwH8ubZxqaqCSTRc2XQl2SK7U4w2CTOuO9SJ9m pbqy2SpFjVtfF9czCjAeP8IxIx1ogrCC90QsbEEfK/xgyBQYDh8X1qk2Ob3O6UzzjTza gPJg== X-Gm-Message-State: AOAM531wGWd80ILPSX/oW1fhtzu5Esz5M6pDmHkMARQv6GCwZTLru2eV DEBy1DYXHspZ4sNXYJvwxXp4sRmy3BU= X-Google-Smtp-Source: ABdhPJz9zZLcEuzOCMRKbT1AkzGtiKnIoA6uj6tw7HwEV0w/4W3JJWgW8BoFeGncClILUvj5mMe1rg== X-Received: by 2002:a5d:490a:: with SMTP id x10mr157229wrq.289.1603903880753; Wed, 28 Oct 2020 09:51:20 -0700 (PDT) Received: from lili.univ-paris-diderot.fr ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id y206sm221247wmd.34.2020.10.28.09.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 09:51:20 -0700 (PDT) From: zimoun To: 43261@debbugs.gnu.org Subject: [PATCH v2 1/2] scripts: lint: Fix '--no-network' option. Date: Wed, 28 Oct 2020 17:51:11 +0100 Message-Id: <20201028165112.28575-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: ludo@gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/lint.scm: (show-help): Add '--no-network' option message. (%options, parse-options): Fix argument order. * doc/guix.texi (Invoking guix lint): Document it. --- doc/guix.texi | 4 ++++ guix/scripts/lint.scm | 18 ++++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 22bddf10e3..19cf26572c 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -11528,6 +11528,10 @@ and exit. Only enable the checkers specified in a comma-separated list using the names returned by @option{--list-checkers}. +@item --no-network +@itemx -n +Only enable the checkers which do not dependent on Internet access. + @item --load-path=@var{directory} @itemx -L @var{directory} Add @var{directory} to the front of the package module search path diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 979d4f8363..1ab563a3fa 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -9,7 +9,7 @@ ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2017, 2018 Efraim Flashner ;;; Copyright © 2018, 2019 Arun Isaac -;;; Copyright © 2019 Simon Tournier +;;; Copyright © 2019, 2020 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -98,6 +98,9 @@ run the checkers on all packages.\n")) (display (G_ " -c, --checkers=CHECKER1,CHECKER2... only run the specified checkers")) + (display (G_ " + -n, --no-network only run checkers which do not access to network")) + (display (G_ " -L, --load-path=DIR prepend DIR to the package module search path")) (newline) @@ -132,10 +135,7 @@ run the checkers on all packages.\n")) result)))) (option '(#\n "no-network") #f #f (lambda (opt name arg result) - (alist-cons 'checkers - %local-checkers - (alist-delete 'checkers - result)))) + (alist-cons 'no-network? #t result))) (find (lambda (option) (member "load-path" (option-names option))) %standard-build-options) @@ -172,7 +172,13 @@ run the checkers on all packages.\n")) value) (_ #f)) (reverse opts))) - (checkers (or (assoc-ref opts 'checkers) %all-checkers))) + (the-checkers (or (assoc-ref opts 'checkers) %all-checkers)) + (checkers + (if (assoc-ref opts 'no-network?) + (filter (lambda (checker) + (member checker %local-checkers)) + the-checkers) + the-checkers))) (when (assoc-ref opts 'list?) (list-checkers-and-exit checkers)) base-commit: d22d129da903cf6c3382cff5226d81a881fed2aa -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 12:51:32 2020 Received: (at 43261) by debbugs.gnu.org; 28 Oct 2020 16:51:32 +0000 Received: from localhost ([127.0.0.1]:50389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXofc-0004zA-E5 for submit@debbugs.gnu.org; Wed, 28 Oct 2020 12:51:32 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXofY-0004yf-05 for 43261@debbugs.gnu.org; Wed, 28 Oct 2020 12:51:28 -0400 Received: by mail-wm1-f42.google.com with SMTP id d3so224177wma.4 for <43261@debbugs.gnu.org>; Wed, 28 Oct 2020 09:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zyGHYMuOUG9SI+erhkP2hv4dqLyoSKx1z1vxYaZ9MO8=; b=lvPDkGfPW/BEXjAznOeP7oTu2tjTpL/fp63MSXM0nMf/rlzAWfd3QyjS6xICRsTt43 fYZe9vxmTfH5O/67C+BSA/SjNYOyRVeukD45oPyRVKtMvKi3jQHuzqhL4wzV7hS5pGgf 6Bgxnrp0Uf+/hL25ebOICk8j6vcs/V8JG2hQkbCdUwH6hKy/2BHed8dugjhwtk7ptKDB PHKRZU81k5MGM78Q//IoD5PaH4w2wT9QoM+iJNQOKDd1Z5qGGWU2EfVt17q5c7EufPCa GpWMU4yUP8xIhlaiPIZ5lhkez7wH9vF2AtPEClpcv9FCHz2M2tif2Dg3s00XVGcHjU+9 zysg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zyGHYMuOUG9SI+erhkP2hv4dqLyoSKx1z1vxYaZ9MO8=; b=M4szBZkklJ6xF8xsvMNtdLUXpNDQktE0437dX7JwqOSif3i2TZzIkuoD+2E4FWAtnV Z8XC0e1xzYgHBGDKadE82t/MMBZw+r5cyV2LsbvCFzn+V9wXJXAxpVCYoKxfFmYY3u5k ApPXDl3aJzDIaR16tHcu+3MVEl1FFfYy4bRbC6QPoiftnGPOIkLb88wAEDjPLrdoBMws Zy1ZTBV4dcTbcP2lmjNh/1xzkmJ3OqIlEPAuT07ZBTtXSgNpZCJQj9d6ayoPS5bAoQFm 1TLAQNvshZohAXDiy6/V7NH3Ji0DKzsx5ZIhmjcl4cYvcuIhpWMWLFWpRzm6AAJ/xP+/ 8mNA== X-Gm-Message-State: AOAM531DSyUilE8suT1Z1AP/+SiHHmzSUTF0ONUcspVD6tu9RWOvX0z/ QutVhoD5ecX85+0bHzBZvUsDnopcHi4= X-Google-Smtp-Source: ABdhPJyPpuV2ydDJltGuJ3Wh8FE7rBsYQ1Fr6GGnt+j/NKH+UqEWkvbFssc16WQ9mZlxEs9Neuimqg== X-Received: by 2002:a7b:c20d:: with SMTP id x13mr335105wmi.83.1603903881773; Wed, 28 Oct 2020 09:51:21 -0700 (PDT) Received: from lili.univ-paris-diderot.fr ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id y206sm221247wmd.34.2020.10.28.09.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 09:51:21 -0700 (PDT) From: zimoun To: 43261@debbugs.gnu.org Subject: [PATCH v2 2/2] scripts: lint: Add '--exclude' option. Date: Wed, 28 Oct 2020 17:51:12 +0100 Message-Id: <20201028165112.28575-2-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201028165112.28575-1-zimon.toutoune@gmail.com> References: <20201028165112.28575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: ludo@gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/lint.scm (%options, parse-options): Add '--exclude' option. (option-checker): New helper function. * doc/guix.texi (Invoking guix lint): Document it. --- doc/guix.texi | 5 +++++ guix/scripts/lint.scm | 44 ++++++++++++++++++++++++++++--------------- 2 files changed, 34 insertions(+), 15 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 19cf26572c..1c146026fd 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -11528,6 +11528,11 @@ and exit. Only enable the checkers specified in a comma-separated list using the names returned by @option{--list-checkers}. +@item --exclude +@itemx -x +Only disable the checkers specified in a comma-separated list using the +names returned by @option{--list-checkers}. + @item --no-network @itemx -n Only enable the checkers which do not dependent on Internet access. diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 1ab563a3fa..cfe1a41211 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -99,6 +99,9 @@ run the checkers on all packages.\n")) -c, --checkers=CHECKER1,CHECKER2... only run the specified checkers")) (display (G_ " + -x, --exclude=CHECKER1,CHECKER2... + exclude the specified checkers")) + (display (G_ " -n, --no-network only run checkers which do not access to network")) (display (G_ " @@ -113,26 +116,34 @@ run the checkers on all packages.\n")) (newline) (show-bug-report-information)) +(define (option-checker short-long) + ;; Factorize the creation of the two options -c/--checkers and -x/--exclude, + ;; see %options. The parameter SHORT-LONG is the list containing the short + ;; and long name. The alist uses the long name as symbol. + (option short-long #t #f + (lambda (opt name arg result) + (let ((names (map string->symbol (string-split arg #\,))) + (checker-names (map lint-checker-name %all-checkers)) + (option-name (string->symbol (match short-long + ((short long) long))))) + (for-each (lambda (c) + (unless (memq c checker-names) + (leave (G_ "~a: invalid checker~%") c))) + names) + (alist-cons option-name + (filter (lambda (checker) + (member (lint-checker-name checker) + names)) + %all-checkers) + result))))) (define %options ;; Specification of the command-line options. ;; TODO: add some options: ;; * --certainty=[low,medium,high]: only run checkers that have at least this ;; 'certainty'. - (list (option '(#\c "checkers") #t #f - (lambda (opt name arg result) - (let ((names (map string->symbol (string-split arg #\,))) - (checker-names (map lint-checker-name %all-checkers))) - (for-each (lambda (c) - (unless (memq c checker-names) - (leave (G_ "~a: invalid checker~%") c))) - names) - (alist-cons 'checkers - (filter (lambda (checker) - (member (lint-checker-name checker) - names)) - %all-checkers) - result)))) + (list (option-checker '(#\c "checkers")) + (option-checker '(#\x "exclude")) (option '(#\n "no-network") #f #f (lambda (opt name arg result) (alist-cons 'no-network? #t result))) @@ -172,7 +183,10 @@ run the checkers on all packages.\n")) value) (_ #f)) (reverse opts))) - (the-checkers (or (assoc-ref opts 'checkers) %all-checkers)) + (no-checkers (or (assoc-ref opts 'exclude) '())) + (the-checkers (filter (lambda (checker) + (not (member checker no-checkers))) + (or (assoc-ref opts 'checkers) %all-checkers))) (checkers (if (assoc-ref opts 'no-network?) (filter (lambda (checker) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 12:58:54 2020 Received: (at 43261) by debbugs.gnu.org; 28 Oct 2020 16:58:54 +0000 Received: from localhost ([127.0.0.1]:50417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXomk-0005B3-2Z for submit@debbugs.gnu.org; Wed, 28 Oct 2020 12:58:54 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:34686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXomj-0005As-34 for 43261@debbugs.gnu.org; Wed, 28 Oct 2020 12:58:53 -0400 Received: by mail-wm1-f68.google.com with SMTP id k21so148363wmi.1 for <43261@debbugs.gnu.org>; Wed, 28 Oct 2020 09:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=YQZiB9XwV6VLIN95bf2EDxGEeEs7j9Xqm+Nik+nDqDc=; b=FlqqppLM7i4BtRZj367OxPf9LDXbjz8Vi3XGWPqLCCojOZ7q2ogR20/450Qa45z4Rw DSp53gIhPPPAlM7z6/KJULbt0k43LPtox6RW0vkFHu/yI/oiphzgAqyMHLBq7ybn/Axj E/83Z9/RmF5okYFmoI4d7xMdh1AM1y36RQKleAseEEHqWODA6+KeOEMkuns3SPROZ/Kn lEyW/dgbIZEarM6nE6gSoobWM6NYanqapC4EoROqGTZIr1JbGt623wyqTgfkKXvZ+//B xR1DOznUbSXcqj2Fzd6pw8Kd/gtVjZq7RSTttuIDLgqBy8zLgw7pSsJJK8DpqeiLjFD3 W1Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YQZiB9XwV6VLIN95bf2EDxGEeEs7j9Xqm+Nik+nDqDc=; b=bqTlef6MfkJ3Vtagw3zfgk1ySz6FOqk6YpT29hW2IslpMfDmMYFafnWNvqHIQozeIt VRiOitkoYgia1tZ5zysLZGY+XO0uglN+2YV5cjz0MlTC/hJovhfsVpWmQuM9WcKF8XSr E1Hc3ySFg3xw6qbbjCuebvgwx1HMwklVOCPxV8Xs5wGCw4hR/1CqrXjtO1OGhU0RX8WJ 21LVbm6P5JDZkzKWI9JeNyziC36vCI4M4NcU3gXFUsCZcTG+4Z0f9LlEHTdxdIBaPlBu PW4JILi7BokZY+EOP4jgSB5rUhMjG8oqyogMkFZ56T/iYUOxEyFvgRj75hmksMHE2BIB p2BA== X-Gm-Message-State: AOAM530oUuYfIXW29t02Tc2w+RqLfDz5gwDyHIBejwTqhCsWw5W2sFGQ jIMvBso1ifX5oMaGtKr4LosbSaNQHso= X-Google-Smtp-Source: ABdhPJxhf82quNrxpeOInJjfKtDYFFVPB6ClcSty4EOw5SmEeZxMSFIcc5a2BwKwa97EUHktCk5ZmA== X-Received: by 2002:a1c:3bc3:: with SMTP id i186mr403794wma.112.1603904326795; Wed, 28 Oct 2020 09:58:46 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id k18sm140366wrx.96.2020.10.28.09.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 09:58:46 -0700 (PDT) From: zimoun To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#43261] [PATCH 2/2] lint: Add '--no-checkers' option. References: <20200907180415.30140-1-zimon.toutoune@gmail.com> <20200907180415.30140-2-zimon.toutoune@gmail.com> <87d0121iru.fsf@gnu.org> Date: Wed, 28 Oct 2020 17:58:45 +0100 In-Reply-To: <87d0121iru.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 28 Oct 2020 16:18:13 +0100") Message-ID: <86y2jq1e4a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43261 Cc: 43261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thank you for the review. All the comments are included in v2. On Wed, 28 Oct 2020 at 16:18, Ludovic Court=C3=A8s wrote: > Use =E2=80=98match=E2=80=99 instead of =E2=80=98cadr=E2=80=99, or maybe m= ake it a parameter of this > procedure? Well, it is a matter of taste. :-) Just to be sure, that=E2=80=99s the poi= nt: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,use(ice-9 match) scheme@(guile-user)> (define foo '(hello world)) scheme@(guile-user)> (cadr foo) $2 =3D world scheme@(guile-user)> (match foo ((hi all) all)) $3 =3D world --8<---------------cut here---------------end--------------->8--- right? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 19:25:35 2020 Received: (at 43261) by debbugs.gnu.org; 29 Oct 2020 23:25:35 +0000 Received: from localhost ([127.0.0.1]:55397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYHIV-0000rB-5j for submit@debbugs.gnu.org; Thu, 29 Oct 2020 19:25:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYHIT-0000qi-Cb for 43261@debbugs.gnu.org; Thu, 29 Oct 2020 19:25:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49897) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYHIO-0008Sz-5D; Thu, 29 Oct 2020 19:25:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50426 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYHIN-0008U8-GO; Thu, 29 Oct 2020 19:25:27 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [PATCH v2 1/2] scripts: lint: Fix '--no-network' option. References: <20201028165112.28575-1-zimon.toutoune@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 30 Oct 2020 00:25:25 +0100 In-Reply-To: <20201028165112.28575-1-zimon.toutoune@gmail.com> (zimoun's message of "Wed, 28 Oct 2020 17:51:11 +0100") Message-ID: <87d010zkbe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43261 Cc: 43261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi! zimoun skribis: > * guix/scripts/lint.scm: (show-help): Add '--no-network' option message. > (%options, parse-options): Fix argument order. > * doc/guix.texi (Invoking guix lint): Document it. Applied with the changes below. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/doc/guix.texi b/doc/guix.texi index 9e276c547d..e3b92d86f9 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -11530,7 +11530,7 @@ names returned by @option{--list-checkers}. @item --no-network @itemx -n -Only enable the checkers which do not dependent on Internet access. +Only enable the checkers that do not depend on Internet access. @item --load-path=@var{directory} @itemx -L @var{directory} diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 1ab563a3fa..6833c60741 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -99,7 +99,7 @@ run the checkers on all packages.\n")) -c, --checkers=CHECKER1,CHECKER2... only run the specified checkers")) (display (G_ " - -n, --no-network only run checkers which do not access to network")) + -n, --no-network only run checkers that do not access the network")) (display (G_ " -L, --load-path=DIR prepend DIR to the package module search path")) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 19:28:58 2020 Received: (at 43261-done) by debbugs.gnu.org; 29 Oct 2020 23:28:58 +0000 Received: from localhost ([127.0.0.1]:55414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYHLm-0000xM-0W for submit@debbugs.gnu.org; Thu, 29 Oct 2020 19:28:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYHLk-0000x7-Hj for 43261-done@debbugs.gnu.org; Thu, 29 Oct 2020 19:28:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49979) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYHLf-0000RD-A0; Thu, 29 Oct 2020 19:28:51 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50456 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYHLd-0004EY-M4; Thu, 29 Oct 2020 19:28:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [PATCH v2 2/2] scripts: lint: Add '--exclude' option. References: <20201028165112.28575-1-zimon.toutoune@gmail.com> <20201028165112.28575-2-zimon.toutoune@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 30 Oct 2020 00:28:48 +0100 In-Reply-To: <20201028165112.28575-2-zimon.toutoune@gmail.com> (zimoun's message of "Wed, 28 Oct 2020 17:51:12 +0100") Message-ID: <878sbozk5r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43261-done Cc: 43261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) zimoun skribis: > * guix/scripts/lint.scm (%options, parse-options): Add '--exclude' option. > (option-checker): New helper function. > * doc/guix.texi (Invoking guix lint): Document it. Applied, thanks! Ludo=E2=80=99. From unknown Sat Aug 16 20:58:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Nov 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator