Subject: bug#43261: closed (Re: [PATCH v2 2/2] scripts: lint: Add '--exclude' option.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 29 Oct 2020 23:29:01 +0000

Your bug report

#43261: [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
43261: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43261
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH v2 2/2] scripts: lint: Add '--exclude' option.
From: Ludovic Courtès <[email-masked]>
To: zimoun <[email-masked]>
Cc: [email-masked]
Date: Fri, 30 Oct 2020 00:28:48 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

zimoun <[email-masked]> skribis:

> * guix/scripts/lint.scm (%options, parse-options): Add '--exclude' option.
> (option-checker): New helper function.
> * doc/guix.texi (Invoking guix lint): Document it.

Applied, thanks!

Ludo’.

Subject: [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options
From: zimoun <[email-masked]>
To: [email-masked]
Cc: zimoun <[email-masked]>
Date: Mon, 7 Sep 2020 20:02:29 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Dear,

The first patch fixes the unexpected behaviour of "guix lint":

  guix lint -c description -n
           vs
  guix lint -n -c description

Now, if '--no-network' and any checkers are provided using '--checkers' then
the ones requiring Internet access are turned off.

The second patch adds the '--no-checkers' option discussed some time ago.  I
am not convinced by the 'option-checker' helper function.  What could be
better?

Instead of '--no-checkers' maybe '--exclude-checkers' is a better name.

Last, note that '--list-checkers' operates as a dry-run:

--8<---------------cut here---------------start------------->8---
./pre-inst-env guix lint -c description,formatting,synopsis -n -x description -l
Available checkers:
- formatting: Look for formatting issues in the source
--8<---------------cut here---------------end--------------->8---

All the best,
simon

zimoun (2):
  lint: Fix '--no-network' option.
  lint: Add '--no-checkers' option.

 doc/guix.texi         |  9 +++++++
 guix/scripts/lint.scm | 55 +++++++++++++++++++++++++++----------------
 2 files changed, 44 insertions(+), 20 deletions(-)

base-commit: 89e1e4481382d18033a9773b90c09345fa33d6cb
-- 
2.28.0