From unknown Fri Jun 20 07:11:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43249 <43249@debbugs.gnu.org> To: bug#43249 <43249@debbugs.gnu.org> Subject: Status: Resolve Calibre run-time dependency Reply-To: bug#43249 <43249@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:00 +0000 retitle 43249 Resolve Calibre run-time dependency reassign 43249 guix-patches submitter 43249 Prafulla Giri severity 43249 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 14:32:41 2020 Received: (at submit) by debbugs.gnu.org; 6 Sep 2020 18:32:42 +0000 Received: from localhost ([127.0.0.1]:47158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEzSz-0005O0-MN for submit@debbugs.gnu.org; Sun, 06 Sep 2020 14:32:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:36066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEzSx-0005Nr-A0 for submit@debbugs.gnu.org; Sun, 06 Sep 2020 14:32:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEzSx-0005nx-3t for guix-patches@gnu.org; Sun, 06 Sep 2020 14:32:39 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:54908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEzSv-0004Iu-8p for guix-patches@gnu.org; Sun, 06 Sep 2020 14:32:38 -0400 Received: by mail-pj1-x1032.google.com with SMTP id mm21so5569181pjb.4 for ; Sun, 06 Sep 2020 11:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=MqjnP5sq5R/kGtEZCg6yw72fz8quSSU+foaQeNouvhQ=; b=XF4KOYbWpFxkQlnMgo4z06/tuzkWTl2GHBB7b4m/x6vdV67JRs+xbn5YJxMrEFX4DR 9BtXG/vyq3q1jSzya8fIrq/EvMHuVH2FfqefHw7C5vQnlQF0tQ1aZ1NHK0rVrWH/IwMC EJuxYn+170EiCLbXbzw9VxLQwWwzAf1rvZOab6IB15NKUL7Ie0iKRnSa424uLfiojGOS fokLX09fkxfJ68cvbI0hqzp84FDmjeUzNdwE5tHR3yAmeXCof7fp3RwhW4jfhSrmea2E JmSPJAtaZRykBtAZQzQiEDoyALiGsaife+jykd0bzyVcUpGKVntzL7qRmhzzeXewxllE gqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=MqjnP5sq5R/kGtEZCg6yw72fz8quSSU+foaQeNouvhQ=; b=QaS0jie19zy12YNzmoILE87m3qdTU8vtQRNqhjIvP6dEkRfnEn4QgIZo1YAkrPeykW S1c6H1VaHuqCiRM1Jr6QSxvBjqfQMUXNXcAo4mNrHPixuyi7r1rL8zwhH+X9dfkROyqO 88+PKZc7iAyqXHKLb9bjveLoKxDUnVkx7D4/BJfvRZTfOpJOWCId+aOQSvTSm90MsUCh cIyZLn3Q7Kg6s0QXYOPBScClKY71szzGOmT+9bBoS2ZlfpzR1YwE3gdAurBclSp+Vpto GGyMbeY+ttAPieeWtm/fE2BHfO2d0MRzePMgHca8zRPLTAuxQWwmk7QhfKhnzA9Tw/Pf llNw== X-Gm-Message-State: AOAM533aKFthbzKKNKy3PyZ2y57h+u7jvHJM5CrPXqftvagUgKOhYn/Q GezlmKL9KIysjyNHKQIlRcjO50c/voB45+lEz6+oqTRrpmD97g== X-Google-Smtp-Source: ABdhPJx0GA5RP4e27srJAkETjTe/ylNozEoil+1Yesdi8K4LzBTs0lU7NpbQpREl7jCvChNsPFjSwKfke295v2/L/tM= X-Received: by 2002:a17:90a:6301:: with SMTP id e1mr16638409pjj.5.1599417154876; Sun, 06 Sep 2020 11:32:34 -0700 (PDT) MIME-Version: 1.0 From: Prafulla Giri Date: Mon, 7 Sep 2020 00:17:23 +0545 Message-ID: Subject: Resolve Calibre run-time dependency To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="0000000000005d618a05aea95340" Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=pratheblackdiamond@gmail.com; helo=mail-pj1-x1032.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000005d618a05aea95340 Content-Type: multipart/alternative; boundary="0000000000005d618905aea9533e" --0000000000005d618905aea9533e Content-Type: text/plain; charset="UTF-8" Esteemed maintainers, Currently, Calibre can't open .epub files unless `qtwebengine` package is also available in one's $GUIX_PROFILE. Neither can the stand-alone `ebook-viewer` program supplied with Calibre. It exits with the complaint: "Could not find QtWebEngineProcess". Attached is a patch to fix the issue. QtWebEngineProcess is now made available to all Calibre binaries via QTWEBENGINE_PATH set during a new 'wrap-program phase introduced with the patch. Thank you --0000000000005d618905aea9533e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Esteemed maintainers,

Curren= tly, Calibre can't open .epub files unless `qtwebengine` package is als= o available in one's $GUIX_PROFILE. Neither can the stand-alone `ebook-= viewer` program supplied with Calibre. It exits with the complaint: "C= ould not find QtWebEngineProcess".

Attached i= s a patch to fix the issue. QtWebEngineProcess is now made available to all= Calibre binaries via QTWEBENGINE_PATH set during a new 'wrap-program p= hase introduced with the patch.

Thank you
--0000000000005d618905aea9533e-- --0000000000005d618a05aea95340 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-calibre-make-QtWebEngineProcess-available-during.patch" Content-Disposition: attachment; filename="0001-gnu-calibre-make-QtWebEngineProcess-available-during.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kerfnj4x0 RnJvbSBjZWMwZDhhZGY0NTZlZmYyMjAxZmQ4OWJiMWZkZTZjYmE5ZDZmYTc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmFmdWxsYSBHaXJpIDxwcmF0aGVibGFja2RpYW1vbmRAZ21h aWwuY29tPgpEYXRlOiBTdW4sIDYgU2VwIDIwMjAgMjM6NTc6MTQgKzA1NDUKU3ViamVjdDogW1BB VENIXSBnbnU6IGNhbGlicmU6IG1ha2UgUXRXZWJFbmdpbmVQcm9jZXNzIGF2YWlsYWJsZSBkdXJp bmcKIHJ1bnRpbWUKCiogZ251L3BhY2thZ2VzL2Vib29rLnNjbSBbYXJndW1lbnRzXTogQWRkIG5l dyBwaGFzZSAnd3JhcC1wcm9ncmFtCnRvIG1ha2UgUXRXZWJFbmdpbmVQcm9jZXNzIGF2YWlsYWJs ZSB0byB0aGUgYmluYXJpZXMgZHVyaW5nIHJ1bi0KdGltZSB3aXRoIFFUV0VCRU5HSU5FUFJPQ0VT U19QQVRILgotLS0KIGdudS9wYWNrYWdlcy9lYm9vay5zY20gfCAxNiArKysrKysrKysrKysrKysr CiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNr YWdlcy9lYm9vay5zY20gYi9nbnUvcGFja2FnZXMvZWJvb2suc2NtCmluZGV4IGFhYjQxNTVkM2Qu LmY2M2QyODRhZmIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lYm9vay5zY20KKysrIGIvZ251 L3BhY2thZ2VzL2Vib29rLnNjbQpAQCAtMjYyLDYgKzI2MiwyMiBAQAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiL3NoYXJlL2ZvbnRzL3RydWV0eXBlIikpKQog ICAgICAgICAgICAgICAgKGRlbGV0ZS1maWxlLXJlY3Vyc2l2ZWx5IGZvbnQtZGVzdCkKICAgICAg ICAgICAgICAgIChzeW1saW5rIGZvbnQtc3JjIGZvbnQtZGVzdCkpCisgICAgICAgICAgICAgI3Qp KQorICAgICAgICAgOzsgTWFrZSBydW4tdGltZSBkZXBlbmRlbmNpZXMgYXZhaWxhYmxlIHRvIHRo ZSBiaW5hcmllcworICAgICAgICAgKGFkZC1hZnRlciAnd3JhcCAnd3JhcC1wcm9ncmFtCisgICAg ICAgICAgIChsYW1iZGEqICgjOmtleSBpbnB1dHMgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMp CisgICAgICAgICAgICAgKGxldCAoKG91dCAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKQorICAg ICAgICAgICAgICAgICAgIChxdHdlYmVuZ2luZSAoYXNzb2MtcmVmIGlucHV0cyAicXR3ZWJlbmdp bmUiKSkpCisgICAgICAgICAgICAgICAod2l0aC1kaXJlY3RvcnktZXhjdXJzaW9uIChzdHJpbmct YXBwZW5kIG91dCAiL2JpbiIpCisgICAgICAgICAgICAgICAgIChmb3ItZWFjaAorICAgICAgICAg ICAgICAgICAgKGxhbWJkYSAoYmluYXJ5KQorICAgICAgICAgICAgICAgICAgICAod3JhcC1wcm9n cmFtIGJpbmFyeQorICAgICAgICAgICAgICAgICAgICAgIDs7IE1ha2UgUXRXZWJFbmdpbmVQcm9j ZXNzIGF2YWlsYWJsZQorICAgICAgICAgICAgICAgICAgICAgIGAoIlFUV0VCRU5HSU5FUFJPQ0VT U19QQVRIIiAiOiIgPQorICAgICAgICAgICAgICAgICAgICAgICAgLChsaXN0IChzdHJpbmctYXBw ZW5kCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHF0d2ViZW5naW5lCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICIvbGliL3F0NS9saWJleGVjL1F0V2ViRW5naW5lUHJv Y2VzcyIpKSkpKQorICAgICAgICAgICAgICAgICAgKGZpbmQtZmlsZXMgIi4iICIuIikpKSkKICAg ICAgICAgICAgICAjdCkpKSkpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9jYWxpYnJlLWVib29r LmNvbS8iKQogICAgIChzeW5vcHNpcyAiRS1ib29rIGxpYnJhcnkgbWFuYWdlbWVudCBzb2Z0d2Fy ZSIpCi0tIAoyLjI4LjAKCg== --0000000000005d618a05aea95340-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 16:09:33 2020 Received: (at 43249) by debbugs.gnu.org; 6 Sep 2020 20:09:33 +0000 Received: from localhost ([127.0.0.1]:47217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0yj-0007eJ-Dt for submit@debbugs.gnu.org; Sun, 06 Sep 2020 16:09:33 -0400 Received: from mout.web.de ([212.227.17.12]:45543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0yh-0007e6-Mb for 43249@debbugs.gnu.org; Sun, 06 Sep 2020 16:09:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1599422964; bh=giYQeufldISVjJ5jg6KBVq7K9pRwbn8Q59+Kh3kN1b0=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=YSGQxnTRL8G9RSn5AWaGG2LLxjGayGZy9Zv/wlNQu16el7QEiSAFafqq9jfYmXcMp 2B6j6ZWQ62oWyWxh4HeZmZt6IRRuhoq5zZ/oyizd3jFSmFQfVHds8+qMH/shhyR/pJ r5p/rLAiKfdWc6bC2CJX4g90Zg5U470QkXXZnVC8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.25] ([5.146.193.136]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MElV3-1kLwz91xHv-00FxSF; Sun, 06 Sep 2020 22:09:24 +0200 Subject: Re: [bug#43249] Resolve Calibre run-time dependency To: Prafulla Giri , 43249@debbugs.gnu.org References: From: Jonathan Brielmaier Message-ID: <90c46d1c-9d4f-3f6d-cf33-2920fdbafdb2@web.de> Date: Sun, 6 Sep 2020 22:09:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Icedove/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:OIsbHjC9kf6jhnaVW+3oPlpcZ5HYynzPON0CYkzFMePIL6L6ScS imTeIUEXE533sdd8drobItkGcEhKCVmCAsk6pDAvRxKYQ0aLqmMIF+Q+R2MFV3Y2DVY9zjG EceWx1y6/yQhNjy3FKqSkjrTlWIM8Y7PhnOZmm9TGwOJaxmpjVsP0W8F1aB3e1zz129nQqU oQS30DiFRyJsur3etQoDw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:eplKjk6a6xk=:m6VkjqpIXtHYqtqn+4Vy3m gX9If7LvuY+4bAN1YJrjXO6dPdd6BFa9DWeoiNNXhjvPdxbKxxBLD4/9sERYDINbAQleytlP7 jYrmvvythp/oX/TrVkOpRHqLPvrQ3YNc2qcOA0rY72IrOwUR+hD6ijyZDxNKKJxqhtWj3PJ4V hp1MxNevw2u+soCd8VvSSCArnOJP44NrtFbEsgfWpFymkPChakjKX/YqjJjSwKgA2EhOGAusE 5bU7RsMEFWjtVnq2N+YncNv7oCX9KpvKETsajScF4UlHvFTkgo5Rqym3+CFGeQnarV6LDjPRy SAu3J2XcB9BWmx1vdGDdtRgxG5aAZGMAzovRk1+hk1Djy6mwiDSW6s4bxybNzp0c32HjauYc2 eX8XV8iSnnAtdFqsnllhMFqrnnQcuELCjeAKiiQJ15O3N8o5jMO4H9uib+GzcPeLwgXdwiiF2 4pZVyoujgfNIyjO6B1yuOT+ntfs/B+OE1N/X7DZ1N1LkA7FTT3JKYukGM683ttGMFUnuNGZPP QDSwbZXk8UmIM4QDxuVM+yZmWxLSdm+aZ8pq83Qcn7RCy+DLCURvJNVN22SBLMz8ksgRTe9PE 0dKXpSXPwxQZFdtoZ7y7FXfZhglOccIG0oBk6m/zit8CChfvgNad8oVgLfzdKq49bqQ3zUBvz 65w62EYJit8zTQgyK06cTrHFZsxhKOIXjoCgqrG6p4XqigKCqEAzQzshdDORmiZv9ooPjdtGH Hm+AbzW5QOZ/VhYlx5OVRwM6IVCDiLIczkWiV07U0FMuLvev37n1KVQCU4zPRHkXApETmjOgy ibwmjZCiu+2bdfxWqZdkeqzh/1b/psQspuPfxZOJRZ7aORc8azDfuv5aVuq7VFEuUiqomU03D 0k7Lo+dIPdFg+cWzWTlPERYvV4Fp5S5X8KSTcWS+fvApoqsXuJpJHw2k+8I0231qq/X4wsRdN nImkqr5Zq0gugSjUqP0fqzqN5wjSIMisk4Vb/aMmLvP759Latz11V3xiuta0cOr/eAcYby6cy Tn+h0b1GnZT1nACXQ3bivnLMUPyVmPterqHqJJVxe2pj5tarhc8+ail2ld3RhWfn3lLtnXVJA ZOUe8IiagmZlKyoU1GDDTBY6naPziGtKArBnKVQlg2N0Wfqy3+nS/AX0oLj4d4omlYwwiSEV7 JSlRWtkw/rxGQkpk4YYTawDbPvWCwzF9/JvnN58XvFYYPPJSwYx4AQMiIdTGu68B8SsbU5tNf 4flyE2ewYR8Mt8qn8Ielfss+C478GNvTd1QPmjA== X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 43249 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) Brendan already proposed a patch for this problem in his series updating calibre to 4.22.0 see http://issues.guix.gnu.org/42885#4 Sorry for the duplicated effort, but maybe you can chime in there. It seems so that there is some work left to get the update merged... On 06.09.20 20:32, Prafulla Giri wrote: > Esteemed maintainers, > > Currently, Calibre can't open .epub files unless `qtwebengine` package i= s > also available in one's $GUIX_PROFILE. Neither can the stand-alone > `ebook-viewer` program supplied with Calibre. It exits with the complain= t: > "Could not find QtWebEngineProcess". > > Attached is a patch to fix the issue. QtWebEngineProcess is now made > available to all Calibre binaries via QTWEBENGINE_PATH set during a new > 'wrap-program phase introduced with the patch. > > Thank you > From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 04:12:47 2020 Received: (at 43249) by debbugs.gnu.org; 7 Sep 2020 08:12:47 +0000 Received: from localhost ([127.0.0.1]:47850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFCGd-0004Ro-5w for submit@debbugs.gnu.org; Mon, 07 Sep 2020 04:12:47 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:19712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFCGa-0004RM-MT; Mon, 07 Sep 2020 04:12:45 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4BlLcQ4sKDzQlJ2; Mon, 7 Sep 2020 10:12:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1599466356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WuO5fAjj2NMHWBrh+rAF059Bi6i1+lC+xTYY+N8yWBI=; b=fh2IegKQAcB7SXzDPOcUQVLExwcqdzmOAZJW+6CXBcHrwDI3ONs4Rq5Dj8jIyGH717/MAQ r8Nk5a7D34laK3t/GbpEwKJzObKmQBho82gnTI1HCi4t/SdM3p46exqka7rcE0o1Kkd82q yZCNNYHlUWuDriOdpN0c0UFqQrZXnhH69x0JiGAEYz22mKgWt8xP0lLkov+l4eRHu96r6g 1tGdzDs5UHICYYlXQbqHF3ws8V0vQcamY6FyfbJolYId6Ol5BGqkyDS6Thv4iJyZwD25LX QyeVNrHAo8oKjIpEAOf57nJ9PFLg0xRDXlPILV//7lEJG1k4dLl6Hh2mcAHZLA== Received: from smtp2.mailbox.org ([80.241.60.241]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id sjXL7hXDbwFO; Mon, 7 Sep 2020 10:12:34 +0200 (CEST) To: "Prafulla Giri From: Brendan Tildesley Subject: Re: Resolve Calibre run-time dependency Message-ID: Date: Mon, 7 Sep 2020 18:12:37 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -0.02 / 15.00 / 15.00 X-Rspamd-Queue-Id: 363B717B7 X-Rspamd-UID: 1b81e4 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43249 Cc: 43249@debbugs.gnu.org, 43151@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) There is actually a Bug report by Andreas for this very issue. I created a bug report just for updating, and fixed this issue after it while I could, without realising. Sorry for all the confusion with things happening in 3 different threads. I created an updated patch just for this one here. https://issues.guix.gnu.org/43151#5 Your patch also works I think but it will wrap the programs twice, so you will get calibre, .calibre-real, and ..calibre-real-real, etc for every program, which seems ugly. My patch reproduces the same PYTHONPATH that is set in python-build-system in addition to wrapping PYTHONPATH (unless I made a mistake), although at the cost of code duplication. I leave it to you and who ever is reviewing this to decide which way is more correct and push one, haha. Please continue any discussion of the QtWebEngine bug on issue 43121: 43151@debbugs.gnu.org / https://issues.guix.gnu.org/43151 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 08:22:44 2020 Received: (at 43249) by debbugs.gnu.org; 8 Sep 2020 12:22:44 +0000 Received: from localhost ([127.0.0.1]:52336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFce4-000260-HM for submit@debbugs.gnu.org; Tue, 08 Sep 2020 08:22:44 -0400 Received: from mail-pj1-f52.google.com ([209.85.216.52]:50195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFce0-00025h-PD for 43249@debbugs.gnu.org; Tue, 08 Sep 2020 08:22:43 -0400 Received: by mail-pj1-f52.google.com with SMTP id b16so8206237pjp.0 for <43249@debbugs.gnu.org>; Tue, 08 Sep 2020 05:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=FGmiAJDQJtVq5o3nmFvXOGR8yZ/mOzVQ1+Fm06nBgMw=; b=H9/t0PfvguieVz4O5s44SqMG4AXIK8GRp0BxOMghvFauewHr+bGTSh9Vo+89eN1pkV IRbfaypdqkrWRHqJhaptnlRSGFIVaPEmJmi+rTtxIWAvzN4Rm9qY7JhfGVQ7LuSKd5EH GMg74Rzt90heLRtdWAjkHlJFZjhBPF3gZ0Ok4gmuCnY2iXMf3egJF6bD1e+606z/wzc2 dFy9sXD+tjJURnBIAe7eOj3mIcGBkF6HNr+WNjEtq2fOPjAtPbyxmVnS9oClgoltCl4C na80125fQj/25oPnxZf7HlCTn9LJ7EalP0HOoQe4+FPwopR/QjVlcmCrmjk9Gt77WFxj HibQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=FGmiAJDQJtVq5o3nmFvXOGR8yZ/mOzVQ1+Fm06nBgMw=; b=lsxz3VAzsRAVvaoz+5vUkrueEWGaHExbTdnBU6DxM8T2c1smrRzPT2h96Hxcm4Nx/B ilKqkdlDCjq7fIfafSUsRrphfYBfejjv2o3wjsKpRftnshbQowjs54bRcLIFz7ZOTyS2 JyG8+kF8a5E8JWvnOzCoEUKjC6txCn4x8daI3DvqGLZpBzUp4kKEdU1+etH8c134oqtR 2ZsLZ7IXylZlBRz7rpJGd6qeK8XdSGvDA30VboD/V8d1NUbgNnDu1Amz2K0Lhl8LBYm4 0RshdrDsLyJZfnf2oKIe8ncJY0zNcv9sIQTLu26XOyoSykKWWWLrTRt3TU5bYO3rhPT3 ko4g== X-Gm-Message-State: AOAM531OHekCfEUjBixiLpXY8kjH0jW2hug2eQpHzmtPIN4cBNtGMAbn pY+mU+EI2dh0BJZgcspcO1jGG6ktrE9rEHun+EDMnoXc3Ok= X-Google-Smtp-Source: ABdhPJytG3sQmMT1u7B0fLDqGxE9EfVRxI1NU288ANRI3HraDkcBvOsA0ndkeGO8G36BEFym1WA32LSxtWVErOQtFHA= X-Received: by 2002:a17:90b:ecc:: with SMTP id gz12mr3575640pjb.219.1599567754678; Tue, 08 Sep 2020 05:22:34 -0700 (PDT) MIME-Version: 1.0 From: Prafulla Giri Date: Tue, 8 Sep 2020 18:07:23 +0545 Message-ID: Subject: To: 43249@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000cfd67c05aecc63e1" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I see. Yes, it does make sense now why you chose to replace the 'wrap phase. I wonder.... perhaps it'd be better altogether if the (wrap-program) procedure could be re-written to not make ..*.real.real programs...? That would save us a lot of code-duplication... Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pratheblackdiamond[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.216.52 listed in list.dnswl.org] 0.0 HTML_MESSAGE BODY: HTML included in message 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.216.52 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: 43249 Cc: mail@brendan.scot X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --000000000000cfd67c05aecc63e1 Content-Type: text/plain; charset="UTF-8" I see. Yes, it does make sense now why you chose to replace the 'wrap phase. I wonder.... perhaps it'd be better altogether if the (wrap-program) procedure could be re-written to not make ..*.real.real programs...? That would save us a lot of code-duplication... --000000000000cfd67c05aecc63e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I see.

Yes, it does make sen= se now why you chose to replace the 'wrap phase.

I wonder.... perhaps it'd be better altogether if the (wrap-program)= procedure could be re-written to not make ..*.real.real programs...? That = would save us a lot of code-duplication...
--000000000000cfd67c05aecc63e1-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 09:38:34 2020 Received: (at 43249) by debbugs.gnu.org; 8 Sep 2020 13:38:34 +0000 Received: from localhost ([127.0.0.1]:52513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFdpS-00068u-Kf for submit@debbugs.gnu.org; Tue, 08 Sep 2020 09:38:34 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:26554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFdpP-00068f-9j for 43249@debbugs.gnu.org; Tue, 08 Sep 2020 09:38:33 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Bm5nr6ZBLzQlQN; Tue, 8 Sep 2020 15:38:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1599572302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QvXoRw0wMvLasr5izX+2LUyRYeFLeyOOgbbFSzjEpoY=; b=at7mm9TjoEatgjmnEMR1yaGE3uPrmWYRjXu2h6nivzTeyz80w7Pv1/wBjYeDgyDxyAYlyK eXoa/6Yeg5JDSHXPeBX/PNlkTxaghNZvAQ3BPzbY2aA5r59DQwl5A6nEC+2YHETMWVp+SE 6l9krNDNf3Xp4BZMSUYgNMUR+/Aj9RPii6kmk0HjT7RDPuL1ucoYnz4gkJPnPdgnko8PBJ yL7dS1j2V1DQAICQ29NMb8rSmy2TchEQnxbhHOS+Yd7Wfq0x7e+KmkyFbalv7POa/987zM NUI1xbJbpArKxj8YZpNdr+MpHbvBNqLc3S6J6M1FirNH3dupZyNLST1g4ChlWw== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id RvPDjaA8ck_r; Tue, 8 Sep 2020 15:38:20 +0200 (CEST) Subject: Re: To: Prafulla Giri , 43249@debbugs.gnu.org References: From: Brendan Tildesley Message-ID: Date: Tue, 8 Sep 2020 23:38:25 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -3.76 / 15.00 / 15.00 X-Rspamd-Queue-Id: 7AA9A17D3 X-Rspamd-UID: 55175e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43249 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 8/9/20 10:22 pm, Prafulla Giri wrote: > I see. > > Yes, it does make sense now why you chose to replace the 'wrap phase. > > I wonder.... perhaps it'd be better altogether if the (wrap-program) > procedure could be re-written to not make ..*.real.real programs...? > That would save us a lot of code-duplication... Actually there is such a thing that can be use for scripts. It's wrap-script. I had sort of forgotten about it because I believe it has a bug where it passes command line arguments incorrectly, so wasn't using it: https://issues.guix.gnu.org/40039 . Would be worth looking in to again. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 15:56:42 2020 Received: (at submit) by debbugs.gnu.org; 8 Sep 2020 19:56:42 +0000 Received: from localhost ([127.0.0.1]:56506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFjjN-00065p-Ov for submit@debbugs.gnu.org; Tue, 08 Sep 2020 15:56:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:46026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFjjI-00065P-HB for submit@debbugs.gnu.org; Tue, 08 Sep 2020 15:56:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFjjI-0005Pt-6a for guix-patches@gnu.org; Tue, 08 Sep 2020 15:56:36 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFjjG-0003em-6Q for guix-patches@gnu.org; Tue, 08 Sep 2020 15:56:35 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1599594988; cv=none; d=zohomail.com; s=zohoarc; b=YH7ceSBaeZGga56djJZZqRiOHVIp0eYobuOyTmW6qYGzjvZ2dIjJdRciQ1lnCm9Opa+1OJN31buWgKRmbnQsPxaYQVaxTdzkTfNU2m1o7+QcCtEa/FMVfsFjbm9NFy0xNB11MLgq80jBdiNjaOtOoCYe2Fcq3maBqqBM32DmrxU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599594988; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=PviaDgTk4WXit2Bu4jDoDjTHTLBb6h7Ev264QPeOXcE=; b=AVdhkDBH+QvWgoPi1Y2s70xuyJvPp0Z08x08xvS5yi69HX7jEb4ErzLOEhowtWv+UVV8FWkMRciVIYysmWH9DBnORGg6ccKshy2/KogdDQUNUgntqovLFiWNkmzj2G4NkEnPz+vsqDOqk8MAa1YwTkuXn70ANHx9MqHA+bfEU04= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1599594988; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=PviaDgTk4WXit2Bu4jDoDjTHTLBb6h7Ev264QPeOXcE=; b=gz60mNTI02EaTo18BFUKptM9PqcwWJWHfC1EKrPBa6WpdYewpx2X/COCKMSBPFlR ID5XEnH6wztAY39BiD8UFEW8k2FGKPItLJYjrZmxVwKEjbjWtRGTdzCfefSxIHFOIHt iK5SWpTLyvpJNAsC7etdiTPWwyDRZ4ZXR+VLZifs= Received: from localhost (p54ad44b3.dip0.t-ipconnect.de [84.173.68.179]) by mx.zohomail.com with SMTPS id 1599594987204915.5884506769106; Tue, 8 Sep 2020 12:56:27 -0700 (PDT) References: User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus To: Prafulla Giri Subject: Re: [bug#43249] In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Tue, 08 Sep 2020 21:57:38 +0200 Message-ID: <87d02wca8d.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 15:56:30 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 43249@debbugs.gnu.org, guix-patches@gnu.org, mail@brendan.scot X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Prafulla Giri writes: > I wonder.... perhaps it'd be better altogether if the (wrap-program) > procedure could be re-written to not make ..*.real.real programs...? That > would save us a lot of code-duplication... Looking at the definition of wrap-program in (guix build utils) there is code that checks if the wrapper already exists; if it does it should append the new environment variable definitions to the existing wrapper. It looks like this doesn=E2=80=99t work reliably. If someone could figure out why that is we could fix this in the next core-updates cycle. --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 16:12:09 2020 Received: (at 43249-done) by debbugs.gnu.org; 8 Sep 2020 20:12:09 +0000 Received: from localhost ([127.0.0.1]:56529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFjyK-0006TW-TN for submit@debbugs.gnu.org; Tue, 08 Sep 2020 16:12:09 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:57498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFjyG-0006T6-MV; Tue, 08 Sep 2020 16:12:07 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4AF58DE74; Tue, 8 Sep 2020 22:12:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 98v6YOuN9Fmn; Tue, 8 Sep 2020 22:12:02 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::c08]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 401A6DB58; Tue, 8 Sep 2020 22:12:02 +0200 (CEST) Date: Tue, 8 Sep 2020 22:11:44 +0200 From: Andreas Enge To: Brendan Tildesley Subject: Re: bug#43151: Resolve Calibre run-time dependency Message-ID: <20200908201144.GA25269@jurong> References: <6492c3cc-07e0-b56b-ea72-99d403770755@brendan.scot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6492c3cc-07e0-b56b-ea72-99d403770755@brendan.scot> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43249-done Cc: 42885@debbugs.gnu.org, 43249-done@debbugs.gnu.org, Prafulla Giri , 43151-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hello, On Mon, Sep 07, 2020 at 06:15:15PM +1000, Brendan Tildesley wrote: > Your patch also works I think but it will wrap the programs twice, so > you will get calibre, .calibre-real, and ..calibre-real-real, etc for > every program, which seems ugly. My patch reproduces the same PYTHONPATH > that is set in python-build-system in addition to wrapping PYTHONPATH > (unless I made a mistake), although at the cost of code duplication. I > leave it to you and who ever is reviewing this to decide which way is > more correct and push one, haha. thanks to both of your for your patches! I just pushed Brendan's, which wraps only once at the price of copy-pasting from another package. I confirm that it works, also to click on an epub file from within calibre. Closing the two bugs asking about qtwebengine. Concerning the update, is mathjax a required input now, or could we just leave it out and update nevertheless? Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 04:38:53 2020 Received: (at 43249-done) by debbugs.gnu.org; 9 Sep 2020 08:38:54 +0000 Received: from localhost ([127.0.0.1]:57143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFvcz-0007uU-Jq for submit@debbugs.gnu.org; Wed, 09 Sep 2020 04:38:53 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:43292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFvcx-0007u9-1d; Wed, 09 Sep 2020 04:38:52 -0400 Received: by mail-pf1-f178.google.com with SMTP id f18so1522011pfa.10; Wed, 09 Sep 2020 01:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9tZkJi+hK0rHUP1z5Z1ulGFDHmW3fvMmq7LGbzjXSzc=; b=OsHY+nryAlPZVnAPnvDrKORPnIJC9FxW6e6xm8AR2zqKhrkkwb1lBaXhSWHROSsBdE M23CW5X1ZAl049kybmH11LDY5m3JU12qcAQAKtgNfVsMaK79PKRPvQLbpeMqPFFXMhS6 VyCUsnx4K3+pkl6rVw8aqrOw5Lz44qKk5qBYe1O8HMZli9UnffJ9h6LXwp0V2dWXqk4t II9gVN70d7HYhCsuVAQ/KsGkzRYhLJXZBRpRUPk3p39E72/BZVJJXQobl/aJcT9qDKI0 NG0+NYaABqC0XCPrJzY4u1xWNowkJhj3onAUnztvDYUZ2aDgm3nIDJOGlj195WVTbLtc 9WrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tZkJi+hK0rHUP1z5Z1ulGFDHmW3fvMmq7LGbzjXSzc=; b=LCgpnWkLMj1qv5oJmThqwlQb9rbXcT/lNarixilnaDU9zD3YYlfk9pRgXd73CTHsVp Yge1ci2nWkYD9PDOzWzz7NUBDWgau2lXwTyZvq/LuSY0jSUaWldfBUQSgRI4Wz+nBZNN COXiXj3WkL0Z4g0Zt5vE5CZsKEk3oOgPfH2MtzjRNSY4Gk18RDjHnry8141bviN+Tq7X 4670jfpTZJNKbnnYazISVNAjpMMu5r3Jq8nMIa6KnfWIqh+jIlcR7q1eICk5owT9Nffz Ig+PKprhTiNW+6Axw0q0jxt+1sAGp3gqtnOlA6Fz2P/5ckyCccrq8tWXkPw9ivhof7LO LlXQ== X-Gm-Message-State: AOAM532H2FtZ8wP9pWFjtlPrAot/ex2fF+P4TjwoY7wLBNguCPEOi4rX UO91GP02uQ5dmGvW6Y68gKmrH4cNyhrooSu61n4= X-Google-Smtp-Source: ABdhPJx4NlQsmxRhoTYuYD2y1Zpe0pEvznqjHsXosP+t0cF2Ht8ek30oS24IfuX1oh+xQ38hmwBESH0GPIUS7h8mVvg= X-Received: by 2002:a17:902:bc81:: with SMTP id bb1mr2779702plb.105.1599640725003; Wed, 09 Sep 2020 01:38:45 -0700 (PDT) MIME-Version: 1.0 References: <6492c3cc-07e0-b56b-ea72-99d403770755@brendan.scot> <20200908201144.GA25269@jurong> In-Reply-To: <20200908201144.GA25269@jurong> From: Prafulla Giri Date: Wed, 9 Sep 2020 14:23:34 +0545 Message-ID: Subject: Re: bug#43151: Resolve Calibre run-time dependency To: Andreas Enge Content-Type: multipart/alternative; boundary="0000000000002ea3c905aedd61ce" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43249-done Cc: 42885@debbugs.gnu.org, 43249-done@debbugs.gnu.org, Brendan Tildesley , 43151-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002ea3c905aedd61ce Content-Type: text/plain; charset="UTF-8" I see. Thank you for the update. Hopefully (wrap-program) will be fixed soon. That should save us a lot of code-duplication. Congratulations, Mr. Tildesley! (: --0000000000002ea3c905aedd61ce Content-Type: text/html; charset="UTF-8"
I see. Thank you for the update.

Hopefully (wrap-program) will be fixed soon. That should save us a lot of code-duplication.

Congratulations, Mr. Tildesley! (:
--0000000000002ea3c905aedd61ce-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 08:46:45 2020 Received: (at submit) by debbugs.gnu.org; 10 Sep 2020 12:46:45 +0000 Received: from localhost ([127.0.0.1]:37582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGLyP-0005AE-Am for submit@debbugs.gnu.org; Thu, 10 Sep 2020 08:46:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:50380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGLyK-00055t-GJ for submit@debbugs.gnu.org; Thu, 10 Sep 2020 08:46:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGLyK-0008Au-8p for guix-patches@gnu.org; Thu, 10 Sep 2020 08:46:40 -0400 Received: from mout-p-201.mailbox.org ([2001:67c:2050::465:201]:53620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kGLyH-0002H0-HU for guix-patches@gnu.org; Thu, 10 Sep 2020 08:46:39 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4BnJY34RW7zQlWQ; Thu, 10 Sep 2020 14:46:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1599741989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dTOO0DxLjahv3UQeVyui34QluZw3BZ1cBD0qHUxDzB0=; b=oxw/SfXe7Dfv5Soh0l8QyXsWWUh/JqQwvnjJf/Cb7NGwJZ1mTx/WiR9U3zUSBBg1tEAI+y yfKXca+BHqpIuq4zqqVDGzbVfYsGWC8USGicSi7R7KcT5Esc+f4fqpJ+nCEnSIwy722T6s 0dwcR755rxxqyZFJrPkfFrJLf+eVBh/lzboGqjDgSUIhbFOkrpN3uOreVx+bWMUJbdIwab iWfNjk3MA7x/JK2pTm5PD/p3ih/9bSUl1dsN/9tiNbBJ5Gl0OB0t+VQ+XAYcL9Ovb2VQ3I /OBfkcpyPsgJZCmOqZOiuk6oPvDHGMymiNSznLyTgJmBkGzfw1pYLpX/Toc2jg== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id Uup9A_m1h0Ms; Thu, 10 Sep 2020 14:46:28 +0200 (CEST) Subject: Re: [bug#43249] To: Ricardo Wurmus References: <87d02wca8d.fsf@elephly.net> From: Brendan Tildesley Message-ID: <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> Date: Thu, 10 Sep 2020 22:46:33 +1000 MIME-Version: 1.0 In-Reply-To: <87d02wca8d.fsf@elephly.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -1.71 / 15.00 / 15.00 X-Rspamd-Queue-Id: 678DA17BB X-Rspamd-UID: 135af8 Received-SPF: pass client-ip=2001:67c:2050::465:201; envelope-from=mail@brendan.scot; helo=mout-p-201.mailbox.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Prafulla Giri , 43249@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On 9/9/20 5:57 am, Ricardo Wurmus wrote: > Prafulla Giri writes: > >> I wonder.... perhaps it'd be better altogether if the (wrap-program) >> procedure could be re-written to not make ..*.real.real programs...? That >> would save us a lot of code-duplication... > Looking at the definition of wrap-program in (guix build utils) there is > code that checks if the wrapper already exists; if it does it should > append the new environment variable definitions to the existing > wrapper. It looks like this doesn’t work reliably. > > If someone could figure out why that is we could fix this in the next > core-updates cycle. > When given "foo", wrap-program checks if ".foo-real" exists and thus concludes that "foo" is a wrapper and appends, however, despite the fact that the wrapper? procedure exists, it is not actually used at any time to check if ".foo-real" its self was passed to wrap-program. Therefore it happily wraps wrappers if it is given one. For example glib-or-gtk-build-system uses (find-files bindir ".*") to find files to pass to wrap-program. This ".*" regular expression matches hidden dotfiles. I copy-pasted everything to make a new build system and added an error for (wrapper? prog) and it exposed this. changingI guess then we should patch wrap-program to add (when (wrapper? prog)     (error (string-append prog " is a wrapper. Refusing to wrap."))) at the start. Then fix all uses of wrap-program so that they dont recieve -real files. In glib-or-gtk-build-system.scm, chanding bin-list to: (bin-list     (filter (lambda (file) (not (wrapper? file)))                                      (append (find-files bindir ".*")                                              (find-files libexecdir ".*")))) seems to fix it, at least in the case of gedit, a program that currently produces a nested wrapper. Ill play with it more tomorrow. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 09:21:13 2020 Received: (at submit) by debbugs.gnu.org; 10 Sep 2020 13:21:13 +0000 Received: from localhost ([127.0.0.1]:37674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGMVl-0006kt-JD for submit@debbugs.gnu.org; Thu, 10 Sep 2020 09:21:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:46808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGMVk-0006km-8i for submit@debbugs.gnu.org; Thu, 10 Sep 2020 09:21:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGMVk-0006AU-2M for guix-patches@gnu.org; Thu, 10 Sep 2020 09:21:12 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGMVg-00078D-Si for guix-patches@gnu.org; Thu, 10 Sep 2020 09:21:11 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1599744066; cv=none; d=zohomail.com; s=zohoarc; b=YEpx9jxR99kzXDVrKB6kOxoGURuXePpY5Z7Yn3bSE6/eAZ6oqt3X+ZAgxAOBO8OMqc1EjN25ZbG7tWUwTD25QVbdogXH2Yf7IEK6Fdo2xqhiiG0uBz3HLZ1gmWrrRMKjJc1pfrARwi1d87lpQBzJBXr3sUj60wikx5Z6hsTE/40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599744066; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=i9BFjRm9zoXaVw+KhjhMQWEj1dKiw2XPQkutgpyMqqk=; b=MXi/8mzUdWJG41zzbAuhxCPjfwuRoN/x8t+IBn2TC1wiVdFyDp9HN3uRi0zsUH6IOXpH2Fvt564vFf3ROeayBHAe/5BhkW6EQRhivcchNqbEX2k42AM/buKX+RgSrOGKP1PpS7n6HAB1fCWRNT+13WKjngqY5XGU7q7J2UhKNWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1599744065; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; bh=i9BFjRm9zoXaVw+KhjhMQWEj1dKiw2XPQkutgpyMqqk=; b=bVoBdMIQdlKR4obMCj90hX6NkmcDUgC55w06nQl8RIMtahwKHpqcbBitKPPqHdrM gaOncrvZyCW31NQcRCK8Vm8NR+Ns/+iXA4Xf7fxMG2Qgwb8PFycedsT14Io1VQy7B3a PDy4MdULInT8mgIAZV1ajXWEVb9JTNxNhWcSgOTQ= Received: from localhost (p54ad4af6.dip0.t-ipconnect.de [84.173.74.246]) by mx.zohomail.com with SMTPS id 1599744063978689.0153058032444; Thu, 10 Sep 2020 06:21:03 -0700 (PDT) References: <87d02wca8d.fsf@elephly.net> <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus To: Brendan Tildesley Subject: Re: [bug#43249] In-reply-to: <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 10 Sep 2020 15:22:17 +0200 Message-ID: <87tuw54vhy.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 08:32:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Prafulla Giri , 43249@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Brendan Tildesley writes: > I guess then we should patch wrap-program to add > > (when (wrapper? prog) > (error (string-append prog " is a wrapper. Refusing to wrap."))) Should it really refuse to wrap or *add* its variables to the existing wrapper? -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 04:18:31 2020 Received: (at submit) by debbugs.gnu.org; 11 Sep 2020 08:18:31 +0000 Received: from localhost ([127.0.0.1]:42232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGeGN-0001mk-6I for submit@debbugs.gnu.org; Fri, 11 Sep 2020 04:18:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:56304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGeGI-0001mS-FB for submit@debbugs.gnu.org; Fri, 11 Sep 2020 04:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGeGI-00046k-9o for guix-patches@gnu.org; Fri, 11 Sep 2020 04:18:26 -0400 Received: from mout-p-201.mailbox.org ([2001:67c:2050::465:201]:14662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kGeGF-0007kn-Fq for guix-patches@gnu.org; Fri, 11 Sep 2020 04:18:25 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4BnpY70RhzzQlKL; Fri, 11 Sep 2020 10:18:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1599812297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rjyVwzRasrsJ+QUOhQ05CIaXeammTB0FYsNxIOqE/fY=; b=rCpsFUBejLZTkDHU/t+50m3DQTNRLFmLVlQ0cN7Ap6jhqFDTcPUwBmJz/jNFqZK3PV/Nbh iTDcycukgQUdex2/qXhkKCluw9eHrPFDgSaIUyCgm1mbMwiPrw+TzwEnKG2pgqfHybRasR y8yETCZQoycOTNnJvAy7uHSVl2EsxYrfmfdl1jTp8DQy+aHMAo2H52TGJWVuy0mWuUWZ7G Us8gsAYq+nhsPpuqB7IoDJq49AfegPlecquOkYFeHdA4kQUhg5jKvgb91vjxAVjyTvJzvG 2jm4Zn1pdnl4ZdzDFLTkQnHlJ85/S1dS4IDBLamNUzPfcMriPai/gMRKrLnz+Q== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id XcQBYf95kg_L; Fri, 11 Sep 2020 10:18:15 +0200 (CEST) Subject: Re: [bug#43249] To: Ricardo Wurmus References: <87d02wca8d.fsf@elephly.net> <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> <87tuw54vhy.fsf@elephly.net> From: Brendan Tildesley Message-ID: Date: Fri, 11 Sep 2020 18:18:21 +1000 MIME-Version: 1.0 In-Reply-To: <87tuw54vhy.fsf@elephly.net> Content-Type: multipart/alternative; boundary="------------FB5D643FC194339E6F97494A" Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -4.69 / 15.00 / 15.00 X-Rspamd-Queue-Id: AD2C226E X-Rspamd-UID: 5e64ca Received-SPF: pass client-ip=2001:67c:2050::465:201; envelope-from=mail@brendan.scot; helo=mout-p-201.mailbox.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Prafulla Giri , 43249@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------FB5D643FC194339E6F97494A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/9/20 11:22 pm, Ricardo Wurmus wrote: > Brendan Tildesley writes: > >> I guess then we should patch wrap-program to add >> >> (when (wrapper? prog) >> (error (string-append prog " is a wrapper. Refusing to wrap."))) > Should it really refuse to wrap or *add* its variables to the existing > wrapper? > If there is a /bin/foo and /bin/.foo-real created by wrap-program, and we are to run another wrap-program phase, under what circumstances would it /not/ be a mistake to call (wrap-program "/bin/.foo-real") instead of (wrap-program "/bin/foo")? And if the first one was called, probably it was because find-files was used and the packager didn't realise it was happening, and therefore it will be double-wrapped, like gedit is. --------------FB5D643FC194339E6F97494A Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 10/9/20 11:22 pm, Ricardo Wurmus wrote:
Brendan Tildesley <mail@brendan.scot> writes:


I guess then we should patch wrap-program to add

(when (wrapper? prog)
    (error (string-append prog " is a wrapper. Refusing to wrap.")))

Should it really refuse to wrap or *add* its variables to the existing
wrapper?

If there is a /bin/foo and /bin/.foo-real created by wrap-program, and we are to run another wrap-program phase, under what circumstances would it not be a mistake to call (wrap-program "/bin/.foo-real") instead of (wrap-program "/bin/foo")? And if the first one was called, probably it was because find-files was used and the packager didn't realise it was happening, and therefore it will be double-wrapped, like gedit is.

--------------FB5D643FC194339E6F97494A-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 04:37:53 2020 Received: (at 43249) by debbugs.gnu.org; 11 Sep 2020 08:37:53 +0000 Received: from localhost ([127.0.0.1]:42260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGeZ7-0002IA-2H for submit@debbugs.gnu.org; Fri, 11 Sep 2020 04:37:53 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGeZ5-0002I2-3H for 43249@debbugs.gnu.org; Fri, 11 Sep 2020 04:37:51 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1599813462; cv=none; d=zohomail.com; s=zohoarc; b=iL0sl3u2hs4N1+nguxVzm6s86MOCukyp27DGZcKZSAOTClpNGL8xcc4LtX518K8OogbWvD5o1bC6rsbH13wxrZSKx+JaRUDD/sVMggDjrRWpR9JA7BUkLbct+D9alnxYRNgY3Fmo2lyK0jb2/5yFqBn4flZ+ecXpgGgCzdCRQDY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599813462; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=30zCCqxoqLrrPzfnTjl0i/btEuYxFy4HvUAlFa6R56c=; b=Fifrnq+E965RI2fZaybGfyukqQ5s2j7W/xnf95Gb5yZb1jf2a35VHCG0cAbO5X/vQJ1HVJjmJTKFRroHKsCHh8D1P81b2LtCOFAZCmzWQAFh7SYX/aAAYCxqkVOn6zX4UgCJLeS7Hd+MAawFQJd+HuRdDGe+NUiIM3VPAzb88Pg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1599813462; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; bh=30zCCqxoqLrrPzfnTjl0i/btEuYxFy4HvUAlFa6R56c=; b=K+dGwprp/spnMJxR+px6TNzYXn54V5jzb76hOdfdf49wBhhs/+ab62KKTpgJPN+f mc6X42nsV87lX+MNkJ9byAKBLxUcM6HPeFStJwtIU6Ish8eo2mhpwaPQvYzmPShcncz Cpx7ntN/mZvrqMmA9d3khoD3DeyLFiaHYANZI5YA= Received: from localhost (p54ad420a.dip0.t-ipconnect.de [84.173.66.10]) by mx.zohomail.com with SMTPS id 1599813460782346.3573145037126; Fri, 11 Sep 2020 01:37:40 -0700 (PDT) References: <87d02wca8d.fsf@elephly.net> <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> <87tuw54vhy.fsf@elephly.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus To: Brendan Tildesley Subject: Re: [bug#43249] In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Fri, 11 Sep 2020 10:38:55 +0200 Message-ID: <87een83dy8.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43249 Cc: Prafulla Giri , 43249@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brendan Tildesley writes: > On 10/9/20 11:22 pm, Ricardo Wurmus wrote: >> Brendan Tildesley writes: >> >>> I guess then we should patch wrap-program to add >>> >>> (when (wrapper? prog) >>> (error (string-append prog " is a wrapper. Refusing to wrap."))) >> Should it really refuse to wrap or *add* its variables to the existing >> wrapper? >> > If there is a /bin/foo and /bin/.foo-real created by wrap-program, and > we are to run another wrap-program phase, under what circumstances > would it /not/ be a mistake to call (wrap-program "/bin/.foo-real") > instead of (wrap-program "/bin/foo")? And if the first one was called, > probably it was because find-files was used and the packager didn't > realise it was happening, and therefore it will be double-wrapped, > like gedit is. Oh, yes, that would be a mistake. -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 12 07:34:01 2020 Received: (at 43249) by debbugs.gnu.org; 12 Sep 2020 11:34:02 +0000 Received: from localhost ([127.0.0.1]:46485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH3n7-0005RD-Kx for submit@debbugs.gnu.org; Sat, 12 Sep 2020 07:34:01 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:12516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH3n5-0005Qw-OM for 43249@debbugs.gnu.org; Sat, 12 Sep 2020 07:34:00 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4BpVrK3ZttzQkK4; Sat, 12 Sep 2020 13:33:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1599910431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CeP7Tn3wXYvrlTxHSlkBinge141zIxKnmmk7p6oioi0=; b=CBDo9ds2d+TGopN1LgMYpItuobBbFctI7GAg7Ta6J6da0Xz09hxfILKrYK7k1p7BWhd5q9 dC443F6RlEx+2t5KFj/Q58OGxiV8y7MEY71qZgGu66tAjPePhm1w5PhTo9+4CmrOerTr1z 5o00EtuqmhQXe0/5Hf2LADIgIhlZDh6wLE1hTrrAXW4EKy9jwchCKnvp3/MFfDqEvf5wDE nhe3icKgkj49l1LIYnQIxTKbYaNdsqL6wJ/P/q/x2czzLFo3TyzRYx5F054oVDkgfaoQ7G aAZP82uk73TRZWL+oG93UpcxJWogDF8DoDIF4Cw8cEGkeBV2i3+5OUZvlFq+8A== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id 0DBM984UN1fC; Sat, 12 Sep 2020 13:33:50 +0200 (CEST) Subject: Re: [bug#43249] To: Ricardo Wurmus References: <87d02wca8d.fsf@elephly.net> <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> <87tuw54vhy.fsf@elephly.net> <87een83dy8.fsf@elephly.net> From: Brendan Tildesley Message-ID: <00cb09fe-a5bb-2713-6683-bbda733f4839@brendan.scot> Date: Sat, 12 Sep 2020 21:33:57 +1000 MIME-Version: 1.0 In-Reply-To: <87een83dy8.fsf@elephly.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -4.87 / 15.00 / 15.00 X-Rspamd-Queue-Id: 5E19417AB X-Rspamd-UID: 9a9a24 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43249 Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 43249@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 11/9/20 6:38 pm, Ricardo Wurmus wrote: > Brendan Tildesley writes: > >> On 10/9/20 11:22 pm, Ricardo Wurmus wrote: >>> Brendan Tildesley writes: >>> >>>> I guess then we should patch wrap-program to add >>>> >>>> (when (wrapper? prog) >>>> (error (string-append prog " is a wrapper. Refusing to wrap."))) >>> Should it really refuse to wrap or *add* its variables to the existing >>> wrapper? >>> >> If there is a /bin/foo and /bin/.foo-real created by wrap-program, and >> we are to run another wrap-program phase, under what circumstances >> would it /not/ be a mistake to call (wrap-program "/bin/.foo-real") >> instead of (wrap-program "/bin/foo")? And if the first one was called, >> probably it was because find-files was used and the packager didn't >> realise it was happening, and therefore it will be double-wrapped, >> like gedit is. > Oh, yes, that would be a mistake. > While we're at it, what do you think about changing the moved file from /bin/.foo-real into /bin/.real/foo, or maybe it would have to go up a directory and go into /.bin-real/foo. That would mean all these dot files wouldn't pollute PATH and appear in things like bemenu, or in window titles. Also pkill should be able to kill correctly based on the name. Would it break more things somehow? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 12 08:20:56 2020 Received: (at 43249) by debbugs.gnu.org; 12 Sep 2020 12:20:57 +0000 Received: from localhost ([127.0.0.1]:46540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH4WW-0000J7-MH for submit@debbugs.gnu.org; Sat, 12 Sep 2020 08:20:56 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH4WS-0000Iv-6a for 43249@debbugs.gnu.org; Sat, 12 Sep 2020 08:20:55 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1599913237; cv=none; d=zohomail.com; s=zohoarc; b=mo3Yvs9gryUcGLGT97VcuXkVolaZaEVbRLBifAJU0vOHCrv3ovq81hY07a86LOsEr75Irf0P+xTr7Zp8ccAijYktpVdG+DH33lBD+fgiEHaPiaIiHxu0heeeQgq9Ke7kqlWyLxLh78Q1brGsMjcodE/ti5AGc4akO2oqdEzxNXY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599913237; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=AZu7bPnC5akm/MQn6wY4/R0d+812xSc49hxSJg4LvSk=; b=Lm5p3IJCtWdgaJpnF+gfE+w7AG3a/iGL288mrH/9+OpgO7K9stYSlVBoFUwGwWXkBmWWhuw/xUDhGX5VIlhoG7IXrlZGb2hERVU0gWOCcS7Kpq5hTb3SSlCPjwJ3miEnQ+s6parH4CNaKPsaKKZtGIzTXWHEnMfAtlapWJL0pjk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1599913237; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=AZu7bPnC5akm/MQn6wY4/R0d+812xSc49hxSJg4LvSk=; b=Ud9I9nHYZlQNNVsnC4WA5WxJ/jqBzPG/UtCL2bnDVWV4EE7laqS2Os1ooVjXY77S woXM6nFNPauE4ISWPzwa+oJC6IuY5oGCa9mCqL51QCrOZuHvK/nWsDN7JHmeFwhHlEa Ap0ciOJWHdW1HElG0NYz6X8a2sXkzlC6viSXEnjQ= Received: from localhost (p4fd5a35d.dip0.t-ipconnect.de [79.213.163.93]) by mx.zohomail.com with SMTPS id 1599913235319789.1644065146404; Sat, 12 Sep 2020 05:20:35 -0700 (PDT) References: <87d02wca8d.fsf@elephly.net> <330470a6-e6d2-e679-32ac-a308d89a5e92@brendan.scot> <87tuw54vhy.fsf@elephly.net> <87een83dy8.fsf@elephly.net> <00cb09fe-a5bb-2713-6683-bbda733f4839@brendan.scot> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus To: Brendan Tildesley Subject: Re: [bug#43249] In-reply-to: <00cb09fe-a5bb-2713-6683-bbda733f4839@brendan.scot> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sat, 12 Sep 2020 14:21:50 +0200 Message-ID: <877dsz18yp.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43249 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 43249@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brendan Tildesley writes: > On 11/9/20 6:38 pm, Ricardo Wurmus wrote: >> Brendan Tildesley writes: >> >>> On 10/9/20 11:22 pm, Ricardo Wurmus wrote: >>>> Brendan Tildesley writes: >>>> >>>>> I guess then we should patch wrap-program to add >>>>> >>>>> (when (wrapper? prog) >>>>> (error (string-append prog " is a wrapper. Refusing to wrap."))) >>>> Should it really refuse to wrap or *add* its variables to the existing >>>> wrapper? >>>> >>> If there is a /bin/foo and /bin/.foo-real created by wrap-program, and >>> we are to run another wrap-program phase, under what circumstances >>> would it /not/ be a mistake to call (wrap-program "/bin/.foo-real") >>> instead of (wrap-program "/bin/foo")? And if the first one was called, >>> probably it was because find-files was used and the packager didn't >>> realise it was happening, and therefore it will be double-wrapped, >>> like gedit is. >> Oh, yes, that would be a mistake. >> > While we're at it, what do you think about changing the moved file > from /bin/.foo-real into /bin/.real/foo, or maybe it would have to go > up a directory and go into /.bin-real/foo. That would mean all these > dot files wouldn't pollute PATH and appear in things like bemenu, or > in window titles. Also pkill should be able to kill correctly based on > the name. Would it break more things somehow? I=E2=80=99d rather not move these things to other directories because some applications are very sensitive to relative location. I think we should be using =E2=80=9Cwrap-script=E2=80=9D where possible (be= cause many wrapped applications really are scripts) and think of another in-place wrapping mechanism for binaries. --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 13 08:43:32 2020 Received: (at 43249) by debbugs.gnu.org; 13 Sep 2020 12:43:32 +0000 Received: from localhost ([127.0.0.1]:49656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRLv-0007CK-Mp for submit@debbugs.gnu.org; Sun, 13 Sep 2020 08:43:31 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:63496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRLt-0007C6-9n for 43249@debbugs.gnu.org; Sun, 13 Sep 2020 08:43:30 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Bq8L311PnzKmVl; Sun, 13 Sep 2020 14:43:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1600000999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=50zWKIK3tONiIzapLLtCdKnld09WVvKfBbqvSbZnGBM=; b=LIqaTUrkNHbctD/Ys9eDuxueHqwkFwBgXe6k9H8ehi8AGKklcV5l0R7g5oy7II7opOdskv DQOUze8IaE4orU2vxoXded/qMZwbEOvn5tfkZXsFFUMeHFti7R8cewSuyom38vTnulcc93 Aje4n/i6BTYDW9j3VlR2uunmPGLs8VVKjDqKHVwL3qOZgg0hrDclEMmjkctix/tixat7hO uc7P9e8GXkGrO5EE6AnW+Z2vhAQnkhBB3RfO39wpKnHZ4tOojtQX0/JIuy2WsttaftX2FW L7Y/q2KJuhbcAkIfYA+d/SSW1icseqmcn2GN5aVSUUqoLENX28Zkwi5f2OyFLw== Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id GGgqqGPGBLRz; Sun, 13 Sep 2020 14:43:17 +0200 (CEST) Subject: Re: To: Prafulla Giri References: From: Brendan Tildesley Message-ID: Date: Sun, 13 Sep 2020 22:43:27 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------AABFCF0CE2F18ECFDB157F22" Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -2.06 / 15.00 / 15.00 X-Rspamd-Queue-Id: DDCDA14E4 X-Rspamd-UID: 746e69 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43249 Cc: Andreas Enge , 43249@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------AABFCF0CE2F18ECFDB157F22 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/9/20 10:22 pm, Prafulla Giri wrote: > I see. > > Yes, it does make sense now why you chose to replace the 'wrap phase. > > I wonder.... perhaps it'd be better altogether if the (wrap-program) > procedure could be re-written to not make ..*.real.real programs...? > That would save us a lot of code-duplication... I have come to understand wrap-program a little better and I realised your patch could have actually been fixed in a better way than I did. The issue is with the part of your code that runs (find-files "." ".*") This is what matches all the .calibre-real files If instead of that, it was: (find-files "." (lambda (file stat) (not (wrapper? file)))) or (find-files "." (lambda (file stat) (not (string-prefix "." (basename file)))) It should avoid double wrapping. An even simpler way would have been to use (add-before 'wrap ..., instead of (add-after 'wrap ... If you are still interested, feel free to make a patch overwriting mine to use this more correct method, instead of where i duplicated the wrap PYTHONPATH bit. The fact that this happened is a bug though. I created some patches I think fix this for core-updates. It would have made your original patch error and force you to fix it: https://issues.guix.gnu.org/43367 --------------AABFCF0CE2F18ECFDB157F22 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 8/9/20 10:22 pm, Prafulla Giri wrote:
I see.

Yes, it does make sense now why you chose to replace the 'wrap phase.

I wonder.... perhaps it'd be better altogether if the (wrap-program) procedure could be re-written to not make ..*.real.real programs...? That would save us a lot of code-duplication...

I have come to understand wrap-program a little better and I realised your patch could have actually been fixed in a better way than I did. The issue is with the part of your code that runs


(find-files "." ".*")


This is what matches all the .calibre-real files

If instead of that, it was:

(find-files "." (lambda (file stat) (not (wrapper? file))))

or

(find-files "." (lambda (file stat) (not (string-prefix "." (basename file))))

It should avoid double wrapping. An even simpler way would have been to use (add-before 'wrap ..., instead of (add-after 'wrap ...

If you are still interested, feel free to make a patch overwriting mine to use this more correct method, instead of where i duplicated the wrap PYTHONPATH bit.

The fact that this happened is a bug though. I created some patches I think fix this for core-updates. It would have made your original patch error and force you to fix it: https://issues.guix.gnu.org/43367


  


--------------AABFCF0CE2F18ECFDB157F22--




From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 07:51:14 2020
Received: (at 43249) by debbugs.gnu.org; 15 Sep 2020 11:51:14 +0000
Received: from localhost ([127.0.0.1]:57452 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from )
	id 1kI9UI-0000ym-Cq
	for submit@debbugs.gnu.org; Tue, 15 Sep 2020 07:51:14 -0400
Received: from mail-pj1-f47.google.com ([209.85.216.47]:54186)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from ) id 1kI9UG-0000yI-9x
 for 43249@debbugs.gnu.org; Tue, 15 Sep 2020 07:51:05 -0400
Received: by mail-pj1-f47.google.com with SMTP id t7so1644779pjd.3
 for <43249@debbugs.gnu.org>; Tue, 15 Sep 2020 04:51:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=8dp96gIfpaoFnBPFgMaNe8CHtwy7TIZov++DAZ7k/Hk=;
 b=d8xlc4iwX5SxJJ3hZp3XzkEOkrUIpWrkb/WMtf/lGE/FAwXHG8Ah6nZHLIWTf6+MJc
 Pt1iE97GKRbUpsUBc3glXac9R2luStzulTnCponGAFXKdu3kbyaiXh8FArVuIFVrfZZX
 R+DFIctq8Rs6XM9cHZI6Icsr9Z25UwZMeRYGu1yPFUmdf/Rl/ZxP+mlqBIxK4MVAiECF
 7I10Gnw6JKONf+dNSgHGkuqG9s2s7cip7NG1F9GBmVR9zD4XgXqxJg/yOjlM1gSf+CPt
 0rqLX/9Tf6idBSfw5hNRaTMIOU5v2uMcNxYB8X9aLD56IDteU2PaNfmQKwSMT2mTxVO7
 UY5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=8dp96gIfpaoFnBPFgMaNe8CHtwy7TIZov++DAZ7k/Hk=;
 b=P3T32ctVN9DrpOsrAE+LJ0qBdaka0bn1H/g3k8uvxfkM4cmO874714yohVEZExKWCB
 yv1hPrMNOE4wsbZEZZzVB1Mnob6dfdA1oOCWcOt5gXOqgDw5wMkWwI9wPHeO3+1ZEzqW
 tHWMM3+Fo1bioPJJf1hDsvN77A9AAettHdbVr1oCG9LIjhKcHEXn+lGRhTsFZJMvpBde
 X+sQN4hOf4dOHE2gScnBZsdSI96Su2r7grmpHeknVYM2JNW8+hX9/Z7bvs1vKzLW4vIV
 AyZZtEvE4mzhGfBj7XCiaf+i9+rTrob0viviM7SYF7ENLkk1cXuAsnjaBqcti8PxrvIR
 BE8w==
X-Gm-Message-State: AOAM532eq2EWal8uksa3Yd8dSamWuu8viEfMjaExIKjZ2YiIUl2u/EzP
 eMPs8QJvGlYHIOfvym3g9CiH+aPaV/nDTqE0gVeIOJMvdy94uw==
X-Google-Smtp-Source: ABdhPJxRNL2QhHyY17IEaFT5KOHfS3ZsYG34XWTuBFBcWEAQCWw3ipf077a+tUM5kWmHosTMVM/a9ADAo0syulv7fQ4=
X-Received: by 2002:a17:90b:ecc:: with SMTP id
 gz12mr3580858pjb.219.1600170658391; 
 Tue, 15 Sep 2020 04:50:58 -0700 (PDT)
MIME-Version: 1.0
References: 
 
In-Reply-To: 
From: Prafulla Giri 
Date: Tue, 15 Sep 2020 17:35:47 +0545
Message-ID: 
Subject: Re:
To: Brendan Tildesley 
Content-Type: multipart/alternative; boundary="000000000000ac6a7305af58c3c2"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43249
Cc: 43249@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: 
List-Unsubscribe: , 
 
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: , 
 
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" 
X-Spam-Score: -1.0 (-)

--000000000000ac6a7305af58c3c2
Content-Type: text/plain; charset="UTF-8"

Dear Mr. Tildesley,

I have sent in a patch to do as you've suggested.
https://issues.guix.gnu.org/43419

Thank you very much.

I will remember this trick of not wrapping wrappers from now on. Thank you
very much.

On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley  wrote:

> On 8/9/20 10:22 pm, Prafulla Giri wrote:
>
> I see.
>
> Yes, it does make sense now why you chose to replace the 'wrap phase.
>
> I wonder.... perhaps it'd be better altogether if the (wrap-program)
> procedure could be re-written to not make ..*.real.real programs...? That
> would save us a lot of code-duplication...
>
> I have come to understand wrap-program a little better and I realised your
> patch could have actually been fixed in a better way than I did. The issue
> is with the part of your code that runs
>
>
> (find-files "." ".*")
>
>
> This is what matches all the .calibre-real files
> If instead of that, it was:
>
> (find-files "." (lambda (file stat) (not (wrapper? file))))
>
> or
>
> (find-files "." (lambda (file stat) (not (string-prefix "." (basename
> file))))
> It should avoid double wrapping. An even simpler way would have been to
> use (add-before 'wrap ..., instead of (add-after 'wrap ...
>
> If you are still interested, feel free to make a patch overwriting mine to
> use this more correct method, instead of where i duplicated the wrap
> PYTHONPATH bit.
>
> The fact that this happened is a bug though. I created some patches I
> think fix this for core-updates. It would have made your original patch
> error and force you to fix it: https://issues.guix.gnu.org/43367
>
>

--000000000000ac6a7305af58c3c2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Dear Mr. Tildesley,

I have s=
ent in a patch to do as you've suggested. https://issues.guix.gnu.org/43419

=

Thank you very much.

I will remember this tri=
ck of not wrapping wrappers from now on. Thank you very much.

On S=
un, Sep 13, 2020 at 6:28 PM Brendan Tildesley <mail@brendan.scot> wro=
te:

 =20
   =20
 =20
  

    
On 8/9/20 10:22 pm, Prafulla Giri
      wrote:

    

    

     =20
      

        
I see.

        


        

        
Yes, it does make sense now why you chose to replace the
          'wrap phase.

        


        

        
I wonder.... perhaps it'd be better altogether if the
          (wrap-program) procedure could be re-written to not make
          ..*.real.real programs...? That would save us a lot of
          code-duplication...

      

    

    
I have come to understand wrap-program a little better and I
      realised your patch could have actually been fixed in a better way
      than I did. The issue is with the part of your code that runs

    


    

    (find-files "." ".*")

    


    

    
This is what matches all the .calibre-real files

    If instead of that, it was:

    

    
(find-files "." (lambda (file stat) (not (wrapper? file)))=
) 

    

    
or 

    

    

      (find-files "." (lambda (file stat) (not (string-prefix &qu=
ot;."
      (basename file))))
    

    It should avoid double wrapping. An even simpler way would have been
    to use (add-before 'wrap ..., instead of (add-after 'wrap ...
    

    If you are still interested, feel free to make a patch overwriting
    mine to use this more correct method, instead of where i duplicated
    the wrap PYTHONPATH bit.

    
The fact that this happened is a bug though. I created some
      patches I think fix this for core-updates. It would have made your
      original patch error and force you to fix it:
      https=
://issues.guix.gnu.org/43367

    

    

  





--000000000000ac6a7305af58c3c2--




From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 09:26:25 2020
Received: (at 43249) by debbugs.gnu.org; 18 Sep 2020 13:26:25 +0000
Received: from localhost ([127.0.0.1]:41302 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from )
	id 1kJGPA-0000k0-NW
	for submit@debbugs.gnu.org; Fri, 18 Sep 2020 09:26:25 -0400
Received: from mail-pj1-f44.google.com ([209.85.216.44]:39854)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from ) id 1kJGP9-0000jo-9a
 for 43249@debbugs.gnu.org; Fri, 18 Sep 2020 09:26:23 -0400
Received: by mail-pj1-f44.google.com with SMTP id v14so3021346pjd.4
 for <43249@debbugs.gnu.org>; Fri, 18 Sep 2020 06:26:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=v/bzjBtiQydfT55xtQ0CYJWRfcVkmCUXuJkGM8T1CYk=;
 b=fh3NBE0nGmwN6WQYdn+oFjeiaJ9cvVglr4RI+V14NjFUQKujVGzEfS9RtsG/mMn1TO
 nC/6VgL1U7uBWr534EKiaPpLK00UkuO0aRK82gaM4+oUZ3yWcLXYPlM+zIykiwg+4dKm
 THGoXmsihJcoONnT6EU+YncFud0JDFJryWM9qJc7B+tkdFfX1fo1udLJCWyqJei4nYXO
 0Ddcj6Nhdsi2qFDUzNUm+xVYYeHKeNl9urNGGs+NUYRmxxEIE81Lwn8ajS/sf5I0DRwZ
 RnKM9PaIZxvsWxasrpc5gudgQvQgpVq+GB99AeY80kP3JMu3i0WQ+IX1C/3iPTKU6WYv
 DVuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=v/bzjBtiQydfT55xtQ0CYJWRfcVkmCUXuJkGM8T1CYk=;
 b=KlOOsPsWhtLtmsdiQYBQSrQGegLTfw5PZb6qpi97WYhV1zimli0MnuE53rkkZt6hRQ
 vbG8Oed59CyV7iuxfC9iEz+CW/i4Uby2wVRU38Gcc4bMSLjYXnchv7hnii34LG/3yuG5
 xzf12Q1hLl7UjtInKORLPazU+bSh+5IgZIFyLcFg/QeDpEQamvqDqfywRxkcDEU6c3QQ
 RZqFSIYKFM3rWtw7TKDYRhpFg1Pmp7iWWjdy2gcpR+AoJ+ox6mvKzmRplDmaReDgZ5nh
 YAKGEd87hADKA2CX6nFiQeUHNnEOcfz/jtCk+VE/8DxZdNUwEqbe+0xasKJ2PMiGxnAl
 sYCA==
X-Gm-Message-State: AOAM530EBkbhPozmOHLMp8qjy27ClyeCSWV3/Zupd5Pc9ELSS4+UkJHr
 N05BK7eAKTG9TNsqVeh+2SvnqvISrj1pKkJCUNyraoHPq7Txbw==
X-Google-Smtp-Source: ABdhPJyfoDuBPPlOdA4a+3tMq15dVSsHqBnkb7aHBg+VBOpeEtuD5Ce5VGGl1aziKkbmNOfbfmmZadu7a0UNoKzAvx4=
X-Received: by 2002:a17:902:b583:b029:d1:c807:da44 with SMTP id
 a3-20020a170902b583b02900d1c807da44mr23919177pls.15.1600435576629; Fri, 18
 Sep 2020 06:26:16 -0700 (PDT)
MIME-Version: 1.0
References: 
 
 
In-Reply-To: 
From: Prafulla Giri 
Date: Fri, 18 Sep 2020 19:11:05 +0545
Message-ID: 
Subject: Re:
To: Brendan Tildesley 
Content-Type: multipart/alternative; boundary="00000000000007eddb05af967202"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43249
Cc: 43249@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: 
List-Unsubscribe: , 
 
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: , 
 
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" 
X-Spam-Score: -1.0 (-)

--00000000000007eddb05af967202
Content-Type: text/plain; charset="UTF-8"

Mr. Tildesley,

The patch has just been merged: https://issues.guix.gnu.org/43419#1

Thank you for your guidance!

On Tue, Sep 15, 2020 at 5:35 PM Prafulla Giri 
wrote:

> Dear Mr. Tildesley,
>
> I have sent in a patch to do as you've suggested.
> https://issues.guix.gnu.org/43419
>
> Thank you very much.
>
> I will remember this trick of not wrapping wrappers from now on. Thank you
> very much.
>
> On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley 
> wrote:
>
>> On 8/9/20 10:22 pm, Prafulla Giri wrote:
>>
>> I see.
>>
>> Yes, it does make sense now why you chose to replace the 'wrap phase.
>>
>> I wonder.... perhaps it'd be better altogether if the (wrap-program)
>> procedure could be re-written to not make ..*.real.real programs...? That
>> would save us a lot of code-duplication...
>>
>> I have come to understand wrap-program a little better and I realised
>> your patch could have actually been fixed in a better way than I did. The
>> issue is with the part of your code that runs
>>
>>
>> (find-files "." ".*")
>>
>>
>> This is what matches all the .calibre-real files
>> If instead of that, it was:
>>
>> (find-files "." (lambda (file stat) (not (wrapper? file))))
>>
>> or
>>
>> (find-files "." (lambda (file stat) (not (string-prefix "." (basename
>> file))))
>> It should avoid double wrapping. An even simpler way would have been to
>> use (add-before 'wrap ..., instead of (add-after 'wrap ...
>>
>> If you are still interested, feel free to make a patch overwriting mine
>> to use this more correct method, instead of where i duplicated the wrap
>> PYTHONPATH bit.
>>
>> The fact that this happened is a bug though. I created some patches I
>> think fix this for core-updates. It would have made your original patch
>> error and force you to fix it: https://issues.guix.gnu.org/43367
>>
>>

--00000000000007eddb05af967202
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Mr. Tildesley,

The patch has=
 just been merged: https://=
issues.guix.gnu.org/43419#1

Thank you for your=
 guidance!

On Tue, Sep 15, 2020 at 5:35 PM Prafulla Giri <pratheblackdiamond@gmail.com=
> wrote:
Dear Mr. Tildesley,

I have sent =
in a patch to do as you've suggested. https://issues.guix.gnu.org/43419
<=
div>
Thank you very much.

I will rem=
ember this trick of not wrapping wrappers from now on. Thank you very much.=


On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley <mail@brenda=
n.scot> wrote:

     =20
      

        
I see.

        


        

        
Yes, it does make sense now why you chose to replace the
          'wrap phase.

        


        

        
I wonder.... perhaps it'd be better altogether if the
          (wrap-program) procedure could be re-written to not make
          ..*.real.real programs...? That would save us a lot of
          code-duplication...

      

    

    
I have come to understand wrap-program a little better and I
      realised your patch could have actually been fixed in a better way
      than I did. The issue is with the part of your code that runs

    


    

    (find-files "." ".*")

    


    

    
This is what matches all the .calibre-real files

    If instead of that, it was:

    

    
(find-files "." (lambda (file stat) (not (wrapper? file)))=
) 

    

    
or 

    

    

      (find-files "." (lambda (file stat) (not (string-prefix &qu=
ot;."
      (basename file))))
    

    It should avoid double wrapping. An even simpler way would have been
    to use (add-before 'wrap ..., instead of (add-after 'wrap ...
    

    If you are still interested, feel free to make a patch overwriting
    mine to use this more correct method, instead of where i duplicated
    the wrap PYTHONPATH bit.

    
The fact that this happened is a bug though. I created some
      patches I think fix this for core-updates. It would have made your
      original patch error and force you to fix it:
      https=
://issues.guix.gnu.org/43367

    

    

  





--00000000000007eddb05af967202--




From unknown Fri Jun 20 07:11:00 2025
Received: (at fakecontrol) by fakecontrolmessage;
To: internal_control@debbugs.gnu.org
From: Debbugs Internal Request 
Subject: Internal Control
Message-Id: bug archived.
Date: Sat, 17 Oct 2020 11:24:07 +0000
User-Agent: Fakemail v42.6.9

# This is a fake control message.
#
# The action:
# bug archived.
thanks
# This fakemail brought to you by your local debbugs
# administrator