From unknown Fri Aug 15 20:05:19 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43245] [PATCH] gnu: xournalpp: Fix path to addr2line binary Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Sep 2020 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43245 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43245@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159940632319267 (code B ref -1); Sun, 06 Sep 2020 15:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Sep 2020 15:32:03 +0000 Received: from localhost ([127.0.0.1]:46854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEweB-00050h-GM for submit@debbugs.gnu.org; Sun, 06 Sep 2020 11:32:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:53604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEwe9-00050I-CM for submit@debbugs.gnu.org; Sun, 06 Sep 2020 11:32:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEwe9-0008KF-5S for guix-patches@gnu.org; Sun, 06 Sep 2020 11:32:01 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050::465:101]:27146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kEwe6-00028w-BZ for guix-patches@gnu.org; Sun, 06 Sep 2020 11:32:00 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4BkwPg0zLGzKmRV for ; Sun, 6 Sep 2020 17:31:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1599406309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sNqpPlzqbTNPjPNlj6nZpniQqZZIUn19BbdCOuQQjWI=; b=VIOTy8ABZzqzY+4mWtdD+UO8UGl9GWwA+X5ZZtP9M0KE761FIURHrMxzwrvxDQqjY5Aeke n3KvDRLyYw7PyWmlCUJsMNK8D5D2PvInrdesP30C3eo9pn4IWo3eFxALTpNrCzDh8mEizc a+d/egc+y39f24toPPOagTjargpkA1vFkvzVtkr+aBYwc5jZPPM9W+l+w9gSzBIYSE+Rpb 2Jvejmi5JFo99GFq9+FFihHuYd+qTUDnRJjPMgXsAP4DAYGRXQl43QELYa385KyI6U+P80 8/K0qR1s/zNULgHqecixDAL1stHTSRJA+Elo6MvhUEDxfDgIvt3QnZoPMCZVFw== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id PoRYAKpg1dPJ for ; Sun, 6 Sep 2020 17:31:47 +0200 (CEST) Date: Sun, 6 Sep 2020 17:31:46 +0200 From: Lars-Dominik Braun Message-ID: <20200906153146.GA1315@noor.fritz.box> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.66 / 15.00 / 15.00 X-Rspamd-Queue-Id: DFB1417A7 X-Rspamd-UID: cdaf36 Received-SPF: pass client-ip=2001:67c:2050::465:101; envelope-from=lars@6xq.net; helo=mout-p-101.mailbox.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi, I noticed xournalpp’s crash reporter depends on binutils’ addr2line binary. When running `guix environment --pure --ad-hoc xournalpp -- xournalpp` you can see lines like `sh: addr2line: command not found`. The attached patch replaces the path by the build-time binutil’s version. Cheers, Lars --r5Pyd7+fXNt84Ff3 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-xournalpp-Fix-path-to-addr2line-binary.patch" >From ab65a639b2af2eb67ab325d2bdf0fab07157d9d3 Mon Sep 17 00:00:00 2001 From: Lars-Dominik Braun Date: Sun, 6 Sep 2020 17:27:54 +0200 Subject: [PATCH] gnu: xournalpp: Fix path to addr2line binary * gnu/packages/pdf.scm [arguments]: Add phase substituting path of addr2line utility. --- gnu/packages/pdf.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm index 7649bff695..4c11111323 100644 --- a/gnu/packages/pdf.scm +++ b/gnu/packages/pdf.scm @@ -848,6 +848,14 @@ using a stylus.") (for-each (lambda (po) (chmod po #o666)) (find-files "." "\\.po$")) #t)) + ;; Fix path to addr2line utility, which the crash reporter uses. + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "src/util/Stacktrace.cpp" + ;; Match only the commandline. + (("\"addr2line ") + (string-append "\"" (which "addr2line") " "))) + #t)) (add-after 'install 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) (native-inputs -- 2.26.2 --r5Pyd7+fXNt84Ff3-- From unknown Fri Aug 15 20:05:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Lars-Dominik Braun Subject: bug#43245: closed (Re: [bug#43245] [PATCH] gnu: xournalpp: Fix path to addr2line binary) Message-ID: References: <87eenennlf.fsf@gnu.org> <20200906153146.GA1315@noor.fritz.box> X-Gnu-PR-Message: they-closed 43245 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 43245@debbugs.gnu.org Date: Mon, 07 Sep 2020 05:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1599457802-2782-1" This is a multi-part message in MIME format... ------------=_1599457802-2782-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43245: [PATCH] gnu: xournalpp: Fix path to addr2line binary which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43245@debbugs.gnu.org. --=20 43245: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43245 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1599457802-2782-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43245-done) by debbugs.gnu.org; 7 Sep 2020 05:49:13 +0000 Received: from localhost ([127.0.0.1]:47647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFA1h-0000hP-2M for submit@debbugs.gnu.org; Mon, 07 Sep 2020 01:49:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFA1e-0000h8-Uv for 43245-done@debbugs.gnu.org; Mon, 07 Sep 2020 01:49:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35785) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFA1X-0007cv-U1; Mon, 07 Sep 2020 01:49:03 -0400 Received: from [2a01:e0a:19b:d9a0:9d9d:97cc:d92a:8ac0] (port=48574 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFA1X-0008W5-6N; Mon, 07 Sep 2020 01:49:03 -0400 From: Mathieu Othacehe To: Lars-Dominik Braun Subject: Re: [bug#43245] [PATCH] gnu: xournalpp: Fix path to addr2line binary References: <20200906153146.GA1315@noor.fritz.box> Date: Mon, 07 Sep 2020 07:49:00 +0200 In-Reply-To: <20200906153146.GA1315@noor.fritz.box> (Lars-Dominik Braun's message of "Sun, 6 Sep 2020 17:31:46 +0200") Message-ID: <87eenennlf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43245-done Cc: 43245-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > I noticed xournalpps crash reporter depends on binutils addr2line > binary. When running `guix environment --pure --ad-hoc xournalpp -- > xournalpp` you can see lines like `sh: addr2line: command not found`. > The attached patch replaces the path by the build-time binutils > version. Pushed, thanks! Mathieu ------------=_1599457802-2782-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Sep 2020 15:32:03 +0000 Received: from localhost ([127.0.0.1]:46854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEweB-00050h-GM for submit@debbugs.gnu.org; Sun, 06 Sep 2020 11:32:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:53604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEwe9-00050I-CM for submit@debbugs.gnu.org; Sun, 06 Sep 2020 11:32:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEwe9-0008KF-5S for guix-patches@gnu.org; Sun, 06 Sep 2020 11:32:01 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050::465:101]:27146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kEwe6-00028w-BZ for guix-patches@gnu.org; Sun, 06 Sep 2020 11:32:00 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4BkwPg0zLGzKmRV for ; Sun, 6 Sep 2020 17:31:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1599406309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sNqpPlzqbTNPjPNlj6nZpniQqZZIUn19BbdCOuQQjWI=; b=VIOTy8ABZzqzY+4mWtdD+UO8UGl9GWwA+X5ZZtP9M0KE761FIURHrMxzwrvxDQqjY5Aeke n3KvDRLyYw7PyWmlCUJsMNK8D5D2PvInrdesP30C3eo9pn4IWo3eFxALTpNrCzDh8mEizc a+d/egc+y39f24toPPOagTjargpkA1vFkvzVtkr+aBYwc5jZPPM9W+l+w9gSzBIYSE+Rpb 2Jvejmi5JFo99GFq9+FFihHuYd+qTUDnRJjPMgXsAP4DAYGRXQl43QELYa385KyI6U+P80 8/K0qR1s/zNULgHqecixDAL1stHTSRJA+Elo6MvhUEDxfDgIvt3QnZoPMCZVFw== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id PoRYAKpg1dPJ for ; Sun, 6 Sep 2020 17:31:47 +0200 (CEST) Date: Sun, 6 Sep 2020 17:31:46 +0200 From: Lars-Dominik Braun To: guix-patches@gnu.org Subject: [PATCH] gnu: xournalpp: Fix path to addr2line binary Message-ID: <20200906153146.GA1315@noor.fritz.box> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.66 / 15.00 / 15.00 X-Rspamd-Queue-Id: DFB1417A7 X-Rspamd-UID: cdaf36 Received-SPF: pass client-ip=2001:67c:2050::465:101; envelope-from=lars@6xq.net; helo=mout-p-101.mailbox.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi, I noticed xournalpp’s crash reporter depends on binutils’ addr2line binary. When running `guix environment --pure --ad-hoc xournalpp -- xournalpp` you can see lines like `sh: addr2line: command not found`. The attached patch replaces the path by the build-time binutil’s version. Cheers, Lars --r5Pyd7+fXNt84Ff3 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-xournalpp-Fix-path-to-addr2line-binary.patch" >From ab65a639b2af2eb67ab325d2bdf0fab07157d9d3 Mon Sep 17 00:00:00 2001 From: Lars-Dominik Braun Date: Sun, 6 Sep 2020 17:27:54 +0200 Subject: [PATCH] gnu: xournalpp: Fix path to addr2line binary * gnu/packages/pdf.scm [arguments]: Add phase substituting path of addr2line utility. --- gnu/packages/pdf.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm index 7649bff695..4c11111323 100644 --- a/gnu/packages/pdf.scm +++ b/gnu/packages/pdf.scm @@ -848,6 +848,14 @@ using a stylus.") (for-each (lambda (po) (chmod po #o666)) (find-files "." "\\.po$")) #t)) + ;; Fix path to addr2line utility, which the crash reporter uses. + (add-after 'unpack 'fix-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "src/util/Stacktrace.cpp" + ;; Match only the commandline. + (("\"addr2line ") + (string-append "\"" (which "addr2line") " "))) + #t)) (add-after 'install 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) (native-inputs -- 2.26.2 --r5Pyd7+fXNt84Ff3-- ------------=_1599457802-2782-1--