GNU bug report logs - #43242
[PATCH] Fix CSS completion bug

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Philip K." <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix CSS completion bug
Date: Sun, 06 Sep 2020 14:51:03 +0200

[Message part 1 (text/plain, inline)]

Hi,

I like to write CSS rules on one line, but Emacs completion-at-point
system always seems to fail if there is more than one rule per line. It
seems the reason was that css--complete-property-value as part of
css-completion-at-point falsely reported a match, because it ignored the
semi-colon. This means that in situations like these

            color: red; padd
                            ^
                        point here

the CAPF backend assumed a "color" value should be completed, even
though the user probably wants the "padd" string to be completed.

The patch below fixes this by making sure css--complete-property-value
doesn't ignore the semi-colon.

-- 
	Philip K.

[0001-Allow-CSS-completion-with-multiple-rules-on-one-line.patch (text/x-patch, inline)]

From d452cd225845000f278e39c02796cf323f931925 Mon Sep 17 00:00:00 2001
From: Philip K <philipk <at> posteo.net>
Date: Sun, 6 Sep 2020 14:42:03 +0200
Subject: [PATCH] Allow CSS completion with multiple rules on one line

* css-mode.el (css--complete-property-value): Check for semi-colon
  when completing property values
---
 lisp/textmodes/css-mode.el | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index cc5879880c..d0882c68d0 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -1357,13 +1357,11 @@ css--property-values
 (defun css--complete-property-value ()
   "Complete property value at point."
   (let ((property
-         (save-excursion
-           (re-search-backward ":[^/]" (line-beginning-position) t)
-           (when (eq (char-after) ?:)
-             (let ((property-end (point)))
-               (skip-chars-backward "-[:alnum:]")
-               (let ((prop (buffer-substring (point) property-end)))
-                 (car (member prop css-property-ids))))))))
+         (save-match-data
+           (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*"
+                              (line-beginning-position) t)
+                (car (member (match-string-no-properties 1)
+                             css-property-ids))))))
     (when property
       (let ((end (point)))
         (save-excursion
-- 
2.26.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.