GNU bug report logs - #43242
[PATCH] Fix CSS completion bug

Previous Next

Package: emacs;

Reported by: "Philip K." <philipk <at> posteo.net>

Date: Sun, 6 Sep 2020 12:52:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 43242 <at> debbugs.gnu.org (full text, mbox):

From: "Philip K." <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43242 <at> debbugs.gnu.org
Subject: Re: bug#43242: [PATCH] Fix CSS completion bug
Date: Sun, 06 Sep 2020 23:40:42 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Philip K." <philipk <at> posteo.net> writes:
>
>> The patch below fixes this by making sure css--complete-property-value
>> doesn't ignore the semi-colon.
>
> [...]
>
>> +         (save-match-data
>> +           (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*"
>
> Looks good...  but is there any particular reason to save the match data
> here?

Well, it's being used in the next line in the member call to extract the
record from css-property-ids.

-- 
	Philip K.
This bug report was last modified 4 years and 315 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.