GNU bug report logs - #43236
[PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43236: closed ([PATCH emacs-guix] elisp: guix-set-emacs-environment:
 Also update Emacs' path.)
Date: Mon, 16 Jan 2023 21:34:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 16 Jan 2023 22:33:05 +0100
with message-id <87sfgaxizy.fsf <at> gnu.org>
and subject line Re: bug#43236: [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path.
has caused the debbugs.gnu.org bug report #43236,
regarding [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43236: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43236
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Jan (janneke) Nieuwenhuizen" <janneke <at> gnu.org>
To: guix-patches <at> gnu.org,
	Alex Kost <alezost <at> gmail.com>
Subject: [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update
 Emacs' path.
Date: Sun,  6 Sep 2020 10:46:46 +0200

This helps Geiser find the correct (environment's) Guile.

* elisp/guix-misc.el (guix-set-emacs-environment): Set "exec-path"
when setting "PATH" variable.
---
 elisp/guix-misc.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/elisp/guix-misc.el b/elisp/guix-misc.el
index 6f79fe6..7e9c068 100644
--- a/elisp/guix-misc.el
+++ b/elisp/guix-misc.el
@@ -1,7 +1,7 @@
 ;;; guix-misc.el --- Miscellaneous definitions  -*- lexical-binding: t -*-
 
 ;; Copyright © 2014–2018 Alex Kost <alezost <at> gmail.com>
-;; Copyright © 2018 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
+;; Copyright © 2018,2020 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
 
 ;; This file is part of Emacs-Guix.
 
@@ -242,7 +242,9 @@ If PROFILE is nil, use `guix-current-profile'."
               (value (if (and separator current-value)
                          (concat path separator current-value)
                        path)))
-        (setenv variable value)))))
+        (setenv variable value)
+        (when (equalp variable "PATH")
+          (setq exec-path (split-string value ":")))))))
 
 
 ;;; Executing guix commands
-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

[Message part 3 (message/rfc822, inline)]

From: Janneke Nieuwenhuizen <janneke <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: alezost <at> gmail.com, 43236-done <at> debbugs.gnu.org
Subject: Re: bug#43236: [PATCH emacs-guix] elisp:
 guix-set-emacs-environment: Also update Emacs' path.
Date: Mon, 16 Jan 2023 22:33:05 +0100

Maxim Cournoyer writes:

Hi Maxim,

> "Jan (janneke) Nieuwenhuizen" <janneke <at> gnu.org> writes:
>
>> This helps Geiser find the correct (environment's) Guile.
>> -;; Copyright © 2018 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
>> +;; Copyright © 2018,2020 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
>
> There's no use for a copyright line here as the change is not
> substantial enough (< 10 lines).

Ah...I guess I figured that we need copyright years to be updated in all
years the program is "released".  Oh well...

>> +        (when (equalp variable "PATH")
>> +          (setq exec-path (split-string value ":")))))))
>
> That's still useful with Emacs 28, right?  If you can confirm it, LGTM.

It's still useful...but also...I found this has already been installed
as

    commit d246b2c443bbb9d49575b63bb78c14699c4448cf
    elisp/misc: Update Emacs path if needed

and

    41fba4eec845e050be92bfe76c0f7980bbe821bd
    Fix the previous commit

Sorry for the noise...Closing.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.