Subject: Re: bug#43236: [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path.

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 16 Jan 2023 13:03:44 -0500

Hi Janneke,

"Jan (janneke) Nieuwenhuizen" <[email-masked]> writes:

> This helps Geiser find the correct (environment's) Guile.
>
> * elisp/guix-misc.el (guix-set-emacs-environment): Set "exec-path"
> when setting "PATH" variable.
> ---
>  elisp/guix-misc.el | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/elisp/guix-misc.el b/elisp/guix-misc.el
> index 6f79fe6..7e9c068 100644
> --- a/elisp/guix-misc.el
> +++ b/elisp/guix-misc.el
> @@ -1,7 +1,7 @@
>  ;;; guix-misc.el --- Miscellaneous definitions  -*- lexical-binding: t -*-
>  
>  ;; Copyright © 2014–2018 Alex Kost <[email-masked]>
> -;; Copyright © 2018 Jan (janneke) Nieuwenhuizen <[email-masked]>
> +;; Copyright © 2018,2020 Jan (janneke) Nieuwenhuizen <[email-masked]>

There's no use for a copyright line here as the change is not
substantial enough (< 10 lines).

>  ;; This file is part of Emacs-Guix.
>  
> @@ -242,7 +242,9 @@ If PROFILE is nil, use `guix-current-profile'."
>                (value (if (and separator current-value)
>                           (concat path separator current-value)
>                         path)))
> -        (setenv variable value)))))
> +        (setenv variable value)
> +        (when (equalp variable "PATH")
> +          (setq exec-path (split-string value ":")))))))

That's still useful with Emacs 28, right?  If you can confirm it, LGTM.

-- 
Thanks,
Maxim