From unknown Wed Aug 20 05:43:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43232 <43232@debbugs.gnu.org> To: bug#43232 <43232@debbugs.gnu.org> Subject: Status: jack2 fails to build on aarch64 Reply-To: bug#43232 <43232@debbugs.gnu.org> Date: Wed, 20 Aug 2025 12:43:32 +0000 retitle 43232 jack2 fails to build on aarch64 reassign 43232 guix submitter 43232 Vitaliy Shatrov severity 43232 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 23:53:15 2020 Received: (at submit) by debbugs.gnu.org; 6 Sep 2020 03:53:15 +0000 Received: from localhost ([127.0.0.1]:44471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kElju-0007zR-RB for submit@debbugs.gnu.org; Sat, 05 Sep 2020 23:53:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEljs-0007zJ-QL for submit@debbugs.gnu.org; Sat, 05 Sep 2020 23:53:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEljs-0002S6-I7 for bug-guix@gnu.org; Sat, 05 Sep 2020 23:53:12 -0400 Received: from knopi.disroot.org ([178.21.23.139]:49882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEljp-0004AE-TC for bug-guix@gnu.org; Sat, 05 Sep 2020 23:53:12 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 64A4B529E4; Sun, 6 Sep 2020 05:53:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qjz3ekR_Wwzi; Sun, 6 Sep 2020 05:53:06 +0200 (CEST) From: Vitaliy Shatrov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1599364386; bh=V7MbVzGdGHCklRd0snCr+Vl7O78l0ZTutg5AxxVZbWw=; h=From:To:Subject:CC:Date; b=FF+cf5uI6vRteCvFjzfFSnTtA7WUD2oMbcYjJS/dr23vNxCUTLCtj8BMBYV99PYFE ex8Q2kjakTFuNIcor6rPj6rgxCTHotJU2TWPoOj6VMoGuRYqsmKv32TWEQrv5yZWq3 9pfm/E6TKGFlwegaGoRo0T2xJLrTRB3D6rMxabxTltGLu1cbgEhF/xNBzdui97vOQE jEcW2p9Tal8bo1oDdyzkFXV2jG8dQBpBx1SN+UUceyIzL5+wgSBVXPjQ4K0Z3IxBYd /j9CcLBaLDd4LLS7xg16k3Z9l45Q0CSxIdTvWmc3OTSn/QdDpkhuFT/qwVTPsQ+yKq VYnH6FsSUQHdQ== To: =?utf-8?B?0JQt0LQt0LTQvtCx0YDRi9C1INCb0Y7QtNC4?= Subject: jack2 fails to build on aarch64 Date: Sun, 06 Sep 2020 10:53:52 +0700 Message-ID: <87363v7e7j.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.21.23.139; envelope-from=guix.vits@disroot.org; helo=knopi.disroot.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/05 23:53:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Mike Rosset X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello Guix. gst-plugins-good needs jack2. Sites like YouTube need gst-plugins-good. Some people think they need the video in Web-browsers (lol, mpv rules). guix 81ea278 is still has no jack2, it's all i know about. Please fix jack2, someone. Thankful for Your attention, Vitaliy. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 04:58:25 2020 Received: (at 43232) by debbugs.gnu.org; 6 Sep 2020 08:58:25 +0000 Received: from localhost ([127.0.0.1]:44787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEqVF-00039k-56 for submit@debbugs.gnu.org; Sun, 06 Sep 2020 04:58:25 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:45354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEqVD-00039b-61 for 43232@debbugs.gnu.org; Sun, 06 Sep 2020 04:58:23 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 6A41B1E59; Sun, 6 Sep 2020 10:58:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wqr6fP3ms-k7; Sun, 6 Sep 2020 10:58:20 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::bf5]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 5B4D71D1D; Sun, 6 Sep 2020 10:58:20 +0200 (CEST) Date: Sun, 6 Sep 2020 10:58:05 +0200 From: Andreas Enge To: Vitaliy Shatrov Subject: Re: bug#43232: jack2 fails to build on aarch64 Message-ID: <20200906085805.GA2494@jurong> References: <87363v7e7j.fsf@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87363v7e7j.fsf@disroot.org> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43232 Cc: Mike Rosset , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) The error message is: [228/274] Compiling example-clients/simdtests.cpp ... [243/274] Linking build/example-clients/jack_simdtests ... ld: example-clients/simdtests.cpp.28.o: undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3' ld: /gnu/store/9xmlrmk7vnlzwq5049500r9lrcf6ikqq-gcc-7.5.0-lib/lib/libstdc++.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ... Waf: Leaving directory `/tmp/guix-build-jack2-1.9.13.drv-0/jack2-1.9.13/build' Build failed -> task in 'jack_simdtests' failed with exit status 1 (run with -v to display more information) command "python" "waf" "build" failed with status 1 Following the advice and running "python waf build -v", the executed gcc command is printed: Build failed -> task in 'jack_simdtests' failed with exit status 1: {task 281472893294736: cprogram simdtests.cpp.28.o -> jack_simdtests} ['/gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/gcc', '-Wl,-rpath=/gnu/store/bwmp037cg6gfz31j9q441j800mvk7wva-jack2-1.9.13/lib', 'example-clients/simdtests.cpp.28.o', '-o/tmp/guix-build-jack2-1.9.13.drv-0/jack2-1.9.13/build/example-clients/jack_simdtests', '-Wl,-Bstatic', '-Wl,-Bdynamic', '-Lcommon', '-L/gnu/store/zwrg5jwyj1222vyjdpmppijzhz04sqid-opus-1.3.1/lib', '-L/gnu/store/mpm43myhw7difa8p3a9xnag3zb6pnn4b-dbus-1.12.16/lib', '-ljack', '-lpthread', '-lopus', '-ldb', '-lrt', '-ldl', '-ldbus-1', '-lm'] Andreas From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 06:03:01 2020 Received: (at 43232) by debbugs.gnu.org; 6 Sep 2020 10:03:01 +0000 Received: from localhost ([127.0.0.1]:44857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kErVl-0004f0-As for submit@debbugs.gnu.org; Sun, 06 Sep 2020 06:03:01 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:46084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kErVj-0004er-VI for 43232@debbugs.gnu.org; Sun, 06 Sep 2020 06:03:00 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D97FF1F71; Sun, 6 Sep 2020 12:02:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZtvrQ7W0UX1N; Sun, 6 Sep 2020 12:02:57 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::5f6]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F27E91F53; Sun, 6 Sep 2020 12:02:56 +0200 (CEST) Date: Sun, 6 Sep 2020 12:02:41 +0200 From: Andreas Enge To: Vitaliy Shatrov Subject: Re: bug#43232: jack2 fails to build on aarch64 Message-ID: <20200906100241.GA4311@jurong> References: <87363v7e7j.fsf@disroot.org> <20200906085805.GA2494@jurong> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200906085805.GA2494@jurong> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43232 Cc: Mike Rosset , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Updating jack2 to 1.9.14 does not solve the problem. Andreas From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 09:46:41 2020 Received: (at 43232) by debbugs.gnu.org; 6 Sep 2020 13:46:41 +0000 Received: from localhost ([127.0.0.1]:45057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEv0C-00060t-Ru for submit@debbugs.gnu.org; Sun, 06 Sep 2020 09:46:41 -0400 Received: from mail-pg1-f169.google.com ([209.85.215.169]:41424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEv09-00060e-OU for 43232@debbugs.gnu.org; Sun, 06 Sep 2020 09:46:39 -0400 Received: by mail-pg1-f169.google.com with SMTP id w186so6737247pgb.8 for <43232@debbugs.gnu.org>; Sun, 06 Sep 2020 06:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=D8HJDCXEIly47OYwfITzsH1gTDwT9YcKEo4YC9Tks5A=; b=iqsW3miutcEIqwTMw6f61g5fFGwxocuqkjfm0AEHysXFJy98BHo6tulk7Z0yOz7E8/ XUUnHoinTMb8o2hajD5UASMGr7qJow559030dUE4QrDgmaZSfzuAVSN1ntpRNnLzBla9 5hg9fu8NpLmzhUReLkBkor3yTBn3S74U3SPBGtfgni9X0ZlLqYUC/ehgagdc9KIAv+KU Q791nuT6wdkitfg+GxuiM4eIq9v3VKI11zV6ZSd8dVuIGvF4+Tc8xhxm80Nhdd7M4/UQ DvlJJffFyhoSzhcsoL7Z01iVr74/yrPv7Meofvc84pxtBGVmQX2UYaB2XNl/6M6KiR4u RNpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=D8HJDCXEIly47OYwfITzsH1gTDwT9YcKEo4YC9Tks5A=; b=hKgR0Qr0MploMNL+PF0o2ss/IfgDb4YLHWmfpSfNtSTFdaPSCaAjFxtpmAfOsAFhuY UXYran5zSXmbRf+TYZfbAjJbWS6Deyaq7qi8t17gq0Fh0LZpLQ5OlxqdxbNx+qLDYblO /bxaKQgTOye+iFRFfj8zfG5CT5AO1MhAmxzsmE1F29Zk21nxxZuTccnkJ95KlnX0U0ku vWRam1TbGFhxkJodJ3MNZVSG9TxROkP6BNIcOmlj+7aBzxnTCDvcnoAVl4PP2OGC161+ zDbW6qS2OKKW/X7jwk+Jg99fuujHL6ZLIHGWdQXC0euvfeIsyxmlrYjlCvldNwFgalLq edZg== X-Gm-Message-State: AOAM531xHQgwPdRyXVQaaDOQvhA7eDffFmRIIgkcBPBMHkcrquMxOQwJ F2MiwcWLpcTZnbUPjGH1HFunz7IYZLY= X-Google-Smtp-Source: ABdhPJx3LemifBjPaErFQx9e/HwXAfbfkImCNuvRBwYo1FvOrgGjTjccIb04y916DgdZIR9J6xkO1A== X-Received: by 2002:a62:dd01:0:b029:13c:f607:5fff with SMTP id w1-20020a62dd010000b029013cf6075fffmr8912117pff.3.1599399991207; Sun, 06 Sep 2020 06:46:31 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id u4sm1022363pfk.166.2020.09.06.06.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 06:46:30 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200906085805.GA2494@jurong> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset To: Andreas Enge Subject: Re: bug#43232: jack2 fails to build on aarch64 In-reply-to: <20200906085805.GA2494@jurong> Date: Sun, 06 Sep 2020 06:46:29 -0700 Message-ID: <87h7sbnhl6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Vitaliy Shatrov , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Enge writes: > The error message is: > [228/274] Compiling example-clients/simdtests.cpp > ... > [243/274] Linking build/example-clients/jack_simdtests > ... > ld: example-clients/simdtests.cpp.28.o: undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3' > ld: /gnu/store/9xmlrmk7vnlzwq5049500r9lrcf6ikqq-gcc-7.5.0-lib/lib/libstdc++.so.6: error adding symbols: DSO missing from command line > collect2: error: ld returned 1 exit status > ... > Waf: Leaving directory `/tmp/guix-build-jack2-1.9.13.drv-0/jack2-1.9.13/build' > Build failed > -> task in 'jack_simdtests' failed with exit status 1 (run with -v to display more information) > command "python" "waf" "build" failed with status 1 > > Following the advice and running "python waf build -v", the executed gcc > command is printed: > Build failed > -> task in 'jack_simdtests' failed with exit status 1: > {task 281472893294736: cprogram simdtests.cpp.28.o -> jack_simdtests} > ['/gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/gcc', '-Wl,-rpath=/gnu/store/bwmp037cg6gfz31j9q441j800mvk7wva-jack2-1.9.13/lib', 'example-clients/simdtests.cpp.28.o', '-o/tmp/guix-build-jack2-1.9.13.drv-0/jack2-1.9.13/build/example-clients/jack_simdtests', '-Wl,-Bstatic', '-Wl,-Bdynamic', '-Lcommon', '-L/gnu/store/zwrg5jwyj1222vyjdpmppijzhz04sqid-opus-1.3.1/lib', '-L/gnu/store/mpm43myhw7difa8p3a9xnag3zb6pnn4b-dbus-1.12.16/lib', '-ljack', '-lpthread', '-lopus', '-ldb', '-lrt', '-ldl', '-ldbus-1', '-lm'] > > Andreas undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3 looks like a potentially gcc flag order issues. Seems -lstdc++ should be at the end of the g++ command invocation. I'll see if I'll have time today to look into this more. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 00:25:39 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 04:25:39 +0000 Received: from localhost ([127.0.0.1]:56858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI2XC-00045j-VH for submit@debbugs.gnu.org; Tue, 15 Sep 2020 00:25:39 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI2X7-00045R-Tt for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 00:25:37 -0400 Received: by mail-pf1-f196.google.com with SMTP id n14so1191003pff.6 for <43232@debbugs.gnu.org>; Mon, 14 Sep 2020 21:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IDwRUMc81rDqjbB7LS7IyEx12vYphCITaqxSNIclHMM=; b=HAiyDwjHw/G2sPB0KXL3A5NQKq5ZQ91tJ3VHhkptlr4++J9dm0qEUZnpoPjCMMYIwJ tEEgd4br7B70w1ritcvofV0Z7jPesiRWdJxBUr9BZC0apaXUsYM1nnA4GLnZCxIeWfit /XE2/OwqQV1LYl455UN/zes3PHfkhKKscTHyh4UULYVJnjMsEJiF/kFZM/djCc4jvCJb ATZDXx5W6S0+aQWoMJHkqTJm5zZol4/nqqA2u7JgmqGEoYOmy5pRvmETfhAxya9yd3ZT odPEi9MtOri1mZ23cedQGVfxk7OiFbe4nJynNG4EoZWacSCBHHcBMTvNBwJE39SYSZ8D guvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IDwRUMc81rDqjbB7LS7IyEx12vYphCITaqxSNIclHMM=; b=lRDA7pkP6wd0GV7bmZhAy9Td4LhlsWROEUHDPN4bjw0+SALqTpqoGicy24mcfV6im2 npiNLppEJaiObLFRTxOMtoIztq6xB/F57QmHNyPLUE2gJH80jZpwNBkocaFCTFoBh/wM vZyhR7jKUhW0EOnZ7o8it8H6hB/KzFVb8jT9JasJuQh35EA6MdlaNKIgoqSDGwjATu4l zXFblyj8Usbnodo+/YQ1Ys8bNFOaVzqppcXeT4E3N6ZE1nX36wne1diazZzr7Us7pCX2 baxEdEmeonuIX7qG/0U4qVCKJIFOAwF1J/Xqg5gfBEr3V0/FkouHqEI79m9fdYXJ82vG f2PA== X-Gm-Message-State: AOAM531XS4Z4/tEJsBkz/5sSkK0HNcuKDCwoycu6Q07ECYOz82XLP+0u lBhjBRjs49cx/i4dOvjuiqQs6Hq37PCyhQ== X-Google-Smtp-Source: ABdhPJxp0/IdoPh8miGRJtRhoAI7TB7tja4PW8pUlcP0aSJ/s1YlRVEjpWPyIQvqr1SpCZEUrIy2ug== X-Received: by 2002:a62:184f:0:b029:142:2501:39fd with SMTP id 76-20020a62184f0000b0290142250139fdmr166473pfy.76.1600143927626; Mon, 14 Sep 2020 21:25:27 -0700 (PDT) Received: from neutron.hitronhub.home (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id x5sm9712569pgf.65.2020.09.14.21.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 21:25:26 -0700 (PDT) From: Mike Rosset To: 43232@debbugs.gnu.org Subject: [PATCH] gnu: jack-2: Update to 1.9.14. Date: Mon, 14 Sep 2020 21:25:25 -0700 Message-Id: <20200915042525.4186311-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Mike Rosset X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/audio.scm (jack-2): Update to 1.9.14. [arguments]: new 'declare-for-int phase after unpack that declares 'i in the for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase ensures -lstdc++ is at the tail. This fixes issues that cause jack-2 to not build on system aarh64-linux. --- gnu/packages/audio.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 38ee4f8bcc..83c08b718e 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2030,7 +2030,7 @@ synchronous execution of all clients, and low latency operation.") (define-public jack-2 (package (inherit jack-1) (name "jack2") - (version "1.9.13") + (version "1.9.14") (source (origin (method url-fetch) (uri (string-append "https://github.com/jackaudio/jack2/releases/" @@ -2039,7 +2039,7 @@ synchronous execution of all clients, and low latency operation.") (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "1d1d403jn4366mqig6g8ghr8057b3rn7gs26b5p3rkal34j20qw2")))) + "0z11hf55a6mi8h50hfz5wry9pshlwl4mzfwgslghdh40cwv342m2")))) (build-system waf-build-system) (arguments `(#:tests? #f ; no check target @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low latency operation.") "--alsa") #:phases (modify-phases %standard-phases + (add-after 'unpack 'declare-for-int + (lambda _ + ;; Declare the for loop i incrementer. + (substitute* "dbus/sigsegv.c" + (("for\\(i = 0") "for(int i = 0")) + #t)) (add-before 'configure 'set-linkflags (lambda _ + ;; Ensure -lstdc++ is the tail of LDFLAGS or the simdtests.cpp + ;; will not link with undefined reference to symbol + ;; '__gxx_personality_v0@@CXXABI_1.3' + (setenv "LDFLAGS" "-lstdc++") ;; Add $libdir to the RUNPATH of all the binaries. (substitute* "wscript" ((".*CFLAGS.*-Wall.*" m) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 02:22:20 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 06:22:20 +0000 Received: from localhost ([127.0.0.1]:57043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI4M8-0007Pa-5C for submit@debbugs.gnu.org; Tue, 15 Sep 2020 02:22:20 -0400 Received: from flashner.co.il ([178.62.234.194]:49722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI4M6-0007PJ-AM for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 02:22:19 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id 3ECE24008C; Tue, 15 Sep 2020 06:22:12 +0000 (UTC) Date: Tue, 15 Sep 2020 09:21:39 +0300 From: Efraim Flashner To: Mike Rosset Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. Message-ID: <20200915062139.GF17272@E5400> References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="L2Brqb15TUChFOBK" Content-Disposition: inline In-Reply-To: <20200915042525.4186311-1-mike.rosset@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --L2Brqb15TUChFOBK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote: > * gnu/packages/audio.scm (jack-2): Update to 1.9.14. > [arguments]: new 'declare-for-int phase after unpack that declares 'i in = the > for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase > ensures -lstdc++ is at the tail. >=20 > This fixes issues that cause jack-2 to not build on system aarh64-linux. > --- > gnu/packages/audio.scm | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm > index 38ee4f8bcc..83c08b718e 100644 > --- a/gnu/packages/audio.scm > +++ b/gnu/packages/audio.scm > @@ -2030,7 +2030,7 @@ synchronous execution of all clients, and low laten= cy operation.") > (define-public jack-2 > (package (inherit jack-1) > (name "jack2") > - (version "1.9.13") > + (version "1.9.14") > (source (origin > (method url-fetch) > (uri (string-append "https://github.com/jackaudio/jack2/rel= eases/" > @@ -2039,7 +2039,7 @@ synchronous execution of all clients, and low laten= cy operation.") > (file-name (string-append name "-" version ".tar.gz")) > (sha256 > (base32 > - "1d1d403jn4366mqig6g8ghr8057b3rn7gs26b5p3rkal34j20qw2")))) > + "0z11hf55a6mi8h50hfz5wry9pshlwl4mzfwgslghdh40cwv342m2")))) > (build-system waf-build-system) > (arguments > `(#:tests? #f ; no check target > @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low late= ncy operation.") > "--alsa") > #:phases > (modify-phases %standard-phases > + (add-after 'unpack 'declare-for-int > + (lambda _ > + ;; Declare the for loop i incrementer. > + (substitute* "dbus/sigsegv.c" > + (("for\\(i =3D 0") "for(int i =3D 0")) > + #t)) Any chance of an upstream bug number or something for this? It seems like the type of thing that might be put into a snippet. > (add-before 'configure 'set-linkflags > (lambda _ > + ;; Ensure -lstdc++ is the tail of LDFLAGS or the simdtests.= cpp > + ;; will not link with undefined reference to symbol > + ;; '__gxx_personality_v0@@CXXABI_1.3' > + (setenv "LDFLAGS" "-lstdc++") > ;; Add $libdir to the RUNPATH of all the binaries. > (substitute* "wscript" > ((".*CFLAGS.*-Wall.*" m) > --=20 > 2.28.0 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --L2Brqb15TUChFOBK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9gXXAACgkQQarn3Mo9 g1EocBAAvHedkb2yUnqp4FKFzsElwMVdkg4aylCXjv40FDpM+q+lkjD6fQYH6QnM BNctLLQQS5gxoo/bFZy/cYSR+mAl0eQtxoO2CeNUq1rDHgZh/3GxCGF5xjMV1OX+ Rbfj6fEdA/PW2BmpmJhokLMl41I0c7kHFeoEeMyMSNenAS2He66Nonmms0w9yWKP /4Ow/rJ9MhBGhjL0sYAVbP0sNsM4sARrvedGdCEXf//5BuV4HwkoXUsjZvcYKydN 2qdDTTxsldewKg0MRV80ItjD5w+V3lEHr8lK75KZ2IUZvZ9ntyYNMxaouPfhbHIB rNZ2jC6lVevgl97DJuh9FPEi4CjB2oH6bRnptRiPRwi1Aox69+pMf6AQLj6Fq4ax kExAOcMOnL72Zsi9HQFNrDN68Pcz+JpWUUhKGo3hbDVPK2rSf3SxOG8OC1t1uxzQ jFheJzXq8I4/9t+XQzFhx9KmMbG3sD5g4+6m1++Yf2Nh2ln503M6/1GzPGTt50Pp SlgdFu4u3qOknT8SSW6HoVPROl9umosxcHuerx6lc4/i/X1moYUPyUHNs+gi+Ud+ WOgJ0juBnMY3RlyYk91aPj+icxDXt4fG+1z4y086L8xf5aXRfPL/t5/TRySe85iJ 3vxU2dadgpiRtA/m+0omBiW0J/qNIg4iGxrCCuFONYG0yadWNi4= =eSJI -----END PGP SIGNATURE----- --L2Brqb15TUChFOBK-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 03:29:53 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 07:29:53 +0000 Received: from localhost ([127.0.0.1]:57087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI5PV-0000di-B5 for submit@debbugs.gnu.org; Tue, 15 Sep 2020 03:29:53 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:38307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI5PT-0000dV-ML for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 03:29:52 -0400 Received: by mail-pl1-f173.google.com with SMTP id c3so882856plz.5 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 00:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=NpoH8pl0mBglYAB2ptihJxx8SRyvPjEAS3rMCnxqXto=; b=GLqSzerp2PC8kxA3rbKdKzVhprDMLnbdQ8KQCSyMY7if73YdUoK5rY0NZ1MflY5f9g A4siJB6z/ToSrktgluLydBuzyCH05uWVm1p//6P9Dzum1gvOjKTKRwWp7No799dqNFBX UQoIYLu8DZK09jzCgMeU151p5J65tlFoj+am4ZPkGcPYf23Ef2UhV5dzTYGmkvn5IGLM th8DCT0lIl2ahXVICu3b+5jWluhLA9AhaInbgFlknd8DZDddfaquszOkS06mTc0FsHpP 4kRwL5OY9bFsv+F/VOu0cndgCBO8YqfWw8tsU+dyc6NNLihEwbm1WjgwqlonPr4gvg2c rMRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=NpoH8pl0mBglYAB2ptihJxx8SRyvPjEAS3rMCnxqXto=; b=IGcwoP638Y/V1LTvmI3a+gfiNucC01prd8GeFQfQO5zeT7LEdJHX7x5IQHCS0nGlkX Ij2tsTMD0tEMF+tI9oIMyWMgctclg/QqONqClaxEo68p6pprEvm9jcOdwCy8XzyYn6eQ WfsakN6SQeTBfsCZC9Jt4zwv5fbx1BRHITA10qbvPsVvsWU7+YUpUTuCq6wRgSvucEit skPEhCH9AlSFHpFaKdvpGXKcMtvgkvIGMwmDbzS8Ad7XM7W9QKOVnaErTy8SmRxP7R9/ GAuRuADjzIVfK6T0JyghQ9lkLZOtZlfiAhh7sdZmOWNHEoGQBfa1k1094EOunrsxPIoJ D3Ug== X-Gm-Message-State: AOAM531PvgN5qJC7aOoE6nRTEix7MoCxF/TEdgiKltrAqm1iir6dFbXp YNYFsFjxpB50D3L30itwi2DI2oFZrJg= X-Google-Smtp-Source: ABdhPJzaEb6iRUBs8vG1T/NCmuSeoA+H7pRCO+9IjAbHDjLLd0/GzM8y+TuNlWPTQ+61/KQHolzhrw== X-Received: by 2002:a17:90a:b292:: with SMTP id c18mr2715897pjr.223.1600154985192; Tue, 15 Sep 2020 00:29:45 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id z23sm12531442pfj.177.2020.09.15.00.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 00:29:44 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset To: Efraim Flashner Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-reply-to: <20200915062139.GF17272@E5400> Date: Tue, 15 Sep 2020 00:29:43 -0700 Message-ID: <87k0wvxztk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Efraim Flashner writes: > On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote: >> (modify-phases %standard-phases >> + (add-after 'unpack 'declare-for-int >> + (lambda _ >> + ;; Declare the for loop i incrementer. >> + (substitute* "dbus/sigsegv.c" >> + (("for\\(i = 0") "for(int i = 0")) >> + #t)) > > Any chance of an upstream bug number or something for this? It seems > like the type of thing that might be put into a snippet. > That's a good idea, in retrospect Andreas did not report having this issue. Let me do a second in series that removes this hunk. The second hunk resolves the undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3 I think that change is a safe one.. Then I can do some follow up the for loop initialization errors. Hopefully it's just not me effected by that error. I'll see about making this a snippet as well. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 03:48:17 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 07:48:17 +0000 Received: from localhost ([127.0.0.1]:57099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI5hJ-00017n-46 for submit@debbugs.gnu.org; Tue, 15 Sep 2020 03:48:17 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI5hD-00017S-N1 for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 03:48:16 -0400 Received: by mail-pf1-f196.google.com with SMTP id c196so1485281pfc.0 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 00:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3nNGwimsNV5D2y2ogBC+QAsnmqMgiSGs1aRlZgoBm9o=; b=TqFkoj+iwrvWXv0eOX7RAQO2WsiXkOAeHRu6qXhIBZQZpx12DF3ULhIoyjrvioQQbl 31BRAB/+MSuI4vPTstkwbI9ggAU/sMGdV2ljbeSsWdrMcH7cLOnLXxAvDaLTrmWzQSyz R/T00VjedtXyeoU5RG/hlD2TDoXEXPlah8UikdqkmPDnrauc+o9oBT5p+qnd8nUc1UEb BYN3oRECTBTHYOdPywy50D0S5zN4AkJTySTSq22iVACoWXeOxyq58JgP78nhbg2JG4Gx o+Ip9dBCo1K+idOXIecVYKe4FrpyEXl08YpEt0PFvUTk373BVlBHu+0aJ5w5LlBq7m7K aAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3nNGwimsNV5D2y2ogBC+QAsnmqMgiSGs1aRlZgoBm9o=; b=ITiSEgQNF9RRnkvNC0LRp9PaV0TACPVmI28X7pHoXGyY9iDvyq0AbJJHcCeSMDcb7G hUq+BefCgdwGQwy3V1PngxeLIo0CuC3dy66YaZG793EXz0S8hzzf6nHAoh7F+aTiPo8W 7JkIZRvQTKrPxvvcTAEQwMnIY65+7RiT1Jas0ENI1w3PkDn4B4tBEDjb+TgrgmBJLnyf AGFK79AGN22flxYwifV+eKZaZC6dYsgZuzlhyzMYqswFW+mgkXjLMKnDtqrjfjVbRYSw o0kkN5Cq+z9sujUFt001PfuvqeqnqEug6ScLgQEG8WjYcs6glbGqoBzJXMQqJZ81mac2 skjA== X-Gm-Message-State: AOAM530oc//AYUrf86Oagb5w6Vr3W9LwEO7XpK+3PVgTg83+vU6o5Ocz mEIyODZargKopRSORdaWwSEUG8V76ho= X-Google-Smtp-Source: ABdhPJzINJJ349TXWTRiYY/XI2WhjnKyCbC6jizQqR1igd4N8CcntICQ2quTuvEYAouQcOTR5DV2dw== X-Received: by 2002:aa7:82d8:0:b029:13f:faa7:11c8 with SMTP id f24-20020aa782d80000b029013ffaa711c8mr4713785pfn.12.1600156085361; Tue, 15 Sep 2020 00:48:05 -0700 (PDT) Received: from neutron.hitronhub.home (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id n2sm11782508pja.41.2020.09.15.00.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 00:48:04 -0700 (PDT) From: Mike Rosset To: 43232@debbugs.gnu.org Subject: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required. Date: Tue, 15 Sep 2020 00:48:02 -0700 Message-Id: <20200915074802.267832-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Mike Rosset X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/audio.scm (jack2): remove 'declare-for-int phase. [arguements]: phases 'declare-for-int has been removed. since package now builds. --- gnu/packages/audio.scm | 6 ------ 1 file changed, 6 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 83c08b718e..fb98777290 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2047,12 +2047,6 @@ synchronous execution of all clients, and low latency operation.") "--alsa") #:phases (modify-phases %standard-phases - (add-after 'unpack 'declare-for-int - (lambda _ - ;; Declare the for loop i incrementer. - (substitute* "dbus/sigsegv.c" - (("for\\(i = 0") "for(int i = 0")) - #t)) (add-before 'configure 'set-linkflags (lambda _ ;; Ensure -lstdc++ is the tail of LDFLAGS or the simdtests.cpp -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 04:03:03 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 08:03:03 +0000 Received: from localhost ([127.0.0.1]:57112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI5vb-0001Vg-33 for submit@debbugs.gnu.org; Tue, 15 Sep 2020 04:03:03 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:56152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI5vZ-0001VG-Gj for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 04:03:02 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E15C12CD3; Tue, 15 Sep 2020 10:02:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2tccNDPvRSBE; Tue, 15 Sep 2020 10:02:59 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::c4d]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 078092896; Tue, 15 Sep 2020 10:02:58 +0200 (CEST) Date: Tue, 15 Sep 2020 10:02:32 +0200 From: Andreas Enge To: Mike Rosset Subject: Re: bug#43232: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required. Message-ID: <20200915080232.GA10884@jurong> References: <87363v7e7j.fsf@disroot.org> <20200915074802.267832-1-mike.rosset@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915074802.267832-1-mike.rosset@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hello Mike, On Tue, Sep 15, 2020 at 12:48:02AM -0700, Mike Rosset wrote: > * gnu/packages/audio.scm (jack2): remove 'declare-for-int phase. > [arguements]: phases 'declare-for-int has been removed. since package now > builds. I am getting a bit lost; it looks like this patch has to be applied on top of your previous one. But since the previous one is not in master yet, there will be no point in pushing one patch, then another one that partially reverts the first one. Could you please just post a new patch with the one modification you propose, to be applied on master? Thanks, Andreas From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 04:33:37 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 08:33:37 +0000 Received: from localhost ([127.0.0.1]:57144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI6PB-0002IV-0R for submit@debbugs.gnu.org; Tue, 15 Sep 2020 04:33:37 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:33148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI6P7-0002IG-Aw for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 04:33:36 -0400 Received: by mail-pg1-f177.google.com with SMTP id s65so1634394pgb.0 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 01:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pal5+ych73AQ/tH6UJJgKqgGlLycSne4N5E1ip+kr3o=; b=b+B8Hq+C7WjMajUIQ5MhVZ2HdS0R5D5VZBN0ysaeNKblPl7XA85lVd+Qo9osexZIRf mp0qUA4aMl4tvailtyJ5KCYZEWi8ZvcuF+vG+Z0HhNUVcM7l1KgUgpZjbtDo5IL/jSTi gcKJEjbSZuLfjlIDHr3oKL1q0AVeVU2bTO3f2YPyRDaTMv7Rils4pwxxEhzuQR30ln/E q4HpJHnf0dHhjB+Le4yA1BmwVETPTB9u23bDDnjbih+39pFskogI9sEI/7F0k+o2ecNr 2ZORQCwQkyYuiMfG3bVe59A0TEImNaYlZX5NrOV3xJT2hNQCsBT96jzOHgUqSCc+xBtl M5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pal5+ych73AQ/tH6UJJgKqgGlLycSne4N5E1ip+kr3o=; b=pB0HHY6BcXYrmE25OlVhb3LaMbEc2EqFTVXaiegbDWfwNG3Fb3rx2ByL32oGvxYKJY VI8f4YOEXf/NN8PNsmTdX8/Q9NzavEsW0UvVanayS9V7ZKC4gAFj46QDoZ+tpvk1ZPvK RTHChcQ2XMxQO+9iqetlT2yNHb1yRpNPsAMr4FRT+l9ZPL4kZ5KFsb/Cno4/gZ+wdOKN Gmktw2+xLVBYrMjlJXqA02lc19oBLAItgzlHfNro3fUg2uvufj9tHbVQmCSLXgO4DELM 0nPEhSBNZP2GLwQQ3Lc9BaKu8X0QZm+xMoYroUCyuwnJYg+Iv/OM51u7cV9LVt/BJqDq wihA== X-Gm-Message-State: AOAM531PibiRezgmtzklMTrcOeI76Xfu9bhi8QQHCEX4alBDZwVQ99gL uW9nZ+bcQRKkzYwIWasl4oxdzmgoGSU= X-Google-Smtp-Source: ABdhPJywOGuWgQ0MNTCDv0xX+NbtRxg/i82X1V6vZ4y4Kug5cbWhK6F59FKh0/7Du0e+ZSb2S9dg/g== X-Received: by 2002:aa7:9409:0:b029:142:2501:3989 with SMTP id x9-20020aa794090000b029014225013989mr905537pfo.78.1600158806873; Tue, 15 Sep 2020 01:33:26 -0700 (PDT) Received: from neutron.hitronhub.home (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id 99sm11647628pjo.40.2020.09.15.01.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 01:33:26 -0700 (PDT) From: Mike Rosset To: 43232@debbugs.gnu.org Subject: [PATCH] gnu: jack-2: Update to 1.9.14. Date: Tue, 15 Sep 2020 01:33:23 -0700 Message-Id: <20200915083323.277828-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Mike Rosset X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/audio.scm (jack-2): Update to 1.9.14. [arguments]: 'set-linkflags phase now adds -lstdc++ to the LDFLAGS environment variable. This fixes an issue that where the linker would fail with "undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3" on aarch64-linux system. --- gnu/packages/audio.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 38ee4f8bcc..fb98777290 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2030,7 +2030,7 @@ synchronous execution of all clients, and low latency operation.") (define-public jack-2 (package (inherit jack-1) (name "jack2") - (version "1.9.13") + (version "1.9.14") (source (origin (method url-fetch) (uri (string-append "https://github.com/jackaudio/jack2/releases/" @@ -2039,7 +2039,7 @@ synchronous execution of all clients, and low latency operation.") (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "1d1d403jn4366mqig6g8ghr8057b3rn7gs26b5p3rkal34j20qw2")))) + "0z11hf55a6mi8h50hfz5wry9pshlwl4mzfwgslghdh40cwv342m2")))) (build-system waf-build-system) (arguments `(#:tests? #f ; no check target @@ -2049,6 +2049,10 @@ synchronous execution of all clients, and low latency operation.") (modify-phases %standard-phases (add-before 'configure 'set-linkflags (lambda _ + ;; Ensure -lstdc++ is the tail of LDFLAGS or the simdtests.cpp + ;; will not link with undefined reference to symbol + ;; '__gxx_personality_v0@@CXXABI_1.3' + (setenv "LDFLAGS" "-lstdc++") ;; Add $libdir to the RUNPATH of all the binaries. (substitute* "wscript" ((".*CFLAGS.*-Wall.*" m) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 04:37:15 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 08:37:15 +0000 Received: from localhost ([127.0.0.1]:57178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI6Sh-0002PA-9T for submit@debbugs.gnu.org; Tue, 15 Sep 2020 04:37:15 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:37002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI6Se-0002Oi-VU for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 04:37:14 -0400 Received: by mail-pj1-f65.google.com with SMTP id kk9so1364685pjb.2 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 01:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=fTz4OPDg0UXEnoQQHIy6J5miiyxiTHkZXmoVM3f8p+4=; b=Vg07q1gxBaOk5Oi818W1VHl9Kbt9riH+CouqDEgyNnydDL26ZFns/23yWLf0qay1JS vWQbuUgxYMAzYvp4eQv/jEwL3WuQGjZiEw/CWydDuHmMQmRgCvIUCGDgu17utApUzQCH PEQHsg4ZCP+/u6hbgauwiR393+f6Qy/r41I3LEt5ZQuB4kmk7Kdapns5rSl7j6K3F30o NWCAimIOJsFLOIR6BdXITdFceuucB/uFcg8fDfJy6MO0QvMSRRf2Fv8kmWOQuSzFYLUB F/7rpDoYbLHbtpWW81tfrPLxLze59PmJbdb+8AFRFa44dVsSSPleZgoCPR4LUIxAINbr 5Ovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=fTz4OPDg0UXEnoQQHIy6J5miiyxiTHkZXmoVM3f8p+4=; b=Lt9PsTLXRzaADjdQj0BJZkRb4b5U4sCiP4oT60McVpyYQHv28M250I709AajOtaDPI 0LXZ6jeHZLrPQ9cw4gkJ8PrdILQaNMJAOIQHCuV6d6eywPM2LbRia3GcXiOsKt3LOIz+ 2+WziBCGRHsJ6KaQPaO1329xeIKtjnBM1WPGUCWJ0o33d3BEdwZ/KG0XmUiKs3BTFi4X 5cOoiCn6CAfJfg8UqO+ohIUT+cNeJBBxnSjr5/ErkdXDb51zYmhQpFanY6ch9KNaxnpe bQKZxfLBGsRr25dH+i/S5OlfPq63XybPGO2lBK3/p/2sc0grArnzoWbh+eIJ8bIKvm5C QuuQ== X-Gm-Message-State: AOAM531bKPiQ2IyLzwP8isOjF6ePMeNRYQnrw/4a5Med5bU3juRHslg7 eHjLvbgtHC6u1dO141aHz+9mRhUTv4I= X-Google-Smtp-Source: ABdhPJx7EXN949QA11DivnRtnpOyFAgVqipKprQfxlkOzKvFd5V1VVGbaJ1AWkK7MnytVMZX63/UVg== X-Received: by 2002:a17:902:6b05:b029:d0:a100:8365 with SMTP id o5-20020a1709026b05b02900d0a1008365mr18352910plk.11.1600159026910; Tue, 15 Sep 2020 01:37:06 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id c3sm13028956pfo.120.2020.09.15.01.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 01:37:06 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915074802.267832-1-mike.rosset@gmail.com> <20200915080232.GA10884@jurong> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset To: Andreas Enge Subject: Re: bug#43232: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required. In-reply-to: <20200915080232.GA10884@jurong> Date: Tue, 15 Sep 2020 01:37:05 -0700 Message-ID: <87h7rzxwpa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Enge writes: > Hello Mike, > > On Tue, Sep 15, 2020 at 12:48:02AM -0700, Mike Rosset wrote: >> * gnu/packages/audio.scm (jack2): remove 'declare-for-int phase. >> [arguements]: phases 'declare-for-int has been removed. since package now >> builds. > > I am getting a bit lost; it looks like this patch has to be applied on top > of your previous one. But since the previous one is not in master yet, there > will be no point in pushing one patch, then another one that partially > reverts the first one. > > Could you please just post a new patch with the one modification you propose, > to be applied on master? > > Thanks, > > Andreas Apologies, I just wanted to keep a series for posterity which normally I'm terrible at. I should have mentioned you could just squash them. I emailed a new first in series that squashed and improved the commit message. Hope that helps. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 14:48:56 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 18:48:56 +0000 Received: from localhost ([127.0.0.1]:60577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIG0d-00008e-RV for submit@debbugs.gnu.org; Tue, 15 Sep 2020 14:48:56 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:36998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIG0b-00008P-Sd; Tue, 15 Sep 2020 14:48:54 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 28214113C0; Tue, 15 Sep 2020 20:48:52 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Yij1vovrEMeq; Tue, 15 Sep 2020 20:48:51 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::c4d]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 473DC10C74; Tue, 15 Sep 2020 20:48:51 +0200 (CEST) Date: Tue, 15 Sep 2020 20:48:24 +0200 From: Andreas Enge To: Mike Rosset Subject: Re: bug#43232: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required. Message-ID: <20200915184824.GA3613@jurong> References: <87363v7e7j.fsf@disroot.org> <20200915074802.267832-1-mike.rosset@gmail.com> <20200915080232.GA10884@jurong> <87h7rzxwpa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7rzxwpa.fsf@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232-done@debbugs.gnu.org, Vitaliy Shatrov , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On Tue, Sep 15, 2020 at 01:37:05AM -0700, Mike Rosset wrote: > Apologies, I just wanted to keep a series for posterity which normally > I'm terrible at. I should have mentioned you could just squash them. No problem, it is just less work for me to apply just one patch :) I pushed the commit, thanks a lot! The new jack2 now also compiles on aarch64, so the original problem is solved. Andreas From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 15:16:17 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 19:16:17 +0000 Received: from localhost ([127.0.0.1]:60604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIGR7-0000nE-2G for submit@debbugs.gnu.org; Tue, 15 Sep 2020 15:16:17 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:36810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIGR5-0000my-7K; Tue, 15 Sep 2020 15:16:15 -0400 Received: by mail-pl1-f196.google.com with SMTP id k13so1851305plk.3; Tue, 15 Sep 2020 12:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=CqL4AjkZ89Q+IQjS4lRAoWp5/GdEGCorNXMQ/wDAsuk=; b=GrRUFmUImy+yR+naIxE1FhPwnBQjgyemfavxfCh2Yizd88oXNOshfNZn95zYsfoLvP WRtd6MY5MN0Cl5IMVwH/f3K0qftx1az3bz32nzN/GHGDTFsCuGb7Y0+Elv9dQnX/DI4y rAAB3eMO45fJdpeQiBDHso8cc3Z7LDxGg5vFrWPErVtf7khiVRBiTAettnQBE474jZP/ lNoIyNniKNlxgBPg3XLgzsiTldQgzyJu5ovT7qGu7ELUHx4SxiQXGtjYwCSLvqwJags7 m7YHu5wd+beVWe6Q0pjna1mHVOW9Ci7VQUsC/YusZpvDkvjmyjpRhN8afEVTontLzQFT AnmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=CqL4AjkZ89Q+IQjS4lRAoWp5/GdEGCorNXMQ/wDAsuk=; b=ah+YDCOwQzTqSjmcHIAODBOUKrKFkmUTZlTukIudVoloxWGyVRmmkKibhqx9GP/Gzb JNEr0CWEZgtg3Pyyt10LPV8KzPt+++SNT5mlsQiKmekmZQW5eYPqA/W2tKMoqpTd2g/A NSSxjZ76+59mRXvVNb/lY8MgCRFE0rclDLTsOKI4NhQpYEmLDJ/nmv5BGcEXJC50VCKD +Yi+F4uQuX5Xt9Y+9XaGpiwvrskihoCpyzMv6qNT3MxR1Uqvulihg/rRTCZT/INVbC6c ubq0NiBcZgIlVXLlCN1OP5mo2jMjtuNRSThBYccIp9EbRQYFuSAAErRQWUxsrLGqrfJc HTjw== X-Gm-Message-State: AOAM531wkGlx1ptEBJDDZdINALQKi8YRVLl7elnRSNHwSv8GPnFRBqM1 7SrMIL9Ivj43HuuaGgXTEGE= X-Google-Smtp-Source: ABdhPJxc1QQsImKGq2ig5Lxg73+PxpRgcZAxUqA3de+IlPPya+DS3TPiEZUPtycaRpP0i8bua12OAw== X-Received: by 2002:a17:90b:905:: with SMTP id bo5mr703843pjb.73.1600197369319; Tue, 15 Sep 2020 12:16:09 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id 31sm11822461pgs.59.2020.09.15.12.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 12:16:08 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915074802.267832-1-mike.rosset@gmail.com> <20200915080232.GA10884@jurong> <87h7rzxwpa.fsf@gmail.com> <20200915184824.GA3613@jurong> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset To: Andreas Enge Subject: Re: bug#43232: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required. In-reply-to: <20200915184824.GA3613@jurong> Date: Tue, 15 Sep 2020 12:16:07 -0700 Message-ID: <87een2yhoo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232-done@debbugs.gnu.org, Vitaliy Shatrov , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Enge writes: > On Tue, Sep 15, 2020 at 01:37:05AM -0700, Mike Rosset wrote: >> Apologies, I just wanted to keep a series for posterity which normally >> I'm terrible at. I should have mentioned you could just squash them. > > No problem, it is just less work for me to apply just one patch :) Totally understandable. I'll remember this in the future. > I pushed the commit, thanks a lot! The new jack2 now also compiles on > aarch64, so the original problem is solved. > > Andreas Thanks for reviewing this, much appreciated. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 16:40:52 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 20:40:52 +0000 Received: from localhost ([127.0.0.1]:60662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHkx-0002mv-O9 for submit@debbugs.gnu.org; Tue, 15 Sep 2020 16:40:51 -0400 Received: from world.peace.net ([64.112.178.59]:42022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHku-0002mf-Sh for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 16:40:50 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIHko-00004v-7d; Tue, 15 Sep 2020 16:40:42 -0400 From: Mark H Weaver To: Efraim Flashner , Mike Rosset Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-Reply-To: <20200915062139.GF17272@E5400> References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> Date: Tue, 15 Sep 2020 16:39:25 -0400 Message-ID: <87ft7ibwpz.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Efraim Flashner writes: > On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote: >> * gnu/packages/audio.scm (jack-2): Update to 1.9.14. >> [arguments]: new 'declare-for-int phase after unpack that declares 'i in the >> for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase >> ensures -lstdc++ is at the tail. [...] >> @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low latency operation.") >> "--alsa") >> #:phases >> (modify-phases %standard-phases >> + (add-after 'unpack 'declare-for-int >> + (lambda _ >> + ;; Declare the for loop i incrementer. >> + (substitute* "dbus/sigsegv.c" >> + (("for\\(i = 0") "for(int i = 0")) >> + #t)) > > Any chance of an upstream bug number or something for this? It seems > like the type of thing that might be put into a snippet. I agree that somehow this fix should be in the 'origin', so that this fix will be in the output of "guix build --source". However, I'd go further and suggest that it should be a patch instead of a call to 'substitute*'. Although patches are larger and a bit more work to create, they are far more robust. When this bug is eventually fixed upstream, a patch to fix it will begin raising an error, alerting us that it's time to remove it. In contrast, a call to 'substitute*' will silently start doing nothing, and may easily be forgotten. To make matters worse, a future version of jack-2 might add another 'for' loop in that file, matching the same pattern but where it is important that 'i' _not_ be initialized to 0. This 'substitute*' call, likely vestigial by that time but long since forgotten, could start silently introducing a new bug. What do you think? Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 16:49:41 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 20:49:42 +0000 Received: from localhost ([127.0.0.1]:60678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHtV-00030s-PT for submit@debbugs.gnu.org; Tue, 15 Sep 2020 16:49:41 -0400 Received: from world.peace.net ([64.112.178.59]:42082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHtU-00030b-FG for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 16:49:40 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIHtO-0000C1-9R; Tue, 15 Sep 2020 16:49:34 -0400 From: Mark H Weaver To: Efraim Flashner , Mike Rosset Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-Reply-To: <87ft7ibwpz.fsf@netris.org> References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> Date: Tue, 15 Sep 2020 16:48:17 -0400 Message-ID: <87d02mbwb7.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Earlier, I wrote: > In contrast, a call to 'substitute*' will silently start doing nothing, > and may easily be forgotten. To make matters worse, a future version of > jack-2 might add another 'for' loop in that file, matching the same > pattern but where it is important that 'i' _not_ be initialized to 0. Sorry, I made a mistake in the details here, since the pattern applies only when 'i' is already initialized to 0, but the more general point still stands, namely that patches are more robust than 'substitute*' for fixing bugs, and less likely to be misapplied or left forgotten in a vestigial state after they are no longer needed. Mark From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 17:08:02 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 21:08:02 +0000 Received: from localhost ([127.0.0.1]:60692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIIBG-0003UI-1p for submit@debbugs.gnu.org; Tue, 15 Sep 2020 17:08:02 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIIBC-0003Tx-G0 for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 17:08:00 -0400 Received: by mail-pf1-f195.google.com with SMTP id f18so2660664pfa.10 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 14:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=2SPkFXa81hWhwvqrnw56GjBrwGtSkUhPATLRg6aomBI=; b=DzjyCoW39r1xDIOuRR0D3+issb3IhAz/rGXC9h6IN1FaMQhkL6T199mkl+lSb+I9pQ 6J4ws9UjBo4fy8z7FGTr/eQ0ME9tNO8xn+NyXh3OgAkDMHDRQ7KB+q94hOLiU8WTOUhO QZAP5v2PNCZ1YjqfdhWky9HyRptkBJo0V8J6ks6oM9xE4H8ts4wJTEeXddMdYQ1RdJn9 liCW//qh/3tU+pN+Yh4Khfwpm0rgvDX0VsJ5tenWENq4zR+knlR1vzJXUYOdtB3xB8al ZPmAeVEc6/YVuuA/taVwdgFTcqA3VDfdPcv2LkUMJYEazfJJgU9Ydo1NWpVWEDE8tQmL sc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=2SPkFXa81hWhwvqrnw56GjBrwGtSkUhPATLRg6aomBI=; b=diEmYn9Q1nj8GJ60dCm54ql3bhCwKMaqeXdo/LU3CDETBVx8ByIXhyh8xocXOBCnGe xfUycZqVGLN65g1jzt/gXmkzinqF0dv7b6gGeHdVGmoLfds5zAlJfmcti1TXKZLiN7b3 gep4RGFL6bdoWUyRKeuqs3QdJRPuvmEjQyFuVzEZP5Ue7aPfwsjFdxa+nhLhkdiPrdAH JZ6eb1O9aedRweFwhxYE8alzWTsho4twOzPr6aVDiXRagGRa5l8ii+8B/lqNumizAX2h iqH6oPLqFnV0qvJHL8iKcgItoOYylff0Uyfq+pPLHnbs4XBnWuSC4XI7NmdGIlERKNwy vgew== X-Gm-Message-State: AOAM533+4jWCDabxGacX+YTmjtkSx7GA1jG/bV3YJXVIFmgAZ/tX6WJ4 ncHgkh/5IFdmSyoW8eIrITn8DrFvAME= X-Google-Smtp-Source: ABdhPJyphmAGp62MMJb+oTx2598XNvSEHC9/9W6EuPCjDQkVjw9ZhWAlquB3SolcIwI+MhnT5p/4Qg== X-Received: by 2002:a63:5f03:: with SMTP id t3mr15942691pgb.258.1600204072217; Tue, 15 Sep 2020 14:07:52 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id bx22sm394118pjb.23.2020.09.15.14.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 14:07:51 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset To: Mark H Weaver Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-reply-to: <87ft7ibwpz.fsf@netris.org> Date: Tue, 15 Sep 2020 14:07:50 -0700 Message-ID: <87bli6ycih.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Efraim Flashner , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mark H Weaver writes: > Efraim Flashner writes: > >> On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote: >>> * gnu/packages/audio.scm (jack-2): Update to 1.9.14. >>> [arguments]: new 'declare-for-int phase after unpack that declares 'i in the >>> for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase >>> ensures -lstdc++ is at the tail. > [...] >>> @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low latency operation.") >>> "--alsa") >>> #:phases >>> (modify-phases %standard-phases >>> + (add-after 'unpack 'declare-for-int >>> + (lambda _ >>> + ;; Declare the for loop i incrementer. >>> + (substitute* "dbus/sigsegv.c" >>> + (("for\\(i = 0") "for(int i = 0")) >>> + #t)) >> >> Any chance of an upstream bug number or something for this? It seems >> like the type of thing that might be put into a snippet. > > I agree that somehow this fix should be in the 'origin', so that this > fix will be in the output of "guix build --source". However, I'd go > further and suggest that it should be a patch instead of a call to > 'substitute*'. > > Although patches are larger and a bit more work to create, they are far > more robust. When this bug is eventually fixed upstream, a patch to fix > it will begin raising an error, alerting us that it's time to remove it. > > In contrast, a call to 'substitute*' will silently start doing nothing, > and may easily be forgotten. To make matters worse, a future version of > jack-2 might add another 'for' loop in that file, matching the same > pattern but where it is important that 'i' _not_ be initialized to 0. > This 'substitute*' call, likely vestigial by that time but long since > forgotten, could start silently introducing a new bug. > > What do you think? > > Thanks, > Mark Hello Mark, Turns out version 1.9.14 is not effected by this. So the version bump is good enough. I resubmitted a first in series with just the version bump and linker change. Which Andreas has merged into master. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 18:29:09 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 22:29:09 +0000 Received: from localhost ([127.0.0.1]:60773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIJRk-0005Ph-Qd for submit@debbugs.gnu.org; Tue, 15 Sep 2020 18:29:09 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:32816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIJRh-0005PA-HI for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 18:29:08 -0400 Received: by mail-pf1-f193.google.com with SMTP id z18so248958pfg.0 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 15:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=HQL2rmaekPwjvs9z3Wp9C9XI9rjIDDMiRkD26lrzyUM=; b=BG/fmJ0pgetU8qkb0rXfoDQP6HqgWWpogDdjwBjjWddvGPmeXzD+f6wQ7jNokRkuSD F3xfFLwsac95GVD8DT2gzzh3x7Skgl8d+gNrmdihM+9w+5d8Lv3IdndjUfkSZoFfio+I pv9Jdkrz5UjSYLt778vE1WG8SW92UHdwW8Wv6wxXRCubDUFgE2hFmsTqdC3BKFrYCRqZ 3+oyfP1M9gmaQcMJf9cGUC/OzICPnAyjakjidAF+r0lneqjRXloN6/TemBlyU4Suv7un 4hXIS7RPGgOY3USza/eO2wWlKG+KxuKSb9SCedg8syR35z2WwSyX1bhl+yHE+muHS6Bp Krig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=HQL2rmaekPwjvs9z3Wp9C9XI9rjIDDMiRkD26lrzyUM=; b=UhsuxeE3NbisaxZXR5rJDe9LbqPFIO1Q6C/sXujY3sxBwiyX4JAnTwHzI9FrR5+OQJ EcpflbtAXEqx2fTh89jfcE1KPG7f0qmW96Lj95OlXIQZCFINuAtbeaf0ELs3zh7wLeKm J53Vb5BKd9K6Gy6RvpBBFlcYX/x6REUvbvTe2wAHt33NafA/BSaRuMh5iLQfEBu6rndz rVplusfr9FbYr0d5fYURxfl+4Wf96EsgANaN9gKAg5CnjzyCpXmAFlOCweRZUtv1e/b3 baH6W1R8Osxaqd7fJtwiqdd+yhiYWcx2Fs/IEWAbkikaXXSH9iQwMeOwLonOjSj1sdVw fvgw== X-Gm-Message-State: AOAM5330oQJsCFUXo46T9QGTXCKq1/rb17dcaP9pN+0TD0q4EF6tsNrP dWaFyz+2YwFn0DLFS2BlfhmrxF/VzZo= X-Google-Smtp-Source: ABdhPJw4VfPlGDGXAQQmTF/EcBLjvcCGsmMaYuyTYTs66y0R3GHySV5VYIkGRD3YPlr3HwNwG+QSig== X-Received: by 2002:a65:5902:: with SMTP id f2mr2582515pgu.379.1600208939259; Tue, 15 Sep 2020 15:28:59 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id 138sm15312596pfu.180.2020.09.15.15.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 15:28:58 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> <87d02mbwb7.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset To: Mark H Weaver Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-reply-to: <87d02mbwb7.fsf@netris.org> Date: Tue, 15 Sep 2020 15:28:57 -0700 Message-ID: <878sday8ra.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Efraim Flashner , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mark H Weaver writes: > Earlier, I wrote: >> In contrast, a call to 'substitute*' will silently start doing nothing, >> and may easily be forgotten. To make matters worse, a future version of >> jack-2 might add another 'for' loop in that file, matching the same >> pattern but where it is important that 'i' _not_ be initialized to 0. > > Sorry, I made a mistake in the details here, since the pattern applies > only when 'i' is already initialized to 0, but the more general point > still stands, namely that patches are more robust than 'substitute*' for > fixing bugs, and less likely to be misapplied or left forgotten in a > vestigial state after they are no longer needed. > > Mark That change was not quite fitting right with me either. So I appreciate the review and comments. Thankful it's not needed with 1.9.14 and I'll take your comments into account in the future. Mike From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 18:47:16 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 22:47:16 +0000 Received: from localhost ([127.0.0.1]:60829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIJjI-0007jy-85 for submit@debbugs.gnu.org; Tue, 15 Sep 2020 18:47:16 -0400 Received: from world.peace.net ([64.112.178.59]:42482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIJjG-0007eH-3D for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 18:47:14 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIJj9-0001cF-Us; Tue, 15 Sep 2020 18:47:08 -0400 From: Mark H Weaver To: Mike Rosset Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-Reply-To: <878sday8ra.fsf@gmail.com> References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> <87d02mbwb7.fsf@netris.org> <878sday8ra.fsf@gmail.com> Date: Tue, 15 Sep 2020 18:45:50 -0400 Message-ID: <87v9geacau.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: Efraim Flashner , 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mike Rosset writes: > Mark H Weaver writes: > >> [...] patches are more robust than 'substitute*' for >> fixing bugs, and less likely to be misapplied or left forgotten in a >> vestigial state after they are no longer needed. > > That change was not quite fitting right with me either. > So I appreciate the review and comments. Thankful it's not needed with > 1.9.14 and I'll take your comments into account in the future. Sounds good. Thank you, Mike! Mark From unknown Wed Aug 20 05:43:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Oct 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator