From unknown Sat Jun 21 10:26:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43228 <43228@debbugs.gnu.org> To: bug#43228 <43228@debbugs.gnu.org> Subject: Status: r-v8 doesn't build since node 10.22 update Reply-To: bug#43228 <43228@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:26:34 +0000 retitle 43228 r-v8 doesn't build since node 10.22 update reassign 43228 guix submitter 43228 Pierre Langlois severity 43228 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 13:45:27 2020 Received: (at submit) by debbugs.gnu.org; 5 Sep 2020 17:45:27 +0000 Received: from localhost ([127.0.0.1]:44018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEcFi-0007mn-SG for submit@debbugs.gnu.org; Sat, 05 Sep 2020 13:45:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:47454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEcFh-0007mg-H0 for submit@debbugs.gnu.org; Sat, 05 Sep 2020 13:45:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEcFh-00040w-94 for bug-guix@gnu.org; Sat, 05 Sep 2020 13:45:25 -0400 Received: from mout.gmx.net ([212.227.15.18]:53569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEcFf-0001jr-9z for bug-guix@gnu.org; Sat, 05 Sep 2020 13:45:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599327921; bh=8LXEo0qw0Oah1T6PqdWRNIBOkKqc4B/vU/lk/XXKh4Y=; h=X-UI-Sender-Class:From:To:Subject:Date; b=KHQNWE1e22aJ05gMelXPZVecQmOX7V+qQm6fT8B+DVr9dd8RapCJt83uk+fVejH1B eWZlLs39NvcqM89lrBa5atL8wzcqv3oJ/s0peSAjQNlsXNnUH/xfk8iGRLx3yXZdIQ Nwi24WIWnwHC86zWSV6a0HaUTL6rjCHK9Q7VZvBY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e119807-lin ([82.69.64.142]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MQe5k-1jt6r11sdK-00NklT for ; Sat, 05 Sep 2020 19:45:21 +0200 User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois To: Bug guix Subject: r-v8 doesn't build since node 10.22 update Date: Sat, 05 Sep 2020 18:44:52 +0100 Message-ID: <87sgbwi0dn.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:imny2Z/PDmF/nk0vBAc0U+X40e0TZampCWd9XAjf2kRo/p2Y2r5 3PBL/HZDoLlkkQPWIfiR7M37jIrkGfxgyuyWSLu/EliVmZ8uyZ8GHFPJPCKkF7VM/2J3L1R 1yo/YOJ+ByMP4PZCfW+r72i7jn4EZGgWzVuH/o4EF44XOelUGKM8DaFdQTzOqnIxBa1Q0Lm uo5AKQ4LGywl9d+PCK5Sg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kJsCDIQW0M4=:ikpRMMwnBG+cm5Hx1sd53w k5wy6D5eQAkkG71YpV4CRobmDPCXWdtUq73zDgoC58L3jKCNTLgmQUWHTg0Uv5gu+838IMjUR TRB3JY1JFZccuag4JjX4nBsK40BNTHA6j4tleqg7lPxejgY6tEo44gJSkQRJvsbQCJUdtMNwC LCmhIBGZBcpHajUzcJbNUQiYpf3Dpmf3HpoMLhyUKuiiz/VqR5/GvDR0TYHORPK+yd4xM2nUg ICCo2OrvxM0KGzbYlxuLkeJFVnNYD3PeCBLh9ukXZxHb1GzC9fhsnbBgzZbTuYVb5NpvwtQGw PLX8PHLSOAxnwC2DKM8alYjlcQz4HY0LzmQdpea7izsxaV1Qx0FHVvDxN8YM3JzOy+Hnq2fp3 6/xTT24HXLUe3D//pRPJpZuRYER9woCZwBBYlZzKROtPqu8nmWyH3cdNAfZjvPERxsoZLarNa NFO5IR4YpUXoh8xapxzjF0yy07FNfHGTxtEfn9/b9WhFal3Nh4ALE187lRykjGtAjZm4IXx6c 8FM0kNyEJlJud8gNtnrrgtiHTOHzte+MubhgWPblYS25T08aXW7wM3u1gMocQNBnd0cGtqWdk UfVimK/N6hCj0ITWgJGOyMEHltrdsfbPCXcnp8m5cWkt57jMuSxe/QXPVar1xSGos5xyKUHAk RbL92RaRMlwFZ5AlO7+zRjeg9yPKLjDSRzc7S7uWwvn+1e9uAmprVGjOpTGndLKboJMZ3ulII Ke/Uwh6IT7yjlw85mb4bKUe70qov2+c7gKSJw55QTWN3eLAqZvrJUeUmpoQsUq9HVGMujFTKb I7iOyMODZOuBR31FKdUnCzZ5vFdv/IjKwuRSqa4SKTCgNkHbBeha3oQvmsLjIMabgGDVkmume GmvVvaKwEUlKjJH4fPTQ9x+cnlaHSkJhAxuh+6bijALoLdX+y269jAZSwKX167hPATsjDkX6B aXvPyJs4q9gvsyb5RQLcPNB5qEDb3ezkHGbAGp3DCFAbDziTS5Vm/y99Jn6faJhmhzXuFX0/q vzuwQn6NTHen9S7+91OEOgkLnFHjJd3eCfBDZ+4ykJZt+h4lc6KrZSGlOc7gXIa/4mg5GhvNi 06OflcILY0/Q0zkk7VxwLG8OG99wl/6/0o5YCo/bbXqw+2GqZ6pKPdEDz35RP5J9lZ6ykConr 6BilGNT0d9gGzWrfca+SLNRvt2cM4Dzst/cjqfeUGQqdNghFVmvmkNRYJTh9cVfRwMuM4yQEG pq563nG1gc6rULomQvgZohXh4rs3AzItvTvzd2Q== Received-SPF: pass client-ip=212.227.15.18; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/05 11:58:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hello Guix! I'm afraid I broke r-v8 and a few of its dependants by updating node, sorry about that! AFAIK, the new node uses a function from nghttp2 1.41 that's not present in 1.40, `nghttp2_option_set_max_settings'. However, since curl depends on nghttp2 we've grafted 1.40 -> 1.41 to avoid a full rebuild. Looking at r-v8's log [0], it complains that the symbol is missing, indicating it's trying to link with the old version 1.40. I /believe/ it's inherited it through r-curl. I'm not sure how to fix this, I'm happy to revert the node update if needed, let me know! Then we'd have to wait for the next core-updates cycle so that we no longer graft nghttp2. Unless somebody has a better idea? Thanks, Pierre [0]: https://ci.guix.gnu.org/log/62nkhf9dnlzgw3dz9khd79khqdpaib79-r-v8-3.2.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCAA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9TzpQYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UoMoH/0O73yNVa6sHJDHeSqHOky/I HOVY75XJTcKOj1zBTtGC67TpM+El+AR56c781VQyR/g923qM0fgi7OfVQeec4xX+ yqyviDg8zcYj9hI1hys2tc9eMcJNA1GlxYcipzGhxFn1mXlJrJAVSO0sEBNw3bPr ofMHGBOvLu8ykFqQlcfGi0ssluhn6fZMylvF3JFFfsJCnR1p5jL0MqUp0ZRfSJOT g8bbggBhuWFfvJXhEU8guuEBHuPFgx72/I0hD1IyEe0T+qgrGbuH0arqTyNuni6h fRnBxPQonA8A+xljLWox0G02JjsTktRdIaTG9mAn9JX4UNiqf4b3qFvqbK9y0po= =GLpB -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 14:37:15 2020 Received: (at 43228) by debbugs.gnu.org; 5 Sep 2020 18:37:15 +0000 Received: from localhost ([127.0.0.1]:44057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEd3q-0000ZS-ST for submit@debbugs.gnu.org; Sat, 05 Sep 2020 14:37:15 -0400 Received: from world.peace.net ([64.112.178.59]:59420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEd3p-0000ZD-5O for 43228@debbugs.gnu.org; Sat, 05 Sep 2020 14:37:13 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEd3i-00022w-BU; Sat, 05 Sep 2020 14:37:06 -0400 From: Mark H Weaver To: Pierre Langlois , 43228@debbugs.gnu.org Subject: Re: bug#43228: r-v8 doesn't build since node 10.22 update In-Reply-To: <87sgbwi0dn.fsf@gmx.com> References: <87sgbwi0dn.fsf@gmx.com> Date: Sat, 05 Sep 2020 14:35:52 -0400 Message-ID: <87tuwcqdek.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43228 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Pierre, I'm quoting your message out of order to ease my reply. Pierre Langlois writes: > I'm afraid I broke r-v8 and a few of its dependants by updating node, > sorry about that! [...] > I'm not sure how to fix this, I'm happy to revert the node update if > needed, let me know! Then we'd have to wait for the next core-updates > cycle so that we no longer graft nghttp2. We will actually need node-10.22 (or at least 10.21) in 'master' in just over 2 weeks, when we'll be compelled to update IceCat to version 78. On Sept 22, Mozilla is scheduled to release a new batch of security fixes in 78.3, and there will be no corresponding 68.x release. (In fact, I had an *identical* commit on my private branch to update 'node' to 10.22, to allow testing IceCat 78 WIP.) However, if needed, I suppose it might be sufficient for my purposes to leave 'node' at 10.19.0, and to bind a separate 'node-10.22' variable to the new version. > AFAIK, the new node uses a function from nghttp2 1.41 that's not > present in 1.40, `nghttp2_option_set_max_settings'. However, since curl > depends on nghttp2 we've grafted 1.40 -> 1.41 to avoid a full rebuild. > > Looking at r-v8's log [0], it complains that the symbol is missing, > indicating it's trying to link with the old version 1.40. I /believe/ > it's inherited it through r-curl. If grafting is working as it should, then nghttp2-1.40 should never be linked at runtime. However, it is certainly the case that most things (except node-10.22) are *built* against nghttp2-1.40, where the aforementioned symbol is missing. One possible solution might be to update the replacement (graft) for _curl_ so that it's *built* against nghttp2-1.41. Something like this (untested): --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 55b7e4393b..bfcb52b678 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -183,6 +183,9 @@ tunneling, and so on.") (sha256 (base32 "0wlppmx9iry8slh4pqcxj7lwc6fqwnlhh9ri2pcym2rx76a8gwfd")))) + (inputs + `(("nghttp2" ,nghttp2-1.41 "lib") + ,@(alist-delete "nghttp2" (package-inputs curl)))) (arguments (substitute-keyword-arguments (package-arguments curl) ((#:phases phases) --8<---------------cut here---------------end--------------->8--- Would you like to try this and see if it solves the problem? Mark From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 15:30:16 2020 Received: (at 43228) by debbugs.gnu.org; 5 Sep 2020 19:30:16 +0000 Received: from localhost ([127.0.0.1]:44117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEdtA-0001sx-0M for submit@debbugs.gnu.org; Sat, 05 Sep 2020 15:30:16 -0400 Received: from mout.gmx.net ([212.227.15.18]:44237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEdt8-0001sl-F8 for 43228@debbugs.gnu.org; Sat, 05 Sep 2020 15:30:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599334207; bh=WnD+KR0A9eEK2ifCWpfAxF0SC2fPgRZWNbuSgNaRl84=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=OSsgc0aZZX3DBy7aSkn0xbUUDOFGpDR/oAcWCdVRk/fxcXaz0yWKOrxdAhic0yYwc sc24yr1z3BWHNJrL3dLhtegtQ5rgqKxRM3+nQ+x5Ke+q8BHGbV6EJmGO/TUTGZG4GV CTVHLRB4JUhgsLHyCKsM/6nkqx8chRUw/L+vPCyM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e119807-lin ([82.69.64.142]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MmlXA-1kx0mG4BEs-00jrGl; Sat, 05 Sep 2020 21:30:07 +0200 References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois To: Mark H Weaver Subject: Re: bug#43228: r-v8 doesn't build since node 10.22 update In-reply-to: <87tuwcqdek.fsf@netris.org> Date: Sat, 05 Sep 2020 20:29:37 +0100 Message-ID: <87blikhvj2.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:Nh0apE9+VYN0xN6B3YGZ/uPkrZCJj8xhCpPW4LgmYefEzu+auS4 8fZkxXAs97Xf2zhnPZoE4m31gDCC0mbMMzTVlLgK/l/DSDiTwGQyI3mWWL6AnLNKOPdHyK0 +gkJzDBU8fBkhdXwuv6FcAbK3jl0RiYi+5Lp31VFm7ZnvsCLR4/J4xpQzv9WsotKWTkAuwf iMBlwnAILyuKSGIbBkvgw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6TIBVGO/SyY=:vESXH3H/wIYrQ0HwbX/a5l th8dqubNtGGwpva6FSjyOahNCaXbbX4+vP1E18xuHded3FOQyw4pDst4MFWL0QfOc5t4+IJbe D5pbNu2yNJSt16E5FdW39EWpsDNiUHvsNJ4LUg40eB8hWoH9WlXsOsR/NPxznWO/T7iMCFxxe Tc1CPMCAYyXThas8gERi8G79xV2J70v6KHQbrmXHY7HYtKZb6vut5V+D42EGS/pbbF3sZKJ3D OI1tI9rAqBrWm7rYY8w6XoDN3rc64h1xh0sndtwZtkVow6Dalj7WPMQX140Ozun0WSjQvHh+W Ve+84NOFCU+9Ugfb2+qH92s7pX5Mn78ZYVM1juED9rzzRrkwOq5i8WXupGs2wdTYUNZGLug1x /66XSkSfu8VyBBAvz+rCu/SjxT8qz0FYj89hBaKxpHwlDiYCiHIRw71P6YtcBfbqQ039sPN9Y KWUUWIbgIXnPMZxep1f/179i3/h0PbDF0QV5sRu4kElFJBt7/9TgrFywQkAEbGhkU4wsqqVO4 +wjoOYevEFTWclHK87OLx1WCDSOcYSEKJq/n2m5Jq5liTZNJpMRitMutQj1W0mxj2tUywfCP5 njDAc0LT70AcjYhgw/3WM3AbcXsrKPeQNUkdfXMA86nELQj2RZL+HbYdP02ohKBKWkjtf370U 8xelFsRZ9pUjf4qzr4tU/BhcIkt23s5NEPYGLJg/v53guT1yo6jDT9zIRNDg4mJQnf/LnVm7V eg68D8GsWAcRy1J0Y08FbZmSh2oXO4XcknZxATuozp6VoR4UxaW4twkrwKh9DIwI+c0Y1Ok4J 56gZ/qDIdWM4F+m8iM2b8o6WFrHWJJhZwdO6QqZDNKTddc5WdeJ2Ib+jMCujtWCt/Baa13kqv ns/6H/sanWRqJRZPjtZc+GLdrjojiM8t0xBa+X3W1j4YBT+4xlxpduZU7tN4e77gYx/3FUKy6 jfV+Gw6bOvicP+4g157SzRHrPuzT2r4UaWU6CzhFzcH1saSYfCtiXIMQRNHIk/9FdvYQAU4np Z2/n2w4GSGZXPIk3pneiKVeEM9bA0dKJGYlU2p59+5erYD/2LdYkJ2WMvwW3VFtaWFlkBpfHR 1XVKH6HfNDdc0AFT/AV6qTRhoU71GtXiIYL692wy2usSvk2WCmxewsg5pINiaS13wYSITil7w rsIkk5PGOlfAz2sxwxdSwmO/o5nMY6VvTeyEWzeDU6N7hvDAhpNkqhL8aWC1ZaTfX1v7E4Vwz nit/Fbpfdza1tDbhIVss2YsFbtdhjI7uK7WeyJA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43228 Cc: Pierre Langlois , 43228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Mark, Mark H Weaver writes: > Hi Pierre, > > I'm quoting your message out of order to ease my reply. > > Pierre Langlois writes: > >> I'm afraid I broke r-v8 and a few of its dependants by updating node, >> sorry about that! > [...] >> I'm not sure how to fix this, I'm happy to revert the node update if >> needed, let me know! Then we'd have to wait for the next core-updates >> cycle so that we no longer graft nghttp2. > > We will actually need node-10.22 (or at least 10.21) in 'master' in just > over 2 weeks, when we'll be compelled to update IceCat to version 78. > On Sept 22, Mozilla is scheduled to release a new batch of security > fixes in 78.3, and there will be no corresponding 68.x release. Oooh cool! Looking forwards to icecat 78! > (In fact, I had an *identical* commit on my private branch to update > 'node' to 10.22, to allow testing IceCat 78 WIP.) > > However, if needed, I suppose it might be sufficient for my purposes to > leave 'node' at 10.19.0, and to bind a separate 'node-10.22' variable to > the new version. > >> AFAIK, the new node uses a function from nghttp2 1.41 that's not >> present in 1.40, `nghttp2_option_set_max_settings'. However, since curl >> depends on nghttp2 we've grafted 1.40 -> 1.41 to avoid a full rebuild. >> >> Looking at r-v8's log [0], it complains that the symbol is missing, >> indicating it's trying to link with the old version 1.40. I /believe/ >> it's inherited it through r-curl. > > If grafting is working as it should, then nghttp2-1.40 should never be > linked at runtime. However, it is certainly the case that most things > (except node-10.22) are *built* against nghttp2-1.40, where the > aforementioned symbol is missing. > > One possible solution might be to update the replacement (graft) for > _curl_ so that it's *built* against nghttp2-1.41. Something like this > (untested): > > --8<---------------cut here---------------start------------->8--- > diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm > index 55b7e4393b..bfcb52b678 100644 > --- a/gnu/packages/curl.scm > +++ b/gnu/packages/curl.scm > @@ -183,6 +183,9 @@ tunneling, and so on.") > (sha256 > (base32 > "0wlppmx9iry8slh4pqcxj7lwc6fqwnlhh9ri2pcym2rx76a8gwfd"))= )) > + (inputs > + `(("nghttp2" ,nghttp2-1.41 "lib") > + ,@(alist-delete "nghttp2" (package-inputs curl)))) > (arguments > (substitute-keyword-arguments (package-arguments curl) > ((#:phases phases) > --8<---------------cut here---------------end--------------->8--- > > Would you like to try this and see if it solves the problem? I'm afraid this still doesn't solve the problem. AFAIU, grafting the new curl happens after building r-v8, so at link time it still sees the old nghttp2 version. Thinking about this, since the new node essentially uses a new ABI to link with nghttp2 by requiring a new symbol, this isn't something we can fix with grafting I believe. It's possible to make r-curl specifically depend on the new curl like so: =2D-8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 2c202e8508..16022c695d 100644 =2D-- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -1038,7 +1038,7 @@ if(_ca_bundle !=3D NULL) { curl_easy_setopt(handle, C= URLOPT_CAINFO, _ca_bundle); } " m))) #t))))) (inputs =2D `(("libcurl" ,curl) + `(("libcurl" ,curl-7.71.0) ("zlib" ,zlib))) (native-inputs `(("pkg-config" ,pkg-config))) diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 55b7e4393b..aa103306a6 100644 =2D-- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -172,7 +172,7 @@ tunneling, and so on.") (inputs (alist-delete "openldap" (package-inputs curl)))))) =20 ;; Replacement package to fix CVE-2020-8169 and CVE-2020-8177. =2D(define curl-7.71.0 +(define-public curl-7.71.0 (package (inherit curl) (version "7.71.0") @@ -183,6 +183,9 @@ tunneling, and so on.") (sha256 (base32 "0wlppmx9iry8slh4pqcxj7lwc6fqwnlhh9ri2pcym2rx76a8gwfd")))) + (inputs + `(("nghttp2" ,nghttp2-1.41 "lib") + ,@(alist-delete "nghttp2" (package-inputs curl)))) (arguments (substitute-keyword-arguments (package-arguments curl) ((#:phases phases) =2D-8<---------------cut here---------------end--------------->8--- But I'm not sure I like this very much, this is getting a bit messy. Instead, I'm thinking your suggestion of leaving 'node' at 10.19 for now (or 10.20, I can try that) and then introduce a 'node-10.22' package that can be used for Icecat is better. I can do that. How does that sound? Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCAA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9T5yEYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31U1FwH+gOHU7kaXjGVnnQmwMkuIHyT JDM55/wUtEyzVFJjpH8EC8k5KoBn2zKHljQv3Z/329y96wjJ++C/R4dJgCv7Fx2e v+SOffrBFEB+ANSqHSDAZLAIBoUJl+ewQWWpJMi4aZSiv+gPje15COJD0cUBKnJu S5uA6rcRTxqPZAGhyTT22WCnzxJ8APyTHw1fDuuA8Tzd5QusKV1vTqAMccepSRoK VizgxLX0ZYXMqYgzcEVXSKzwqyKcCIO92CEgrgMjpzcYqxCy1P8gQAxPckYCdpI0 3QCmwo2SAO6PGCOa6gmDS5rxAGhtsgrYbJlbMfotb9sbj+2ppnbAcvKUey2cZ18= =cjHU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 19:15:08 2020 Received: (at 43228) by debbugs.gnu.org; 5 Sep 2020 23:15:08 +0000 Received: from localhost ([127.0.0.1]:44354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEhOl-00038c-UR for submit@debbugs.gnu.org; Sat, 05 Sep 2020 19:15:08 -0400 Received: from world.peace.net ([64.112.178.59]:60722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEhOk-00037n-1N for 43228@debbugs.gnu.org; Sat, 05 Sep 2020 19:15:06 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEhOe-0006yk-Eh; Sat, 05 Sep 2020 19:15:00 -0400 From: Mark H Weaver To: Pierre Langlois Subject: Re: bug#43228: r-v8 doesn't build since node 10.22 update In-Reply-To: <87blikhvj2.fsf@gmx.com> References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> Date: Sat, 05 Sep 2020 19:13:46 -0400 Message-ID: <87o8mjrf3u.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43228 Cc: 43228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Pierre, Pierre Langlois writes: > Mark H Weaver writes: > >> One possible solution might be to update the replacement (graft) for >> _curl_ so that it's *built* against nghttp2-1.41. Something like this >> (untested): > > I'm afraid this still doesn't solve the problem. AFAIU, grafting the new > curl happens after building r-v8, so at link time it still sees the old > nghttp2 version. Ah yes, that makes sense. > Instead, I'm thinking your suggestion of leaving 'node' at 10.19 for now > (or 10.20, I can try that) and then introduce a 'node-10.22' package > that can be used for Icecat is better. That indeed might be the best approach for now. > I can do that. How does that sound? Sure, sounds good. Thanks! Mark From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 07:17:04 2020 Received: (at 43228) by debbugs.gnu.org; 6 Sep 2020 11:17:04 +0000 Received: from localhost ([127.0.0.1]:44899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEsfQ-0006YN-3J for submit@debbugs.gnu.org; Sun, 06 Sep 2020 07:17:04 -0400 Received: from mout.gmx.net ([212.227.17.20]:41035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEsfO-0006Xr-OS for 43228@debbugs.gnu.org; Sun, 06 Sep 2020 07:17:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599391016; bh=b1PkSgF7X/+hymfpXN4klWwApW0BRskOvb1fQCCqC/M=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=DwdPqGZ80DNZ3LreDaAF2aGeZKCuoeQt3fT3Q5X3X0VXsyCeWNrnQi6Io0UB+o5m7 KNAb93VCmPxqcF1WbGp41Ix6TX/NWi4ta8JZCfOmO/TvRfQBqkvV/Tvu+O8ISlOZ92 oh0kmQvUBlLa3S9lMxUQ1gJZIsFFYti9b0As+eX0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2E1G-1kglRG0n0g-013f2q; Sun, 06 Sep 2020 13:16:56 +0200 References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> <87o8mjrf3u.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois To: Mark H Weaver Subject: Re: bug#43228: r-v8 doesn't build since node 10.22 update In-reply-to: <87o8mjrf3u.fsf@netris.org> Date: Sun, 06 Sep 2020 12:17:00 +0100 Message-ID: <87pn6z5f4j.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:D0JTePx/KQjfq1lkMO9YQ+Poj+qjAgX0uokepFaCsT8yY/q52H3 EtYPqy15PF+HtqE7b8/s18JdW5aWW6c3C9EDXbVJ4+5J+xj+YDdtlvBt6dYsWpo/2luPxLo 3F+7Wd0ncrGNW7FX8jNi/hH1UUDypb9UnfWsV1pwI/TDj77waiGerrpQS/qJ9E4jR6ZKl88 uDdresQyXon4UBdSnhsRQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:NIwFkIHe4iI=:M0r6yKX5Fh5Gln7aYpmWfM nRn6HyipmBAR8JHFBiNmrGCiPRvgao/qFx2MQ+BbwUn4GJ6m3g0eOvlp2OILrXffNxvgLCrnV NMh4J+YZ+DvArxhhlg/te3uyHIrFRWvyy7v/j/ONz4F/ZIC1Jqj7WvhTSNURAxRjahPr2RT/R ihAcOfGeMwlYUvStYJA2UhJsM8HkVUNoYkTFNHFsrsXJO1B1yw1SMBFDrYXJ1O9BfIF3ynLMw rcZQ7jWK4do9D6ZiC1IN3Op4LNx4q5Th/f9ZVM3RufdTBg5wQY7nfBHLvmZAv9O6lt2YR/7YF nbSb+h9tAP6/R3pvUrO694n3ZgKCdDvNUL8U3QoYsQbKrXviBiqqBlVTBFPnMGvHPq8J/1z5F wM9guHwjZUoPhnc/J15lql/wGSE+kQoH+8qnWvCKcmgbVfu3injpbXKSF//zmLcUd8GaqMi3n t/Bbc+E33NcrIKkvpDGk9loJCTAC6pbRVxdLzVU0vUsVGT9dhxKO6yCGxviiPcqr8xbO1oKO8 RaOPoWo9n9D0WnQyq2S0qo/X/C5dXebHj5Exp88RBX8zJ8fGDD1LWBdM+2B+zhqf17FCt6Dc1 41bzijlRJkRSdyVAZ3jaIeD2bML+Ls2TYSEE2uDTl3g6uA00dPu3sCLGeu9B/jiRlekmANjhV qP/dT7n/HgH5O0Xq3uFqWcgqF1liSJU8reKtbHjOYE31aPc+2hpWN8fZIGXIK0PiUw1Bp3cvV FIB+zd3/l5g1pXjG27623XC8nQol6TjrsFJJp32c+7vYyssIAFBarJvP5PLfQNshA7du/eF9H nGouF5uaB/528iY9HpmFPwGZxzRRcL0wrVRYbyZD2FLO7ojmGo7kmk2doLeDW2cy0hSl0vkQL Cr1KY8p6KWWMKXOjwPSHwD6AdqJNlxq1RLNlJU9zZqqVr3EMVtXAHWRg9YJijjjQX60sWLQLX SExHTEjCYftlmuhcWCxEJF1bxC9tul43kQzkamQWLmhFQ1muMiYLbhE1YHIYIu3Rex/QCIIj3 6zZW3jQYLfekTfKJFAVDXXDdyJaEU2dI1gaRheGEx6tovhK/aaOMNg0GJ1C0UdRVd2H30p0TE GdHtaRenV6BzunwZ3y8713syzcI/kjELX3SFRqTs4I9uw+HIngUCr9EH04Tewte0c3yKlbR6H RNRbCjeQuBK8mvxw0bIpm6yw3lwEhLwtx/PX8PRY/ac5P3A1xeo4DsWrWqdMxbZ9BjbLDSjC2 hChHxpmI8V19OPl83jemozzuJav4NrXjg97xtHg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43228 Cc: Pierre Langlois , 43228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Mark H Weaver writes: > Hi Pierre, > > Pierre Langlois writes: > >> Mark H Weaver writes: >> >>> One possible solution might be to update the replacement (graft) for >>> _curl_ so that it's *built* against nghttp2-1.41. Something like this >>> (untested): >> >> I'm afraid this still doesn't solve the problem. AFAIU, grafting the new >> curl happens after building r-v8, so at link time it still sees the old >> nghttp2 version. > > Ah yes, that makes sense. > >> Instead, I'm thinking your suggestion of leaving 'node' at 10.19 for now >> (or 10.20, I can try that) and then introduce a 'node-10.22' package >> that can be used for Icecat is better. > > That indeed might be the best approach for now. > >> I can do that. How does that sound? > > Sure, sounds good. Thanks! Cool, here's a patch to do just that :-). I tried to update node to 10.21 but that still required the newer nghttp2 lib, but it worked for 10.20. Thanks, Pierre --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9UxSwYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UcDwH/A3B1ce50Ask2Z4K5pgaIVOs CjSoUsnkIO2UM28ZSshjv1tX9bvt8MfAy6B41v82RCnZYlpug30QOMORT6+9eY2o wYfw/3Ksk5na+N+glP5ME8LuCNVexqP7LZ4vMBbPnR9JtVW/FdmtTM6isltk6AAy YOkt8wMZW/RKD0Dq4tgGVyoCftjyNpS7FAsvQdy8ZkcKD1bN4OLvOzyDM4ya6IpX OtH+9t5xUOAv243ggJ5a3n3IegVFJ4Ft8jtuchlvHRaCkl0WK6LDDsJiN3whnJrV kfCFcQ6odQvEhipVSyf3Jh4YGhEKHwQWlHZ7tkgwbweaSt2gj2/qUjBmBxVhb7A= =2eIH -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-node-Downgrade-to-10.20.0.patch Content-Transfer-Encoding: quoted-printable =46rom eb00ab49df23f7319009a9fec7fc2805016e2e25 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 5 Sep 2020 21:05:08 +0100 Subject: [PATCH] gnu: node: Downgrade to 10.20.0. But keep version 10.22.0 around with a new node-10.22 variable. * gnu/packages/node.scm (node): Downgrade to 10.22.0. [inputs]: Downgrade nghttp2 to 1.40. (node-10.22): New variable. =2D-- gnu/packages/node.scm | 44 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index ed0b5c4f16..345668fa56 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -25,6 +25,7 @@ (define-module (gnu packages node) #:use-module ((guix licenses) #:select (expat)) + #:use-module ((guix build utils) #:select (alist-replace)) #:use-module (guix packages) #:use-module (guix derivations) #:use-module (guix download) @@ -47,14 +48,14 @@ (define-public node (package (name "node") - (version "10.22.0") + (version "10.20.0") (source (origin (method url-fetch) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.xz")) (sha256 (base32 - "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")) + "0cvjwnl0wkcsyw3kannbdv01s235wrnp11n2s6swzjx95gpichfi")) (modules '((guix build utils))) (snippet `(begin @@ -186,7 +187,7 @@ ("http-parser" ,http-parser) ("icu4c" ,icu4c) ("libuv" ,libuv) - ("nghttp2" ,nghttp2-1.41 "lib") + ("nghttp2" ,nghttp2 "lib") ("openssl" ,openssl) ("zlib" ,zlib))) (synopsis "Evented I/O for V8 JavaScript") @@ -200,6 +201,43 @@ devices.") (properties '((max-silent-time . 7200) ;2h, needed on ARM (timeout . 21600))))) ;6h +;; TODO: Make this the default node on core-updates. This cannot be done= on +;; master since this version of node requires a newer nghttp2 library at = link +;; time. +(define-public node-10.22 + (package + (inherit node) + (version "10.22.0") + (source (origin + (method url-fetch) + (uri (string-append "https://nodejs.org/dist/v" version + "/node-v" version ".tar.xz")) + (sha256 + (base32 + "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")) + (modules '((guix build utils))) + (snippet + `(begin + ;; Remove bundled software. + (for-each delete-file-recursively + '("deps/cares" + "deps/http_parser" + "deps/icu-small" + "deps/nghttp2" + "deps/openssl" + "deps/uv" + "deps/zlib")) + (substitute* "Makefile" + ;; Remove references to bundled software. + (("deps/http_parser/http_parser.gyp") "") + (("deps/uv/include/\\*.h") "") + (("deps/uv/uv.gyp") "") + (("deps/zlib/zlib.gyp") "")) + #t)))) + (inputs + (alist-replace "nghttp2" (list nghttp2-1.41 "lib") + (package-inputs node))))) + (define-public libnode (package (inherit node) =2D- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 15:43:59 2020 Received: (at 43228) by debbugs.gnu.org; 6 Sep 2020 19:43:59 +0000 Received: from localhost ([127.0.0.1]:47198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0Zy-00073d-QC for submit@debbugs.gnu.org; Sun, 06 Sep 2020 15:43:59 -0400 Received: from world.peace.net ([64.112.178.59]:35650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0Zq-00073I-0r for 43228@debbugs.gnu.org; Sun, 06 Sep 2020 15:43:57 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF0Zj-00037R-FY; Sun, 06 Sep 2020 15:43:43 -0400 From: Mark H Weaver To: Pierre Langlois Subject: Re: bug#43228: r-v8 doesn't build since node 10.22 update In-Reply-To: <87pn6z5f4j.fsf@gmx.com> References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> <87o8mjrf3u.fsf@netris.org> <87pn6z5f4j.fsf@gmx.com> Date: Sun, 06 Sep 2020 15:42:27 -0400 Message-ID: <878sdmr8sh.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43228 Cc: 43228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Pierre, Your new patch looks good to me, but the node-10.22 source field could be simplified to avoid repeating the unchanged field (especially the snippet), by inheriting from (package-source node) like this: --8<---------------cut here---------------start------------->8--- (source (origin (inherit (package-source node)) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.xz")) (sha256 (base32 "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")))) --8<---------------cut here---------------end--------------->8--- Also, it would be great to find a way to fit in the subject line that 10.22 is also being kept as a separate binding, especially since "guix build node" and most other user commands will still build 10.22. Maybe something like this: gnu: node: Downgrade to 10.20.0; add separate 'node-10.22' binding. What do you think? Anyway, feel free to push this, preferably after incorporating these suggestions. If I'm not mistaken, the simplification suggested above should not change the .drv file, and therefore not entail a rebuild, so testing it should be very quick. Thanks! Mark From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 18:23:39 2020 Received: (at 43228-done) by debbugs.gnu.org; 6 Sep 2020 22:23:39 +0000 Received: from localhost ([127.0.0.1]:47355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF34V-0004Xc-GA for submit@debbugs.gnu.org; Sun, 06 Sep 2020 18:23:39 -0400 Received: from mout.gmx.net ([212.227.17.22]:34557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF34T-0004XP-N1 for 43228-done@debbugs.gnu.org; Sun, 06 Sep 2020 18:23:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599431011; bh=KZIQRa7wQL1kCNeVAyS7WbTDL9InJCz/BgqJM9Lk5gk=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=IG291RdQqnvPBrMQ64eygGuxRgGC7oNbWNjwzg3Uv8xbwT3RwHkw2v6y6WdH+xv/U ASvh8p/BTHHfhNqJo+brQTDuygPeQTa4Bhljd6E9fdW+Z9nDWmfl/RPLM9Bfhfd0xZ YEzEOANX2zQ0quT95dBAeQh9Jgr4dXdQA6FdzbsA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MCKBm-1kOMj30OeI-009Na1; Mon, 07 Sep 2020 00:23:31 +0200 References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> <87blikhvj2.fsf@gmx.com> <87o8mjrf3u.fsf@netris.org> <87pn6z5f4j.fsf@gmx.com> <878sdmr8sh.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois To: Mark H Weaver Subject: Re: bug#43228: r-v8 doesn't build since node 10.22 update In-reply-to: <878sdmr8sh.fsf@netris.org> Date: Sun, 06 Sep 2020 23:23:35 +0100 Message-ID: <87tuwalf2w.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:AUoEz6wCOv+VfToFr9Nvq+tj1iEOqjoQPAUcQ/yr2Zc/IZuceLk UmCh0tYXp7jGzTgmmZkLUmKY4XcZTjkgZkEPnIG/GCrQMpvioe5XnguaFZJrcFjBQP4KmIn ge7YnH4cMET+tbYu9BoJtz4qiv2g7MxcUIFIacFmY9pEQaM5Y5l/wO81dXnA/qHHCjylZ7f g3H1dYXW19dQht09HgvwQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:NnbrJkh5weE=:0UiBshS7mMoOvghT+6yZdz EBIdLpzrH8tNpg66NGrJ3fN6ccyYrOPQ2ttcBUSKjJgspmzhEeq3SsteoRLFAT2GgxERGDO88 J4CG6y5mEx5b5GwClTvW8+XMmrPeO3/w4sIZ6rd9ICnm+uA1n9IPuy4TutKJgVic01KVPwetY fZA0mfv3hbmcnJjvyKpykDF9bfOwwyx0Vb1y5Mb5lAx4CdzIyh4pakaVMuJdWc5Ba3aYFHsY8 7Xl+ZPtrhDXAtGHZuVSefp9YN5Ib4YWzNymwp4QqeW3dMsUf/M70SWeD4RM5Jb2KbKkwayAQD VCVSq2Pd+QIh1vYxDLs3gr6FDpWWfLbo5OUXYmEIMmkvmlzb8uWTjJddPXFKfEKSGwxRVHsqj egI0TnNRn91obBMxLTDcDWby+h+H5H7x0pW4oMNu5bRljF3n3l1AU4FbDvROznw68MYInztye yOcoMHNQ+B0aqoXyQa4HEP7aLyYkgJJbmDaKilmRC1kJ8BIqo9lvgzcV47KVqe45Ek5RSrKpK q+DJoVTyclVFT1f4dBKCTk4Ypglj85BTEe8XiGTsgSflMWE1Ah8X1MEJ05Q5JLUdQlT0E2Uhq chTP/1oZy6x2dkvmDaVtnmFE+LhSNUnjzWjyqGcZB5bfolj5Wmf7ZOYHL4mMsLOXSLf0/pswK LTarLdj0aNge4Oc5DPTZy5ADsOIfVdfkTOjfJOf4ZbDzPqOmUOm8iI1zLvJIAJcycsrA/1Qy0 EN7m2yHZkJc+f5CjMxV/UwFbaw6jZH/5Lxjf/f6vibVZ4dgSKEog3vENytwlpDS/16uRWWwPz jALIyg/n5BWkI5h74hAzBMzXKxRvFOFaaqHekLL1GI6GZgIWpXNcVvj8ft/ryzeR5dLkwKY5n 76f+EYgrQQMZmjrU9hzsVoRKjRcPZZ/QpXnyZnP/WJW23I6AJ4cJCI5dSqRB65QcKRFjkjhda f6WRs5MsSW2ij12sDWS4UmU+sIAi8YcNhSfqSXiCFkRmegDLsnXczc/sWtyZ9nOIRmplwWOf3 FU94rE8JxMGGypW4DNUJVfW2yqRruHNFZHMPlaF0cjkxHYpD/VMOGnZVm9opB2E5dZMD8mpCE oheu6k/dTaF2FDENM+LTtctxpCN6lbziIFPqrS4biftrUbjdbg64Cy6lij1nOZrnubj+ODYcv OoHs+xpH9wsjrXxqnXfBdf2s2iVIXjcVpMkockMCm3Qn9XdF/8caHrvdKpDFX3Hea6IVc9G5N NAUcdfhfrckVuM6XGNMiqyUHAV4eq03LA38+t7w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43228-done Cc: Pierre Langlois , 43228-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hi Mark, Mark H Weaver writes: > Hi Pierre, > > Your new patch looks good to me, but the node-10.22 source field could > be simplified to avoid repeating the unchanged field (especially the > snippet), by inheriting from (package-source node) like this: > > --8<---------------cut here---------------start------------->8--- > (source (origin > (inherit (package-source node)) > (uri (string-append "https://nodejs.org/dist/v" version > "/node-v" version ".tar.xz")) > (sha256 > (base32 > "1nz18fa550li10r0kzsm28c2rvvq61nq8bqdygip0rmvbi2paxg0")))) > --8<---------------cut here---------------end--------------->8--- Oh yeah, that's much better. > > Also, it would be great to find a way to fit in the subject line that > 10.22 is also being kept as a separate binding, especially since "guix > build node" and most other user commands will still build 10.22. Maybe > something like this: > > gnu: node: Downgrade to 10.20.0; add separate 'node-10.22' binding. > > What do you think? Actually, even better, I can split this into two separate commits. > > Anyway, feel free to push this, preferably after incorporating these > suggestions. If I'm not mistaken, the simplification suggested above > should not change the .drv file, and therefore not entail a rebuild, so > testing it should be very quick. Pushed as 6b7cba0fa897e97b43e76612e3736429426f4d9d and 92db0d39e2aa64be390e86172bd670d98e121c4b, thanks for the review! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9VYWgYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UIA0H/RBdW+hGtQOhwS8jipG9nCyV b8TPnQWapBCq22lYG0PI51VzlflFWgyJznFLpu2aXK4If2H4BSiywYwTjQJanLiB LAfe2FpvdpqcHgT1Hs/DNPl0gi1zMfEw9Bal1MjULYoVIerUxP0iwCiVr/3wHVgk nkQ6KgQzLy87FhvROm8j3gc8UYgWblAzMHnesXVz4hMvS0MAQdKcMjad+MC8/6mD LoAi3O7CPNuYLk1xT/h0M8AuGM/zaCUd8eQ6wOtdtnImzRPNWjPy36Km+okY/19C hXAyvIgHWcuP2Z2vuGwTjA21C/PtU8UzLxF1ihK3DkEnC0ZXIAHbYyR0DMlQQBU= =HYSC -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 10:26:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Oct 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator