GNU bug report logs - #43222
28.0.50; fido-mode selects wrong buffer to kill when no input

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sean Whitton <spwhitton <at> spwhitton.name>
Subject: bug#43222: closed (Re: bug#43222: 28.0.50; fido-mode selects
 wrong buffer to kill when no input)
Date: Sun, 06 Sep 2020 07:40:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#43222: 28.0.50; fido-mode selects wrong buffer to kill when no input

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 43222 <at> debbugs.gnu.org.

-- 
43222: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43222
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: João Távora <joaotavora <at> gmail.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 43222-done <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#43222: 28.0.50; fido-mode selects wrong buffer to kill when
 no input
Date: Sun, 06 Sep 2020 08:39:20 +0100

João Távora <joaotavora <at> gmail.com> writes:

> Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>> This is orthogonal to #43120 so far as I can tell.
>>
>> 1. emacs -q
>> 2. M-x fido-mode RET
>> 3. C-x C-f ~/src/emacs/lisp/icomplete.el RET
>> 4. M-: (find-file (locate-library "icomplete.el.gz")) RET
>> 5. C-x b icomplete.el RET
>> 6. C-x k [wait for completions] RET|M-j
>
> Followed your report and confirmed it.  Notice that the problem only
> happens because the file names share a common prefix: "icomplete.el"
>
> Maybe the title (and the severity) of this bug should be changed to
> reflect that.  Do you know how to do that, Lars?
>
>> The first completion offered by fido-mode is different from the
>> default value shown in the minibuffer prompt.
>
> This sentence indeed describes it.  There code is fido-mode to "bubble"
> up the default to the first result, but it isn't working for some
> reason.  I'd say the problem lies somewhere in
> icomplete--sorted-completions.

I've fixed this in 6fc502c1ef327ab357c971b9bffbbd7cb6a436f1.

Author: João Távora <joaotavora <at> gmail.com>
Date:   Sun Sep 6 08:35:53 2020 +0100

  Don't resort Icomplete candidates when default already on top
  
  Fixes: bug#43222
  
  Icomplete mode re-sorts candidates, bubbling the default to top if
  it's found somewhere down the list.  This is done according to two
  criteria: exact match and prefix match.  Before this fix, it didn't
  take into account the possibility that the exact match for the default
  would already be on top, and would incorrectly bubble a prefixing
  completion down the list to the top.  This commit fixes that.
  
  * lisp/icomplete.el (icomplete--sorted-completions):
  Rework. Recomment.

[Message part 3 (message/rfc822, inline)]

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; fido-mode selects wrong buffer to kill when no input
Date: Sat, 05 Sep 2020 08:39:36 -0700

This is orthogonal to #43120 so far as I can tell.

1. emacs -q
2. M-x fido-mode RET
3. C-x C-f ~/src/emacs/lisp/icomplete.el RET
4. M-: (find-file (locate-library "icomplete.el.gz")) RET
5. C-x b icomplete.el RET
6. C-x k [wait for completions] RET|M-j

This should kill the buffer visiting icomplete.el (right?) but in fact
it kills the buffer visiting icomplete.el.gz.  The first completion
offered by fido-mode is different from the default value shown in the
minibuffer prompt.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.