GNU bug report logs - #43210
[PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout

Previous Next

To reply to this bug, email your comments to 43210 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout 
Date: Sat, 05 Sep 2020 10:24:14 +0430

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 21587609ce..baa2ee6795 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -379,6 +379,7 @@ the operating system LXQt is running on.")
        ("qtbase" ,qtbase)
        ("qtsvg" ,qtsvg)
        ("qtx11extras" ,qtx11extras)
+       ("setxkbmap" ,setxkbmap)
        ("solid" ,solid)
        ("xf86-input-libinput" ,xf86-input-libinput)
        ("xkeyboard-config" ,xkeyboard-config)
@@ -418,7 +419,16 @@ the operating system LXQt is running on.")
                (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
                 (string-append (assoc-ref outputs "out")
                                "/share/lxqt/translations")))
-             #t)))))
+             #t))
+          (add-after 'install 'wrap-for-setxkbmap-path
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((out              (assoc-ref outputs "out"))
+                    (setxkbmap          (assoc-ref %build-inputs "setxkbmap")))
+                       (wrap-program (string-append out "/bin/lxqt-config")
+                            `("PATH" ":" prefix (,(string-append setxkbmap "/bin/"))))
+                       (wrap-program (string-append out "/bin/lxqt-config-input")
+                           `("PATH" ":" prefix (,(string-append setxkbmap "/bin/"))))
+               #t))))))
     (home-page "https://lxqt.github.io")
     (synopsis "Tools to configure LXQt and the underlying operating system")
     (description "lxqt-config is providing several tools involved in the

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout 
Date: Sat, 12 Sep 2020 16:31:33 +0430

Hi guys.
Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The previous commit will fix the adding `keyboard-layout` but without having the `setxkbmap` in `propagated-inputs` the added layouts won't add as permanent and will be reset after each reboot. So again, we need to add `setxkbmap` as a dependency in `propagated-inputs`.


On Sat, Sep 5, 2020, at 10:24 AM, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 21587609ce..baa2ee6795 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -379,6 +379,7 @@ the operating system LXQt is running on.")
>         ("qtbase" ,qtbase)
>         ("qtsvg" ,qtsvg)
>         ("qtx11extras" ,qtx11extras)
> +       ("setxkbmap" ,setxkbmap)
>         ("solid" ,solid)
>         ("xf86-input-libinput" ,xf86-input-libinput)
>         ("xkeyboard-config" ,xkeyboard-config)
> @@ -418,7 +419,16 @@ the operating system LXQt is running on.")
>                 (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
>                  (string-append (assoc-ref outputs "out")
>                                 "/share/lxqt/translations")))
> -             #t)))))
> +             #t))
> +          (add-after 'install 'wrap-for-setxkbmap-path
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((out              (assoc-ref outputs "out"))
> +                    (setxkbmap          (assoc-ref %build-inputs 
> "setxkbmap")))
> +                       (wrap-program (string-append out 
> "/bin/lxqt-config")
> +                            `("PATH" ":" prefix (,(string-append 
> setxkbmap "/bin/"))))
> +                       (wrap-program (string-append out 
> "/bin/lxqt-config-input")
> +                           `("PATH" ":" prefix (,(string-append 
> setxkbmap "/bin/"))))
> +               #t))))))
>      (home-page "https://lxqt.github.io")
>      (synopsis "Tools to configure LXQt and the underlying operating 
> system")
>      (description "lxqt-config is providing several tools involved in 
> the

Message #11 received at 43210 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
Cc: 43210 <at> debbugs.gnu.org
Subject: Re: [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config
 and lxqt-config-input and setting the setxkbmap PATH for fixing save added
 layout
Date: Thu, 24 Sep 2020 17:22:56 +0200

Hi,

"Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org> skribis:

> Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The previous commit will fix the adding `keyboard-layout` but without having the `setxkbmap` in `propagated-inputs` the added layouts won't add as permanent and will be reset after each reboot. So again, we need to add `setxkbmap` as a dependency in `propagated-inputs`.

Why is that?  I fail to see why using ‘propagated-inputs’ instead of
wrapping would work better.

>> +          (add-after 'install 'wrap-for-setxkbmap-path
>> +            (lambda* (#:key outputs #:allow-other-keys)
>> +              (let ((out              (assoc-ref outputs "out"))
>> +                    (setxkbmap          (assoc-ref %build-inputs 
>> "setxkbmap")))
>> +                       (wrap-program (string-append out 
>> "/bin/lxqt-config")
>> +                            `("PATH" ":" prefix (,(string-append 
>> setxkbmap "/bin/"))))
>> +                       (wrap-program (string-append out 
>> "/bin/lxqt-config-input")
>> +                           `("PATH" ":" prefix (,(string-append 
>> setxkbmap "/bin/"))))
>> +               #t))))))

For this case, it might be easier/preferable to replace ‘setxkbmap’ in
the source code with the absolute file name of ‘setxkbmap’.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.