Subject: Re: [bug#43208] [PATCH] gnu: emacs-ess: Update to 20200903.1516.

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 05 Sep 2020 15:35:04 +0200

Hello,

Tim Howes via Guix-patches via <[email-masked]> writes:

> * gnu/packages/statistics.scm (emacs-ess): Update to 20200903.1516.
> [version]: Use latest commit, assign version based on commit date.
> [source]: Fix snippet for removing julia-mode.  Remove snippet to modify
> roxy-preview-Rd-test.  Add snippet to modify r-help-mode test.  Add
> snippet to fix install target to install files to correct directories.
> [arguments]: Add flag to specify INFODIR.  Remove patch modifying
> SHELL.

Thank you.

> This updates emacs-ess to the current version on github and resolves
> bugs #43093 and #42259.
>
>  gnu/packages/statistics.scm | 43 ++++++++++++++++---------------------
>  1 file changed, 19 insertions(+), 24 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index c1cefa8c41..aa14e2887f 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -5805,29 +5805,24 @@ Java package that provides routines for various statistical distributions.")
>  (define-public emacs-ess
>    (package
>      (name "emacs-ess")
> -    (version "18.10.2")
> +    ;; Use version number based on commit date and time (UTC), similar to melpa.
> +    (version "20200903.1516")

I don't think this numbering is great because it makes it difficult to
switch to the official one once it is increased. Usually, we add
a revision number to the version, see, e.g., emacs-ansi.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou