From unknown Tue Jun 24 05:14:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Michael Rohleder Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Sep 2020 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43204@debbugs.gnu.org Cc: Michael Rohleder X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159923392128668 (code B ref -1); Fri, 04 Sep 2020 15:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Sep 2020 15:38:41 +0000 Received: from localhost ([127.0.0.1]:40393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEDnV-0007SJ-5Q for submit@debbugs.gnu.org; Fri, 04 Sep 2020 11:38:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:36728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEDnT-0007SC-Im for submit@debbugs.gnu.org; Fri, 04 Sep 2020 11:38:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEDnT-0003WL-By for guix-patches@gnu.org; Fri, 04 Sep 2020 11:38:39 -0400 Received: from wp224.webpack.hosteurope.de ([2a01:488:42:1000:50ed:84e7::]:40884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEDnR-0006AD-At for guix-patches@gnu.org; Fri, 04 Sep 2020 11:38:39 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kEDnN-0000UJ-Vl; Fri, 04 Sep 2020 17:38:33 +0200 Received: from [192.168.1.3] (helo=micha.rohleder.de) by www.rohleder.de with esmtp (Exim 4.94) (envelope-from ) id 1kEDnL-0007S8-9o; Fri, 04 Sep 2020 17:38:33 +0200 From: Michael Rohleder Date: Fri, 4 Sep 2020 17:38:24 +0200 Message-Id: <20200904153824.27164-1-mike@rohleder.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1599233917;804496e0; X-HE-SMSGID: 1kEDnN-0000UJ-Vl Received-SPF: permerror client-ip=2a01:488:42:1000:50ed:84e7::; envelope-from=mike@rohleder.de; helo=wp224.webpack.hosteurope.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 11:38:34 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. --- It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz according to the installed pkg-config. I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, (I guess, all revdeps of taglib that don't have zlib as an input have that problem) gnu/packages/mp3.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 7ee009df74..8ea282be97 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -175,7 +175,7 @@ a highly stable and efficient implementation.") (arguments '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on. #:configure-flags (list "-DBUILD_SHARED_LIBS=ON"))) - (inputs `(("zlib" ,zlib))) + (propagated-inputs `(("zlib" ,zlib))) (home-page "https://taglib.org") (synopsis "Library to access audio file meta-data") (description -- 2.28.0 From unknown Tue Jun 24 05:14:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Sep 2020 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Michael Rohleder Cc: 43204@debbugs.gnu.org X-Debbugs-Original-Cc: 43204@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 43204-submit@debbugs.gnu.org id=B43204.159923597931927 (code B ref 43204); Fri, 04 Sep 2020 16:13:02 +0000 Received: (at 43204) by debbugs.gnu.org; 4 Sep 2020 16:12:59 +0000 Received: from localhost ([127.0.0.1]:40472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEEKh-0008It-9b for submit@debbugs.gnu.org; Fri, 04 Sep 2020 12:12:59 -0400 Received: from mout.gmx.net ([212.227.17.20]:44487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEEKg-0008Id-1D for 43204@debbugs.gnu.org; Fri, 04 Sep 2020 12:12:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599235971; bh=8AceZfEABYMaC2gi7v2UR9XMdUOrrRv67YyUkinyC0U=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=Cj0Pt2tsTkGLLsGzWkXG+/8lYiEl+xjqEJgwBnduleUPsVQoowapbHONZ3G2Ce9hC xITtYqDRzMGb3XRQEMBCEz1ktZw4yPQ0ITcTfu1hbpXH+gXHF981cu8wz8sBKSr1zB BSa3mh2ru+MZ/ajJFMR6ARBDTP/MNNU+jBfrV3Ts= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e119807-lin ([82.69.64.142]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M7K3Y-1kD9TT1W6m-007lQq; Fri, 04 Sep 2020 18:12:51 +0200 References: <20200904153824.27164-1-mike@rohleder.de> User-agent: mu4e 1.4.13; emacs 26.3 From: Pierre Langlois In-reply-to: <20200904153824.27164-1-mike@rohleder.de> Date: Fri, 04 Sep 2020 17:12:50 +0100 Message-ID: <87363xmsfx.fsf@gmx.com> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:pmjIAT9ihhRtE0pjeSE2pYlBjrIU4yCfWshlDKLxWef49ndEQTU wWfXRIZaiOV5O3L17hr5Gk3ToljMSu1OhCvZO+UwbCgbsDo0UpBS7MATf4OxGSrZ2040LVb WroEpb9kxnNzuQ2fDPdoYIeJbmJ87mBHhGUpnPBpaOP13EbQrOZcaFwRr1ZGLd7oKO1H1J1 C+5yAHTCbDOnabDg1FuYA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MFEtXr6MS9g=:xbF7hkMf6AQs5jYl09rZz8 LmsL3Ne77xCxWP2GiHmjp6Pron85uG7NHnMB93+4MrZyIuzU7x4fkIy1r1Qpvx2J3zBQQ7tkM qtdVvjNu1TXpBTaU1SUQWSoVBIR+VqM3VrSdQfUXEPYkZqa2snRuTZEoMJ4EX9jRGjeqbtf3I h+XG2FNFtKrGESirZMm4zNL6aL6Blwn5A/fQud5hjKhHo1bRf3h0jL1N8i+lCvWprmXI3WTIj 6CE5qEz6hYI84QUaLW0NhTjvDHFTyiAvIV+xKvzhr8JyRwSYBq1E1wxWRPuzyyXJ16gXWjz2n 3I2htdus1X7x6EZGQ+qNSq9/85LGpXqojh1gscxsGghXIPWq8kZjdfmHNlA+RcDliBQXl6eTh YGdaKYycmN+CmTu+ulkYxtpODVqTj0CwkC01PIQ63Mw0sHi9zHnbzxULSJqOCLf7V9f11WEkM bc7fzy1pJTnXfRuQvUugSZn5KjTkjHyfIhfFEsMFC9rZGTzXnpncJ+DQ41gDwcJSKuH310rCs XyAKEJ5IJ7h893W+9GR/bYv3Yq2Ve7sz4dWBls74hv0LbiwyoCUo92pYJ2RSggEwhQn0fjkmL e4srGkFDC28AFG9D+4+ht13/hL6+6RjGu6CeNxRFoXfNwpBXqqbGOAO1GeVAX64trUUo5Uq9E z2hvWRxsskcarYck9WCA5TkYN8dUlSrqnX5TArko60YS91281UlwXMpXWyQ6ZoSIQ6YFEWkmL AQhsQY4BFIArvHBCy+s0HQDWp7aYa6Duh7dan+M5bFNY7+5rm7/LCZ4FUB4bvaIWxxkw+EI3v qQmRWZ3jqJQJRi6ivOs30nvIPx0FTmzKuwCivguql0nmrk1ViIeWtUq4/PR4J3UcEnJzrKTmD rhivCSIH7jZdaKzp0HghUNyulpokZ4X1UgdYDt+I6isIzWLD5dABFlJUM5nkF4GDgIzcie7ek /ed1dixaVrZkk7LBOgLmZWPFzUEv4OGOzzafoGkXdZk0KAgC6S8FWIKfrPPuXHFycC8jVRMQ4 +KknMjbhrMIRg993zceTG8nKYNlW7mh729hG9s6MpvcTl/v9qKARPAT6+ELktw5+6MuVC2tei +Txu8qVvytmcNYNqX1P5k3WfeWYUq1zwdm/gCgi7nsQy+DeAt7Evw7UwsTAPlhXkCTRcHwezH 9pksTmzm1WyycSvD/GddVFkL6PQSA1/j1B5htYjgDIImsnk3zNRkdkv2gm8vMs/Gr9QJCMfwO wOLnV02mmCP2fohoOjskFOTpusPUznhULvet44w== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Michael, Michael Rohleder writes: > * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. > --- > It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz > according to the installed pkg-config. > > I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, > (I guess, all revdeps of taglib that don't have zlib as an input have that problem) Oh, indeed emacs-emms doesn't build, sorry for the breakage! :-/ I see the pkg-config file was changed here https://github.com/taglib/taglib/commit/ef1312d62239f399c40233d76ef3328b8dadf984 Propagating zlib seems like the right thing to do (although I'm not a maintainer), thanks for the patch! Pierre From unknown Tue Jun 24 05:14:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Sep 2020 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 43204@debbugs.gnu.org, mike@rohleder.de X-Debbugs-Original-Cc: 43204@debbugs.gnu.org, Michael Rohleder , guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159930503813822 (code B ref -1); Sat, 05 Sep 2020 11:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Sep 2020 11:23:58 +0000 Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEWIY-0003as-4b for submit@debbugs.gnu.org; Sat, 05 Sep 2020 07:23:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:49078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEWIW-0003al-GF for submit@debbugs.gnu.org; Sat, 05 Sep 2020 07:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEWIW-0002ge-Ah for guix-patches@gnu.org; Sat, 05 Sep 2020 07:23:56 -0400 Received: from mout.gmx.net ([212.227.17.22]:46407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEWIU-0000CQ-8e for guix-patches@gnu.org; Sat, 05 Sep 2020 07:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599305022; bh=2Lui4zQULpPScBT7ZrfX+lvnQK0lzDNzH3RwRSmvLM0=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=Z0hV9g4G9GMafCnw6XfRfbJnfuLiwTgHuS0hMinkROA1K/RFdJ3bqh5DgqWIvIqo4 rCowkJ78O0bCEHeIznFukw7HJtSpceqfJ5/wVhnr4LdDW19DtKBQ+5G7doiDGmTjTW fjRktXe94O61i2UxZ4GOv48nq7uuuHAsPDpFHS3s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mf0BG-1kl6DU2fne-00gYJI; Sat, 05 Sep 2020 13:23:42 +0200 References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <87363xmsfx.fsf@gmx.com> Date: Sat, 05 Sep 2020 12:23:43 +0100 Message-ID: <87wo18piv4.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:qcVvjt3qzXHy7DFbqk+/Z+JmSk/U8AwAnlMNeTsYQdsEIrFnDib zTsZGwHeYSlKqxNTC/xbvx9dDGb+8iv2csTuGxuUcE2uItpDVwLHQjecOMcb8gGyktYyooT GKOV7x4SlTMt2CHy1UhwRy0z1rerhf7mdwXFQtnD1mdIxVwz6jn8Jc/Y127S2MN1hKgQVnB FDpmWLqjq5bVMchpkIigA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yGs4UE66+1g=:zj3p/RZ5oW3vlhAmBIO8zU 84+sA0Jo0d2I8SpKOhoPA6oJz5mxACP+GR7yv4616SnYYv9b9xdSVmu3eqW8/w7qTzDxB+P6p tP2pb2Ekd1t/FIviMTL4PQZ+sgoUDIfwrC1gSz3ZG/mQ9ucQsyu3slXxaNaC6DZjk32nNJ7YO oFF5jmU4OKiSEZSo/t1WTgbGFEfhBCbKfKCFtfpvLnE/LtjUMGnYXFfQ4qZPfKAd3kD10hbu9 oYgJ+J8yYAmn05hWlbTDYgOUhPImfoY7rUMwtx3r8p2d68/WGFneAATErmT9F/Jw5vmM1mqFG bZLxFywh9nG46ttZYB7zjG+QxpsqiWvH2OjdV7aodGiFwaomvVN3eljl5hABn2J1Ixn6UHCwu QpGhkzcFGMeCfU6OwT4DPq9zaVFzxJsW6GoRUDGgySBklM2zb2CTczpSELf0gvH5i40xSL0zJ wL6FsU1QmH3vwMot60P1BBD+fqrB9DHBqekO4s8bhgeTgn17ReVyRwBG2cBBX/ydozKDy6UkK SrG93Gf5lEsZXZK8imFJprgcdAauc9YfTch26ntvQBMKapd/9pYpWfIlihZh+aBmv/ZCEHOSv HzKHeKfNr6v/9hINt1sJ0+O/MEL7Vl6oLcOhrJvOqT0gJLmT9LcW7BVteyjHEcUNa2STLHOkI Rh3ESmH8SB2lUkSBSI8ll6sdChADuQfcVvu8HSWMAxmWzZzi2sx/uPiKwVHsdX9UkVBdhlY6H cXD3X40YQFda+SUv31CnCQgRADCXqeoqd7jicj1acO6W1UIbIOZhX//l/RMp3sIgqqzy0D/SI q5Yu7UDfGjj6Q4K9dkfreRtlyt+55OGqpJK52n6SwiXcs63oTnwzAiDUEmrMGa3CZ26MiLdYF FINIeO6yjxXMVZG+rpYp54Gld5CFePPEYkB/G5aHCOGfifnI2nnD+cxhv/2fKXK1ZqLO96z+9 5lW2asX6LdGu9ETsogz8049SKm1+6JpfArhjdp7+1ULyzksdACs1eQyJdt16Fir0/TJ0a+rIm 4BNJe8fdfHAoeHKlCbDcbpttqoqa30mteaG02v0EOSRaqVbREGyqc4yE9R59Oo4nfeDgolRJl cljFZSObSfCOjY6BFUJRylzI2aEnma4FpBmu1Skz+Dc2FCiwc2qHrshutQMbShdzUPrCfwL4j ZW4zzho0UPooc3hBpfRj2uU3vb6qUVxJiGyPosFtLBF7GL75lrGWav4k33eYvgY94/ylYrq7J kIFK5ikfJVoAixISQVeyN+Z/HR36Ua+pIsjpFzw== Received-SPF: pass client-ip=212.227.17.22; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/05 07:23:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Pierre Langlois writes: > Hi Michael, > > Michael Rohleder writes: > >> * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. >> --- >> It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz >> according to the installed pkg-config. >> >> I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, >> (I guess, all revdeps of taglib that don't have zlib as an input have that problem) > > Oh, indeed emacs-emms doesn't build, sorry for the breakage! :-/ I see > the pkg-config file was changed here https://github.com/taglib/taglib/commit/ef1312d62239f399c40233d76ef3328b8dadf984 > > Propagating zlib seems like the right thing to do (although I'm not a > maintainer), thanks for the patch! Actually, thinking about this a little more, I'm not sure I understand upstream decision to propagate -lz. The commit fixes [0] which indicates it's so that taglib can be linked statically, but then that means if we're dynamically linking, the application will also dynamically link with zlib when it doesn't need to (at least not directly). And in guix we only build shared libs for taglib so we're never statically linking it AFAIK. So, here I'm a bit torn here, should we just follow what upstream is indicating? Even it doesn't look right to me, but I might be wrong! Or, should we revert the change that propagates -lz? Thanks, Pierre [0]: https://github.com/taglib/taglib/issues/872 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9TdT8YHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UKoIH/1Symc4WsyqqhGTafMjEbql8 ai5420ZcSv7DRWd9IHrffN+WeF44Nt+eVakMQaqqJHtTmAgER6UzjRK0zGxRv3Rp Dr9py+zdhIwLOkjB2IhmOhztdjmOahj0a3xyPkdnaTdEEpqGNqe9rDruwwqekC15 IWCjWcZQ9w/5djV7MbHLXPDOnulJVVR9AG2Pk9O06Q8qSIk/p/nAdfvz1iDY08uX Hg0oALdbRoxBrOdUdOywGSa545nNqGbLL/N7Ipc98jLfCS0dru93OY90ocBxP9no bP65AvWiJiM8vFM6qIjTSMFc4ZBhF/AoBtHKGjrJvnzTjMS15C+adaowKuY4dM4= =4MeF -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 24 05:14:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: mike@rohleder.de, 43204@debbugs.gnu.org Received: via spool by 43204-submit@debbugs.gnu.org id=B43204.159948096625226 (code B ref 43204); Mon, 07 Sep 2020 12:17:02 +0000 Received: (at 43204) by debbugs.gnu.org; 7 Sep 2020 12:16:06 +0000 Received: from localhost ([127.0.0.1]:48315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFG3z-0006YD-Pb for submit@debbugs.gnu.org; Mon, 07 Sep 2020 08:16:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFG3u-0006Xt-Hn for 43204@debbugs.gnu.org; Mon, 07 Sep 2020 08:15:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41512) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFG3o-0008Fb-3M; Mon, 07 Sep 2020 08:15:48 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=43964 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFG3n-0000nc-Lg; Mon, 07 Sep 2020 08:15:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> Date: Mon, 07 Sep 2020 14:15:41 +0200 In-Reply-To: <87wo18piv4.fsf@gmx.com> (Pierre Langlois's message of "Sat, 05 Sep 2020 12:23:43 +0100") Message-ID: <875z8pkck2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Pierre Langlois skribis: > Actually, thinking about this a little more, I'm not sure I understand > upstream decision to propagate -lz. The commit fixes [0] which indicates > it's so that taglib can be linked statically, but then that means if > we're dynamically linking, the application will also dynamically link > with zlib when it doesn't need to (at least not directly). And in guix > we only build shared libs for taglib so we're never statically linking > it AFAIK. > > So, here I'm a bit torn here, should we just follow what upstream is > indicating? Even it doesn't look right to me, but I might be wrong! Or, > should we revert the change that propagates -lz? I had the following patch that I intended to push, to avoid propagation. WDYT? Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable commit d8124a707602980556fd33c7dbf9f7483fe1d0df Author: Ludovic Court=C3=A8s Date: Mon Sep 7 09:56:08 2020 +0200 gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. =20=20=20=20 Fixes compilation of emacs-emms-print-metadata. =20=20=20=20 * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 7ee009df74..a7574f0cf9 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2013 Andreas Enge -;;; Copyright =C2=A9 2014, 2015, 2017 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2014, 2015, 2017, 2020 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2015 Mark H Weaver ;;; Copyright =C2=A9 2016 Efraim Flashner ;;; Copyright =C2=A9 2017 Thomas Danckaert @@ -174,7 +174,18 @@ a highly stable and efficient implementation.") (build-system cmake-build-system) (arguments '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on. - #:configure-flags (list "-DBUILD_SHARED_LIBS=3DON"))) + #:configure-flags (list "-DBUILD_SHARED_LIBS=3DON") + #:phases (modify-phases %standard-phases + (add-before 'configure 'adjust-zlib-ldflags + (lambda* (#:key inputs #:allow-other-keys) + ;; Make sure users of 'taglib-config --libs' get th= e -L + ;; flag for zlib. + (substitute* "CMakeLists.txt" + (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)") + (string-append "set(ZLIB_LIBRARIES_FLAGS -L" + (assoc-ref inputs "zlib") + " -lz)"))) + #t))))) (inputs `(("zlib" ,zlib))) (home-page "https://taglib.org") (synopsis "Library to access audio file meta-data") --=-=-=-- From unknown Tue Jun 24 05:14:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Michael Rohleder Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 13:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Pierre Langlois , 43204@debbugs.gnu.org Received: via spool by 43204-submit@debbugs.gnu.org id=B43204.159948524131962 (code B ref 43204); Mon, 07 Sep 2020 13:28:01 +0000 Received: (at 43204) by debbugs.gnu.org; 7 Sep 2020 13:27:21 +0000 Received: from localhost ([127.0.0.1]:48413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHB3-0008JR-0t for submit@debbugs.gnu.org; Mon, 07 Sep 2020 09:27:21 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:58952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHB1-0008JI-MU for 43204@debbugs.gnu.org; Mon, 07 Sep 2020 09:27:20 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kFHAz-0002rY-BB; Mon, 07 Sep 2020 15:27:17 +0200 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kFHAw-0000rn-ML; Mon, 07 Sep 2020 15:27:16 +0200 From: Michael Rohleder References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> <875z8pkck2.fsf@gnu.org> X-PGP-Fingerprint: 755E 2DE5 D0D5 85C5 2E78 2830 7C7A FFBE FEF2 CB25 X-PGP-Key: https://www.rohleder.de/~mike/pgpkey.asc Date: Mon, 07 Sep 2020 15:26:49 +0200 In-Reply-To: <875z8pkck2.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 07 Sep 2020 14:15:41 +0200") Message-ID: <87sgbtsoo6.fsf@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1599485239;9fa60336; X-HE-SMSGID: 1kFHAz-0002rY-BB X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey Ludo, Ludovic Court=C3=A8s writes: > I had the following patch that I intended to push, to avoid propagation. > > WDYT? > > commit d8124a707602980556fd33c7dbf9f7483fe1d0df > Author: Ludovic Court=C3=A8s > Date: Mon Sep 7 09:56:08 2020 +0200 > > gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. >=20=20=20=20=20 > Fixes compilation of emacs-emms-print-metadata. >=20=20=20=20=20 > * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. > Nice! I think we (or upstream) should do something like this anyway. =2D-=20 "If you want to travel around the world and be invited to speak at a lot of different places, just write a Unix operating system." Linus Torvalds --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl9WNRkRHG1pa2VAcm9o bGVkZXIuZGUACgkQfHr/vv7yyyWKlAgAic0tvH7pQVOOABlE1NDYUv7OjCdsvF0b shXaoTe241XBi3P/P0xKbxHC5Z6XTey9JzXVOYMsCa4nLpPzBko3nzaFKuT5QYL5 BpY+7hWRSXKPOKB/OsNmLMRek/ahlgX1hiFYp6IFt1eWeabaRzsUgUuONlD90WDb Z0811XVGgx/hUzgT5PahY72lWoVrOQhis9Zxy78nZdL1Vn7bPJ4wxbEGklNjs6gk wSED2cbnHUmJXhC+gdkiRwqJTr5owbHdFkmEzaMr2NDEXl2IuLsr7loJXTxwc5Lu hN78sq/cSSElZU0ES5YPDgqMb+CL9aK/odISbksWC6VTbEhEP0Yu9g== =jeW4 -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 24 05:14:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: mike@rohleder.de, Pierre Langlois , 43204@debbugs.gnu.org Received: via spool by 43204-submit@debbugs.gnu.org id=B43204.1599485803409 (code B ref 43204); Mon, 07 Sep 2020 13:37:01 +0000 Received: (at 43204) by debbugs.gnu.org; 7 Sep 2020 13:36:43 +0000 Received: from localhost ([127.0.0.1]:48426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHK7-00006W-HM for submit@debbugs.gnu.org; Mon, 07 Sep 2020 09:36:43 -0400 Received: from mout.gmx.net ([212.227.15.19]:41971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHK5-00006H-4h for 43204@debbugs.gnu.org; Mon, 07 Sep 2020 09:36:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599485792; bh=U+G1HKpkuSz4fwWwrAIqeepUp0XqlbLIoCmhw/n+bYk=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=OVwx1BQPdVwYEeEK53lRlgr/NtkdeaH7jLwL5m+MTzIqsx0qc2Yl47D6HcOt4MhS9 f2y3bIA962Srlhe2uEGHKFqyXQyganP8JI5V8VXX2SlTqmHz/Pc/M4vRFo1fsn0Bx0 +S2Dc2HGibFBZZuT/vpfYuCyBc62g/SDHW8Tcx0E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e120243-lin ([82.69.64.142]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M1psI-1kHUFM0Wlc-002JjM; Mon, 07 Sep 2020 15:36:32 +0200 References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> <875z8pkck2.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <875z8pkck2.fsf@gnu.org> Message-ID: <87eendpuvl.fsf@gmx.com> Date: Mon, 07 Sep 2020 14:41:02 +0100 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:VYXxf2mvZwqLavYn3pOOr9JolGMfFjOaZEsJrqyJABv0beoQ3wQ 3Ru5vEK9Irv5eLehJ+B15tAs1Ixicl65lscjG8AF6PcQclHyfLnpKWcbObn4z4pEn7b7e6J 57OQDyN+MTkgFa/FZRJ02lpGSt0NKeA4ZIxc7MHD2phKS6TkduZ3alo5V+YEa8x5+Cp71Jx wuGRUAhlDNtUSs23Vj9/A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7OxV2BOzaCI=:w8ufSdpoUUP2jc4gpO5hsA TsahadOnYm3jzKLPGtBixeXgKyCvBBpWGSzL6CtgvYz1wp6ly4pFrdlfA3HNhoAvtsdvtonWe GXW+T/0Ed6JEQ7kWl0qhRUgtUPwFBcG2MML520QoP/n9swysB3zH/L/Ybn9DDYJqJWraDRSo9 nWo3lDWrxKZ/k9Tgi+4331XCpvdQxHkb1OPrNwrjcZ0qTVFct2m7Arh4WY4zNeF2bEoz4H3Ac eqUytbWy3+cQMBRb7yPHftMW7vuHuWU8B4rNUh/SiNAh5UbbcCj+jhkM0a/iE5cDYvLLbwLUW csicO8SABpI70Rx8nAZ4ASpfvWtsaRNET9qzOXjP6RFUxLxDPghhVreStyMrRDaMNkKYhOWkC W0rVOBoYH2X1JVxv5kbuIJUwZKnvQzwv/nvCSGd91cEXYAyxUiXj5ON2bsvQ7Cb6CUZF5xtMl E2FG74EjurdIDaKJTOSuKBgAM58qdPPzG9+IAWBmGNdGfZuDu1xjeqO05CGpL3iWEFCrc3pbd hYO5nWY/SQDp2Q86BI/0kXEFuNXMV4DT/M+qXtZfGAKaF8383UMzvf6oIiNyVbbKEVx77EY+y bnoqimqX+k8zhiSTVMYwNw+syBfCbAeMJoR+yPBi0dXTKqVCMBjHRLmjcAi1nKaAkNO2kG1Ot RKl+UTYLyH62MPv/Iwfsb0wbiU92LrsjYPdeoMa1oXKOYHX/HVQhIjJ6eYaagX7xLmbcxwJyE D7BoWoHdiz+VTcUU9vC+oAuGSvDmpYtlKJj9uE1wr2+NNKppc8XpmWk9rpdW7EBNbaGfK6ZgL qqd3gypu1vTWUxj2ffs304cDQOKzeQZXeZ+jl+WcgXAguh8Jjvukmjg9DlH6D0bvRLqMaa55j 6UU1BlnoLIHpygnwItAidBtW9Yn6u21DQ8+p43wSvxdJcenlbsl3Ix3/cDtDd7m17B5Xoiqe9 J1nVOkRtTVrqWxxMfX8OPsyjMkoBgJwrj+ZPlAxyvU28AWJTM1vRx1n6UVDDZb3nfuMMqygw0 CKQb97PeHLhBng9wZaXRkWT9l+miYvPnq7MttmnS8IniWvGQdzJiJ96uuJiTU0MzDK5khTyuh U4Cjs1kDjuJV4vN3zt3NuUWCJB/AZ07gzJdYrcWkH9C/wLhJhjqdCFgU/S8CmfZpbq8b7W8Ya MfdgdDwcgDeiDtlM3LXsdYQymbgCN4KQ+6+J58e91OFK/PxHeI2yt0Pi8FUPClhXIb4lnxgJt kIXTuWu485yaP0PWCrjsXLTuQxzD7518lbSIrAg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Pierre Langlois skribis: > >> Actually, thinking about this a little more, I'm not sure I understand >> upstream decision to propagate -lz. The commit fixes [0] which indicates >> it's so that taglib can be linked statically, but then that means if >> we're dynamically linking, the application will also dynamically link >> with zlib when it doesn't need to (at least not directly). And in guix >> we only build shared libs for taglib so we're never statically linking >> it AFAIK. >> >> So, here I'm a bit torn here, should we just follow what upstream is >> indicating? Even it doesn't look right to me, but I might be wrong! Or, >> should we revert the change that propagates -lz? > > I had the following patch that I intended to push, to avoid propagation. > > WDYT? > > Ludo=E2=80=99. > > commit d8124a707602980556fd33c7dbf9f7483fe1d0df > Author: Ludovic Court=C3=A8s > Date: Mon Sep 7 09:56:08 2020 +0200 > > gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. >=20=20=20=20=20 > Fixes compilation of emacs-emms-print-metadata. >=20=20=20=20=20 > * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. LGTM! I was originally thinking we could just drop the `-lz`, since it /should/ only be needed for people who statically link with taglib, and we only ship shared libs. But actually, it's probably safer to follow what upstream is doing. Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCAA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9WOG4YHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UxnUIAK5lzRBIWA6e2gltYGSBIgw6 Sjy36KME6/TBu8D2uT5009wJGLaHNYHrGEg7kO8hDvoEt4AiomV0fbIdt+LEIY+O EBbtrSNyuc2tS1PLF2clf/sPjIOomzM+MiST0Fq0SizQBjHL8Ohw/MDl6YG/1l5Y KP2vJGh21g0KY5IVtY3FRA/KVjzTVev/TNkFJqNjvrniEEwb4DLoZ/ngYZ5sw9Pu 302KHsMXgkm8TrrZty+573Qdz11mm/gqhZnuj4/NSVdrQbq5NUvxqTZg7p6fuemZ cZ7auXP9WSIREg3bv7ZgLH3NNVs8tUFP6C9HemA/4rCdy0hpoUBjGauN5oQQHoc= =TnBV -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 24 05:14:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Michael Rohleder Subject: bug#43204: closed (Re: [bug#43204] [PATCH] gnu: taglib: Propagate zlib.) Message-ID: References: <874ko9fb8i.fsf@gnu.org> <20200904153824.27164-1-mike@rohleder.de> X-Gnu-PR-Message: they-closed 43204 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 43204@debbugs.gnu.org Date: Mon, 07 Sep 2020 22:56:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1599519361-18150-1" This is a multi-part message in MIME format... ------------=_1599519361-18150-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43204: [PATCH] gnu: taglib: Propagate zlib. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43204@debbugs.gnu.org. --=20 43204: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43204 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1599519361-18150-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43204-done) by debbugs.gnu.org; 7 Sep 2020 22:55:50 +0000 Received: from localhost ([127.0.0.1]:51341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFQ3C-0004iN-H5 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 18:55:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFQ3A-0004i8-0y for 43204-done@debbugs.gnu.org; Mon, 07 Sep 2020 18:55:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53312) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFQ33-000481-HT; Mon, 07 Sep 2020 18:55:41 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52684 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFQ2t-0003Tt-LM; Mon, 07 Sep 2020 18:55:40 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Pierre Langlois Subject: Re: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> <875z8pkck2.fsf@gnu.org> <87eendpuvl.fsf@gmx.com> Date: Tue, 08 Sep 2020 00:55:25 +0200 In-Reply-To: <87eendpuvl.fsf@gmx.com> (Pierre Langlois's message of "Mon, 07 Sep 2020 14:41:02 +0100") Message-ID: <874ko9fb8i.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43204-done Cc: 43204-done@debbugs.gnu.org, mike@rohleder.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pierre Langlois skribis: > Ludovic Court=C3=A8s writes: [...] >> commit d8124a707602980556fd33c7dbf9f7483fe1d0df >> Author: Ludovic Court=C3=A8s >> Date: Mon Sep 7 09:56:08 2020 +0200 >> >> gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. >>=20=20=20=20=20 >> Fixes compilation of emacs-emms-print-metadata. >>=20=20=20=20=20 >> * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. > > LGTM! > > I was originally thinking we could just drop the `-lz`, since it > /should/ only be needed for people who statically link with taglib, and > we only ship shared libs. But actually, it's probably safer to follow > what upstream is doing. Yeah. Pushed as d2a7114e0b46fccad1e02e301c58a5124f361c5c, thanks! Ludo=E2=80=99. ------------=_1599519361-18150-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Sep 2020 15:38:41 +0000 Received: from localhost ([127.0.0.1]:40393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEDnV-0007SJ-5Q for submit@debbugs.gnu.org; Fri, 04 Sep 2020 11:38:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:36728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEDnT-0007SC-Im for submit@debbugs.gnu.org; Fri, 04 Sep 2020 11:38:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEDnT-0003WL-By for guix-patches@gnu.org; Fri, 04 Sep 2020 11:38:39 -0400 Received: from wp224.webpack.hosteurope.de ([2a01:488:42:1000:50ed:84e7::]:40884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEDnR-0006AD-At for guix-patches@gnu.org; Fri, 04 Sep 2020 11:38:39 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kEDnN-0000UJ-Vl; Fri, 04 Sep 2020 17:38:33 +0200 Received: from [192.168.1.3] (helo=micha.rohleder.de) by www.rohleder.de with esmtp (Exim 4.94) (envelope-from ) id 1kEDnL-0007S8-9o; Fri, 04 Sep 2020 17:38:33 +0200 From: Michael Rohleder To: guix-patches@gnu.org Subject: [PATCH] gnu: taglib: Propagate zlib. Date: Fri, 4 Sep 2020 17:38:24 +0200 Message-Id: <20200904153824.27164-1-mike@rohleder.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1599233917;804496e0; X-HE-SMSGID: 1kEDnN-0000UJ-Vl Received-SPF: permerror client-ip=2a01:488:42:1000:50ed:84e7::; envelope-from=mike@rohleder.de; helo=wp224.webpack.hosteurope.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 11:38:34 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Michael Rohleder X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. --- It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz according to the installed pkg-config. I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, (I guess, all revdeps of taglib that don't have zlib as an input have that problem) gnu/packages/mp3.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 7ee009df74..8ea282be97 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -175,7 +175,7 @@ a highly stable and efficient implementation.") (arguments '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on. #:configure-flags (list "-DBUILD_SHARED_LIBS=ON"))) - (inputs `(("zlib" ,zlib))) + (propagated-inputs `(("zlib" ,zlib))) (home-page "https://taglib.org") (synopsis "Library to access audio file meta-data") (description -- 2.28.0 ------------=_1599519361-18150-1--