Subject: bug#43198: closed (Re: [bug#43198] Add breeze icon assets)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 09 Sep 2020 07:27:02 +0000

Your bug report

#43198: Add breeze icon assets

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
43198: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43198
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#43198] Add breeze icon assets
From: Ludovic Courtès <[email-masked]>
To: Prafulla Giri <[email-masked]>
Cc: [email-masked]
Date: Wed, 09 Sep 2020 09:26:34 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Prafulla Giri <[email-masked]> skribis:

> From 8096401f6f977cf48b66914e161da0efd124931e Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <[email-masked]>
> Date: Fri, 4 Sep 2020 12:56:26 +0545
> Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets
>
> * gnu/packages/kde-frameworks.scm (breeze-assets): New variable.

Applied.

> From b7d4e572923a98cc4ff266e95a3bd247556fb834 Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <[email-masked]>
> Date: Fri, 4 Sep 2020 12:59:28 +0545
> Subject: [PATCH 2/2] gnu: kde-frameworks: Add breeze
>
> * gnu/packages/kde-frameworks.scm (breeze): New variable.

[...]

> +    (synopsis "Full Breeze Theme")
> +    (description "The full Breeze visual style: a union-build of
> +breeze-assets and breeze-icons.")

I tweaked these and applied it.

Thank you!

Ludo’.

PS: Please keep the bug Cc’d.

Subject: Add breeze icon assets
From: Prafulla Giri <[email-masked]>
To: [email-masked]
Date: Fri, 4 Sep 2020 14:07:27 +0545
List-Id: <debbugs-submit.debbugs.gnu.org>

Esteemed maintainers,

I submit the following two patches to you for review.

They add breeze-assets and breeze packages.

Currently, guix only has `breeze-icons`, and this package only supplies the
icons, and not the entire breeze theme.

I have, however, a few concerns/comments regarding the patches.

# Regarding the first patch:
1. Regarding `breeze-assets`, I am not entirely sure if that is the right
name for the package. If there are any better suggestions, perhaps it
should be changed (?)
2. The `breeze-assets` package inheriting from `breeze-icons` package is
intentional: so as to show the relationship. I started with `guix
environment breeze-icons --ad-hoc stuffs` to package breeze-assets,
anyways. I think this makes it more read-able. (Can we keep it, please?)
3. I could not really find a proper home-page for the package.
4. I wonder if there should be better synopsis/description? But I'm not
sure. But if I get an 'it's all right', I'd like to run with it as-is,
please.

# Regarding the second patch:
1. I intentionally used (inherit, again, and used (@ to inherit from
mate.scm. Probably a bad idea. And it got me thinking, since union-builds
aren't all that common yet, perhaps a boilerplate union-build package could
be created. I saw that `mate` and `xfce` use almost identical package
definitions. Perhaps abstracting that away into some hidden package like
(@@ (guix some place) union-build-boilerplate) or something would keep us
from repeating ourselves? I understand that inheriting from something from
an entirely different desktop-environment might be too much spaghetti code.
And I am in favour of changing this. However, I send this patch in as a
sample of how having union-build boilerplate might help us.
2. I am not entirely certain what the version number should be. It seems
`breeze-icons` and `breeze-assets` differ in their latest version. But
since `breeze-assets` is the bigger of the two packages, I decided to go
with `breeze-assets`'s version number.

I hope to learn a lot from the review of these patches, and will try to
send updated/polished patches - as per the reviews - as promptly as
possible.

Thank you
From ac4c48493cff931d8f04abf8f52236e49bc818ae Mon Sep 17 00:00:00 2001
From: Prafulla Giri <[email-masked]>
Date: Fri, 4 Sep 2020 12:56:26 +0545
Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets

* gnu/packages/kde-frameworks.scm (breeze-assets): New variable.
---
 gnu/packages/kde-frameworks.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a1abd7d46c..7fd17d92b7 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -57,6 +57,7 @@
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages image)
   #:use-module (gnu packages kerberos)
+  #:use-module (gnu packages kde-plasma)
   #:use-module (gnu packages libreoffice)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages mp3)
@@ -325,6 +326,35 @@ It is the default icon theme for the KDE Plasma 5 desktop.")
     ;; text.
     (license license:lgpl3+)))
 
+(define-public breeze-assets
+  (package (inherit breeze-icons)
+           (name "breeze-assets")
+           (version "5.19.5")
+           (source (origin
+                     (method url-fetch)
+                     (uri (string-append
+                           "https://codeload.github.com/KDE/breeze/tar.gz/v"
+                           version))
+                     (sha256
+                      (base32
+                       "12ffrm0nrhi2avq2z7jx3pdp0zgsxsary7gpfp60vvxs1jrvnk1b"))))
+           (inputs
+            `(,@(package-inputs breeze-icons)
+              ("ki18n" ,ki18n)
+              ("kpackage" ,kpackage)
+              ("kguiaddons" ,kguiaddons)
+              ("kdecoration" ,kdecoration)
+              ("kcoreaddons" ,kcoreaddons)
+              ("kiconthemes" ,kiconthemes)
+              ("kwindowsystem" ,kwindowsystem)
+              ("kconfigwidgets" ,kconfigwidgets)
+              ("qtx11extras" ,qtx11extras)))
+           (home-page "https://github.com/KDE/breeze")
+           (synopsis "Artwork, styles and assets for the Breeze visual style")
+           (description "Artwork, styles and assets associated with the Breeze
+visual style.")
+           (license license:gpl2)))
+
 (define-public kapidox
   (package
     (name "kapidox")
-- 
2.28.0

From 468f64cd140bf38b6142fa0e4e1d6cae22c2b8df Mon Sep 17 00:00:00 2001
From: Prafulla Giri <[email-masked]>
Date: Fri, 4 Sep 2020 12:59:28 +0545
Subject: [PATCH 2/2] gnu: kde-frameworks: Add breeze

* gnu/packages/kde-frameworks.scm (breeze): New variable.
---
 gnu/packages/kde-frameworks.scm | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 7fd17d92b7..2ff90fb915 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -355,6 +355,20 @@ It is the default icon theme for the KDE Plasma 5 desktop.")
 visual style.")
            (license license:gpl2)))
 
+(define-public breeze
+  (package (inherit (@ (gnu packages mate) mate)) ;; union-build boilerplate
+           (name "breeze")
+           (version (package-version breeze-assets))
+           (native-inputs '()) ;; over-write inherited native-inputs
+           (inputs
+            `(("breeze-icons" ,breeze-icons)
+              ("breeze-assets" ,breeze-assets)))
+           (home-page "https://github.com/KDE/breeze-icons")
+           (synopsis "Full Breeze Theme")
+           (description "The full Breeze icon theme: a union-build of
+breeze-assets and breeze-icons.")
+           (license (list license:gpl2 license:gpl3+))))
+
 (define-public kapidox
   (package
     (name "kapidox")
-- 
2.28.0