From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 21:08:09 2020 Received: (at submit) by debbugs.gnu.org; 4 Sep 2020 01:08:09 +0000 Received: from localhost ([127.0.0.1]:36580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE0D3-0008Sb-DK for submit@debbugs.gnu.org; Thu, 03 Sep 2020 21:08:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:42698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE0D1-0008ST-Tx for submit@debbugs.gnu.org; Thu, 03 Sep 2020 21:08:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE0D1-0007aw-Pb for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 21:08:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50231) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE0D1-00039Y-Fm for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 21:08:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37252) by fencepost.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE0D1-0004aF-9E for bug-emacs@gnu.org; Thu, 03 Sep 2020 21:08:07 -0400 Received: from mail-oo1-xc2f.google.com ([2607:f8b0:4864:20::c2f]:40320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kE0Cz-000399-Bt for bug-emacs@gnu.org; Thu, 03 Sep 2020 21:08:07 -0400 Received: by mail-oo1-xc2f.google.com with SMTP id r4so1250569ooq.7 for ; Thu, 03 Sep 2020 18:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=tM0hjjkSA2l8nxM0QZxgHM1ANoKwY0KoRn/t1dUoX50=; b=SAau4deMJkYPJbqd/gVh8PhqT0cynVT0ftR5awpOR7ia6LlcquekdU2O5F/pYTX3v0 et7OfUGg1jcd4dgsVOQ+xDpCRhXfQw59nDPvHB61lPhXMUhBhtgyii1QaO2GZq9i5Mf1 WhoP35hKzOFX6dcCKRt0WQY/lnMRtWoY2TIME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=tM0hjjkSA2l8nxM0QZxgHM1ANoKwY0KoRn/t1dUoX50=; b=F9OgqtBYRaCPt1o8Cx/wNgc6piuq92iygJZnhdhg372AxpHIRNUcF6nYdPcAXO1oU8 ezsKyCLXeoDYS9x7ckj5LPjR3w0rvFilHqn78WXST/jMdRZofgg0lOrqu2iiKTplZMQ+ 4j+fURvho//FbtFPKhEpWDkODsmRAe8mxfSpi7BY1oxo1BgOK0vsCQeUgeuuT2FvR8pJ mvmgFA+eufwv459hBGLYohTDLZh7/qqII7BEtU2O94VtZSMH2o0jGJYYn2xjnTzI39bW +jVLKebxOqVYQWq6pmG5JuXNqDSZlKImLh/pF713ktq3o1WKX3PoKmfw76pTZM0xjsu+ 1xfQ== X-Gm-Message-State: AOAM5325wRpHfPs67VVRJt1qakQM2//bXprtt8DjZJLEYWAsPWdi5G3P zoJQB02imKWWdp/YA4fldVs+hxTBaQZfLFlgro14DqsvQow= X-Google-Smtp-Source: ABdhPJytbuUa/sQHoeeyRRaCZ27sYrwk1fvxk2LKddZE8GD2IGG8eyTnvfBEVfrHZTAhxaXbQ7IFGDxbp+08NbCxtpE= X-Received: by 2002:a4a:e4d9:: with SMTP id w25mr4056187oov.33.1599181683129; Thu, 03 Sep 2020 18:08:03 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Fri, 4 Sep 2020 02:07:51 +0100 Message-ID: Subject: [PATCH] Add enchant-2 to list of default spelling checker programs To: bug-emacs Content-Type: multipart/mixed; boundary="00000000000027b03005ae72801e" Received-SPF: pass client-ip=2607:f8b0:4864:20::c2f; envelope-from=rrt@sc3d.org; helo=mail-oo1-xc2f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --00000000000027b03005ae72801e Content-Type: multipart/alternative; boundary="00000000000027b02e05ae72801c" --00000000000027b02e05ae72801c Content-Type: text/plain; charset="UTF-8" (As I've not been active for a while, I'd appreciate a review of this admittedly trivial patch; I plan to make another few patches to ispell.el.) I attach a patch to fix an XXX and add "enchant-2" to the list of spelling checker programs checked by default. The XXX comment noted that enchant >= 2.1.0 is required by ispell.el; the good news is that enchant is now commonly installed under the name "enchant-2", which is likely to be a suitable version (2.0.x releases were not widely adopted), so rather than look for "enchant" (perhaps that will come later), we can now look for "enchant-2". -- https://rrt.sc3d.org --00000000000027b02e05ae72801c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(As I've not been active for a whil= e, I'd appreciate a review of this admittedly trivial patch; I plan to = make another few patches to ispell.el.)

<= div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif= ;font-size:small">I attach a patch to fix an XXX and add "enchant-2&qu= ot; to the list of spelling checker programs checked by default. The XXX co= mment noted that enchant >=3D 2.1.0 is required by ispell.el; the good n= ews is that enchant is now commonly installed under the name "enchant-= 2", which is likely to be a suitable version (2.0.x releases were not = widely adopted), so rather than look for "enchant" (perhaps that = will come later), we can now look for "enchant-2".

--
--00000000000027b02e05ae72801c-- --00000000000027b03005ae72801e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-enchant-2-to-list-of-default-spelling-checker-pr.patch" Content-Disposition: attachment; filename="0001-Add-enchant-2-to-list-of-default-spelling-checker-pr.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kenjgssz0 RnJvbSA5MGEwYTVlYzM2NGVmYjgyMDdjMWI0ZTFiOWI1Mzk2MzQxMzVjZjNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IEZy aSwgNCBTZXAgMjAyMCAwMTo1ODowNCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBlbmNoYW50 LTIgdG8gbGlzdCBvZiBkZWZhdWx0IHNwZWxsaW5nIGNoZWNrZXIgcHJvZ3JhbXMKCiogbGlzcC90 ZXh0bW9kZXMvaXNwZWxsLmVsIChpc3BlbGwtcHJvZ3JhbS1uYW1lKTogQ2hlY2sgYGVuY2hhbnQt MicsCmFzIGl0IGlzIGxpa2VseSB0byBiZSBhIHN1aXRhYmxlIHZlcnNpb24uIEVuY2hhbnQgMiBz ZWVtcyB0byBiZQpjb21tb25seSBpbnN0YWxsZWQgdW5kZXIgdGhpcyBuYW1lLCBzbyB3ZSBkb24n dCBoYXZlIHRvIHdvcnJ5IGFib3V0CmNoZWNraW5nIGBlbmNoYW50Jy4KLS0tCiBsaXNwL3RleHRt b2Rlcy9pc3BlbGwuZWwgfCA1ICstLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsIGIv bGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCmluZGV4IDg2NDUyZmYxZTguLjgyODFmMWQ2YmQgMTAw NjQ0Ci0tLSBhL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbAorKysgYi9saXNwL3RleHRtb2Rlcy9p c3BlbGwuZWwKQEAgLTE5OCwxNCArMTk4LDExIEBAIGlzcGVsbC1jaG9pY2VzLXdpbi1kZWZhdWx0 LWhlaWdodAogICA6dHlwZSAnaW50ZWdlcgogICA6Z3JvdXAgJ2lzcGVsbCkKIAotOzsgWFhYIEFk ZCBlbmNoYW50IHRvIHRoaXMgbGlzdCBvbmNlIGVuY2hhbnQgPj0gMi4xLjAgaXMgd2lkZXNwcmVh ZC4KLTs7IEJlZm9yZSB0aGF0LCBhZGRpbmcgaXQgaXMgdXNlbGVzcywgYXMgaWYgaXQgaXMgZm91 bmQsIGl0IHdpbGwganVzdAotOzsgY2F1c2UgYW4gZXJyb3I7IGFuZCBvbmUgb2YgdGhlIG90aGVy IHNwZWxsaW5nIGVuZ2luZXMgYmVsb3cgaXMKLTs7IGFsbW9zdCBjZXJ0YWlubHkgaW5zdGFsbGVk IGluIGFueSBjYXNlLCBmb3IgZW5jaGFudCB0byB1c2UuCiAoZGVmY3VzdG9tIGlzcGVsbC1wcm9n cmFtLW5hbWUKICAgKG9yIChleGVjdXRhYmxlLWZpbmQgImFzcGVsbCIpCiAgICAgICAoZXhlY3V0 YWJsZS1maW5kICJpc3BlbGwiKQogICAgICAgKGV4ZWN1dGFibGUtZmluZCAiaHVuc3BlbGwiKQor ICAgICAgKGV4ZWN1dGFibGUtZmluZCAiZW5jaGFudC0yIikKICAgICAgICJpc3BlbGwiKQogICAi UHJvZ3JhbSBpbnZva2VkIGJ5IFxcW2lzcGVsbC13b3JkXSBhbmQgXFxbaXNwZWxsLXJlZ2lvbl0g Y29tbWFuZHMuIgogICA6dHlwZSAnc3RyaW5nCi0tIAoyLjI1LjEKCg== --00000000000027b03005ae72801e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 21:46:22 2020 Received: (at 43191) by debbugs.gnu.org; 4 Sep 2020 01:46:22 +0000 Received: from localhost ([127.0.0.1]:36631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE0o2-0000wU-0n for submit@debbugs.gnu.org; Thu, 03 Sep 2020 21:46:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE0o0-0000wC-61 for 43191@debbugs.gnu.org; Thu, 03 Sep 2020 21:46:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XIwEwGwUMBDDEMC6s8SnObAs19Szmdrn4tVg2EF/Et8=; b=lLoao+ArVCWch8FSEJkqqUsdw5 p8Z8rBxYB0mpiUy3zlfP++qt2R1gDgf6OpOF81J/cT515QlSmNhazHKW2ftzBnegMXagjg3SnWSRp Gu2MPafGMltjGhx4jB78LshEInLZsmnGnFsuWrJfUruaPHe4xW/ViYUaRur+Qy024teY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE0nj-0000sR-Pm; Fri, 04 Sep 2020 03:46:13 +0200 From: Lars Ingebrigtsen To: Reuben Thomas Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs References: X-Now-Playing: Herbert's _Early Herbert_ Date: Fri, 04 Sep 2020 03:46:02 +0200 In-Reply-To: (Reuben Thomas's message of "Fri, 4 Sep 2020 02:07:51 +0100") Message-ID: <87imcus49x.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Reuben Thomas writes: > (As I've not been active for a while, I'd appreciate a review of this > admittedly trivial patch; I plan to make another few patches to > ispell.el.) Looks good to me (although I haven't used enchant-2 myself). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43191 Cc: 43191@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Reuben Thomas writes: > (As I've not been active for a while, I'd appreciate a review of this > admittedly trivial patch; I plan to make another few patches to > ispell.el.) Looks good to me (although I haven't used enchant-2 myself). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 21:51:34 2020 Received: (at 43191) by debbugs.gnu.org; 4 Sep 2020 01:51:34 +0000 Received: from localhost ([127.0.0.1]:36645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE0t4-00014t-7d for submit@debbugs.gnu.org; Thu, 03 Sep 2020 21:51:34 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:34662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE0t2-00014f-Cc for 43191@debbugs.gnu.org; Thu, 03 Sep 2020 21:51:32 -0400 Received: by mail-qk1-f180.google.com with SMTP id w186so5093760qkd.1 for <43191@debbugs.gnu.org>; Thu, 03 Sep 2020 18:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=x2x/6aqCmDEgisuUB2ez5/B3vYAdGcUGHxbvOF7bHBk=; b=Nb6rRUxG9hF+KOybb5jy3IXyaQ/iLcQXc9IuTQDNXSY+lWQ6co4cjdNIbtdknGkDTO nCMXhA9bJgSudw/g2a06VUH9qEQsn53E70fWAsYuGIz7u3T6i15Nr6jS3j07OU/aqzpz PNYwL/thqQedsxQFMOJoYqP709gLpbQSy/KIQRdf2LihltWtZGuCi7m8184DtSeJ78Ni 7lI2HmsPEJ1905x7T041sE1MlrCy4cP6TpOjOXWGRp/x9Qo7yA8z2PTdVkG2zCcorkMj UOhBKVskUL7Gw8nMcXTPgRLIWnpar0kGxWUJTBbeE1DjuSv1BXg5OUDNmy1ebVserByE 927Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=x2x/6aqCmDEgisuUB2ez5/B3vYAdGcUGHxbvOF7bHBk=; b=CTgIsoNPveT8Nn2pwu9ENymPPWpqH08VSmtLhhJaooy5oR/RHZbaVTp3ejU09UGIzU Gfhq4cG+O92iWd/7MXKhX/0ZTu0ch4k5LLjPu6nVfyMPSvZtrEETFqYiyWUllDdRA70O VKBwFHhZwcJaJ+zP3r/mFEBnlBqCNqLTTZ25NCb1Be82FPUoeriKH4cqDIgoUo9sRgcc 0F920Hu+fktcr61V7e/bwxDjkmdRliLBTpWQhn5kgMMeU2SaqHTolkIZdvCaPoa2Bvpo PbfHtM2Nk0+eob09X8rCs9E9fciA2bi7qnNNMrMO9scMVyxv33pbkGGC8VcD7A4zhrb6 e19w== X-Gm-Message-State: AOAM532v+tPCNKjqv+FACRrt0h7wU4DeSB4pYmFjikEWRLehVzMJISHi VZqlD5wvRfstUkB8a+iVednxlOnrwElsew== X-Google-Smtp-Source: ABdhPJxX6qGgD6sgB49+3B2bRE0oQvLtfkqTKe065IIoJDNX0cVMjBLsaDxN2jpjRlzWeBMmg2ARYg== X-Received: by 2002:a37:a80e:: with SMTP id r14mr6172030qke.85.1599184286513; Thu, 03 Sep 2020 18:51:26 -0700 (PDT) Received: from LAPTOP-5NDQIUP9 (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id c7sm3545563qkd.92.2020.09.03.18.51.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Sep 2020 18:51:26 -0700 (PDT) From: Noam Postavsky To: Reuben Thomas Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs References: Date: Thu, 03 Sep 2020 21:51:24 -0400 In-Reply-To: (Reuben Thomas's message of "Fri, 4 Sep 2020 02:07:51 +0100") Message-ID: <86363yia1v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43191 Cc: 43191@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Reuben Thomas writes: > * lisp/textmodes/ispell.el (ispell-program-name): Check `enchant-2', > as it is likely to be a suitable version. Enchant 2 seems to be > commonly installed under this name, so we don't have to worry about > checking `enchant'. The second sentence might be better as a code comment (but otherwise, put 2 spaces after periods). From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 03:27:48 2020 Received: (at 43191) by debbugs.gnu.org; 4 Sep 2020 07:27:48 +0000 Received: from localhost ([127.0.0.1]:37146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE68S-0006EZ-FX for submit@debbugs.gnu.org; Fri, 04 Sep 2020 03:27:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE68Q-0006EI-R0 for 43191@debbugs.gnu.org; Fri, 04 Sep 2020 03:27:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54181) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE68L-0005OR-DI; Fri, 04 Sep 2020 03:27:41 -0400 Received: from [176.228.60.248] (port=4368 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE68K-0008Mc-9d; Fri, 04 Sep 2020 03:27:40 -0400 Date: Fri, 04 Sep 2020 10:27:29 +0300 Message-Id: <83y2lqt31a.fsf@gnu.org> From: Eli Zaretskii To: Reuben Thomas In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43191 Cc: 43191@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 4 Sep 2020 02:07:51 +0100 > From: Reuben Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > (As I've not been active for a while, I'd appreciate a review of this admittedly trivial patch; I plan to make > another few patches to ispell.el.) I will review the patch soon, thanks. Meanwhile, would you please look into the problems raised in bug#42248? I have difficulty understanding the issues there, since I'm not familiar enough with Enchant (it sounds like they've changed the valid options and their syntax lately, so our support fails in some cases?), and would appreciate your help. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 09:30:36 2020 Received: (at 43191) by debbugs.gnu.org; 4 Sep 2020 13:30:36 +0000 Received: from localhost ([127.0.0.1]:38017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBnX-0003vD-SX for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:30:36 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:41983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBnW-0003oT-Qf for 43191@debbugs.gnu.org; Fri, 04 Sep 2020 09:30:35 -0400 Received: by mail-oi1-f173.google.com with SMTP id x69so3529856oia.8 for <43191@debbugs.gnu.org>; Fri, 04 Sep 2020 06:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QHWQ9UQoHjz3TGrBtiUVtyREfjhH+KouFTCg3I+mVao=; b=WWWF1j4XTSTFxkijrAIoZcowwu0iJoFaMNoIN2eVmzZA05miw5Yi8uu6LVqTktOrrY rkjgGpW7Z6USe3n37hnSHlQQZfMuQFzckSYjRsIzPa7k3EVXOXn9qu8RC+v2MzFuU1SI q7aR+hfdbKkVIdNN4B+Qg5ttuVfEza7tGZ7XQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QHWQ9UQoHjz3TGrBtiUVtyREfjhH+KouFTCg3I+mVao=; b=Wn5tgijlhkkHBlSfcwqjw5jRK5joYL5Yu6l4Qt0CUSvHVCMvGxqYXgmA3F86nr0cYk 5pyeHIyeDIJjtn94Qj4gAbiY43Jb0tTySCVPPp5sFHh7e60CvxsXKg/PtX8gHkS83UQP BA26cMMyx5KslcpiDslVvJFAmJCiUDBxSvEzv0xtNPtVzEC1y+3YborZ+pFuUmDHJ0Ld HxvK2TJ14qVCmydH8ZMj8qYoebfdXwwU3P4SHf0JRnewlSgqdwLJnzZM8I2xCFXcqfcs QpUdHt+WDsFmDKGblnncZo/KY8CUlxwM7nHcc4PMlV+1xyU1vHVnUMNS7Sl6Ak/SYgf5 k16Q== X-Gm-Message-State: AOAM531a4H2r3vvSZen4vCddhqQ2aX4+kNuMMXolqoXhVn5yLvr3x4U7 /F4lzqGZpSSOwthrNT9yGj4ghRNRTgPxcCSwV31UIW4zaX8= X-Google-Smtp-Source: ABdhPJzLjWCeQXCogfYPLhK7N44lEBIxkFa5qfenhSbbm14TJk9k8pcr+ys6l2W6xxEe1MyywFWOYWI3hz6/4KA/BGs= X-Received: by 2002:aca:abc2:: with SMTP id u185mr5384552oie.62.1599226229071; Fri, 04 Sep 2020 06:30:29 -0700 (PDT) MIME-Version: 1.0 References: <83y2lqt31a.fsf@gnu.org> In-Reply-To: <83y2lqt31a.fsf@gnu.org> From: Reuben Thomas Date: Fri, 4 Sep 2020 14:30:18 +0100 Message-ID: Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000004cb43c05ae7cdfd8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43191 Cc: 43191@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004cb43c05ae7cdfd8 Content-Type: text/plain; charset="UTF-8" On Fri, 4 Sep 2020 at 08:27, Eli Zaretskii wrote: > > Date: Fri, 4 Sep 2020 02:07:51 +0100 > > From: Reuben Thomas via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > (As I've not been active for a while, I'd appreciate a review of this > admittedly trivial patch; I plan to make > > another few patches to ispell.el.) > > I will review the patch soon, thanks. > Thanks, Eli. Meanwhile, would you please look into the problems raised in > bug#42248? I have difficulty understanding the issues there, since > I'm not familiar enough with Enchant (it sounds like they've changed > the valid options and their syntax lately, so our support fails in > some cases?), and would appreciate your help. > No problem, I'll look into it. -- https://rrt.sc3d.org --0000000000004cb43c05ae7cdfd8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, 4 Sep 2020 at 08:27, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Fri, 4 Sep 2020 02:07:51 +0100
> From: Reuben Thomas via "Bug reports for GNU Emacs,
>=C2=A0 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> (As I've not been active for a while, I'd appreciate a review = of this admittedly trivial patch; I plan to make
> another few patches to ispell.el.)

I will review the patch soon, thanks.

<= div style=3D"font-family:arial,helvetica,sans-serif;font-size:small" class= =3D"gmail_default">Thanks, Eli.

Meanwhile, would you please look into the problems raised in
bug#42248?=C2=A0 I have difficulty understanding the issues there, since I'm not familiar enough with Enchant (it sounds like they've change= d
the valid options and their syntax lately, so our support fails in
some cases?), and would appreciate your help.

No problem, I&= #39;ll look into it.

--
--0000000000004cb43c05ae7cdfd8-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 02:49:11 2020 Received: (at 43191) by debbugs.gnu.org; 5 Sep 2020 06:49:11 +0000 Received: from localhost ([127.0.0.1]:41427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kES0d-0003BH-8s for submit@debbugs.gnu.org; Sat, 05 Sep 2020 02:49:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kES0a-0003Aw-AB for 43191@debbugs.gnu.org; Sat, 05 Sep 2020 02:49:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59157) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kES0U-0006Er-K0; Sat, 05 Sep 2020 02:49:02 -0400 Received: from [176.228.60.248] (port=4883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kES0T-0006vR-P0; Sat, 05 Sep 2020 02:49:02 -0400 Date: Sat, 05 Sep 2020 09:48:54 +0300 Message-Id: <83v9gspvl5.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-Reply-To: <86363yia1v.fsf@gmail.com> (message from Noam Postavsky on Thu, 03 Sep 2020 21:51:24 -0400) Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs References: <86363yia1v.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43191 Cc: 43191@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noam Postavsky > Date: Thu, 03 Sep 2020 21:51:24 -0400 > Cc: 43191@debbugs.gnu.org > > Reuben Thomas writes: > > > * lisp/textmodes/ispell.el (ispell-program-name): Check `enchant-2', > > as it is likely to be a suitable version. Enchant 2 seems to be > > commonly installed under this name, so we don't have to worry about > > checking `enchant'. > > The second sentence might be better as a code comment (but otherwise, > put 2 spaces after periods). I agree, and the patch LGTM otherwise. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 18:25:44 2020 Received: (at 43191-done) by debbugs.gnu.org; 6 Sep 2020 22:25:44 +0000 Received: from localhost ([127.0.0.1]:47362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF36V-0004b6-SG for submit@debbugs.gnu.org; Sun, 06 Sep 2020 18:25:44 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:38269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF36T-0004ar-LR for 43191-done@debbugs.gnu.org; Sun, 06 Sep 2020 18:25:42 -0400 Received: by mail-ot1-f67.google.com with SMTP id y5so10815251otg.5 for <43191-done@debbugs.gnu.org>; Sun, 06 Sep 2020 15:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tf3Hg4iqc8GFhkRGYLHz/ztMAue+2rzaUSDHbCYHD5A=; b=3b0zBwP8SbgWcQR9/oyA0BaLGatlKv2KhMd4ZUrarwGApjRv0xCnQ9J3APlz9P6CM/ DZ53ey92C2xQ8OJKSsI8u75YqtsDvSRpcKwLAH+Pe94zqJJLOqvQI05cbBktZDSrkmMf wBBz6Qo9aT3DGXnj2J13crSIcXkP7JpvdcJIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tf3Hg4iqc8GFhkRGYLHz/ztMAue+2rzaUSDHbCYHD5A=; b=NK5dyx4n6PaB05QU2Xl+Q2TfoTKN+rlWqlWpSD4VdKBaA+U42QI42skFNI1cGgVNVK l4sHsJMsPS7wOziSZ46LZ4BmdfRUxSDQjbZFmMnFR6KIZSHB+ddPpw0jUIlBoVNjjQ7C n4gUtED7Az6refB2P+NxHXEc1IDDUnWfmlB5OvlllzNpN34GeW97ADvlZ+0OOsXJhO0/ XmkDY5tnuJq//7193lnqTNYKq4cMDjQB7tX03bsrx0T26JzyfER6nqVI2bcKMW4dDkA0 tDK/5shZ1ZAMnok+N9r3dmOaOQ6UkyOrV0hcGdFHNrytFWRAnQeF+3hj1vfUBWhbMBz1 mPyw== X-Gm-Message-State: AOAM531ZAZMY5X3k6KzuOgthT2IOtQy6kAjRjofmLV6+hbq0UDkutcW4 Kq5nyVeW9PD/RGyOJDA/gG6xihkxnnxBx+gzKJvMYw== X-Google-Smtp-Source: ABdhPJwxJKprROZXiiN7AUaN4t7a9p6g+A8OwxhtBDf7WXHsVUPDFV0AGcWV7r8ER/iB5uRIne2aHcbxS2KIRIF9w4I= X-Received: by 2002:a9d:7186:: with SMTP id o6mr12199581otj.76.1599431135832; Sun, 06 Sep 2020 15:25:35 -0700 (PDT) MIME-Version: 1.0 References: <86363yia1v.fsf@gmail.com> <83v9gspvl5.fsf@gnu.org> In-Reply-To: <83v9gspvl5.fsf@gnu.org> From: Reuben Thomas Date: Sun, 6 Sep 2020 23:25:24 +0100 Message-ID: Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000b1c48f05aeac9416" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43191-done Cc: 43191-done@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b1c48f05aeac9416 Content-Type: text/plain; charset="UTF-8" I've adjusted the patch as suggested, moving the second sentence into a code comment, and installed the patch. Thanks all for your reviews. -- https://rrt.sc3d.org --000000000000b1c48f05aeac9416 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've adjusted the patch as suggeste= d, moving the second sentence into a code comment, and installed the patch.=

Thanks all for your r= eviews.

--
--000000000000b1c48f05aeac9416-- From unknown Mon Jun 23 00:33:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Oct 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator