GNU bug report logs - #43191
[PATCH] Add enchant-2 to list of default spelling checker programs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43191 in the body.
You can then email your comments to 43191 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-emacs <bug-emacs <at> gnu.org>
Subject: [PATCH] Add enchant-2 to list of default spelling checker programs
Date: Fri, 4 Sep 2020 02:07:51 +0100

[Message part 1 (text/plain, inline)]

(As I've not been active for a while, I'd appreciate a review of this
admittedly trivial patch; I plan to make another few patches to ispell.el.)

I attach a patch to fix an XXX and add "enchant-2" to the list of spelling
checker programs checked by default. The XXX comment noted that enchant >=
2.1.0 is required by ispell.el; the good news is that enchant is now
commonly installed under the name "enchant-2", which is likely to be a
suitable version (2.0.x releases were not widely adopted), so rather than
look for "enchant" (perhaps that will come later), we can now look for
"enchant-2".

-- 
https://rrt.sc3d.org

[Message part 2 (text/html, inline)]

[0001-Add-enchant-2-to-list-of-default-spelling-checker-pr.patch (text/x-patch, attachment)]

Message #8 received at 43191 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 43191 <at> debbugs.gnu.org
Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling
 checker programs
Date: Fri, 04 Sep 2020 03:46:02 +0200

Reuben Thomas <rrt <at> sc3d.org> writes:

> (As I've not been active for a while, I'd appreciate a review of this
> admittedly trivial patch; I plan to make another few patches to
> ispell.el.)

Looks good to me (although I haven't used enchant-2 myself).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 43191 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 43191 <at> debbugs.gnu.org
Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling
 checker programs
Date: Thu, 03 Sep 2020 21:51:24 -0400

Reuben Thomas <rrt <at> sc3d.org> writes:

> * lisp/textmodes/ispell.el (ispell-program-name): Check `enchant-2',
> as it is likely to be a suitable version. Enchant 2 seems to be
> commonly installed under this name, so we don't have to worry about
> checking `enchant'.

The second sentence might be better as a code comment (but otherwise,
put 2 spaces after periods).

Message #14 received at 43191 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 43191 <at> debbugs.gnu.org
Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling
 checker programs
Date: Fri, 04 Sep 2020 10:27:29 +0300

> Date: Fri, 4 Sep 2020 02:07:51 +0100
> From: Reuben Thomas via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> (As I've not been active for a while, I'd appreciate a review of this admittedly trivial patch; I plan to make
> another few patches to ispell.el.)

I will review the patch soon, thanks.

Meanwhile, would you please look into the problems raised in
bug#42248?  I have difficulty understanding the issues there, since
I'm not familiar enough with Enchant (it sounds like they've changed
the valid options and their syntax lately, so our support fails in
some cases?), and would appreciate your help.

Message #17 received at 43191 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43191 <at> debbugs.gnu.org
Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling
 checker programs
Date: Fri, 4 Sep 2020 14:30:18 +0100

[Message part 1 (text/plain, inline)]

On Fri, 4 Sep 2020 at 08:27, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Fri, 4 Sep 2020 02:07:51 +0100
> > From: Reuben Thomas via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >
> > (As I've not been active for a while, I'd appreciate a review of this
> admittedly trivial patch; I plan to make
> > another few patches to ispell.el.)
>
> I will review the patch soon, thanks.
>

Thanks, Eli.

Meanwhile, would you please look into the problems raised in
> bug#42248?  I have difficulty understanding the issues there, since
> I'm not familiar enough with Enchant (it sounds like they've changed
> the valid options and their syntax lately, so our support fails in
> some cases?), and would appreciate your help.
>

No problem, I'll look into it.

-- 
https://rrt.sc3d.org

[Message part 2 (text/html, inline)]

Message #20 received at 43191 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 43191 <at> debbugs.gnu.org, rrt <at> sc3d.org
Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling
 checker programs
Date: Sat, 05 Sep 2020 09:48:54 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Thu, 03 Sep 2020 21:51:24 -0400
> Cc: 43191 <at> debbugs.gnu.org
> 
> Reuben Thomas <rrt <at> sc3d.org> writes:
> 
> > * lisp/textmodes/ispell.el (ispell-program-name): Check `enchant-2',
> > as it is likely to be a suitable version. Enchant 2 seems to be
> > commonly installed under this name, so we don't have to worry about
> > checking `enchant'.
> 
> The second sentence might be better as a code comment (but otherwise,
> put 2 spaces after periods).

I agree, and the patch LGTM otherwise.

Thanks.

Message #25 received at 43191-done <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43191-done <at> debbugs.gnu.org, Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#43191: [PATCH] Add enchant-2 to list of default spelling
 checker programs
Date: Sun, 6 Sep 2020 23:25:24 +0100

[Message part 1 (text/plain, inline)]

I've adjusted the patch as suggested, moving the second sentence into a
code comment, and installed the patch.

Thanks all for your reviews.

-- 
https://rrt.sc3d.org

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.