GNU bug report logs - #43183
[PATCH] gnu: Add loko-scheme.

Previous Next

Full log

Message #8 received at 43183 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Martin Becze <mjbecze <at> riseup.net>
Cc: 43183 <at> debbugs.gnu.org
Subject: Re: [bug#43183] [PATCH] gnu: Add loko-scheme.
Date: Fri, 04 Sep 2020 08:43:37 +0200

Hello Martin,

Thanks for this patch.

> +(define pfds
> +  (let ((name "pfds")
> +	(version "0.3"))
> +      (origin
> +	(method git-fetch)

There's a space/tab indentation mix here and in the other origin
declarations.

> +	(uri (git-reference
> +	      (url "https://github.com/ijp/pfds.git")
> +	      (commit (string-append "v" version))))

This could be useful not only for Loko but also for other scheme
implementations. Thus, it would be nice to define it as a proper package
rather than a simple origin.

> +              (sha256 (base32 "019jlh3lywy912cfz689c9fxgf4bi5700i9k04g7sl5w5gchj36m"))

This is usually wrapped to stay under the 78 columns limit.

> +              (file-name (git-file-name name version))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f

You should add a comment explaining why tests are disabled.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.