Subject: Re: bug#43180: [PATCH] scripts: system: Expand some help messages.

From: Efraim Flashner <[email-masked]>
Date: Sat, 5 Sep 2020 22:26:44 +0300

On Thu, Sep 03, 2020 at 02:46:23PM +0200, Julien Lepiller wrote:
> Le Thu,  3 Sep 2020 14:55:42 +0300,
> Efraim Flashner <[email-masked]> a écrit :
> 
> > * guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
> > '--expose=SPEC' that it also works for containers.
> > ---
> >  guix/scripts/system.scm | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> > index b75b0e5b60..be17bc1ba7 100644
> > --- a/guix/scripts/system.scm
> > +++ b/guix/scripts/system.scm
> > @@ -7,6 +7,7 @@
> >  ;;; Copyright © 2019 Christopher Baines <[email-masked]>
> >  ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <[email-masked]>
> >  ;;; Copyright © 2020 Julien Lepiller <[email-masked]>
> > +;;; Copyright © 2020 Efraim Flashner <[email-masked]>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
> >    (display (G_ "
> >        --save-provenance  save provenance information"))
> >    (display (G_ "
> > -      --share=SPEC       for 'vm', share host file system according
> > to SPEC"))
> > +      --share=SPEC       for 'vm' and 'container', share host file
> > system
> > +                         according to SPEC"))
> >    (display (G_ "
> > -      --expose=SPEC      for 'vm', expose host file system according
> > to SPEC"))
> > +      --expose=SPEC      for 'vm' and 'container', expose host file
> > system
> > +                         according to SPEC"))
> >    (display (G_ "
> >    -N, --network          for 'container', allow containers to access
> > the network")) (display (G_ "
> 
> Should we say something about how sharing is read-write, exposing is
> read-only?

Sounds good. I expanded it a bit to mention share is read/write and
expose is read-only.

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted