GNU bug report logs - #43161
[PATCH] gnu: deluge: Update to 2.0.3.

Previous Next

Full log

Message #13 received at 43161-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 43161-done <at> debbugs.gnu.org
Subject: Re: [bug#43161] [PATCH] gnu: deluge: Update to 2.0.3.
Date: Sat, 05 Sep 2020 15:59:04 -0400

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hey,
>
>> * gnu/packages/bittorrent.scm (deluge): Update to 2.0.3.
>> [source]: Update URL.
>> [inputs]: Remove libtorrent, python2-chardet, python2-pygtk,
>> python2-pyopenssl,
>> python2-pyxdg, python2-service-identity, python2-twisted.
>> [propagated-inputs]: Add gobject-introspection, gtk+, librsvg, libtorrent,
>> python-pycairo, python-chardet, python-dbus, python-mako, python-pygobject,
>> python-pillow, python-pyopenssl, python-pyxdg, python-rencode,
>> python-service-identity, python-setproctitle, python-six, python-twisted, and
>> python-zope-interface.
>> [native-inputs]: Add python-wheel.
>> [arguments]: Disable tests.  Add 'wrap phase.
>
> That's a major update!
>
>> +    ;; After "pytest-twisted" is packaged, HOME is set, and an X server is
>> + ;; started, some of the tests still fail.  There are likely some
>> tests that
>> +    ;; require a network connection.
>
> Besides wrapping this comment to stay under the 78 columns limit, it all
> looks fine.
>

Alright, I was under the impression that the column limit was 80 based
on the note in guix/lint.scm.

> Thanks,
>
> Mathieu

Pushed with size-reducing and bug-fixing changes to master as commit
01d5eec92d!

Thanks for reviewing,
Kei

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.