From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 06:49:03 2020 Received: (at submit) by debbugs.gnu.org; 1 Sep 2020 10:49:03 +0000 Received: from localhost ([127.0.0.1]:55206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD3qY-0001YO-MP for submit@debbugs.gnu.org; Tue, 01 Sep 2020 06:49:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:41430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD3qW-0001Xz-N5 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 06:49:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD3qW-00016z-Ds for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 06:49:00 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:40455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kD3qU-0002uq-TH for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 06:49:00 -0400 Received: by mail-ej1-f54.google.com with SMTP id z22so950249ejl.7 for ; Tue, 01 Sep 2020 03:48:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=9ZSJ7zFUsgs6F+GcKxX9jEr3PUWxpPAkD93H5jIT/Zg=; b=mWRBQkoJRs6oWN/sCodxOSBBw/ht102VmHR226ZtoOMMH6Fzb53CVAQrIRAW1trEZ6 FIfhcpHPpR2M3dZN81obAyGO9bMqFzUptFGUrht05WU+QUrYPyAQ51Q5ikDZOe0VORiV GxN28klj4BLcsRcMBvxN0FAssrBa57/HCRd/HKdUAWOTlSbCGM9Hq6xIBZleByrVgSQm MNyznGCWF2ga65W1UhW9obFnUxrjTUqBMYWoLZH5gKvrPNE7npqlYz+NwKwChI9vk5Kb 0E0atYsbpV/ywtDVOGC26fb+HUsG12KAj6ga/k5AuNSBOZdpflFAw2VDT+cx0gfpZH1Q /tKA== X-Gm-Message-State: AOAM531ISKedwFa67cW1hxlBlRbRjvbjSoMxrYLbjub5cyQFIhA+C9Au cKfhQCVb45383CQtCsZUA6VCp1JVuYniTE+dtyCSIgvQ X-Google-Smtp-Source: ABdhPJw+EXDGmj5aiGoFo2Iz8aQys4PxOowTR5QsoYcswcIcduQlfACRJ9P1SWIr/sc8JqVxKk+ZDF+TETqR4ndFTcI= X-Received: by 2002:a17:906:e0c2:: with SMTP id gl2mr906222ejb.160.1598957336755; Tue, 01 Sep 2020 03:48:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 1 Sep 2020 03:48:55 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 1 Sep 2020 03:48:55 -0700 Message-ID: Subject: Add new command project-find-dir (and move binding of project-dired) To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.218.54; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f54.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 06:48:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Severity: wishlist Please consider adding a new command `project-find-dir' that works like `project-find-file' but for directories. I would also suggest to move `project-dired to `C-c p D' and put the new `project-find-dir' command on `C-c p d'. These key bindings would be in line with the third-party projectile package. Thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 07:55:21 2020 Received: (at 43153) by debbugs.gnu.org; 1 Sep 2020 11:55:21 +0000 Received: from localhost ([127.0.0.1]:55302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD4si-0005Kl-PF for submit@debbugs.gnu.org; Tue, 01 Sep 2020 07:55:21 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:32964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD4sf-0005KU-Pu for 43153@debbugs.gnu.org; Tue, 01 Sep 2020 07:55:19 -0400 Received: by mail-lj1-f179.google.com with SMTP id r13so1163901ljm.0 for <43153@debbugs.gnu.org>; Tue, 01 Sep 2020 04:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nKRyAiO1lN5N7A4C1TARFLgPR0+xDbMVsbtEwfm6XB8=; b=r2ZmEnEO6wxtRHhapbrTlvT6SnBrUzvtCgd9dfYS4tn4LrV+C1E0e2J/roibWF3l6w 1O9ufz2AA7odC/9utfqSOGhuePw1s254k1Lr8OsuzreLvBPrjiCmTQ7miCKf8NbkU5ZW SeM67gEJunLUfFmToNP+xkt3AicyuB3/m4kRkUjT2H/zjvemSXSIFTs8uJf66pSTrHlr opsJ7yWZW/XSxojkSj8aj6CrYSrk+3bQzKfQXfRd+oR2t3MOe9XDkKIes0wTkr2yW58y aEo4FhnHqLQiVbamGSLd7U76xlUouaQNUVTGVWV46vdrCa7E1is9PsizNaFmJJ9dqOby MU/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nKRyAiO1lN5N7A4C1TARFLgPR0+xDbMVsbtEwfm6XB8=; b=bG4kdEiIVz+5L6Gpa+u9Y7nxZvOBt4mbzv3WSERuoGBlTJou6ikFgnKrked0ZOvrkQ zrDLqdiMob3qNH2SgZUtAdQmXt0JbXsz0lVuG0ZAqcOa8ID+n04LKoFJEIlKINwZx+qV Sdiy970R3nDlKWXVkJhNe2/yg16TYLg7sKHiHb3YqlfjtwTIHF86U6ZbwACj7Cy4x2H5 Nmtn+zRqctsHIX3H6yWzkUe8s3zKC4cbvoBLlxJv8Pifl+17wB3wWJsG9N+acCSBdCMg Rx5fXAMIR0Z84xXQbDB200UyRsXZE3kNNVGMkuVL+p50mR8Pda0gWYxeIl7mWdW4yrhD id7g== X-Gm-Message-State: AOAM531YlmRVJ9ilrY691s9zef4mWk2hkz8WDayA2SKU6e86VsdaFZpg RC/TyCRGJa6hiRGkl4oxoWDDDEDSmvg= X-Google-Smtp-Source: ABdhPJyhSYGsn7rylKs0eQAefAbXG4rTydV7xvGp/nqiHoJ8Bonthzakcr/qQMM2c8ORWEq25mkSPg== X-Received: by 2002:a2e:808f:: with SMTP id i15mr427962ljg.151.1598961311152; Tue, 01 Sep 2020 04:55:11 -0700 (PDT) Received: from [192.168.0.104] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id r8sm234204lfm.42.2020.09.01.04.55.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 04:55:10 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Stefan Kangas , 43153@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> Date: Tue, 1 Sep 2020 14:55:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 43153 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Hi! On 01.09.2020 13:48, Stefan Kangas wrote: > Severity: wishlist > > Please consider adding a new command `project-find-dir' that works like > `project-find-file' but for directories. Would you like to try your hand at the patch? > I would also suggest to move `project-dired to `C-c p D' and put the new > `project-find-dir' command on `C-c p d'. These key bindings would be in > line with the third-party projectile package. Sounds good to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:32:47 2020 Received: (at 43153) by debbugs.gnu.org; 1 Sep 2020 15:32:47 +0000 Received: from localhost ([127.0.0.1]:56830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8H8-0000ma-SG for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:32:47 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:33993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8H6-0000mN-Nl for 43153@debbugs.gnu.org; Tue, 01 Sep 2020 11:32:45 -0400 Received: by mail-ej1-f47.google.com with SMTP id d26so2310743ejr.1 for <43153@debbugs.gnu.org>; Tue, 01 Sep 2020 08:32:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=L9JywzYi324/8qd+tEquru9aHW262HCovlWUJSdZ8Lo=; b=LT890a5Qqwwluh6+G7LCHrCYBXodQkUW5o6DksEq0OaWqOHYLPTJE+4Uo0A69iY5Tr kCE4XyQRm1yfjMcf9Wjl+dC/j/5etdCN994uZSGpgwOHphqQBgJ0BQavvvht1pEw15Pg 4KBTEwrjB1ySq5poLcOwqEkAiFdEp0hNYBn2d0Ue38nxIbnvBvJVFqO66vM+nfTPX241 kT5u0ys7S9zC/YV23rl2jdJ9pbndTkZkDH2TNjlPfo3d9SPVb2hho5e6Vxvz4fDzY65x UzKryX2Rvk46p2znpVmwTZ3DnepgUW0das+EwCzqaWtS9Fjx4y7FWX6Hfthjw0z6EbNU VSQg== X-Gm-Message-State: AOAM530Gxbat3UtYgZFFtx8gwYynvM4q2FKY7OYZQdoeoKc1+xhVAD+8 SfrLyAx2Y1DLGk01+TwTcLWwer8JPBrGwGmK/Ig= X-Google-Smtp-Source: ABdhPJzrcmttZWw81B+5/HoC9/kWwZwswt09LCGh2Ip0SuepHLff/uXlr9Wl9+ZEYh57c5WfTjSjiE6wTD6kt0IQer4= X-Received: by 2002:a17:906:a84f:: with SMTP id dx15mr1896870ejb.377.1598974358972; Tue, 01 Sep 2020 08:32:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 1 Sep 2020 08:32:38 -0700 From: Stefan Kangas In-Reply-To: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> MIME-Version: 1.0 Date: Tue, 1 Sep 2020 08:32:38 -0700 Message-ID: Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Dmitry Gutov , 43153@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 43153 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > Would you like to try your hand at the patch? A patch!? I have written or two of them before, sure. I could take a gander. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 18:58:09 2020 Received: (at 43153) by debbugs.gnu.org; 3 Sep 2020 22:58:09 +0000 Received: from localhost ([127.0.0.1]:36475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDyBF-000350-0P for submit@debbugs.gnu.org; Thu, 03 Sep 2020 18:58:09 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:40734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDyBD-00034j-R5 for 43153@debbugs.gnu.org; Thu, 03 Sep 2020 18:58:08 -0400 Received: by mail-lj1-f172.google.com with SMTP id s205so5707326lja.7 for <43153@debbugs.gnu.org>; Thu, 03 Sep 2020 15:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aiAhdmHW58pYBfbhknOILkVEUo877QIGucaBaDIHqs8=; b=ND/SOYwtMfi1YxVmaSZvFKUsUqNyx+stVFHu6KlKDhYKYyUbGt/haKRiTwr7lna3d8 sm5i5UQCCILLnBPf0rgqgfY4DkpA+AZ7ZaifvAnjYNAxrNhFBeE7XTOhxCEUI72tusYF h8Pozy9vQrzQi04H6mFOXzCPlp1on3JshyyH+4rzxg+qUBCel7sFSWh0eZyBV399xhdG F9StWEoM0EYPkSchbVFQxcP89aQOCKTc80c8R4B1aLKFLhiIrNBSREkfG7YuThE4kGQC kJWoFu9ZNyoE5YXqDS6jEw8pAs9C9JCPbzYScvCdElCLpzhQtnnFlBdfoznXfwntG+Sp BLLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aiAhdmHW58pYBfbhknOILkVEUo877QIGucaBaDIHqs8=; b=tZcQmO3iXmOf8sl5vdUKUHHWjpgdCbYMLbyYCJbQ2+Wg570iuQjQMqSUuuVtw1C8QA vvLaWjF8viLljLx6iYeSCN0iLGCkqRGktM1eUs+jTLmFOAp5z9jTxSMLQyv4dMDpRIos ACgk8M5scYsKzcwlXbaLm3vARkg+qMJ+6fSnwzUnJ/BXvQvaKnk2bWhHYkf80DZH7/CY E8dW+2BHaffhLhWZUbz4RAWKKHwvHHSerGgVmFYlQ8Wk2WhCSoWZhFiQ/eiDZb2OsDfo XD/dOQFguLPCVbJPqySyoSCWFnp+C4OGlDbsh0MM2xEB2FwO3cguNi1I1zX6rUSKy4kw e3vg== X-Gm-Message-State: AOAM531x/3ZiqNDkRaqD7ZoZYl5eC39NvulK6r1TEH7EVD0S0rz+shwN 4t1+P8/gzf2+xiXU809HwPluZ06f7jM= X-Google-Smtp-Source: ABdhPJwB84XWd/6Oq8KIbFXFQHKgQuk4NSVNl1j+dXjCK6e2kRSS4t/bIGG/BsdmhvW3uj3XaOjOLg== X-Received: by 2002:a2e:b4f5:: with SMTP id s21mr2452584ljm.270.1599173881313; Thu, 03 Sep 2020 15:58:01 -0700 (PDT) Received: from [192.168.0.104] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id t12sm884486lfk.26.2020.09.03.15.58.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2020 15:58:00 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Stefan Kangas , 43153@debbugs.gnu.org References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> From: Dmitry Gutov Message-ID: Date: Fri, 4 Sep 2020 01:57:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 01.09.2020 18:32, Stefan Kangas wrote: > Dmitry Gutov writes: > >> Would you like to try your hand at the patch? > > A patch!? I have written or two of them before, sure. > I could take a gander. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [94.229.108.16 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.172 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.172 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -2.4 NICE_REPLY_A Looks like a legit reply (A) X-Debbugs-Envelope-To: 43153 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) On 01.09.2020 18:32, Stefan Kangas wrote: > Dmitry Gutov writes: > >> Would you like to try your hand at the patch? > > A patch!? I have written or two of them before, sure. > I could take a gander. Excellent. :-) It should be straightforward. One moderately tricky issue is to how to generate a directory completion table from the return value of project-files (which returns only files, not directories). Perhaps the simplest approach is to create a unique set of all parent directories of said files. It would omit empty directories, but oh well. I'm not sure we want to create a new generic function (e.g. project-directories) just for that command, but it's also an option. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 11:34:14 2021 Received: (at 43153) by debbugs.gnu.org; 19 Sep 2021 15:34:14 +0000 Received: from localhost ([127.0.0.1]:39581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRypZ-0007JX-Ux for submit@debbugs.gnu.org; Sun, 19 Sep 2021 11:34:14 -0400 Received: from mail-pg1-f176.google.com ([209.85.215.176]:36541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRypX-0007JH-LC for 43153@debbugs.gnu.org; Sun, 19 Sep 2021 11:34:12 -0400 Received: by mail-pg1-f176.google.com with SMTP id t1so14891959pgv.3 for <43153@debbugs.gnu.org>; Sun, 19 Sep 2021 08:34:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=Ds7GsUcA2RLoqxb/uZZzGidoRL42zyLZ0UplVDbJlXI=; b=xvhmDbu6Ie7/pAvU5h4WavRp/ppftoh3cq7qKSB0rGghZRT/ZpxWh51Ihlg/5DvKKP H6sAsHFliwI0rn+TpnV1j5yEKUQzfWKtNX9zC9TGvp79BRF4v+RTUP0UUjvFrvtgzD0u wWQX8zWmCdz+z91PeBAAuCZsX9FjEa4lhH38+oOb+6fXoCDtM+Un6Op8ynR23yK/QYoC HCCUdKWcUr0nn2WviGQqiLhrIvJBtsQWJw4jJ3zHUfo975MEPNqO/L/W5jvdX4pnaj7P hxiMgESyzarkiqHX8purFrMeROtxqXXKdzMzDpWrbk1Nym/9h3dcyBqeK6w7rGn78we9 rDGA== X-Gm-Message-State: AOAM532T2BJn+I66btWTVunZoH5W9q8QsE+L23kLVDE+JgezzPTOqkDm ve1xBwtg124ni79k3M2xG9PhHriy19AvCxB0gcI= X-Google-Smtp-Source: ABdhPJyV1eX6HQTHnM8LXbV7pcrZI3Iln3B5pb2PL7d32r4T9dglNbjZJ+7nvxotv5OlLOBdFYMOs2GX5kPvTJd0xQE= X-Received: by 2002:a63:a311:: with SMTP id s17mr19200462pge.359.1632065645750; Sun, 19 Sep 2021 08:34:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 08:34:05 -0700 From: Stefan Kangas In-Reply-To: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> (Dmitry Gutov's message of "Tue, 1 Sep 2020 14:55:09 +0300") References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 19 Sep 2021 08:34:05 -0700 Message-ID: Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Dmitry, Dmitry Gutov writes: > On 01.09.2020 13:48, Stefan Kangas wrote: >> Severity: wishlist >> Please consider adding a new command `project-find-dir' that works like >> `project-find-file' but for directories. > > Would you like to try your hand at the patch? > >> I would also suggest to move `project-dired to `C-c p D' and put the new >> `project-find-dir' command on `C-c p d'. These key bindings would be in >> line with the third-party projectile package. > > Sounds good to me. It seems like I won't be able to have time to write this patch before Emacs 28.1. Could we move `project-dired' to `C-x p D' in Emacs 28.1, while awaiting this new keybinding `C-x p d'? Moving it later will be much harder. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 12:44:51 2021 Received: (at 43153) by debbugs.gnu.org; 19 Sep 2021 16:44:51 +0000 Received: from localhost ([127.0.0.1]:39738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRzvu-00057A-QS for submit@debbugs.gnu.org; Sun, 19 Sep 2021 12:44:50 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:57617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRzvt-00056x-9E for 43153@debbugs.gnu.org; Sun, 19 Sep 2021 12:44:49 -0400 Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4245940002; Sun, 19 Sep 2021 16:44:40 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) Organization: LINKOV.NET References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> Date: Sun, 19 Sep 2021 19:40:19 +0300 In-Reply-To: (Stefan Kangas's message of "Sun, 19 Sep 2021 08:34:05 -0700") Message-ID: <87czp4ikng.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Please consider adding a new command `project-find-dir' that works like >>> `project-find-file' but for directories. >> >> Would you like to try your hand at the patch? >> >>> I would also suggest to move `project-dired to `C-c p D' and put the new >>> `project-find-dir' command on `C-c p d'. These key bindings would be in >>> line with the third-party projectile package. >> >> Sounds good to me. > > It seems like I won't be able to have time to write this patch before > Emacs 28.1. > > Could we move `project-dired' to `C-x p D' in Emacs 28.1, while awaiting > this new keybinding `C-x p d'? Moving it later will be much harder. If current `project-dired' actually means "project-root-dired", then it makes sense to bind it to `C-x p D' like `C-x v D' (vc-root-diff). From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 13:23:19 2021 Received: (at 43153) by debbugs.gnu.org; 19 Sep 2021 17:23:19 +0000 Received: from localhost ([127.0.0.1]:39817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS0X9-00021I-AB for submit@debbugs.gnu.org; Sun, 19 Sep 2021 13:23:19 -0400 Received: from mail-pj1-f51.google.com ([209.85.216.51]:56214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS0X6-00020r-W9 for 43153@debbugs.gnu.org; Sun, 19 Sep 2021 13:23:18 -0400 Received: by mail-pj1-f51.google.com with SMTP id t20so10336827pju.5 for <43153@debbugs.gnu.org>; Sun, 19 Sep 2021 10:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=e9q75UsvTu/HDhxM67Xjpfg81Tm5Pv3unro4KJJSpf0=; b=Z7GdAAjPRkgcqFqRjEQjQcIuA1qn9m4FPl6yGdkf80Qojgz4i1bMN/Fd+tnQiPkfL/ I7Np3Y/kE+HsQy+NiBVsMkRbi4BVthmQwprUf0DYb34HW69XDSr4ug6tladXS0mFEfAA CNM4KZ0bUrxwv6W5Jo0gemnYFJeuyCRENgMDwY32YFVYukBDo/W1PvJnzZ9QtwxumdlK Nlcs5RL9JOAE6PNckYM6dcE94RzRLhiE13URplH+HpBrpREUvuh9sC7J5tNb5Ngbj5sP lkBdm11TbUVH+ruXMlpEKn2OM4K3y1iHm4ZntcjQNlx+ch3m0kNhfj6l44hiwYtV6ZY2 /19w== X-Gm-Message-State: AOAM532+g2Yi7O3ZgIRMLKzq5H9j47BISfjsoSb1cxDMo3eYtytBTGei 1P++G+4nFmGQ45PjVAPAOvw/DICyTNBhFOlIp7ad3mYP X-Google-Smtp-Source: ABdhPJzfDUop8apkyslHU8N6xFK++QB2hwE+LN0rDNXbMVbEgMd4XZ4bBgN5vQoo7asbQ5yh2sADMnzYkIPwc/jhko8= X-Received: by 2002:a17:90a:7c42:: with SMTP id e2mr33004066pjl.132.1632072191247; Sun, 19 Sep 2021 10:23:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 10:23:10 -0700 From: Stefan Kangas In-Reply-To: <87czp4ikng.fsf@mail.linkov.net> References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> MIME-Version: 1.0 Date: Sun, 19 Sep 2021 10:23:10 -0700 Message-ID: Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Juri Linkov writes: >> Could we move `project-dired' to `C-x p D' in Emacs 28.1, while awaiting >> this new keybinding `C-x p d'? Moving it later will be much harder. > > If current `project-dired' actually means "project-root-dired", > then it makes sense to bind it to `C-x p D' like `C-x v D' (vc-root-diff). Does it makes sense to rename it, as well? For the sake of completion I mention that the same command is named `projectile-dired' in projectile, where it is bound here to `C-c p D'. I believe you can use whatever prefix you want, though. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 13:36:00 2021 Received: (at 43153) by debbugs.gnu.org; 19 Sep 2021 17:36:00 +0000 Received: from localhost ([127.0.0.1]:39836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS0jP-0002NT-Vv for submit@debbugs.gnu.org; Sun, 19 Sep 2021 13:36:00 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:43011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS0jO-0002NC-6d for 43153@debbugs.gnu.org; Sun, 19 Sep 2021 13:35:59 -0400 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 64A28E0005; Sun, 19 Sep 2021 17:35:49 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) Organization: LINKOV.NET References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> Date: Sun, 19 Sep 2021 20:35:13 +0300 In-Reply-To: (Stefan Kangas's message of "Sun, 19 Sep 2021 10:23:10 -0700") Message-ID: <87h7egfoz2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Could we move `project-dired' to `C-x p D' in Emacs 28.1, while awaiting >>> this new keybinding `C-x p d'? Moving it later will be much harder. >> >> If current `project-dired' actually means "project-root-dired", >> then it makes sense to bind it to `C-x p D' like `C-x v D' (vc-root-diff). > > Does it makes sense to rename it, as well? > > For the sake of completion I mention that the same command is named > `projectile-dired' in projectile, where it is bound here to `C-c p D'. > I believe you can use whatever prefix you want, though. Maybe then better to rename `project-dired' to `project-root-dired', then bind `C-x p D' to `project-root-dired' without the prompt, and bind `project-dired' to `C-x p d' with a prompt that asks for a directory like `C-x p f' (project-find-file). From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 16:42:34 2021 Received: (at 43153) by debbugs.gnu.org; 19 Sep 2021 20:42:34 +0000 Received: from localhost ([127.0.0.1]:40088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS3dy-0007F8-Eq for submit@debbugs.gnu.org; Sun, 19 Sep 2021 16:42:34 -0400 Received: from mail-pj1-f52.google.com ([209.85.216.52]:52798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS3dw-0007Ev-3h for 43153@debbugs.gnu.org; Sun, 19 Sep 2021 16:42:32 -0400 Received: by mail-pj1-f52.google.com with SMTP id v19so10547154pjh.2 for <43153@debbugs.gnu.org>; Sun, 19 Sep 2021 13:42:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=lWrqL8Yiyi5ctnwB3rLhVZPoaAv1B74OzZiFTO8ia4s=; b=DQlvI67d1PKlNrHgs64S8lJGENgnvYhPpW+8xcroEnfPcUPHpPXt7ilvZLUqbq7Nu2 AEavejwYtHBsZ5UieXXclPT6Z49HeOKmEcH1BmR2Cf+u8NxBCNTiyTfSnxig20Z4Nkhh 8WqaAy9tAh4fQnjCRGu/bJQ20XYx3Bd84Cw7xUCHLmebSCt9choXOBTTqrqKR+598kYS NnKK0jBY6oRSP5G9Glal8sDPHI7E7oZGXtD54HPXUv++1WEm6FLlpNRdrkdb9CDe7BCU HRth0Q98w2ZGpBJMGQQN2HQVtKpMvr1F5V28kcKmv53BM2BlTcmfD9hson7N09HhK0+C e6XA== X-Gm-Message-State: AOAM53232UaKRH7/7BwlaXZdxAMY78FDdxgR31eoX4pJ66Wwnbvvtxo0 3rUXOAPbgnzlzoBns3zW+8gBMAK8NRfe77WguvI= X-Google-Smtp-Source: ABdhPJxq9j10YGTNqzQgIzh0HVgAsGSb4Jr6LflEHOqrqR2Rq+7W3v8WmhFBViPL/VG3sqRL/jjiIyJCFjpcAGeF1VI= X-Received: by 2002:a17:90a:7c42:: with SMTP id e2mr33723964pjl.132.1632084146174; Sun, 19 Sep 2021 13:42:26 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 13:42:25 -0700 From: Stefan Kangas In-Reply-To: <87h7egfoz2.fsf@mail.linkov.net> References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> MIME-Version: 1.0 Date: Sun, 19 Sep 2021 13:42:25 -0700 Message-ID: Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Juri Linkov writes: > Maybe then better to rename `project-dired' to `project-root-dired', > then bind `C-x p D' to `project-root-dired' without the prompt, > and bind `project-dired' to `C-x p d' with a prompt that > asks for a directory like `C-x p f' (project-find-file). Agreed. Let's see what Dmitry thinks about it. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 21:35:00 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 01:35:00 +0000 Received: from localhost ([127.0.0.1]:40375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS8Cx-0001mV-Oh for submit@debbugs.gnu.org; Sun, 19 Sep 2021 21:35:00 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:41876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS8Cv-0001mI-Gn for 43153@debbugs.gnu.org; Sun, 19 Sep 2021 21:34:58 -0400 Received: by mail-wr1-f41.google.com with SMTP id w29so25864122wra.8 for <43153@debbugs.gnu.org>; Sun, 19 Sep 2021 18:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dx2I7aKe6lDsEG0VQKVAGADhsSUK37LWv8LJwl4NSFM=; b=OGzP9tnlWIeJKib6DGCldFP8ZzrnrdD1ekzCQ0st296ckSGcN8rX/J56B8VCjVjdrZ HrUi2WmQdQMV/A3oNWA6PuXrTsvjR4e+RrTKo/J0ERUMLAgcVDbmnvmS0JuqMsqfd3fo 6xfB6V3HD22UEJVsQrXX0GY5B0POc4ae1AVJ/dpR7ROyTE1P+RYECF9VHZiNIFS6KouT IekwnJZlCdFpi08+HwoZK/LfNVfwA6PoDBGt1eKnewAvkc80u1zXDW7FpHks3UtMAKwh h7eqmG3dhYeTEtX1bUSrYs2eba110t877cy3k7kCrVoyUgCOLO8zfEO+u7HuMpHilFyR Auaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dx2I7aKe6lDsEG0VQKVAGADhsSUK37LWv8LJwl4NSFM=; b=20NisQ+C+V36AxaXx6Xj9WBTCA/rEILT8GLvdufkc8VXdpU9Lw4x4XAUvWEZ5bCHLM 2NfOHk5kMUUQsQwY67JzAsO741vkjJAt67S71H5OSoH87x7qo2PT+zseBYMHTWO5Czgj HFdrjQSrToq7XY6ULAXK5JvjCbzPY7RENmXaLauS34MnDYx8EggZ3GcpTVZFgFtuQJy7 8x4fCEW0+ncEh2dYwAO170Sl0h+MKijgRITFA8xRvUvkztXKtiEqEBJKEEAQ/UcHLtCj 0utxJRS2n60aqq8i90SoqQ0vXzOOxh9ZJEzIKG9QkxUSWH7462dH50AwMSSbUtiyY03/ 8cxw== X-Gm-Message-State: AOAM532QZs1lwIiE5sC6WdrcUhz3qrcP+a4da64kJGqrlqysY7oRtdeY 6Yn6qF3w9Ipo61Tl9L7QNvGuOq8qDdA= X-Google-Smtp-Source: ABdhPJy1QgDCPq5ZqFfAXfoW2kEn5c0PGTHQIgaOU/e+3lfGOPNfzZ12tUcGVWzKIUG299lr0/2bpg== X-Received: by 2002:adf:cf10:: with SMTP id o16mr24999613wrj.12.1632101691522; Sun, 19 Sep 2021 18:34:51 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v18sm13484269wml.44.2021.09.19.18.34.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Sep 2021 18:34:51 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Stefan Kangas , Juri Linkov References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 20 Sep 2021 04:34:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi all! On 19.09.2021 23:42, Stefan Kangas wrote: > Juri Linkov writes: > >> Maybe then better to rename `project-dired' to `project-root-dired', >> then bind `C-x p D' to `project-root-dired' without the prompt, >> and bind `project-dired' to `C-x p d' with a prompt that >> asks for a directory like `C-x p f' (project-find-file). > Agreed. Let's see what Dmitry thinks about it. Here's a quick implementation of this feature inside project-dired: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 563b9c3c90..3a21cc15a4 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -963,7 +963,18 @@ project--completing-read-strict (defun project-dired () "Start Dired in the current project's root." (interactive) - (dired (project-root (project-current t)))) + (let* ((project (project-current t)) + (all-files (project-files (project-current))) + (completion-ignore-case read-file-name-completion-ignore-case) + ;; FIXME: This misses directories without any files directly + ;; inside. Consider DIRS-ONLY as an argument for + ;; `project-files-filtered', and see + ;; https://stackoverflow.com/a/50685235/615245 for possible + ;; implementation. + (all-dirs (mapcar #'file-name-directory all-files)) + (dir (funcall project-read-file-name-function + "Dired" all-dirs nil nil))) + (dired dir))) ;;;###autoload (defun project-vc-dir () It's a little flawed, but that shouldn't stop us from installing it. Note that the user can simply press RET without typing any directory name and that will launch Dired in the project root. That seems like it might make having a separate command unnecessary, since 'C-x p D' and 'C-x p d RET' take the same number of keypresses. The latter might make you move your hand farther, though. But I don't mind having a separate command if you both think it's a good idea. Then we either call it project-root-dired, and this new one -- just project-dired. Or we move project-dired to 'C-x p D' without changing it, and add this functionality in 'project-find-dir', bound to 'C-x p d'. OTOH, it might make sense to keep 'project-dired' on 'C-x p d' and move project-find-dir to 'C-x p D' because the users of the latter must be prepared to do more typing anyway during completion, so having to also press Shift once won't hurt their efficiency much. But compatibility with Projectile can be important, too. Cast your votes, everybody ;-) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 03:11:06 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 07:11:06 +0000 Received: from localhost ([127.0.0.1]:40856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDSE-0002Qv-HS for submit@debbugs.gnu.org; Mon, 20 Sep 2021 03:11:06 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:61143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDRy-0002P6-MF for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 03:10:51 -0400 Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 90CA740006; Mon, 20 Sep 2021 07:10:43 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) Organization: LINKOV.NET References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> Date: Mon, 20 Sep 2021 09:54:05 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 20 Sep 2021 04:34:43 +0300") Message-ID: <87r1djn3ea.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43153 Cc: Stefan Kangas , 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Here's a quick implementation of this feature inside project-dired: Thanks, I tried it and everything's working as expected. > Note that the user can simply press RET without typing any directory name > and that will launch Dired in the project root. This is a nice feature. > That seems like it might make having a separate command unnecessary, since > 'C-x p D' and 'C-x p d RET' take the same number of keypresses. The latter > might make you move your hand farther, though. We had such discussion about 'C-x v d' where the request was for a command that doesn't require RET. But 'C-x v D' can't be used because it's bound to 'vc-root-diff'. BTW, I have such customization: (define-key project-prefix-map "V" vc-prefix-map) to allow vc commands in a project, e.g. 'C-x p V D' for 'vc-root-diff'. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 03:12:01 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 07:12:01 +0000 Received: from localhost ([127.0.0.1]:40864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDT7-0002Sg-CT for submit@debbugs.gnu.org; Mon, 20 Sep 2021 03:12:01 -0400 Received: from mail-pf1-f170.google.com ([209.85.210.170]:43942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDT5-0002SP-3E for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 03:11:59 -0400 Received: by mail-pf1-f170.google.com with SMTP id c1so12440884pfp.10 for <43153@debbugs.gnu.org>; Mon, 20 Sep 2021 00:11:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=O/1o8N3oNZeRu5jJDr2xVTxh0jPomwG/x1D6p92P56Y=; b=Iwp+TNeIDIytW3rr8eYYDEBIBaVmITaffKn8XT4nDqc45a/+9bpbTw3B2j83xV7JAL OLijag4kd0XsoXqaAl0BfAk2GPZOYptM4toElL/H/qS86sHaX1qKhkVAjYUyregcbZHE LHeImlfeXu99aDhGQW4a2n4YNTScc6C+kwv7DzyFSfbbztjRgOceUZWj2fgZoRPNqhW3 bPI0hnROqt5VoEtwUoJbC6Sy42kDokxUAj7VVITWgOiOZGTKkGhl5y8p834O24hkxdry Oftjc455JnqeMLJ2OPqrJ/vHT8PqFJ0XNDIGUYNc038KMQb8i8VRpzDFTi/5gRfsxuXt MB0Q== X-Gm-Message-State: AOAM530YWoeQb0vVOCOXn8b5Us26fMNxBqiLlHtKaghsTx7YiapGyjU5 jUJw9/Qs+PXdlOURjgWXWwxkfoo4uoAxgRvgvq8= X-Google-Smtp-Source: ABdhPJxSF9s0gR6zb4abZ7VkUcqu8NofxDzDCXiVXnNohgLZHU8aHlVlqpN1IFi3eQo+qttAvAw2bre0v5buyCk5ZV4= X-Received: by 2002:a63:7d5d:: with SMTP id m29mr22058296pgn.114.1632121913178; Mon, 20 Sep 2021 00:11:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Sep 2021 00:11:52 -0700 From: Stefan Kangas In-Reply-To: References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> MIME-Version: 1.0 Date: Mon, 20 Sep 2021 00:11:52 -0700 Message-ID: Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Dmitry Gutov , Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Dmitry Gutov writes: > Here's a quick implementation of this feature inside project-dired: Thanks! I don't currently have time to test it, but I'm sure it is very good. Let me know if you think that testing would be useful, and I'll be glad to help when I can find some time. > OTOH, it might make sense to keep 'project-dired' on 'C-x p d' and move > project-find-dir to 'C-x p D' because the users of the latter must be > prepared to do more typing anyway during completion, so having to also > press Shift once won't hurt their efficiency much. But compatibility > with Projectile can be important, too. > > Cast your votes, everybody ;-) I don't see one way as fundamentally better than the other, so IMHO it's better to just have the same UI as projectile. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 10:31:41 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 14:31:41 +0000 Received: from localhost ([127.0.0.1]:43786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSKKb-0005em-B0 for submit@debbugs.gnu.org; Mon, 20 Sep 2021 10:31:41 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSKKZ-0005ZK-34 for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 10:31:40 -0400 Received: by mail-wr1-f52.google.com with SMTP id i23so30341511wrb.2 for <43153@debbugs.gnu.org>; Mon, 20 Sep 2021 07:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B6dGW8lJPjhZa14Z5hIN9hAxB4OCdsJiveQMTMiu3hE=; b=F3mdVZT2lyYQuXORmG6EP3wvodf7GsHSsLg2M3hpZMAALmsf46AjUPlchUIyuU0TSS B9SSyDB8HcMwe1Oa7GEb1K7upQE4XWP0nklFatuJpkEUizqPnx7MW3bdP1Q0GuFfW6c+ BWBNLFnJmlNd+SgGBTT4skyH4rzrqWEfr+LOngOlEqcgvIvwkvHbzXZ00zLQppoIa6gl JyoEN272puhLQJEJTyeaGzTYdO4G8Bhq0t0m6IMw+MGs4BrJ9YfeOOLqGHPoYcrSfpRD yJOoyUYmsIO5S/0cw7IJhmMDMlV47knHIi9z3CgugcONMAwNKl0i40lgOzurAzVCN4xV BMlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B6dGW8lJPjhZa14Z5hIN9hAxB4OCdsJiveQMTMiu3hE=; b=HHeZ469m04CwchJwA8oRNNWBvMb6uqD7puafDlrimkdWa7AzXlFyfp78zXYkt2pgOc pSImGdUtOUfF6HOWjaf+ox/TSvlYbxyaTu3C4gqiWyCb/I412O6S8IgB8lzJB+1VmaiD ZZHj68nYGqKYYYL/9sa39lf1abX2tHX4Zns6lPYGzNOZS8Owvpd+wfZkrNCZYmFi5u2l oEj2P4yojJxwvXGar6pfhqBk/WCMflR0i8tBKTuiQLzL0av4ve3knYjbFcdTVu3omkIh XBTnojiuGevBD5Zj1SoexF4LaWXDnygZZ0vhNCKr1a+QTyhsDd3UoO3ohxd1FxihqnBF vssQ== X-Gm-Message-State: AOAM531ykV9BQzCKwm4m+TwQABllcwRyuDEerirWmFsoCWzYqSNe2Pwk aCcXqpt/6EP4rVZc+e17wuDmKrdfPkI= X-Google-Smtp-Source: ABdhPJzZHW06bDXkMr8cFA46pP6naR0UIPrG8ugkRK1fusb0yVAgrubrZomg79xzywT5Npyj0S6vKQ== X-Received: by 2002:adf:eec3:: with SMTP id a3mr28955424wrp.276.1632148293153; Mon, 20 Sep 2021 07:31:33 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n7sm2028065wra.37.2021.09.20.07.31.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 07:31:32 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Juri Linkov References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <87r1djn3ea.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <1c06c9eb-0edc-6c3d-8e7b-f6d6ab27f228@yandex.ru> Date: Mon, 20 Sep 2021 17:31:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87r1djn3ea.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 43153 Cc: Stefan Kangas , 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 20.09.2021 09:54, Juri Linkov wrote: >> Here's a quick implementation of this feature inside project-dired: > > Thanks, I tried it and everything's working as expected. > >> Note that the user can simply press RET without typing any directory name >> and that will launch Dired in the project root. > > This is a nice feature. > >> That seems like it might make having a separate command unnecessary, since >> 'C-x p D' and 'C-x p d RET' take the same number of keypresses. The latter >> might make you move your hand farther, though. > > We had such discussion about 'C-x v d' where the request > was for a command that doesn't require RET. But 'C-x v D' > can't be used because it's bound to 'vc-root-diff'. True. > BTW, I have such customization: > > (define-key project-prefix-map "V" vc-prefix-map) > > to allow vc commands in a project, e.g. 'C-x p V D' for 'vc-root-diff'. Hmm. I'm not sure when I'd use it instead of the shorter 'C-x v D'. When you are inside a Git submodule, maybe? It can make a difference. But then you have to be aware that the diff will not include changes in the submodules (just the changed summary hashes). From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 10:34:08 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 14:34:09 +0000 Received: from localhost ([127.0.0.1]:43790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSKMy-0006SE-O0 for submit@debbugs.gnu.org; Mon, 20 Sep 2021 10:34:08 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:36451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSKMw-0006Rm-U6 for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 10:34:07 -0400 Received: by mail-wr1-f45.google.com with SMTP id g16so30336377wrb.3 for <43153@debbugs.gnu.org>; Mon, 20 Sep 2021 07:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rtl85eUOVucAqcuiMcdMDmXP8OzhIkonwpUMsQHyDuo=; b=gWZ7ZO0H5DLwE0q0xQc+A4jC7ofHyE1egS2WZVJb3vjGOOSyJ9JaUr+WN5hu0yO3GO ZcZGR6yk2TXQHjNq9w6/WGf+x5nbO6MXjzecyY7Pi0RRlL9DLNapcYnaMcgOrlkCWbQE XycE9O66RHnxFmdM2lTDFEhJ5fHm0eGuvud8y3sqIpNPkQJhOQ5CrPxRn9nLXwtyRNjT OUC2RULxvqdWjOgPMKv4HV389qNK4Ymnp3slDgyMVe0RDGmYAKGvutlS3O6m6s9aVYyD OpWhCfPbQ2G3XyzjmRGtmjGVv9G5e/87/73VEacGhlFiu1QZA/96kfeCkbh+y78CWvN/ MTgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rtl85eUOVucAqcuiMcdMDmXP8OzhIkonwpUMsQHyDuo=; b=h65aIII8NrJOIIwTXC6oF47fDPR7HibKsRpZJrm9SuhG4/Sp9AjCQt3ZHCC+kmDB1s otAhBqHj7WuRSpKeDc2ZgcN14i8/h6oQ5Q8mZ6JCk1I+HK+oWLx5km/Ul0FC6SML+aBl C22M+HLJO0284Xh0v1k3y2x9Yju5IlIb3VAeYI1nsyLGfkim0qNuwWBsq9i8qdog2hax 9M++V/PeVuZfbDk9ICA7u9QQUZMfwIcuDjaod0MBlsey4Y54zGgRKp9qKXOaBTzxAWda vIXDorF1xfTZYr1Lvcw10zrj+u7vRKO/FATLrWUnHniYQonpA8bL8LKCC4viaiRuBj5v GYIA== X-Gm-Message-State: AOAM531n6eQWGiJO5jk30oZoULMuFWnpp/JNb0IyM1eEikJ6R2HMGfL9 XORTmTPSAr+EQElLbPIcIJvdFLUhj34= X-Google-Smtp-Source: ABdhPJz2BRAA8vAJf04LYWptkLKm8O9lVdVJAcO2eSxf+HR+VxgCTSfam11+w42C1nLQwCwjMWVK7Q== X-Received: by 2002:a7b:c40f:: with SMTP id k15mr29062350wmi.127.1632148441118; Mon, 20 Sep 2021 07:34:01 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q201sm21890130wme.2.2021.09.20.07.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 07:34:00 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Stefan Kangas , Juri Linkov References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <3fcdfac7-8ab9-325c-fd14-c4967c7d0b0e@yandex.ru> Date: Mon, 20 Sep 2021 17:33:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 20.09.2021 10:11, Stefan Kangas wrote: > Dmitry Gutov writes: > >> Here's a quick implementation of this feature inside project-dired: > > Thanks! I don't currently have time to test it, but I'm sure it is very > good. > > Let me know if you think that testing would be useful, and I'll be glad > to help when I can find some time. No, it's all right. It seems functional (though it will likely be more sluggish with medium-large size projects), and the main caveat is already documented. We'll get more testing from the users, too. >> OTOH, it might make sense to keep 'project-dired' on 'C-x p d' and move >> project-find-dir to 'C-x p D' because the users of the latter must be >> prepared to do more typing anyway during completion, so having to also >> press Shift once won't hurt their efficiency much. But compatibility >> with Projectile can be important, too. >> >> Cast your votes, everybody ;-) > > I don't see one way as fundamentally better than the other, so IMHO it's > better to just have the same UI as projectile. OK, that makes sense. Easier transition, etc. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 11:29:10 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 15:29:10 +0000 Received: from localhost ([127.0.0.1]:43862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLEE-0001zM-1w for submit@debbugs.gnu.org; Mon, 20 Sep 2021 11:29:10 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:53331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLED-0001yk-0y for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 11:29:09 -0400 Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A20DDC0012; Mon, 20 Sep 2021 15:29:01 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) Organization: LINKOV.NET References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <87r1djn3ea.fsf@mail.linkov.net> <1c06c9eb-0edc-6c3d-8e7b-f6d6ab27f228@yandex.ru> Date: Mon, 20 Sep 2021 18:17:39 +0300 In-Reply-To: <1c06c9eb-0edc-6c3d-8e7b-f6d6ab27f228@yandex.ru> (Dmitry Gutov's message of "Mon, 20 Sep 2021 17:31:30 +0300") Message-ID: <87mto7nudg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43153 Cc: Stefan Kangas , 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> BTW, I have such customization: >> (define-key project-prefix-map "V" vc-prefix-map) >> to allow vc commands in a project, e.g. 'C-x p V D' for 'vc-root-diff'. > > Hmm. I'm not sure when I'd use it instead of the shorter 'C-x v D'. > > When you are inside a Git submodule, maybe? It can make a difference. But > then you have to be aware that the diff will not include changes in the > submodules (just the changed summary hashes). I meant that 'C-x p V D' can be typed outside of a repository to select a project. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 11:29:47 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 15:29:47 +0000 Received: from localhost ([127.0.0.1]:43865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLEp-00020X-9I for submit@debbugs.gnu.org; Mon, 20 Sep 2021 11:29:47 -0400 Received: from mail-pf1-f171.google.com ([209.85.210.171]:34733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLEo-00020I-4N for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 11:29:46 -0400 Received: by mail-pf1-f171.google.com with SMTP id g14so16641512pfm.1 for <43153@debbugs.gnu.org>; Mon, 20 Sep 2021 08:29:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rsZqYjnDzT+pG4vYiVWzBv8VEfcysa6CpjsG//EMEO4=; b=Iz4veGo086gHAwkhXblpR8Macbx0RhYqaHE77r0JzrFU2krQGhwE8Q3QiGDOkBlxBv lktmbcmMMr4G5BJ5+oZwb5Yd4RjsqhB3wYzRbTM8sqERiaTbr/KaLcVdEHnZPlT/HH3G vC3N2Lw3m4rDqvW5hN03sK2rcx4VF2SBIpJ+/PxZ41Ji7lcOWb2QWzAqYJJHu79HrHVd 0HJHWZemaGDyxCR+590mkqD/NIPSzmbCAR5BkbUceE3NeesZ2d42Tj4u1y1RFZ4n2F90 LfTSa08G/Nq4w66R14mbfsdLKClxhQ3nhBMiPs5u3jj/vkB9a6bc6TrrzkuvCdEvLvSk fogQ== X-Gm-Message-State: AOAM531QXSaUmyDY8sTtUZbOpQnvDRF6lGYKwgfcuNzfEVJa3f+IGHmu sdnA1Wd9tfKU/RvUodUpOvpXRjMgB2w3GHcqEQc= X-Google-Smtp-Source: ABdhPJwHaT6Gd2kURvad3OHLIHYxlvF62LPLUIYB/cWJddCjV79UYEDCDCbnobO3/+L8uGo8W0IM6OhNdDYCp7EV9gs= X-Received: by 2002:a63:f946:: with SMTP id q6mr24025176pgk.42.1632151779371; Mon, 20 Sep 2021 08:29:39 -0700 (PDT) MIME-Version: 1.0 References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <3fcdfac7-8ab9-325c-fd14-c4967c7d0b0e@yandex.ru> In-Reply-To: <3fcdfac7-8ab9-325c-fd14-c4967c7d0b0e@yandex.ru> From: Stefan Kangas Date: Mon, 20 Sep 2021 17:29:27 +0200 Message-ID: Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43153 Cc: 43153@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Dmitry Gutov writes: > > I don't see one way as fundamentally better than the other, so IMHO it's > > better to just have the same UI as projectile. > > OK, that makes sense. Easier transition, etc. Yup, that's my thinking too. (In my use, project does everything I need so while projectile is still installed it goes largely unused these days.) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 11:30:55 2021 Received: (at 43153) by debbugs.gnu.org; 20 Sep 2021 15:30:55 +0000 Received: from localhost ([127.0.0.1]:43870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLFs-00024Y-Ku for submit@debbugs.gnu.org; Mon, 20 Sep 2021 11:30:55 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:37878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSLFr-00024F-0E for 43153@debbugs.gnu.org; Mon, 20 Sep 2021 11:30:51 -0400 Received: by mail-wr1-f41.google.com with SMTP id t8so30873029wrq.4 for <43153@debbugs.gnu.org>; Mon, 20 Sep 2021 08:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GsfeVdlRsAVWcXQKgQSNbQYBjD5WsOosxcXqWuuJCNc=; b=WvaTD60hl08YX+qdZljiqJaRQ3HxMvpqDcQF7ByimEMdyTlWt6Qk052ysG1PuyEZb7 3njTEVi4sDbJvzJMJiR0ZV8E26U4GxkBTVo1mL9Tdy1xgI2svqbdb3DlPz1E+l9R5mCH 6jjtAI+q/Gc7YMvGqekS9NVTQkH8+/ql1+xVF/dft9UhiLRMUgSR4q/WDWLG+YiuvGPr FhE2V8o5LHL+uLBZCi9HlCHbufSpobzMNFp3/O6ML7h7dbMENv7ix7QR1BWqaahIdDXp SZsUh7rcN6YinWO5ocBfw2XjLu0s/3huNDgVMNqxBER895Jg/vqlD1fnCH6cDqudbFhE H/lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GsfeVdlRsAVWcXQKgQSNbQYBjD5WsOosxcXqWuuJCNc=; b=j1hOXdU32pJsbaFMOGWRtE+LnrvBlHCV00SawcQvdAu2jHWDIWpbx1r+IIOoPaXmkj 6KFzKeprlOd5zKwgjyzNh0YsPMxw5euXs/Cy7nmV8HlFM+fEYb4VREHTwZwudv60/JwW tXhp+lUjglw8DrUBMp9HTxM9utWPfy1eje6WXuTEs3HKumYgWJ9sZ1gj9KZq7i9aDqnf +FtilVGpMLRncxPmzkbNQ76uLxBH52niqrHcp4y0xEs8oOd9/FxmQsPUW4VgYoZr9KIB bW14crINu/+515TqrQTqOodZ8QALM5+9cbd1eqRm5zFIpzxKMQn4DiI8KwXTJipoHn0f 6p1w== X-Gm-Message-State: AOAM531uixVwhyVz7ttNvVL0MROXgdYXwcq5U262i/jFmGVaUyjqDVPx uHlTSh/TzNZOonBawjG57bSgjZ3Zbx0= X-Google-Smtp-Source: ABdhPJyv0h2RabmkCMA8nYZuECzOY2zHdYkwECT751PQLfW/Dt4NAKvaQdkVLuT9YjvbC438YCKjuQ== X-Received: by 2002:a05:6000:184e:: with SMTP id c14mr27161911wri.301.1632151845088; Mon, 20 Sep 2021 08:30:45 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id a72sm20435594wme.5.2021.09.20.08.30.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 08:30:44 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Juri Linkov References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <87r1djn3ea.fsf@mail.linkov.net> <1c06c9eb-0edc-6c3d-8e7b-f6d6ab27f228@yandex.ru> <87mto7nudg.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 20 Sep 2021 18:30:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87mto7nudg.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 43153 Cc: Stefan Kangas , 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 20.09.2021 18:17, Juri Linkov wrote: >>> BTW, I have such customization: >>> (define-key project-prefix-map "V" vc-prefix-map) >>> to allow vc commands in a project, e.g. 'C-x p V D' for 'vc-root-diff'. >> Hmm. I'm not sure when I'd use it instead of the shorter 'C-x v D'. >> >> When you are inside a Git submodule, maybe? It can make a difference. But >> then you have to be aware that the diff will not include changes in the >> submodules (just the changed summary hashes). > I meant that 'C-x p V D' can be typed outside of a repository > to select a project. Ah. That should be handy, yes. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 20:57:48 2021 Received: (at 43153-done) by debbugs.gnu.org; 21 Sep 2021 00:57:48 +0000 Received: from localhost ([127.0.0.1]:44352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSU6N-0005dM-3x for submit@debbugs.gnu.org; Mon, 20 Sep 2021 20:57:48 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:41818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSU6L-0005d4-Kt for 43153-done@debbugs.gnu.org; Mon, 20 Sep 2021 20:57:38 -0400 Received: by mail-wr1-f41.google.com with SMTP id w29so34433335wra.8 for <43153-done@debbugs.gnu.org>; Mon, 20 Sep 2021 17:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wn8/AMtVpVuoZsmXLf4guERhcnXPSFAYZZVfvaLaVss=; b=GoYDjFyQsq9dJj2JfSg4uGQs8CUos8LCmf4GYBmlcP6ovT1nNDYchrd6++LfTn0X3T i4SIR9MWQNtvKilnPCTMgJsglrY1SbUn2mPpiQzuJ6ZmLuoEBnjWlP7ePELA6Jpvq0X3 sYwu5ISg5WFkSIu+LJbe8fOJCWSYZNDgmC8mhDN/dpMJDdHvxh0p+AQOYuSnS4AjhXTF 0ROB9PUtwSMf0VojS+xKoO4UMA77xZysVsBKtamiO63Ro99wMP6r7pZDQJBhKVrNiEx2 LEvrsgB3/iWqcYfwD1h6+p4e2o04ZJD1f2Zzh+KtusJeI+bKCOVkZXvF0xoN7ONrLYto 387Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wn8/AMtVpVuoZsmXLf4guERhcnXPSFAYZZVfvaLaVss=; b=ZnPW2CVzq+1yne5H9hZH9/JvmmPTJm9jtzojY2as5ZRQsmp9z+N7iRMxUWOMHGgrdV CYx3dRthWAwWy+J0goCELfh5aPQMHDZoQ5QWkBwSIaytHatzipcitI+nRC4RFZMH/eXg h60RWMzlWO95fV8xdAMtGd40yYbl95azucC6jReWwyLQpl8G6o++jZe4Ue/ZbH1v05yK 1y0zfOl42z19CEDzjb//6CmCqxto9KXGJk7hjqO8srp7FSujMlkq1GF0XXwzVd/+jDoL CnzzS4x1Umm42LhsIrLwHRdLibf3LiELVEppW2b+dUk75b5nJRVZ2nlr+fZBB+LQI0Xw D05Q== X-Gm-Message-State: AOAM533L/PmhWWLqB/ra8jQJjpLtcqHjEn3SwDVcTWc5Sa15TABwZi/A AvQQFDu56mqApRA5hz4jhN2dqk0R62A= X-Google-Smtp-Source: ABdhPJylsgP7fcDVqOBrCx1lZ2emW5nOqwFGGytjes4x3URxovHBXgCiUw+EF6qZZi/g3remXfF70Q== X-Received: by 2002:a1c:f713:: with SMTP id v19mr1660712wmh.188.1632185851602; Mon, 20 Sep 2021 17:57:31 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i67sm1234687wmi.41.2021.09.20.17.57.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 17:57:30 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Stefan Kangas References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <3fcdfac7-8ab9-325c-fd14-c4967c7d0b0e@yandex.ru> From: Dmitry Gutov Message-ID: <469d1164-3469-e8a7-ec45-430dea761381@yandex.ru> Date: Tue, 21 Sep 2021 03:57:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 43153-done Cc: 43153-done@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Version: 28.1 On 20.09.2021 18:29, Stefan Kangas wrote: > Dmitry Gutov writes: > >>> I don't see one way as fundamentally better than the other, so IMHO it's >>> better to just have the same UI as projectile. >> >> OK, that makes sense. Easier transition, etc. > > Yup, that's my thinking too. Now installed with commit df1d4f5894. > (In my use, project does everything I need so while projectile is > still installed it goes largely unused these days.) Good to hear ;-) But as far as missing pieces go, I think people are still asking for https://debbugs.gnu.org/41572, in some shape or form. Emacs 28 probably should have a solution for it. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 13:32:15 2021 Received: (at 43153) by debbugs.gnu.org; 21 Sep 2021 17:32:15 +0000 Received: from localhost ([127.0.0.1]:47885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSjct-0002zb-BW for submit@debbugs.gnu.org; Tue, 21 Sep 2021 13:32:15 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:34193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSjcr-0002t1-Fn for 43153@debbugs.gnu.org; Tue, 21 Sep 2021 13:32:14 -0400 Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id D3FA2240002; Tue, 21 Sep 2021 17:32:05 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) Organization: LINKOV.NET References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <87r1djn3ea.fsf@mail.linkov.net> <1c06c9eb-0edc-6c3d-8e7b-f6d6ab27f228@yandex.ru> <87mto7nudg.fsf@mail.linkov.net> Date: Tue, 21 Sep 2021 20:29:39 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 20 Sep 2021 18:30:41 +0300") Message-ID: <87bl4l26dw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43153 Cc: Stefan Kangas , 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>> BTW, I have such customization: >>>> (define-key project-prefix-map "V" vc-prefix-map) >>>> to allow vc commands in a project, e.g. 'C-x p V D' for 'vc-root-diff'. >>> Hmm. I'm not sure when I'd use it instead of the shorter 'C-x v D'. >>> >>> When you are inside a Git submodule, maybe? It can make a difference. But >>> then you have to be aware that the diff will not include changes in the >>> submodules (just the changed summary hashes). >> I meant that 'C-x p V D' can be typed outside of a repository >> to select a project. > > Ah. That should be handy, yes. But like there is the binding 'C-x v d' to 'vc-dir' wouldn't it better to provide the same for project? Then 'C-x p v d' could use 'project-vc-dir', and other 'C-x v' bindings will be available under 'C-x p v'. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 13:49:39 2021 Received: (at 43153) by debbugs.gnu.org; 21 Sep 2021 17:49:39 +0000 Received: from localhost ([127.0.0.1]:47896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSjtj-0005uZ-EH for submit@debbugs.gnu.org; Tue, 21 Sep 2021 13:49:39 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:43562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSjth-0005uJ-Pa for 43153@debbugs.gnu.org; Tue, 21 Sep 2021 13:49:38 -0400 Received: by mail-wr1-f43.google.com with SMTP id w17so33592818wrv.10 for <43153@debbugs.gnu.org>; Tue, 21 Sep 2021 10:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8XiaOlOPPaHOL0nEn3qDU8pTAcX6qlihbSe6JjligKM=; b=YzRvIdQgHRCzznSjiQScxyqqGLm4h8bO9Uo3V1fC8y68mMsTUvR5oCeQyCE/Q1f6PH yWdupCzLWSrzjYs1Z/3jv1DUD5NDlFJfeb4XNmqYxlC4Z36p5Oilbucjd1zjFE95IPOg dm4TDdSkWhZbTGvh2/4KcIKJVTKqzAmV1USa4yG/hLfg73uELfPHXcQCCfARO4nW+Lpr bH6ESKD38f6j8LvIf1BoX6VIRKnTiOsODagKWI6exlZpc6MHh8SQFQQS7L7+OrKhIxtY yh8AniUisjpw7CMSw1mKXWxA9YzP3OnoZh3EvvlzvCSxbBi9+KOkyTau76/p2Qz1ElXF ov8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8XiaOlOPPaHOL0nEn3qDU8pTAcX6qlihbSe6JjligKM=; b=sdFw6YTe0ARprO6n1k6sFPkQyC6bBaUn79Ui797JhcG9HKvsEOi1ONiLaFX7e3U+lv hDXb98gEmOExLDb9wXDqBJCRQQ8rhpBqgBF2hU0Lyt3N755ZhWbDoDvXLapfIRsAHzMT F0CkrFgLoSnp/wZBB7KmNz8b1E0RZOpOg/bZHfn68Lcb3r9bP3qDRoZRcBSqrejeBvwf OOtppGI7SreevPJRYAC8u1GF2pfSzXwpqbh49fnrfbiQttNLq0oCuhb/5fuguHF3zATt K4ThdAHf5d5wqynfdG3r2bk/980YjeSQcUox+zgwLvB9vSvQxjGWu4aLx3i197Id11JR 8KOg== X-Gm-Message-State: AOAM533jnNccRG8qWDjlc87In8/l3JliJmDCpaQk1liXyHbUu7FVNoPT HF349Sd377So611D/hWjGqmLFTfEUeU= X-Google-Smtp-Source: ABdhPJwtu1RKSOdzU76TwAoxY+COt77UNiHlPmJTQuHo6I9sSZMEz7nPWiDWrY5cH9HH3QtLWN5qDg== X-Received: by 2002:a5d:688f:: with SMTP id h15mr36239348wru.410.1632246571889; Tue, 21 Sep 2021 10:49:31 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id a202sm3871655wmd.15.2021.09.21.10.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 10:49:31 -0700 (PDT) Subject: Re: bug#43153: Add new command project-find-dir (and move binding of project-dired) To: Juri Linkov References: <3071f53f-4334-6ed6-e69e-b49122492a1b@yandex.ru> <87czp4ikng.fsf@mail.linkov.net> <87h7egfoz2.fsf@mail.linkov.net> <87r1djn3ea.fsf@mail.linkov.net> <1c06c9eb-0edc-6c3d-8e7b-f6d6ab27f228@yandex.ru> <87mto7nudg.fsf@mail.linkov.net> <87bl4l26dw.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <1d70d0dd-ff94-cbfe-0cd2-d7b5dc3209e0@yandex.ru> Date: Tue, 21 Sep 2021 20:49:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87bl4l26dw.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 43153 Cc: Stefan Kangas , 43153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 21.09.2021 20:29, Juri Linkov wrote: >>>>> BTW, I have such customization: >>>>> (define-key project-prefix-map "V" vc-prefix-map) >>>>> to allow vc commands in a project, e.g. 'C-x p V D' for 'vc-root-diff'. >>>> Hmm. I'm not sure when I'd use it instead of the shorter 'C-x v D'. >>>> >>>> When you are inside a Git submodule, maybe? It can make a difference. But >>>> then you have to be aware that the diff will not include changes in the >>>> submodules (just the changed summary hashes). >>> I meant that 'C-x p V D' can be typed outside of a repository >>> to select a project. >> Ah. That should be handy, yes. > But like there is the binding 'C-x v d' to 'vc-dir' > wouldn't it better to provide the same for project? > Then 'C-x p v d' could use 'project-vc-dir', and > other 'C-x v' bindings will be available under 'C-x p v'. Don't we mostly have that already? 'C-x p v D' will get you vc-diff for the project, 'C-x p v L' will get you vc-print-root-log, 'C-x p v B' gets you branch commands, and so on. From unknown Sun Jun 15 08:42:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Oct 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator