From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 17:06:48 2020 Received: (at submit) by debbugs.gnu.org; 30 Aug 2020 21:06:48 +0000 Received: from localhost ([127.0.0.1]:50869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCUXH-0007Qa-TS for submit@debbugs.gnu.org; Sun, 30 Aug 2020 17:06:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:37862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCUXG-0007QT-Ki for submit@debbugs.gnu.org; Sun, 30 Aug 2020 17:06:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCUXG-0006od-FD for guix-patches@gnu.org; Sun, 30 Aug 2020 17:06:46 -0400 Received: from [67.214.175.87] (port=58124 helo=vpn.dnsexit.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCUXE-0006xd-Ta for guix-patches@gnu.org; Sun, 30 Aug 2020 17:06:46 -0400 Received: from mail.dnsexit.com (box2 [67.214.175.80]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by vpn.dnsexit.com (Postfix) with ESMTPS id 7CA2960843 for ; Sun, 30 Aug 2020 17:06:48 -0400 (EDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.dnsexit.com (Postfix) with ESMTP id 3AB543C1554 for ; Sun, 30 Aug 2020 17:06:35 -0400 (EDT) X-Virus-Scanned: amavisd-new at dnsexit.com Received: from mail.dnsexit.com ([127.0.0.1]) by localhost (box2.dnsexit.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P-BAeEEZDlDw; Sun, 30 Aug 2020 17:06:35 -0400 (EDT) Received: from localhost.localdomain (greenrd.plus.com [212.159.116.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.dnsexit.com (Postfix) with ESMTPSA id 4B8F23C1556; Sun, 30 Aug 2020 17:06:34 -0400 (EDT) From: Robin Green To: guix-patches@gnu.org Subject: [PATCH] guix: packages: Fix print-content-hash Date: Sun, 30 Aug 2020 22:05:59 +0100 Message-Id: <20200830210559.6344-1-greenrd@greenrd.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 67.214.175.87 (failed) Received-SPF: pass client-ip=67.214.175.87; envelope-from=greenrd@greenrd.org; helo=vpn.dnsexit.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/30 17:06:40 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SBL_CSS=3.335, RCVD_IN_XBL=0.375, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/packages.scm (print-content-hash): Prevent throwing an exception for linux-libre and breaking backtraces. --- guix/packages.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/packages.scm b/guix/packages.scm index 95d7c2cc0d..c5a971b7b7 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -228,7 +228,8 @@ as base32. Otherwise, it must be a bytevector [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [67.214.175.87 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: submit Cc: Robin Green X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/packages.scm (print-content-hash): Prevent throwing an exception for linux-libre and breaking backtraces. --- guix/packages.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/packages.scm b/guix/packages.scm index 95d7c2cc0d..c5a971b7b7 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -228,7 +228,8 @@ as base32. Otherwise, it must be a bytevector [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [67.214.175.87 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * guix/packages.scm (print-content-hash): Prevent throwing an exception for linux-libre and breaking backtraces. --- guix/packages.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/packages.scm b/guix/packages.scm index 95d7c2cc0d..c5a971b7b7 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -228,7 +228,8 @@ as base32. Otherwise, it must be a bytevector." (define (print-content-hash hash port) (format port "#" (content-hash-algorithm hash) - (bytevector->nix-base32-string (content-hash-value hash)))) + (false-if-exception + (bytevector->nix-base32-string (content-hash-value hash))))) (set-record-type-printer! print-content-hash) -- 2.27.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 09:53:35 2020 Received: (at 43121-done) by debbugs.gnu.org; 31 Aug 2020 13:53:35 +0000 Received: from localhost ([127.0.0.1]:51853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCkFb-0007JK-2P for submit@debbugs.gnu.org; Mon, 31 Aug 2020 09:53:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCkFZ-0007J6-7l for 43121-done@debbugs.gnu.org; Mon, 31 Aug 2020 09:53:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56430) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCkFT-0004EA-CF; Mon, 31 Aug 2020 09:53:27 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36324 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCkFS-0007LX-VH; Mon, 31 Aug 2020 09:53:27 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Robin Green Subject: Re: [bug#43121] [PATCH] guix: packages: Fix print-content-hash References: <20200830210559.6344-1-greenrd@greenrd.org> Date: Mon, 31 Aug 2020 15:53:26 +0200 In-Reply-To: <20200830210559.6344-1-greenrd@greenrd.org> (Robin Green's message of "Sun, 30 Aug 2020 22:05:59 +0100") Message-ID: <87wo1ec46h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43121-done Cc: 43121-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Robin, Robin Green skribis: > * guix/packages.scm (print-content-hash): Prevent throwing an exception f= or > linux-libre and breaking backtraces. > --- > guix/packages.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/guix/packages.scm b/guix/packages.scm > index 95d7c2cc0d..c5a971b7b7 100644 > --- a/guix/packages.scm > +++ b/guix/packages.scm > @@ -228,7 +228,8 @@ as base32. Otherwise, it must be a bytevector." > (define (print-content-hash hash port) > (format port "#" > (content-hash-algorithm hash) > - (bytevector->nix-base32-string (content-hash-value hash)))) > + (false-if-exception > + (bytevector->nix-base32-string (content-hash-value hash))))) >=20=20 > (set-record-type-printer! print-content-hash) I pushed something different with the same effect as 83ec969cc7170634872d4ff3ffc0d4099a6765a4 (avoiding =E2=80=98false-if-except= ion=E2=80=99, which is too broad IMO). Thanks! Ludo=E2=80=99. From unknown Mon Aug 18 14:24:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Sep 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator