GNU bug report logs - #43120
28.0.50; fido-mode: M-j before completions appear selects wrong choice

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Sun, 30 Aug 2020 21:01:01 UTC

Severity: normal

Tags: fixed

Merged with 43083

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: OGAWA Hirofumi <hirofumi <at> mail.parknet.co.jp>
Cc: 19032 <at> debbugs.gnu.org, 43120 <at> debbugs.gnu.org, João Távora <joaotavora <at> gmail.com>, Lars Ingebrigtsen <larsi <at> gnus.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice
Date: Wed, 09 Sep 2020 21:58:03 +0300
>> +(defun icomplete-ret ()
>> +  "Exit minibuffer for icomplete."
>> +  (interactive)
>> +  (if (and icomplete-show-matches-on-no-input
>> +           (car completion-all-sorted-completions)
>> +           (eql (icomplete--field-end) (icomplete--field-beg)))
>> +      (icomplete-force-complete-and-exit)
>> +    (exit-minibuffer)))
>
> This changed the behavior of RET from `minibuffer-complete-and-exit' to
> `exit-minibuffer'. Was that intention? What I noticed is the following.

I confirm that this change broke icomplete-mode.  Here is a test case
that shows regression:

M-x icomplete-mode RET
M-x rgr RET

  Lisp error: (error "‘rgr’ is not a valid command name")

Until yesterday it used to run 'rgrep'.




This bug report was last modified 4 years and 311 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.