From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 17:00:14 2020 Received: (at submit) by debbugs.gnu.org; 30 Aug 2020 21:00:14 +0000 Received: from localhost ([127.0.0.1]:50857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCUQv-0007HJ-VV for submit@debbugs.gnu.org; Sun, 30 Aug 2020 17:00:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:33626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCUQv-0007HC-5d for submit@debbugs.gnu.org; Sun, 30 Aug 2020 17:00:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCUQu-0004in-Nh for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 17:00:12 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCUQs-00069d-An for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 17:00:12 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3D9885C00EB for ; Sun, 30 Aug 2020 17:00:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 30 Aug 2020 17:00:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=IbIN7mtgj0qZEbcfLyb20wtRNkEYpByjKm1lIsUJQ/Q=; b=jWGIQt17 9sVrlIQZoNvGHQ2KSgj69Sm4wfH2LngiaYd7MS9tO9MPASRWECXyjF6kgSl3TdIM zUsjKEmjQhP5ARMUrP9YkgTTGK6r4e1v7IhUTe2NqUgpH1OfIniwOqs6TZ1i7/ty Qudi7ms8JMaAvh2lDy5vamjyaZ+WiEy9AOGy/bHy1aAiYJ4s4nHBlKteNzNQfGM4 K6LnSoTBlcOln3vW3zmME2fbyY8XycDGfrT+YVggMRcxGWFNIS1TZUjQSq/YtpcU CyVAKf8bv2R3CVSubP5OB6MxXWITXThSj27TY6was6cMDgDdvIroc4NyvhYHKfHX uZ43ZfjxOyup9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=IbIN7mtgj0qZEbcfLyb20wtRNkEYp ByjKm1lIsUJQ/Q=; b=AlnH7gdKhKcH49hIay312IB2gslLVAuo39Z7shlzCl+ql T7XJftPziqKMSWzQvVbdhy+TUGz5P9xJqK8NnhdoULkrC40EElsIDOrXMScSxKOK Sl+mcMUp9RUwPIVy2jy6oZsBxjR9wLKE9xkrFzljOpyjd6uWHAMqjjmNMMup0qWz e9H2bylRVxpTMR5p2mn8fq/U/TsnE21RxTcoUWx7arst2sUn3XeqYTVe1etnKQyF l0xE61Fqx9wLwpJzcbJbFXjSLi+Yd90M4SSNLKbQ6uoF4Wc3t4qxp6bPagRzbrb/ EvTD5y+39yMAJFJZ8vlkqaMjS5TBztWwIpHVzpp+w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeffedgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesthdtredttd dttdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhp fihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeelleegjeehvdehgeehgf efgedvhfdvfefffeehjedtgeefheffiedtfeetjeeuheenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhith htohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 28.0.50; fido-mode: M-j before completions appear selects wrong choice X-debbugs-cc: larsi@gnus.org, joaotavora@gmail.com Date: Sun, 30 Aug 2020 14:00:03 -0700 Message-ID: <8736433l4c.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.28; envelope-from=spwhitton@spwhitton.name; helo=out4-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/30 14:08:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hello, The recent change to fix #19032 has broken my fido-mode workflow in a way which I think reveals a bug. When starting from an empty minibuffer, icomplete-fido-exit now selects a different match depending on whether the completions have appeared yet. So if you hit keys fast enough then you get different behaviour than if you hit them a bit slower. For example: 1. emacs -q 2. M-x fido-mode RET 3. C-x b foo M-j (type slowly) 4. C-x b bar M-j (type slowly) 5. C-x b M-j (type quickly) This will take you to *GNU Emacs* but it should take you to foo (the minibuffer prompt is "Switch to buffer (default foo)"). If you wait for the completions to appear before hitting M-j, you go to the right place. I think the fix would be to clear completion-content-when-empty when the minibuffer exits, instead of leaving data from the last completion there. Or possibly M-j should call icomplete-completions to popular completion-content-when-empty with the correct information. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 19:50:21 2020 Received: (at 43120) by debbugs.gnu.org; 30 Aug 2020 23:50:21 +0000 Received: from localhost ([127.0.0.1]:50971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCX5Z-0002hP-7F for submit@debbugs.gnu.org; Sun, 30 Aug 2020 19:50:21 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:38313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCX5X-0002h2-9S for 43120@debbugs.gnu.org; Sun, 30 Aug 2020 19:50:20 -0400 Received: by mail-wm1-f43.google.com with SMTP id t14so3739538wmi.3 for <43120@debbugs.gnu.org>; Sun, 30 Aug 2020 16:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HwIoDTkuuFof3mpyiOzGQs/SfeJnHlLhwUJ+30Egbus=; b=YXLS73eTpIlZcG8cVFdIoI9JvlymQPnxv90RjThe0RLl7MidnxaHseGUzTcenmorgM qC+93CghBgJ0I4pw9GFNgFUo/4n5UKeAy1/KF9Rv7r3F5yfTA8QUkLjEXqIU0i/8OHXK E31anID6LjxvkiX+YhgeBVgeaxs3qXKZkRkcgdk/ZNtorV7Rf1ffZh5wFqrUQk/QdmOx 3veId6XsVUjjcYh5Sk5SkROQeCGUL9j1G3NXFVLu/ncEVFrb2WYVISG6T7kl0O3ERdPw MMu+zA5cvYnl5oMyQpQcqd+zS+L17An0u9g3ECo411H99+87ycHiMqTC0yw5AO6Eq1IP K3Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HwIoDTkuuFof3mpyiOzGQs/SfeJnHlLhwUJ+30Egbus=; b=DLAkQ7ayZKOqffGi2UzHzZrXz9YNGqFuFw5GvMhSxc2slWNZQnDiVkFGtDaGftF+6k LXUYMlqvhTCyQDcMEwUj9nwwBcmi8tqw2DgcPH8+drqg1vtaZe3wolBPWSuT3HDtyONz LBvbXDw+2NMvgSY9srO5LHKKzj+DjabG/poDyy15iQRRXdSCH2MqidlqnVX7YkN4e1aM 6Z3Wnzj1RlRCL+mn4SN7mBatUR9a8y2B0Q/oV4oDhPfKeZN2mVvHZxR4WlDMJZRkAyax /WvEQ4KG4S6hzpt4h+gq1ezBoV1nGdr7Fph+7JkVReiAfOQZD3r4EBP/s2dzo3pWIGF/ mYvQ== X-Gm-Message-State: AOAM530P/YbspWLkTvhO15hGWS4h6V+TOJ58d3A3pHURtLm3OBKHOvAu mI0TayQ8t+rcRZSzMDBQ4TU= X-Google-Smtp-Source: ABdhPJwT6GZk10WxnlC41ODLeDG9KDn/pz+AOUD5fff9QTUIp0sX3KcnoSvo5ON2VrcutC1REGK39g== X-Received: by 2002:a1c:62d4:: with SMTP id w203mr3647826wmb.146.1598831413217; Sun, 30 Aug 2020 16:50:13 -0700 (PDT) Received: from krug (173.37.158.5.rev.vodafone.pt. [5.158.37.173]) by smtp.gmail.com with ESMTPSA id c205sm8919845wmd.33.2020.08.30.16.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 16:50:12 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Sean Whitton Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> Date: Mon, 31 Aug 2020 00:50:10 +0100 In-Reply-To: <8736433l4c.fsf@iris.silentflame.com> (Sean Whitton's message of "Sun, 30 Aug 2020 14:00:03 -0700") Message-ID: <87zh6bhex9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: larsi@gnus.org, 43120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > For example: > > 1. emacs -q > 2. M-x fido-mode RET > 3. C-x b foo M-j (type slowly) > 4. C-x b bar M-j (type slowly) > 5. C-x b M-j (type quickly) This sounds like a bug, indeed. I dealt with this kind of problem in the past and worked hard to mitigate it. I was unware of this recent patch to icomplete/fido-mode, sorry. I will note that the problem doesn't seem to happen if step 5 ends with RET instead of M-j. M-j in the fido-mode minibuffer is bound to icomplete-fido-exit which does have have an optional FORCE arg, which could maybe justify the behaviour you're observing. But anyway it's nil by default, so it doesn't. > I think the fix would be to clear completion-content-when-empty when the > minibuffer exits, instead of leaving data from the last completion > there. Or possibly M-j should call icomplete-completions to popular > completion-content-when-empty with the correct information. I don't understand the reason of being for the patch. I didn't read the bug, but I do read this in NEWS: +*** 'icomplete-show-matches-on-no-input' behavior change +Previously, choosing a different completion with commands like 'C-.' +and then hitting enter would choose the default completion. Doung +this will now choose the completion under point. Now, I have never observed this reported behaviour in fido-mode even before the patch. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 12:37:19 2020 Received: (at 43120) by debbugs.gnu.org; 31 Aug 2020 16:37:19 +0000 Received: from localhost ([127.0.0.1]:53535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCmo3-0005U8-Df for submit@debbugs.gnu.org; Mon, 31 Aug 2020 12:37:19 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCmo1-0005Ts-9L for 43120@debbugs.gnu.org; Mon, 31 Aug 2020 12:37:18 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B4C095C019D; Mon, 31 Aug 2020 12:37:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 31 Aug 2020 12:37:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=fm1; bh= eFxfEVbfI85O1DbXXMPgnJD5lAnmq3L+T1wIdNROI54=; b=R1CLoM37dsq9599l U1ewIJ5VVIMETYl5cdVnrcndEPMG3xy8bSLejX2RKzkT92flrZgezqPFt63J22Pn x3/CStOnfVpJW22//TnLPGD+gjMjotsuaUzs6MiVZKZK1ZtNLoURcXSZ+aEvumhw fBGq/wF+RP9g3hihlcZD7gkb20MUUc03vYZXTOo8xiX6mRKEvXRtDX165zm8wQAi 4tRvEtxmnFyZmiG84uz1VXPAbjfe+16qnFk8zKnmqH3o3Tpzzfd4C2R3VRbDGRKi 5ywPEDkxxeI+qIrcxX12lCLpOVxVBmFkFRlMHnsahLnWgLi0rtgT4VZ43RkeYXuH Twr/2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=eFxfEVbfI85O1DbXXMPgnJD5lAnmq3L+T1wIdNROI 54=; b=UYGHB08oofTLKeAmKgIdQhcyXpPHhw/OD31Or0AUD5CMFOZ2BSs/TR6Tz GSOd+2hVzkRCYdLiaoUAlv1v0qxOjwqAjQurg2PNBRiJltmDPa0bYjiDNr9b1Vcm OuXTZlYe2707rSJ9Ptw9sOc0pNqhZZeiaesffiOIdK5zC9e+PRcuJwhgKfX6bGi8 WoNV2K6SQHyuj/S2h3hQPreNw1UXuPBWN01zpuMiKRmTi7999bFdDD2dG9jF+UZZ F/bNdPjg0hOYFXJL7iaIaR9717h4YRgKg+c9kayIZHT+dsZoABNlUyY81vmgxfdA t+Vy1UVPV/C+P3NVlKh4nJ8ILh5Aw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefhedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkgggtgfesthhqredttddtjeenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedvgfekvedtteevvdfhhfegveelleefkeevueevheffuddv ieduhfegleevgffhheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice In-Reply-To: <87zh6bhex9.fsf@gmail.com> References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> Date: Mon, 31 Aug 2020 09:37:08 -0700 Message-ID: <87zh6a22mj.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: larsi@gnus.org, 43120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Jo=C3=A3o, On Mon 31 Aug 2020 at 12:50AM +01, Jo=C3=A3o T=C3=A1vora wrote: > Sean Whitton writes: > >> For example: >> >> 1. emacs -q >> 2. M-x fido-mode RET >> 3. C-x b foo M-j (type slowly) >> 4. C-x b bar M-j (type slowly) >> 5. C-x b M-j (type quickly) > > This sounds like a bug, indeed. I dealt with this kind of problem in > the past and worked hard to mitigate it. I was unware of this recent > patch to icomplete/fido-mode, sorry. > > I will note that the problem doesn't seem to happen if step 5 ends with > RET instead of M-j. M-j in the fido-mode minibuffer is bound to > icomplete-fido-exit which does have have an optional FORCE arg, which > could maybe justify the behaviour you're observing. But anyway it's nil > by default, so it doesn't. Right. I actually have icomplete-fido-exit bound to RET because that means that RET in any minibuffer always exits with the current input, which I find makes completion less obstrusive. But this bug is breaking that atm. --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 10:16:55 2020 Received: (at 43120) by debbugs.gnu.org; 1 Sep 2020 14:16:55 +0000 Received: from localhost ([127.0.0.1]:56630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD75j-0002ly-3T for submit@debbugs.gnu.org; Tue, 01 Sep 2020 10:16:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD75g-0002li-Pl for 43120@debbugs.gnu.org; Tue, 01 Sep 2020 10:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+lTW6xQvgXnAzD04BK3I4Aq3TWN99FVRfavc7EuPf4c=; b=pvmptEgqwQrJaDqrZmSiVJGlq0 62uS8kO0NrjKJc7HceJegH1bVP0GFhV1ZH6eRkTHUIH68iDlE5gBTQT5sDM3fyawiRD+w33WvUUPv Q1Dh4zCqiArZXtTdQL7w2zfe5+3DkVoKmx/+coTwJg9lEjVnUjB4aGAuD/41JYG+dWcI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD75Y-0002JS-AA; Tue, 01 Sep 2020 16:16:46 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEWNcHFWLTE3ChCt k5Lby8YfAAD///+vu6zwAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QJAQ4MKok9XfAAAAG3SURBVDjL dZRLltwgDEWFwXPAVXNQl+fQsACfoAVUnJP9byVgwJ92hYEHujxJ6GMAAI3Xo6CcEIJjF7tkaJUq IIQzsUxFSlRBGA4ATCQmXQNujyNhWrSlrjicgUyzoZA6CE1iJIyGKABQ/pbjN/sMXCkilrOiTjaJ BW9F0qvVG0h7FAPPB33b8kDqElfAFyAFxbK6gtR9SfYVFjaX7PguKY90o4ibHeGvFU2S8zJc0bLW 9yCusUpyEClfqVUnA3w3XxqZj4s+wByrr8EqRw4PgK8GjI3Jn4Gtvrx5096ADcwNqD8pjhcgGngt vcoV4KPmO4gl4AW8KhiDd+sHwDV5/xEocv8DweOn4JL4FbR0nYzTD9AeKMWUGzx8KMlUXJ1AL+Ib eDiDveyGR6lRXRpVgDaPyEY099YaQ78U2udpGLbY+S6l37nBGzgGa8iA06DQlNJXe5sFgxMttkoO QZ4Cq02i7yo5ZrcUY0AeSasZGjhG9zmBSJJZtkK3+7oexrlsWTiDGM57axnPZclX9x3s5bYy+bwA id/WGU1yxT/82OZCuLc83X8Z2Z0IEOFuL2nzkAEovB/1DziVspmDzhX9AAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIwLTA5LTAxVDE0OjEyOjQyKzAwOjAw96/xcAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy MC0wOS0wMVQxNDoxMjo0MiswMDowMIbyScwAAAAASUVORK5CYII= X-Now-Playing: Riow Aral's _Beat Bracelet_: "Compress" Date: Tue, 01 Sep 2020 16:16:42 +0200 In-Reply-To: <87zh6bhex9.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Mon, 31 Aug 2020 00:50:10 +0100") Message-ID: <87sgc1d1kl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > I don't understand the reason of being for the patch. I didn't read the > bug, but I do read this in NEWS: > > +*** 'icomplete-show-matches-on-no-input' behavior change > +Previously, choosing a dif [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I don't understand the reason of being for the patch. I didn't read the > bug, but I do read this in NEWS: > > +*** 'icomplete-show-matches-on-no-input' behavior change > +Previously, choosing a different completion with commands like 'C-.' > +and then hitting enter would choose the default completion. Doung > +this will now choose the completion under point. > > Now, I have never observed this reported behaviour in fido-mode even > before the patch. It was reported as a problem in icomplete, but I don't know how fido relates to icomplete.=20=20 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 10:19:44 2020 Received: (at 43120) by debbugs.gnu.org; 1 Sep 2020 14:19:44 +0000 Received: from localhost ([127.0.0.1]:56651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD78R-0002rs-Qo for submit@debbugs.gnu.org; Tue, 01 Sep 2020 10:19:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD78Q-0002rf-BO for 43120@debbugs.gnu.org; Tue, 01 Sep 2020 10:19:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SeIpYqyPc87aazlkfkzFkAsuMmiGf09lxUJUqcKWf7Q=; b=kJSQKI19B8yNp8BGDcCTm+AjBa WW0fDHCx6WIpTybEWLpV2qwIK8nSOjsWorGgwh1SWdle/eFe6DpNIqq/2fylaINwFsZqDvoFP3BxR ry2U2sE2WSn6IwiqdVOie6tq35XNfuX5nchliCZDTNXXPDM5OLQxKiAc9pNDR/WxnMPg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD78H-0002Nm-9b; Tue, 01 Sep 2020 16:19:36 +0200 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEWNcHFWLTE3ChCt k5Lby8YfAAD///+vu6zwAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QJAQ4MKok9XfAAAAG3SURBVDjL dZRLltwgDEWFwXPAVXNQl+fQsACfoAVUnJP9byVgwJ92hYEHujxJ6GMAAI3Xo6CcEIJjF7tkaJUq IIQzsUxFSlRBGA4ATCQmXQNujyNhWrSlrjicgUyzoZA6CE1iJIyGKABQ/pbjN/sMXCkilrOiTjaJ BW9F0qvVG0h7FAPPB33b8kDqElfAFyAFxbK6gtR9SfYVFjaX7PguKY90o4ibHeGvFU2S8zJc0bLW 9yCusUpyEClfqVUnA3w3XxqZj4s+wByrr8EqRw4PgK8GjI3Jn4Gtvrx5096ADcwNqD8pjhcgGngt vcoV4KPmO4gl4AW8KhiDd+sHwDV5/xEocv8DweOn4JL4FbR0nYzTD9AeKMWUGzx8KMlUXJ1AL+Ib eDiDveyGR6lRXRpVgDaPyEY099YaQ78U2udpGLbY+S6l37nBGzgGa8iA06DQlNJXe5sFgxMttkoO QZ4Cq02i7yo5ZrcUY0AeSasZGjhG9zmBSJJZtkK3+7oexrlsWTiDGM57axnPZclX9x3s5bYy+bwA id/WGU1yxT/82OZCuLc83X8Z2Z0IEOFuL2nzkAEovB/1DziVspmDzhX9AAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIwLTA5LTAxVDE0OjEyOjQyKzAwOjAw96/xcAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy MC0wOS0wMVQxNDoxMjo0MiswMDowMIbyScwAAAAASUVORK5CYII= X-Now-Playing: Riow Aral's _Beat Bracelet_: "Bitter Sweet" Date: Tue, 01 Sep 2020 16:19:31 +0200 In-Reply-To: <8736433l4c.fsf@iris.silentflame.com> (Sean Whitton's message of "Sun, 30 Aug 2020 14:00:03 -0700") Message-ID: <87o8mpd1fw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > I think the fix would be to clear completion-content-when-empty when the > minibuffer exits, instead of leaving data from the last completion > there. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > I think the fix would be to clear completion-content-when-empty when the > minibuffer exits, instead of leaving data from the last completion > there. Oh yeah, definitely -- it should be cleared on minibuffer exit. I'm guessing that should go in... `completion--complete-and-exit'? Would it be possible for you to propose a patch that does that? I don't use fido-mode myself, and it's probably easier for you to test whether that's the right fix. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 14:28:01 2020 Received: (at 43120) by debbugs.gnu.org; 1 Sep 2020 18:28:02 +0000 Received: from localhost ([127.0.0.1]:57257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDB0j-0003PG-LD for submit@debbugs.gnu.org; Tue, 01 Sep 2020 14:28:01 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:51135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDB0g-0003Ow-CD for 43120@debbugs.gnu.org; Tue, 01 Sep 2020 14:28:01 -0400 Received: by mail-wm1-f44.google.com with SMTP id e17so2096304wme.0 for <43120@debbugs.gnu.org>; Tue, 01 Sep 2020 11:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EBfqQbxUhY8XXSobrcaeILA0c1ZDrSiKQr+7zZfrnWs=; b=t2vBzfcJynjEpPZG8BLWETwMTHBe+BqCqh35YrS+5pK2XrlJUkPHt2UgrCZ9k0lxGG whzrGq1O1f4HZw3TlKyq7eHG2if1vnQkdXE9nbo4VFmF037HvxhUVlC4tgyPXuHvfG09 TSqY5Z88MdNkjBKRS3Er8d3ieKHIC16X3RXN3jHiBcR7qcgbESfEEXSR2bhfaSXP/ZpJ 7QV4MasouDhxIBPRgOJsnVPFoVkhsqqbc5mcAfPhdYx1Bg21jdsI8gzN6vrlQ+/E+e27 aljRyvwu+eiCTd9qQQgU/HkMtVAYH2aj2WSCJZXwYIFgy6Wgsqb6wjoT5dtVaB4SBzE3 giuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EBfqQbxUhY8XXSobrcaeILA0c1ZDrSiKQr+7zZfrnWs=; b=Ji9Bl5ouWb+1JdUkyrZ/OZV56HhLYoejwFkWjh5T9SAKHDXBxteHGzakYrbNqWMyXC F8imH8lo+tp5Iu32C/ckKvUhdecQ7AqiLr4QEdqOnbIxo/xplBLxWbWLRcfEc4Ey96zS NAZe1r+lWtSpi0xQjYv3AEegGu8z513sTpmjebQ0xABkOdY7hWO+J1TQ0+KfcuNRkOA7 lrTw6CFl6ZdeU8mS9fgLHcZ/0odOInxu1GJiXFF+snNWIlGrusACRKeqyP+gMQUoTUZD BTvq/v3ZYF/DS7HSXcg5asF4osPT8H1/TjdbzdXi8vrEzW+DZv8sMDYcdRfm7HiNBzng Uhjg== X-Gm-Message-State: AOAM532MPfXsXAO2s6wpYwl0f0s2ErCBBLiYZ9Q3MOE+5owNuzXBXXR1 du6yz1ftgfsmzh0/agHQyjSTxhQ1gQaDKQ== X-Google-Smtp-Source: ABdhPJxk+SDHfxkL5s8BmtPmajfYfyBOiT3wppqCHXOtRMUKiTl5LeFOlGo0+lTyMMJ/gXEJBFwyTA== X-Received: by 2002:a1c:480a:: with SMTP id v10mr2818401wma.141.1598984872215; Tue, 01 Sep 2020 11:27:52 -0700 (PDT) Received: from krug (77.68.108.93.rev.vodafone.pt. [93.108.68.77]) by smtp.gmail.com with ESMTPSA id u6sm3297822wrn.95.2020.09.01.11.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 11:27:51 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> <87sgc1d1kl.fsf@gnus.org> Date: Tue, 01 Sep 2020 19:27:49 +0100 In-Reply-To: <87sgc1d1kl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Sep 2020 16:16:42 +0200") Message-ID: <87v9gxpd22.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I don't understand the reason of being for the patch. I didn't read the >> bug, but I do read this in NEWS: >> >> +*** 'icomplete-show-matches-on-no-input' behavior change >> +Previously, choosing a different completion with commands like 'C-.' >> +and then hitting enter would choose the default completion. Doung >> +this will now choose the completion under point. >> >> Now, I have never observed this reported behaviour in fido-mode even >> before the patch. > > It was reported as a problem in icomplete, but I don't know how fido > relates to icomplete. This makes sense then. fido-mode is basically icomplete-mode with different defaults and slightly different bindings, resulting in a visual experience that looks vaguely like Ido (Fido =3D "fake Ido"). However, the description of this icomplete problem sounds like something where fido-mode and icomplete-mode should exhibit exactly the same behaviour, i.e. work along the very same code. So I'm baffled as to why that problem affected icomplete and not fido-mode. Almost equally baffled as to why it now breaks fido-mode. I see in the side thread there seems to be a straightforward and logical fix. If that makes sense globally and also fixes it for Sean, I'm fine with it, otherwise I'd suggest having a second look at the original problem that prompted the problematic patch, specifically at why fido-mode didn't suffer from it. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 08:40:39 2020 Received: (at 43120) by debbugs.gnu.org; 3 Sep 2020 12:40:39 +0000 Received: from localhost ([127.0.0.1]:33915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDoXe-0006G1-Pi for submit@debbugs.gnu.org; Thu, 03 Sep 2020 08:40:39 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:34473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDoXc-0006Fm-ES for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 08:40:37 -0400 Received: by mail-wr1-f41.google.com with SMTP id t10so3104169wrv.1 for <43120@debbugs.gnu.org>; Thu, 03 Sep 2020 05:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=QYzmvR+LOS0g0qlHBJB/kH2xNNcGsFB1jKC14z749r8=; b=N+2/NMJAtgerLyA2cfv79JwcHs+aZYhh/cgZYezEVxodyWcvzDD46YZRX5epphI/M6 WkoTkW2b5RbBbKqwhjF5laBD68BUPSsSCiv2rXsSlHtL9dZcit+XMkDu7YxXm6NII9Fn bBGVivfot7liOwMbd7luCcdleKYX7B4/9mRvLOw8hCYtsCIXmsT1CRm7du9Zctswthxh Y2aoTXdtTVMdTAFjQmh1hdGjsqTFpkJCCePpmc8bqeQL+IHayaplxHIWY/34v3ATVmTM YzLZWLrfiyrOLx+h81Dnk+52YFhTZ9QOIcYIlCb0WH4ebWO7yarGbF7OzriSDHxDO/a9 YzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=QYzmvR+LOS0g0qlHBJB/kH2xNNcGsFB1jKC14z749r8=; b=bxJIpGpZ2LmZUkv+HfACvep0dRlEIgSX84O99OJ/GiufMycxwyFBM38b1eYXs98RdH IOpwc2mSwgmaJtGWacfNoK4qGU+BkXYWUQKQqD6wJquRQWXQ+uGvMzTXwAUsRknusON4 8fKzD1LN3BEVfxPDs2A5UxlPyScVI+KRWt9CSAvLFLrZV4f3ti4U6fkdMV4/ycTGSOZo YMTeJQ4yVB2TweVmz6kU7kJCRx8KLOODtABMsjgAYW5wPxdUba39Vl4WTJOC2bmUQ+Pj fs5xm7HrgyubrncYDmtQ7nnqdHNZm0yt5Vlb01LbUQ5BLoUsO6qa2oulRrpknxxit5hz amUg== X-Gm-Message-State: AOAM530b0skYECpcc4hCdGmGbybfNveNYdrkA5wZOn0JDBvMJDhOMv/h saZlf4QTK0JUUmKt0/VuNHtVHJMvAF8= X-Google-Smtp-Source: ABdhPJyEAAPwyhPVYF68W5o96CASH2AIzEnxi1gRwCDsvod/bkxLQ6cqOAVhjz1cmA1YY5alo6wRAw== X-Received: by 2002:adf:a48d:: with SMTP id g13mr2265349wrb.212.1599136829910; Thu, 03 Sep 2020 05:40:29 -0700 (PDT) Received: from krug (93.194.137.78.rev.vodafone.pt. [78.137.194.93]) by smtp.gmail.com with ESMTPSA id b11sm4468760wrt.38.2020.09.03.05.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 05:40:29 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> <87sgc1d1kl.fsf@gnus.org> <87v9gxpd22.fsf@gmail.com> Date: Thu, 03 Sep 2020 13:40:28 +0100 In-Reply-To: <87v9gxpd22.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Tue, 01 Sep 2020 19:27:49 +0100") Message-ID: <87d033owxv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I see in the side thread there seems to be a straightforward and logical > fix. If that makes sense globally and also fixes it for Sean, I'm fine > with it, otherwise I'd suggest having a second look at the original > problem that prompted the problematic patch, specifically at why > fido-mode didn't suffer from it. It didn't, but it sure does now. I just noticed that this affects bare-bones fido-mode as well, i.e. even without using M-j we get some akward and very highly annoying cache. In an Emacs -Q with fido-mode enabled: (bound-and-true-p [press C-h f RET here, slowly]) now move the point to the "setq" in, say (setq blabla ) And type C-h f RET here, quickly. You'll be presented with `bound-and-true-p`'s doc, not `setq`'s. This is a regression: the bug should be fixed ASAP. Maybe some "clearing" as was suggested is in order. I'm not very confortable writing that patch right now. Can anyone else do it? Or should we revert the original fix instead in the meantime? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 09:11:56 2020 Received: (at 43120) by debbugs.gnu.org; 3 Sep 2020 13:11:56 +0000 Received: from localhost ([127.0.0.1]:33980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDp1w-000736-17 for submit@debbugs.gnu.org; Thu, 03 Sep 2020 09:11:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDp1t-00072r-9T for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 09:11:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5i1/srxhAcfaZdHhH1QnU0TnIusuI0tYakoBvxwfPcg=; b=cemPD2bTQhNwIpjv7VKBaMQvJV FB/e9cbHkjQGzaNZASkJfpRbZ0nWMt1oqRAYziRXMnJ/tIe52uqVXb80WDN0v9ZRjRvAbl1V8hB1z ge6WGLJNULrER6UWQPfw9RVJzmX1hxCLxK9xE/P1XXyMQMAdAHBX5a/KYxNSclS6kveg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDp1c-0002De-Dd; Thu, 03 Sep 2020 15:11:46 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> <87sgc1d1kl.fsf@gnus.org> <87v9gxpd22.fsf@gmail.com> <87d033owxv.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEX+/v7Lyshyb2qD gXyAfnmvraoZFA0iHRZUUEpHQjw1MSpCPTcoIxz///8W+sBnAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QJAw0JHJO/Sv4AAACASURBVDjLY2AYBUMICBkbG7sYuzgbOasYG6siSYSlpVXMWr161cqVu9LS spEkwtecObWqAwjmrKk5U4GsAyi+qqO7o3PVqjU1GSgSpzs6ds3s6NjR2YUiEX7mzPEVHas6ZnSV oxlVlpZWnjOzY1kaEGQiSUh0IIGmgQ68UTD0AQBxSDi16xIgDQAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wM1QxMzowOToyOCswMDowMFYNoLUAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDNUMTM6MDk6MjgrMDA6MDAnUBgJAAAAAElFTkSuQmCC X-Now-Playing: Delroy Edwards & Dean Blunt's _Desert Sessions_: "(untitled)" Date: Thu, 03 Sep 2020 15:11:35 +0200 In-Reply-To: <87d033owxv.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Thu, 03 Sep 2020 13:40:28 +0100") Message-ID: <87lfhrt37c.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > This is a regression: the bug should be fixed ASAP. Maybe some > "clearing" as was suggested is in order. I'm not very confortable > writing that patch right now. Can anyone else do it? Or should we [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > This is a regression: the bug should be fixed ASAP. Maybe some > "clearing" as was suggested is in order. I'm not very confortable > writing that patch right now. Can anyone else do it? Or should we > revert the original fix instead in the meantime? I think the fix should be pretty trivial. I don't have time to test it today, but tomorrow should be open. Reverting the problematic patch in the meantime is fine by me, but on the other hand, it'll get reapplied again tomorrowish, I guess, so that seems like unnecessary churn... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 09:13:57 2020 Received: (at 43120) by debbugs.gnu.org; 3 Sep 2020 13:13:57 +0000 Received: from localhost ([127.0.0.1]:34020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDp3t-00077K-Ct for submit@debbugs.gnu.org; Thu, 03 Sep 2020 09:13:57 -0400 Received: from mail-il1-f177.google.com ([209.85.166.177]:36921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDp3r-000775-LW for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 09:13:56 -0400 Received: by mail-il1-f177.google.com with SMTP id b17so2443302ilh.4 for <43120@debbugs.gnu.org>; Thu, 03 Sep 2020 06:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pF+lrAYuzdYoDVNkNDNGkX5goWtb/Se640KF5kzpHdw=; b=PK/2zc51zntR2xTIq9Gxrdnb0gEZ3NTzwjQjETVGIhkLaxGcVGRVCrwaLf6dE5rGCI hfGOFjkTkXwKTZMid2pGI5LVqNuANpeICGijif8KNjoDnSdpQ4Gd6+USdSrwFCOaKtTE edmy4lA6mkL7o1OJnmrzAsa0OUE5v7YhTmvHghTiQNKKfv4+hFExfuf8IsqIRB8Dq8qt 1tMRpiNSFXTq/ox2iEw/D8T4D5p1PxVVeJgV+QUB2ads7syPLFVHXYH/YH8VMy998hzi 6F37cViqMI2QTaM+uan5P4JE6uT2/flPgWG7kzrQcPVY1BTQQnxjATUjd6GIASqqglbN HBow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pF+lrAYuzdYoDVNkNDNGkX5goWtb/Se640KF5kzpHdw=; b=DQaZqfGRODHDACUbnZHAy8EinT2mC3wGlx2YCByzpRmBM30MTWFVlVKeqceAwPQXQ6 wbgoxfpg/d/Km6nAnJGRY1+pOm8oJzWKm2WSOXLIQN088FsCOZ1K4a5HpFAC6Sju1ARE KRytgge2dCJF/J712NUTD3X2JHPnsrUKLWEQ+UbNWrbSKIU+f6XZERvu0qVn20oTQXHF WD0JQB4VvLbl6/jg4h6aEHUQN9vi/q8sdTotnXvFXRiBzzbJ3ieSbfxAvCtljDeV77Yb 4JQz/Zf0y8J2j4uNzOOxXj4U3j9P1ZyvseF/b2A4xhO02J7DEJMVsK5HpPINUKIVbV+u 0rXQ== X-Gm-Message-State: AOAM533/l5NhrLYA8YTQrpxFm7b7bhXXcr8o3wXlIOwZkEsLmhp6lrxm R4oP+zCBqdoXcbXfYV5roq4ixeqrP+BmKifMaBw= X-Google-Smtp-Source: ABdhPJzDHKjKq7siORGSfCaBAjNXPeqcrFTVpbXmBq8uY/tXj+ZgUzKuiHD/ZQAxOAwerVp/xvWSY04ILkxHo3bVCP0= X-Received: by 2002:a92:2c0e:: with SMTP id t14mr3136083ile.199.1599138830008; Thu, 03 Sep 2020 06:13:50 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> <87sgc1d1kl.fsf@gnus.org> <87v9gxpd22.fsf@gmail.com> <87d033owxv.fsf@gmail.com> <87lfhrt37c.fsf@gnus.org> In-Reply-To: <87lfhrt37c.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 3 Sep 2020 14:13:38 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000e8c8ac05ae68852c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e8c8ac05ae68852c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 3, 2020 at 2:11 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > This is a regression: the bug should be fixed ASAP. Maybe some > > "clearing" as was suggested is in order. I'm not very confortable > > writing that patch right now. Can anyone else do it? Or should we > > revert the original fix instead in the meantime? > > I think the fix should be pretty trivial. I don't have time to test it > today, but tomorrow should be open. > > Reverting the problematic patch in the meantime is fine by me, but on > the other hand, it'll get reapplied again tomorrowish, I guess, so that > seems like unnecessary churn... No problem then, but can you give me an idea of the patch, so I can hotfix my Emacs master where this is bothering me a bit? Jo=C3=A3o --000000000000e8c8ac05ae68852c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Sep 3, 2020 at 2:11 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writ= es:

> This is a regression: the bug should be fixed ASAP.=C2=A0 Maybe some > "clearing" as was suggested is in order.=C2=A0 I'm not v= ery confortable
> writing that patch right now.=C2=A0 Can anyone else do it?=C2=A0 Or sh= ould we
> revert the original fix instead in the meantime?

I think the fix should be pretty trivial.=C2=A0 I don't have time to te= st it
today, but tomorrow should be open.

Reverting the problematic patch in the meantime is fine by me, but on
the other hand, it'll get reapplied again tomorrowish, I guess, so that=
seems like unnecessary churn...

No problem = then, but can you give me an idea of the patch, so
I can hotfix m= y Emacs master where this is bothering me a bit?

J= o=C3=A3o
--000000000000e8c8ac05ae68852c-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 09:51:43 2020 Received: (at 43120) by debbugs.gnu.org; 3 Sep 2020 13:51:43 +0000 Received: from localhost ([127.0.0.1]:34112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDpeQ-00082f-Qd for submit@debbugs.gnu.org; Thu, 03 Sep 2020 09:51:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDpeO-00082Q-75 for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 09:51:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DMzZ8wUWsCwTYvnW8apJEIrdBNg4rc8PNlLTxAaCi2s=; b=TPC03okZzh5Nws5SEYYHfjvTEl NK0lFT1QkLMJNzGnldkHEHn7FwgqlyQUufFEhynyX4D6fCrw0QwQOG0D6icRpYMW3UCLHG1g/HGxd Aj9Vb/gq2Ak/e0LyhfevQp/sVOpSMLaCkMy1h6kVMkmQa25EfJhDnbDpLTjAM0t7vfdM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDpeF-0002dO-2r; Thu, 03 Sep 2020 15:51:33 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> <87sgc1d1kl.fsf@gnus.org> <87v9gxpd22.fsf@gmail.com> <87d033owxv.fsf@gmail.com> <87lfhrt37c.fsf@gnus.org> X-Now-Playing: Baby Huey's _The Baby Huey Story: The Living Legend_: "California Dreaming" Date: Thu, 03 Sep 2020 15:51:30 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Thu, 3 Sep 2020 14:13:38 +0100") Message-ID: <87h7sft1ct.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > No problem then, but can you give me an idea of the patch, so > I can hotfix my Emacs master where this is bothering me a bit? I think setting the variable to nil in completion--complete-and-exit is probably the correct fix, but I haven't tested it. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > No problem then, but can you give me an idea of the patch, so > I can hotfix my Emacs master where this is bothering me a bit? I think setting the variable to nil in completion--complete-and-exit is probably the correct fix, but I haven't tested it. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 09:56:04 2020 Received: (at 43120) by debbugs.gnu.org; 3 Sep 2020 13:56:04 +0000 Received: from localhost ([127.0.0.1]:35816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDpie-00008P-Cz for submit@debbugs.gnu.org; Thu, 03 Sep 2020 09:56:04 -0400 Received: from mail-il1-f172.google.com ([209.85.166.172]:44610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDpic-000082-PZ for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 09:56:03 -0400 Received: by mail-il1-f172.google.com with SMTP id h11so2523994ilj.11 for <43120@debbugs.gnu.org>; Thu, 03 Sep 2020 06:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nrJjj4qPM9wH3YYoddn7F7VuJbxC8TSKJ04ouMGq7HM=; b=kA+z0oP77khsXM7qE8UwscgcmQr8V/r2bdtYzVwvFWLCm5aWV1n+A09myBOqKJGXRA Vh8zZ8Xm58OHdz3jwl3dJcKRGXGGylk9yjPAE/9c8RM9KfLUm/OQhRzd2qQhVWuq6Our UGU3hZVtsyIqrhsaJdlQ0DLB/1NZV0ZXSB4imeLvwyNmL1hvBvsADJDo74eZyTEt8O5Q Y+k1q05FGk1BGxeP9ixinvNGvlH3FMeLcv4C5lhutmmUXd2nAaiBwLf9AszeC898al4s iwWsLWus2ahopMWvdREZAN0tqVzJKYuBVcYd0lp4ZKLElRIQHHMj3bhT+ykBRBKVmC+J /isQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nrJjj4qPM9wH3YYoddn7F7VuJbxC8TSKJ04ouMGq7HM=; b=l5nigJ9sNPIxWdPKiGMgVWWiC6tUN0b6uTA9w9ObUW42Hp7MZmaBCV9GNDrsIICc7i oHf0/8VfudZ0AcZoa9mdPGroivo+G8rg2JWE7Ds5623lhqvYJicZA8D/C8SgTOzKWipg mePpWIiPjz9KGgeL+1b4oelNbnvDpsZKCozpGe7ROXsW0yDUtiGMu9VcMRZr3kOejNKn f7F5fFOVUjFyPq9FMkrZHvIfc/V24eiR4B64rJAmSkjgRIVFdbSQSfSYYXEHNZPFonMC mLQdv4oACbBS1akW6P5LMk/BV64GG/d8SQWiFhsf5BX5myeuRkSX/SUFFstwF7Yi6ThH kEcA== X-Gm-Message-State: AOAM533OlHB4cGxagqT0Ire0sTaaZBwc5sTpCHbwzWbL0wnsnGbm0pAl J8EbF26s7YK4gqd868UBdPYwEox+4vU6NnVB6+w= X-Google-Smtp-Source: ABdhPJw35SRjTI7fB/4gn02/ZoVeNArOcdMS3mHXVqIqyxd7dEwYdZZgpzxIhBXa+65+ag+cTUXVPiyBlIDMBcJSfPs= X-Received: by 2002:a92:d482:: with SMTP id p2mr3423357ilg.9.1599141356896; Thu, 03 Sep 2020 06:55:56 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87zh6bhex9.fsf@gmail.com> <87sgc1d1kl.fsf@gnus.org> <87v9gxpd22.fsf@gmail.com> <87d033owxv.fsf@gmail.com> <87lfhrt37c.fsf@gnus.org> <87h7sft1ct.fsf@gnus.org> In-Reply-To: <87h7sft1ct.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 3 Sep 2020 14:55:45 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000008605e005ae691c5c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008605e005ae691c5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, thanks. I'll try that. On Thu, Sep 3, 2020 at 2:51 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > No problem then, but can you give me an idea of the patch, so > > I can hotfix my Emacs master where this is bothering me a bit? > > I think setting the variable to nil in completion--complete-and-exit is > probably the correct fix, but I haven't tested it. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --=20 Jo=C3=A3o T=C3=A1vora --0000000000008605e005ae691c5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, thanks. I'll try that.

On Thu, Sep 3, 20= 20 at 2:51 PM Lars Ingebrigtsen <larsi= @gnus.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> No problem then, but can you give me an idea of the patch, so
> I can hotfix my Emacs master where this is bothering me a bit?

I think setting the variable to nil in completion--complete-and-exit is
probably the correct fix, but I haven't tested it.

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no


--
Jo=C3=A3o T=C3=A1vora
--0000000000008605e005ae691c5c-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 19:24:05 2020 Received: (at 43120) by debbugs.gnu.org; 3 Sep 2020 23:24:05 +0000 Received: from localhost ([127.0.0.1]:36488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDyaL-0005tj-BM for submit@debbugs.gnu.org; Thu, 03 Sep 2020 19:24:05 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDyaJ-0005tF-3B for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 19:24:03 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CF890A55; Thu, 3 Sep 2020 19:23:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 03 Sep 2020 19:23:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=2XpgTD73W2zNYVku7h7VlD0Cfm a46HfJid61eq8NNjk=; b=bReUk/F/DGKkqqeUZ35sgPY+yWVZ7BS5B5ShDw6F2u 9jIvsuh/Ao1LWHJEVkYhYl+XQc9G3Il+ZiIzIvbeXQ4kLMFvllVsUrU5r/Z5ShjH +/XYTkPlUZyPefpahUH5lyiUbUH5UbUvrMX4XULQXRg12UOAqhaaDaHHVJV9CLK5 mZvk6a7XgDeFgbcVfnKtDL9eK0RKiZtKjmf/1U/xD1DQpCelcZuuwQRY5H4wGXZg TIhvmADlzN7pxebbGvghqbTh5hgn/mcYHFfRZ0sylDkY+iOO51+YpwSEdvFbfbFR a6nm1XlPvJ7LvZQPFvBwZMUWvmIQ5N2j+z58VVLfuagw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=2XpgTD 73W2zNYVku7h7VlD0Cfma46HfJid61eq8NNjk=; b=a+F95tsapYIUUHOVFcfjy+ 4vG9u4qmWOMcQk9rbw6gg/hrRDyosZUINlZYp9GKFSSozehOQxiCIUvFCiBY0VL0 TuBqXu1SbvNyc6+yiNQE7fRg/d6t0qOzcZRbl6nKTQU7xHaAXPZvbNg2n2qbaA4N 6c6LdvSrrOWmNSxkWv9kNj8qdhnxlWsgmteqg2tEyzbvmHkZte+IbCObpodGLxtc /9RFmKwJd/11kp9fDFP6ATQojs0fXsjhQVbqs+Q9M9MjwAzz8KnIAJ2OEupscEFO k+20/qMzK0heBVtfb66cJdyIttALR8uQ06dpoGnmAZDYzNQgCNGYDHNH/U/k/XHA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegvddgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice In-Reply-To: <87o8mpd1fw.fsf@gnus.org> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> Date: Thu, 03 Sep 2020 16:23:54 -0700 Message-ID: <87tuwewik5.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Lars, On Tue 01 Sep 2020 at 04:19PM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> I think the fix would be to clear completion-content-when-empty when the >> minibuffer exits, instead of leaving data from the last completion >> there. > > Oh yeah, definitely -- it should be cleared on minibuffer exit. I'm > guessing that should go in... `completion--complete-and-exit'? Would > it be possible for you to propose a patch that does that? I don't use > fido-mode myself, and it's probably easier for you to test whether > that's the right fix. I'm certainly happy to test a patch but I don't think that can be the right place to clear the variable. The docstring for that function says it exits from a require-match minibuffer. But completion gets used in other minibuffers too. So we need to clear the variable somewhere which gets called for every minibuffer exit. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 22:12:18 2020 Received: (at 43120) by debbugs.gnu.org; 4 Sep 2020 02:12:18 +0000 Received: from localhost ([127.0.0.1]:36670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE1D8-0003l5-6D for submit@debbugs.gnu.org; Thu, 03 Sep 2020 22:12:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE1D6-0003kq-0w for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 22:12:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ijdK8m2Nz+ZNaTGI0+J5VWpgcUdZLE20BDe4qyBcK9c=; b=Bqu/c6pcicD71zIHYvIazwVGi+ soNKYPFkylbv1Goh353U1ic9n8lf3Si1Rs4GY5etHvmVOvdhAHhJJr3myPUDSV2Vfmb1ZAquv0b5M sv5J6up3bGrb1q/53vcWYGf/QGQkRkvfcerHWN1k5S/TVZ18joLpYtZ+YSV5ma7wgeaw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE1Cp-00016Y-MB; Fri, 04 Sep 2020 04:12:09 +0200 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> X-Now-Playing: Herbert's _Early Herbert_ Date: Fri, 04 Sep 2020 04:11:58 +0200 In-Reply-To: <87tuwewik5.fsf@iris.silentflame.com> (Sean Whitton's message of "Thu, 03 Sep 2020 16:23:54 -0700") Message-ID: <87zh66qoi9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > The docstring for that function says it exits from a require-match > minibuffer. But completion gets used in other minibuffers too. So we > need to clear the variable somewhere which gets called for [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > The docstring for that function says it exits from a require-match > minibuffer. But completion gets used in other minibuffers too. So we > need to clear the variable somewhere which gets called for every > minibuffer exit. Yeah, following the exit logic (from the multiple number of code paths) isn't trivial here. But as far as I can tell, the exit-minibuffer function is called in all the relevant code paths? Does this fix the problem for you? diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 864726e3cc..8984440576 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2062,6 +2062,9 @@ exit-minibuffer ;; (or to turn it into a list of buffers, ...), but in the mean time, ;; this should do the trick in most cases. (setq deactivate-mark nil) + ;; Clear any computed default values (so that they're not used on + ;; the next invocation). + (setq completion-content-when-empty nil) (throw 'exit nil)) (defun self-insert-and-exit () -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 23:22:24 2020 Received: (at 43120) by debbugs.gnu.org; 4 Sep 2020 03:22:24 +0000 Received: from localhost ([127.0.0.1]:36763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2Ix-0001PN-U8 for submit@debbugs.gnu.org; Thu, 03 Sep 2020 23:22:24 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2Iq-0001P3-9Y for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 23:22:22 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 098F15C005B; Thu, 3 Sep 2020 23:22:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 03 Sep 2020 23:22:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=OVoDWgHQGEtqksu0Unh55Manyg R0ucCVRDB5F8XJHss=; b=uaeUUJLcIpkxrpdkFCf+B7zHdNClwccT18/ah8Wxqg NZWcmXYlQrVoAMrdiuhzw1zAJHhBfEPuxoiitLsImgHJAC//vbeYpkKbAMlaG7vD 3Lb0oLeYntmZpHuDF941PTIXbt1R+OaZRKCPKJh+nC0B/wZ8K+l0QrceG24sz4DU HSpXoCfCbhPAv8HbR0h3u+OHUq2LhZEZxCbwsXPmVcgP4nRFjW78MNnRRy+vwbMl l3F2cu2rZdBALAmcOCDTjIVLUUthxmZHHt0BVNf5mXRjEJFq+aoj7wDe2R7NzdUi Ycw6dNrUTekj+aHZTbkaSSliWvioirGvS+DGWH19XBsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OVoDWg HQGEtqksu0Unh55ManygR0ucCVRDB5F8XJHss=; b=YiueMgwZPRaspfbkFRJonM 93Jd5H0dXM+LyKdF0rxSlnLPtrQDNMPlYqEUAYXbYdeMSDkTKrKMaPuIw47UsCO3 /t7ngdSv94CIGLxk3WZbKVMjzota98QP0zqi9atF2a+XZiZ5BexX2+iMCcWKOxPJ GchQSVG6k5WgR21TM5t8bZLFVfiNUU8VJKDWYOB8hS/w7jebrDzdHu6XGAawKmdw Vhizod8qjxvaM7ma5UIcIuLp5hAgVXjEwv/uyVKm6n5M2Hy8OYeqFJ4X/56VHj7h zKNZhSkqAPNDOfy55DcPAByt34p7NYkItEml6W7MpsyF19ElvmI3/apqu444HHUQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegvddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice In-Reply-To: <87zh66qoi9.fsf@gnus.org> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> Date: Thu, 03 Sep 2020 20:22:09 -0700 Message-ID: <87pn72w7j2.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 04 Sep 2020 at 04:11AM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> The docstring for that function says it exits from a require-match >> minibuffer. But completion gets used in other minibuffers too. So we >> need to clear the variable somewhere which gets called for every >> minibuffer exit. > > Yeah, following the exit logic (from the multiple number of code paths) > isn't trivial here. But as far as I can tell, the exit-minibuffer > function is called in all the relevant code paths? > > Does this fix the problem for you? Unfortunately it does not, so I guess icomplete-fido-exit is not exiting the minibuffer through that path. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 23:27:45 2020 Received: (at 43120) by debbugs.gnu.org; 4 Sep 2020 03:27:46 +0000 Received: from localhost ([127.0.0.1]:36767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2O9-0001Wv-Np for submit@debbugs.gnu.org; Thu, 03 Sep 2020 23:27:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2O7-0001Wh-Og for 43120@debbugs.gnu.org; Thu, 03 Sep 2020 23:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u4imJGCT9dgC/ni1vb1zTT9KPNHnh/P402R1dxeMIUQ=; b=S6GV0nQRiW/obZmHI8dElqv0E0 HuWZhJ8KuIFAu7p87K4ohl4PIkSx3jJvpJ2AvvFcGwaOrF/z3oWC3Cr2+RjjLUGfI8CjwXJMAFezr njjXSa5RlBulFj6888Nvn0JlT8Go6I5NKw1rnn+iFbgLbMamE869gy5+7PdHvZGe/Gu8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE2Nx-0001tD-Hn; Fri, 04 Sep 2020 05:27:37 +0200 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAABGdBTUEAALGPC/xhBQAAAAJi S0dEAP+Hj8y/AAAAB3RJTUUH5AkEAiEukL7KUAAAAOFJREFUSMftlL0RwjAMhT9+KspcjgXUsAJT vF2ymcah8AysQBNsyfg4OBqK6C6FLH/Wk1+S3cx3sf9y/wZswAb8AhzHy7LiIQP8HSDPeUxHgPKW D2bwp452gtQBCnUWUJAlE1jfwUId4VFUWR+Aw2kd83q+rUuX+zTVBBA2nf3WdVCxRa2ZkcOq4irJ y3rzsiCgqrV+aFO6l3jJudsxHrQUcEp2wXPLABQDH3jmMtqLEo2Lwjt57ZQkCYQLyDakIZpxVstm 2XiGwHPzqwc5dnOQbAW8/xjGwOfxhz+BDfgP4AH+CjRRsIuwngAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wNFQwMjozMzo0NiswMDowMPP95CEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDRUMDI6MzM6NDYrMDA6MDCCoFydAAAAAElFTkSuQmCC X-Now-Playing: Machinedrum's _Vapor City Citizenship Programme_: "SeeSea VIP" Date: Fri, 04 Sep 2020 05:27:32 +0200 In-Reply-To: <87pn72w7j2.fsf@iris.silentflame.com> (Sean Whitton's message of "Thu, 03 Sep 2020 20:22:09 -0700") Message-ID: <87eenifcgr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > Unfortunately it does not, so I guess icomplete-fido-exit is not exiting > the minibuffer through that path. Hm. Am I misreading the code here? So the else branch definitely calls exit-minibuffer... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Unfortunately it does not, so I guess icomplete-fido-exit is not exiting > the minibuffer through that path. Hm. Am I misreading the code here? So the else branch definitely calls exit-minibuffer... (defun icomplete-fido-exit (force) [...] (if (and (not force) minibuffer--require-match) (minibuffer-complete-and-exit) (exit-minibuffer))) And the "then" branch ends up here: (defun minibuffer-complete-and-exit () [...] (completion-complete-and-exit (minibuffer-prompt-end) (point-max) #'exit-minibuffer)) Hm... which then calls completion--complete-and-exit, which should then end up calling the exit function in... hm. Perhaps not all the branches? There's a bunch of callbacks, but I thought I followed them all to the end and they all ended up calling the exit function, but perhaps not? Would it be possible for you to edebug through completion-complete-and-exit? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 10:47:35 2020 Received: (at 43120) by debbugs.gnu.org; 4 Sep 2020 14:47:35 +0000 Received: from localhost ([127.0.0.1]:40325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kED03-0006Ds-Bb for submit@debbugs.gnu.org; Fri, 04 Sep 2020 10:47:35 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:42359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kED01-0006Df-FX for 43120@debbugs.gnu.org; Fri, 04 Sep 2020 10:47:34 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7468D90A; Fri, 4 Sep 2020 10:47:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 04 Sep 2020 10:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=t5051p7LuEG/Ke9T9iCR8OTugR DJF3lDCljNSFfUDBg=; b=ZwqRtDRYqKhZkILciI9AKy+PPObavs4Iv03jGnqp8K PNvXp7WK8uonoIHLPu91l58OU2R7DRRGXqWXV92yAsQ2PdJW5+CxpMQsLlWTufls ahb6MBflHEZXSe/ZIqW/fG9wNMMDpjaSdfVzmm6k22EQ7KMjtnRFyNxm5lTxi997 SS9Uqxd3HEdO4dFGNbelSbGdvKf1vHwCeQpvvkBXMkVrODzFutEzHDEZSvsKJane 05ytdervuMPuKj+SIYxYheNBjcDrBqAl368HbNupgRKgf22ayjIqbSg+bikZ3OSE 8wSK/4nLTu6s6mbl7lI/hXg86+2bhgfSgomNO74aD+pQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=t5051p 7LuEG/Ke9T9iCR8OTugRDJF3lDCljNSFfUDBg=; b=dw8ILBzf6VvsyZLvA56/SQ Ku0x5Vus6TvqIYK5d+6fkTkqqUteOEcqPH73JoU+PVISzcJyzM82QTtOfNG2q5Ya Awun6U5udL55PY5drZrtDN0JoMyex6RCuI8/mktdpZIEuAeYDdTB/NMxNuC1yIlI FbTJIF6+HwPp2gI0hjU9R6ebL1iVTNiRJKmuLqmhpSTg7PMGbpkLb3v4jyPv4khW 7FW1sxVg/gdYzrYdgH1c8zqBV52Ww/knUqYMmXlTVJso8wWq0FKbBSIZIwyniHT+ n+gC1WSWB5qyOFFHlb/khvg99yQI6TYZrFbTKvLOGJKntA3pDibCum48K8FziCeA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegfedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice In-Reply-To: <87eenifcgr.fsf@gnus.org> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> Date: Fri, 04 Sep 2020 07:47:24 -0700 Message-ID: <87mu25wqdf.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Lars, On Fri 04 Sep 2020 at 05:27AM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> Unfortunately it does not, so I guess icomplete-fido-exit is not exiting >> the minibuffer through that path. > > Hm. Am I misreading the code here? So the else branch definitely calls > exit-minibuffer... > > (defun icomplete-fido-exit (force) > [...] > (if (and (not force) minibuffer--require-match) > (minibuffer-complete-and-exit) > (exit-minibuffer))) > > And the "then" branch ends up here: > > (defun minibuffer-complete-and-exit () > [...] > (completion-complete-and-exit (minibuffer-prompt-end) (point-max) > #'exit-minibuffer)) > > Hm... which then calls completion--complete-and-exit, which should then > end up calling the exit function in... hm. Perhaps not all the > branches? There's a bunch of callbacks, but I thought I followed them > all to the end and they all ended up calling the exit function, but > perhaps not? Would it be possible for you to edebug through > completion-complete-and-exit? I think I see what the problem is. I was doing the following to generate a test case: C-h f comp [wait for completions to appear] C-g This leaves completion-content-when-empty populated to interfere with the next run, as getting out of the minibuffer that way does not clear the variable, but it should. Might it work to set the variable buffer-local to the minibuffer? Then we can be sure it would always be cleared. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 08:26:07 2020 Received: (at 43120) by debbugs.gnu.org; 5 Sep 2020 12:26:07 +0000 Received: from localhost ([127.0.0.1]:41738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEXGh-0003Ii-L4 for submit@debbugs.gnu.org; Sat, 05 Sep 2020 08:26:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEXGf-0003IE-V3 for 43120@debbugs.gnu.org; Sat, 05 Sep 2020 08:26:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4LmDbTzGqryCKLyNSqE1bgQ7lkGpl6xvMDlFeTJTOmM=; b=Vw8BZy+I2zPZj9Qe7MEwTtUMaj 8e2uFec7a7Vj+bP/bDoNsecUv+2q6+AwMi5YIMffxvfLevQgEL20JeGbdb3ZC3T1wbfR0mvqI9cKu rHc5uFhk8sgrKyLJnfzSnimaIZAALCPHsyUn3ilQ+/WLHrpXgahBmAoLYqv1aPFYWOlQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEXGT-0003Y0-8l; Sat, 05 Sep 2020 14:25:59 +0200 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEU5JSFIMy42IR0o EhAeCgp3ZmBnU01cSENXQjyHd3Cdjof///9o0S9GAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+QJBQwY LbURXD8AAAFxSURBVDjLdZJLTsMwEIad5ALYCc22iXktE9sq24axukeCSl0iIF3TonZNKsENQD0A i94Sm7zc2B1pnMif/n8yM0EeRgj5CI39NB2rN/X4DyS4O5D7OrFBog9xDhbIQ3WwuQ0yDbIH24pp kK8dxTWYvThAoGpj6gb527APqrKifEbIABCVVyG/tKw8lRPKl2xolXPKbgK+IhbIlzEO83A3BJk+ 8GQU2FYqPnFpjV2NQn0Webb3gVV+FTsbTJX76pp3AAAENC1mpOpAdhb4Y1JPnTMcdqDYH+5/f2pJ wDDvrTblU1k1rTDSAxZ7280rrb0w7cG0/Fg87qNaknJDsfXiZV2z+X9axWh0+H7ntmJaxov52tii 0TmYOzdBt0OfuwFrv2EIEkGcQLWduhV6jCdAdgokA9A10jcoju5ZaAIh5aBEayVANpoKjmvIBtyF vQKkAJDKTLPiogP6pg0Qt9wARggMbgCRBCe4i7h0ASii1uoPky7q2T4YcJEAAAAldEVYdGRhdGU6 Y3JlYXRlADIwMjAtMDktMDVUMTI6MjQ6NDUrMDA6MDDSIEriAAAAJXRFWHRkYXRlOm1vZGlmeQAy MDIwLTA5LTA1VDEyOjI0OjQ1KzAwOjAwo33yXgAAAABJRU5ErkJggg== X-Now-Playing: Thomas Mery's _Les couleurs, les ombres_: "Aux =?utf-8?Q?fe?= =?utf-8?Q?n=C3=AAtre?= immenses" Date: Sat, 05 Sep 2020 14:25:51 +0200 In-Reply-To: <87mu25wqdf.fsf@iris.silentflame.com> (Sean Whitton's message of "Fri, 04 Sep 2020 07:47:24 -0700") Message-ID: <87k0x876ls.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > I think I see what the problem is. I was doing the following to > generate a test case: C-h f comp [wait for completions to appear] C-g Oh, right; didn't think that through properly... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > I think I see what the problem is. I was doing the following to > generate a test case: C-h f comp [wait for completions to appear] C-g Oh, right; didn't think that through properly... > This leaves completion-content-when-empty populated to interfere with > the next run, as getting out of the minibuffer that way does not clear > the variable, but it should. > > Might it work to set the variable buffer-local to the minibuffer? Then > we can be sure it would always be cleared. All this time I thought the minibuffer was reused, but poking around a bit now, it seems like it's not? In which case -- does the following fix this problem? diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 8a68df876c..ba266cfbfe 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -715,7 +715,7 @@ icomplete-completions (setq prospects (nreverse prospects)) ;; Return the first match if the user hits enter. (when icomplete-show-matches-on-no-input - (setq completion-content-when-empty (car prospects))) + (setq-local completion-content-when-empty (car prospects))) ;; Decorate first of the prospects. (when prospects (let ((first (copy-sequence (pop prospects)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 11:32:45 2020 Received: (at 43120) by debbugs.gnu.org; 5 Sep 2020 15:32:45 +0000 Received: from localhost ([127.0.0.1]:43895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaBI-0004gA-TB for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:32:45 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaBH-0004fx-DG for 43120@debbugs.gnu.org; Sat, 05 Sep 2020 11:32:43 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2DB165C00D1; Sat, 5 Sep 2020 11:32:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 05 Sep 2020 11:32:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=DRgSAyiY+7u1P/adFsGpLIVQUZ IDj4gO/QgOKjVMTcU=; b=MKgjrglaByRD4EV7P96CcuSdCBMx0AjZCaN79VMgRK fjzAh686nt1u/RKWctWAgXyLTRE0tBDlSIOy0NRErUwlohsn3QaQsnYJYpTOJVWW PCYDfElRSvIg5m51cEaV4j/shHiRAJAJYyJRXY4k6mp+SxwHDAdRmcwalJ0IDNVa o+/QBzrsaYi6ib8GuqjohX5HnKrXSJCIj7dOSfbIQauaFDGU3k0SWVPjyEV8m3Dx fA09T42Woo+YhG2G8jSYLYQO2NJf1u93XTNcUSiv3S9ONNz/BN4UEW1CAcNuy8RM CQVdmePuBnOfJcDfVo7d59deQ2WrqtS5Ekq9rdmZgpMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=DRgSAy iY+7u1P/adFsGpLIVQUZIDj4gO/QgOKjVMTcU=; b=mDPhBnQZeQPRkhPbfSg2hr gDmhLU0WRgGO8qU894UgkYk/NgomTNLtRrrTuifRE5iJVpaXoaQu4E9Y39ylWvGO wp4xF9luDOZ5Z70eSCklmjtJcPefOxWrz7109tMjCkPdS7KXb1vxigNCRLRFcYz3 B/kBX3hSp35XM8reGNM0ncsOUIkoT8RGJhitmqz9I63+xTK0d8Oz/nQpbVkT7i4z XHBlD6TNOysByBlTLTUEce6QSwgT96junvNz3bdG4L4aHZWEDygoMqDccr61oXv3 G9jn/6DqQl7/JzryV+Ku1dl8E6oyK+DwTBYZdWTWIfJZClRX1iRjbyLFyzEsSzVA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeghedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice In-Reply-To: <87k0x876ls.fsf@gnus.org> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> Date: Sat, 05 Sep 2020 08:32:36 -0700 Message-ID: <87k0x8tf1n.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 05 Sep 2020 at 02:25PM +02, Lars Ingebrigtsen wrote: > In which case -- does the following fix this problem? It does indeed. Hope this patch can be applied. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 17:12:18 2020 Received: (at 43120) by debbugs.gnu.org; 5 Sep 2020 21:12:18 +0000 Received: from localhost ([127.0.0.1]:44244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEfTu-0004Kx-El for submit@debbugs.gnu.org; Sat, 05 Sep 2020 17:12:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEfTs-0004Ki-Rr for 43120@debbugs.gnu.org; Sat, 05 Sep 2020 17:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tw/fJu+7I4CsLnaz6GuWJUwQMcCgDTlvsG62IeUd2CM=; b=VKBuu2rWPPFtdfq768ncC85+UD T/3SOl+SQkr8C7G3/LpV+oHc7vFnUYUU3X5pQIXXMT1nK6QREm9tLdiA4QimdFObayeLaNewiyOUW hu3Ij5DuX6s60pAyb4fH4jSA5SZV7KbJ2+1WtbYbQsBS0+OHvEGeckRwTkGSvJz1m334=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEfTj-00039e-CV; Sat, 05 Sep 2020 23:12:10 +0200 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> X-Now-Playing: John Jastszebski's _Drone EP_: "Murphy's Law" Date: Sat, 05 Sep 2020 23:12:06 +0200 In-Reply-To: <87k0x8tf1n.fsf@iris.silentflame.com> (Sean Whitton's message of "Sat, 05 Sep 2020 08:32:36 -0700") Message-ID: <87363w2ajd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > On Sat 05 Sep 2020 at 02:25PM +02, Lars Ingebrigtsen wrote: > >> In which case -- does the following fix this problem? > > It does indeed. Hope this patch can be applied. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > On Sat 05 Sep 2020 at 02:25PM +02, Lars Ingebrigtsen wrote: > >> In which case -- does the following fix this problem? > > It does indeed. Hope this patch can be applied. Thanks for testing; I've now applied the patch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 17:12:24 2020 Received: (at control) by debbugs.gnu.org; 5 Sep 2020 21:12:25 +0000 Received: from localhost ([127.0.0.1]:44249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEfU0-0004LK-Nl for submit@debbugs.gnu.org; Sat, 05 Sep 2020 17:12:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEfTz-0004Kw-6Q for control@debbugs.gnu.org; Sat, 05 Sep 2020 17:12:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t11nDRtqgeMkSn6yiQgi1BVje13mKwY64RBl4U+/snw=; b=YzcCYlD4G2npj4O4fnl04GrMiF dkCpGWnzgQ9MV93AfIfJeyxvOtbBkCiDMYEiI5wxx5r/6rjJ7fsahDMf4hX8hcfqQHRexJuqwnt0h IrYq7stT27uegYHxY07mc6eR+t61z8FRCeK0JwjE82PJwwNz3TDxMBNzUYqgs23zMpFE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEfTr-0003A6-FC for control@debbugs.gnu.org; Sat, 05 Sep 2020 23:12:17 +0200 Date: Sat, 05 Sep 2020 23:12:14 +0200 Message-Id: <871rjg2aj5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43120 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43120 fixed close 43120 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43120 fixed close 43120 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 05 20:05:27 2020 Received: (at control) by debbugs.gnu.org; 6 Sep 2020 00:05:27 +0000 Received: from localhost ([127.0.0.1]:44366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEiBT-0004Id-4R for submit@debbugs.gnu.org; Sat, 05 Sep 2020 20:05:27 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:50223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEiBR-0004IQ-DV for control@debbugs.gnu.org; Sat, 05 Sep 2020 20:05:26 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6CEA686E for ; Sat, 5 Sep 2020 20:05:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 05 Sep 2020 20:05:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=hKelVCHfII9qStMxBMKSN/DHgwjeFSQ9C9jsFzdKcFM=; b=M2FISMf2 E15M3cum6RGpHMaQeogIJcWa8lptWn2TD8ID+8Yoht4JK9iR8UPGjvnqPKiaHacI Tu46xYGch1UhKAwt7t2wCcpSymw5paxpXcaHdxPJNo28PQ1q51/k844v9ZDOX978 uG4ujFCbMJuIin6Kngs/GW+i6xXx8JvVR5LMKdl6TJmyL8kOdxHhP4THFwd9N9z1 xrFiP3d0aQUNcOfNrbW53jjSy1goSATdvZ5D+I01gEEsufao8Qiw1VC7aR5CTb5i bFTrtlpELwCYzT75VJkgZ1CfoXv9Rnh5KXCXl5vQNSmJaq73mYo/qfvh+/NteTEs snKj1vSvOXRPzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=hKelVCHfII9qStMxBMKSN/DHgwjeF SQ9C9jsFzdKcFM=; b=uwfUkrdPBc7bciwgGiPaakcj+isU2Wea2cQ5t8oOVROkH CfQSFSCSqP4lYGTHaUhsC1JfjR7uD0madV8EBwqhNPZprCDcjfNP9SzDDFNLmbZk lHjNFpHAi3zHj+39k0GkJeb6hCN9K1cMHicNGhpcOrPh4PRWrcTkaYi+zFKfxoAa xRBFsxRvHgAP1KJhq4cCboP7XIQwm1ddflK8q7eMqKGG0uq/0P+qCvW1f7/yoa05 6s0bktg9JjcY+pm7ezOlwyqhYJ5fmVyijF1EFgpsxyRKCaWEQjqFYG3zQoAc1bN1 4ZhIdhI8Sjzy6Llq5AG5Z43na1sDwQbH/aannDbGw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegiedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehttdertddttd dtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphif hhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepleelgeejhedvheeghefgfe egvdfhvdefffefheejtdegfeehffeitdefteejueehnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtth honhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: control@debbugs.gnu.org Subject: merge duplicates Date: Sat, 05 Sep 2020 17:05:17 -0700 Message-ID: <874kob4vnm.fsf@iris.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) forcemerge 43120 43083 thanks -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 14:27:03 2020 Received: (at 43120) by debbugs.gnu.org; 6 Sep 2020 18:27:03 +0000 Received: from localhost ([127.0.0.1]:47146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEzNW-0005Cy-DH for submit@debbugs.gnu.org; Sun, 06 Sep 2020 14:27:02 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:38095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEzNU-0005CY-9k; Sun, 06 Sep 2020 14:27:00 -0400 Received: by mail-wr1-f41.google.com with SMTP id g4so12778903wrs.5; Sun, 06 Sep 2020 11:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=r+mR28t0SILD0wD+2BPqgIhAzAmRzpvV9cLqZalhMj8=; b=bA0z6avjrIjnPNI9rYGYf2cCdtkI5pvZGzqdAGapVzIlPfltH0DoqCPO/0uxreN6hK XNJqhOHmvVt5nISEBzqB7Jwy7dk54YBSBFRPkARJmTL5KpdDfHK+SeclYhGmhzW7XWl1 9KVViX7RwPQ032JGUfrd7xLw5ukjTf89ktml1SiKDiCoEhmJ6UgdGP4x2296eordIIJ6 LZRr6KPDsIJ3pwv0j+Vu5RtRHzqhoz7uzFQchFKdq9QLSv2V7Eo+S3kUk/BcDEBXqDsh sCJH6SGamgXrgkr0ZkZ+Lvee8WEIJNPa4MoCVOu7Oe8r2Yhoq+X44MiwDexCZ9lic7MS s/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=r+mR28t0SILD0wD+2BPqgIhAzAmRzpvV9cLqZalhMj8=; b=g49KcZLr4XnCQHUGx1puxWueUMvVbWMDruM6hPxbNaN+hYtMPI2tkDK+xa/FzVNOMb ZjRdxwV/znq1pM+/jZBnpJshx1otghjGW4ZucHuxwdNAYp/FzSnXJzS0dK7nXFulGaP0 /SSTErH92iaCMDFODiDie51dc3+6zM+v3amC9s4EWvycw2P3uLdw+eWpPFBCZ56y95u5 WXhaXlPpw2ItDw3c2fMLq7vWsCZoZUx4TO5009+LKvMFOgIp9VXKBoKg1Xw4l/fdcEzo ojI8YOXWfIkspgAXbxHEKKTwGt4LdL5YjTFesVmjk5xHSoFVAHm7gf2ulNLaZ5vFagaQ UySA== X-Gm-Message-State: AOAM533DioKRa3Lfc9Aao9mcBR8Dcm6UQtBHPdYjkPkw+gEoty4HZ9EG jkQRlFXzNDVILDnM9CMnHEe1/CLSoDM= X-Google-Smtp-Source: ABdhPJwCspVhfctmQVKNFAvZN5Cp/Ib6qYmVdBlVClTC31VOiECmGrfwj0yaVBFtOGnT0uq9EWJMZg== X-Received: by 2002:adf:f903:: with SMTP id b3mr18471983wrr.142.1599416814135; Sun, 06 Sep 2020 11:26:54 -0700 (PDT) Received: from krug (93.102.201.41.rev.optimus.pt. [93.102.201.41]) by smtp.gmail.com with ESMTPSA id w15sm24038800wro.46.2020.09.06.11.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 11:26:53 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> Date: Sun, 06 Sep 2020 19:26:47 +0100 In-Reply-To: <87363w2ajd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 05 Sep 2020 23:12:06 +0200") Message-ID: <87tuwaoj6g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Sean Whitton writes: > >> On Sat 05 Sep 2020 at 02:25PM +02, Lars Ingebrigtsen wrote: >> >>> In which case -- does the following fix this problem? >> >> It does indeed. Hope this patch can be applied. > > Thanks for testing; I've now applied the patch. I've had a look at the original problem that triggered this, and I wonder if this much simpler patch wouldn't be preferable. For one, it doesn't touch the minibuffer.el machinery (which is complicated as it is) or has any kind of complicated caching semantics. It just binds a different command to RET in icomplete-minibuffer-map, presumably solving 19032 (in my limited testing). It's also guaranteed not to affect fido-mode. I think something like this is the way to go for a behaviour change such as this. Jo=C3=A3o --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Change-icomplete-show-matches-on-no-input-behaviour-.patch >From f4dc81e0c7be75ace3766ca16e2be8bdcc8f0627 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Sun, 6 Sep 2020 19:03:52 +0100 Subject: [PATCH] Change icomplete-show-matches-on-no-input behaviour for Icomplete only Fixes: bug#19032, bug#43120 Previous fixes to bug#19032 introduced bugs in Fido mode. This fix relies on a new command bound to RET. * etc/NEWS (Miscellaneous): Mention icomplete-show-matches-on-no-input. * lisp/icomplete.el (icomplete-show-matches-on-no-input): Add comment. (icomplete-minibuffer-map): Bind icomplete-ret. (icomplete-ret): New command. --- etc/NEWS | 6 ++++++ lisp/icomplete.el | 16 +++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 749b28ac3f..d40a4807ec 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -938,6 +938,12 @@ window after starting). This variable defaults to nil. ** Miscellaneous +--- +*** 'icomplete-show-matches-on-no-input' behavior change +Previously, choosing a different completion with commands like 'C-.' +and then hitting enter would choose the default completion. Doing +this will now choose the completion under point. + +++ *** The user can now customize how "default" values are prompted for. The new utility function 'format-prompt' has been added which uses the diff --git a/lisp/icomplete.el b/lisp/icomplete.el index f76ab28fb8..c4d5012af9 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -75,7 +75,11 @@ icomplete-tidy-shadowed-file-names selection process starts again from the user's $HOME.") (defcustom icomplete-show-matches-on-no-input nil - "When non-nil, show completions when first prompting for input." + "When non-nil, show completions when first prompting for input. +This also means that if you traverse the list of completions with +commands like `C-.' and just hit RET without typing any +characters, the match under point will be chosen instead of the +default." :type 'boolean :version "24.4") @@ -153,12 +157,22 @@ icomplete-post-command-hook (defvar icomplete-minibuffer-map (let ((map (make-sparse-keymap))) (define-key map [?\M-\t] 'icomplete-force-complete) + (define-key map (kbd "RET") 'icomplete-ret) (define-key map [?\C-j] 'icomplete-force-complete-and-exit) (define-key map [?\C-.] 'icomplete-forward-completions) (define-key map [?\C-,] 'icomplete-backward-completions) map) "Keymap used by `icomplete-mode' in the minibuffer.") +(defun icomplete-ret () + "Exit minibuffer for icomplete." + (interactive) + (if (and icomplete-show-matches-on-no-input + (car completion-all-sorted-completions) + (eql (icomplete--field-end) (icomplete--field-beg))) + (icomplete-force-complete-and-exit) + (exit-minibuffer))) + (defun icomplete-force-complete-and-exit () "Complete the minibuffer with the longest possible match and exit. Use the first of the matches if there are any displayed, and use -- 2.25.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 06:30:25 2020 Received: (at 43120) by debbugs.gnu.org; 7 Sep 2020 10:30:25 +0000 Received: from localhost ([127.0.0.1]:48187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEPp-0008S1-6G for submit@debbugs.gnu.org; Mon, 07 Sep 2020 06:30:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEPm-0008Jb-ED; Mon, 07 Sep 2020 06:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6FZFhH5n9tyPjo0DIjFSj+NNJQ0jNUR/5DgCeFsd14o=; b=VmCCs9gm+cAkRsKCE+HK44Kkcg XaHL4wKEjOVB/c1qKuZKcSsRRAkV7UasQUBHdxgr57oDjOaU6cbrdFeHXsCd4vY7IhrGsR2I2ilpR kXjHmlgMjryL8O8/cnN68Ze3yNly8HOjZtCSwpMGja31FQ7qZlm+u2EN0EtCNgcf2tt0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFEPd-00064j-Ax; Mon, 07 Sep 2020 12:30:15 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUrR6MsTq9ec7px h8ZcdsFLZ7qps9SZptCKmMpxgb21vto5X8L////C3AL4AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QJ BwoLHCukqa4AAAEuSURBVDjLrZPBSsNAEIZn32DGstBraFXwJpuaXotVvNa6UuhJqd3gsTQ29CYF iWfBV+jZQ9/PTdoEG2YKBYdAlv34d+b/swEFhLAtpD8FSuVAKVS0V5BvACIS1gEo8iLMn5qidsa2 8BCg/wHkLUgAkAc+EgHQ0QAFgJIi96F4wIdVAFbhx2LbeIMogaPHLb0j7TXz6QoKKZNCwPooNkFQ MIXFNy8ubx3sXopYwGdI3FwgKwSA8i0hCYixHziK/6cATxrtsG8D3Rk+9MJhu1c5vz1LM9d6akbP 7tssriZVj7d49vWZTZrnL/FFN47mFQg696dk7uxs1Ho316GtmqdBdJn1b5I0bKyM6RqzA3qRTMO1 c0m8fnTL1+X0o1RoGpDVm8HYamtXc7vhI/kpF7+VDmRfLEfkkgAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wN1QxMDoxMToyOCswMDowMO2vH8gAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDdUMTA6MTE6MjgrMDA6MDCc8qd0AAAAAElFTkSuQmCC X-Now-Playing: Artful Dodger's _It's All About the Stragglers_: "What You Gonna Do? feat. Craig David" Date: Mon, 07 Sep 2020 12:30:12 +0200 In-Reply-To: <87tuwaoj6g.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 06 Sep 2020 19:26:47 +0100") Message-ID: <87a6y1angr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > I've had a look at the original problem that triggered this, and I > wonder if this much simpler patch wouldn't be preferable. For one, it > doesn't touch the minibuffer.el machinery (which is compl [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I've had a look at the original problem that triggered this, and I > wonder if this much simpler patch wouldn't be preferable. For one, it > doesn't touch the minibuffer.el machinery (which is complicated as it > is) or has any kind of complicated caching semantics. It just binds a > different command to RET in icomplete-minibuffer-map, presumably solving > 19032 (in my limited testing). It's also guaranteed not to affect > fido-mode. That does look like a much simpler and less invasive way to implement this; yes. (And you'd presumably remove the stuff that was added for 19032 already?) But I was wondering whether there were any other use cases where the newly added stuff would be useful... but perhaps not? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 13:30:56 2020 Received: (at 43120) by debbugs.gnu.org; 7 Sep 2020 17:30:56 +0000 Received: from localhost ([127.0.0.1]:50717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKym-0000Wf-0t for submit@debbugs.gnu.org; Mon, 07 Sep 2020 13:30:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKyj-0000WJ-C5; Mon, 07 Sep 2020 13:30:53 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CDDD210022E; Mon, 7 Sep 2020 13:30:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5200710006F; Mon, 7 Sep 2020 13:30:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599499839; bh=FAF2x4vbsjloyiYKqnPHY+AfJzXXQzSWjMzpit/jx0E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SbY9crUsI9juTmPWJsAf3/hA4zZfAnNDVSVMglmccLz5UR0wQekTpjbR6PTFJvg// zKeInHzi2+E47zW54yUNHuIqEioFxFK3laJ3/lXDOhauPcsv/SJ1yQ5hbVnQpqzxci 9YKqWy2ni0c31FcC2z0SVsllHSudJZ0pcTjTVTcngjD6/ODs5W+0OK5jbRV+LFKV33 QlaloFIuFfBw6s/Lao/RFxDmc/+tcIicYwZmFs1eP7lHFOAY79IDcQ37RYiwZaTB5+ sA3GxVxeSVqEN9Fm+mxtcFxVpP1YrS1LiJqmcj7mrQ0gvxmDtXQUjsj9A4z9KAoXr1 q1vh4VBjZbT3w== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EB75512081D; Mon, 7 Sep 2020 13:30:38 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Date: Mon, 07 Sep 2020 13:30:38 -0400 In-Reply-To: <87tuwaoj6g.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sun, 06 Sep 2020 19:26:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think something like this is the way to go for a behaviour change such > as this. Looks fine to me. > + (define-key map (kbd "RET") 'icomplete-ret) Maybe use a `remap`ping instead? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 02:52:33 2020 Received: (at 43120) by debbugs.gnu.org; 8 Sep 2020 06:52:33 +0000 Received: from localhost ([127.0.0.1]:51718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFXUX-0008Bi-C9 for submit@debbugs.gnu.org; Tue, 08 Sep 2020 02:52:33 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFXUV-0008BP-Bb; Tue, 08 Sep 2020 02:52:31 -0400 Received: by mail-wr1-f51.google.com with SMTP id a17so17828685wrn.6; Mon, 07 Sep 2020 23:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KxAydsf2519t8+wHlNZKK3SJymJpM8IohbSxLcbKs/4=; b=fSDMLD4AHYGikYwssxh908AWmoJpyIkTE9jNrLYB4bZkSEUd23Vvxxsb4UqYeDAELg Mb+FfSEfVp3RIpShaOgXkx7YmkIHqEw9m6dbNFxuuGLMNKUr8d9qwfmUFsQfiWQ3pHen /Y+r2I+8IMkuBZvuvSwScv9OLrki/XUFt0SHQVLNzOjqa5W/NqKRs4kKeFuagFGVx1vQ 9XOBo3ZKDQnPdHt/PTikH9KB8V5VCBWO8IaPaEqKjep5kt2l6iBpD82izoIM2bKLcS8h 8V1847/rShfZnQmVVhVguxbXTTkyYL+QfWZTmF9DjIqErZZ7wIOl9a1p04/qoE9Lix7n 7i5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KxAydsf2519t8+wHlNZKK3SJymJpM8IohbSxLcbKs/4=; b=a9lwi28niWC0KcyS7TvW73ILPtDmFlOkdR1FaJLtFtfilOu+uKvwXsUJV975/02vlA lxy4HLRBMnDinW2bkmk1cDjMODDjxYl3dNQhX5/HLuTy78VF/myYz/rHEhtRVQ+1EVrq KuNMXfyU/UtMpo12pcom5cf/ePlEPZUGod8Lyp2rwZ/9a53R8Dpp8MJyQoVXxStfrx6t rE8DUnm7Qjua0GZzWqs2EU5LTv8O2dA8S4A+JNf3XMjr+TaZwvOGFUtAoIDle+uZxYkU qTKBQ8jdlOazO9IvjICasBiaxuP5xFrkW8hSrL9wdt6/rziV4vYrvt3RUYUypRtrXVnJ SIVg== X-Gm-Message-State: AOAM530BdCaOh9gw69vJ01nZ+7K/EjaOvbym7Lcss3Z71SBvA8SQoeSX 1KRF/tI2qkN3CMZwVcLDYZc= X-Google-Smtp-Source: ABdhPJzcRuxyqUqEFe6oWrxZBS90Ol2fjkPjIyexbagQwqljJMzbVWQbOslpNgyyF+Wgq36CwEin2g== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr24872366wro.362.1599547945339; Mon, 07 Sep 2020 23:52:25 -0700 (PDT) Received: from krug ([89.180.149.6]) by smtp.gmail.com with ESMTPSA id u126sm38563481wmu.9.2020.09.07.23.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:52:24 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Date: Tue, 08 Sep 2020 07:52:21 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 07 Sep 2020 13:30:38 -0400") Message-ID: <87eencwyje.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> I think something like this is the way to go for a behaviour change such >> as this. > > Looks fine to me. > >> + (define-key map (kbd "RET") 'icomplete-ret) > > Maybe use a `remap`ping instead? Yes, maybe makes sense. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 05:00:06 2020 Received: (at 43120) by debbugs.gnu.org; 8 Sep 2020 09:00:06 +0000 Received: from localhost ([127.0.0.1]:51905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZTx-00053r-CY for submit@debbugs.gnu.org; Tue, 08 Sep 2020 05:00:06 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZTv-00052m-SB; Tue, 08 Sep 2020 05:00:04 -0400 Received: by mail-wr1-f51.google.com with SMTP id a17so18212634wrn.6; Tue, 08 Sep 2020 02:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5NF3WaY49CTzxW8VNecAxLBUKag9T40oxui0434TBic=; b=cKXWeDOqOUf7HLBueFCNHv4XzTrvMSu5S8KIIzZp77J8cVcbQW+eh/CWURaDiNL6kJ PFhPZKYUNJqgmSaOhGiH1l4Ww2Z6KJdcsEh9GrOTaf6EQ36wvdZeXJ4GkarOW4bbOTyL gdHHFLou2geJKETWzkIEw4L4QKcPNUgUOb51WVVHh+6EYiM0T1X3o1prsu0u107PiGI3 ZkYd8Ht+BM0BZVgvBUn1w8OyqXivEg71PkCmfx7qDOTPZuk+IBtePpvmEcS+RMByRfYS yWzEBElLnt8vOTmdOZ+ltzJeETDRhzvWAZuoQNjghlVyesPgjjoY7afTRhQEeh8N7e+i hOyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5NF3WaY49CTzxW8VNecAxLBUKag9T40oxui0434TBic=; b=ZKNCAtAIRB0Ojz3iOJeJxGDYPhQubt4cE1SHMsDwO8JmF/LF788qrvlII07qaWK4AB TLM1Pq4+ufuRc3qgzpts6SNHtYfYIXH7E1bBvTmHcM1P1j3EeGVoKBdSQ74ps87iU598 fT1PfekGKpw4pSSQS2vARKDw3yLhGxd75U4IzlAC5UwO57ozE1a5viC1MqyK48gOhsFF vGpJkCeUc1g+ZrfZtq9Hrn8ScPlZgDAAmMf834fHW1YxjGajrX9jK5/bN47tJ+tUehuI lzZJjYm6BzbumOS7LE2B5jMCeHLtKpMvmwzdvUjHapLqwVBKHX+eYFmnxCEgxQskqiJR tisw== X-Gm-Message-State: AOAM5301jHBuFOvCx2F39Mz/HXjf30V2QIhAf7+OoB9pz9OelcjVzFtO d0L7VH/MTazmnq4ES8oHGMY= X-Google-Smtp-Source: ABdhPJwsKcdYejkNW+ynUcso3gneGt+Ur9WFeVO5rzii1hfJwlCQQjlhwNO8YaaH0p0td3k4URmwEw== X-Received: by 2002:adf:edd2:: with SMTP id v18mr24932732wro.242.1599555597967; Tue, 08 Sep 2020 01:59:57 -0700 (PDT) Received: from krug ([89.180.149.6]) by smtp.gmail.com with ESMTPSA id u66sm31313271wmg.44.2020.09.08.01.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 01:59:57 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Date: Tue, 08 Sep 2020 09:59:56 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 07 Sep 2020 13:30:38 -0400") Message-ID: <871rjcwsmr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> I think something like this is the way to go for a behaviour change such >> as this. > > Looks fine to me. Thanks, pushed. >> + (define-key map (kbd "RET") 'icomplete-ret) > > Maybe use a `remap`ping instead? I did that, too. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 10:01:32 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 14:01:32 +0000 Received: from localhost ([127.0.0.1]:60926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG0fD-0006OJ-La for submit@debbugs.gnu.org; Wed, 09 Sep 2020 10:01:31 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:60160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG0fA-0006Ks-Jg; Wed, 09 Sep 2020 10:01:30 -0400 Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 40DC91B44DF; Wed, 9 Sep 2020 23:01:26 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.15.2/8.15.2/Debian-20) with ESMTPS id 089E1O9q581093 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Sep 2020 23:01:26 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.15.2/8.15.2/Debian-20) with ESMTPS id 089E1OAw1235885 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Sep 2020 23:01:24 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.15.2/8.15.2/Submit) id 089E1Mlo1235884; Wed, 9 Sep 2020 23:01:22 +0900 From: OGAWA Hirofumi To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> Date: Wed, 09 Sep 2020 23:01:22 +0900 In-Reply-To: <871rjcwsmr.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Tue, 08 Sep 2020 09:59:56 +0100") Message-ID: <87y2ljcaml.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , Sean Whitton , Stefan Monnier , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) João Távora writes: > Stefan Monnier writes: > >>> I think something like this is the way to go for a behaviour change such >>> as this. >> >> Looks fine to me. > > Thanks, pushed. > >>> + (define-key map (kbd "RET") 'icomplete-ret) >> >> Maybe use a `remap`ping instead? > > I did that, too. > +(defun icomplete-ret () > + "Exit minibuffer for icomplete." > + (interactive) > + (if (and icomplete-show-matches-on-no-input > + (car completion-all-sorted-completions) > + (eql (icomplete--field-end) (icomplete--field-beg))) > + (icomplete-force-complete-and-exit) > + (exit-minibuffer))) This changed the behavior of RET from `minibuffer-complete-and-exit' to `exit-minibuffer'. Was that intention? What I noticed is the following. [before] emacs -Q M-x icomplete-mode C-xd /usr C-xk u ;; shows "Kill buffer (default usr): u(sr)" RET killed "usr" buffer [after] emacs -Q M-x icomplete-mode C-xd /usr C-xk u ;; shows "Kill buffer (default usr): u(sr)" RET No buffer named u Thanks. -- OGAWA Hirofumi From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 12:12:07 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 16:12:07 +0000 Received: from localhost ([127.0.0.1]:33053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG2ha-0006eL-Jb for submit@debbugs.gnu.org; Wed, 09 Sep 2020 12:12:06 -0400 Received: from mail-il1-f174.google.com ([209.85.166.174]:33481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG2hV-0006dh-1M; Wed, 09 Sep 2020 12:12:05 -0400 Received: by mail-il1-f174.google.com with SMTP id x2so2888113ilm.0; Wed, 09 Sep 2020 09:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/pXdUAS6lFsadA6/dGWq9L2YOOuwcEYJwvrHSUrFD6k=; b=LDbx+akDnRjI/gPCvtqGc0/q6jzBVcOdVBGX4atspF+71ES+/DP5JJBYEp3yjcdXMw QCd4acCdcLl9D6FYoFqvYjU7x/4ox9yKlRiL8hC7dF4pOT0NsXByAgaAUF1Wwf952dwA ah2o0eH9TF4a3KqW9ZboCqM7TyXw0tuK5dc42WcdZq0hU1IlSql/+A73g7Rb21XNTjdr WNdK1BxsbY3BuT1wIAtEVXXg6mo1hw69c7pa95S1KGRf6B4ywfrpTnSw8P7ZS02JahUU /HpvBI1WQTJr08eCg5cz6KSktbZW9co/NLgJwzUDtLmlUV4WYqSuKRGQ/q0wYS66a/3H MKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/pXdUAS6lFsadA6/dGWq9L2YOOuwcEYJwvrHSUrFD6k=; b=ACMv1UygU1hGVopwsuMkc6fUM9aqhqB4Zs2lDDDParLVf9shAzz3QGFgokYcPDeLGS lO+uakyZ3kfIaW5+U7PIvmmiJZduHvkX1Klrb2oLIBa1pm04AB61yPJZkMTSoclK6Qzj PnujcqIDIIi8nr84XzcjUecfFnMVt324pU36qwm8F3KdWZVcb6Ql0/UiEV/jCc36yPiK aPhB9/S1L4CfNNB0EVC8NeQ1rhSV+6Jm5oo2TtR4wrf2g6ZmLOLemSmMBn4uxccrgcBU hj594s5Lc78v/cVe4QJlh9tJlOsJZz8bjDGXGWYJbISjKDtLUYLm3DxJlFIzN41sAoUz lclQ== X-Gm-Message-State: AOAM533nKUqMPlf5jAm4KuYyL6NwiPvPSNtWDCIY2Q3YAuJT/cQgRYnw GnozUgsBBg7ZHT2S/UNiQkZARN9yP4R0KhyU6Kg= X-Google-Smtp-Source: ABdhPJzcM9OCDFZ5RyPyHudgEnl3jSp1wu7wuW0j5WQXJcteAOQLkhRHix3mH0db2W3RxZifmlzVmz3oA4GrV03WIMw= X-Received: by 2002:a92:b309:: with SMTP id p9mr2661036ilh.125.1599667915490; Wed, 09 Sep 2020 09:11:55 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> In-Reply-To: <87y2ljcaml.fsf@mail.parknet.co.jp> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 9 Sep 2020 17:11:43 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: OGAWA Hirofumi Content-Type: multipart/alternative; boundary="000000000000dc8b2605aee3b567" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , Sean Whitton , Stefan Monnier , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000dc8b2605aee3b567 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 9, 2020 at 3:01 PM OGAWA Hirofumi wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Stefan Monnier writes: > > > >>> I think something like this is the way to go for a behaviour change > such > >>> as this. > >> > >> Looks fine to me. > > > > Thanks, pushed. > > > >>> + (define-key map (kbd "RET") 'icomplete-ret) > >> > >> Maybe use a `remap`ping instead? > > > > I did that, too. > > > +(defun icomplete-ret () > > + "Exit minibuffer for icomplete." > > + (interactive) > > + (if (and icomplete-show-matches-on-no-input > > + (car completion-all-sorted-completions) > > + (eql (icomplete--field-end) (icomplete--field-beg))) > > + (icomplete-force-complete-and-exit) > > + (exit-minibuffer))) > > This changed the behavior of RET from `minibuffer-complete-and-exit' to > `exit-minibuffer'. Was that intention? > Nope, sorry. You're right. It should read minibuffer-complete-and-exit ther= e of course. Jo=C3=A3o --000000000000dc8b2605aee3b567 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 9, 2020 at 3:01 PM OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
=
Jo=C3=A3o T=C3=A1vo= ra <joaotavora= @gmail.com> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> I think something like this is the way to go for a behaviour c= hange such
>>> as this.
>>
>> Looks fine to me.
>
> Thanks, pushed.
>
>>> +=C2=A0 =C2=A0 (define-key map (kbd "RET") 'icom= plete-ret)
>>
>> Maybe use a `remap`ping instead?
>
> I did that, too.

> +(defun icomplete-ret ()
> +=C2=A0 "Exit minibuffer for icomplete."
> +=C2=A0 (interactive)
> +=C2=A0 (if (and icomplete-show-matches-on-no-input
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(car completion-all-sorted-c= ompletions)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(eql (icomplete--field-end) = (icomplete--field-beg)))
> +=C2=A0 =C2=A0 =C2=A0 (icomplete-force-complete-and-exit)
> +=C2=A0 =C2=A0 (exit-minibuffer)))

This changed the behavior of RET from `minibuffer-complete-and-exit' to=
`exit-minibuffer'. Was that intention?

=
Nope, sorry. You're right. It should read minibuffer-complet= e-and-exit there
of course.

Jo=C3=A3o
--000000000000dc8b2605aee3b567-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 13:52:20 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 17:52:20 +0000 Received: from localhost ([127.0.0.1]:34396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG4Ga-0001KP-1L for submit@debbugs.gnu.org; Wed, 09 Sep 2020 13:52:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG4GY-0001Jh-An; Wed, 09 Sep 2020 13:52:18 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C191B80D35; Wed, 9 Sep 2020 13:52:12 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 01ACC80723; Wed, 9 Sep 2020 13:52:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599673931; bh=w65XQ8gE4osdOQFIfsvq1ccPQWqoqXOa9TZh8ur4eK4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eFLBW9YC7mNeysOuRhpcWfWyIkk7lI8Dz6VPIu0SwCWc03p9MEFdcHec7hnIYXcmA USvo8kZ6f7mIEd7Y7MKWBS2mjqmsBg2UzEusz8tZhYFVC33nJtxRsDbflAFm1bIWj2 3c5M7ECD31X+4EIY81qby/j8oWsE/Rx50xrybGs/XWr5MRKfYsKOXFm2tpK8vZLug+ F6U7A9uO95sdFzAYq3H6PXAjpaffJRGgv0SV9C5V2PvNnwbGBc/62mbcSxPWRXfZF5 fcj/8yl5Yjv+j8mJj9ygHeOC+x//Wf5T5mThX1FvB1YwpygR3Z+JFoGMV61LLob/34 cAbfCnUdJUn3w== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8782112079C; Wed, 9 Sep 2020 13:52:10 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Date: Wed, 09 Sep 2020 13:52:10 -0400 In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Wed, 9 Sep 2020 17:11:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Nope, sorry. You're right. It should read minibuffer-complete-and-exit there > of course. IIRC this depends on whether the completion is `require-match` or not. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:04:12 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 19:04:12 +0000 Received: from localhost ([127.0.0.1]:34721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5O8-0005Pn-I4 for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:04:12 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5O6-0005PI-0E; Wed, 09 Sep 2020 15:04:11 -0400 X-Originating-IP: 91.129.97.241 Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C83D7E0002; Wed, 9 Sep 2020 19:03:59 +0000 (UTC) From: Juri Linkov To: OGAWA Hirofumi Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Organization: LINKOV.NET References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Date: Wed, 09 Sep 2020 21:58:03 +0300 In-Reply-To: <87y2ljcaml.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Wed, 09 Sep 2020 23:01:22 +0900") Message-ID: <87eena6b30.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , Lars Ingebrigtsen , Stefan Monnier , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> +(defun icomplete-ret () >> + "Exit minibuffer for icomplete." >> + (interactive) >> + (if (and icomplete-show-matches-on-no-input >> + (car completion-all-sorted-completions) >> + (eql (icomplete--field-end) (icomplete--field-beg))) >> + (icomplete-force-complete-and-exit) >> + (exit-minibuffer))) > > This changed the behavior of RET from `minibuffer-complete-and-exit' to > `exit-minibuffer'. Was that intention? What I noticed is the following. I confirm that this change broke icomplete-mode. Here is a test case that shows regression: M-x icomplete-mode RET M-x rgr RET Lisp error: (error "‘rgr’ is not a valid command name") Until yesterday it used to run 'rgrep'. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:13:40 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 19:13:40 +0000 Received: from localhost ([127.0.0.1]:34738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5XI-0005dR-5l for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:13:40 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:51762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5XF-0005d8-I6; Wed, 09 Sep 2020 15:13:38 -0400 Received: by mail-wm1-f46.google.com with SMTP id w2so3362933wmi.1; Wed, 09 Sep 2020 12:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5YGRHx5oa+q8uO7teXhj3ocKPiZYBpAmE4A/ELHfs28=; b=Ep8OAWKrYhjGKMsZ8pWcOCLaipMH5JtUWI0akPLDByHbt9hNkk4aT/Xi+3tdY+pw+h MUJ0ly0CBIUfqTYRa4bgvFlH6hxLNTM3cACAbPB+SOix+tt1+PVoc6kvyQSUzPNz9FVT xNwimD58vViQZLG9aogvjyYDINOPX8nthXGtw/BNDZCc+XDvtJNoW0dI6696XnUKfVYW tjh+O48qxcmuf9KL79U5Z1OzXvwipeUdqYGHj9bN7Zq/Ebq1o5wPrgdJmjKI8AxRCosn c4A01xEntH13WtAuoIevqDHniyAOaOBL+N6tfbJicUGzrg8k0FjGAvZ2mM1oIMD02m2G Ph5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5YGRHx5oa+q8uO7teXhj3ocKPiZYBpAmE4A/ELHfs28=; b=fNfM3IpjQUqBO4TUegJi0soD+OyfIT2P641qP7FItHrClPuMf797QNZe6yFUQuvSGc FNauAR/t2A6k90vXdL2puOUPteLxeH4FIBObqx269gCdlY2ZhkUq+cvOXnNWHmPMt0jB 4UW8REIk76LVMsNe5k3wQdQcbvlWAPo0HSLRurH63MKshtoIvsmWHCKgILRNiepLnPHk UIE5BO3kTuZwBTCYQYo1CBar3zjNM6qL+77NeD7oDtVn71Hz1lmCN+61acNIrhKGW0MQ LFNaOKcLIzhWQRUZ5BVeq1rhFjzW6+cdepS2/Xr8H4sGovjkZSFnIJucr6Ff2FZYejEO qH9A== X-Gm-Message-State: AOAM530HkZYoKfXUEMZfX7EOKdly0nGi5qGrDlNi3N/mCL0eAaOsYo8o AzN4KMZRR/COi+sgAeQQN5c= X-Google-Smtp-Source: ABdhPJzV0OInTkMG04X3zmwXFuDkMDsAFkdM6+bi+YvKj20IJC+PKAAndvrtro5UiYuXoxPINQUwHA== X-Received: by 2002:a1c:5a56:: with SMTP id o83mr5106611wmb.77.1599678811664; Wed, 09 Sep 2020 12:13:31 -0700 (PDT) Received: from krug ([89.180.151.22]) by smtp.gmail.com with ESMTPSA id m3sm80384wme.31.2020.09.09.12.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 12:13:31 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Date: Wed, 09 Sep 2020 20:13:28 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Sep 2020 13:52:10 -0400") Message-ID: <87k0x2vk4n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Nope, sorry. You're right. It should read minibuffer-complete-and-exit t= here >> of course. > > IIRC this depends on whether the completion is `require-match` or not. If so, shouldn't minibuffer-complete-and-exit take care of that? I mean, I've remapped the binding to _that_ command, so unless it's making some "(interactive)" magic, which it is not, calling it from lisp in the normal case as it should be completely equivalent. I've gone ahead and commited the fix, as it fixes Hirofumi's problem, as he described it. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:52:51 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 19:52:51 +0000 Received: from localhost ([127.0.0.1]:34809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG69D-0006au-BV for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:52:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG69A-0006aa-Kv; Wed, 09 Sep 2020 15:52:49 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B831D100234; Wed, 9 Sep 2020 15:52:42 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 12C6310006F; Wed, 9 Sep 2020 15:52:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599681161; bh=0PdfYnOFoeqAlXCnyCYrAanmqJYiJabtWUu415PX54g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eSrhKiRojd+6sMQ5h10bUC3NN1iPzqgabWl/ZimFIluWJd3h+i+dnzJ0X2BQc+25H ShCN8ZY8d3eimHftmNmwiAWv9DhJRuFBY+f49XUsj60/jPGOMXXszFV5XC3meUqfkE L3wupzKzfaYqTr9AjTV4+UnrZnsfhiEKiwEUVXsjat3E+OwXE+gI62+tCFghTRDscu VPfTknFqPe1mhgPXj2yGHYYRf5cod9lPehSpYh9f5cl5zsjH+i5fWVmhx3iEgmuliP lX/jINs0340dSJR/3TyAneoT4n6jsnugUpDiBiLoEdTGTNRpUpzpWoL8uBs0hG6+0A 3Rf0VeIofI1mA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 91678120319; Wed, 9 Sep 2020 15:52:40 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> Date: Wed, 09 Sep 2020 15:52:38 -0400 In-Reply-To: <87k0x2vk4n.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Wed, 09 Sep 2020 20:13:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> Nope, sorry. You're right. It should read minibuffer-complete-and-exit there >>> of course. >> IIRC this depends on whether the completion is `require-match` or not. > If so, shouldn't minibuffer-complete-and-exit take care of that? Yes and no: IIRC depending on `require-match`, RET is bound either to `minibuffer-complete-and-exit` or to `exit-minibuffer`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:55:00 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 19:55:00 +0000 Received: from localhost ([127.0.0.1]:34816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6BH-0006eb-Pq for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:54:59 -0400 Received: from mail-io1-f43.google.com ([209.85.166.43]:34075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6BF-0006eJ-Uy; Wed, 09 Sep 2020 15:54:58 -0400 Received: by mail-io1-f43.google.com with SMTP id m17so4563917ioo.1; Wed, 09 Sep 2020 12:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dn10GNF/GclEs36hao6BRVOgdWpZyL2Kio1Ixchhe6M=; b=es6SYQsN0KGen1MWUZcfxc2UCbU0MwGFR0iozEqn86nL+lgHDPWixgSj6lUpBtTCjA kaHkkHFH4DB14aLlz+dAyVXH71qVVpdltK2I/NgK3pNnhXiIlhBulMO05EBdKWtQugxu a29sPahWEUKpziJLcPOPvO+ByYp9T1OTylk+7JzKtyYfu01JU3/P1r7cUqIQ6P7Ztb9k Gg2uImJ5vXJ4CvhFr7G4YhSRpD3kbHL39riOevjrqJOsHJQncQfg/BM7nlA6V8MHK4eP Z+WI4aqMnLyPP8fXtyolgPJPXKEF5ZcIw2bEHMa3XxWCDYli135E91biSj5tIpYUtzN1 Ha/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dn10GNF/GclEs36hao6BRVOgdWpZyL2Kio1Ixchhe6M=; b=kvUv8CgX1/5dtE+63w0r6yXlD6OHX07Y6QV4z7sjaAN3KdOGfou64gTWhx/4dPVq2t mCck6jRjqrNGUIW/THQGGjYocBn9f6vfcxzzf5BYEIylMlaPfOKaZqgQYJJ37RfNPbds OaV/pTMOf5rC7eEbr51vblL0rea4syvj3obSyKH1kDASh244/y4e58SsE8S9QO5bb8qj SFVNgIJxHkxsrON6GpnJWkh4rCnWm9JV7Z+PbOOOjsTkEluFgLAYLI+QLRzGdpyeQ8qE mqP2uTgYNFPdzjaXan/R6rkBb76d/iko5ON89cXmRMqa0lMPi+u4kPAhsG2hiFwQ8vB4 qtQg== X-Gm-Message-State: AOAM53328mVY4hO4qKwIwr0KCymCkUGLJJWEyfRZ1qL9erJvuvg/yxok 1MChPT40BqX9tBvZg1hkmyx7NL8bZF+ImE3Apfw= X-Google-Smtp-Source: ABdhPJwJZNGjpv23wKFj4pvW9bm8HskwyiClNjjCYxkTTUbL+bualTc8Yc6zN4XkGpr+5pCammvsuxT21R+kUHRWajg= X-Received: by 2002:a6b:7c0d:: with SMTP id m13mr4679288iok.57.1599681292180; Wed, 09 Sep 2020 12:54:52 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 9 Sep 2020 20:54:39 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Stefan Monnier Content-Type: multipart/alternative; boundary="0000000000002ca0e605aee6d359" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002ca0e605aee6d359 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 9, 2020 at 8:52 PM Stefan Monnier wrote: > >>> Nope, sorry. You're right. It should read minibuffer-complete-and-exi= t > there > >>> of course. > >> IIRC this depends on whether the completion is `require-match` or not. > > If so, shouldn't minibuffer-complete-and-exit take care of that? > > Yes and no: IIRC depending on `require-match`, RET is bound either > to `minibuffer-complete-and-exit` or to `exit-minibuffer`. Bah, so the remap you suggested wouldn't work anyway. What to do? The good 'ol :filter trick? How does it go again? Jo=C3=A3o --0000000000002ca0e605aee6d359 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 9, 2020 at 8:52 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
=
>>> Nope, sorry.= You're right. It should read minibuffer-complete-and-exit there
>>> of course.
>> IIRC this depends on whether the completion is `require-match` or = not.
> If so, shouldn't minibuffer-complete-and-exit take care of that?
Yes and no: IIRC depending on `require-match`, RET is bound either
to `minibuffer-complete-and-exit` or to `exit-minibuffer`.

Bah, so the remap you suggested wouldn't work any= way.=C2=A0 What to do?
The good 'ol :filter trick? How d= oes it go again?

Jo=C3=A3o
--0000000000002ca0e605aee6d359-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:58:10 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 19:58:10 +0000 Received: from localhost ([127.0.0.1]:34823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6EM-0006jj-GP for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:58:10 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:46233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6EH-0006j9-NN; Wed, 09 Sep 2020 15:58:08 -0400 Received: by mail-io1-f47.google.com with SMTP id d18so4507389iop.13; Wed, 09 Sep 2020 12:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wHTWWe4CNWTkkwFaorYH+WOGUvP1qy3yohbZGUgh51g=; b=AfdOLXEIo4vrxFT3pGUK4JWK/DzwdzpogP85QUGY5xhfK9yx1m4ErF5Rf17lYVkMiK yWdkoFaAb7rvKxvoEOqSLvaQW5G9zLUO6MD1EEBrRO9ofWaMcHojGt70EuqdDiqT1zfR DDxJXCBg086dpgfyuldW5wmS4Is/qYxR39xl8elye5xzQ2DqVLlRS6VATxHYITR7iFdn u0/sSK+qpxUvVxvXXVSLUhLJtR6CopupiGMI2ayvg7ekx4VYlGkuHb37kWrguK0L9KS1 lPEC2wi9J08Nc4/JP3dBW7KQHwNwA/ii9xP1+UM5NpYNXctkbZMPFSyCbbIZWWZs7mpi i4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wHTWWe4CNWTkkwFaorYH+WOGUvP1qy3yohbZGUgh51g=; b=WR/9GAN863+RvhvIcggI/WfxJAXolVVaIBThds6pykLLqM+r3cMdwc6IL/hZe97r4s 0dKG0uwIjgHIbz1Js/7ripT70O5kUm9fdHiNsWoseMyGyKcOmPSW6S/OpRNBZ/V/4XvP UzMRzv+rLMovvh/HC95wHIabpCwkA73Tlmot1Wzs9v8JgDQhTbeSECEclVBbuVTMfDR0 kehz1SPXoSUv1YmSUSKODFgHAjYAxaGiHgNj14/LmecF3jOi5LlSTkdyoUWHpDVj9z4k 8vakoGs3Hgs8ODPH39bTwY/+eF8xONPYQXH1iAw67h+2RSyaPKhW7/PjtUnFiuHrayw1 Zypg== X-Gm-Message-State: AOAM530NLs+mjtQ1bHceVwsyAd6HuCWffyNoNo5qFQcQh0bXKvFFtyMC YB2JafF3mYqmpXFKpJrVlObetMlXYTQzr+qdW2g= X-Google-Smtp-Source: ABdhPJyVx86YUXb+AtYCqIYVqyefYWPutlHHudpYBTnSHOt+TMchabFyXK9+k6SxKKzlugV8L5ius7nHrW4FgCH1jR4= X-Received: by 2002:a02:cbda:: with SMTP id u26mr5538834jaq.71.1599681480168; Wed, 09 Sep 2020 12:58:00 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 9 Sep 2020 20:57:47 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Stefan Monnier Content-Type: multipart/alternative; boundary="00000000000061163505aee6de38" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000061163505aee6de38 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 9, 2020 at 8:54 PM Jo=C3=A3o T=C3=A1vora = wrote: > On Wed, Sep 9, 2020 at 8:52 PM Stefan Monnier > wrote: > >> >>> Nope, sorry. You're right. It should read >> minibuffer-complete-and-exit there >> >>> of course. >> >> IIRC this depends on whether the completion is `require-match` or not= . >> > If so, shouldn't minibuffer-complete-and-exit take care of that? >> >> Yes and no: IIRC depending on `require-match`, RET is bound either >> to `minibuffer-complete-and-exit` or to `exit-minibuffer`. > > > Bah, so the remap you suggested wouldn't work anyway. What to do? > The good 'ol :filter trick? How does it go again? > Alternatively (and a bit sillily), two remaps for two different commands: one for exit-minibuffer and one for minibuffer-complete-and-exit. Or check minibuffer-require-match which was recently added. Pick your poison. Jo=C3=A3o --00000000000061163505aee6de38 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 9, 2020 at 8:54 PM Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
On Wed, Sep 9, 2020= at 8:52 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>> Nope, sorry. You'= ;re right. It should read minibuffer-complete-and-exit there
>>> of course.
>> IIRC this depends on whether the completion is `require-match` or = not.
> If so, shouldn't minibuffer-complete-and-exit take care of that?
Yes and no: IIRC depending on `require-match`, RET is bound either
to `minibuffer-complete-and-exit` or to `exit-minibuffer`.

Bah, so the remap you suggested wouldn't work any= way.=C2=A0 What to do?
The good 'ol :filter trick? How d= oes it go again?

Alternatively = (and a bit sillily), two remaps for two different commands:
= one for exit-minibuffer and one for minibuffer-complete-and-exit.=C2=A0 Or<= /div>
check minibuffer-require-match which was recently added. Pick you= r
poison.

Jo=C3=A3o
--00000000000061163505aee6de38-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 16:36:03 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 20:36:03 +0000 Received: from localhost ([127.0.0.1]:34869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6p1-0007dO-Bu for submit@debbugs.gnu.org; Wed, 09 Sep 2020 16:36:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6oy-0007ck-SU; Wed, 09 Sep 2020 16:36:02 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0FEDA440F7F; Wed, 9 Sep 2020 16:35:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 756F5440F72; Wed, 9 Sep 2020 16:35:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599683753; bh=YgLh4Wr2GgdvBg5+TGnNOMGCtCWarRNvc2zuQx3mHp0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VKmC3VA1QC7h0TS9JtbMJjLrSATncNrOic37ll3AYA3mCwmDntPKe2yDZjdw1X5H2 IwMCwP39n5wm+KOlb2R7vG4Mnmjp8y8OBZXoq7JUtOjPDTrVPUH0TwBmJHNdqgcB0W EH4fA7GSQVVmUcp3xMnhP5cdDwCz82BG/IbWe12izPHaHVICqFZ7v+sE3i2kl+JDRC qVPKxJb8BOqYDKDRqJC3Of8wZnyZp4Z4JUaQouku/2wSeancmJ/DomyDbJ7V05nCP9 4bMf2YnWyANI6aNLkOG5Y6Qw26iFTf1qPVHyld+ZhuLyieyhkW09jVhF2CAtByA5n1 m3afoa94T5PcQ== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE0E112025D; Wed, 9 Sep 2020 16:35:52 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> Date: Wed, 09 Sep 2020 16:35:52 -0400 In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Wed, 9 Sep 2020 20:57:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Alternatively (and a bit sillily), two remaps for two different commands: > one for exit-minibuffer and one for minibuffer-complete-and-exit. I'd go with that, yes, Also, because it will handle the case where the user has added a binding to `minibuffer-complete-and-exit` to the keymap where RET is bound to `exit-minibuffer`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 18:08:57 2020 Received: (at 43120) by debbugs.gnu.org; 9 Sep 2020 22:08:57 +0000 Received: from localhost ([127.0.0.1]:35016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG8Gu-0003c6-RR for submit@debbugs.gnu.org; Wed, 09 Sep 2020 18:08:57 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:46455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG8Gs-0003bm-BK; Wed, 09 Sep 2020 18:08:55 -0400 Received: by mail-wr1-f49.google.com with SMTP id o5so4503357wrn.13; Wed, 09 Sep 2020 15:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fpep/0va5i6An5TwJ1g+b8jJ39PgYMoTZhjtBKWWL3k=; b=J56miASGivF3W55RBxKZFoaKkLhkALBoUvNjmWcPwCW04uln/7xOrkhQY5jFmjDZXu aB4UtKf1ebhNftGxsP6z4qR8SkuwmtnKcx6UHeFObyFuA7Y69LMqodDpSc3jan31ZGPx QjmnwV9Qzx+Mvox0Fy8EWvbQyfZ9rX43KHWveGOJXlrF8MV3mQMQ4rnhH5DoBkM5e6Ga YDFFVWfZrieOd3sMKRx3HfqUlIWxpuCKptKM4TMdjbcI05CFsid5k+n+leXDMYV9t9D5 Q4t1HtbHpFTC73LUObyq+1JpqClE9QfaF10WDFfFMkpQsW+VezGDXC2dSomCQpzn/unS nDGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fpep/0va5i6An5TwJ1g+b8jJ39PgYMoTZhjtBKWWL3k=; b=EQ74rneNT4rc4gwWdHqKytQEIDBp1NUZfuq2J3/ycMGteYB/VQoAvRTevkI/5SfDSw nAxJ5iBrh67DrOJGfLHgRWfazNC1haQNwZManKR5+D3PHNWEtaJE8TNA30lkIKIR2RmL DPt1fwmeB4Bl+4OPUZLWj8y0aSr2LK/NLFESN03PkXRjlsVHBVQJQqPxKhtPGJ0cufu4 jQFDc1pMiXigI++I/MvFFKY198lzZW3aEkTPD7xDqzN4f3s0Ao+tW8BldpbK1H5cOY1U XXfw8RCZYVcJ3ShYfpupjSy8pmwGk6dpJerwUpk/zAbsMMheVKhHrwkpDmZhlk44m8WX +72A== X-Gm-Message-State: AOAM5302JwioUaQkdkguOzRVPKD24poeBhhfYOPR750vCRdb0bx0f188 0e/vowLTGxr141Gpvka0sxA= X-Google-Smtp-Source: ABdhPJw4SRbMW4PJACZ3Tj5b/CVXu3fy877v15qVpyJS4SqiroD52KA4fjX8Kfy0bTJ6PiZK1WqMxw== X-Received: by 2002:a5d:4d51:: with SMTP id a17mr5932815wru.248.1599689328384; Wed, 09 Sep 2020 15:08:48 -0700 (PDT) Received: from krug (89-180-151-22.net.novis.pt. [89.180.151.22]) by smtp.gmail.com with ESMTPSA id g12sm5827917wro.89.2020.09.09.15.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 15:08:47 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> Date: Wed, 09 Sep 2020 23:08:44 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Sep 2020 16:35:52 -0400") Message-ID: <87ft7qvc0j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Alternatively (and a bit sillily), two remaps for two different commands: >> one for exit-minibuffer and one for minibuffer-complete-and-exit. > > I'd go with that, yes, > > Also, because it will handle the case where the user has added a binding > to `minibuffer-complete-and-exit` to the keymap where RET is bound to > `exit-minibuffer`. OK, how's this look? Though I'm starting to think that when require-match is nil, an icomplete user wouldn't want the new icomplete-show-matches-on-no-input behaviour anyway. But I'm not one of those. Else, if she does, doesn't it mean she wants fido-mode instead? The question is thus: remap exit-minibuffer or not? It means usually: exit with whatever has been input, which may well be the empty string. Jo=C3=A3o diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 4e546807b7..6d48aa84d4 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -157,21 +157,31 @@ icomplete-post-command-hook (defvar icomplete-minibuffer-map (let ((map (make-sparse-keymap))) (define-key map [?\M-\t] 'icomplete-force-complete) - (define-key map [remap minibuffer-complete-and-exit] 'icomplete-ret) + (define-key map [remap minibuffer-complete-and-exit] 'icomplete-comple= te-and-exit) + (define-key map [remap exit-minibuffer] 'icomplete-exit) (define-key map [?\C-j] 'icomplete-force-complete-and-exit) (define-key map [?\C-.] 'icomplete-forward-completions) (define-key map [?\C-,] 'icomplete-backward-completions) map) "Keymap used by `icomplete-mode' in the minibuffer.") =20 -(defun icomplete-ret () - "Exit minibuffer for icomplete." - (interactive) +(defun icomplete--maybe-force (fallback) + "Helper for `icomplete-complete-and-exit' and `icomplete-exit'." (if (and icomplete-show-matches-on-no-input (car completion-all-sorted-completions) (eql (icomplete--field-end) (icomplete--field-beg))) (icomplete-force-complete-and-exit) - (minibuffer-complete-and-exit))) + (funcall fallback))) + +(defun icomplete-complete-and-exit () + "Complete, then exit minibuffer for icomplete." + (interactive) + (icomplete--maybe-force #'minibuffer-complete-and-exit)) + +(defun icomplete-exit () + "Exit minibuffer for icomplete." + (interactive) + (icomplete--maybe-force #'exit-minibuffer)) =20 (defun icomplete-force-complete-and-exit () "Complete the minibuffer with the longest possible match and exit. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 00:36:56 2020 Received: (at 43120) by debbugs.gnu.org; 10 Sep 2020 04:36:56 +0000 Received: from localhost ([127.0.0.1]:35635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGEKO-0007FP-4W for submit@debbugs.gnu.org; Thu, 10 Sep 2020 00:36:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGEKL-0007F6-8W; Thu, 10 Sep 2020 00:36:54 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 993FD100271; Thu, 10 Sep 2020 00:36:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 82818100059; Thu, 10 Sep 2020 00:36:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599712600; bh=oBgLE25CqShwefNNrOYfhzGMywuTgGvZ7RzNYCn0794=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fn6DW3nvqbo7Iyg8zbuq58boALX07VC63P8JXfPpUqVVWHXGuE/70+KKjuS3zSBjA eNqTlB6/oyiPnA21SEZbIvXCEkSyO8RMQ37c6n5lMOwyY3OKsF78mJ60R8k1E3+4HO /hhlwqWGCD3KWAw+tNXtlZsYpUU7ndyRcSn14vVWbNtpjwW813zGB6wtHoYQc3ju6C yKxUs3vO0ophxayKHjBRevFl8p/1vtT4zgNgOXJP9+dL+dsYccsVSfQ47bCt7PKUoa 1ndMksvD2z347TMxepzJUmn8YTfr1gjwo6Kt50A7nBS7dltsZFcR5t5qqG5F/0/hss Q4u2TkotNVobA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3AC82120237; Thu, 10 Sep 2020 00:36:40 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> Date: Thu, 10 Sep 2020 00:36:39 -0400 In-Reply-To: <87ft7qvc0j.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Wed, 09 Sep 2020 23:08:44 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43120 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The question is thus: remap exit-minibuffer or not? Good question. I think if there is a default value (i.e. if exit-minibuffer would return that non-nil default when the minibuffer is empty), then I think it makes sense to use the new icomplete-show-matches-on-no-input, but if not, indeed we probably should return "" (otherwise we're making it impossible to return ""). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 14:53:21 2020 Received: (at 43120) by debbugs.gnu.org; 10 Sep 2020 18:53:21 +0000 Received: from localhost ([127.0.0.1]:41208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRhB-0005Gb-DR for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:53:21 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:60387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRh9-0005GF-1X; Thu, 10 Sep 2020 14:53:20 -0400 Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D8CF2200002; Thu, 10 Sep 2020 18:53:07 +0000 (UTC) From: Juri Linkov To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Organization: LINKOV.NET References: <8736433l4c.fsf@iris.silentflame.com> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> Date: Thu, 10 Sep 2020 21:51:34 +0300 In-Reply-To: <87ft7qvc0j.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Wed, 09 Sep 2020 23:08:44 +0100") Message-ID: <87lfhh8nyh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43120 Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, Stefan Monnier , Lars Ingebrigtsen , OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Though I'm starting to think that when require-match is nil, an > icomplete user wouldn't want the new icomplete-show-matches-on-no-input > behaviour anyway. This is confusing, I don't understand why behaviour of icomplete-show-matches-on-no-input should depend on require-match. Here are two examples that produce a different result. The first example is from hi-lock-read-face-name: (defvar hi-history nil) (icomplete-mode) (let ((icomplete-show-matches-on-no-input t) (defaults '("hi-yellow" "hi-green")) (hi-history '("hi-blue"))) (completing-read (format-prompt "Highlight using face" (car defaults)) obarray 'facep t nil 'hi-history defaults)) displays this prompt: Highlight using face (default hi-yellow): {link | menu | bold ... Typing RET returns "link" (and sometimes returns "hi-blue" from the history), but never returns the expected default value "hi-yellow". Whereas the second example from tab-bar-switch-to-tab works correctly since its arg require-match is nil: (let ((icomplete-show-matches-on-no-input t) (defaults '("yellow" "green")) (hi-history '("blue"))) (completing-read (format-prompt "Switch to tab by name" (car defaults)) defaults nil nil nil 'hi-history defaults)) displays this prompt: Switch to tab by name (default yellow): {green | yellow} Typing RET returns the default value "yellow", not the first candidate "green". This makes the behaviour of icomplete-show-matches-on-no-input unpredictable, and thus in some cases dangerous. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 15:15:36 2020 Received: (at 43120) by debbugs.gnu.org; 10 Sep 2020 19:15:36 +0000 Received: from localhost ([127.0.0.1]:41238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGS2h-0005oA-Vo for submit@debbugs.gnu.org; Thu, 10 Sep 2020 15:15:36 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGS2g-0005nq-KX; Thu, 10 Sep 2020 15:15:35 -0400 Received: by mail-wm1-f42.google.com with SMTP id l9so1483328wme.3; Thu, 10 Sep 2020 12:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=YgUdFFn8tPd8XaApra/ASmehqu8CYfqEUHLzfwob9RU=; b=pqMO9xpDjm6easyrF21iAZBUUZFqxeIJZw8ssKhRAV24Idy2tAdwB/8vprA1nzji4a 9kSCg0cEZ+Z2JAqIGfIPQwO9C4HDrya5v0yRQL/GmZik4asC++EOg0t/8XJSQCWShMmi wEUcnBbxYOPHjkL43DuHtxqpT23vJAnv3NcCv/KmKUjOAUKHUHlXCaHi5eoo/9hB7Gzr vtEaShL/Lz2Ujq75X3d/hZtG8LE0LX5nNJPu4Q7Ub/EJ//GPA0kxwX7HN+7CS7q6Rsfk FPSOw+Ug2CI/csJft3UknWNdUaZ1cXV8xy9Hz0RrItExH4jTfwQ4B5fOdOiZ0PMsgZGM qUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YgUdFFn8tPd8XaApra/ASmehqu8CYfqEUHLzfwob9RU=; b=NAq4w/H/l+B0DbYVh5ZnXlJXWr5O1lx8fI18oWOhPmXcMqV+6nxmmGnjY7Ey8khkCZ wE29HoCReh3DW4sFdmpGdIieRZWbcv3C/1goeTdo2yMcUKAUUwwjy8a2mnh1WcT7ZHwK NnK9OtfmhE+ZSBgqJ4OwKuPSuDSnkXKR8B+eaSvKDNXEhv53acOKJtfYr1STTT/QXJW3 5Ig2S2m3DMpDj5YOxZRsEXmFXp7khPDoE+jV9ekd6/Zkw90dvHYGVYpSD44m1186Z2mh Ow6JCywVY3NdUvR5qBvvd3wx1shv4uvZaFnwgrFkszOyPXxx1pOPyvt3PNHsh1kLmWVY GREg== X-Gm-Message-State: AOAM531+kzliNQcs8MAotP9R26eW4zNgRnOjDtjlMSlT3VrvA3bk0Omc U+WE4RgoUqlTgpuvdJ+Ehws= X-Google-Smtp-Source: ABdhPJx8SfkZtNB7ADatTSK++Tf895nunkKosR+RnhOs5G7a5r5JmB5ygHW1B3Xda4ziBgY88aB6aw== X-Received: by 2002:a1c:105:: with SMTP id 5mr1586527wmb.83.1599765328631; Thu, 10 Sep 2020 12:15:28 -0700 (PDT) Received: from krug ([89.180.146.237]) by smtp.gmail.com with ESMTPSA id o124sm4849958wmb.2.2020.09.10.12.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 12:15:27 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Juri Linkov Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> <87lfhh8nyh.fsf@mail.linkov.net> Date: Thu, 10 Sep 2020 20:15:25 +0100 In-Reply-To: <87lfhh8nyh.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 10 Sep 2020 21:51:34 +0300") Message-ID: <87363pv3xu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43120 Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, Stefan Monnier , Lars Ingebrigtsen , OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> Though I'm starting to think that when require-match is nil, an >> icomplete user wouldn't want the new icomplete-show-matches-on-no-input >> behaviour anyway. > > This is confusing, I don't understand why behaviour of > icomplete-show-matches-on-no-input should depend on require-match. > > Here are two examples that produce a different result. > > The first example is from hi-lock-read-face-name: > > (defvar hi-history nil) > (icomplete-mode) > (let ((icomplete-show-matches-on-no-input t) > (defaults '("hi-yellow" "hi-green")) > (hi-history '("hi-blue"))) > (completing-read > (format-prompt "Highlight using face" (car defaults)) > obarray 'facep t nil 'hi-history defaults)) > > displays this prompt: > > Highlight using face (default hi-yellow): {link | menu | bold ... > > Typing RET returns "link" (and sometimes returns "hi-blue" from the histo= ry), > but never returns the expected default value "hi-yellow". > > Whereas the second example from tab-bar-switch-to-tab > works correctly since its arg require-match is nil: > > (let ((icomplete-show-matches-on-no-input t) > (defaults '("yellow" "green")) > (hi-history '("blue"))) > (completing-read > (format-prompt "Switch to tab by name" (car defaults)) > defaults nil nil nil 'hi-history defaults)) > > displays this prompt: > > Switch to tab by name (default yellow): {green | yellow} > > Typing RET returns the default value "yellow", not the first candidate "g= reen". > > This makes the behaviour of icomplete-show-matches-on-no-input > unpredictable, and thus in some cases dangerous. I think I agree, but I've just tested this with the version of icomplete.el before I started messing with this stuff (commit c8472cc69d4bce7f53c9a62966245a4de3d99fbd) and I get exactly the same results as you. So I'd leave my work here for someone else to pick up on: To be clear, I just wanted to simplify/refactor the code to be less intrusive on minibuffer.el. I'm not much of an icomplete-mode user, more of a fido-mode user where these discrepancies are "fixed" by copying ido-mode's behaviour. Jo=C3=A3o From unknown Sat Aug 16 18:43:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Oct 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator