GNU bug report logs - #43117
[PATCH] Add .git-blame-ignore-revs file

Previous Next

Full log

Message #26 received at 43117 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Robert Pluim <rpluim <at> gmail.com>
Cc: 43117 <at> debbugs.gnu.org
Subject: Re: bug#43117: [PATCH] Add .git-blame-ignore-revs file
Date: Sun, 13 Sep 2020 02:42:23 +0200 (CEST)

[Message part 1 (text/plain, inline)]

OK, please see attached. Right now there are no extraneous whitespace changes, and the only changes I've made change if -> when in the eshell files.

> Pure re-indentation patches I thought were not acceptable unless
> accompanied by an actual code change near the re-indented lines.

With a .git-blame-ignore file of some sort, shouldn't this not be a hindrance?

> ----------------------------------------
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Sent: Mon Aug 31 23:03:23 CEST 2020
> To: Robert Pluim <rpluim <at> gmail.com>
> Cc: Brian Leung <leungbk <at> mailfence.com>, <43117 <at> debbugs.gnu.org>
> Subject: Re: bug#43117: [PATCH] Add .git-blame-ignore-revs file
> 
> 
> On 31.08.2020 23:57, Robert Pluim wrote:
> 
> >      Dmitry> Do we accept reindentation patches, though? Ones where the effective
> >      Dmitry> indentation does change.
> > 
> > Didnʼt we just have this thread? :-)
> 
> I might have missed it. :-(
> 
> > Pure re-indentation patches I thought were not acceptable unless
> > accompanied by an actual code change near the re-indented lines.
> 
> Okay.
> 
> Brian, could you re-submit patches without extra re-indentation?


-- 
Sent with https://mailfence.com
Secure and private email

[0001-eshell-Replace-single-clause-if-statements-with-when.patch (text/x-diff, attachment)]

[0002-Add-.git-blame-ignore-revs.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.