GNU bug report logs - #43108
[PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Rohleder <mike <at> rohleder.de>
Subject: bug#43108: closed (Re: [bug#43108] [PATCH] gnu: emacs-elisp-refs:
 Disable test failing on Emacs 27.1.)
Date: Tue, 01 Sep 2020 19:28:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#43108: [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 43108 <at> debbugs.gnu.org.

-- 
43108: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43108
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43108-done <at> debbugs.gnu.org
Subject: Re: [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing
 on Emacs 27.1.
Date: Tue, 01 Sep 2020 21:27:50 +0200

Hello Michael,

> My ert-runner fu is not good enough for a better hack. I tried
> '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it
> skipped all tests then.

Well your hack seems to work fine :) Pushed as
a73ccefe315cd16e9d0b31a00bbd61e6cc3042f5.

Thanks,

Mathieu

[Message part 3 (message/rfc822, inline)]

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.
Date: Sun, 30 Aug 2020 09:50:25 +0200

* gnu/packages/emacs-xyz.scm (emacs-elisp-refs)[arguments]:
Add phase to disable failing test "elisp-refs-next-match" on emacs27.
---
My ert-runner fu is not good enough for a better hack. I tried
'("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it
skipped all tests then.

 gnu/packages/emacs-xyz.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c6d95d9b83..cfc728b53e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14825,7 +14825,17 @@ continue.")
        ("emacs-undercover" ,emacs-undercover)))
     (arguments
      `(#:tests? #t
-       #:test-command '("ert-runner")))
+       #:test-command '("ert-runner")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'disable-refs-next-match-test
+           ;; Hack to disable the failing test for emacs27
+           ;; https://github.com/Wilfred/elisp-refs/issues/29
+           (lambda _
+             (substitute* "test/unit-test.el"
+               (("ert-deftest elisp-refs-next-match")
+                "defun elisp-refs-next-match"))
+             #t)))))
     (home-page "https://github.com/Wilfred/elisp-refs")
     (synopsis "Find callers of elisp functions or macros")
     (description "Find references to functions, macros or variables.  Unlike a
-- 
2.28.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.