From unknown Sat Aug 16 18:47:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1. Resent-From: Michael Rohleder Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Aug 2020 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43108 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43108@debbugs.gnu.org Cc: Michael Rohleder X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159877388619379 (code B ref -1); Sun, 30 Aug 2020 07:52:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Aug 2020 07:51:26 +0000 Received: from localhost ([127.0.0.1]:49461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCI7a-00052V-AJ for submit@debbugs.gnu.org; Sun, 30 Aug 2020 03:51:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:56752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCI7Y-00052N-8c for submit@debbugs.gnu.org; Sun, 30 Aug 2020 03:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCI7Y-0007eW-0W for guix-patches@gnu.org; Sun, 30 Aug 2020 03:51:24 -0400 Received: from wp224.webpack.hosteurope.de ([2a01:488:42:1000:50ed:84e7::]:36874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCI7V-0000L2-QL for guix-patches@gnu.org; Sun, 30 Aug 2020 03:51:23 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kCI7S-0000AJ-S0; Sun, 30 Aug 2020 09:51:18 +0200 Received: from [192.168.1.3] (helo=micha.rohleder.de) by www.rohleder.de with esmtp (Exim 4.94) (envelope-from ) id 1kCI7Q-00025N-Lw; Sun, 30 Aug 2020 09:51:18 +0200 From: Michael Rohleder Date: Sun, 30 Aug 2020 09:50:25 +0200 Message-Id: <20200830075025.17460-1-mike@rohleder.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1598773881;98167da7; X-HE-SMSGID: 1kCI7S-0000AJ-S0 Received-SPF: permerror client-ip=2a01:488:42:1000:50ed:84e7::; envelope-from=mike@rohleder.de; helo=wp224.webpack.hosteurope.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/30 03:51:19 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/emacs-xyz.scm (emacs-elisp-refs)[arguments]: Add phase to disable failing test "elisp-refs-next-match" on emacs27. --- My ert-runner fu is not good enough for a better hack. I tried '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it skipped all tests then. gnu/packages/emacs-xyz.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c6d95d9b83..cfc728b53e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -14825,7 +14825,17 @@ continue.") ("emacs-undercover" ,emacs-undercover))) (arguments `(#:tests? #t - #:test-command '("ert-runner"))) + #:test-command '("ert-runner") + #:phases + (modify-phases %standard-phases + (add-before 'check 'disable-refs-next-match-test + ;; Hack to disable the failing test for emacs27 + ;; https://github.com/Wilfred/elisp-refs/issues/29 + (lambda _ + (substitute* "test/unit-test.el" + (("ert-deftest elisp-refs-next-match") + "defun elisp-refs-next-match")) + #t))))) (home-page "https://github.com/Wilfred/elisp-refs") (synopsis "Find callers of elisp functions or macros") (description "Find references to functions, macros or variables. Unlike a -- 2.28.0 From unknown Sat Aug 16 18:47:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Michael Rohleder Subject: bug#43108: closed (Re: [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.) Message-ID: References: <87wo1dthzd.fsf@gnu.org> <20200830075025.17460-1-mike@rohleder.de> X-Gnu-PR-Message: they-closed 43108 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 43108@debbugs.gnu.org Date: Tue, 01 Sep 2020 19:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1598988482-3332-1" This is a multi-part message in MIME format... ------------=_1598988482-3332-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43108: [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43108@debbugs.gnu.org. --=20 43108: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43108 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1598988482-3332-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43108-done) by debbugs.gnu.org; 1 Sep 2020 19:28:01 +0000 Received: from localhost ([127.0.0.1]:57356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDBwm-0000rX-Oi for submit@debbugs.gnu.org; Tue, 01 Sep 2020 15:28:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDBwl-0000rK-4N for 43108-done@debbugs.gnu.org; Tue, 01 Sep 2020 15:27:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57450) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDBwf-00062Z-IS; Tue, 01 Sep 2020 15:27:53 -0400 Received: from [2a01:e0a:19b:d9a0:24e2:2545:c1f2:cf9e] (port=48734 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kDBwe-0001Js-Ds; Tue, 01 Sep 2020 15:27:53 -0400 From: Mathieu Othacehe To: Michael Rohleder Subject: Re: [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1. References: <20200830075025.17460-1-mike@rohleder.de> Date: Tue, 01 Sep 2020 21:27:50 +0200 In-Reply-To: <20200830075025.17460-1-mike@rohleder.de> (Michael Rohleder's message of "Sun, 30 Aug 2020 09:50:25 +0200") Message-ID: <87wo1dthzd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43108-done Cc: 43108-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Michael, > My ert-runner fu is not good enough for a better hack. I tried > '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it > skipped all tests then. Well your hack seems to work fine :) Pushed as a73ccefe315cd16e9d0b31a00bbd61e6cc3042f5. Thanks, Mathieu ------------=_1598988482-3332-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Aug 2020 07:51:26 +0000 Received: from localhost ([127.0.0.1]:49461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCI7a-00052V-AJ for submit@debbugs.gnu.org; Sun, 30 Aug 2020 03:51:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:56752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCI7Y-00052N-8c for submit@debbugs.gnu.org; Sun, 30 Aug 2020 03:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCI7Y-0007eW-0W for guix-patches@gnu.org; Sun, 30 Aug 2020 03:51:24 -0400 Received: from wp224.webpack.hosteurope.de ([2a01:488:42:1000:50ed:84e7::]:36874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCI7V-0000L2-QL for guix-patches@gnu.org; Sun, 30 Aug 2020 03:51:23 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kCI7S-0000AJ-S0; Sun, 30 Aug 2020 09:51:18 +0200 Received: from [192.168.1.3] (helo=micha.rohleder.de) by www.rohleder.de with esmtp (Exim 4.94) (envelope-from ) id 1kCI7Q-00025N-Lw; Sun, 30 Aug 2020 09:51:18 +0200 From: Michael Rohleder To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1. Date: Sun, 30 Aug 2020 09:50:25 +0200 Message-Id: <20200830075025.17460-1-mike@rohleder.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1598773881;98167da7; X-HE-SMSGID: 1kCI7S-0000AJ-S0 Received-SPF: permerror client-ip=2a01:488:42:1000:50ed:84e7::; envelope-from=mike@rohleder.de; helo=wp224.webpack.hosteurope.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/30 03:51:19 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Michael Rohleder X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/emacs-xyz.scm (emacs-elisp-refs)[arguments]: Add phase to disable failing test "elisp-refs-next-match" on emacs27. --- My ert-runner fu is not good enough for a better hack. I tried '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it skipped all tests then. gnu/packages/emacs-xyz.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c6d95d9b83..cfc728b53e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -14825,7 +14825,17 @@ continue.") ("emacs-undercover" ,emacs-undercover))) (arguments `(#:tests? #t - #:test-command '("ert-runner"))) + #:test-command '("ert-runner") + #:phases + (modify-phases %standard-phases + (add-before 'check 'disable-refs-next-match-test + ;; Hack to disable the failing test for emacs27 + ;; https://github.com/Wilfred/elisp-refs/issues/29 + (lambda _ + (substitute* "test/unit-test.el" + (("ert-deftest elisp-refs-next-match") + "defun elisp-refs-next-match")) + #t))))) (home-page "https://github.com/Wilfred/elisp-refs") (synopsis "Find callers of elisp functions or macros") (description "Find references to functions, macros or variables. Unlike a -- 2.28.0 ------------=_1598988482-3332-1--