GNU bug report logs - #43101
[PATCH] Add version number in release ISO

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43101: closed ([PATCH] Add version number in release ISO)
Date: Mon, 31 Aug 2020 14:15:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 31 Aug 2020 16:13:46 +0200
with message-id <20200831161346.5ed7ac86 <at> tachikoma.lepiller.eu>
and subject line Re: [bug#43101] [PATCH v2] Add version number in release ISO
has caused the debbugs.gnu.org bug report #43101,
regarding [PATCH] Add version number in release ISO
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43101: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43101
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add version number in release ISO
Date: Sat, 29 Aug 2020 15:44:45 +0200

[Message part 3 (text/plain, inline)]

Hi,

I've recently proposed a patch to libosinfo database, and they
suggested that we add the version number to the ISO label, so the tool
can differentiate and identify the ISOs. See
https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/202

The first patch adds the --label option to guix system, and it sets the
label for the boot partition.  The second patch simply uses it and adds
a --label option to the release target in the Makefile.

[0001-guix-system-Add-label-option.patch (text/x-patch, attachment)]

[0002-Makefile.am-Set-iso-label.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: 43101-done <at> debbugs.gnu.org
Subject: Re: [bug#43101] [PATCH v2] Add version number in release ISO
Date: Mon, 31 Aug 2020 16:13:46 +0200

Le Mon, 31 Aug 2020 08:18:44 +0200,
Mathieu Othacehe <othacehe <at> gnu.org> a écrit :

> Hey Julien,
> 
> Thanks for the v2 :)
> 
> >                    (inherit iso9660-image)
> > -                  (operating-system installation-os))))
> > +                  (operating-system installation-os)
> > +                  (partitions (match (image-partitions
> > iso9660-image)
> > +                                ((boot others ...)
> > +                                 (cons
> > +                                   (partition
> > +                                     (inherit boot)
> > +                                     (label (string-append "GUIX_"
> > system "_"
> > +
> > %guix-version)))
> > +                                   others)))))))  
> 
> We could maybe factorize this in something like:
> 
> --8<---------------cut here---------------start------------->8---
> (define (image-with-label image label)
> ...)
> --8<---------------cut here---------------end--------------->8---
> 
> that would be put in (gnu system image).
> 
> Otherwise, looks fine to me :)
> 
> Thanks again,
> 
> Mathieu

Pushed as 036f23f053ee6bd34c6d387debb4a9166561dd02 to
7b2ac4768721ccab1782daad99a7cb1be0ed01ee, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.