From unknown Mon Aug 18 14:13:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#4310 <4310@debbugs.gnu.org> To: bug#4310 <4310@debbugs.gnu.org> Subject: Status: Flymake standardizing(slightly) patch Reply-To: bug#4310 <4310@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:13:27 +0000 retitle 4310 Flymake standardizing(slightly) patch reassign 4310 emacs submitter 4310 Jimmy Yuen Ho Wong severity 4310 wishlist tag 4310 patch thanks From wyuenho@gmail.com Tue Sep 1 22:25:59 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Sep 2009 05:25:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=AWL,FOURLA,FVGT_m_MULTI_ODD, IMPRONONCABLE_2,MIXEDBDN,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n825PwFU023023 for ; Tue, 1 Sep 2009 22:25:59 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MiiM1-0004q6-Ic for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 01:25:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MiiLv-0004pe-Jn for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 01:25:55 -0400 Received: from [199.232.76.173] (port=58902 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiiLv-0004pb-F0 for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 01:25:51 -0400 Received: from mail-yw0-f178.google.com ([209.85.211.178]:39209) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MiiLv-0002aJ-6i for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 01:25:51 -0400 Received: by ywh8 with SMTP id 8so1007790ywh.14 for ; Tue, 01 Sep 2009 22:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type; bh=lgcLfjgr+CP77jZ3My+QDCtxxUXCXBFp+3mA76DP8q4=; b=ofPdL2UqUdOuTwAFasDsuAf+tPBe/mx9QVtM/G+9IHMnigZqJEC8cEVw0SSB8NnWsZ VScUjfHTgQFfc4TwmoCXXmqj7iDLELKj8G8b9r3u0su821MC0aSkIuUcb8rSRlJCdRAb joCROwwSDy3hBkQ/tIIv10IrUiZxMRsVdoiQc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; b=jNRccwu5YOWvjXEJStNQne6umIW+8kaCCl9sbi68SUn7w43LqQFzpds3QspwzoT4Tn L0NGlAa9FVbCIpOdpCgdKxmU4fD6s+5bAv/lUxGCGbXei7HSb1vh0jLLTa8FeoQYybsn tWeyXMr7NAiLkYd1PXPwvDMaajDE+Z7LAsV8U= Received: by 10.91.54.22 with SMTP id g22mr5753825agk.80.1251869150330; Tue, 01 Sep 2009 22:25:50 -0700 (PDT) Received: from MobileCat.local (146-115-23-49.c3-0.abr-ubr3.sbo-abr.ma.cable.rcn.com [146.115.23.49]) by mx.google.com with ESMTPS id 34sm1446400agc.31.2009.09.01.22.25.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 01 Sep 2009 22:25:49 -0700 (PDT) Message-ID: <4A9E01DC.3030903@gmail.com> Date: Wed, 02 Sep 2009 01:25:48 -0400 From: Jimmy Yuen Ho Wong User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Flymake standardizing(slightly) patch Content-Type: multipart/mixed; boundary="------------060900000708000405070304" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) This is a multi-part message in MIME format. --------------060900000708000405070304 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Emacs LISPers! I'm not sure if this issue has been raised before (searching the mailing list comes up nothing), but here it goes: I was frustrated with the fact that flymake-mode is the one minor-mode that I use often and complicated enough but doesn't come with anyway to extend it with hooks or keymaps. So I've patch the trunk flymake.el to be a little more emacsy. I've added a default keymap and a minor-mode hook to flymake, I was hoping this will make it into the next Emacs version. Comments welcome. Jimmy Yuen Ho Wong P.S The attached patch is in git format. --------------060900000708000405070304 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="flymake.el.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="flymake.el.patch" ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2ZseW1ha2UuZWwgYi9saXNwL3Byb2dtb2Rl cy9mbHltYWtlLmVsCmluZGV4IDY5ZWFjNTYuLmNiZDdkZDUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2ZseW1ha2UuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZmx5bWFrZS5lbApA QCAtMTMyMiwxMiArMTMyMiwzMCBAQCBGb3IgdGhlIGZvcm1hdCBvZiBMSU5FLUVSUi1JTkZP LCBzZWUgYGZseW1ha2UtbGVyLW1ha2UtbGVyJy4iCiAgIDpncm91cCAnZmx5bWFrZQogICA6 dHlwZSAnYm9vbGVhbikKIAorKGRlZnZhciBmbHltYWtlLXByZWZpeC1tYXAKKyAgKGxldCAo KG1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKSkpCisgICAgKGRlZmluZS1rZXkgbWFwICJzIiAn Zmx5bWFrZS1zdGFydC1zeW50YXgtY2hlY2spCisgICAgKGRlZmluZS1rZXkgbWFwICJuIiAn Zmx5bWFrZS1nb3RvLW5leHQtZXJyb3IpCisgICAgKGRlZmluZS1rZXkgbWFwICJwIiAnZmx5 bWFrZS1nb3RvLXByZXYtZXJyb3IpCisgICAgKGRlZmluZS1rZXkgbWFwICJtIiAnZmx5bWFr ZS1kaXNwbGF5LWVyci1tZW51LWZvci1jdXJyZW50LWxpbmUpCisgICAgbWFwKSkKKworKGRl ZnZhciBmbHltYWtlLW1vZGUtbWFwCisgIChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1h cCkpKQorICAgIChkZWZpbmUta2V5IG1hcCAiXEMtYzsiIGZseW1ha2UtcHJlZml4LW1hcCkK KyAgICBtYXApCisgICJUaGUga2V5bWFwIHByb3ZpZGVzIHRoZSBkZWZhdWx0IGZseW1ha2Ut bW9kZSBiaW5kaW5ncy4iKQorCisoZGVmdmFyIGZseW1ha2UtbW9kZS1ob29rIG5pbAorICAi TW9kZSBob29rIGZvciBgZmx5bWFrZS1tb2RlYC4gVGhpcyBob29rIGlzIHJ1biBfX2JlZm9y ZV9fCitzeW50YXggY2hlY2sgaGFwcGVucywgYnV0IGFmdGVyIGFsbCB0aGUgaW5pdGlhbGl6 YXRpb24gaXMgZG9uZS4iKQorCiA7OzsjIyNhdXRvbG9hZAogKGRlZmluZS1taW5vci1tb2Rl IGZseW1ha2UtbW9kZQogICAiTWlub3IgbW9kZSB0byBkbyBvbi10aGUtZmx5IHN5bnRheCBj aGVja2luZy4KIFdoZW4gY2FsbGVkIGludGVyYWN0aXZlbHksIHRvZ2dsZXMgdGhlIG1pbm9y IG1vZGUuCiBXaXRoIGFyZywgdHVybiBGbHltYWtlIG1vZGUgb24gaWYgYW5kIG9ubHkgaWYg YXJnIGlzIHBvc2l0aXZlLiIKLSAgOmdyb3VwICdmbHltYWtlIDpsaWdodGVyIGZseW1ha2Ut bW9kZS1saW5lCisgIDpncm91cCAnZmx5bWFrZSA6bGlnaHRlciBmbHltYWtlLW1vZGUtbGlu ZSA6a2V5bWFwIGZseW1ha2UtbW9kZS1tYXAKICAgKGNvbmQKIAogICAgOzsgVHVybmluZyB0 aGUgbW9kZSBPTi4KQEAgLTEzNDQsNiArMTM2Miw4IEBAIFdpdGggYXJnLCB0dXJuIEZseW1h a2UgbW9kZSBvbiBpZiBhbmQgb25seSBpZiBhcmcgaXMgcG9zaXRpdmUuIgogICAgICAgKHNl dHEgZmx5bWFrZS10aW1lcgogICAgICAgICAgICAgKHJ1bi1hdC10aW1lIG5pbCAxICdmbHlt YWtlLW9uLXRpbWVyLWV2ZW50IChjdXJyZW50LWJ1ZmZlcikpKQogCisgICAgICAocnVuLWhv b2tzICdmbHltYWtlLW1vZGUtaG9vaykKKwogICAgICAgKHdoZW4gZmx5bWFrZS1zdGFydC1z eW50YXgtY2hlY2stb24tZmluZC1maWxlCiAgICAgICAgIChmbHltYWtlLXN0YXJ0LXN5bnRh eC1jaGVjaykpKSkKIAo= --------------060900000708000405070304-- From rgm@gnu.org Wed Sep 2 23:02:07 2009 Received: (at 4310) by emacsbugs.donarmstrong.com; 3 Sep 2009 06:02:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n83625YM030108 for <4310@emacsbugs.donarmstrong.com>; Wed, 2 Sep 2009 23:02:06 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Mj5OX-0004bQ-AW; Thu, 03 Sep 2009 02:02:05 -0400 From: Glenn Morris To: Jimmy Yuen Ho Wong Cc: 4310@debbugs.gnu.org Subject: Re: bug#4310: Flymake standardizing(slightly) patch References: <4A9E01DC.3030903@gmail.com> X-Spook: Indigo SHA Arnett dictionary BLU-97 A/B North Korea PGP X-Ran: /R!V(2x']?Ul;Zeq|Bb3&3UnV\Irol&J$"dQWi{@f`Gs#l?,#*@Q>&snCj$!@.%#Flf^Z@ X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 03 Sep 2009 02:02:05 -0400 In-Reply-To: <4A9E01DC.3030903@gmail.com> (Jimmy Yuen Ho Wong's message of "Wed, 02 Sep 2009 01:25:48 -0400") Message-ID: <4pljkwbm76.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Jimmy Yuen Ho Wong wrote: > I've added a default keymap and a minor-mode hook to flymake With regards to the hook part, it already runs flymake-mode-hook, as you can see eg by: (add-hook 'flymake-mode-hook (lambda () (error "foo"))) The define-minor-mode macro takes care of this. There is no need for a hook to be defvar'd before use. From wyuenho@gmail.com Thu Sep 3 05:23:42 2009 Received: (at 4310) by emacsbugs.donarmstrong.com; 3 Sep 2009 12:23:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.211.171]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n83CNfFN007594 for <4310@emacsbugs.donarmstrong.com>; Thu, 3 Sep 2009 05:23:42 -0700 Received: by ywh1 with SMTP id 1so1970718ywh.9 for <4310@emacsbugs.donarmstrong.com>; Thu, 03 Sep 2009 05:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=qg5wDBIrUose7s5QuooxhJRF0m9OecobTqeu9WkMEnI=; b=h+Npkg1poIeulue4L5EyuHvHJLAbyCH/M2jy0I9URZj2jiZ8+7s0//jW/IlreVSCi0 1uGnFFnFlSgRmiHYve1Tp9jnjB9Y3qi7/sgb1iIOVxdbLhmZ/V1cUSq3utwuZ4yW+/ty 7vnj5NUcifkSKkFJjF0HtoJnOW56P58VMknvo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=wPCf1bvP2pVRdsTl16e8EjHYSGbjWLTmrHXcWGXn2nvan6z0jno66efevO1FPpdX3N PDF0nPGf5WKuROwvFsAMDrfEMWdMIGFchD2N37K8SjO30Mi7Kz641/EMj8myeJ6J0KLj my32L5kTJ1edmvfyceTmiCg05IMoalzlYONVQ= Received: by 10.91.7.17 with SMTP id k17mr7118805agi.24.1251980615457; Thu, 03 Sep 2009 05:23:35 -0700 (PDT) Received: from MobileCat.local (146-115-23-49.c3-0.abr-ubr3.sbo-abr.ma.cable.rcn.com [146.115.23.49]) by mx.google.com with ESMTPS id 39sm1793802agd.6.2009.09.03.05.23.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 03 Sep 2009 05:23:32 -0700 (PDT) Message-ID: <4A9FB543.10708@gmail.com> Date: Thu, 03 Sep 2009 08:23:31 -0400 From: Jimmy Yuen Ho Wong User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Glenn Morris CC: 4310@debbugs.gnu.org Subject: Re: bug#4310: Flymake standardizing(slightly) patch References: <4A9E01DC.3030903@gmail.com> <4pljkwbm76.fsf@fencepost.gnu.org> In-Reply-To: <4pljkwbm76.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Ah right. I missed that part of the documentation. Noob mistake. However, this brings me to a question, since all the initialization is essentially done before flymake finally runs syntax check at the end of the minor mode definition. If I want to run the minor mode hook before syntax check, but not after, what should I do? Also, I'd imagine some people might want to do something after syntax check is done too, like echoing to the minibuffer, or automatically jump to the first line of error etc. That means I should probably add a post-syntax-check hook. But it seems rather complicated due to the number of cases in which it may fail. Any suggestions? Glenn Morris wrote: > Jimmy Yuen Ho Wong wrote: > >> I've added a default keymap and a minor-mode hook to flymake > > With regards to the hook part, it already runs flymake-mode-hook, as > you can see eg by: > > (add-hook 'flymake-mode-hook (lambda () (error "foo"))) > > The define-minor-mode macro takes care of this. There is no need for a > hook to be defvar'd before use. From monnier@iro.umontreal.ca Thu Sep 3 08:28:48 2009 Received: (at 4310) by emacsbugs.donarmstrong.com; 3 Sep 2009 15:28:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n83Dhmfh021288 for <4310@emacsbugs.donarmstrong.com>; Thu, 3 Sep 2009 06:43:49 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoYFAMRkn0rO+KL0/2dsb2JhbACBU9kshBsFh3Q X-IronPort-AV: E=Sophos;i="4.44,325,1249272000"; d="scan'208";a="45077954" Received: from 206-248-162-244.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.244]) by ironport2-out.teksavvy.com with ESMTP; 03 Sep 2009 09:42:30 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1B0317F45; Thu, 3 Sep 2009 09:43:42 -0400 (EDT) From: Stefan Monnier To: Jimmy Yuen Ho Wong Cc: 4310@debbugs.gnu.org, Glenn Morris Subject: Re: bug#4310: Flymake standardizing(slightly) patch Message-ID: References: <4A9E01DC.3030903@gmail.com> <4pljkwbm76.fsf@fencepost.gnu.org> <4A9FB543.10708@gmail.com> Date: Thu, 03 Sep 2009 09:43:42 -0400 In-Reply-To: <4A9FB543.10708@gmail.com> (Jimmy Yuen Ho Wong's message of "Thu, 03 Sep 2009 08:23:31 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > However, this brings me to a question, since all the initialization is > essentially done before flymake finally runs syntax check at the end of the > minor mode definition. If I want to run the minor mode hook before syntax > check, but not after, what should I do? Change flymake-mode to offer this functionality. Maybe one way to do that is to move the (flymake-start-syntax-check) to after flymake-mode is over. E.g. by running it via run-with-timer. > Also, I'd imagine some people might want to do something after syntax check > is done too, like echoing to the minibuffer, or automatically jump to the > first line of error etc. That means I should probably > add a post-syntax-check hook. Yes, that would probably be a good addition. > But it seems rather complicated due to the number of cases in which it > may fail. Any suggestions? No, you'll have to study the code and/or reorganize it until you feel comfortable doing it. Stefan From geb-bug-gnu-emacs@m.gmane.org Thu Sep 3 22:13:35 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2009 05:13:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n845DV9E011994 for ; Thu, 3 Sep 2009 22:13:34 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjR74-0007fx-Rv for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 01:13:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjR6z-0007eB-4d for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 01:13:29 -0400 Received: from [199.232.76.173] (port=35276 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjR6y-0007e6-VR for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 01:13:25 -0400 Received: from lo.gmane.org ([80.91.229.12]:44803) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MjR6y-0004Ml-Lr for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 01:13:24 -0400 Received: from list by lo.gmane.org with local (Exim 4.50) id 1MjR6u-00051C-Fx for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 07:13:20 +0200 Received: from c-71-237-24-138.hsd1.co.comcast.net ([71.237.24.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 04 Sep 2009 07:13:20 +0200 Received: from kevin.d.rodgers by c-71-237-24-138.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 04 Sep 2009 07:13:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Kevin Rodgers Subject: Re: bug#4310: Flymake standardizing(slightly) patch Date: Thu, 03 Sep 2009 23:13:02 -0600 Lines: 9 Message-ID: References: <4A9E01DC.3030903@gmail.com> <4pljkwbm76.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-71-237-24-138.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) In-Reply-To: <4pljkwbm76.fsf@fencepost.gnu.org> Sender: news X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Glenn Morris wrote: > There is no need for a > hook to be defvar'd before use. No need by Emacs/Lisp, but for the user's sake. -- Kevin Rodgers Denver, Colorado, USA From rgm@gnu.org Fri Sep 4 09:27:50 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Sep 2009 16:27:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,ONEWORD,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n84GRmOw011422 for ; Fri, 4 Sep 2009 09:27:50 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Mjbdb-0004Fg-R9; Fri, 04 Sep 2009 12:27:48 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19105.16387.657386.295073@fencepost.gnu.org> Date: Fri, 4 Sep 2009 12:27:47 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes close 4328 reassign 4339 emacs,ns severity 4310 wishlist reassign 4329 emacs,solaris reassign 4330 emacs,solaris fixed 4330 23.1.50 reassign 4331 emacs,solaris reassign 4332 emacs,solaris fixed 4332 23.1.50 reassign 4327 spam reassign 4323 spam From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 10:58:12 2009 Received: (at control) by debbugs.gnu.org; 20 Dec 2009 15:58:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NMOAe-0006FH-7M for submit@debbugs.gnu.org; Sun, 20 Dec 2009 10:58:12 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NMOAc-0006FB-OB for control@debbugs.gnu.org; Sun, 20 Dec 2009 10:58:11 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nBKFvug3004692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 20 Dec 2009 07:57:56 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nBKFvuig021746; Sun, 20 Dec 2009 07:57:56 -0800 (PST) Date: Sun, 20 Dec 2009 07:57:56 -0800 (PST) Message-Id: <200912201557.nBKFvuig021746@godzilla.ics.uci.edu> From: Dan Nicolaescu To: control@debbugs.gnu.org Subject: X-Debbugs-No-Ack: yes Lines: 16 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nBKFvug3004692 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-0.155, required 5, autolearn=disabled, ALL_TRUSTED -1.44, MISSING_SUBJECT 1.28) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org tags 3597 + patch tags 3904 + patch tags 4142 + patch tags 4951 + patch tags 4448 + patch tags 4286 + patch tags 2159 + patch tags 2746 + patch tags 1643 + patch tags 1933 + patch tags 3175 + patch tags 3887 + patch tags 4310 + patch tags 4546 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 01:44:51 2016 Received: (at 4310) by debbugs.gnu.org; 28 Feb 2016 06:44:51 +0000 Received: from localhost ([127.0.0.1]:49482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZv63-000638-L0 for submit@debbugs.gnu.org; Sun, 28 Feb 2016 01:44:51 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:46025) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZv61-000630-MO for 4310@debbugs.gnu.org; Sun, 28 Feb 2016 01:44:50 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZv5f-00055g-0k; Sun, 28 Feb 2016 07:44:27 +0100 From: Lars Ingebrigtsen To: Jimmy Yuen Ho Wong Subject: Re: bug#4310: Flymake standardizing(slightly) patch References: <4A9E01DC.3030903@gmail.com> Date: Sun, 28 Feb 2016 17:44:22 +1100 In-Reply-To: <4A9E01DC.3030903@gmail.com> (Jimmy Yuen Ho Wong's message of "Wed, 02 Sep 2009 01:25:48 -0400") Message-ID: <87twktqqpl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aZv5f-00055g-0k X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457246667.75227@LRX1HjJw6LoCvlbngO7yAw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 4310 Cc: 4310@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Jimmy Yuen Ho Wong writes: > I was frustrated with the fact that flymake-mode is the one minor-mode > that I use often and complicated enough but doesn't come with anyway > to extend it with hooks or keymaps. So I've patch the trunk flymake.el > to be a little more emacsy. > > I've added a default keymap and a minor-mode hook to flymake, I was > hoping this will make it into the next Emacs version. [...] > +(defvar flymake-prefix-map > + (let ((map (make-sparse-keymap))) > + (define-key map "s" 'flymake-start-syntax-check) > + (define-key map "n" 'flymake-goto-next-error) > + (define-key map "p" 'flymake-goto-prev-error) > + (define-key map "m" 'flymake-display-err-menu-for-current-line) > + map)) > + > +(defvar flymake-mode-map > + (let ((map (make-sparse-keymap))) > + (define-key map "\C-c;" flymake-prefix-map) > + map) > + "The keymap provides the default flymake-mode bindings.") > + > +(defvar flymake-mode-hook nil > + "Mode hook for `flymake-mode`. This hook is run __before__ > +syntax check happens, but after all the initialization is done.") As Glenn said, the hook isn't needed, but I think the minor mode map might make sense. I've never used flymake, though, so I can't really say. Anybody? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 13:52:16 2019 Received: (at 4310) by debbugs.gnu.org; 27 Jun 2019 17:52:16 +0000 Received: from localhost ([127.0.0.1]:39542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYZD-0004RT-TD for submit@debbugs.gnu.org; Thu, 27 Jun 2019 13:52:16 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYZC-0004RK-AT for 4310@debbugs.gnu.org; Thu, 27 Jun 2019 13:52:14 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYZ7-0008IY-4t; Thu, 27 Jun 2019 19:52:13 +0200 From: Lars Ingebrigtsen To: Jimmy Yuen Ho Wong Subject: Re: bug#4310: Flymake standardizing(slightly) patch References: <4A9E01DC.3030903@gmail.com> <87twktqqpl.fsf@gnus.org> Date: Thu, 27 Jun 2019 19:52:08 +0200 In-Reply-To: <87twktqqpl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 28 Feb 2016 17:44:22 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> +(defvar flymake-prefix-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map "s" 'flymake-start-syntax-check) >> + (define-key map "n" 'flymake-goto-next-error) >> + (define-key map "p" [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 4310 Cc: 4310@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> +(defvar flymake-prefix-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map "s" 'flymake-start-syntax-check) >> + (define-key map "n" 'flymake-goto-next-error) >> + (define-key map "p" 'flymake-goto-prev-error) >> + (define-key map "m" 'flymake-display-err-menu-for-current-line) >> + map)) >> + >> +(defvar flymake-mode-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map "\C-c;" flymake-prefix-map) >> + map) >> + "The keymap provides the default flymake-mode bindings.") >> + >> +(defvar flymake-mode-hook nil >> + "Mode hook for `flymake-mode`. This hook is run __before__ >> +syntax check happens, but after all the initialization is done.") > > As Glenn said, the hook isn't needed, but I think the minor mode map > might make sense. > > I've never used flymake, though, so I can't really say. Anybody? Didn't seem to be much enthusiasm for this over the years, so it seems unlikely that progress will be made, and I'm closing this bug report. Please reopen if somebody wants to add that keymap... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 17:53:41 2019 Received: (at control) by debbugs.gnu.org; 30 Jun 2019 21:53:41 +0000 Received: from localhost ([127.0.0.1]:47413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhhlU-0001JK-Ou for submit@debbugs.gnu.org; Sun, 30 Jun 2019 17:53:40 -0400 Received: from quimby.gnus.org ([80.91.231.51]:45816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhhlS-0001JA-VQ for control@debbugs.gnu.org; Sun, 30 Jun 2019 17:53:39 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhhlP-0007ln-4B for control@debbugs.gnu.org; Sun, 30 Jun 2019 23:53:37 +0200 Date: Sun, 30 Jun 2019 23:53:34 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #4310 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 4310 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 4310 quit From unknown Mon Aug 18 14:13:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 29 Jul 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator