GNU bug report logs - #43096
[PATCH] gnu: emacs-erc-status-sidebar: Update to 0.1-2.b589b742.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43096 in the body.
You can then email your comments to 43096 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: emacs-erc-status-sidebar: Update to 0.1-2.b589b742.
Date: Sat, 29 Aug 2020 03:11:57 +0200

* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): Update to 0.1-2.b589b742.
[propagated-inputs]: removed emacs-seq.
[license]: changed to gpl3+.
---
emacs-seq seems to make lots of trouble in emacs27 (max-lisp-eval-depth).
I think, we should remove that dep everywhere (it's provided by emacs) and
mark it as deprecated or also remove it.

 gnu/packages/emacs-xyz.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0755926ffe..7a6eb2e878 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3486,8 +3486,8 @@ IRC bouncer with ERC.")
     (license license:expat)))
 
 (define-public emacs-erc-status-sidebar
-  (let ((commit "ea4189a1dbfe60117359c36e681ad7c389e2968c")
-        (revision "1"))
+  (let ((commit "b589b74245591257c9e666bd5cd25812e04b7a34")
+        (revision "2"))
     (package
       (name "emacs-erc-status-sidebar")
       (version (git-version "0.1" revision commit))
@@ -3499,9 +3499,8 @@ IRC bouncer with ERC.")
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "1hwlhzgx03z8891sblz56zdp8zj0izh72kxykgcnz5rrkyc3vfi3"))))
+          (base32 "08fvr5ba6gb3y52sypbdj236nxr5rl95zgz1b120scz6xal7mysy"))))
       (build-system emacs-build-system)
-      (propagated-inputs `(("emacs-seq" ,emacs-seq)))
       (home-page "https://github.com/drewbarbs/erc-status-sidebar")
       (synopsis "Hexchat-like activity overview for ERC channels")
       (description
@@ -3509,7 +3508,7 @@ IRC bouncer with ERC.")
 ERC, an Emacs client for IRC (Internet Relay Chat).  It relies on the
 @code{erc-track} module, and displays all the same information
 @code{erc-track} does in the mode line, but in an alternative format.")
-      (license license:expat))))
+      (license license:gpl3+))))
 
 (define-public emacs-shut-up
   (package
-- 
2.28.0

Message #8 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43096 <at> debbugs.gnu.org
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Fri, 28 Aug 2020 20:45:56 -0500

Michael Rohleder <mike <at> rohleder.de> writes:

> * gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): Update to 0.1-2.b589b742.
> [propagated-inputs]: removed emacs-seq.
> [license]: changed to gpl3+.
> ---
> emacs-seq seems to make lots of trouble in emacs27 (max-lisp-eval-depth).
> I think, we should remove that dep everywhere (it's provided by emacs) and
> mark it as deprecated or also remove it.
>
>  gnu/packages/emacs-xyz.scm | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 0755926ffe..7a6eb2e878 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3486,8 +3486,8 @@ IRC bouncer with ERC.")
>      (license license:expat)))
>  
>  (define-public emacs-erc-status-sidebar
> -  (let ((commit "ea4189a1dbfe60117359c36e681ad7c389e2968c")
> -        (revision "1"))
> +  (let ((commit "b589b74245591257c9e666bd5cd25812e04b7a34")
> +        (revision "2"))
>      (package
>        (name "emacs-erc-status-sidebar")
>        (version (git-version "0.1" revision commit))
> @@ -3499,9 +3499,8 @@ IRC bouncer with ERC.")
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 "1hwlhzgx03z8891sblz56zdp8zj0izh72kxykgcnz5rrkyc3vfi3"))))
> +          (base32 "08fvr5ba6gb3y52sypbdj236nxr5rl95zgz1b120scz6xal7mysy"))))
>        (build-system emacs-build-system)
> -      (propagated-inputs `(("emacs-seq" ,emacs-seq)))
>        (home-page "https://github.com/drewbarbs/erc-status-sidebar")
>        (synopsis "Hexchat-like activity overview for ERC channels")
>        (description
> @@ -3509,7 +3508,7 @@ IRC bouncer with ERC.")
>  ERC, an Emacs client for IRC (Internet Relay Chat).  It relies on the
>  @code{erc-track} module, and displays all the same information
>  @code{erc-track} does in the mode line, but in an alternative format.")
> -      (license license:expat))))
> +      (license license:gpl3+))))
>  
>  (define-public emacs-shut-up
>    (package

I might be mistaken, but I think the license change belongs in a
separate patch.

Brett Gilio

Message #11 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 43096 <at> debbugs.gnu.org, Michael Rohleder <mike <at> rohleder.de>
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Sat, 29 Aug 2020 03:51:00 +0200

[Message part 1 (text/plain, inline)]

Brett Gilio 写道：
>> -      (license license:expat))))
>> +      (license license:gpl3+))))
>>  
>>  (define-public emacs-shut-up
>>    (package
>
> I might be mistaken, but I think the license change belongs in a
> separate patch.

Not if the licence actually changed between versions.

If it's correcting a previously incorrect licence in Guix, then 
indeed it does.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 43096 <at> debbugs.gnu.org, Michael Rohleder <mike <at> rohleder.de>
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Fri, 28 Aug 2020 20:58:08 -0500

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Brett Gilio 写道：
>>> -      (license license:expat))))
>>> +      (license license:gpl3+))))
>>>   (define-public emacs-shut-up
>>>    (package
>>
>> I might be mistaken, but I think the license change belongs in a
>> separate patch.
>
> Not if the licence actually changed between versions.
>
> If it's correcting a previously incorrect licence in Guix, then indeed
> it does.
>
> Kind regards,
>
> T G-R

It's kind of a weird case where it is both? The LICENSE file has always
been GPL3, but the code header erroneously stated it as expat-style.

https://github.com/drewbarbs/erc-status-sidebar/commit/b589b74245591257c9e666bd5cd25812e04b7a34

I kind of lean on the side of a separate patch since the license never
really changed, but was an error both upstream and on our end as well.

Brett Gilio

Message #17 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 43096 <at> debbugs.gnu.org, Michael Rohleder <mike <at> rohleder.de>
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Fri, 28 Aug 2020 20:59:58 -0500

Brett Gilio <brettg <at> gnu.org> writes:

> Tobias Geerinckx-Rice <me <at> tobias.gr> writes:
>
>> Brett Gilio 写道：
>>>> -      (license license:expat))))
>>>> +      (license license:gpl3+))))
>>>>   (define-public emacs-shut-up
>>>>    (package
>>>
>>> I might be mistaken, but I think the license change belongs in a
>>> separate patch.
>>
>> Not if the licence actually changed between versions.
>>
>> If it's correcting a previously incorrect licence in Guix, then indeed
>> it does.
>>
>> Kind regards,
>>
>> T G-R
>
> It's kind of a weird case where it is both? The LICENSE file has always
> been GPL3, but the code header erroneously stated it as expat-style.
>
> https://github.com/drewbarbs/erc-status-sidebar/commit/b589b74245591257c9e666bd5cd25812e04b7a34
>
> I kind of lean on the side of a separate patch since the license never
> really changed, but was an error both upstream and on our end as well.
>
> Brett Gilio

Actually, the change of commits may not be necessary at all. There is no
code changes between the commits, and the license file is intact.

Message #20 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Brett Gilio <brettg <at> gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 43096 <at> debbugs.gnu.org
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Sun, 30 Aug 2020 03:29:48 +0200

[Message part 1 (text/plain, inline)]

Hey Brett, hey Tobias,

Brett Gilio <brettg <at> gnu.org> writes:
>> It's kind of a weird case where it is both? The LICENSE file has always
>> been GPL3, but the code header erroneously stated it as expat-style.
>>
>> https://github.com/drewbarbs/erc-status-sidebar/commit/b589b74245591257c9e666bd5cd25812e04b7a34
>>
>> I kind of lean on the side of a separate patch since the license never
>> really changed, but was an error both upstream and on our end as well.
>>
>> Brett Gilio
>
> Actually, the change of commits may not be necessary at all. There is no
> code changes between the commits, and the license file is intact.
>

Ok, here are 2 patches, one for the license and one for removing
emacs-seq:

[0001-gnu-emacs-erc-status-sidebar-Correct-license.patch (text/x-patch, inline)]

From 340699d5ceb2db40824a403399556536f2e07e23 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Sun, 30 Aug 2020 02:48:32 +0200
Subject: [PATCH] gnu: emacs-erc-status-sidebar: Correct license.

* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar)[license]: Set to GPL3+.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ff789ffedf..9975fc8366 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3509,7 +3509,7 @@ IRC bouncer with ERC.")
 ERC, an Emacs client for IRC (Internet Relay Chat).  It relies on the
 @code{erc-track} module, and displays all the same information
 @code{erc-track} does in the mode line, but in an alternative format.")
-      (license license:expat))))
+      (license license:gpl3+))))
 
 (define-public emacs-shut-up
   (package
-- 
2.28.0

[0001-gnu-emacs-erc-status-sidebar-Fix-for-emacs27.patch (text/x-patch, inline)]

From 028021a0654c3a82d951ec991d63d392c421324d Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Sun, 30 Aug 2020 03:03:48 +0200
Subject: [PATCH] gnu: emacs-erc-status-sidebar: Fix for emacs27.

* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar)[propagated-inputs]: remove emacs-seq.

This package works well with the seq library that is provided with emacs.
Current emacs-seq (0.20) is broken for emacs27. A fix seems on it's
way: https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00996.html
---
 gnu/packages/emacs-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9975fc8366..a2427112aa 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3501,7 +3501,6 @@ IRC bouncer with ERC.")
          (sha256
           (base32 "1hwlhzgx03z8891sblz56zdp8zj0izh72kxykgcnz5rrkyc3vfi3"))))
       (build-system emacs-build-system)
-      (propagated-inputs `(("emacs-seq" ,emacs-seq)))
       (home-page "https://github.com/drewbarbs/erc-status-sidebar")
       (synopsis "Hexchat-like activity overview for ERC channels")
       (description
-- 
2.28.0

[Message part 4 (text/plain, inline)]

-- 
"How should I know if it works? That's what beta testers are for. I only
coded it."
(Attributed to Linus Torvalds, somewhere in a posting)

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43096 <at> debbugs.gnu.org
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Sun, 30 Aug 2020 11:22:54 +0200

Hello,

Michael Rohleder <mike <at> rohleder.de> writes:

> I think, we should remove that dep everywhere (it's provided by emacs) and
> mark it as deprecated or also remove it.

I agree that the dependency should be removed from Emacs packages. The
emacs-seq package can be deprecated, indeed.

Regards,
-- 
Nicolas Goaziou

Message #26 received at 43096 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 43096 <at> debbugs.gnu.org
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Tue, 01 Sep 2020 05:48:57 +0200

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>> I think, we should remove that dep everywhere (it's provided by emacs) and
>> mark it as deprecated or also remove it.
>
> I agree that the dependency should be removed from Emacs packages. The
> emacs-seq package can be deprecated, indeed.

Pierre made a patch for bug #43138:
https://lists.gnu.org/archive/html/bug-guix/2020-08/msg00311.html

-- 
There are two reasons why we dont trust people.
First - we dont know them.
Second - we know them.

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 43096-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 43096-done <at> debbugs.gnu.org,
 Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to
 0.1-2.b589b742.
Date: Fri, 18 Dec 2020 14:18:32 +0100

Hi!

Michael Rohleder <mike <at> rohleder.de> skribis:

> From 340699d5ceb2db40824a403399556536f2e07e23 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Sun, 30 Aug 2020 02:48:32 +0200
> Subject: [PATCH] gnu: emacs-erc-status-sidebar: Correct license.
>
> * gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar)[license]: Set to GPL3+.

Applied, thanks!

The emacs-seq bit is already done, as discussed on IRC.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.