From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 01:24:53 2020 Received: (at submit) by debbugs.gnu.org; 27 Aug 2020 05:24:53 +0000 Received: from localhost ([127.0.0.1]:41376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBAP7-0005Zv-0r for submit@debbugs.gnu.org; Thu, 27 Aug 2020 01:24:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:37044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBAP3-0005Zl-JZ for submit@debbugs.gnu.org; Thu, 27 Aug 2020 01:24:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBAP3-0002sL-E9 for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 01:24:49 -0400 Received: from mail-yb1-f179.google.com ([209.85.219.179]:42823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBAP1-00080g-SJ for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 01:24:49 -0400 Received: by mail-yb1-f179.google.com with SMTP id a34so2271169ybj.9 for ; Wed, 26 Aug 2020 22:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=2Q7mZFOn6J76qKnf7L25hgvrRWc+wIZpXuYxl6RD3r0=; b=RZvpl0++sM5Xd1FlRU3P6hM5KKK/hiCUt6hj/MquqwHonFRR9QX9a/w8TE/+gyi6GV GkBaSxiyZ3sByM+vL8EOquodq/aeiVJTFixYdPNpk5t4spxesByyUkbSVbUr2Kbk4uaB /f0QRP4AYa15ny5EaFQtf5+ZItXDl0FDJZQ1wGehyboarV/wYtr51R/oHXZd4vJLLDgJ dCdAI/5oA9pQx6JiWXYr8MCyCCyA73I9m0rFY/UYZ0OI0vw56Q+Hl+UPtW6Ny7AuyaiQ bPc5QJ2l2Q6EoHwyo38Kwc2zWusk6kXWXN55g1F8EJK1w7+acLwfFHcifZMcdBtJQJoo NCKw== X-Gm-Message-State: AOAM533UfNhcsJ+6/REcwzRO0XIHeySsymywFBOSV+oXX9Ua6y3rdbSB db0flUWPGFpxrkyBkEquEDV7chz/Vb3Pnb5/1xFB4Zt2 X-Google-Smtp-Source: ABdhPJydcLSoDXfRb4YjuhCzf+C2QVWg3h6xejRpQaqY0dMIIHIyiz8IpG1VAy1qVBNxOlkQz3a4JrapVu6OK/wZ7Wk= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr27652234ybb.129.1598505886312; Wed, 26 Aug 2020 22:24:46 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Aug 2020 22:24:45 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 26 Aug 2020 22:24:45 -0700 Message-ID: Subject: Fix or remove broken flyspell-issue-welcome-flag option To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000086987005add527a7" Received-SPF: pass client-ip=209.85.219.179; envelope-from=stefankangas@gmail.com; helo=mail-yb1-f179.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 01:24:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --00000000000086987005add527a7 Content-Type: text/plain; charset="UTF-8" The flyspell-issue-welcome-flag option is supposed to control whether or not a welcome message is shown when enabling flyspell-mode: "Welcome to Flyspell. Use C-. or Mouse-3 to correct words." This does not work; flyspell-mode does not show such a message. >From digging in the sources, it's not clear to me if this has worked at all since 2002 or so. I didn't bother with a full investigation, so I might be overlooking something. In any case, I see three options: 1. Fix it. I have attached a patch here which does that. The message is mildly annoying, but could be useful to beginners. (And it's easy to disabled using the mentioned variable.) 2. Fix it, but change the default to nil. I think this is pointless, since this would mostly be useful to beginners. 3. Remove the code and make the option obsolete. Any opinions or preferences? --00000000000086987005add527a7 Content-Type: text/plain; charset="US-ASCII" Content-Disposition: attachment Content-Transfer-Encoding: base64 X-Attachment-Id: 4d0cb188731edfc3_0.2 Lgo= --00000000000086987005add527a7 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-flyspell-welcome-message.patch" Content-Disposition: attachment; filename="0001-Fix-flyspell-welcome-message.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 4d0cb188731edfc3_0.1 RnJvbSAwMzdhNzUxMGU3Yzg5ZmFjMzdiOWM1M2MyODJiNjY0MTQ5NWEyZmY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDI3IEF1ZyAyMDIwIDA3OjA3OjM5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Rml4IGZseXNwZWxsIHdlbGNvbWUgbWVzc2FnZQoKKiBsaXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5l bCAoZmx5c3BlbGwtbW9kZSwgZmx5c3BlbGwtbW9kZS1vbik6CkZpeCBzaG93aW5nIHdlbGNvbWUg bWVzc2FnZSB3aGVuIGBmbHlzcGVsbC1pc3N1ZS13ZWxjb21lLWZsYWcnIGFuZApgZmx5c3BlbGwt aXNzdWUtbWVzc2FnZS1mbGFnJyBhcmUgYm90aCBub24tbmlsLgotLS0KIGxpc3AvdGV4dG1vZGVz L2ZseXNwZWxsLmVsIHwgMTQgKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2Vy dGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXh0bW9kZXMvZmx5 c3BlbGwuZWwgYi9saXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbAppbmRleCA3OGE3NGRlNGU4Li4w MjQ2YTY0ZGQxIDEwMDY0NAotLS0gYS9saXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbAorKysgYi9s aXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbApAQCAtNTMzLDcgKzUzMyw3IEBAIGZseXNwZWxsLW1v ZGUKICAgICAgICAgICAocHJvZ24KICAgICAgICAgICAgICh3aGVuIGZseXNwZWxsLXVzZS1tb3Vz ZS0zLWZvci1tZW51CiAgICAgICAgICAgICAgIChmbHlzcGVsbC0tc2V0LXVzZS1tb3VzZS0zLWZv ci1tZW51ICdmbHlzcGVsbC11c2UtbW91c2UtMy1mb3ItbWVudSB0KSkKLQkgICAgKGZseXNwZWxs LW1vZGUtb24pKQorICAgICAgICAgICAgKGZseXNwZWxsLW1vZGUtb24gdCkpCiAJKGVycm9yICht ZXNzYWdlICJFcnJvciBlbmFibGluZyBGbHlzcGVsbCBtb2RlOlxuJXMiIChjZHIgZXJyKSkKIAkg ICAgICAgKGZseXNwZWxsLW1vZGUgLTEpKSkKICAgICAoZmx5c3BlbGwtbW9kZS1vZmYpKSkKQEAg LTYxMSw4ICs2MTEsMTIgQEAgZmx5c3BlbGwta2lsbC1pc3BlbGwtaG9vawogOzsqLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tKi8KIDs7KiAgICBmbHlzcGVsbC1tb2RlLW9uIC4uLiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICovCiA7OyotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0qLwotKGRlZnVuIGZseXNw ZWxsLW1vZGUtb24gKCkKLSAgIlR1cm4gRmx5c3BlbGwgbW9kZSBvbi4gIERvIG5vdCB1c2UgdGhp czsgdXNlIGBmbHlzcGVsbC1tb2RlJyBpbnN0ZWFkLiIKKyhkZWZ1biBmbHlzcGVsbC1tb2RlLW9u ICgmb3B0aW9uYWwgU0hPVy1NU0cpCisgICJUdXJuIEZseXNwZWxsIG1vZGUgb24uICBEbyBub3Qg dXNlIHRoaXM7IHVzZSBgZmx5c3BlbGwtbW9kZScgaW5zdGVhZC4KKworSWYgb3B0aW9uYWwgYXJn dW1lbnQgU0hPVy1NU0cgaXMgbm9uLW5pbCwgc2hvdyBhIHdlbGNvbWUgbWVzc2FnZQoraWYgYGZs eXNwZWxsLWlzc3VlLW1lc3NhZ2UtZmxhZycgYW5kIGBmbHlzcGVsbC1pc3N1ZS13ZWxjb21lLWZs YWcnCithcmUgYm90aCBub24tbmlsLiIKICAgKGlzcGVsbC1zZXQtc3BlbGxjaGVja2VyLXBhcmFt cykgOyBJbml0aWFsaXplIHZhcmlhYmxlcyBhbmQgZGljdHMgYWxpc3RzCiAgIChzZXRxIGlzcGVs bC1oaWdobGlnaHQtZmFjZSAnZmx5c3BlbGwtaW5jb3JyZWN0KQogICA7OyBsb2NhbCBkaWN0aW9u YXJpZXMgc2V0dXAKQEAgLTY0NCw4ICs2NDgsOCBAQCBmbHlzcGVsbC1tb2RlLW9uCiAJKHNldHEg Zmx5c3BlbGwtZ2VuZXJpYy1jaGVjay13b3JkLXByZWRpY2F0ZSBtb2RlLXByZWRpY2F0ZSkpKQog ICA7OyB0aGUgd2VsY29tZSBtZXNzYWdlCiAgIChpZiAoYW5kIGZseXNwZWxsLWlzc3VlLW1lc3Nh Z2UtZmxhZwotCSAgIGZseXNwZWxsLWlzc3VlLXdlbGNvbWUtZmxhZwotICAgICAgICAgICAoY2Fs bGVkLWludGVyYWN0aXZlbHktcCAnaW50ZXJhY3RpdmUpKQorICAgICAgICAgICBmbHlzcGVsbC1p c3N1ZS13ZWxjb21lLWZsYWcKKyAgICAgICAgICAgc2hvdy1tc2cpCiAgICAgICAobGV0KiAoKGJp bmRpbmcgKHdoZXJlLWlzLWludGVybmFsICdmbHlzcGVsbC1hdXRvLWNvcnJlY3Qtd29yZAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwgJ25vbi1hc2NpaSkpCiAg ICAgICAgICAgICAgKG1vdXNlLWJ1dHRvbiAoaWYgZmx5c3BlbGwtdXNlLW1vdXNlLTMtZm9yLW1l bnUKLS0gCjIuMjguMAoK --00000000000086987005add527a7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 04:42:50 2020 Received: (at 43065) by debbugs.gnu.org; 27 Aug 2020 08:42:50 +0000 Received: from localhost ([127.0.0.1]:41583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBDUf-0000Ki-JA for submit@debbugs.gnu.org; Thu, 27 Aug 2020 04:42:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBDUb-0000KR-2i for 43065@debbugs.gnu.org; Thu, 27 Aug 2020 04:42:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48739) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBDUV-0006p2-FU; Thu, 27 Aug 2020 04:42:39 -0400 Received: from [176.228.60.248] (port=3283 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBDUU-0007Ni-Mh; Thu, 27 Aug 2020 04:42:39 -0400 Date: Thu, 27 Aug 2020 11:42:25 +0300 Message-Id: <834koo32fi.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 26 Aug 2020 22:24:45 -0700) Subject: Re: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43065 Cc: 43065@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 26 Aug 2020 22:24:45 -0700 > > 1. Fix it. I have attached a patch here which does that. The message > is mildly annoying, but could be useful to beginners. (And it's > easy to disabled using the mentioned variable.) > > 2. Fix it, but change the default to nil. I think this is pointless, > since this would mostly be useful to beginners. > > 3. Remove the code and make the option obsolete. > > Any opinions or preferences? #1, please. Thanks for paying attention to this. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 05:06:43 2020 Received: (at 43065) by debbugs.gnu.org; 27 Aug 2020 09:06:43 +0000 Received: from localhost ([127.0.0.1]:41596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBDrn-0000tU-8J for submit@debbugs.gnu.org; Thu, 27 Aug 2020 05:06:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBDrl-0000tH-Gr for 43065@debbugs.gnu.org; Thu, 27 Aug 2020 05:06:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48937) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBDrg-0001AM-8U; Thu, 27 Aug 2020 05:06:36 -0400 Received: from [176.228.60.248] (port=4750 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBDrf-0002P6-97; Thu, 27 Aug 2020 05:06:35 -0400 Date: Thu, 27 Aug 2020 12:06:23 +0300 Message-Id: <83zh6g1mr4.fsf@gnu.org> From: Eli Zaretskii To: stefan@marxist.se In-Reply-To: <834koo32fi.fsf@gnu.org> (message from Eli Zaretskii on Thu, 27 Aug 2020 11:42:25 +0300) Subject: Re: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option References: <834koo32fi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43065 Cc: 43065@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 27 Aug 2020 11:42:25 +0300 > From: Eli Zaretskii > Cc: 43065@debbugs.gnu.org > > > From: Stefan Kangas > > Date: Wed, 26 Aug 2020 22:24:45 -0700 > > > > 1. Fix it. I have attached a patch here which does that. The message > > is mildly annoying, but could be useful to beginners. (And it's > > easy to disabled using the mentioned variable.) > > > > 2. Fix it, but change the default to nil. I think this is pointless, > > since this would mostly be useful to beginners. > > > > 3. Remove the code and make the option obsolete. > > > > Any opinions or preferences? > > #1, please. Btw, can we make this only display the welcome message if flyspell-mode is invoked interactively? Your patch makes this unconditional, which I don't think was the original intent. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 05:27:23 2020 Received: (at 43065) by debbugs.gnu.org; 27 Aug 2020 09:27:23 +0000 Received: from localhost ([127.0.0.1]:41603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEBn-0001Mp-0u for submit@debbugs.gnu.org; Thu, 27 Aug 2020 05:27:23 -0400 Received: from mail-yb1-f179.google.com ([209.85.219.179]:38373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEBj-0001MX-I2 for 43065@debbugs.gnu.org; Thu, 27 Aug 2020 05:27:21 -0400 Received: by mail-yb1-f179.google.com with SMTP id e187so2586340ybc.5 for <43065@debbugs.gnu.org>; Thu, 27 Aug 2020 02:27:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=LDyd7hStdfbZDXFBPqfZCd5LKS+YOzvmIshW2vInRx0=; b=U9vrILhCO91HDmQqgdQ1OW6TiRuqWzIYvA7gxBS/KFTxheaLTMANPhKEHwX57VhCt0 omHlAf0EvvQURwdWBbBnzDNN565K8MQ3IaXjV+gvBD9g92HTHIfSFZfk5W/fWh8odWrx VqagkjFOy/yv2FHqya1qb1Ls2aFEqLiz1P5OiiYYXxjJ6yE3BeXTXE3kYygh+B1vY/mc sP91H3OcNysJz9v6UM7dQRKWBaGvhYhnA9KUhF0CN0PMdDUQ5oEW6XniLVt84PnBoGXc Nass5y6udDEOHHG8+LRF+tjWtn72eGkZvkxVAhqKLFbUsJz61lkvtHvvtqFQ5aW+EfvL U3Ug== X-Gm-Message-State: AOAM5307jGnd99Vc8rljWzvjgHwjA5PrCDGBTjHcgWDjyRD6/XpM52vU RMBeQxD9CClyZcq80eIUBlqCfgoHb2izLwsuZWlJDQ97nVo= X-Google-Smtp-Source: ABdhPJycgThryes4++E3uKtxS9lD3GiVndYShGV9ymg1zJD4HvnPzgE9QV15AoRc9iob9HfkAKl9W5tP9afZLnt4Kkw= X-Received: by 2002:a25:7007:: with SMTP id l7mr26407461ybc.85.1598520433648; Thu, 27 Aug 2020 02:27:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Aug 2020 02:27:13 -0700 From: Stefan Kangas In-Reply-To: <83zh6g1mr4.fsf@gnu.org> References: <834koo32fi.fsf@gnu.org> <83zh6g1mr4.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 27 Aug 2020 02:27:13 -0700 Message-ID: Subject: Re: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43065 Cc: 43065@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > Btw, can we make this only display the welcome message if > flyspell-mode is invoked interactively? Your patch makes this > unconditional, which I don't think was the original intent. (I received your email less than a minute after pushing.) Your observation is correct, I think. Is this one of those places where we are forced to use (called-interactively-p 'interactive)? Or can we add an optional argument to `define-minor-mode' somehow? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 05:27:26 2020 Received: (at 43065) by debbugs.gnu.org; 27 Aug 2020 09:27:26 +0000 Received: from localhost ([127.0.0.1]:41607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEBq-0001N9-8K for submit@debbugs.gnu.org; Thu, 27 Aug 2020 05:27:26 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:42242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEBo-0001Md-Ry for 43065@debbugs.gnu.org; Thu, 27 Aug 2020 05:27:25 -0400 Received: by mail-yb1-f182.google.com with SMTP id a34so2577492ybj.9 for <43065@debbugs.gnu.org>; Thu, 27 Aug 2020 02:27:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=1Nl+Rhm8376O75127i108Yy75xLTCDq0skXHKVDhZ3o=; b=RIHXN7uW/VQUuLbWy0zCDYzDQtv3RT/KgS+OvldVQ0reYUrhUno56i5ki5TepZPXlB dEh2+IgJi/dwhAIMYo1YvATvUmxspwyG7dJs2YazB9jrNNUR+a2ruzbKNFcQC/9UdGI0 H0tclxRxfn40Tuki/3nmvGQ/LD2vGIHgmAjrO8FVfzwbS/ODnYvqBM7mzdzRqqE70OCc ofA4l8uaVWX8mOdyLFchgiMtvPVASKFfJtw3y1icssyxsEWj+uTARyQkz2NmdEnIBYFY pWl51fpTUy/w/gL5but7WOev6Hur3OVoRooaXtcnaYyNfnceSJfULXKShbOry6pyb9TX vZew== X-Gm-Message-State: AOAM531ZD7rhBMSq7tHolnwn75Ekc7Sr0NWiVsE6hGOCYqaaOUjzRGcM L/iZRLfx5POnHRkc+dGPxFPsjXJ+GMvJ+66gIb8P6SfASqU= X-Google-Smtp-Source: ABdhPJzjATeNc5zdv4LzQPqwhFURU01CwaIZnzHRnXKMBQS4izpxflwH7agjHtraEHuk2RYdRy/gOtRxO7wbbTnMVNY= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr28691900ybb.129.1598520439459; Thu, 27 Aug 2020 02:27:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Aug 2020 02:27:19 -0700 From: Stefan Kangas In-Reply-To: <834koo32fi.fsf@gnu.org> References: <834koo32fi.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 27 Aug 2020 02:27:19 -0700 Message-ID: Subject: Re: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43065 Cc: 43065@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 43065 28.1 thanks Eli Zaretskii writes: >> 1. Fix it. I have attached a patch here which does that. The message >> is mildly annoying, but could be useful to beginners. (And it's >> easy to disabled using the mentioned variable.) >> >> 2. Fix it, but change the default to nil. I think this is pointless, >> since this would mostly be useful to beginners. >> >> 3. Remove the code and make the option obsolete. >> >> Any opinions or preferences? > > #1, please. Fix pushed to master as commit 4766006d3c. Closing. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 05:32:20 2020 Received: (at 43065) by debbugs.gnu.org; 27 Aug 2020 09:32:20 +0000 Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEGa-0003PU-8s for submit@debbugs.gnu.org; Thu, 27 Aug 2020 05:32:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEGY-0003Jv-3q for 43065@debbugs.gnu.org; Thu, 27 Aug 2020 05:32:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49196) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBEGS-0004V5-PZ; Thu, 27 Aug 2020 05:32:12 -0400 Received: from [176.228.60.248] (port=2465 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBEGR-0005pU-O6; Thu, 27 Aug 2020 05:32:12 -0400 Date: Thu, 27 Aug 2020 12:31:59 +0300 Message-Id: <83wo1k1lkg.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 27 Aug 2020 02:27:13 -0700) Subject: Re: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option References: <834koo32fi.fsf@gnu.org> <83zh6g1mr4.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43065 Cc: 43065@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 27 Aug 2020 02:27:13 -0700 > Cc: 43065@debbugs.gnu.org > > Eli Zaretskii writes: > > > Btw, can we make this only display the welcome message if > > flyspell-mode is invoked interactively? Your patch makes this > > unconditional, which I don't think was the original intent. > > (I received your email less than a minute after pushing.) > > Your observation is correct, I think. > > Is this one of those places where we are forced to use > (called-interactively-p 'interactive)? Yes, I think so. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 05:47:38 2020 Received: (at 43065) by debbugs.gnu.org; 27 Aug 2020 09:47:38 +0000 Received: from localhost ([127.0.0.1]:41647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEVO-00045M-3s for submit@debbugs.gnu.org; Thu, 27 Aug 2020 05:47:38 -0400 Received: from mail-yb1-f171.google.com ([209.85.219.171]:38431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBEVM-000459-NK for 43065@debbugs.gnu.org; Thu, 27 Aug 2020 05:47:37 -0400 Received: by mail-yb1-f171.google.com with SMTP id e187so2613944ybc.5 for <43065@debbugs.gnu.org>; Thu, 27 Aug 2020 02:47:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=JMAPoUghcV4oR66wdBlcp6BNg6a9Q7SEqNFEINXmAIo=; b=VRuPteS+BK/X/7FcLxNLIHLlMcFNHhvdkaKrezUxsZxzKEXrCkcs9Gvt+xKlZ1LlmR 6ooM+4h+FcdxwJyKqF0oGh7siiO1ROUXlGu1a7VmwDoQmnuVs1AFR56O3k9Pf2D833Kk zxuRCBcbVbyuGxfnwSjSf1f3kXkdM6jYxE39G4oGn2DAZxHgo/RgQTE/mVbKJPUt2izI hOQwFoVuMFIHpqqY2tqXOMfQ0aE57SQyskMgFLtttc+vXZTgp3pKZhvPo3Vxkd139IQO e+c8YLYq7iobFj8OAjCv3OvrsJvprVKX3CAq7JSBgO485She9WBc4oX0h2GExNp5N2kc FqzA== X-Gm-Message-State: AOAM530Y3kocJnU76HjIrwIJsVhCg2LNecIqqzqF55WooXkJPhD1P7r3 nWghNmq0TpGRWGmLesWD/J8DmMeY04SsY1uXIXE= X-Google-Smtp-Source: ABdhPJz/t6S+63cPx3cViGeiwHamu87bW/4SvJtrCuKXaMOQRA1z6TskxvGt9PSc7D7aPVboAxUTdhqmi6jX2RbWKFY= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr28786080ybb.129.1598521651120; Thu, 27 Aug 2020 02:47:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Aug 2020 02:47:30 -0700 From: Stefan Kangas In-Reply-To: <83wo1k1lkg.fsf@gnu.org> References: <834koo32fi.fsf@gnu.org> <83zh6g1mr4.fsf@gnu.org> <83wo1k1lkg.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 27 Aug 2020 02:47:30 -0700 Message-ID: Subject: Re: bug#43065: Fix or remove broken flyspell-issue-welcome-flag option To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43065 Cc: 43065@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > Yes, I think so. OK, thanks. Pushed fix to master as commit f40260f121. From unknown Sat Aug 16 18:47:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Sep 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator