GNU bug report logs - #43015
git-fetched packages' working copy is not writable

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43015: closed (git-fetched packages' working copy is not
 writable)
Date: Thu, 04 Feb 2021 12:42:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 04 Feb 2021 07:41:10 -0500
with message-id <87k0rongyh.fsf <at> gmail.com>
and subject line Re: bug#43015: git-fetched packages' working copy is not writable
has caused the debbugs.gnu.org bug report #43015,
regarding git-fetched packages' working copy is not writable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43015: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43015
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: <bug-guix <at> gnu.org>
Subject: git-fetched packages' working copy is not writable
Date: Mon, 24 Aug 2020 11:13:59 +0200

[Message part 3 (text/plain, inline)]

Hi,

the working copy of a package build when the package was git-fetched is not
writable.

On the other hand, if it's url-fetched, it's perfectly writable.

Shall we fix this on core-updates ?

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 43015-done <at> debbugs.gnu.org, Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: bug#43015: git-fetched packages' working copy is not writable
Date: Thu, 04 Feb 2021 07:41:10 -0500

Hello,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote:
>> Hi,
>> 
>> the working copy of a package build when the package was git-fetched is not
>> writable.
>> 
>> On the other hand, if it's url-fetched, it's perfectly writable.
>> 
>> Shall we fix this on core-updates ?
>
> (ins)efraim <at> E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages
> gnu/packages/bioinformatics.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/code.scm:                    (add-after 'unpack 'make-files-writable
> gnu/packages/djvu.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/machine-learning.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/ocaml.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/ruby.scm:                    (add-after 'unpack 'make-files-writable
>
> My only concern would be if there were files which weren't supposed to
> be writable. We're building the package, not making changes to be
> submitted upstream or anything, so I don't see that as being a reason to
> hold back.
>
> I'm in favor

I've included the fix as part as the unpack phase, and pushed to
core-updates as commit 6129ebddbd.

Thanks for the report!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.