From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 05:14:12 2020 Received: (at submit) by debbugs.gnu.org; 24 Aug 2020 09:14:12 +0000 Received: from localhost ([127.0.0.1]:56027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA8YO-0004y1-9a for submit@debbugs.gnu.org; Mon, 24 Aug 2020 05:14:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:46630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA8YM-0004xt-PQ for submit@debbugs.gnu.org; Mon, 24 Aug 2020 05:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA8YM-0003Lu-KR for bug-guix@gnu.org; Mon, 24 Aug 2020 05:14:10 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:33444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA8YJ-0000hY-Le for bug-guix@gnu.org; Mon, 24 Aug 2020 05:14:10 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id A636A3365519 for ; Mon, 24 Aug 2020 11:14:03 +0200 (CEST) Date: Mon, 24 Aug 2020 11:13:59 +0200 From: Danny Milosavljevic To: Subject: git-fetched packages' working copy is not writable Message-ID: <20200824111359.4008ce30@scratchpost.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Rz3XXUgWmzHZFeQlcXMhsIO"; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=85.13.145.193; envelope-from=dannym@scratchpost.org; helo=dd26836.kasserver.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/24 05:14:04 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --Sig_/Rz3XXUgWmzHZFeQlcXMhsIO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, the working copy of a package build when the package was git-fetched is not writable. On the other hand, if it's url-fetched, it's perfectly writable. Shall we fix this on core-updates ? --Sig_/Rz3XXUgWmzHZFeQlcXMhsIO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9DhNcACgkQ5xo1VCww uqVjnQgAlViT4A8YjNv5uTgfo2WUtVxntyJslfOOPm6kP27lsQLRKOIwXB0bkkQg Wd8kBKow9ConVYzDJOdnATMQmmSD8hbn/aumTvhEk83QQE8LkeUIglmDcToqiX6v 1isKqXdc6MjoRNi7xXosWFPaP3guaATWyT0nRD84vrQrDAui30CkOLTQHzTnVNFX rQShNyhMAQdPoKbvaTZGHoRcFNzJo9SIO9HPl7afjW2oQoxPO1jAWjxTjX7c2eHO c47ScURQhBWTj/GV4bLd6vYtJX2OXuZVwmCcS2+zM+mEQ2A+FPCKw4w4i39OaHMG lkl1+V7UtQee67u021CtD07m7RwFJg== =wI1k -----END PGP SIGNATURE----- --Sig_/Rz3XXUgWmzHZFeQlcXMhsIO-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 05:23:38 2020 Received: (at 43015) by debbugs.gnu.org; 24 Aug 2020 09:23:38 +0000 Received: from localhost ([127.0.0.1]:56042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA8hW-0005FY-Em for submit@debbugs.gnu.org; Mon, 24 Aug 2020 05:23:38 -0400 Received: from flashner.co.il ([178.62.234.194]:35844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA8hU-0005FJ-EH for 43015@debbugs.gnu.org; Mon, 24 Aug 2020 05:23:37 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id 9D4F340045; Mon, 24 Aug 2020 09:23:29 +0000 (UTC) Date: Mon, 24 Aug 2020 12:22:56 +0300 From: Efraim Flashner To: Danny Milosavljevic Subject: Re: bug#43015: git-fetched packages' working copy is not writable Message-ID: <20200824092256.GH1392@E5400> References: <20200824111359.4008ce30@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="poJSiGMzRSvrLGLs" Content-Disposition: inline In-Reply-To: <20200824111359.4008ce30@scratchpost.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43015 Cc: 43015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --poJSiGMzRSvrLGLs Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote: > Hi, >=20 > the working copy of a package build when the package was git-fetched is n= ot > writable. >=20 > On the other hand, if it's url-fetched, it's perfectly writable. >=20 > Shall we fix this on core-updates ? (ins)efraim@E5400 ~/workspace/guix$ git grep make-files-writable | grep unp= ack | grep gnu/packages gnu/packages/bioinformatics.scm: (add-after 'unpack 'make-files-wri= table gnu/packages/code.scm: (add-after 'unpack 'make-files-wr= itable gnu/packages/djvu.scm: (add-after 'unpack 'make-files-writable gnu/packages/java.scm: (add-after 'unpack 'make-files-writable gnu/packages/java.scm: (add-after 'unpack 'make-files-writable gnu/packages/java.scm: (add-after 'unpack 'make-files-writable gnu/packages/java.scm: (add-after 'unpack 'make-files-writable gnu/packages/machine-learning.scm: (add-after 'unpack 'make-files-w= ritable gnu/packages/ocaml.scm: (add-after 'unpack 'make-files-writable gnu/packages/ruby.scm: (add-after 'unpack 'make-files-wr= itable My only concern would be if there were files which weren't supposed to be writable. We're building the package, not making changes to be submitted upstream or anything, so I don't see that as being a reason to hold back. I'm in favor --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --poJSiGMzRSvrLGLs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9Dhu0ACgkQQarn3Mo9 g1HidRAAtzv1ZzynJi32LBGiOTmfl91eHtzgi9XluUK8CLYljE0ajtCENgqlCGx4 wX1xhfSIgJZuJRJ01oDODaL6AcU7jiHj03uMwasPyNRKMIbJeqJKsAzSHOVjXm5F /OvYqKj9PChx1cgOpxuduodeFSlf+sfWNaoMwJ6iA/EeV6ZrNq+na/kuojfP2Wz6 E6kIVRqy7Lphhlaj1D9Z33oeaxNQBn4d41kQc0Bn796/MDcIkDifl7gUvqnkGTX/ gDdUTV8qWdVQwexQg+xL2cjftrxm40oNhnwuNZP+FuzwTiNWLK7Z0TzuHPBBC1bJ v9xQ1tqDPwaLSQKFxgJG6XsCzg+FiXp6xddFmeAaBcE7vcvTWywOMBe9UvISAw3j ByL1nUze3+W+tE/5sSxBREmEXiVyX9ZUJ87rsG7+aToPVSoFujCLHQtgfmhV97HN Y+TbhoNet+inqXv7WBcZ+OqvhFmxpd0is/5Tt68oXlEyhnYUG9tGnHuChHCQTN4N WXXFd+S/jt+/cAmpRn/Zzff3I53m4t0NmfozOHmMbKMMpFnO7lEvi/dmXrX9ye0m k2WYtLLjaQWtf3ehpR57EipNEbf/3iY4KGjvGRI0+mM8hCqCQJGA+wrdRzfnvD1c uE7fvFBcJ2rT2NpnfkqK1pmQNCQ9GlHu5J/15rT63J0Ob6uUhnE= =K8+9 -----END PGP SIGNATURE----- --poJSiGMzRSvrLGLs-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 07:41:22 2021 Received: (at 43015-done) by debbugs.gnu.org; 4 Feb 2021 12:41:22 +0000 Received: from localhost ([127.0.0.1]:40152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7dwn-0004cA-P5 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 07:41:21 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:35290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7dwk-0004bv-Hc for 43015-done@debbugs.gnu.org; Thu, 04 Feb 2021 07:41:19 -0500 Received: by mail-qk1-f178.google.com with SMTP id a19so3116470qka.2 for <43015-done@debbugs.gnu.org>; Thu, 04 Feb 2021 04:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hhS2aQ0NSi9dKsKbLrQ+KLMU3iF+AAJp5tDHqPIaebs=; b=kLBHIoe0MIxpHBxeZcJL5cg7E+g/nN9V6rmJZPgy33oFE33uj8l7fii7M8ySuVfuGB V2w9GqMjYSWF/8tixMXMAaWaeyKK8bzR3d95BZJyKJ/rHNle1pSOGYimALqCWtnLBUQL 7SmVDkI9NHLT1vY+Tf2ti5yR2UmEy3B72haLotpOajOD3MkiVbNp0Kq67tP/dzDU4H3h KZeuimFEruUNK1xgnaTof5e1Ho1Aax7K+fvdICoLWgM48bqJOs3JgN99q2iOO7DHGR1j VhBv9pxxsj26/IY0eT2AykX7EgRkxFFpX9WNv9DH7ZF9Fk1SWNh73K6o9vfgGLNQJtLL 0fzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hhS2aQ0NSi9dKsKbLrQ+KLMU3iF+AAJp5tDHqPIaebs=; b=LQ+IbwDeEhoGaToxPlpELocmDj7Y2EhV7NV15MHCIKM1I1NzAXV/LnG2IC9mxoBxNa yRRC8qZMEt8PMxgwcC7i4reXd0qlfMSZj+46xF7d885eSz1SooOIuK7xgA/Z0Xm08gEF QlB9SV76LTiBGhLBL9Km79IMzRK9pu2oNMam2lur0P5h660utMz9tAaVOmM4UlJZN3mG c+N3zgDMF9YmTJ5XaU/Hn06zq6k8yWJq6UJCFOBi5UXGOn7lWAzcrwbxrXLd+5yfmchk qGwVGYCIsGt6ZiG2rXrZoKg0W1W8bJjXMwWLNP8rmbNlSRbHnc7vQlMHmc9NR1/xGRoz 6ilQ== X-Gm-Message-State: AOAM530Mb84v43T82OLZOlxumtwY97hWptXbI9umb1syp8L1I5AqQKBS mGs6wRi/PHlYIPyt/GEmKqsYd0F47d0= X-Google-Smtp-Source: ABdhPJw71tmGIHaXuZcxcysAs67IZjNLX76Py6h00uf9yrWmRwKJVmfPgdhYH6trjA6Di7OBYbQxxw== X-Received: by 2002:a05:620a:49:: with SMTP id t9mr7661250qkt.231.1612442472811; Thu, 04 Feb 2021 04:41:12 -0800 (PST) Received: from hurd (dsl-205-151-56-157.b2b2c.ca. [205.151.56.157]) by smtp.gmail.com with ESMTPSA id c14sm5194893qkl.18.2021.02.04.04.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 04:41:11 -0800 (PST) From: Maxim Cournoyer To: Efraim Flashner Subject: Re: bug#43015: git-fetched packages' working copy is not writable References: <20200824111359.4008ce30@scratchpost.org> <20200824092256.GH1392@E5400> Date: Thu, 04 Feb 2021 07:41:10 -0500 In-Reply-To: <20200824092256.GH1392@E5400> (Efraim Flashner's message of "Mon, 24 Aug 2020 12:22:56 +0300") Message-ID: <87k0rongyh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43015-done Cc: 43015-done@debbugs.gnu.org, Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Efraim Flashner writes: > On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote: >> Hi, >> >> the working copy of a package build when the package was git-fetched is not >> writable. >> >> On the other hand, if it's url-fetched, it's perfectly writable. >> >> Shall we fix this on core-updates ? > > (ins)efraim@E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages > gnu/packages/bioinformatics.scm: (add-after 'unpack 'make-files-writable > gnu/packages/code.scm: (add-after 'unpack 'make-files-writable > gnu/packages/djvu.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/machine-learning.scm: (add-after 'unpack 'make-files-writable > gnu/packages/ocaml.scm: (add-after 'unpack 'make-files-writable > gnu/packages/ruby.scm: (add-after 'unpack 'make-files-writable > > My only concern would be if there were files which weren't supposed to > be writable. We're building the package, not making changes to be > submitted upstream or anything, so I don't see that as being a reason to > hold back. > > I'm in favor I've included the fix as part as the unpack phase, and pushed to core-updates as commit 6129ebddbd. Thanks for the report! Closing. Maxim From unknown Fri Sep 12 22:55:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Mar 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator