From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 23 17:46:56 2020 Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 21:46:56 +0000 Received: from localhost ([127.0.0.1]:55277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xpI-0002Iz-8W for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:46:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:58672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xpG-0002Ir-F9 for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:46:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xpF-0000Iv-TI for bug-guix@gnu.org; Sun, 23 Aug 2020 17:46:54 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:47962) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9xpD-0001m9-UP for bug-guix@gnu.org; Sun, 23 Aug 2020 17:46:53 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 300FC1AA3F for ; Sun, 23 Aug 2020 14:46:46 -0700 (PDT) From: Vagrant Cascadian To: bug-guix@gnu.org Subject: make dist fails: "store file names embedded in the distribution" Date: Sun, 23 Aug 2020 14:46:17 -0700 Message-ID: <87wo1p3uja.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/23 17:46:46 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain When I tried to run make dist, it fails: guix-1.0.1.21330-a8c8f-dirty/gnu/packages/commencement.scm: // /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e9a/lib/libc.a: error: 'sigprocmask' defined t error: store file names embedded in the distribution The attached patch triggers pretty extensive rebuilds, but should fix the problem. live well, vagrant --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-commencement-bash-mesboot0-Remove-store-file-nam.patch Content-Transfer-Encoding: quoted-printable From=206e77f342c0deca73fa608365bbceb14aaf675b21 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Sun, 23 Aug 2020 14:10:57 -0700 Subject: [PATCH] gnu: commencement: bash-mesboot0: Remove store file name. This is a follow-up to commit d9484fba91bc360ad18fe82cb9f4963ccb32c580, and fixes "make dist". * gnu/packages/commencement (bash-mesboot0): Remove reference to store item. =2D-- gnu/packages/commencement.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index aa30e3fa18..617a12016f 100644 =2D-- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -792,7 +792,7 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" // tcc: error: undefined symbol 'enable_hostname_completion' #define enable_hostname_completion(on_or_off) 0 =20 =2D// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e9= a/lib/libc.a: error: 'sigprocmask' defined twice +// /gnu/store/=E2=80=A6-tcc-boot0-0.9.26-6.c004e9a/lib/libc.a: error: 'sig= procmask' defined twice #define HAVE_POSIX_SIGNALS 1 #define endpwent(x) 0 ") =2D-=20 2.20.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX0LjqQAKCRDcUY/If5cW qmLbAP9dRtk8TgMx7+21PyIW4Lwzsd0X9tTTeZu2e5+nHjdH2wEAxWB4lrA6itSH 5pffL+VXTYrWHc5SU3P4eTOAPN6DywU= =yGd5 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 02:18:42 2020 Received: (at 43005) by debbugs.gnu.org; 24 Aug 2020 06:18:42 +0000 Received: from localhost ([127.0.0.1]:55837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA5oJ-0006kY-Lm for submit@debbugs.gnu.org; Mon, 24 Aug 2020 02:18:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA5oI-0006kI-7W for 43005@debbugs.gnu.org; Mon, 24 Aug 2020 02:18:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39066) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kA5oC-0005sB-PK; Mon, 24 Aug 2020 02:18:20 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=36918 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kA5oC-0004UZ-94; Mon, 24 Aug 2020 02:18:20 -0400 From: Jan Nieuwenhuizen To: Vagrant Cascadian Subject: Re: bug#43005: make dist fails: "store file names embedded in the distribution" Organization: AvatarAcademy.nl References: <87wo1p3uja.fsf@yucca> X-Url: http://AvatarAcademy.nl Date: Mon, 24 Aug 2020 08:18:17 +0200 In-Reply-To: <87wo1p3uja.fsf@yucca> (Vagrant Cascadian's message of "Sun, 23 Aug 2020 14:46:17 -0700") Message-ID: <871rjwsh1y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43005 Cc: 43005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Vagrant Cascadian writes: Hello! > When I tried to run make dist, it fails: > > guix-1.0.1.21330-a8c8f-dirty/gnu/packages/commencement.scm: > // /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e= 9a/lib/libc.a: error: 'sigprocmask' defined t > error: store file names embedded in the distribution > > The attached patch triggers pretty extensive rebuilds, but should fix > the problem. Oops; your patch is fine (see nit-pick) for core-updates; but as you noticed, on master we need to add an indirection to avoid rebuilds. What about something like --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index aa30e3fa18..48f9a47c6b 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -788,14 +788,16 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" (substitute* "config.h" (("#define GETCWD_BROKEN 1") "#undef GETCWD_BROKEN")) (let ((config.h (open-file "config.h" "a"))) - (display (string-append " + ;; TODO: remove ,(string-append hack in next rebuild cycle + ;; together with store file name + (display (string-append ,(string-append " // tcc: error: undefined symbol 'enable_hostname_completion' #define enable_hostname_completion(on_or_off) 0 =20 -// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e9a/= lib/libc.a: error: 'sigprocmask' defined twice +// /gnu/store/" "cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e= 9a/lib/libc.a: error: 'sigprocmask' defined twice #define HAVE_POSIX_SIGNALS 1 #define endpwent(x) 0 -") +")) config.h) (close config.h)) #t)) --8<---------------cut here---------------end--------------->8--- Thanks for catching this! Greetings, Janneke > From 6e77f342c0deca73fa608365bbceb14aaf675b21 Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Sun, 23 Aug 2020 14:10:57 -0700 > Subject: [PATCH] gnu: commencement: bash-mesboot0: Remove store file name. [..] > diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm > index aa30e3fa18..617a12016f 100644 > --- a/gnu/packages/commencement.scm > +++ b/gnu/packages/commencement.scm > @@ -792,7 +792,7 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" > // tcc: error: undefined symbol 'enable_hostname_completion' > #define enable_hostname_completion(on_or_off) 0 >=20=20 > -// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e9= a/lib/libc.a: error: 'sigprocmask' defined twice > +// /gnu/store/=E2=80=A6-tcc-boot0-0.9.26-6.c004e9a/lib/libc.a: error: 's= igprocmask' defined twice > #define HAVE_POSIX_SIGNALS 1 > #define endpwent(x) 0 > ") ^ This is the closing parenthesis of a string-append that has only this one big string; what about removing that string-append altogether? --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 16 06:21:29 2020 Received: (at 43005) by debbugs.gnu.org; 16 Sep 2020 10:21:29 +0000 Received: from localhost ([127.0.0.1]:33303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIUZ6-0008Ln-Up for submit@debbugs.gnu.org; Wed, 16 Sep 2020 06:21:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIUZ5-0008Lb-EY for 43005@debbugs.gnu.org; Wed, 16 Sep 2020 06:21:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37118) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIUZ0-0004hx-6b; Wed, 16 Sep 2020 06:21:22 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39272 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIUYz-0007dO-Df; Wed, 16 Sep 2020 06:21:21 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jan Nieuwenhuizen Subject: Re: bug#43005: make dist fails: "store file names embedded in the distribution" References: <87wo1p3uja.fsf@yucca> <871rjwsh1y.fsf@gnu.org> Date: Wed, 16 Sep 2020 12:21:09 +0200 In-Reply-To: <871rjwsh1y.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Mon, 24 Aug 2020 08:18:17 +0200") Message-ID: <87o8m6nht6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43005 Cc: Vagrant Cascadian , 43005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Jan Nieuwenhuizen skribis: >> When I tried to run make dist, it fails: >> >> guix-1.0.1.21330-a8c8f-dirty/gnu/packages/commencement.scm: >> // /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004= e9a/lib/libc.a: error: 'sigprocmask' defined t >> error: store file names embedded in the distribution >> >> The attached patch triggers pretty extensive rebuilds, but should fix >> the problem. > > Oops; your patch is fine (see nit-pick) for core-updates; but as you > noticed, on master we need to add an indirection to avoid rebuilds. > What about something like > > diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm > index aa30e3fa18..48f9a47c6b 100644 > --- a/gnu/packages/commencement.scm > +++ b/gnu/packages/commencement.scm > @@ -788,14 +788,16 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" > (substitute* "config.h" > (("#define GETCWD_BROKEN 1") "#undef GETCWD_BROKEN")) > (let ((config.h (open-file "config.h" "a"))) > - (display (string-append " > + ;; TODO: remove ,(string-append hack in next rebuild cycle > + ;; together with store file name > + (display (string-append ,(string-append " > // tcc: error: undefined symbol 'enable_hostname_completion' > #define enable_hostname_completion(on_or_off) 0 >=20=20 > -// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e9= a/lib/libc.a: error: 'sigprocmask' defined twice > +// /gnu/store/" "cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c00= 4e9a/lib/libc.a: error: 'sigprocmask' defined twice > #define HAVE_POSIX_SIGNALS 1 > #define endpwent(x) 0 > -") > +")) Well done! Could you push to =E2=80=98master=E2=80=99 (with a =E2=80=9CFix= es=E2=80=9D line in the commit log)? >> From 6e77f342c0deca73fa608365bbceb14aaf675b21 Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian >> Date: Sun, 23 Aug 2020 14:10:57 -0700 >> Subject: [PATCH] gnu: commencement: bash-mesboot0: Remove store file nam= e. > > [..] > >> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.s= cm >> index aa30e3fa18..617a12016f 100644 >> --- a/gnu/packages/commencement.scm >> +++ b/gnu/packages/commencement.scm >> @@ -792,7 +792,7 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" >> // tcc: error: undefined symbol 'enable_hostname_completion' >> #define enable_hostname_completion(on_or_off) 0 >>=20=20 >> -// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e= 9a/lib/libc.a: error: 'sigprocmask' defined twice >> +// /gnu/store/=E2=80=A6-tcc-boot0-0.9.26-6.c004e9a/lib/libc.a: error: '= sigprocmask' defined twice >> #define HAVE_POSIX_SIGNALS 1 >> #define endpwent(x) 0 >> ") > ^ > > This is the closing parenthesis of a string-append that has only this > one big string; what about removing that string-append altogether? Agreed. Vagrant, could you push it to core-updates with this change? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 16 06:48:19 2020 Received: (at 43005) by debbugs.gnu.org; 16 Sep 2020 10:48:19 +0000 Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIUz5-0000g4-Ak for submit@debbugs.gnu.org; Wed, 16 Sep 2020 06:48:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIUz3-0000fs-Kw for 43005@debbugs.gnu.org; Wed, 16 Sep 2020 06:48:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37427) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIUyx-0008Ij-1X; Wed, 16 Sep 2020 06:48:11 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=54422 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIUyw-0004Kq-CP; Wed, 16 Sep 2020 06:48:10 -0400 From: Jan Nieuwenhuizen To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#43005: make dist fails: "store file names embedded in the distribution" Organization: AvatarAcademy.nl References: <87wo1p3uja.fsf@yucca> <871rjwsh1y.fsf@gnu.org> <87o8m6nht6.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Wed, 16 Sep 2020 12:47:36 +0200 In-Reply-To: <87o8m6nht6.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 16 Sep 2020 12:21:09 +0200") Message-ID: <87h7ryhubb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43005 Cc: Vagrant Cascadian , 43005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s writes: Hello, > Jan Nieuwenhuizen skribis: > >> Oops; your patch is fine (see nit-pick) for core-updates; but as you >> noticed, on master we need to add an indirection to avoid rebuilds. >> What about something like >> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.s= cm >> index aa30e3fa18..48f9a47c6b 100644 >> --- a/gnu/packages/commencement.scm >> +++ b/gnu/packages/commencement.scm [..] > Well done! Could you push to =E2=80=98master=E2=80=99 (with a =E2=80=9CF= ixes=E2=80=9D line in the > commit log)? Pushed to master as b85863f7ce99d05205e57358b36ff50656cca08b. Meanwile we have a duplicate bug: (it finally rang a bell on IRC...). Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 16 07:13:52 2020 Received: (at 43005) by debbugs.gnu.org; 16 Sep 2020 11:13:52 +0000 Received: from localhost ([127.0.0.1]:33382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIVNo-0001JN-06 for submit@debbugs.gnu.org; Wed, 16 Sep 2020 07:13:52 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]:45523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIVNl-0001JA-SM for 43005@debbugs.gnu.org; Wed, 16 Sep 2020 07:13:50 -0400 Received: by mail-qv1-f51.google.com with SMTP id cv8so3262823qvb.12 for <43005@debbugs.gnu.org>; Wed, 16 Sep 2020 04:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bzB1e7U4kg+UZFZ2zdr05E4i2YFyeDFdtm9MlNR0cuU=; b=eFspJhWGMc4/wvG0N82FgDsxrHxsOt55BnN44v34EGlPn+IpMYbE+EQx78Qu5++nxr iSM594mGxmlwD8P0YTeG0PmD1sDLT+5XGtJVhl96yggwtI78iaIqK7kflmaBg2hZbrhA 7Ltc1IqLuHXVhUQRrDvtL1deRD3CpzrGWJyg7ijGedxsxL+wnEjZLUjnsddUCGcVOxzZ iGEMgh5LVHXlywdJppN6TRf+XT/p8LOMThxwm8g/S3ebCrY8DGyLxYErVNH5558FJWHW ULG9GtBkaBIsqucu1pO4zae43jhHwsIo9UCgK///ow5DPV7fwDSQLu5zqNY+4IXb4RNy WjDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bzB1e7U4kg+UZFZ2zdr05E4i2YFyeDFdtm9MlNR0cuU=; b=fIqcLd3pZwvpEfXmFeba7u6ihb8Av5UIwPLNlR1A9qzVQ7vo59c9NjBCg+LL/4GdcT kKKXRkh2A9HPYHdEGdC8S4BkznCb391daL7XCvwnNbkBAabgcF1bYbBO7jYQZX1NC2gL 3q0erRjxFfQf4dR3LuBKQc04mdo9A7Wz9l/Rl7DdqF024adcOXDhvSrTTw30OGoHcpqr VR2eEA89P73nApJ4ZH7iA0XhnPQN/qeiWVfwUIuw5dBoDGBQuEusDegZUyw5Rf3lb5IR ijqvMJnzMDhhU13yaSJxL/Zt0q0EUAEbUrjxol6bXiKg0mvpQqgAt8MocUtXXBqODtC5 /OrQ== X-Gm-Message-State: AOAM530FGUe4PlBmriZk8KCsw/jSAh2jfIKBggAwCmgnmESNHCKXDuYu u/hQIR/yLbLpTclFvFN8sNF7EugEWLcb+RWab8o= X-Google-Smtp-Source: ABdhPJyaFNlWfUnGq1lHVIWGoEdNQNeiw5cv++Z5Tlu2J9Qe9dDFFRCnchToMuXsKIZzImGGcvrr4g5sP2XTlSnQtf8= X-Received: by 2002:ad4:58e7:: with SMTP id di7mr6196682qvb.36.1600254824326; Wed, 16 Sep 2020 04:13:44 -0700 (PDT) MIME-Version: 1.0 References: <87wo1p3uja.fsf@yucca> <871rjwsh1y.fsf@gnu.org> <87o8m6nht6.fsf@gnu.org> <87h7ryhubb.fsf@gnu.org> In-Reply-To: <87h7ryhubb.fsf@gnu.org> From: zimoun Date: Wed, 16 Sep 2020 13:13:33 +0200 Message-ID: Subject: Re: bug#43005: make dist fails: "store file names embedded in the distribution" To: Jan Nieuwenhuizen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43005 Cc: Vagrant Cascadian , =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 43005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 16 Sep 2020 at 12:49, Jan Nieuwenhuizen wrote: > Meanwile we have a duplicate bug: > (it finally rang a bell on IRC...). I have closed the duplicate referencing this one. Sorry for missing this one. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 16 14:05:09 2020 Received: (at 43005) by debbugs.gnu.org; 16 Sep 2020 18:05:09 +0000 Received: from localhost ([127.0.0.1]:35828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIbnp-0005ek-Fs for submit@debbugs.gnu.org; Wed, 16 Sep 2020 14:05:09 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:54588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIbno-0005eS-1r for 43005@debbugs.gnu.org; Wed, 16 Sep 2020 14:05:08 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 2EC891AD7A; Wed, 16 Sep 2020 11:05:02 -0700 (PDT) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Jan Nieuwenhuizen Subject: Re: bug#43005: make dist fails: "store file names embedded in the distribution" In-Reply-To: <87o8m6nht6.fsf@gnu.org> References: <87wo1p3uja.fsf@yucca> <871rjwsh1y.fsf@gnu.org> <87o8m6nht6.fsf@gnu.org> Date: Wed, 16 Sep 2020 11:04:59 -0700 Message-ID: <87wo0ty4vo.fsf@ponder> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43005 Cc: 43005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-09-16, Ludovic Court=C3=A8s wrote: > Hello! > > Jan Nieuwenhuizen skribis: > >>> When I tried to run make dist, it fails: >>> >>> guix-1.0.1.21330-a8c8f-dirty/gnu/packages/commencement.scm: >>> // /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c00= 4e9a/lib/libc.a: error: 'sigprocmask' defined t >>> error: store file names embedded in the distribution >>> >>> The attached patch triggers pretty extensive rebuilds, but should fix >>> the problem. >> >> Oops; your patch is fine (see nit-pick) for core-updates; but as you >> noticed, on master we need to add an indirection to avoid rebuilds. >> What about something like >> >> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.s= cm >> index aa30e3fa18..48f9a47c6b 100644 >> --- a/gnu/packages/commencement.scm >> +++ b/gnu/packages/commencement.scm >> @@ -788,14 +788,16 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" >> (substitute* "config.h" >> (("#define GETCWD_BROKEN 1") "#undef GETCWD_BROKEN")) >> (let ((config.h (open-file "config.h" "a"))) >> - (display (string-append " >> + ;; TODO: remove ,(string-append hack in next rebuild cyc= le >> + ;; together with store file name >> + (display (string-append ,(string-append " >> // tcc: error: undefined symbol 'enable_hostname_completion' >> #define enable_hostname_completion(on_or_off) 0 >>=20=20 >> -// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004e= 9a/lib/libc.a: error: 'sigprocmask' defined twice >> +// /gnu/store/" "cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c0= 04e9a/lib/libc.a: error: 'sigprocmask' defined twice >> #define HAVE_POSIX_SIGNALS 1 >> #define endpwent(x) 0 >> -") >> +")) > > Well done! Could you push to =E2=80=98master=E2=80=99 (with a =E2=80=9CF= ixes=E2=80=9D line in the > commit log)? > >>> From 6e77f342c0deca73fa608365bbceb14aaf675b21 Mon Sep 17 00:00:00 2001 >>> From: Vagrant Cascadian >>> Date: Sun, 23 Aug 2020 14:10:57 -0700 >>> Subject: [PATCH] gnu: commencement: bash-mesboot0: Remove store file na= me. >> >> [..] >> >>> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.= scm >>> index aa30e3fa18..617a12016f 100644 >>> --- a/gnu/packages/commencement.scm >>> +++ b/gnu/packages/commencement.scm >>> @@ -792,7 +792,7 @@ $MES -e '(mescc)' module/mescc.scm -- \"$@\" >>> // tcc: error: undefined symbol 'enable_hostname_completion' >>> #define enable_hostname_completion(on_or_off) 0 >>>=20=20 >>> -// /gnu/store/cq0cmv35s9dhilx14zaghlc08gpc0hwr-tcc-boot0-0.9.26-6.c004= e9a/lib/libc.a: error: 'sigprocmask' defined twice >>> +// /gnu/store/=E2=80=A6-tcc-boot0-0.9.26-6.c004e9a/lib/libc.a: error: = 'sigprocmask' defined twice >>> #define HAVE_POSIX_SIGNALS 1 >>> #define endpwent(x) 0 >>> ") >> ^ >> >> This is the closing parenthesis of a string-append that has only this >> one big string; what about removing that string-append altogether? > > Agreed. > > Vagrant, could you push it to core-updates with this change? Not in a good position to push anything for a few days; if someone else could that would be great! live well, vagrant From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 16 17:44:56 2020 Received: (at 43005-done) by debbugs.gnu.org; 16 Sep 2020 21:44:56 +0000 Received: from localhost ([127.0.0.1]:36710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIfEV-0004kl-PT for submit@debbugs.gnu.org; Wed, 16 Sep 2020 17:44:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIfET-0004kW-2u for 43005-done@debbugs.gnu.org; Wed, 16 Sep 2020 17:44:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49921) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIfEL-0002mY-El; Wed, 16 Sep 2020 17:44:45 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=32982 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIfEL-0004CH-0T; Wed, 16 Sep 2020 17:44:45 -0400 From: Jan Nieuwenhuizen To: Vagrant Cascadian Subject: Re: bug#43005: make dist fails: "store file names embedded in the distribution" Organization: AvatarAcademy.nl References: <87wo1p3uja.fsf@yucca> <871rjwsh1y.fsf@gnu.org> <87o8m6nht6.fsf@gnu.org> <87wo0ty4vo.fsf@ponder> X-Url: http://AvatarAcademy.nl Date: Wed, 16 Sep 2020 23:44:11 +0200 In-Reply-To: <87wo0ty4vo.fsf@ponder> (Vagrant Cascadian's message of "Wed, 16 Sep 2020 11:04:59 -0700") Message-ID: <87a6xp75xw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43005-done Cc: 43005-done@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Vagrant Cascadian writes: Hi! > On 2020-09-16, Ludovic Court=C3=A8s wrote: >> Hello! >> >> Jan Nieuwenhuizen skribis: >>> This is the closing parenthesis of a string-append that has only this >>> one big string; what about removing that string-append altogether? >> >> Agreed. >> >> Vagrant, could you push it to core-updates with this change? > > Not in a good position to push anything for a few days; if someone else > could that would be great! Sure. Pushed with minor change (removing encompassing string-append) to core-updates as 7467f9857dc530861735ebffe2c9376c8dfb80b7 Thanks! Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From unknown Thu Sep 11 11:26:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Oct 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator