Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources

From: Stephen Berman <[email-masked]>
Date: Sat, 31 Oct 2020 22:30:48 +0100

On Sat, 31 Oct 2020 03:39:12 +0200 Dmitry Gutov <[email-masked]> wrote:

> On 30.10.2020 23:26, Stephen Berman wrote:
>> That's what I did in my patch in<[email-masked]>
>> (https://debbugs.gnu.org/cgi/bugreport.cgi?msg=11;att=1;bug=43004) and
>> initially concluded that with that patch "I now get no unexpected
>> failures when running the tests in batch mode, though when run
>> interactively xref-elisp-test-find-defs-defgeneric-implicit-generic
>> still fails."
>
> But looking at that patch, you moved some of the 'file-truename' calls, at
> least, down inside the test definitions, to produce the "expected" values.
>
> What happens if you just remove that 'file-truename' call without adding it
> somewhere else?

With just that change, a batch run started in the test subdirectory of
the emacs sources symlinked from my home directory gives:

5 unexpected results:
   FAILED  xref-elisp-test-find-defs-constructor
   FAILED  xref-elisp-test-find-defs-defalias-defun-el
   FAILED  xref-elisp-test-find-defs-defgeneric-el
   FAILED  xref-elisp-test-find-defs-defun-el-defvar-c
   FAILED  xref-elisp-test-find-defs-face-el

A batch run started in the non-symlinked test subdirectory gives:

5 unexpected results:
   FAILED  xref-elisp-test-find-defs-defgeneric-el
   FAILED  xref-elisp-test-find-defs-defun-defvar-el
   FAILED  xref-elisp-test-find-defs-defun-el
   FAILED  xref-elisp-test-find-defs-defvar-el
   FAILED  xref-elisp-test-find-defs-feature-el

Full output of the batch runs is attached.

Steve Berman