GNU bug report logs - #43003
28.0.50; comint-password-prompt-regexp too restrictive

Previous Next

Package: emacs;

Reported by: Stephen Berman <stephen.berman <at> gmx.net>

Date: Sun, 23 Aug 2020 21:27:01 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #51 received at 43003 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43003 <at> debbugs.gnu.org, Stephen Berman <stephen.berman <at> gmx.net>
Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
Date: Tue, 01 Sep 2020 17:40:19 +0200

>>>>> On Tue, 01 Sep 2020 17:06:50 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> said:

    Lars> Robert Pluim <rpluim <at> gmail.com> writes:
    >> >> -	  (string-match comint-password-prompt-regexp string))
    >> >> +	  (string-match comint-password-prompt-regexp
    >> >> +                        (replace-regexp-in-string "\r" "" string)))
    >> 
    Lars> Yes, that makes sense to me.
    >> 
    >> Done in 2e3ec40293

    Lars> One thought -- just as a precaution, would it make sense to do this
    Lars> replacement only if the \r is at the start of a line, and it's not
    Lars> followed by a \n?  I'm just slightly worried that there may be
    Lars> repercussions on systems that use \r\n as end-of-line markers...  it
    Lars> probably makes no difference here, but...

Iʼm finding it hard to come up with a case where stripping the \r
fails (famous last words).

Robert
This bug report was last modified 4 years and 347 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.