GNU bug report logs - #43003
28.0.50; comint-password-prompt-regexp too restrictive

Previous Next

Full log

Message #48 received at 43003-done <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 43003-done <at> debbugs.gnu.org, Stephen Berman <stephen.berman <at> gmx.net>
Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
Date: Tue, 01 Sep 2020 17:06:50 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

>     >> -	  (string-match comint-password-prompt-regexp string))
>     >> +	  (string-match comint-password-prompt-regexp
>     >> +                        (replace-regexp-in-string "\r" "" string)))
>
>     Lars> Yes, that makes sense to me.
>
> Done in 2e3ec40293

One thought -- just as a precaution, would it make sense to do this
replacement only if the \r is at the start of a line, and it's not
followed by a \n?  I'm just slightly worried that there may be
repercussions on systems that use \r\n as end-of-line markers...  it
probably makes no difference here, but...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.