GNU bug report logs - #43003
28.0.50; comint-password-prompt-regexp too restrictive

Previous Next

Package: emacs;

Reported by: Stephen Berman <stephen.berman <at> gmx.net>

Date: Sun, 23 Aug 2020 21:27:01 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 43003 <at> debbugs.gnu.org
Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
Date: Thu, 27 Aug 2020 15:02:44 +0200
Stephen Berman <stephen.berman <at> gmx.net> writes:

> The minimal change to fix my use case is to add the carriage return
> character as an alternative to comint-password-prompt-regexp, as in the
> attached patch.  If even that is too risky, I'll just stick with a local
> fix.
>
> Steve
>
> diff --git a/lisp/comint.el b/lisp/comint.el
> index 092902d865..b6098f449d 100644
> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -365,7 +365,7 @@ comint-process-echoes
>  ;; See ert test `comint-test-password-regexp'.
>  (defcustom comint-password-prompt-regexp
>    (concat
> -   "\\(^ *\\|"
> +   "\\(^ *\\|"
>     (regexp-opt
>      '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the"
>        "Enter Auth" "enter auth" "Old" "old" "New" "new" "'s" "login"

I don't quite understand how this patch helps -- doesn't this just
require a ^M character before Enter/Old/etc?  Did you mean 

> +   "\\(^ *\\|\\|"

?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 347 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.