From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 23 17:26:33 2020 Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 21:26:33 +0000 Received: from localhost ([127.0.0.1]:55237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xVY-0001nN-TM for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:26:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:51372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9xVX-0001nF-KH for submit@debbugs.gnu.org; Sun, 23 Aug 2020 17:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xVX-0004f9-EL for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:26:31 -0400 Received: from mout.gmx.net ([212.227.17.21]:40153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9xVV-00081x-N4 for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 17:26:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598217987; bh=ZarThuz2JUPUOsraafRjXFULaldeF45JXp8FHri5HOw=; h=X-UI-Sender-Class:From:To:Subject:Date; b=FiE8GgHQ8EvcHlkjr7viDEoLaoAjT8C7sOMqwfHOsu4lyVFM03igl0HVLNMw8vIUG taLcdxEcbbYJ1T+EIqxPN17nvfHa10DPMT5LhU3IC/mX/ZYvpzs/3g4nWm3raCI32E /PApQlX8e9qn9KYELtnmQ/Bw1pe+uUF9okLFqToI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([92.73.78.116]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHEJ-1kpJbk2G9z-00gnMh for ; Sun, 23 Aug 2020 23:26:27 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 28.0.50; comint-password-prompt-regexp too restrictive Date: Sun, 23 Aug 2020 23:26:26 +0200 Message-ID: <87pn7hawal.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:yORn1/Q47Ixc7H9JLzDzhO/cMWL1lLNuPVIS10MhCoFMy3okJpk uKnOxO9V1x85XY3StQ+gRaDPr5rVTav8r1Q0/RAYwBgeRwi0JDJuSKuO6plx2IugehtcFQB vGpDTLHvv5Iaelvdw8//kNtEE1hUbDg9DKD50ZnZjEohBq6OVWXXm/fHRvGnVZBjIrcVDzC 6mrbVISnb7yA2JpKZsacA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dBYB7sUcjbw=:uS/HQXiQr6uJTL2ZnWMX9L M8bm1dMDAvDandcd2OC6+vo4m3sT20W6UzsfNiDk4x4fYQgmue5LjeuZLlyt9/ENNSIyDjEDH woVkCNNXSVj/Zg0aLP6y0mpItNysX+0oSNm74KUI0SF2HueRwKPOBvIUiXnjOzDBMiWJ2M1id KxpFJmdor4H1BYwbfpKD34Vfq1A60e0aawG1TzQlo9hLUamNpaTjM0lQgoak/DVT4MJ2gbwqC gvAvwjSFbj2dSmMkQJ+l/hQKekQkZDrRBiZeeqRMNqap6ek5VX1vlQKDl/wdHQSa9BY9bmRQ6 4FpYr7RWlmiy2SfxeLrEpVOQ64NPSFTea0XKZ5S2bXcYpy1hmPWeje9w1i7VoFeZeub9Djz4t awcsfJXXTYa0QX/32BTCL+vtm6s02KdoptWcIrQCg0Zv/j1QHxcZ0vgodmJf0iHUcEAJPV5c3 nyUWXV3CqmshzzuQ/vv97rq1ibIKe64NTriQpjMzDsJcrxnxaz+ShVoMWeQr17bNfMrAC3Cj5 8krGSYCrLWrsfO2ckiJYam/K+LVVHmrt3c0XJTdWDct4spsko0kDiJ5+585/3n4fUQUXII/cE m7SdFY/q27mMCpVpZyTGn0ZwuY8zWHDbzrA6T3SN7v0Ed7sUc+XUYXgAopEOCcAb05tfR8ttA 9T4JjtYe7dU0ee061l7OsijzCm/6YzRgGOVo2ZfnACFmMkR0JbRF+qqDaJSY7MkYBU/RBt4jY ULSiPKqCjbWgVuiL0kW4twDcsyIJ1k9GXx/cfhy7WWV2nvdAV8mCYP0BysOZ8Qs3TJTjZ5LgF 1btkVJOsEziPGzW7wzs5yvuGSemAaFMll7sSpM/GxGygPdQYKZ/kyXcpilI54XLGfVs545+E9 kF9d0WMobAC2t/nu5Kx0aYAjjQmuRMZN1R1PUR0HSTIa0edEK662X7aQimVVvlnrk93Bct2WE 2ZwUdwEwbjXIxcPaPY6l2CF/GWNI+z0pBlVtvlma97KjTE6kM8UN3H76lPlTkSaa1BlTsI9Zo 4WpZqg9fu5ECTUCQ8upBur8e/iDWTWOEh0sb3H9Pboydgt5tblW7EveHPyZo1FecVKmwcztTF oWU449F5a6cUHzZfjN8bxkOntslZaYQfwXBR0I1QXK8MALuiZrchzFbSJMMK5a8qEAS+KWakn FMPCnRCmnyJB+VtEnvowjcF16CgnD5FM79Yhvmfu4Knqe06dBQXJ+fGwBHSgQeYIQKvLGP/bL 6Kj4YUSQdf9a90JwH/86Hlfo1d/L9ODMCzshc7w== Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/23 17:26:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On one of my systems, when using ssh in shell-mode (M-x shell), the password prompt does not appear in the minibuffer but only in the *shell* buffer directly under the ssh invocation, and the password is not hidden when it's entered. I've determined that reason is that the password prompt string passed to comint-output-filter begins with a carriage return character (^M), and when the rest of the prompt string begins with "Password" (which it can on this system), comint-password-prompt-regexp does not match it and thus comint-watch-for-password-prompt returns nil instead of calling comint-send-invisible. So far I haven't found out where the carriage return is coming from, maybe it's from openssh (on the system where the carriage return occurs in the prompt string I have openssh-8.2p1, another system where the carriage return does not occur has openssh-7.9p1; if anyone knows the answer, or has a suggestion for how to find out, I'd appreciate hearing it). As a workaround, I can customize comint-password-prompt-regexp to match the prompt with the carriage return. But this problem could be seen as a datapoint in favor of changing the default value of comint-password-prompt-regexp. Already in bug#31075 Noam Postavsky pondered whether eshell-password-prompt-regexp should replace comint-password-prompt-regexp, noting that "the eshell regexp looks much simpler". And indeed, on the system where the carriage return occurs in the prompt string, using ssh in the Emacs shell (M-x eshell) does use the minibuffer for password input and it is hidden; and if I set comint-password-prompt-regexp to eshell-password-prompt-regexp, then I also get minibuffer hidden input in shell-mode. So this bug report is basically a plea to change the default value of comint-password-prompt-regexp to be the same as that of eshell-password-prompt-regexp. Or is there a good reason not to do this? In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3) of 2020-08-21 built on strobe-jhalfs Repository revision: 3e10174fb65f4eb601b1921271bdcf10c933b879 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux From Scratch SVN-20200401 Configured using: 'configure 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 08:27:54 2020 Received: (at 43003) by debbugs.gnu.org; 24 Aug 2020 12:27:54 +0000 Received: from localhost ([127.0.0.1]:56442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kABZq-0003nO-BJ for submit@debbugs.gnu.org; Mon, 24 Aug 2020 08:27:54 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kABZn-0003nA-W5 for 43003@debbugs.gnu.org; Mon, 24 Aug 2020 08:27:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DP0rpXyWkm3x6NbuBdqVO2p7Y2eCBXZpJsmwB8t3MiU=; b=khqFHnU/QiHWEk+Lldl0CCGdRv MqLkJc64URFfKyLsjz9tlHuOybRpeKhsyl8yCFll4qNpL4WMpA1Z8yr9jNvHard1g4tjqaM1cMff9 gz5PVoqm0znyBmkvV50hOM2OASz0RrbQzc+RZuknKLID3ik5870+cqSp3uan4+yY895s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kABZf-0005xa-5X; Mon, 24 Aug 2020 14:27:45 +0200 From: Lars Ingebrigtsen To: Stephen Berman Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> X-Now-Playing: Kronos Quartet's _Terry Riley: Sun Rings_: "One Earth, One People, One Love" Date: Mon, 24 Aug 2020 14:27:41 +0200 In-Reply-To: <87pn7hawal.fsf@gmx.net> (Stephen Berman's message of "Sun, 23 Aug 2020 23:26:26 +0200") Message-ID: <878se4dy9u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > So this bug report is basically a plea to change the default value of > comint-password-prompt-regexp to be the same as that of > eshell-password-prompt-regexp. Or is there a good reason not to do > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > So this bug report is basically a plea to change the default value of > comint-password-prompt-regexp to be the same as that of > eshell-password-prompt-regexp. Or is there a good reason not to do > this? The difference is that the former looks for something like "enter" before something like "password:", while the latter is just looking for variations of "password:"? My guess would be that the latter would have more false positives... but you'd think those would be pretty rare. I can't imagine many people having shells with prompts like "Type your user name here but definitely not your password:". So I think replacing the former with the latter might work, but comint is very old code, so perhaps it supports older shells better here... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 06:11:03 2020 Received: (at 43003) by debbugs.gnu.org; 26 Aug 2020 10:11:03 +0000 Received: from localhost ([127.0.0.1]:37451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAsOV-0005hl-ES for submit@debbugs.gnu.org; Wed, 26 Aug 2020 06:11:03 -0400 Received: from mout.gmx.net ([212.227.15.19]:52241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAsOU-0005h9-4y for 43003@debbugs.gnu.org; Wed, 26 Aug 2020 06:11:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598436656; bh=06Ye/OHgPJNLAhw0wHmShI91y4s6Vuv33o/yxHSBGQM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Pzugp0MBAofMhXRsbEH04XQwwj5zhBDpPCaX3F0jCpJVbjjhOtnPU0qDfoANVdXvJ T7N95iO9krpkFiv5sk5UYshWOGw5aE6cVPsXK2zlusOugH1tye0TzjJ8PuU/dAFE1D lmD3wdssyzFsui8uckYXzls1W3Gd9NPY3KJHPbOI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([84.61.246.117]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8ofE-1keB4Y07zK-015o7g; Wed, 26 Aug 2020 12:10:56 +0200 From: Stephen Berman To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> Date: Wed, 26 Aug 2020 12:10:55 +0200 In-Reply-To: <878se4dy9u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 24 Aug 2020 14:27:41 +0200") Message-ID: <87lfi1emz4.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:XCQPOhXHRuZyGsiQsRfhaPZ6j5n2HjrTrclVv2bwt02ip/fNi5Q dNueg/v41pQeBUAxXn/7MFcfRdHS6CegBiykNvD7hfgM5ngVWuByxSzQtzzLVIVvGrk6+cj 67OIOA/SJos6LbfdxSrMdkf0GyNgmZuzbAoal0t7D1i9V19vDvF/6ZrQc9eIL8u2KN944Q1 MasqR4qNuIe8mbR4ocPCQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jcAMOPiEFf4=:bHvg27xAYPHV0FX07Qj3K5 yaEjfx/Ib7iAk7CWGOO9OvKGMwNmi2QZxrURxTSo5j+XS0JsC1f2Czx8E2moYxc5iAPUKLS0P zm6R+gtvdL9ohpw36u9+tWNT6YTAVVAPCeAl/yWaOoBwAUU9shCqZH9raMo3RBkykd8+lZVkh 6Gw4au1+rNhQWC69cvo609W/BnikEGEV5lj5blQpf2hSva/sCn77YO6cNV7ZaiK1a9fgUXNcq P8t8xuVJ4ZGVG/1ia5kHVsqYCNv8biMf8HiPTjVt67/TDFCSBBtYP3li+h9M07BybbTobTSYJ o2kvQvZT7YKwW4edsTSvA/ule/pwq9oX3kpEwYu26+1fD7tGPRgttue1e19CfiJSC0iHPjqEx apt8TUMG7xzGKdtdD7Y45PYKFWZwKBvNs5bPLAFSNoBM6E2yrfNnBgst9ujsZnnO1Bbm0Wcwr dZ6YgXrJNbeqYN21A59qLIMSsdLBrSJ4ZC3JncgMHZXwDXtwPgQeHvMLDlZ2oXKUs9429dZv0 K23M3bj0y/HCkBGchadntAedbVCGz59FCJv58XoD/6btYbgfJzf/V+4Lx4ppS6H4A5WgEZsCz Z5VKt6n2BvL+VTVHvS0WvM7GfWzYJd2xP6yqHtQ1O39bGfpu+TZJJuShjorGWKxgBAWEfAEkw VVAasPaXjo7Bv/fdmi1zvI8ubzndE8C/AtwcBqErpMQr2ZOPGYWXHFVnutymZwhRz7R9nLEtH 4kABEnTmBOxZV0Ga7LB6LsAlSwB7J4Wb/DgKvykh8LWD5gli9NYh0uJYVb/mi4x3rNtwqi4/y 1bxsbG6Png9rABFv0JZ8qwHOyGPjWraC4kv6rtz8cRiTVwJIEmTEiINHxJkJ0tzGjRBM7mToQ VS4uAoHhi+t8fd+uLa5em5jmP8gpekylChhxcTceTP/3fEHQKB3/voe2kyjDSNOAf85L3TGLC 6zeJ1IxkbQZpdSoIQ8kyUgzsVYDg2r7jCK+v1R6HRWZDWbEO8anQrAPE2EbzlkwSZJvQdpJQy gvhCJ4ZFSxqYqqkJOhIbM+0HB4ia0QNCsZvSLJMZO5jIRznGf4erfaOr9+JR07AKqitu8gPnl aerwjNzpwj+ERCzW8D7KYFi3xj/CPVEpk8+wVARj3fRjf39gI8ynX2IVblIn+hmFPkq411a/V ObaHBPzhUBdX359NYzj7ztD8E2jpHX6t1APjEJMGwMGVHf3NPYMDuwcSIrmD9kj2rQDJ7y+yG uyN8G0nXgA8vjyGmTDWOG6OliLlHEwwvMP4GBXA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Mon, 24 Aug 2020 14:27:41 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> So this bug report is basically a plea to change the default value of >> comint-password-prompt-regexp to be the same as that of >> eshell-password-prompt-regexp. Or is there a good reason not to do >> this? > > The difference is that the former looks for something like "enter" > before something like "password:", while the latter is just looking for > variations of "password:"? > > My guess would be that the latter would have more false positives... > but you'd think those would be pretty rare. I can't imagine many people > having shells with prompts like "Type your user name here but definitely > not your password:". > > So I think replacing the former with the latter might work, but comint > is very old code, so perhaps it supports older shells better here... The minimal change to fix my use case is to add the carriage return character as an alternative to comint-password-prompt-regexp, as in the attached patch. If even that is too risky, I'll just stick with a local fix. Steve --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable Content-Description: comint-password-prompt-regexp patch diff --git a/lisp/comint.el b/lisp/comint.el index 092902d865..b6098f449d 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -365,7 +365,7 @@ comint-process-echoes ;; See ert test `comint-test-password-regexp'. (defcustom comint-password-prompt-regexp (concat - "\\(^ *\\|" + "\\(^ *\\|=0D" (regexp-opt '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" "Enter Auth" "enter auth" "Old" "old" "New" "new" "'s" "login" --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 09:03:00 2020 Received: (at 43003) by debbugs.gnu.org; 27 Aug 2020 13:03:00 +0000 Received: from localhost ([127.0.0.1]:42099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBHYS-0007vm-Gz for submit@debbugs.gnu.org; Thu, 27 Aug 2020 09:03:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBHYQ-0007va-NI for 43003@debbugs.gnu.org; Thu, 27 Aug 2020 09:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y6csyG/3xfE37ed1RRAX5ycy1O+yduWL+hiiEAEJMSE=; b=T7aEnH8j67KLRs5eryxnwTLg5p JgIaIjOTP4b8Af7Yr6bpHy7gjAMEAWtN3PUar2nHA1Py719GgXDOa+ms4aEa0TVZpXHYAzHY6NKU9 IF92CgqsEDVPbicO09HbAjbzZu6sWdXKNK2cOCaomsp2d1YlXYVk7PwscRJwEguiI5Pg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBHYE-0002n0-GW; Thu, 27 Aug 2020 15:02:52 +0200 From: Lars Ingebrigtsen To: Stephen Berman Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXFuZpoXF3Am2OU cEH///9sZGuXAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QIGww7AMPBfjcAAAFxSURBVDjLtZPrkcMw CISxKgimAT0aCNB/b7cgJbY8dz9Pk5kkfGYXEKaD6EV/nL/AQf8GClEt/cLv78/eS+/fko7XJzrP F+g5dcoDFBWqCSoloz59DpePM9RqAHzhnyrXeLjQ0krg5upq8XBZFVQy7y4qrgxQIhlyEziAM/O5 HBIQufhgWWCdmsChkkdmrEQCACMu+CwwW69oCQGHkMhYcyvZRQBPIesT1NUlgKZSH9ekaQIPqTOU HyCMlbUZn+22GBl39sbtre11AQ0iYk1aP5QvEFFkKI5xO25SLuHAOk54lJuUex+CEecK3EpGsYaK zWuAegcGBza3viWEFIpVeReiDXjMHXPMi733jpjHOEZe3gOU9eQTWLdI6mUDUW74WI0l2TPG8Gm0 AYQGmiixa+Uh5dFd3OkOJIXM1hJfAIMaUqf8BrC2yGJ+1hsN5jaqPIYoc1gyJ3P3iPlmnm0AFy6/ AiQgqtPpAdaN4G17X+4/4FBLfdXAE18AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjdUMTI6 NTg6NTkrMDA6MDBuU+D5AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI3VDEyOjU4OjU5KzAw OjAwHw5YRQAAAABJRU5ErkJggg== X-Now-Playing: Jim Black Trio's _Reckon_: "Astrono Said So" Date: Thu, 27 Aug 2020 15:02:44 +0200 In-Reply-To: <87lfi1emz4.fsf@gmx.net> (Stephen Berman's message of "Wed, 26 Aug 2020 12:10:55 +0200") Message-ID: <873648xmvf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > The minimal change to fix my use case is to add the carriage return > character as an alternative to comint-password-prompt-regexp, as in the > attached patch. If even that is too risky, I'll just s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > The minimal change to fix my use case is to add the carriage return > character as an alternative to comint-password-prompt-regexp, as in the > attached patch. If even that is too risky, I'll just stick with a local > fix. > > Steve > > diff --git a/lisp/comint.el b/lisp/comint.el > index 092902d865..b6098f449d 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -365,7 +365,7 @@ comint-process-echoes > ;; See ert test `comint-test-password-regexp'. > (defcustom comint-password-prompt-regexp > (concat > - "\\(^ *\\|" > + "\\(^ *\\|" > (regexp-opt > '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" > "Enter Auth" "enter auth" "Old" "old" "New" "new" "'s" "login" I don't quite understand how this patch helps -- doesn't this just require a ^M character before Enter/Old/etc? Did you mean > + "\\(^ *\\|\\|" ? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 11:09:13 2020 Received: (at 43003) by debbugs.gnu.org; 27 Aug 2020 15:09:13 +0000 Received: from localhost ([127.0.0.1]:43626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBJWb-0007QF-G2 for submit@debbugs.gnu.org; Thu, 27 Aug 2020 11:09:13 -0400 Received: from mout.gmx.net ([212.227.17.21]:56355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBJWZ-0007Q1-1K for 43003@debbugs.gnu.org; Thu, 27 Aug 2020 11:09:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598540945; bh=I+IOfjN2LbsAlw8wbrtg0CBiyVmrskTlPgOK594F+Bs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ZQDdNj6HjkplJFBwVHIRTzyqMViupZuOsRHMs/IfcxRIw1BoiOHb+EQCb2dFuMAX9 RUM7Yn8bn6aBX90nCX9f1VTSrGqLGG+dfONRt0xwBEw63lMNE2NIqNmQEF5J/Y7Jsz Sw65zmXTVol73UjleEWn8A6nXGv4XHgjYMOlHK+4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([178.1.125.104]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRmjq-1k47kQ3iqw-00TE49; Thu, 27 Aug 2020 17:09:05 +0200 From: Stephen Berman To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> Date: Thu, 27 Aug 2020 17:09:03 +0200 In-Reply-To: <873648xmvf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 27 Aug 2020 15:02:44 +0200") Message-ID: <87sgc83z3k.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TWmyOYdS5kMjLIBsgPfeD4guuttbUHsu7h2UIe/atn2CMLsZSQS cPfalZ5N6s8QO4fm568PRravIVftHUo2cuT0QCPgy7ScpFm8J8akWxXYyJstxGOurwCzG0R 5jI6y6wg1QExzBvjcoQf9jA7GVyViyBFQlp9V5Vy8Il1pIf7TdaN//6Bi0x1TxZkZQhlsZW KWMOIBVjIZVQG3Ows1rpQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4H4Weg5urks=:iaO3MsdgTKlSAMcN4CtM1/ YlgWvGqwSFWHrBmUk+C8WLMR7XY+jBwS302f9qV46SPtFUxirqoXKssXlWgVSa4n8GSVc+blK ytx6Zkwbyaeaj3Zy0i64asG0HB1XcG/bR27X7gPSXtKxe+OgxnhY7HpZXGTR6u0/6tUprAoRn /hZSP+RtfmkfpRyombm9lArw4XPzTZ3WgeJOR4qJCaMW4liyhOABuBfgaSQCbM9N9PzIxNOKC eQBy1MjfP5oZbjqoQUPMMSD9wrpoDefdsfRDlx6c1d6Ew2zOQlMfqG0u3AEB1geTPjVoNgvvL G8FWMKZidUWW0/aXKcyt78QoGwE4NBwVnrSTreVmXJLANxF1WCOQyyOGuSKJH4JNCZgth87Hq RiOvL2y9Ehql3rHvce1gpdplNVBRXiQH8x+7i441v1Uat3TOybnjLMmpz+OqrWiHlb/VObIYM p0QOmA6BOB4dDCAz7CAraaC099U5SM1USj3bFwHcbwsKMkl2Vd60zD6hExZbfCeHnf1Ldbo2l QHF9OTHrFU++un/Vm4tVM89F39quxXjV1U/JnF11H2FV5HQR6Pd8YuGpNew6BhcH7TGNRIT1y Nwl4RiUHpwehtGdsifxWRgCielI5I3G3o/DSddwkv500v7B1Tg2E8n64AtiAK77UObwWqbCU0 IlsCeREGO8wh2J1mUvx3BXwDGYPOYr3+1Rj/X2KnmqJ06VpphgLj7ic9QSDD+AgPy+0ef3xBm Ymk6IobesTvdqvcxG8HY3T42BK0RVvbFoki2+LNyAUz1Fvy4Dts3Z7jQTyUCrfWXI7jY4iUwo 5rRKR2kMsgp3Twch7w7Ssy7/6QpEZR6MZg2H28D7tYdpfu2JUx618go5/+Mw7nEmXUe6ScoFm HAAq0IFyMrkf+O8pYbPZKmYy+wqk+w/26lIF6bTCC57NqjHKk2RlOq6APNT04G+ATG9e64q04 s6z09d/GPNaVBbKLw0gdFT6UbDHi1dig2gtI2e89PjEnHRPz1tWrPuwtPYXqCkx/8kSSHeg7D fNHJlnV4rlIX+NOIzY05pX6IE2Jnb8m0lvsWPBNzla5YAq0k3+g0mCRmB5Ek2PoX73IGG3Tfz vLsRDkXKnokYwUklVehJyOrgQLee8G/sdFMJrPPmuOdrI7DZSFYlq9WCydpU75zbbKWMu4zyk T1Wp2iauarak2REBOFopox30X6jPg4noRloNymIZrdGDTE8rEum5llR2MyVtLnmuLglnpOH1E 60P60GwHIybLLs1KVQnWCxlr1NBYiCDd/YJ/XAw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 27 Aug 2020 15:02:44 +0200 Lars Ingebrigtsen wrot= e: > Stephen Berman writes: > >> The minimal change to fix my use case is to add the carriage return >> character as an alternative to comint-password-prompt-regexp, as in the >> attached patch. If even that is too risky, I'll just stick with a loca= l >> fix. >> >> Steve >> >> diff --git a/lisp/comint.el b/lisp/comint.el >> index 092902d865..b6098f449d 100644 >> --- a/lisp/comint.el >> +++ b/lisp/comint.el >> @@ -365,7 +365,7 @@ comint-process-echoes >> ;; See ert test `comint-test-password-regexp'. >> (defcustom comint-password-prompt-regexp >> (concat >> - "\\(^ *\\|" >> + "\\(^ *\\|" >> (regexp-opt >> '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the= " >> "Enter Auth" "enter auth" "Old" "old" "New" "new" "'s" "login" > > I don't quite understand how this patch helps -- doesn't this just > require a ^M character before Enter/Old/etc? Did you mean > >> + "\\(^ *\\|\\|" (It looks like Gnus removed the ^M characters.) Yes, I just tested again and the password is indeed hidden only when `\\|' follows `^M' in the regexp. Apparently I omitted that when I made the diff for the patch after testing yesterday... Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 10:09:09 2020 Received: (at 43003) by debbugs.gnu.org; 28 Aug 2020 14:09:09 +0000 Received: from localhost ([127.0.0.1]:47030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBf41-0000bj-Ka for submit@debbugs.gnu.org; Fri, 28 Aug 2020 10:09:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBf40-0000bX-Bq for 43003@debbugs.gnu.org; Fri, 28 Aug 2020 10:09:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UtmLtVgF0iyJcPrP2vG9nCeh0EMH4WTdscXF34GEY+o=; b=RN+PrKggLPDC3iNUHeOWO+eznQ Hw8sdZuJzB1HKqxOV1u7oKG7xZvXiuGxs/S/Szm6pqK1XNI44LUfXbXRTMrHvHaOpVmiHApXe20rf OMpJJp2V1QW30M6QMl8qcjoBsFtlOJenrIhvwox+qAlKr8Z+Ieb1JWbNONjNB5Gk9X0g=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBf3r-0002vT-T4; Fri, 28 Aug 2020 16:09:02 +0200 From: Lars Ingebrigtsen To: Stephen Berman Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWpuctxj8g9R1r/ //8QJ8S9AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIHA4FDBXhxbYAAAFlSURBVCjPTZIxj9swDIUf jVMGTyrQ3JCps38FPWS5yQHMAPXcpf4V7trJGW73kBxs/so+ykXuOAj6RIl8TxIgZh2ecTTkT+jT Z8rMdF8FZNj2hPYc3B/AsG3gWrVB3GfUExNVzIIXQl37HgWqMh19FuA0/Xh118Y7Aw5LSqaHzrXl 0Q0Xa5dqLc3G6Tt+ymkOMVrfRebMbkdodP0l9R2UmxR+0zxqsnBzGe5yWJGo85vZFXmcIcWNzFI5 zb4EJOTmbeqtDRjb6uGPYtfMl8b/3s49bRM+3D8WBWsT3JMvOa4s4I5mTQF6pK00uKgZdw4b+/qk YkyWGKcsccbsbHZaXpACWuKw7tqMj2LXtXk/o8hIlpyuCB21Ghvc+lKg4zj4e1cOMdde3XKBEmz9 nEd8hb2AfMko5Anxruh0h/+fQGjb/c/+C/iABLoG77DyLcBDasbrA2vjzh9w7CAt3mKf6G/WvPwD bX2cIoGJqjYAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjhUMTQ6MDU6MTIrMDA6MDBCuCXs AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI4VDE0OjA1OjEyKzAwOjAwM+WdUAAAAABJRU5E rkJggg== X-Now-Playing: Mike Oldfield's _Tubular Bells (1)_: "Tubular Bells Part Two" Date: Fri, 28 Aug 2020 16:08:58 +0200 In-Reply-To: <87sgc83z3k.fsf@gmx.net> (Stephen Berman's message of "Thu, 27 Aug 2020 17:09:03 +0200") Message-ID: <87mu2evp51.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: >>> + "\\(^ *\\|\\|" > > (It looks like Gnus removed the ^M characters.) Yeah, probably better to use \r instead of the ^M character directly. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: >>> + "\\(^ *\\|\\|" > > (It looks like Gnus removed the ^M characters.) Yeah, probably better to use \r instead of the ^M character directly. > Yes, I just tested again and the password is indeed hidden only when > `\\|' follows `^M' in the regexp. Apparently I omitted that when I > made the diff for the patch after testing yesterday... That makes more sense. But I don't think having ^M as a password prompt regexp makes all that much sense, though -- surely there's no ^M involved in prompting on non-Windows systems, and there you'll surely find ^Ms all over the place, not just in password prompts? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 10:53:55 2020 Received: (at 43003) by debbugs.gnu.org; 28 Aug 2020 14:53:55 +0000 Received: from localhost ([127.0.0.1]:47133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBflL-00069n-AA for submit@debbugs.gnu.org; Fri, 28 Aug 2020 10:53:55 -0400 Received: from mout.gmx.net ([212.227.15.19]:42835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBflI-00069X-Lx for 43003@debbugs.gnu.org; Fri, 28 Aug 2020 10:53:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598626426; bh=Y43N25gBkki8bne5tLKbIJhR0kRtaDdpgo6bo83mHso=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Jc3ZqBXINnVaaUTGMreoP8yghDPN8LC+xXAd8Z6noq6G4mLKZ7Uj+/0H2it4coD0X 7fG2j87Hg7YrsQdY4OX0qjK8zouM8MlSNxStSavM4dJUhMZgbgpKZ4olU35gEAxq1H z8e+opPL6ROOffWllKa3ve7G4+cita6CJPQa2ZLE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([178.9.96.201]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MrQIv-1kzbQL2UDf-00oSpO; Fri, 28 Aug 2020 16:53:46 +0200 From: Stephen Berman To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> Date: Fri, 28 Aug 2020 16:53:45 +0200 In-Reply-To: <87mu2evp51.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 28 Aug 2020 16:08:58 +0200") Message-ID: <87tuwm95za.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:2JbboGwtH6WRwiK8s8mW3MDLIuvgAGPsddtEfLVP8LJkvKWTGsu CQazVabkrS3bvhljq9nOkQdbV1u5dttbaFALmstF9J+4F1XPS7iBg9cgUFNig1zakPvoPxY 9cBN+n1MXTiOCACvG6l/xl55Zq5GWr5lTxIVsKCVqo9TxeGgsqvojsD1tz7mIHxYvcO1c6L aKLDBON5KydHkKDEWcx/A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:DMFHXeNwZS0=:dLVLnaio5cUZC78IbDsYLJ abpKje3lOZWejnD8AkivetkRsOnhPp/0fGtvbcFpNQfnoOzdx5DraZVMLJGO4lOCiti7BMv1e ij9DfkWttffxC+ERJ0VuhxPGH1s2jNeuocDcp9f4RohCJmNbo4GMFOnQKX+FgvkkvjL8dNtaG fMKEf2+NsGb63maFN/GXLI17crHWHqLt+Fhg0jXXuXekUUFwu3yjvttrd2t/L/GSCk/kGNQwM /KlKPDVqV7VL3i9lsyTDOMxScSRyxoyNFZZf+JctYOXQXc5RckPcW+PGq0VwBgacn95cg/o60 ocVHcKcrv2fwq5a0FCOtA6me7eTMs73viZtfkufU6jjVGKgxrZTF5m1jAxpN4HQmBkZXLu4Pf FGlrAHtRXl1QUP94G5jn9u1GIZXb2Z+6lxl2AevZTuN3ePdjp93s9c7vfmeZyYWPnGOhL9FkT Vyq0MqmL/RM7jSFcGU3pMjKVFhDVeo0PNdUA+UK/BxpdNGDyUkSV6C0YUARVJ+1a+R9VgbYD0 5Nlu2ISYQ0efnXg+lUTzZJIlsbXmD7NvQFL3KkZSFvBBOAntWdZ9ayOVcQ9gOUN5JCOKZ9MKt IoO9sUl/LGHQuP9zK4zAeJSujAqjDp1f+S7Rg4a24+XD7iWlCAI6SlBu2Iq4edgT0s8aBfnri 3YL70BopFDaCspIniXY51WqQ15b6ae5t8LM5MUA6qS67IsisxHa1CGr4hO0/GbR21CLcgFDcR C6+flnba4Web/iAwQJ15B1aM11yfAYPP0co4Z2aE3u8kyRAM8oi9qOWwpHgUcipvpr9lK29r3 KHprGu6/1a0zZ+eYJaCFeFrX0Mc7h48LrTsgpbnzZ8uAyF3+VXlBhQl3TcLVPJ2RLlk8hVrXr WYG5+sk/gEIbjH8DtjOH7VNaOcLUUZ74A424U79qFn0EJ2tAEJLjV2GM+ddm3GAEhIphsETSV NRSGqo74Li40wETL+uWTmApYa9iC72QBoC0joVXNK4SJlvJ3VAX2EhN3TWKLX9X5HHo8d7s7N MBYCUhg2XClTvvM+2k+mwO7Db+vZudfdDeeylzKednClXGEeCO7UBAquVasaP2XuktZilbpb/ fTO4drY1BseiN+VPf87Bch2sw+Tc8uMjNSEvpUqDyL+596odwfl+qvr3+7NQLFE9iqRvZMyjC DlUespr0iusza0iD+kvCRlJDBwnPRx4saK5uUGi5M6fbim3NxjGGS+8x6sJCGeMDd7qAQP5nJ wq1NteheYFsgdAWlhAcFBQXAMqSRquUbqMRcQhw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 28 Aug 2020 16:08:58 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >>>> + "\\(^ *\\|\\|" >> >> (It looks like Gnus removed the ^M characters.) > > Yeah, probably better to use \r instead of the ^M character directly. Oh, yes, of course. >> Yes, I just tested again and the password is indeed hidden only when >> `\\|' follows `^M' in the regexp. Apparently I omitted that when I >> made the diff for the patch after testing yesterday... > > That makes more sense. But I don't think having ^M as a password prompt > regexp makes all that much sense, though -- surely there's no ^M > involved in prompting on non-Windows systems, except, apparently, on mine ;-) > and there you'll surely > find ^Ms all over the place, not just in password prompts? True, I wasn't thinking about that. Then I guess it's best to leave comint-password-prompt-regexp as is and I'll just change it locally. The problem I have with it doesn't seem to be widespread, to say the least. So feel free to close the bug. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 09:41:51 2020 Received: (at control) by debbugs.gnu.org; 30 Aug 2020 13:41:51 +0000 Received: from localhost ([127.0.0.1]:49645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNah-0006zj-MI for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:41:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNaf-0006zW-OZ for control@debbugs.gnu.org; Sun, 30 Aug 2020 09:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RoBn+65Ndj0+uvRYlcEmjEXgpIb6Mrk/sSZWK8t/fkU=; b=X4tMsvVub53X2DA+rMBo778RsB kFmlxmP8XkSRZ8iZ6EuaannducFcB/NCPcptbTQp7X/yuWsC5ywoMqZ527jMfkRTH0pAMZq7S0vKa gG+KIb/hxDjL9sP8OHqFxZ+IVUlTn5bCuVHblX2VRu0JJ6HKn818MWwVLELk5kH2xPlY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCNaX-0001Bg-Ej for control@debbugs.gnu.org; Sun, 30 Aug 2020 15:41:43 +0200 Date: Sun, 30 Aug 2020 15:41:40 +0200 Message-Id: <87eenotfmz.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43003 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 43003 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 43003 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 09:42:08 2020 Received: (at 43003) by debbugs.gnu.org; 30 Aug 2020 13:42:08 +0000 Received: from localhost ([127.0.0.1]:49651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNax-00070r-Rl for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:42:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNaw-000700-GI for 43003@debbugs.gnu.org; Sun, 30 Aug 2020 09:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9gSY2Cu34co3W4theBxisHG2Oxjyuk93Q2zrVwhnrkM=; b=VoTssWWgsT3KIOVsqARfX6fTf3 +BgldTELUV/AtS6MYv9kkB4fmFv/macKhOkAD7178LPJakIUpTGG0R510xVIng9HTIQGf7obcoQ9h UF0yRs8rgW66HiVKFW+ZULyY/HR2R1IbUuhtRMHaguBNI8izdb5zPiaa7ERgaGiuxeHY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCNao-0001C4-89; Sun, 30 Aug 2020 15:42:00 +0200 From: Lars Ingebrigtsen To: Stephen Berman Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUSDw4qKCc/QT5+ gHpfX1ysppn///9OVc6wAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QIHg0pMdz3lNsAAAGISURBVDjL lZPJcoMwDIYtwgNILr1jD7l3YrhjEPdMYr//q1TGZGOZTnXBw2dZ+rUo9acB7fyzxloD6YjgWjaN T+fCaGuYcbl1jveBh3QqebDLnWSnGG8ZVJUX0KvFpXiCgSRGUyskIgV10cXbOAOPQMYiYNF4Kns4 C7jMiUimpOWrdU3nXoKEDJIEFBFCbTP9qPIFstVUeZquWyA5KDr16nsFQNItwlSLwpDTfbPWxr7a ABRtY7xy4zYeZYwxTNxtQBXjPYxuC5ouBnCuu60AsIvRuHa6rD2Y20GNzq1AObCTdvEawFe8jN0F xM1n8OhpEUMxBs3MZhVjCqhNAv7V6LmIlRdnLTH8qiSQOUl3PmcMUB3YBgAeXNaW9gHZ/aehMbQP mI7Ap0eavlwkrumVLoAxT5A9snKQSX4+ZempXYZVm0UWNDMARWmKUVG9yAJZwBQTUBYiFZgeenV+ FaQ0sruyRo8NhuUGzXnhWzFzUrAUntSnLli+lfTXqH8aHvwnPHTR9YGLwV/8Y0JxFkZNUQAAACV0 RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOC0zMFQxMzo0MTo0OSswMDowMDir/t4AAAAldEVYdGRhdGU6 bW9kaWZ5ADIwMjAtMDgtMzBUMTM6NDE6NDkrMDA6MDBJ9kZiAAAAAElFTkSuQmCC X-Now-Playing: Mega Bog's _Dolphine_: "I Hear You Listening To (The Bug On My Wall)" Date: Sun, 30 Aug 2020 15:41:57 +0200 In-Reply-To: <87tuwm95za.fsf@gmx.net> (Stephen Berman's message of "Fri, 28 Aug 2020 16:53:45 +0200") Message-ID: <87a6yctfmi.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > True, I wasn't thinking about that. Then I guess it's best to leave > comint-password-prompt-regexp as is and I'll just change it locally. > The problem I have with it doesn't seem to be widespread, [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > True, I wasn't thinking about that. Then I guess it's best to leave > comint-password-prompt-regexp as is and I'll just change it locally. > The problem I have with it doesn't seem to be widespread, to say the > least. So feel free to close the bug. OK; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 05:26:20 2020 Received: (at 43003) by debbugs.gnu.org; 31 Aug 2020 09:26:20 +0000 Received: from localhost ([127.0.0.1]:51561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCg4y-0004bi-3n for submit@debbugs.gnu.org; Mon, 31 Aug 2020 05:26:20 -0400 Received: from mout.gmx.net ([212.227.17.20]:38169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCg4w-0004bV-5I for 43003@debbugs.gnu.org; Mon, 31 Aug 2020 05:26:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598865971; bh=o6wFO3QXY5sNal1ceX8dhkNhgxkLCZ9cAUwnEVaAJDc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=PtwrZ023uM7MGnj40NEv3+GBK1u2iVIHFr44YUD0VT21POsm01TkymNKX+cdtd0cn yYp6oGELD5s5xQZxiWfvj7cXZ560js8YG96IuU6102UwI7IMBZNtiRbW6piq8HBrJx 7Fbb2Yhd3AYrW3cULw9ObAlakt/YlNLdPaA8gki4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from linux-tuxedo ([178.6.210.84]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MXXyJ-1k5nWm2ezf-00YzUY; Mon, 31 Aug 2020 11:26:11 +0200 From: Stephen Berman To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> Date: Mon, 31 Aug 2020 11:26:10 +0200 Message-ID: <87mu2btbd9.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:zY+lZVGDM3AbJCWwXPcBEpRfqWCcjATs3I6snQM0ndxQgWBkF+o HGjyvo4W0tUsxe0fDCMEHBzeg5mYcwAMCmz4SMeafSgB+RhQcqR+UIRmfj0PNpmTFTxbpGP WhXABtM3V4VAateTxzqwc6GxGC1ZP4NpgYlCPVR1/82h9XuUoqVMnh5ensxpS4zVrfqi2Ui U6oYxNfLBvCLPjJle1JBg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:oOQGC3P64vE=:UD0/WkPEFGcIRTcGorDj7z O3eSLwB0YaShXUe3cR+2Lg7PsS6FxRVbG7g7lOpOCpInYp2jJv+8+f4Bf0rYGeEY15QLPoQhS XYjdfn61AFnWYLhzrPwJl5oT0IJ7y3J+oQrGwV7oTcY0t6BS+Dt6q0xPfwqqGXzdLsLnQTAiw fz4+wQhh/cmS0YoXP9R18mqpPCKzXFW2yFyM2jBhdtZHggd34r/T2kkSBIn8Jk/iRUwMBmbyB cEj3exfjdS5/etATiK3Wk9F2yEcz+qNxWVmNm175NwZlPI2dclhhdRGmfEFKJ2RW9UQxz7kC1 Os3LEGt3z402RjSjaGmiV+IBrq7A7dozyVcP+KcqJXwk4GQE35ntzEl/ia1mO3ZA3AkazM+v+ /++JcoqcWrs7clE9FCcckZLs4t/kuwX6mjl8K+Zk3os7Y45jNG1eyHbK4GREoLFZqqGjHR1tF /hDM5tUmU1hKpptmhFZhlsB0R+qbh7MJ6GrY0v/4x432T158FahYPbOpguz7VczG8MBkPVhej 2fAXRr79WZCH6Vao8QG8cpkU6YmtKn80/4l294AnU7ALP11VUVnMKmlThmOQ2DEhpjMghr0lR 05kMBkuDidWySYvmhk9Ky47CrhNd6Ke6WO3Jxe/QOWKFFQCT9D8GdpzzkMsU97uLwWDwpypS8 /ckZ1wly0Qaoyiu2fcBmKW+9dlaqq/GIO0SYpp9awB/GXKySP75qhQpOPxRnj2PKVz6TJAQCR 6Jr3EI9mLVCFrSV1J1pomD2M+ZPp46cZgxrLYSqNdRBXx4xbyQuWDsD9d+awLqVLJjlV5obVS 15brUFxTCPZGWtEWCJ0edxsj0gqN5E1pXpX6aynq/TIiE8ciY31bVxqCBaFLvvvr9Uepta/Cp HWos3upfwowdU+ykbrtDi0LNhGRKYdpBiIU2TtGOD0NYABMdcmzyQM7oLw6/g4tnCdZDBzXBc s5VB0Bj6mMa55GwrrPYkWxWY4HyNq1/MPesZ9+BpFWSiHX9fw4ThjAWufFJDKhdVvB9T0tAmH lopClmtItH9gIUTu+1Spqmx5tRheK8SaqxPWacXN50qNwCXf9Wvf4AkvlIr5THN6rj9+Oez2H vRLKiThsY35akWx4WdaKSmB6a7pxcts7u2OOkMvW1LDejj/Mw4DBiA92jwKZ58KFenfiDeyJI c8A3q2glwiCxKG8Rzw1vJq+FOctTQacIDSS42pDR0ShZCqcU49RHfuqk2jOYbC+TEoSm70Ot3 7tMoYUkXBycE+xL6TB6/DCtlSHEn81sXDCq21ag== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 30 Aug 2020 15:41:57 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> True, I wasn't thinking about that. Then I guess it's best to leave >> comint-password-prompt-regexp as is and I'll just change it locally. >> The problem I have with it doesn't seem to be widespread, to say the >> least. So feel free to close the bug. > > OK; done. A postscript with additional datapoints: In my OP, the the system that the problem occurs on (Linux From Scratch) uses openssh 8.2p1, while the system without the problem (an older Linux From Scratch) uses openssh 7.9p1. I've now reproduced the problem on two other GNU/Linux systems: current openSUSE Tumbleweed, which uses openssh 8.3p1 (and I see the problem here on two different machines), and openSUSE Leap 15.2, which uses openssh 8.1p1. This supports my conjecture that the problematic carriage return in the prompt comes from openssh. If anyone else running a system with openssh 8.{1,2,3}p1 can reproduce the problem, then perhaps a different way of handling it than changing the default value of comint-password-prompt-regexp can be found. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 06:12:09 2020 Received: (at 43003) by debbugs.gnu.org; 31 Aug 2020 10:12:09 +0000 Received: from localhost ([127.0.0.1]:51597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCgnJ-0005hr-C0 for submit@debbugs.gnu.org; Mon, 31 Aug 2020 06:12:09 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCgnE-0005hL-Kp for 43003@debbugs.gnu.org; Mon, 31 Aug 2020 06:12:08 -0400 Received: by mail-wr1-f65.google.com with SMTP id k15so5303243wrn.10 for <43003@debbugs.gnu.org>; Mon, 31 Aug 2020 03:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=MpQFzsC3ZUwTTxw/EAovdCZ0XhJwGy3l9cop82CY2M4=; b=gmKYhDVwJNt3AM+BG39qW/69G0JaX1LQdJlr8+VoaTWFrvP6rL/7btC62s4QI7aNQL jZjurl7YH3SKKu6Msw9oRIJ4J6h8ePBSpcnBOMnPh+Yi+Wag2f238BZUfaawnhs8ZPOI oP2hVdtNw7oMFat5KWxhs56i4alPyc41uhCgGtuHDyxgGDJny61x5ui9Sj4IsyZRubRV 9E/rpl1m+BglKgy5+K8gpKNdcIwR2IebfqYNzJw7FYuOvqodvOLqZbnKE9oKZyv9VhVR Fw5FDe7K/uf5TLvrcL8M5DS3WJR7HdKUMCrB/8wiNSlcqR7ub8p+YuRsrChcqRt/hhPy 56eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=MpQFzsC3ZUwTTxw/EAovdCZ0XhJwGy3l9cop82CY2M4=; b=VQOcYbJS15EhyW7kSZTEiRiMhDyVkIqcPddSvAde0uSH2JhK4MQgcXvs019YxAi5KS +inUa7VGt6xaatx9HwGWfv6PmpXC5QJYgCsHXW/XYI8aSlJduyK3n9jHc0jlScQAU6ic dwVwDmgloGXUhntkdCzT+JsVfqqW4CZBRjqq1HbxlY7ylMkUtfo9KRxtgf47xb27VVah ePzmqJbYgZH5aEEm0US88OBCSAR9ebDh8nzNiWpj9TUD9SpzpHv1qaT79Zcxj+TXT2Qd ny0A1vD+mRc0N00+VkyTagfwYUcYF7+EG/n/26Nu+muow2SwJfX7nyK8sAopWi5PvdYX BhsA== X-Gm-Message-State: AOAM531zRgaVCgEy29dPbz8UAw75l4FF4tgVA5KPtXfiYmtyEKtqndZV K0HQEJxtCAy2XEaLdNxcndMGdCTYlo8= X-Google-Smtp-Source: ABdhPJxf0AhyqV5C4JS2NfC3kOoWNn2EWTH3doIsCGIBJCI90w1wJnsrxEe4Tsxw6Se8CECnrJIueQ== X-Received: by 2002:a5d:574e:: with SMTP id q14mr867682wrw.281.1598868718296; Mon, 31 Aug 2020 03:11:58 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:4833:59bb:ac1c:3d8d]) by smtp.gmail.com with ESMTPSA id g8sm9926559wmd.12.2020.08.31.03.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 03:11:57 -0700 (PDT) From: Robert Pluim To: Stephen Berman Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> Date: Mon, 31 Aug 2020 12:11:54 +0200 In-Reply-To: <87mu2btbd9.fsf@gmx.net> (Stephen Berman's message of "Mon, 31 Aug 2020 11:26:10 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 31 Aug 2020 11:26:10 +0200, Stephen Berman said: Stephen> On Sun, 30 Aug 2020 15:41:57 +0200 Lars Ingebrigtsen wrote: >> Stephen Berman writes: >> >>> True, I wasn't thinking about that. Then I guess it's best to leave >>> comint-password-prompt-regexp as is and I'll just change it locally. >>> The problem I have with it doesn't seem to be widespread, to say the >>> least. So feel free to close the bug. >> >> OK; done. Stephen> A postscript with additional datapoints: In my OP, the the system that Stephen> the problem occurs on (Linux From Scratch) uses openssh 8.2p1, while the Stephen> system without the problem (an older Linux From Scratch) uses openssh Stephen> 7.9p1. I've now reproduced the problem on two other GNU/Linux systems: Stephen> current openSUSE Tumbleweed, which uses openssh 8.3p1 (and I see the Stephen> problem here on two different machines), and openSUSE Leap 15.2, which Stephen> uses openssh 8.1p1. This supports my conjecture that the problematic Stephen> carriage return in the prompt comes from openssh. If anyone else Stephen> running a system with openssh 8.{1,2,3}p1 can reproduce the problem, Stephen> then perhaps a different way of handling it than changing the default Stephen> value of comint-password-prompt-regexp can be found. That matches the analysis done in https://emacs.stackexchange.com/questions/60394/unable-to-push-into-github-using-magit which leads to: https://github.com/magit/magit/issues/3843 TL;DR magit decided to strip the \r from the prompt received from openssh. We could strip control characters in comint-watch-for-password-prompt, but then people who've legitimately put control characters in comint-password-prompt-regexp will get annoyed. Perhaps just strip '\r'? (And document it, of course) diff --git a/lisp/comint.el b/lisp/comint.el index be0e32b9e0..74c5c7f94f 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2427,7 +2427,8 @@ comint-watch-for-password-prompt This function could be in the list `comint-output-filter-functions'." (when (let ((case-fold-search t)) - (string-match comint-password-prompt-regexp string)) + (string-match comint-password-prompt-regexp + (replace-regexp-in-string "\r" "" string))) (when (string-match "^[ \n\r\t\v\f\b\a]+" string) (setq string (replace-match "" t t string))) (let ((comint--prompt-recursion-depth (1+ comint--prompt-recursion-depth))) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 08:06:00 2020 Received: (at 43003) by debbugs.gnu.org; 31 Aug 2020 12:06:00 +0000 Received: from localhost ([127.0.0.1]:51762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCiZU-0004f1-AW for submit@debbugs.gnu.org; Mon, 31 Aug 2020 08:06:00 -0400 Received: from mout.gmx.net ([212.227.15.15]:57825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCiZR-0004el-IB for 43003@debbugs.gnu.org; Mon, 31 Aug 2020 08:05:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598875550; bh=JrlIKyotybtWnaslOSZSvGK28qTexYDBJx4+aFXV+0I=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=BnuULGPJafapWQjBYX7yP3jgtfoQCPk0KZAwmL24ZYXSS4w2Ytjee0rjY5TiqT39N /Y/iLrfewh55j6qL4eVS6KXf8esH3Ugt6Kvru0dkJYMU7umMtVyZ+mpuo+r40mzqBB eif6ptKPPI/Ecfz1EsdZzvc0A5uf0/hLbtHBhuAg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([178.6.210.84]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxDkw-1kWKsY2WYi-00xeAZ; Mon, 31 Aug 2020 14:05:50 +0200 From: Stephen Berman To: Robert Pluim Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> Date: Mon, 31 Aug 2020 14:05:48 +0200 In-Reply-To: (Robert Pluim's message of "Mon, 31 Aug 2020 12:11:54 +0200") Message-ID: <87imczf2ar.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:j7gdZmVriVCoRzkpV1ZVzW40gQEwVz3lfhpiH+ujVjd13x3RNvY WK8kbIprF8t9NcQq87qtFYVpSZHiEMU+iNSALextmTyLmzwRnL/4BW+jJ/R3YsN9GBs7adu knpdkrOl/CJS5hDSa0IkkzkF/t7/3/zJ8mhGrKb2/ilXQM7jBe5uRfEj4EYimd5XINv+Xcp SLnuVc1YDpG0M9mXIiopQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:O1jZAMEaSUU=:HIwa3UivXsbvqXpLVEXHu3 8UWEBjKOSddDqrrwmOWhcAQfp0nwfpU5lqKbUFIuWp8RisiEOMr+icwkocxjGcpmOVsbAuR0E 8Cm/3aTz1scim2j78RG0sq59zTlk8qXzxxt/OSU3ULw+Epzrv+5sa2MEUwXsZ29xg8iX+/oix /qIhZ0nQUXR1vNFZf3a9zs1eiLd2SLttBgSg3eMa89g5EWdH4OL+xUunVl63yHfWuLkkDKKF7 mcdV6eEF5C5OcF4MlV+DRWNRALTW+EEXvVheD8qGvcZNabACpPTWGVyOfbS7Zr4xD3mN9Bplp zUOppWeMDqFnA4bxPYrAcdnEINbCWcpEY4gvqwU63dNc9lchzQgdGnQbFunLpfDfuU/oZb5ze kTo3TOVEHHErx5LrOHHp5uphGtLLGjKDXW96rlXXL7McST4sLrLwF75DNngUBiviDGMocKnsw ORyqFZqPTo2tfm8Cux8WwntUviItrxfiJNK62/N27s5akHKd8Ty2yux72JNMDQSZWZZ3Th9s1 d5GoDLQ7Uhk2qpeVajEEOlWPcjTafdFgkMuYkPwY9SaiWd1iA7htcjRqbrfdAPyeyuAklf1br X66Cgzg2XAOtkrL0+wdMS1SD4H6v3IqF7VFM7TpKxgjFtWZndxln00oKzkEnHflI88S3qL+e2 4k0EOc0JujSEeLqi1P729piu3VzqSemaeMzYWX+MnPjr8KkQs64/iSmUOFke8IFPX6nVEc6Ut YDPynpWsmYA3JZdleAD8cBEuA8FHhJd1PZP/j8GW3nN5/bZw/WRFt0SVOfyhBqbYpC7RCjXT0 ztsz/IUvLT6AfJ/84HMPWA3x+702yAN6n+pMEOuPAsDTxcSWty9QPNYLoYih0PJ+YrAOJGWxL 0LnOq+SMac1QLor9t2KuUVQAOIB3HteVEpaRhER9Z+1SqzYSVveHjtw7mf4sfMvIxb3eYTwou 0twimqhypwnnvqOdW8TJ3/pLJBJCmqQ9AYaHLdcmuHi0p4B3R6Ihdtc6GUVJ1r8lOxCpV3t7n qR7i9wT2ouuLxF7jSsHn7Qx2ETkBpNPrEhlOIZ8MtyhQCqGBdk4Zc4GwqZOuirNBcTR9TS6Ac oTCfpJptZiD9YPbiPeYnyX/l6lNImibMch65/5DKIe+mXwiemA8myRPxp/bha9oxjQXnRil2I VBXvSpAKystTmPrZwfhIEa0JIUhimnGf+ZX1bBVt5lMKbTLf3nZCxaRgcNIBZp6t1OIfxSBAW WoJ9xrGwIA7BQ9Zv+miF8y4ErPm45pxtVhuIzww== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, 31 Aug 2020 12:11:54 +0200 Robert Pluim wrote: >>>>>> On Mon, 31 Aug 2020 11:26:10 +0200, Stephen Berman > said: > > Stephen> On Sun, 30 Aug 2020 15:41:57 +0200 Lars Ingebrigtsen > Stephen> wrote: > >> Stephen Berman writes: > >> > >>> True, I wasn't thinking about that. Then I guess it's best to l= eave > >>> comint-password-prompt-regexp as is and I'll just change it loca= lly. > >>> The problem I have with it doesn't seem to be widespread, to say= the > >>> least. So feel free to close the bug. > >> > >> OK; done. > > Stephen> A postscript with additional datapoints: In my OP, the the = system that > Stephen> the problem occurs on (Linux From Scratch) uses openssh 8.2= p1, while the > Stephen> system without the problem (an older Linux From Scratch) us= es openssh > Stephen> 7.9p1. I've now reproduced the problem on two other GNU/Li= nux systems: > Stephen> current openSUSE Tumbleweed, which uses openssh 8.3p1 (and = I see the > Stephen> problem here on two different machines), and openSUSE Leap = 15.2, which > Stephen> uses openssh 8.1p1. This supports my conjecture that the p= roblematic > Stephen> carriage return in the prompt comes from openssh. If anyon= e else > Stephen> running a system with openssh 8.{1,2,3}p1 can reproduce the= problem, > Stephen> then perhaps a different way of handling it than changing t= he default > Stephen> value of comint-password-prompt-regexp can be found. > > That matches the analysis done in > > https://emacs.stackexchange.com/questions/60394/unable-to-push-into-gith= ub-using-magit > > which leads to: > > https://github.com/magit/magit/issues/3843 > > TL;DR magit decided to strip the \r from the prompt received from > openssh. Ah, thanks for the pointer. I'd done a web search before my first post about this but didn't find those pages. > We could strip control characters in comint-watch-for-password-prompt, > but then people who've legitimately put control characters in > comint-password-prompt-regexp will get annoyed. > > Perhaps just strip '\r'? (And document it, of course) > > diff --git a/lisp/comint.el b/lisp/comint.el > index be0e32b9e0..74c5c7f94f 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2427,7 +2427,8 @@ comint-watch-for-password-prompt > > This function could be in the list `comint-output-filter-functions'." > (when (let ((case-fold-search t)) > - (string-match comint-password-prompt-regexp string)) > + (string-match comint-password-prompt-regexp > + (replace-regexp-in-string "\r" "" string))) > (when (string-match "^[ \n\r\t\v\f\b\a]+" string) > (setq string (replace-match "" t t string))) > (let ((comint--prompt-recursion-depth (1+ comint--prompt-recursion-= depth))) That works for me. Thanks, Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 10:28:30 2020 Received: (at 43003) by debbugs.gnu.org; 1 Sep 2020 14:28:30 +0000 Received: from localhost ([127.0.0.1]:56669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7Gw-00035t-2o for submit@debbugs.gnu.org; Tue, 01 Sep 2020 10:28:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7Gu-00035f-17 for 43003@debbugs.gnu.org; Tue, 01 Sep 2020 10:28:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8uJTC09URiH8I2RH/6n00CIT0D7k5Zx6tiRTLVIKjOQ=; b=i0M8uCa4S5JDqMQEV61AKKhyjo prrUxIbQlYR8JE6m/QPSwnz1jym2paou79/EiFxuLu3RC4KUitdrKNILL3AsDjjsr0MaA3ml9wnJ2 pwi4ghpo6NrdLmCGvV1xhHIN4pKBvObSCHQXjAoOMPAX7ov7JeNIM/LzPKutIa6zkQjA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7Gk-0002Ts-GW; Tue, 01 Sep 2020 16:28:21 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> X-Now-Playing: DACM's =?utf-8?Q?=5FSt=C3=A9r=C3=A9otypie=5F=3A?= "LN Start" Date: Tue, 01 Sep 2020 16:28:17 +0200 In-Reply-To: (Robert Pluim's message of "Mon, 31 Aug 2020 12:11:54 +0200") Message-ID: <87k0xdd11a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > That matches the analysis done in > > https://emacs.stackexchange.com/questions/60394/unable-to-push-into-github-using-magit > > which leads to: > > https://github.com/magit/magit/issues/3843 Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > That matches the analysis done in > > https://emacs.stackexchange.com/questions/60394/unable-to-push-into-github-using-magit > > which leads to: > > https://github.com/magit/magit/issues/3843 Thanks for doing the detective work here. Summary: ---- After a bit of digging, the change does indeed come from OpenSSH: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/readpass.c.diff?r1=1.52&r2=1.53 Print an \r in front of the password prompt so parts of a password that was entered too early are likely clobbered by the prompt. ---- To which I can only say: "Ok...?" > TL;DR magit decided to strip the \r from the prompt received from > openssh. [...] > Perhaps just strip '\r'? (And document it, of course) [...] > - (string-match comint-password-prompt-regexp string)) > + (string-match comint-password-prompt-regexp > + (replace-regexp-in-string "\r" "" string))) Yes, that makes sense to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:03:49 2020 Received: (at control) by debbugs.gnu.org; 1 Sep 2020 15:03:49 +0000 Received: from localhost ([127.0.0.1]:56781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7p7-0006Id-5N for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:03:49 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:33767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7p5-0006IP-6z for control@debbugs.gnu.org; Tue, 01 Sep 2020 11:03:47 -0400 Received: by mail-wr1-f42.google.com with SMTP id m6so1942186wrn.0 for ; Tue, 01 Sep 2020 08:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=V6nHFE/R3z4JDbKptK8ZrXvyDOUiYZtIKETgWeOaBvY=; b=ohKERURIMf5SeOFe6kn9Xadm/PjyogNBuDoRwdaBMW2WGww8Up29qDjJUyq8AAzX2y FKAcSQPkijjdel2IaWjXlgLN6xG4kNJhrlyy7XxvhOxwnWchyvyCEsHXABwpMiuFgSRY Vzm/2A2BMAS9pfDhtVyTiyldg9pLNWBwRuCtXRaQ1qSoCgWTfk0yPvEt+Ir3L1zZBkM8 OzmFaMbyGwH1TBc9BsJQ2acqPHBcP+59ahBUKPWouG3I3MCIVWL1xcmqR18ghTOA6vJD cMFY85mfd5ghacPrEqY765MuTDLeBCT7ScB9msMgc3Qa4doZKd7O94COphnQ91zr7tNW i5eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=V6nHFE/R3z4JDbKptK8ZrXvyDOUiYZtIKETgWeOaBvY=; b=PntauHsr2l+KXBL5o2PyOWa5bbgjpPQhccHRFOeqAuuaqbt9RSEMZHqcfPDfkHAlcx 9vu3JNXJcLr2jTiQYLpXMrm6hof8xOBdhns+3zf7TrxQu+0FVFOx9WlWwXwgU3CTG/Yb jSnuHMgz7oi0GoScpEmXXRTlqBs6Lj7PLnGldwC7X+O0uHVNA0J8TDQhBZCHeMXEOwWE u91k9GdhPcREZAG6IYgpebw4iHatdbW6tO3WnTeolV9OgrZzCezmB1U6IhxtKOYtsnAO shyx0VR4hNl/CEm4lWM8Kzlemgbo1Ik2sd0TAqr+jTlouPTStGC4FU6kGmaPcqhQluOB qD9w== X-Gm-Message-State: AOAM530s+phwu2RKbpUEAvsZSDQpqBMNJq8+qbz4+5uZ88rf6DKsV2dX sns7xtZjdV7jmqgiuyopGXL/MFLqDV0= X-Google-Smtp-Source: ABdhPJwc7+OZCwKuvnuXyg5P+rX6ktq/vlQADb/EaNGPzwENp5ZSTXhoi1Fint/HK90hcRvUGB7i6Q== X-Received: by 2002:adf:a287:: with SMTP id s7mr2587761wra.103.1598972621166; Tue, 01 Sep 2020 08:03:41 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:2092:9c81:7555:7807]) by smtp.gmail.com with ESMTPSA id k22sm2716646wrd.29.2020.09.01.08.03.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 08:03:35 -0700 (PDT) From: Robert Pluim To: control@debbugs.gnu.org Subject: control message for bug #43003 Date: Tue, 01 Sep 2020 17:03:33 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) fixed 43003 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:03:20 2020 Received: (at 43003-done) by debbugs.gnu.org; 1 Sep 2020 15:03:20 +0000 Received: from localhost ([127.0.0.1]:56778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7od-0006Ho-RP for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:03:20 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7oa-0006HX-Qe for 43003-done@debbugs.gnu.org; Tue, 01 Sep 2020 11:03:17 -0400 Received: by mail-wm1-f42.google.com with SMTP id b79so1485556wmb.4 for <43003-done@debbugs.gnu.org>; Tue, 01 Sep 2020 08:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=1pRSyMPlij1I2ymIvdMe7JUas3z7n3tw6ebJBAVw+1g=; b=BMsHDMazSMuct675hxg5frs9hxwskrJux+7tkZ0R4PX4HztwvAkMAeAMSvoUY05bG8 +9XNoQMpGHXoLrcbcS1RenwUSI25n3JVSNSxVTBFHh4LKh9fiiXwdbQ7/SL0KtH5jZtG nUfA9hnZ4a7Wh0XZQih1riyd5RBN7P7yVQ5S+GLCin8CVqFi8TjnIRt8qMYluC/IgnwM /zr4OpE8Bk7HWnjww0K+25/1OgFpBBL6lP4/9vzjTsxUN3VsAFcauHar2E6X9pC2kzVK 1AR/QeEMVG24G+nCYYU6cGxy1S5ev0umD4A12aqRIweJ14kUGJhh4aHsRljP5FJcs8hO oF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=1pRSyMPlij1I2ymIvdMe7JUas3z7n3tw6ebJBAVw+1g=; b=FkQ1qTvoIXGVJSXWKAwAxS9sD1RK28M5imqf01MZGBMwIgJVej+NlT7if02gwX2KyK a7oc0FZzf5sFO+ndFPGLWPIpbfeY1+r55QxOkPjefsX3btX8WegWLOGvrxrdPHG3qeov vkGeAd4g14JtkRS/KBsil0VPOQlMIw4tze3zcQhVABXpwqi52+87SQf5F6EihjtAXy0Q xN6tAN41W0Xu/r/mOpA6v2zI93vVaYowVFyaJlAuJnfVChNc7JhEtsbHIuJeF1VRuIP9 4cCgkH1LzJq6kba7p4cL5Er21h4wa28cIT1FASeKJeJstnM/axtUEO89cclxw2G2pipN 5y1Q== X-Gm-Message-State: AOAM533oHak4GtnT/EsI6y4sA5a6eF09bQJ+SPohwdFETen50kGF/zGC 6OJuWYzCZttSoXgJD9HcaxF8sBzz6kA= X-Google-Smtp-Source: ABdhPJzq5GveNIGPPvR2ox1S1qJspp5g3N06I/J4r4ofwXjp+ICJaMecstWXzSKSfXl/s0XzDYGvmg== X-Received: by 2002:a1c:81c6:: with SMTP id c189mr2183145wmd.124.1598972588169; Tue, 01 Sep 2020 08:03:08 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:2092:9c81:7555:7807]) by smtp.gmail.com with ESMTPSA id c18sm2663233wrx.63.2020.09.01.08.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 08:03:05 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> <87k0xdd11a.fsf@gnus.org> Date: Tue, 01 Sep 2020 17:03:04 +0200 In-Reply-To: <87k0xdd11a.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Sep 2020 16:28:17 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003-done Cc: 43003-done@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 01 Sep 2020 16:28:17 +0200, Lars Ingebrigtsen said: Lars> [...] >> - (string-match comint-password-prompt-regexp string)) >> + (string-match comint-password-prompt-regexp >> + (replace-regexp-in-string "\r" "" string))) Lars> Yes, that makes sense to me. Done in 2e3ec40293 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:07:04 2020 Received: (at 43003-done) by debbugs.gnu.org; 1 Sep 2020 15:07:04 +0000 Received: from localhost ([127.0.0.1]:56791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7sF-0006O6-UF for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:07:04 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7sD-0006NV-L1 for 43003-done@debbugs.gnu.org; Tue, 01 Sep 2020 11:07:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qt8KGDceM2IKJywVr8C8B65/Oeh0ynxtakQNSQ++6yY=; b=h0+TpeY0Od8z+JUeTsbgFStDlb lPggRAaez1Sk3Mbs3VptcO2l5KoL8cEj/Ci3plWUAG939qTaS2uyhYk9lPGKtbRLchZJ1TD6LZcwP Yi0ZbOw1s5GQhGS691gywHD1LycW2OcFzqFuNdgiRzvgdEvlOY5TRnnfyc6vGl2wPimQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7s3-0002ku-Nj; Tue, 01 Sep 2020 17:06:55 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> <87k0xdd11a.fsf@gnus.org> X-Now-Playing: DACM's =?utf-8?Q?=5FSt=C3=A9r=C3=A9otypie=5F=3A?= "Latex" Date: Tue, 01 Sep 2020 17:06:50 +0200 In-Reply-To: (Robert Pluim's message of "Tue, 01 Sep 2020 17:03:04 +0200") Message-ID: <875z8xcz91.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > >> - (string-match comint-password-prompt-regexp string)) > >> + (string-match comint-password-prompt-regexp > >> + (replace-regexp-in-string "\r" "" string))) > > Lars> Yes, that makes sense to me. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003-done Cc: 43003-done@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > >> - (string-match comint-password-prompt-regexp string)) > >> + (string-match comint-password-prompt-regexp > >> + (replace-regexp-in-string "\r" "" string))) > > Lars> Yes, that makes sense to me. > > Done in 2e3ec40293 One thought -- just as a precaution, would it make sense to do this replacement only if the \r is at the start of a line, and it's not followed by a \n? I'm just slightly worried that there may be repercussions on systems that use \r\n as end-of-line markers... it probably makes no difference here, but... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:40:28 2020 Received: (at 43003) by debbugs.gnu.org; 1 Sep 2020 15:40:28 +0000 Received: from localhost ([127.0.0.1]:56839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8Oa-0000xb-KQ for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:40:28 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:34496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8OY-0000xO-SE for 43003@debbugs.gnu.org; Tue, 01 Sep 2020 11:40:27 -0400 Received: by mail-wm1-f48.google.com with SMTP id c19so1224268wmd.1 for <43003@debbugs.gnu.org>; Tue, 01 Sep 2020 08:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=m1Lc5zDR2G+aoCFP0NbTmQoOWodj/h/TyxJiuthHhCM=; b=DbvDJIBc6ufxY47MlER2smIgbFqOIFtchocE9tuhWXM9KlDtriLcosbbdEJyRO83nd wMTS4s9rY3drMM2UwOhHRZRb2w1Y5bzEWpzMgT0BGU37VWNjX+e4e8CeN75BnVRPSw8d zO0bKJ/6fHUiHakK28J20k+kqj0yzlY4ocmtbPyaziv/EuRFT+SQ4HTM+rjmZPItMUxk Tc27qriAALDTm8LKAkgfbPWKAAmYodTJsZL8tIDTamjIe+8KG00FSDrwUmcvXDwhGe2p oq6QAA0QdGKnuqU+O2Hjmma19RlojXS/6Zpy5hnmM8/I16U8Jmghe4pW3KhOdZBzi2ET r9mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=m1Lc5zDR2G+aoCFP0NbTmQoOWodj/h/TyxJiuthHhCM=; b=Q82mPvSL4s7KfpzocHiDMRPK1K+nk3aAa0agf+64pFkCG57OtcWA5k8uY8fgRnQ20+ T3N7GKr9etaSFKvOGmWOV5SeZnHqtnrGJVRuzwXMtCjzJvGgiXn90fK206N4MfGogHeV aatKUva6CIfjnzakNLDuvV5dieGYDbgTVYc0cN3Bk/fd+LQcBO7WLTCjc7vdm6dPmG0v VBMwOnTyN07bJcsguy6de7KJz8j3VgD4trWsLcBdozTlGarwgi6RI+tlxTJuZCbzLWEc ZzBevIGKNYfZhlND/wEkZUqopD7slLdjquSC8qSg6RBNtHiuUpUEg6BF9FAOFATNEqeV Iygg== X-Gm-Message-State: AOAM533NHhzS2nT0RNG00DpSHA1dVj132UUivmu7XKnO6OPJWJK6ZXDM vYFxFVQwAr3q9N8NuieFHxQ5RDH/T5XrDw== X-Google-Smtp-Source: ABdhPJwEG7KwalL6GpzJEjEdPlftKlv5s00r7Ay3ZZL71WNKDg/gmLjr/UhR7snXX7FBqaqQS/KTJQ== X-Received: by 2002:a05:600c:20f:: with SMTP id 15mr2185134wmi.99.1598974820548; Tue, 01 Sep 2020 08:40:20 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:2092:9c81:7555:7807]) by smtp.gmail.com with ESMTPSA id v4sm2162100wml.46.2020.09.01.08.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 08:40:19 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> <87k0xdd11a.fsf@gnus.org> <875z8xcz91.fsf@gnus.org> Date: Tue, 01 Sep 2020 17:40:19 +0200 In-Reply-To: <875z8xcz91.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Sep 2020 17:06:50 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 01 Sep 2020 17:06:50 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> >> - (string-match comint-password-prompt-regexp string)) >> >> + (string-match comint-password-prompt-regexp >> >> + (replace-regexp-in-string "\r" "" string= ))) >>=20 Lars> Yes, that makes sense to me. >>=20 >> Done in 2e3ec40293 Lars> One thought -- just as a precaution, would it make sense to do th= is Lars> replacement only if the \r is at the start of a line, and it's not Lars> followed by a \n? I'm just slightly worried that there may be Lars> repercussions on systems that use \r\n as end-of-line markers... = it Lars> probably makes no difference here, but... I=CA=BCm finding it hard to come up with a case where stripping the \r fails (famous last words). Robert From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 12:46:41 2020 Received: (at 43003) by debbugs.gnu.org; 1 Sep 2020 16:46:41 +0000 Received: from localhost ([127.0.0.1]:57016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD9Qe-000437-Ty for submit@debbugs.gnu.org; Tue, 01 Sep 2020 12:46:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD9Qa-0003v3-0d for 43003@debbugs.gnu.org; Tue, 01 Sep 2020 12:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SlcMB1E+pgvWz6EmCIAdegpW68FoCC9dlDFbeFHPqyY=; b=m4zk1QMJ/c6wS3pGhQqAdRpcie oJrR+JRQ3XXBmqFK3ZH1yS59JVuThVVEdOpnDCRtl0t8VDtj8LRudNSj4U+J3Gs7fmIdNEibiLh8o HjrsBPZUqlxdebJFv7PoYR4Zo+1jkRHHpoWe2FYJvjbbyz4AE1fpCV0URSZnTnk1QZAA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD9QQ-0003U5-FE; Tue, 01 Sep 2020 18:46:29 +0200 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> <87k0xdd11a.fsf@gnus.org> <875z8xcz91.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUjHyEhHB1VUVO6 sZ3///8XRmjUAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QJARAtHNygU/AAAAG8SURBVDjLdVPbkcQw CAOuAfA1YJMGdpL+ezsJO4n34zyzsw6yeAgQWUcjXPYTEdPunop/508L4UPHe7+6h/WbkUFWxysY w2m3TAIuatnTwhlm4DMXoI5bjuDxYR0AeSmd9j5T8o7L7arscHDldcp4AZrxpRcup9Q1ciZmOSSK cQGIxWAqjKwHEDBwtUeLNlb90kZXtarGCyg8eOuu2bK0gkx3HdL6gAJOwKWeTkI0ZKULWDXP44IY Ygwfdr52SD2yWsAYx3QvTq8+joGklEA7v3wdAwUWEAcjZ2kDpIBqYK/wF8/HoUCfDIme5wNsDIM8 9LUAdH0BqANd2xilrrJnOdpnAyhGMQar2rJij4uxK8JCIOKMsQDxOZbxAPoqpY7YuqZx97IaYGMB lFJ1k+uZdr8dekmv/q6BvjmJqHwBWApMsaquNYAbmzOkOaAPLTXIzeaw+ANIKSItLWu9GqRr19AC nEByRdS99oUiVYAFIDYvmA/xxsGOAqrehn2rlH4+D2MOYTEg+++ocibAhbX5AvNLB0zXIn5Oito4 g8G5Ywwp4FpAycWlX7Jb3gwtjcLvfux9qaX4NmznX+APxEFJima8pW0AAAAldEVYdGRhdGU6Y3Jl YXRlADIwMjAtMDktMDFUMTY6NDU6MjgrMDA6MDBmZ6XJAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIw LTA5LTAxVDE2OjQ1OjI4KzAwOjAwFzoddQAAAABJRU5ErkJggg== X-Now-Playing: Various's _The Wire Tapper 53_: "Chouk Bwa - RARA" Date: Tue, 01 Sep 2020 18:46:24 +0200 In-Reply-To: (Robert Pluim's message of "Tue, 01 Sep 2020 17:40:19 +0200") Message-ID: <871rjlcun3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Iʼm finding it hard to come up with a case where stripping the \r > fails (famous last words). Yeah, it's pretty unlikely. Perhaps if somebody has customised comint-password-prompt-regexp to be "Password:\r\n", and then it'd no longer match... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > I=CA=BCm finding it hard to come up with a case where stripping the \r > fails (famous last words). Yeah, it's pretty unlikely. Perhaps if somebody has customised comint-password-prompt-regexp to be "Password:\r\n", and then it'd no longer match... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 13:45:11 2020 Received: (at 43003) by debbugs.gnu.org; 1 Sep 2020 17:45:11 +0000 Received: from localhost ([127.0.0.1]:57178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDALH-0006TW-2T for submit@debbugs.gnu.org; Tue, 01 Sep 2020 13:45:11 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:42911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDALC-0006JL-UZ for 43003@debbugs.gnu.org; Tue, 01 Sep 2020 13:45:10 -0400 Received: by mail-wr1-f51.google.com with SMTP id c18so2476207wrm.9 for <43003@debbugs.gnu.org>; Tue, 01 Sep 2020 10:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=hhDMqClFpK2dqs7PcGffE4jJfNi6/ZV7LdBLtS+G0TI=; b=Su1mnsx3WE2e3+hjEXzVd0oQtIicje46qLiHnnqadhghZtJt5wfX90RAfkJVpLI9kK xNlA+5yNkjxvYTL+SZaDxaggAmQcAGcB7XVmHjKDqIQuL9oGEApdrAhH3WkQBkb6uMMO 4wUsC6etbAgd1euPQ6VlHFkvZAOx6bAGSA8SGmJBzGztqEOZyP8NN2QrOASo4XWOfjaq GflNnVmrBjQRihPowaoN84+cDEa5/lj0Xr2fnXb0ZZJuanozK6Jw+RLjVgVTVXm3h6hB DG8SMljjvPMYYpoOEUl/hYiqzyRkEdPc0Wz3Ia6wVDXeHYakcJyzRdq7Tx6kfMgwcfDJ Cx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=hhDMqClFpK2dqs7PcGffE4jJfNi6/ZV7LdBLtS+G0TI=; b=I2w3O5LL1MdFQB/5J2MqaorveypZ7xv4pjQjuISLz/ueaX49rOpgQcrSb4sptbgYn4 bpffnB1z1kdSTJYc2wOyzMNJm/p86z4lsAKLi5X/LiF7Fv/Gt3Lu40ds9FzWZBQawDdH CJimOaAccWISMcwSDXMXZBReOFQNLrSGdSQQRz43g1ogxr7py23BMPydnY02vsCr9rvB e1Frgew+24oFGZpPyXdzNP4/vtq0pj2ZDmYx6yWAJ3B35t5zgAWi52MItP6/WHZdvsEj R7ggGRD1+ejAiABMnn+s3ef7ij9SwN7qETCObpPYHHOpUVE7ey63s9VTTNDqR22byYCh +lYw== X-Gm-Message-State: AOAM532Hnjnj3+VrikH9ja9iCxL7c24JmukNE7kIfNu3tLOUa267Xm9z rttQNk9+g+eC80fsfV/nBgY= X-Google-Smtp-Source: ABdhPJzB4ipTvgFEMjuh0F1405vpu8gGuvRFLaPs7K/8LUAjtupSOIg00GA0tZUmbZCgnMX88df+yg== X-Received: by 2002:adf:cf01:: with SMTP id o1mr3102395wrj.421.1598982300868; Tue, 01 Sep 2020 10:45:00 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:2092:9c81:7555:7807]) by smtp.gmail.com with ESMTPSA id v2sm3186141wrn.44.2020.09.01.10.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 10:44:59 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> <87k0xdd11a.fsf@gnus.org> <875z8xcz91.fsf@gnus.org> <871rjlcun3.fsf@gnus.org> Date: Tue, 01 Sep 2020 19:44:58 +0200 In-Reply-To: <871rjlcun3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Sep 2020 18:46:24 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43003 Cc: 43003@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 01 Sep 2020 18:46:24 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> I=CA=BCm finding it hard to come up with a case where stripping the = \r >> fails (famous last words). Lars> Yeah, it's pretty unlikely. Perhaps if somebody has customised Lars> comint-password-prompt-regexp to be "Password:\r\n", and then it'= d no Lars> longer match... I=CA=BCm not aware of any tools that emit \r and/or \n *after* the password prompt, so I think that=CA=BCs unlikely. Robert From unknown Thu Sep 11 11:26:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 30 Sep 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator