From unknown Thu Sep 11 16:06:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43001: 27.1; bad fontification of Common Lisp uninterned symbols Resent-From: Robert Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2020 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 43001@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159821332232166 (code B ref -1); Sun, 23 Aug 2020 20:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 20:08:42 +0000 Received: from localhost ([127.0.0.1]:55175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9wIE-0008Mk-6e for submit@debbugs.gnu.org; Sun, 23 Aug 2020 16:08:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:57392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9wIC-0008Mc-L5 for submit@debbugs.gnu.org; Sun, 23 Aug 2020 16:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9wIC-0007SL-Gg for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 16:08:40 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:34787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9wIA-0008BY-Gm for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 16:08:40 -0400 Received: by mail-ej1-x634.google.com with SMTP id o23so9301390ejr.1 for ; Sun, 23 Aug 2020 13:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=YlfH3UochkAL8oUXp9MrNiufAvwYXuXNJpmhqIOaCcE=; b=o8GTGVKdD6PPUVWSplC6Camw6b/89sl9CddL8TU1tug1Whe8RCVCpwhG+5cNSc9CnP Cy8uwjT0W/IDC42PGOB+a1SLMT8EQEzhMlohdqTpnaE/8kkoHvqpBKpKer53ahTdJaqA RuReJOAtlYLlbYs7wdS9JfB4ddcOHsdhakJU8cKeH+YLxc0xpSSZNU1vapdZxLGhO4xn twJwC4DZjlpmlR3PKK0pdKAdbRaqdfQzTx6BFNSlrWfKZin8lY9CnXp1Bri8WIg/HHvT y0AjoRYF3sKS1ULQ0+L0jghwry1lF79vh5e/Bk1ajkPY63xEt4hySLaAXF37TNfGK0wL V+fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YlfH3UochkAL8oUXp9MrNiufAvwYXuXNJpmhqIOaCcE=; b=JIuQqtnf6NoiXj0SZ4g4u06QcTksnxrR2rVl2rUKlCd1g2xtB/ndhojvvgykwUcmCa 9ssusvQnv9ayHLe0c18RYOvjjEj/w+mOS7k/fzZp1SZCEFZzkB13gx43Bz+kaljsiFYY WydP6VT//UZzcqJiPdysdneJfQCUQDu4LUC5ZCTpuMVAk3TVfEx4vFSUswZC+4j5/tg3 kovhdTWg/dNs3rgJyhU23OoClbF7aPDp/EHnEL0kXDOfPOTEviYAN2StCGLp1Go0Y6N6 D1SQd/5Lg7LI2AYNeyE1Mao7sx0KQZxHf+JX++5qcVGs8MnHeqF1sl9SAeej/BW7Crnq xRLg== X-Gm-Message-State: AOAM530ijHusPu5cXIYhYejlX1iv4nuJ1V2EHcpY7Qaj78xYydexurit CzteuuX0h7teDH8Bz66ozYo4prbIO/cg/J2zoHjOn/XmN64= X-Google-Smtp-Source: ABdhPJzfgqR3qCSLRJ8ERx8poy6L8EcksAqVyoOS0AuCfvc+X1kH7bANVBdbIisJYQSmfSKinSg13ET4Y+kvFbUiW/c= X-Received: by 2002:a17:906:fcb3:: with SMTP id qw19mr2695134ejb.271.1598213316099; Sun, 23 Aug 2020 13:08:36 -0700 (PDT) MIME-Version: 1.0 From: Robert Brown Date: Sun, 23 Aug 2020 16:08:25 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=robert.brown@gmail.com; helo=mail-ej1-x634.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Git commit bae7a63b808 introduced fontification of Common Lisp uninterned symbols using this code: ;; Uninterned symbols, e.g., (defpackage #:my-package ...) ;; must come before keywords below to have effect (,(concat "\\(#:\\)\\(" lisp-mode-symbol-regexp "\\)") (1 font-lock-comment-delimiter-face) (2 font-lock-doc-face)) An uninterned symbol looks like "#:my-symbol". The change causes "#:" to be displayed with one face and "my-symbol" with another. That's bad. Fontification signals a semantic property The entire thing is a symbol, so it should be displayed using one face. What face should we use? Keyword symbols are displayed using font-lock-builtin-face, so that's what I would use. Why I'm commenting on Lisp fontification ... Symbols that start with an ampersand character are currently being displayed using font-lock-type-face, which doesn't make much sense, since they too are symbols. Perhaps they should be displayed using font-lock-builtin-face too. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu) of 2020-08-16 built on chuwi System Description: Ubuntu 18.04.5 LTS Recent messages: Configured using: 'configure --without-x --prefix=/home/brown/local/software/package/emacs-27.1' Configured features: SOUND NOTIFY INOTIFY GNUTLS ZLIB XIM MODULES THREADS JSON PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: show-paren-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Load-path shadows: /home/brown/local/software/source/dash/dash-functional hides /home/brown/.emacs.d/elpa/dash-functional-20191109.1327/dash-functional /home/brown/local/software/source/dash/dash hides /home/brown/.emacs.d/elpa/dash-20191109.1327/dash /home/brown/local/software/source/markdown-mode/markdown-mode hides /home/brown/.emacs.d/elpa/markdown-mode-20190802.2215/markdown-mode Features: (shadow sort mail-extr warnings emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm vm-autoloads vm-version vm-vars cc-styles cc-align cc-engine cc-vars cc-defs slime-autoloads regexp-opt edmacro kmacro paren finder-inf info tool-bar package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify multi-tty make-network-process emacs) Memory information: ((conses 16 102351 27442) (symbols 48 11628 5) (strings 32 32543 5246) (string-bytes 1 1146866) (vectors 16 12405) (vector-slots 8 142487 34066) (floats 8 32 537) (intervals 56 184 0) (buffers 1000 12)) From unknown Thu Sep 11 16:06:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43001: 27.1; bad fontification of Common Lisp uninterned symbols Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Brown Cc: 43001@debbugs.gnu.org Received: via spool by 43001-submit@debbugs.gnu.org id=B43001.159827256515460 (code B ref 43001); Mon, 24 Aug 2020 12:37:02 +0000 Received: (at 43001) by debbugs.gnu.org; 24 Aug 2020 12:36:05 +0000 Received: from localhost ([127.0.0.1]:56459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kABhk-00041I-Uc for submit@debbugs.gnu.org; Mon, 24 Aug 2020 08:36:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kABhi-00040j-CW for 43001@debbugs.gnu.org; Mon, 24 Aug 2020 08:36:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gBGHJfCWQb8XNZ9eWXQZVk7SsSpvMZVGLXrS7BODyZU=; b=NJdNSR4vO8wNc/gugK2fCXAW2n EWUQOujn6tLFdVxRpndERs3Go6IoC2CwTLTZVY6/2mPu09d5CUJtGu8oJEL48ayosUJMfJR6TSIsp mJ1GUkREbXw1/U6GsrtEExImzmipLUi+sK3T4UI9lB0m84vmDxM7L7xgoaiqeQyCYgso=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kABhY-00063a-VT; Mon, 24 Aug 2020 14:35:55 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Kokoko!'s _Fongola_: "Buka Dansa" Date: Mon, 24 Aug 2020 14:35:51 +0200 In-Reply-To: (Robert Brown's message of "Sun, 23 Aug 2020 16:08:25 -0400") Message-ID: <874kosdxw8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Brown writes: > An uninterned symbol looks like "#:my-symbol". The change causes "#:" > to be displayed with one face and "my-symbol" with another. That's bad. > Fontification signals a semantic property The entire [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Brown writes: > An uninterned symbol looks like "#:my-symbol". The change causes "#:" > to be displayed with one face and "my-symbol" with another. That's bad. > Fontification signals a semantic property The entire thing is a symbol, > so it should be displayed using one face. What face should we use? > Keyword symbols are displayed using font-lock-builtin-face, so that's > what I would use. Makes sense; I've now made this change in Emacs 28. > Why I'm commenting on Lisp fontification ... Symbols that start with an > ampersand character are currently being displayed using > font-lock-type-face, which doesn't make much sense, since they too are > symbols. Perhaps they should be displayed using font-lock-builtin-face > too. I think it's fine to use that face in Lisp mode (since it's largely unused in Lisp mode otherwise). The face names aren't very descriptive, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 08:36:10 2020 Received: (at control) by debbugs.gnu.org; 24 Aug 2020 12:36:10 +0000 Received: from localhost ([127.0.0.1]:56462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kABhq-00041Y-5H for submit@debbugs.gnu.org; Mon, 24 Aug 2020 08:36:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kABhn-000419-Va for control@debbugs.gnu.org; Mon, 24 Aug 2020 08:36:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ldFx5aMVQV0ols2t35mleN/dowLqJtxNa1RCUb0yhhc=; b=EU5puuqmzCbdS6zZ5t2gzQlSyT aZvZj7g9hx2FuuC0u/PpeiCdMimMzukjACRbBeGE2dClPrKAFSbd7lf91Krr2F7JD83BbUoBAXpQ+ jczbrzSPfYn+tj2WGj+NRdztCzkwNzO8RzXcZG9JdLT/SYVmU7omM0Ti3R89tOLUNsOQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kABhg-00063l-7I for control@debbugs.gnu.org; Mon, 24 Aug 2020 14:36:02 +0200 Date: Mon, 24 Aug 2020 14:35:58 +0200 Message-Id: <87364cdxw1.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43001 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43001 fixed close 43001 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43001 fixed close 43001 28.1 quit