From unknown Wed Jun 18 23:15:02 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4300: 23.1.50; bad function name: browse-url-default-browser Reply-To: Leo , 4300@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 31 Aug 2009 17:20:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4300 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125173883813750 (code B ref -1); Mon, 31 Aug 2009 17:20:06 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 31 Aug 2009 17:13:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7VHDuH1013746 for ; Mon, 31 Aug 2009 10:13:58 -0700 Received: from mail.gnu.org ([199.232.76.166]:48611 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MiAS4-0007Ri-3O for emacs-pretest-bug@gnu.org; Mon, 31 Aug 2009 13:13:56 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MiAS2-00077p-Ad for emacs-pretest-bug@gnu.org; Mon, 31 Aug 2009 13:13:55 -0400 Received: from mx20.gnu.org ([199.232.41.8]:27774) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MiAS2-00077Y-0d for emacs-pretest-bug@gnu.org; Mon, 31 Aug 2009 13:13:54 -0400 Received: from ppsw-6.csi.cam.ac.uk ([131.111.8.136]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MiAS0-000135-D0 for emacs-pretest-bug@gnu.org; Mon, 31 Aug 2009 13:13:52 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:49898 helo=victoria.local) by ppsw-6.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MiARy-00056u-Jy (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Mon, 31 Aug 2009 18:13:50 +0100 From: Leo To: emacs-pretest-bug@gnu.org Date: Mon, 31 Aug 2009 18:13:42 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please describe exactly what actions triggered the bug and the precise symptoms of the bug: ,----[ C-h f browse-url-default-browser RET ] | browse-url-default-browser is a compiled Lisp function in | `browse-url.el'. | | (browse-url-default-browser url &rest args) | | Find a suitable browser and ask it to load url. | Default to the url around or before point. | | When called interactively, if variable `browse-url-new-window-flag' is | non-nil, load the document in a new window, if possible, otherwise use | a random existing one. A non-nil interactive prefix argument reverses | the effect of `browse-url-new-window-flag'. | | When called non-interactively, optional second argument NEW-WINDOW is | used instead of `browse-url-new-window-flag'. | | The order attempted is gnome-moz-remote, Mozilla, Firefox, | Galeon, Konqueror, Netscape, Mosaic, Lynx in an xterm, and then W3. | | [back] `---- The only thing that is related to 'default' is it uses url around point by default. But the name is misleading, for example, emacs-w3m uses it to open a default external browser, but it will open bizarre browsers on OS X or Windows. I wonder if the function name can be improved, for example, browse-url-try-browsers. Thanks. Leo From lekktu@gmail.com Thu Oct 22 02:35:31 2009 Received: (at control) by emacsbugs.donarmstrong.com; 22 Oct 2009 09:35:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f213.google.com (mail-fx0-f213.google.com [209.85.220.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9M9ZTNW004084 for ; Thu, 22 Oct 2009 02:35:31 -0700 Received: by fxm9 with SMTP id 9so9696363fxm.1 for ; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=8EmqKmTQZFxRHmBqMf0mAHPBq3MFliknc0lztWoJq6Y=; b=HxQYupT4FFltZz1ItMJj0h3XTFYNK5e7ryT0Cek2T3YESYQLNQM8G9V9i2CKiMAEbc EvYuLj8f7w1qApk14qvzihjcYCGQUOU+1DBevO5UhGKLQhzQ6+vBiuihHNGFYaXeeEYe kJYg0CmwEGM5xp9e/Qz4pt4br7Ml4TcpNJkWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Y5ybjjcxlLdLgAFAm7oQwPF4q6enZ/vhDgoBesbKLPsYfKZBy2gNxuVUArd1lZsA9C Mqc9bcUQhekOxrkhuBrM/oRLNjZDm8m0DPtCnEMhvvK6rKfs9H9j6QMJR6VObUwlfUeo 7VB35jQ8OYFrwvpcsbgPdQA8bmjmcb1XFRU14= MIME-Version: 1.0 Received: by 10.239.145.8 with SMTP id q8mr761204hba.122.1256204124158; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) From: Juanma Barranquero Date: Thu, 22 Oct 2009 11:35:04 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 reassign 4326 emacs,ns merge 4261 4434 merge 1589 3359 4207 merge 3829 4077 tags 4781 + patch tags 4747 + patch tags 4579 + patch tags 4471 + patch tags 4434 + patch tags 4234 + patch tags 4221 + patch tags 4147 + patch tags 4144 + patch tags 4139 + patch tags 4023 + patch tags 4736 + moreinfo unreproducible tags 4547 + notabug tags 4451 + notabug tags 4448 + moreinfo tags 4427 + moreinfo tags 4373 + notabug tags 4360 + notabug tags 4271 + moreinfo tags 4236 + moreinfo tags 4143 + moreinfo unreproducible tags 4120 + moreinfo unreproducible tags 4070 + moreinfo unreproducible severity 4422 wishlist severity 4396 minor severity 4394 minor severity 4341 wishlist severity 4300 minor severity 4263 minor severity 4178 minor severity 4172 wishlist severity 4110 wishlist severity 4056 wishlist close 4772 close 4700 close 4599 close 4515 close 4463 close 4445 close 4395 close 4334 close 4289 close 4219 quit From unknown Wed Jun 18 23:15:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4300: 23.1.50; bad function name: browse-url-default-browser Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2011 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: 4300@debbugs.gnu.org Received: via spool by 4300-submit@debbugs.gnu.org id=B4300.131050665818655 (code B ref 4300); Tue, 12 Jul 2011 21:38:01 +0000 Received: (at 4300) by debbugs.gnu.org; 12 Jul 2011 21:37:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgke6-0004qn-P0 for submit@debbugs.gnu.org; Tue, 12 Jul 2011 17:37:38 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgke1-0004qO-S8 for 4300@debbugs.gnu.org; Tue, 12 Jul 2011 17:37:34 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qgkdq-0006Ks-Gt; Tue, 12 Jul 2011 23:37:18 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Leo's message of "Mon, 31 Aug 2009 18:13:42 +0100") Date: Tue, 12 Jul 2011 23:37:09 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Peter Gabriel's _Plays Live (1)_: "I Go Swimming" X-Hashcash: 1:23:110712:4300@debbugs.gnu.org::dRxuYJAEckU1Z5RO:00000000000000000000000000000000000000000Kvhl X-Hashcash: 1:23:110712:sdl.web@gmail.com::uRPFcnf95gTGYQTM:00000000000000000000000000000000000000000000PNue MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qgkdq-0006Ks-Gt X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311111438.84579@m9mTaMUmCJxjm5V0KDFmzw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Leo writes: > ,----[ C-h f browse-url-default-browser RET ] > | browse-url-default-browser is a compiled Lisp function in > | `browse-url.el'. [...] > The only thing that is related to 'default' is it uses url around point > by default. But the name is misleading, for example, emacs-w3m uses it > to open a default external browser, but it will open bizarre browsers on > OS X or Windows. > > I wonder if the function name can be improved, for example, > browse-url-try-browsers. I think the function name is clear enough, and renaming it would introduce churn for little extra gain, so I'm closing this report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 17:37:27 2011 Received: (at control) by debbugs.gnu.org; 12 Jul 2011 21:37:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgkdz-0004qW-H5 for submit@debbugs.gnu.org; Tue, 12 Jul 2011 17:37:27 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgkdy-0004qJ-68 for control@debbugs.gnu.org; Tue, 12 Jul 2011 17:37:27 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qgkdm-0006Ki-Is for control@debbugs.gnu.org; Tue, 12 Jul 2011 23:37:14 +0200 Date: Tue, 12 Jul 2011 23:37:13 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #4300 X-MailScanner-ID: 1Qgkdm-0006Ki-Is X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311111434.88928@PkPkk10+Ssh6hz8SwTYwVQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 4300 notabug close 4300 From unknown Wed Jun 18 23:15:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4300: 23.1.50; bad function name: browse-url-default-browser Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug To: Lars Magne Ingebrigtsen Cc: 4300@debbugs.gnu.org Received: via spool by 4300-submit@debbugs.gnu.org id=B4300.131052221322014 (code B ref 4300); Wed, 13 Jul 2011 01:57:02 +0000 Received: (at 4300) by debbugs.gnu.org; 13 Jul 2011 01:56:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgoh2-0005j1-7B for submit@debbugs.gnu.org; Tue, 12 Jul 2011 21:56:52 -0400 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgoh0-0005ip-I0 for 4300@debbugs.gnu.org; Tue, 12 Jul 2011 21:56:51 -0400 Received: by iye7 with SMTP id 7so5185305iye.3 for <4300@debbugs.gnu.org>; Tue, 12 Jul 2011 18:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=BZIqCwiCS4jFliBTf6EYt7P7xEDa/Nx056K9ysBe5OU=; b=a0BC8GcTci36IV2012CDEWxAC/6fk8nYSdZXZpjLqgCNx6uXtzOgT4d2OusnTrSCsJ sZ9XcdtzgTKe7zn69p/nwI6xzda4QsrE4oRRUjD59jztwW1GKWqjU/SCbv2VC1j2iquO ExzaYYPRySLuEY56vd2xTxSi3StNZw/5FJ1D0= Received: by 10.42.161.73 with SMTP id s9mr558393icx.523.1310522204692; Tue, 12 Jul 2011 18:56:44 -0700 (PDT) Received: from localhost ([114.247.10.78]) by mx.google.com with ESMTPS id a9sm12869321icy.6.2011.07.12.18.56.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Jul 2011 18:56:44 -0700 (PDT) From: Leo References: Date: Wed, 13 Jul 2011 09:56:28 +0800 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 12 Jul 2011 23:37:09 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) On 2011-07-13 05:37 +0800, Lars Magne Ingebrigtsen wrote: > I think the function name is clear enough, and renaming it would > introduce churn for little extra gain, so I'm closing this report. Lars, The function name is misleading in that it does not find the default browser on the OS to open url. For example, on OSX, it opens up an xterm, which is ridiculous to most OSX users. Changing a function name to better introduces no churn and helps 3rd party developers improve their code. Cheers, Leo From unknown Wed Jun 18 23:15:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4300: 23.1.50; bad function name: browse-url-default-browser In-Reply-To: Resent-From: Lawrence Mitchell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug To: 4300@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.131054479829249 (code B ref -1); Wed, 13 Jul 2011 08:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jul 2011 08:13:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QguZJ-0007bi-GV for submit@debbugs.gnu.org; Wed, 13 Jul 2011 04:13:17 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QguZG-0007bV-1r for submit@debbugs.gnu.org; Wed, 13 Jul 2011 04:13:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QguZ6-0006Bc-V5 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 04:13:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:56850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguZ6-0006BV-Lq for submit@debbugs.gnu.org; Wed, 13 Jul 2011 04:13:04 -0400 Received: from eggs.gnu.org ([140.186.70.92]:54476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguZ2-0006mY-FR for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 04:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QguYy-00069Z-1X for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 04:13:00 -0400 Received: from lo.gmane.org ([80.91.229.12]:33252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QguYx-00069T-GX for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 04:12:55 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QguYs-0004iD-3D for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 10:12:50 +0200 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2011 10:12:50 +0200 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2011 10:12:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Lawrence Mitchell Date: Wed, 13 Jul 2011 09:12:38 +0100 Lines: 59 Message-ID: <87bowyiop5.fsf@gmx.li> References: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: e4300lm.epcc.ed.ac.uk User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:WWy9hYq/+eiFX2DGDsJNnWM3yWs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Leo wrote: > On 2011-07-13 05:37 +0800, Lars Magne Ingebrigtsen wrote: >> I think the function name is clear enough, and renaming it would >> introduce churn for little extra gain, so I'm closing this report. > Lars, > The function name is misleading in that it does not find the default > browser on the OS to open url. For example, on OSX, it opens up an > xterm, which is ridiculous to most OSX users. > Changing a function name to better introduces no churn and helps 3rd > party developers improve their code. How about this patch, which doesn't change the name, but does stop it from lying. It also removes the (unnecessary, and indeed incorrect) implementation description from browse-url-default-browser. diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el index ac12030..e18b42a 100644 --- a/lisp/net/browse-url.el +++ b/lisp/net/browse-url.el @@ -214,13 +214,7 @@ ;;;###autoload (defcustom browse-url-browser-function - (cond - ((memq system-type '(windows-nt ms-dos cygwin)) - 'browse-url-default-windows-browser) - ((memq system-type '(darwin)) - 'browse-url-default-macosx-browser) - (t - 'browse-url-default-browser)) + 'browse-url-default-browser "Function to display the current buffer in a WWW browser. This is used by the `browse-url-at-point', `browse-url-at-mouse', and `browse-url-of-file' commands. @@ -908,12 +902,13 @@ a random existing one. A non-nil interactive prefix argument reverses the effect of `browse-url-new-window-flag'. When called non-interactively, optional second argument NEW-WINDOW is -used instead of `browse-url-new-window-flag'. - -The order attempted is gnome-moz-remote, Mozilla, Firefox, -Galeon, Konqueror, Netscape, Mosaic, Lynx in an xterm, and then W3." +used instead of `browse-url-new-window-flag'." (apply (cond + ((memq system-type '(windows-nt ms-dos cygwin)) + 'browse-url-default-windows-browser) + ((memq system-type '(darwin)) + 'browse-url-default-macosx-browser) ((browse-url-can-use-xdg-open) 'browse-url-xdg-open) ((executable-find browse-url-gnome-moz-program) 'browse-url-gnome-moz) ((executable-find browse-url-mozilla-program) 'browse-url-mozilla) -- Lawrence Mitchell From unknown Wed Jun 18 23:15:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4300: 23.1.50; bad function name: browse-url-default-browser Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug To: Lawrence Mitchell Cc: 4300@debbugs.gnu.org Received: via spool by 4300-submit@debbugs.gnu.org id=B4300.13105526407980 (code B ref 4300); Wed, 13 Jul 2011 10:24:02 +0000 Received: (at 4300) by debbugs.gnu.org; 13 Jul 2011 10:24:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgwbm-00024f-Vu for submit@debbugs.gnu.org; Wed, 13 Jul 2011 06:23:59 -0400 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgwbl-00024U-9p for 4300@debbugs.gnu.org; Wed, 13 Jul 2011 06:23:57 -0400 Received: by iye7 with SMTP id 7so5467233iye.3 for <4300@debbugs.gnu.org>; Wed, 13 Jul 2011 03:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=kHb+qyaK6ImKQ9IYTp9hIFEPydNwmT7FIRQ8ZHcLxO0=; b=dEtnGx7zMk9AQaZAD4nW0xsFGc1vBeIh7SY2S26Cp6XiX9F3gMZCY3oddBdiwn9AWO qPnh8lB6jGWAOyUVbzOAw0jeKN2vZqmJTQmWEXhRngDPRA53SD062wODoQTqhmmaHSgU 1ZUxlNO6fyilEHRp7JzcQDQETarseNPrj7JWA= Received: by 10.231.61.202 with SMTP id u10mr913516ibh.73.1310552631470; Wed, 13 Jul 2011 03:23:51 -0700 (PDT) Received: from localhost ([114.247.10.67]) by mx.google.com with ESMTPS id x11sm2540475ibd.58.2011.07.13.03.23.45 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 13 Jul 2011 03:23:50 -0700 (PDT) From: Leo References: <87bowyiop5.fsf@gmx.li> Date: Wed, 13 Jul 2011 18:23:38 +0800 In-Reply-To: <87bowyiop5.fsf@gmx.li> (Lawrence Mitchell's message of "Wed, 13 Jul 2011 09:12:38 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On 2011-07-13 16:12 +0800, Lawrence Mitchell wrote: > How about this patch, which doesn't change the name, but does stop > it from lying. It also removes the (unnecessary, and indeed > incorrect) implementation description from > browse-url-default-browser. Sounds like a good change ;) Leo From unknown Wed Jun 18 23:15:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4300: 23.1.50; bad function name: browse-url-default-browser In-Reply-To: Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug To: 4300@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13105650743490 (code B ref -1); Wed, 13 Jul 2011 13:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jul 2011 13:51:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgzqI-0000uC-D1 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:51:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgzqD-0000te-OI for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:51:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qgzq4-0005q3-Ct for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:51:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:60913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgzq4-0005py-4t for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:50:56 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgzpz-0001EP-Eb for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 09:50:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qgzpu-0005ol-Gt for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 09:50:51 -0400 Received: from lo.gmane.org ([80.91.229.12]:56671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgzpu-0005of-60 for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 09:50:46 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qgzps-00083H-7v for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 15:50:44 +0200 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2011 15:50:44 +0200 Received: from larsi by cm-84.215.51.58.getinternet.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2011 15:50:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org From: Lars Magne Ingebrigtsen Date: Wed, 13 Jul 2011 15:50:31 +0200 Organization: Programmerer Ingebrigtsen Lines: 12 Message-ID: References: <87bowyiop5.fsf@gmx.li> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cm-84.215.51.58.getinternet.no Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEURDBcVEBwTDhomIywN CBKbaMmoAAACf0lEQVQ4jU1TgbXjIAwTlAGwkwEMZYCmuQEg9f4znZze/ffpa9Mg27JkQPFf63Iv k885BXU7f9af5v7HP+4tK8p5vmLvBvbIkeK1b8B5Hj9AlDOfwBL4+auUXygJU5EkMs7z8y9j+p6T qyQ9UL/AuIE1/ZU+5ls1jN+lhq9UpZben7ACFI/mHRRgXstEITkyMAKYXqov9YSyzxsoSvWFCka5 qCCV/avc0u4pFK/hj1le+AzfLkM2avFvLa9YfSTz/Xqia5DfEB/ZioHSL5aSmsv/BJKXIM/pQGsF N/n0gYVK5fuVIFD7JnzJQfJl/tREGR0zoCmsVS5Uvmp6AMbPTV4yraVyzFxXA1pulepKKlB8BA3l HfNIqUgFR71gKZum7rU1ViEknbPefVVGjWpr9204oWTY6WphHxW5G6naWGiDk3TE4k6Gq133zE16 pio2gfmuS4zTe3cClSr5jfq7NGgTUWn5BH/V2rQ3ktoj1RffGSQQRmQjp3OUiqUb8uj5CVE0iY58 ZrOW01lJnjaWsl7LKmhlvm1pP4u/8DhZylR81lBuyZRjGKQIQKh8sq3wp9vbKPbTSK4ESqYHzYpo EqHtlgXbwbZoTK7GCKYfGmobhMDbUoV0O9pTZNPySuvWwcismrJGvLSu8uwHDrk9IGnSO0iz2uJh O+M/a9OkLyAZw7oEx/bd+EJ6tNQre4vtf5ge+hDdOg57HLxpUaHV3m6MQjpHRHK2xL3eKr2U1oyn nx4HB/1vOTyOlG6dwOhhiXA3AJMvwqtjtoXt2g/l1HqWIB9bq+++cbQNPQLpLBMslEePJ9A5N+Fo w5x0iz2iKEZjH9J51ALkBePRCSf+ArvRhGEO5RorAAAAAElFTkSuQmCC Mail-Copies-To: never X-Now-Playing: Talking Heads's _Fear Of Music_: "I Zimbra" User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:K9PajqLYksXMLNLhUwXpTNX0JA0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) Lawrence Mitchell writes: > How about this patch, which doesn't change the name, but does stop > it from lying. It also removes the (unnecessary, and indeed > incorrect) implementation description from > browse-url-default-browser. Thanks; applied. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 09:51:18 2011 Received: (at control) by debbugs.gnu.org; 13 Jul 2011 13:51:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgzqQ-0000uU-98 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 09:51:18 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgzqO-0000uD-VU for control@debbugs.gnu.org; Wed, 13 Jul 2011 09:51:17 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QgzqE-0000Pp-4K for control@debbugs.gnu.org; Wed, 13 Jul 2011 15:51:06 +0200 Date: Wed, 13 Jul 2011 15:51:05 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #4300 X-MailScanner-ID: 1QgzqE-0000Pp-4K X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311169866.21458@+dFwsZ1zqG2Md7oVwBAkoA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 4300 fixed close 4300 24.1