From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Sam Steingold Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 42966@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: sds@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159802293022742 (code B ref -1); Fri, 21 Aug 2020 15:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2020 15:15:30 +0000 Received: from localhost ([127.0.0.1]:48068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k98lH-0005o5-JZ for submit@debbugs.gnu.org; Fri, 21 Aug 2020 11:15:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:41300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k98lD-0005jP-23 for submit@debbugs.gnu.org; Fri, 21 Aug 2020 11:15:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k98lC-0007Bm-Sp for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 11:15:18 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:34692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k98lA-0004Uh-RB; Fri, 21 Aug 2020 11:15:18 -0400 Received: by mail-qt1-x82c.google.com with SMTP id x12so1434460qtp.1; Fri, 21 Aug 2020 08:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:return-receipt-to:reply-to:date:message-id :mime-version; bh=9YRqKeTX59MmZ86eE69LecDMOxnf7NydMzZlAybS0p8=; b=eZaiYmUG7p2qXXE3I9aVgUtKMOc9ORP4OGjODUcqc2HHfS9Jo0vyIkjKHifq04IsEL 49ZVS73KvaZiHIDC6biuCgG8naDNH3n1xXZiYoxwGHeN0LMgkZMLRUBlkvM0wct89+Di 2P6i4lMECtsNx6/Jj4sunlNWv0dya7F+HVHLFb//3LsrtINeAkFveChGJ4J7ww841aOe yiYH9z47SDeSBWS2BAXzwTvZF914GLgKDvdeJM0z7/fPZVYn4WOdlDn1qCdmFCvLcs6t 45ZC15wX46PyUunuLv2JXMcme4XFeeXFJAR3KhXEQ1vVWh299VZzmGkvY3O2ofTyhfB+ XkTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:return-receipt-to :reply-to:date:message-id:mime-version; bh=9YRqKeTX59MmZ86eE69LecDMOxnf7NydMzZlAybS0p8=; b=cEafu9G2gvfdSFpCyVL7RUxNov/9vJFY6elw8Cm/je2LrxmGIBSzMlZd1nG//JGzae ELNd5PBYPFbbJvkL11dwk1LnduMsxzwhvZ4ZHc74NuWSgagGcHbHeEFzs6qHOhlLmmRU MUbQikl68gbdhEbiZJkNzM0+0DOobN8uvd+bV6X7LN/Z3BYZgFQ2WaGFiNWq2+uPpNXt CWrkd668VunEXcYHXyKOViBNaS63zRrUljEtbcHssXto83MUs0m9ej317zuuQq4IRR1n 6AjfFGd6GoviV27fzDNOvFy0VOfvneT2WSHrFVJ1LWyuEWs11Sxcy2XqCRtHtw/dwKiB S50g== X-Gm-Message-State: AOAM533iaqFaaMQp4THSJsha1qi2EPjUMPcFofpKXYVfnhq1upCIecgT +SOWANThcaJqGGNWtlVs0jfzNXQZVKIb X-Google-Smtp-Source: ABdhPJxi+TYxGEF9nXKVz0uVshy2a8HW3uFsxVYrutUs08tX6IOHcfAj8U/3G17VEpla4a2b0btLFA== X-Received: by 2002:ac8:454b:: with SMTP id z11mr3199008qtn.350.1598022914192; Fri, 21 Aug 2020 08:15:14 -0700 (PDT) Received: from BZ-C02XR5CGJG5L (pool-108-30-23-113.nycmny.fios.verizon.net. [108.30.23.113]) by smtp.gmail.com with ESMTPSA id i7sm2267597qtb.27.2020.08.21.08.15.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Aug 2020 08:15:13 -0700 (PDT) From: Sam Steingold X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Date: Fri, 21 Aug 2020 11:15:11 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=sam.steingold@gmail.com; helo=mail-qt1-x82c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) My home directory is under `git` and `~/.gitignore` contains `/src` so that directories under `~/src` can be handled separately, under different repos. `~/src/cl/clocc` is a managed by mercurial and files there are identified by Emacs as such, as indicated in the mode line as `Hg:1234567`. However, when I do `C-x v d` in a buffer visiting `~/src/cl/clocc/src/port/proc.lisp`, I get a prompt VC status for directory: ~/src/cl/clocc/ (note the _correct_ default mercurial root directory!) and hit RET, I get the `*vc-dr*` buffer with --8<---------------cut here---------------start------------->8--- VC backend : Git Working dir: ~/src/cl/clocc/ Branch : master Remote : git@gitlab.com:sam-s/home.git Stash : Nothing stashed ./ --8<---------------cut here---------------end--------------->8--- note the incorrect `VC backend` and `Remote` (which should be `Hg` and `ssh://sds@hg.code.sf.net/p/clocc/hg` resp.) This is because `vc-responsible-backend` calls `responsible-p` and `vc-git-responsible-p` is aliased to `vc-git-root` which merely looks for `.git` above the argument, not paying attention to `.gitignore`. In GNU Emacs 28.0.50 (build 6, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Version 10.15.6 (Build 19G2021)) of 2020-08-17 built on BZ-C02XR5CGJG5L Repository revision: e5d4fae6797330d91e901c7ecb1412551db12f6a Repository branch: master Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.6 Configured using: 'configure --with-imagemagick --with-mailutils --with-ns PKG_CONFIG_PATH=/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/imagemagick/lib/pkgconfig:/usr/local/opt/gnutls/lib/pkgconfig:/usr/local/opt/jansson/lib/pkgconfig:/usr/local/opt/libtiff/lib/pkgconfig:/usr/local/opt/libpng/lib/pkgconfig:/usr/local/opt/libjpeg/lib/pkgconfig:/usr/local/opt/freetype/lib/pkgconfig' Configured features: JPEG TIFF PNG IMAGEMAGICK NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2 Important settings: value of $LANG: C locale-coding-system: utf-8-unix Features: (shadow bbdb-message mailalias cookie1 emacsbug sendmail cl-indent face-remap inf-lisp vc-hg url-http url-gw url-auth url-queue url-cache gnus-fun time nndoc flow-fill tramp-cmds sort gnus-cite smiley mm-archive gnus-async gnus-bcklg gnus-dup qp mail-extr gnus-ml hl-line disp-table spam spam-stat gnus-uu yenc nndraft nnmh gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig utf-7 gnus-cache gnus-sum url url-proxy url-privacy url-expand url-methods url-history mailcap shr url-cookie url-domsuf url-util svg xml dom bbdb-gnus gnutls network-stream nsm nntp gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win doc-view jka-compr image-mode exif vc-annotate pulse tabify cl-print debug backtrace tramp-cache cal-move cal-x view cal-china cal-bahai cal-islam holidays hol-loaddefs bbdb-anniv cal-iso cal-hebrew lunar cal-julian solar cal-dst appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs find-dired bug-reference eieio-opt speedbar ezimage dframe find-func misearch multi-isearch log-view skeleton dabbrev log-edit message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader pcvs-util smerge-mode diff vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log remember tex-mode dired-aux dired dired-loaddefs inf-ruby ruby-mode yaml-mode vc-dir ewoc vc vc-dispatcher sh-script smie executable conf-mode company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-template company-cmake company-bbdb yasnippet-snippets cl-extra yasnippet flymake-proc flymake thingatpt company-capf company pcase help-fns radix-tree help-mode elpy edmacro kmacro elpy-rpc pyvenv eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util elpy-shell elpy-profile elpy-django s elpy-refactor ido grep compile etags fileloop generator xref project cus-edit python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 ls-lisp format-spec comint ansi-color vc-git diff-mode easy-mmode flyspell ispell midnight warnings gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search time-date mail-utils mm-util mail-prsvr wid-edit bbdb-mua bbdb-com crm mailabbrev bbdb bbdb-site timezone edit-server advice server winner ring which-func imenu paren help-at-pt desktop frameset cus-start cus-load info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 679755 110407) (symbols 48 32339 6) (strings 32 227857 7588) (string-bytes 1 6102300) (vectors 16 88150) (vector-slots 8 2148274 178424) (floats 8 1143 845) (intervals 56 46064 762) (buffers 992 121)) -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1894 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com https://mideasttruth.com https://ffii.org https://www.dhimmitude.org Daddy, why doesn't this magnet pick up this floppy disk? From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sam Steingold Cc: 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.16028385818013 (code B ref 42966); Fri, 16 Oct 2020 08:57:02 +0000 Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 08:56:21 +0000 Received: from localhost ([127.0.0.1]:57652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTLXA-00025A-Il for submit@debbugs.gnu.org; Fri, 16 Oct 2020 04:56:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTLX3-00024q-3V for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 04:56:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LrYXdSetvVeoFM3QqeX2XW9ZyPfAZcxrTnq42puXy5E=; b=o9DjDDes3y1/k6q/maaVhHrD91 j0mkifNrnLLELcWbdUZmuM5OAm56Gb4Ohfdn+Yc+7h4w3l3B7F8RphTts9GML7Zn60QJnb6+h3skm Nok6NnmO2uC2dWOshSinVgOigrwls9/y5+67my/WPsz2WVRZzrh3JnL4ETgFqA/MYN84=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTLWl-0000ur-Vq; Fri, 16 Oct 2020 10:56:06 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: ELP's _Tarkus_: "A Time And A Place" Date: Fri, 16 Oct 2020 10:55:54 +0200 In-Reply-To: (Sam Steingold's message of "Fri, 21 Aug 2020 11:15:11 -0400") Message-ID: <87d01imtwl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sam Steingold writes: > My home directory is under `git` and `~/.gitignore` contains `/src` so > that directories under `~/src` can be handled separately, under > different repos. > > `~/src/cl/clocc` is a managed by mercu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sam Steingold writes: > My home directory is under `git` and `~/.gitignore` contains `/src` so > that directories under `~/src` can be handled separately, under > different repos. > > `~/src/cl/clocc` is a managed by mercurial and files there are identified > by Emacs as such, as indicated in the mode line as `Hg:1234567`. > > However, when I do `C-x v d` in a buffer visiting > `~/src/cl/clocc/src/port/proc.lisp`, I get a prompt > > VC status for directory: ~/src/cl/clocc/ > > (note the _correct_ default mercurial root directory!) and hit RET, I > get the `*vc-dr*` buffer with > > VC backend : Git > Working dir: ~/src/cl/clocc/ > Branch : master > Remote : git@gitlab.com:sam-s/home.git > Stash : Nothing stashed I don't think the .gitignore helps much here -- Emacs doesn't look that hard at the various backend's ignore capabilities. But: (catch 'found ;; First try: find a responsible backend. If this is for registration, ;; it must be a backend under which FILE is not yet registered. (dolist (backend vc-handled-backends) (and (vc-call-backend backend 'responsible-p file) (throw 'found backend)))) This just goes through the backends and the first one that happens to be able to say "yes" wins. Shouldn't this instead go through all the backends, and if more than one says "yes", then choose the one with the most specific path? Looking at the code, that shouldn't be too hard to implement, because it seems like responsible-p returns the root path? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen , Sam Steingold Cc: 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160285228431385 (code B ref 42966); Fri, 16 Oct 2020 12:45:01 +0000 Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 12:44:44 +0000 Received: from localhost ([127.0.0.1]:58046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTP6B-0008A9-W6 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 08:44:44 -0400 Received: from mail-ed1-f46.google.com ([209.85.208.46]:35707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTP6A-00089x-Bi for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 08:44:42 -0400 Received: by mail-ed1-f46.google.com with SMTP id cq12so2200079edb.2 for <42966@debbugs.gnu.org>; Fri, 16 Oct 2020 05:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tYsxHp0dvcnQ0fmPOL2DyRMPKAgrHg2pfu/uSWBJlVc=; b=SpQXPxOvD0koJgmt5D1baSIsSNIdUwC9oW+A9fJuwnq5vc7tXhbB96CjDYoVg4GN/M WO8eyJGlSB+fmL8tNDD+bboTWTDRepXaS9b2ZscQkCqAr240C4mnDKD87/Pi3RYVu49Y NtsCWtg5ohEVp+Qa4qxw8KU/gkqmZCrAGHXn/3MYZMhS7dYPGiacSGC8EVu07DEKXuff Qc9AH/Xx6C2iygYl/tPfN68hMiZqWI1Kgc4owyrmEH2yKkWMpRFlR5nf8JhLtMFOHLCT dzAzoRS8QadRh22uiD36+PXA0LjClNTlD89KMKNVfuT/tW9j0WUKUNwxlZ3iApJXrTS8 Lc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tYsxHp0dvcnQ0fmPOL2DyRMPKAgrHg2pfu/uSWBJlVc=; b=b2S/eV9gXLTN0nL7gA7+W2axX8zOR3jMmttYU26Cq4Xwc2FEh+ScjfsFfjO7C15iQL 41kYetYltgf/XrUlIWSnXllT782G95Bu+3kHLmmu9up3J1f+9c03BuGIfv1hT6czoUy+ W0qhKMk6T4UibrBgB8ZWd7xolu+q4rHs8ASbK/3mGm4G5DHBJv3jIUtsrNL0uZLcfFzy 5kt26k48JuhppdnHo/eCsKyKmq0Vxe7RAD9jMu5htaDeV21k7+muEikjYLKsyOjB6foh pO/E/CAm0tyBbkJtGpfRMHsECpzU9HzScEzLneLWhXMvqMqz2ki6A3PBmmyhMPvl9lfa 41Yw== X-Gm-Message-State: AOAM532uMHb0fV2oWVFOF6q5xwIHmwAzj6xSOf0vETWpSNBkVJIQgvH1 t/3Bm5P2azd3gsB/7NLz28oIj223chpw8Q== X-Google-Smtp-Source: ABdhPJybNffOVeAx4CTFCo7/upJQMWKf/DyHrglbZSH39QRXd1J21BnFkYFaYXtYCaDrKS0MCY+zEg== X-Received: by 2002:a05:6402:943:: with SMTP id h3mr3697548edz.88.1602852276267; Fri, 16 Oct 2020 05:44:36 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id n20sm1450194eje.85.2020.10.16.05.44.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 05:44:35 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> From: Dmitry Gutov Message-ID: <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> Date: Fri, 16 Oct 2020 15:44:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87d01imtwl.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 16.10.2020 11:55, Lars Ingebrigtsen wrote: > But: > > (catch 'found > ;; First try: find a responsible backend. If this is for registration, > ;; it must be a backend under which FILE is not yet registered. > (dolist (backend vc-handled-backends) > (and (vc-call-backend backend 'responsible-p file) > (throw 'found backend)))) > > This just goes through the backends and the first one that happens to be > able to say "yes" wins. Shouldn't this instead go through all the > backends, and if more than one says "yes", then choose the one with the > most specific path? > > Looking at the code, that shouldn't be too hard to implement, because it > seems like responsible-p returns the root path? The code should be straightforward, but I'd like to see some performance measurements: both for the local case, and for the remote one (Tramp). The difference can be small, though, given that we already try a number of other backends first (Git is near the end of vc-handled-backends; we might want to change that, BTW). From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160285931121194 (code B ref 42966); Fri, 16 Oct 2020 14:42:02 +0000 Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 14:41:51 +0000 Received: from localhost ([127.0.0.1]:60403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQvX-0005Vm-22 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 10:41:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQvV-0005VV-9Q for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 10:41:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9LsvLfPU4c6hvqkhA89N9eHbwSc8pyanZOQb0pJrxwk=; b=emVuSg2eByAi1l8LDdQL8OF8Bx rN8E0lxa7beW1xrsl2HCUImdwYhXFup/xrj58Zw1wnw7kTRNuPbe9WiayRXKZCKJV2wqz5bjibXq3 ExWtxWH/zoE8HMIkPadBXb4SVUbXxB2FBXe9w0HaW+tTR7kGYfRUBI0daW8bFiD5d6y0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTQvK-0004L8-Tj; Fri, 16 Oct 2020 16:41:43 +0200 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAMFBMVEX+/v7s6ejj393R zMtnXVuyrKssIB9EOTeDeHYzJyUkGRgaEBDGvbhQPzuelZL///8RPH+VAAAAAWJLR0QPGLoA2QAA AAd0SU1FB+QKEA4lDl59bOAAAACTSURBVDjLY2AYBUMLMCoIMxhgk2B2CDMoYW7ClGB1iFRcwrLZ 5AAWCaUtLLmZjpgSYUpLni+bYYBFh3Lmqi2Y9vNceGW3O30qFlcVvKrebpqHRWKO99odfOswJZhm 7n66hRWLDtZdt4238JRgSrzeah2UwnwF04oplzQfTmeIwwxDAyUmARcBXCHMMAoGGgjhEAcA9Msm KaubwYcAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMTZUMTQ6Mzc6MTQrMDA6MDCjoS0GAAAA JXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEwLTE2VDE0OjM3OjE0KzAwOjAw0vyVugAAAABJRU5ErkJg gg== X-Now-Playing: Lamb's _5_: "She Walks" Date: Fri, 16 Oct 2020 16:41:37 +0200 In-Reply-To: <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> (Dmitry Gutov's message of "Fri, 16 Oct 2020 15:44:34 +0300") Message-ID: <87v9fa44im.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > The code should be straightforward, but I'd like to see some > performance measurements: both for the local case, and for the remote > one (Tramp). > > The difference can be small, though, given tha [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > The code should be straightforward, but I'd like to see some > performance measurements: both for the local case, and for the remote > one (Tramp). > > The difference can be small, though, given that we already try a > number of other backends first (Git is near the end of > vc-handled-backends; we might want to change that, BTW). As you point out, Git is already towards the end, so the typical case would just be two more tests, and both of the ones after Git (Hg and Mtn) look pretty trivial, too. So it looks rather unlikely that there'd be a noticeable performance impact, I think? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 14:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160285947121524 (code B ref 42966); Fri, 16 Oct 2020 14:45:01 +0000 Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 14:44:31 +0000 Received: from localhost ([127.0.0.1]:60439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQy7-0005b6-4F for submit@debbugs.gnu.org; Fri, 16 Oct 2020 10:44:31 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:39264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQy4-0005ar-Lc for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 10:44:29 -0400 Received: by mail-ej1-f45.google.com with SMTP id lw21so3547878ejb.6 for <42966@debbugs.gnu.org>; Fri, 16 Oct 2020 07:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mPstJEe3QsJdsepNle0RNtkPw0/oyyK6JheBaWb5kz0=; b=TufhzwC4QgUIPHsOHERJdpwmo+myC5q1DoT0j1n9tSK9wdtFUfjxvZh60HaNUpch09 hIaI+7sq9mbgRRYUUteJJ9qnguaFoF/ISvOP/T4WT/oFG2nNRD5Jb30AuB+V9UXmk7px k4baWeb+Ah2OrnEYYDkZ844X7wyP/7QW+Co7E+vn895pnhwRbMAv+ZrsgoFEzx/8SPE8 XdeJMEC4iTL/L1+C4xK3ip9I62AUTyMkjROBj9jti3Ma//aPiPOxfYbPhlnrzLv02csF Oyt/L+ImvZD32+xwTO2/zcCtWQl1GvKKjNATG0gl0q8pK7QvezOx2j5f+Ihde3rzKb0J FunQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mPstJEe3QsJdsepNle0RNtkPw0/oyyK6JheBaWb5kz0=; b=o9NkXUsHic6DT+zYG1+AH6Q092zj6GgWxVo6CmlfjU3VynvnKqcchBU+1NYEmk0aZj mS02lHic4AOB4WNnOdsfmWhsgN5GUDoDvdFSfclutTeVZD/JGs2rh2sBzkMcElmmW5Xf 17npJn0FfZ5CN59iL46ZVshriB9w4205sd0h8mnSebq73GNDeINxwnFbLRBF1qug8M2a qcobRdCtr1uoVVHrAvCqxKVfWVQ6AKRqfuLiPjQASz88NM8VKa6P0+WDeCwPpcSTRwdH ROgne4so3UDPv4e39KnfVdmf6qM8sWahGE7i1YCeTP9BM0aWaG22SIzxM90lfhQtGjx1 2ULw== X-Gm-Message-State: AOAM530k2zWsYa/r2BvekPH+mh9Yq8IzgEtr3zr9um4tDkSKHzrj+Gl9 5GQGMYatAUs6iHdmZ4ugEUTbeu+ZQefVRQ== X-Google-Smtp-Source: ABdhPJxvTdXGQrDDmGJ/Sb1FuTZHj+FRZhgZuv0C/S+Lg30ov85XHlvbY8tfLBQov6JZ7lZLZO3Blw== X-Received: by 2002:a17:906:8c6:: with SMTP id o6mr4035824eje.304.1602859462520; Fri, 16 Oct 2020 07:44:22 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id a10sm1764752ejs.11.2020.10.16.07.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 07:44:21 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> From: Dmitry Gutov Message-ID: <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> Date: Fri, 16 Oct 2020 17:44:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87v9fa44im.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 16.10.2020 17:41, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> The code should be straightforward, but I'd like to see some >> performance measurements: both for the local case, and for the remote >> one (Tramp). >> >> The difference can be small, though, given that we already try a >> number of other backends first (Git is near the end of >> vc-handled-backends; we might want to change that, BTW). > > As you point out, Git is already towards the end, so the typical case > would just be two more tests, and both of the ones after Git (Hg and > Mtn) look pretty trivial, too. > > So it looks rather unlikely that there'd be a noticeable performance > impact, I think? Let's measure it anyway, because the potential impact is big (an extra delay when opening any file). From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 11:31:29 2020 Received: (at control) by debbugs.gnu.org; 16 Oct 2020 15:31:29 +0000 Received: from localhost ([127.0.0.1]:60571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTRhY-0000X5-VT for submit@debbugs.gnu.org; Fri, 16 Oct 2020 11:31:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTRhX-0000Wt-Mp for control@debbugs.gnu.org; Fri, 16 Oct 2020 11:31:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34654) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTRhS-0001JH-Av for control@debbugs.gnu.org; Fri, 16 Oct 2020 11:31:22 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kTRhR-0005Ym-Gz for control@debbugs.gnu.org; Fri, 16 Oct 2020 11:31:21 -0400 Subject: control message for bug 42966 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Fri, 16 Oct 2020 11:31:21 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 3807 42966 From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: sds@gnu.org Cc: 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.16028625602487 (code B ref 42966); Fri, 16 Oct 2020 15:36:01 +0000 Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 15:36:00 +0000 Received: from localhost ([127.0.0.1]:60575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTRlw-0000e1-Fe for submit@debbugs.gnu.org; Fri, 16 Oct 2020 11:36:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTRlu-0000dm-Ro for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 11:35:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34802) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTRlo-0002B6-5G; Fri, 16 Oct 2020 11:35:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kTRle-0004X7-1g; Fri, 16 Oct 2020 11:35:42 -0400 From: Glenn Morris References: X-Spook: Rule Psix UOP Customs and Border Protection Pakistan X-Ran: 1GqAME-(x94.%``:e3"f+Z-QUJ&Lg_S7:/$|fk{j<(qq76&@);0npr0~zHV/l$:KMRjOa> X-Hue: brightblue X-Attribution: GM Date: Fri, 16 Oct 2020 11:35:41 -0400 In-Reply-To: (Sam Steingold's message of "Fri, 21 Aug 2020 11:15:11 -0400") Message-ID: <54k0vq420i.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a long standing known issue. See eg https://debbugs.gnu.org/3807#21 from 11 years ago. Or even https://debbugs.gnu.org/8179. :) From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 18:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris , sds@gnu.org Cc: 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160287239810684 (code B ref 42966); Fri, 16 Oct 2020 18:20:02 +0000 Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 18:19:58 +0000 Received: from localhost ([127.0.0.1]:60809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTUKc-0002mF-9d for submit@debbugs.gnu.org; Fri, 16 Oct 2020 14:19:58 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:41663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTUKZ-0002m1-Qv for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 14:19:56 -0400 Received: by mail-ed1-f49.google.com with SMTP id l24so3399763edj.8 for <42966@debbugs.gnu.org>; Fri, 16 Oct 2020 11:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BgQ1kQcE8lZ0qRMLTPYgHJFaXO2HIBIT8da0XOgDiWw=; b=pqe5qAaDLLUJsb2Fuw21Exr3KD6r49qUWtWVxM1zVLXdcxtVf+xwxBMBgjgrz7KyMv Bu26cdId9qN+I0cK6cxzmblbeMV7UXaIjpAFcSmmyk1HKE+2mTJqJe39zoXeRMHsZe+p ULtbfKlwtfoNt4CeClQbjJ3g9ov4c1oV+Mo14LtBeQfx0XVaNk76zFAPWBdUdIhF290s er++KDIZajFh813GZRn+9QKFDEJGtP8BV21qaHm3RXnh7pSLa+nqyWMBcw42qH5YKxsn ob3WyTeHB6cxnNRLuHvAQaF7MY8WuOlxu+RKUop6mCjMeYg5fvpbS8NqNLC9+TAU/8Ms p+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BgQ1kQcE8lZ0qRMLTPYgHJFaXO2HIBIT8da0XOgDiWw=; b=r89HrPGVyVOj+ZE2msVt/CzuaM3ZrH657774WezOxEtmeJngpxd28Oh9p3u8H67MGY 91kativOO6BcFQK0ClxxuWyNia5F00LLy/ZjecjI+6WcbYu5IGweb/bugTZyL1QnwWh7 nkpWnT3z6chUyuqK6ERx4h6XT/D4bSHWv2uSNA6G5TunKUCadOPw+mfYjJAX/V1j7dLp UXRD6oDpS5QjqMuzwUg9Nq55sJEeojc8iB7qlGg+MSIQihEY1dz8U2AJJVo+rm1UB1im hIlUfnbNeR6+rgcldQFFONMV37mriYx/dfAJBwKS4XkuDqjMtS0y7X7/LVB2rXKBs4Yt fy1g== X-Gm-Message-State: AOAM531u+MIExWI4bEUS1z0lJ9TPFFjLkcPNkYgmD3sgJkf2fEK1Y09g /yAPg9cOVyUQ15FtUkz4YD7se+N2uyBdZQ== X-Google-Smtp-Source: ABdhPJxmpzJUfR7hYCew5hyLqBhmqobPkdE8pGKYxVN9bjUWd3fZPPPsh2h4SV51fyRiH+y4JdUAEA== X-Received: by 2002:a05:6402:1388:: with SMTP id b8mr5596670edv.1.1602872389754; Fri, 16 Oct 2020 11:19:49 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id 59sm2213034ede.73.2020.10.16.11.19.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 11:19:49 -0700 (PDT) References: <54k0vq420i.fsf@fencepost.gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 16 Oct 2020 21:19:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <54k0vq420i.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 16.10.2020 18:35, Glenn Morris wrote: > See eghttps://debbugs.gnu.org/3807#21 from 11 years ago. Stefan's suggestion is pretty sensible. Though it'll require a rework of the corresponding VC backend actions. Not sure if it's possible to do in a backward-compatible fashion. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 06:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Glenn Morris , sds@gnu.org, 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160291481612101 (code B ref 42966); Sat, 17 Oct 2020 06:07:01 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 06:06:56 +0000 Received: from localhost ([127.0.0.1]:33080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTfMm-000397-Ef for submit@debbugs.gnu.org; Sat, 17 Oct 2020 02:06:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTfMl-00038t-7Q for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 02:06:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sVbvjvfJzKwYLPjhDJkZaqyCO41X4SsCt7Jr2pnn6K0=; b=F5fqcbhwe9bpAfdLN8IuFJwzZ0 gJn051Rqob4gQ01xQCuZajXxJdwssC+T+y6utUAgBR/p4GObLY79sDjOnKu/edPsf5u8cf3XDcDnr oursUxL/IJ01QHOO8VQ2VwcaANo7N68vynyE9lfsM3wB9GUQp8yOMGja35XFkPDH7gMY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTfMb-0008B2-S0; Sat, 17 Oct 2020 08:06:48 +0200 From: Lars Ingebrigtsen References: <54k0vq420i.fsf@fencepost.gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEX622P96mju2WDn pWOzoEjsbjbWhz70tYvv0qH55878+fH///+IxYaOAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+QKEQYB KiU5X0oAAAGASURBVDjLnZPBaoNAEIa1TxDbF4hroKG3uBU317JvIKm9lzbnIqlJTiki7u6pIDRZ T4Uc4u5T1piGyGgC7bAwsB///DMDYxiGaXWFcQFY/wUIuahvN8DRglYx6AT3ZwDaS7qAVX0iswvA rsxzA55X1NnBLq6e49oAeC/h5DWYeMEIgGGCg3kcx9EJHFaS8AxjXxP9ARQZKUqfkTh7A0BgUaQi IiFUiETwXbFjEnosUvYpPV/ItgLLXRBwfgJGb5/v2LhMJ+Gy0dVBQyKSE5wRDj1u13kUZ5L4DVCb OFk+87NZhOFKkjxM3tNgvIYg2j5FX3k8LVZw7duQ44ThZrt15t9THW/ERsJSYktEwrQan5Z4GJDl RHhMysUIgnXAH9nmedYqpXRZ6HKpV8BcSK201lI1PGqJ4IpoWbICblcoxQpZiVYQCCV1URWDAw4Z m7N92MCjFRfA7/+1i2yEUBtcUYrogLZBdWl2dWttcEPpA3Wa4HjnZq/f6zJvd2X9EfwAN7GyEqS2 dKkAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMTdUMDY6MDE6NDIrMDA6MDBPVsWyAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTEwLTE3VDA2OjAxOjQyKzAwOjAwPgt9DgAAAABJRU5ErkJggg== X-Now-Playing: The Pentangle's _Cruel Sister_: "Jack Orion" Date: Sat, 17 Oct 2020 08:06:44 +0200 In-Reply-To: (Dmitry Gutov's message of "Fri, 16 Oct 2020 21:19:47 +0300") Message-ID: <87pn5h1j4b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 16.10.2020 18:35, Glenn Morris wrote: >> See eghttps://debbugs.gnu.org/3807#21 from 11 years ago. > > Stefan's suggestion is pretty sensible. > > Though it'll require a rework of the correspondin [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 16.10.2020 18:35, Glenn Morris wrote: >> See eghttps://debbugs.gnu.org/3807#21 from 11 years ago. > > Stefan's suggestion is pretty sensible. > > Though it'll require a rework of the corresponding VC backend > actions. Not sure if it's possible to do in a backward-compatible > fashion. (The suggestion is to recurse upwards and ask each backend "are you responsible for this directory, then?") That makes sense, but it's just a performance hack, isn't it? The result should be the same as the less invasive "loop over all the backends and collect the most specific one". -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160291815917277 (code B ref 42966); Sat, 17 Oct 2020 07:03:02 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 07:02:39 +0000 Received: from localhost ([127.0.0.1]:33114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgEh-0004Ub-Fh for submit@debbugs.gnu.org; Sat, 17 Oct 2020 03:02:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgEf-0004UO-CT for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 03:02:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pDm6fWrDnSu28Vpua46JeDiw4LXKPH3NUJoGfWpGybk=; b=IW8fBGM8QqP9VcX1jMS00xiu6f Y4jLChIxA5LrJWoXkp0Fa7wySFgwOYiFIs88CBSOZa4Kuh6LA/BSZpiNmaX8TDvS0okgIIPE0/u+4 Z9dNLmBs/SRZzm5RWxXzaQlGBHrVGmdki0RZUQRGzyXltr1gBFWbQiaN+v9gqcnTwbTo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTgEW-0000P0-Ax; Sat, 17 Oct 2020 09:02:31 +0200 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEVUUE1hXVjNybjb 2MWJhXuoo5Xu7Nb9/etEQD/BvKtva2aCfnVBPT3///+oZfybAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QKEQYQIJY1lUQAAADySURBVDjLY2BAAEYBRgZBIA2kwDSylCAQgEh0CbAMWBZdAiwmgEUCohqL BANOCUaSJYCewSEBk8IiIcCIQwJiE3YJbP6A6GCESygpO4CosDRFqGEwifTyCCDJWl5ehGaEWnkA kGQuDysTQJXghOpQq2RAlwjgCg3hSi8vwZRgLa9kLncuX4ApUVYqXr643AFVohNouaAgU3k5uuWs aSBXMU5L00LzBzyQGIgEHLgkRJcuEQllCQkNcQ3dgCKxLFxp0aQmI6VMtWkBKBKLZwpNDT2qqaka FIQqAXSdAJAAJmdGhlEwtAAsXwsgmAsFV61aBQBdBy4XxoN/QAAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0xMC0xN1QwNjoxNjozMiswMDowMGbBCBIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAt MTdUMDY6MTY6MzIrMDA6MDAXnLCuAAAAAElFTkSuQmCC X-Now-Playing: Various's _1-8 Split Series_: "The Third Eye Foundation - There's No End In Sight" Date: Sat, 17 Oct 2020 09:02:26 +0200 In-Reply-To: <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> (Dmitry Gutov's message of "Fri, 16 Oct 2020 17:44:20 +0300") Message-ID: <87a6wlz665.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Let's measure it anyway, because the potential impact is big (an extra > delay when opening any file). Sure. I've set up a directory structure with a hg repo inside a git repo (tar file included as an attachment). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Dmitry Gutov writes: > Let's measure it anyway, because the potential impact is big (an extra > delay when opening any file). Sure. I've set up a directory structure with a hg repo inside a git repo (tar file included as an attachment). Here's the benchmarks on a local machine and a remote machine with the current code: (benchmark-run 1000 (vc-responsible-backend "/tmp/git-dir/dir1/dir2/hg-dir/bar")) (0.47081299800000004 10 0.07627535899999999) (benchmark-run 100 (vc-responsible-backend "/ssh:stories:/tmp/git-dir/dir1/dir2/hg-dir/bar")) (2.8259669379999997 99 0.912024865) Benchmarking for the rewritten code to follow, once I've rewritten it. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no --=-=-= Content-Type: application/x-gtar-compressed Content-Disposition: attachment; filename=vc-test.tgz Content-Transfer-Encoding: base64 H4sIAAAAAAAAA+w9TW8bSXaanQADNoIAOSRADgFqWsxQlNn80teEMrXjlT1jLTy2Y0njAJataXYX yR43u+mupmTa1gS5ZIEghwDZSw4BckjOg/0DewkWyJ5yyi0/IECAIDnkGCTvo7rZ/NDXWNZkMizA Itld9erVe6/eV71ud7zYcr2osvAOWxXaxtoaftY21qrZz6Qt1FY2VutrtZUa9qvVVldqC2LtXSKV tIGK7UiIBd+OlHdGv/Puf09bR/O/DF/elRBcgv/1leoK8L9eX1+d8/862hj//bCj3oEQXJ7/K/A5 5/91tGn+R7J9xUJwef6v1tY35vy/jnYK/7vSdq9MCi7P/7X62sqc/9fRzuR/z1axjN56DmTw+urq qfyvr2xM8H99dQP4X72C9Z3bfuD8r16wiaqsOvZavWbXnLWP1+SK8/HHq7XV1XV7Za1da7dqGx87 q+C3S3EPCCV2go5sRV4nVjIQN4l2n3SCgSqHUWdL1Nar9T8EEdioiRvVerWac8Jez4vFkhd4sWf7 xYbYpivGd02e//dtev/fvXPr9tXOcfn9v7K+tj7f/9fR5vv/h93G9n8rsgOnK686BryM/1dfx/zP anV9Hv9dSxvjvxe48uXVz3Gu/q/VJvX/Sq061//X0W7vPNqGjx/Bv/cO//znvxS13/4m+Vx47/0f vfeXH/zZwsKf/t3Cwvv/yv8WfuMP3vzKLf3ib/f+4y/+8cfWz7e++O+tX/71wvuvwljD3Ht05w58 /N5CTVSNf/rgm1d/v/9bv/rZNz979ie//od//6/f/Zt+/MHNv/q3L/75N997svTTf7n5P7/zR7// n7/4zijww25j+78bhs/fQQLw8vp/ZbW2Ptf/19Fm8L8fSas/UN2ysnt9X779HOfwv75WXZ3g//rK xlz/X0tb/LDS8oKK6hrGorgVCPmSmC5QFIRyIq8fizgURzLy2kNx3LVj4Slht8IBXW9JgaIi3bIQ 27bvS1e0hsIEYQJweMcUdjuWkQDvvmsrAd6l8xw6xV0pItkLYymA/vFAlUQLILZkO4yksINh3PWC Dg1pSRloYDTNThtGAw4aOfnSi5U49uKusEUQBtYrGYUaKPxmOMee72dwNRYB4B4CoWXCp8O4ExjE rR36fniMQ/t2ZPckLEE1aFi+JixL3IdrImxn1wHUOO56Do/HiRBuSyIMNwwkDq3j0P1H987vC71h nXiH0Y+7SPCBwl+wTJjdTefthgpIFnUGPRkQKXit8sXA9nmpOwGQtWfHXhgkrIN5OehSGhMb6M4Y MJEQIzXo930PvgMbfC+QChAHcDgYCBy4dgTdgj7A8wJNtqjHZBIQ9YVAVcCyvZV8V127Bj804nwn kQK8NeILqx64Gh4jk46RYqCXjmCFTC+g/Qh/GUma3g87oieVsjuEYBQrgEc8NR/vPDTF0nEYPUdc +1HYiaBjsWwYjEDTzNdMYxD58KVuGsar1WrzorGxYQAJfVyQ7Qpa6SGsTX+DhWlO0UX9Fa4abmjk vLZ4Isx82tUUTZGHucVTIwcrCoxcblHcBVIDeFf6IIdwpWHkpK/wmx4+ApodnwAACPflseDgrkQ7 HHgpQOITEmInuNtBKoxQgat6GoCw33dtFnLYcCpGOZkEGMAkMwCOkCuXx6G3PYPWt41KAWVHAJc0 CLjBX5pfgjIBsh1ZPswrrEDgBgTu9UXhGfQv4PpxKvPLhCDQx8zzaHOMENLphmLro7owPw0HgZuZ DoUin7KuhIoj2X0mjQQtI2qMM/6jXWrQ1er3Okkxw/63VS8MvDiMrGM7dro9O3hLT+Bs+1+rVdc2 xu1/vbq6Nrf/19LA/g9URD5AX0a+YQwU6s7Ic+JN+n5sRwHsAsW/dh5uNxoP+jKob57tMHhBLDsR qozHWoig+1I3jvuqUam0bUe2YABKXXfQKnthJZG1SpE1Nu56gKP6EuzPoA/aL5YO6h2Ag5oGdKLo ha7XRvvUBvWrErMuU6vet5VC64Xui0Ljt+QMoghsiD8U9SKB8G1QKoNEuT0nV4ONZcx2zyZqoNmF 3mA6wdopQix20ZDahEwWAHYEIKheCS2wTDY6P0eSXJkR0mDMHbZb2eFl8dCOu0r0QDABTAvNig+m +4iUL/kbISgn7XugQUPk4khKwlBJdFhi9sNsnKMDzLm/f09TB/R3YLd8yT4UEqoEE6BDwVcQZZzI fDGQ0TDVAKYGjigVkDVOGLS9DnxEspwqDJHRIuPjCzB7byiW8poTJdC2QPlDXvkhrbwItuuTW48+ +4JEaz9AzYz2Hg2DK1uDToe53wd2xGJ37/adR49A0VdFAnQGzIPAJGhsYuJUNkA6IxTCRDIMMBwp csBSFI/XRs71pDD3A/SDwgiJyqsaLZigJcMKCYBCGeYVZSMHbhDYGhAFspc2ogCS49gBbqlyuUzo nRhImjyQ7hDZeUi8bIqO5N/Q8xA09FJxk/tFMo6GcL+mf3+lwuCw/7yzacgj8LEA6whcPw9cop/u PrjfaPzx7qaRS3vBQDO5DnPnAMqJQAKH0yMfPpw98uFDxBqm9+0BeACHCZMJRTVoiYnrCBkxDQFE cu2QKIkj0GYveWq0dh4n3aV8WCQu5HjbgWVWAz+Gy9bWaweM9fOTkvjkNf2knXZyguBOkKCIxdgo jcNSngZ6LoykMSR0h4B37lSRS3HWELFrCCpQLOGi2uABmVsm/CHhT/pa3LcMHyZiBTvZC2DrSz2i MYjbH5t0g+UZLqPXwtgdBIwdyQd0gcuKRiKiCSDYAQ/297KwNCQNJL1gHlTxLvvg+RIykq/wbZ5q MyFbyiECk/AOqNgPA4WC+eJlukrBfcxx4TUrm3rrfGp7GFaB0IM0684eqFHcK2ND0h2TO2e7CJCW /I/Fh01RRVrAZhhEwWgTWFugjq0tJIi15UoH6LSU4l6cXiNJYbLGPqDWJNbWlw6Wt+/eu31IBNbf d+6XRCFdufUVuKFBaEFUEsfDQtHIoczgohlAUbRp8Q2R/1Cv7VxNgKze4UiKEZMv+ximoHJpSQhI xbEsYHysSOmjlKLmVmgNRraGBKaLLnFiY6b1IkXb6OS2o7BHE6L0YtjryghQXUQgYCxsB7YExICq S+ahpBHgQBSHmTSDCfwNJNgdwAjWhZ4C3EQYkXRk4AwFHS3QmiGKcUAWwJ54ZPUC4JEi82KCWfRd ZWI330OvXAPhvYSXyTzpNQf+sIzmPphGakQ3ACajHsatAKc9iOB2hMYLjLqtg1ZWEOA+kCYC8YB7 S9MkK4lqSdSKEFcL0zFZMc0gLG4uc4YhMk3STSRozNymuHnTzN25fxvv5J6wxUVFMrGbSjRVTlO6 MYObJbqvqdcQT0ykkPmUL2doQbfCGCA+McGkUC+tuMynGCidwB9A6ExtSG5HsgsI54spROpaxo2q FeJI7zFBpjUd99Cbb9SL++jLm1P6CU2Z1nWVTXEz2cdbJ2dr+XRdIoE1Wtepi0q6nrKu5Pb00khT JK5xg6JQ3AKsz2DjBqGW+vLFlAfpxZQIKKPm5vmzeAG4DF7i1zZGEC446SAApaOy1P9aVJ4dvK68 hW6e5Qqk1psRTYw2cV5GEfCxKfQ9cAboyon2LLS/tCWqpGN098xXQLlXGWinOETmh/6R9rLLy6DS QYWBXoPZy8tFjCpQbWq8KloN0ByWhfv4DGPJ0jXLWE5ay579PLPJeNypFvMCTuaY1QR8tUJtXpw5 MOgMQk8KGve9lE2nEZucELqwI/ZtPLHJnQi/H6eUxtyp7R/bQ6U3SSaOC3WO04sgZGQVrkIar7vS XYwnTQmBgE5hg8CACMVDU7R9u0OuEBg2lD83ZPuWRYDBfgWxX+I0QecQoHFQHIALoEKwdxD4BYUY Atwhjed0rqI0lg6cfYxMIG6WNsgOWF/vyHMHNq+lrOV0zCEn72zpPFZfMa/P8OyXzIpZZHRmWdlM X4LEwc9k6AFuGMmn5lCVbPCUXhxfwqVWoAHXUvU1EbYlvmXmUqKYnj1A3VPoqaEqiDdvRHLBGXaO vaCgVUsWVlM89oKVeqPxmYy3j13NrLEeX4s4qhwcVA4qqFdOBGZwCVAS2sG46VF4tdFwNMiTjPIe w/vke53qnLcZ7ZTzX7vf94d93CBXcAp83vn/+trk+T/0ntd/Xksbnf8uftsDYD5BiSVmPTHpmIoO B5dg1aTVA9cmOZqbyNOqbjjwXTrHTYzc+CGuPkBWasBpWEyu9vtRCH42xo/JgR/oVIRgB0l+Nuxn jjkvm/4c3wRm2TDKaFkt1bUUqMa+AR30AZWZX0qOqPogJBKPp6AnDOyK0Y7izkXTiCUeY70EPzAF YYqPPgICSGf8Yv517YaZ/8Q8MRrvTPHO2P88vdVTnSuqADln/9fWp+p/1tc31ub7/zraRfe/kybQ 9YFp5qy9jAn2seIPkYgwbegwGNUnlAhGkCmfwC1HRQU2l4hk5kjgiwtoCwBxir64jLYAKFpfiLGT JBvLQTg2k64Xz0BSO9aX0zKjrYYaJhv44ASc8oN+touHWLteB2J2K2y3LSAz1mMkJ0IZPtwOOZcB s0AsYI8WAN4sxPuutClGoGydz0U3VIMS4blRoqUQIYCVjO1hTQ5QM2YCJMp098FPmqz6jmAHfbaz d3hrf+/ug0eHO7fv3N8TbwSevVmBKKjKswMInrcOiuXlfGVsGQ1xUKv0C0UAR0f61gslzGd5AG0K rMhAv5hO7U2+trVFl42kTiSRVoficQi1Bn3fc5DR09RSQGJSviZWSaDW5iKCCYQKemIjB6FWFMM6 BoH3QlhOsiIpCpVnT0Tu6XIN/1bcQpHwBC87LTC4fTYeST3Bd+9Qn+L/6U1wLfp/pba2Mqn/N6r1 uf6/jnaV/t95diAIR2Vq0zodBl/cBzxFpwOMK/YB9QJAdYDFmHTzNFHwiTmxVXHlUSUY+L6ob31U M7jmyO7YXqDiJnYxuJoKj3joKSeNVUO4XrstdE9yl3v9eMhH+mHrK+nEIzisb8FMdi2+JayYe6bT Fw2sq6L6wWE4IGKQDUELRnS9tbu9s0Or5IMU8Gd54aDGvSQNGkcDsCc0CMbYyvE8Pbk++beseNiX zVYY+uzllsc6FxGFR5Kzp5kDHBW7MorKBnm7NVCVdDofhUqJvm/HWHqB1Xm4NGChDMji2Eeh587C fTMpCuSqxB5HHFzGCEaT7RWf8fRDhSf2w7J4LPFczQ+1GW/bTszeB9t/St8TGaisTBcSCr4vVB+r BpyuHcEwyYlkwFJXoMae7wLZdFneGEFMzL6aSFZTPAV/HwXhPtdvatB4agY+UQsgP5c4Y0RFajbw QqMCPILtguWOJbHkxQWFQHD9Qmd33BJlTLFYwW55vodiFIrdEJQXjK1VC0qk5T5xVCzx+aChM4jq xYCqQBkB2MNgLUHW+phhxbM3TIXqMzNXKrBrVGdCqIFJI9PKIkICbVmOTbl7y0JeWXheB9/xngUM BOI1bwnrlcgnko8WV9zbPrx1715zGxdtuaLwRFhfPz2oFsD4HjtghIuUxNa7CwysuHnz4M6DT407 mJBriFugh3qssdhpGhcacjxhL5Pv4OD5tY1UB4EDfvcUeoXZPUPlosTYvgxRKYaBCOkEMZFV9Cn2 uAyaaA59PFaQ7pGnRmcKWrskXqKhN+dzTOiSTsVfSHyX/Df8hei5CQzCl1xwOuVsGIYQmc04YwPS DjaQNImzkaqFmApmcbbjLjh1LNKU0VQlfXqFqILLApJNB82jU1eUdzzY1js44bbF57vAc0Iy5X3K XMv6zl2deZvRZvl/oYotzrZfjQN4Xv6vDsH+RP6vOo//r6dd1P/TASJo1L5NT3CMLCqZHDJe4A8B EHfQa4H2sQOFOlFd2usaiR+6Xama4UuWkhFMA/qmHc41ytu32fHfRC7gndZ/w/avr07Wf6+s1ub7 /zraZff/t8sAzsr5jWX80rxbArGkH8FiiNrlJGywGE6D0Y+KLCaDwL1V4SByshlDuNYfRH088PfU jPzdaDT7ZvoBM00AdHVOe7qsZCxmycFRcRSnz5ddJs6c2HCcDcw8oRY4/sCl+j6M9TSPFJW/6YIE TLLiozZHMiGouSge+tLGciAsd56VWC2XTQgn/P700YyS4Fq62YllEsUB8c2Ml0/OvQ7TrcjEEDwY z0uWuKBBP9xHBXo4nseYSZ0TEB6JqCUBUQbWS3bQcbZQKix5cMK+ZIZYFsyMRfm6OALDF3xyLZWl zBMBQPDITWUbQgN1kYRqiWXUoTMnFScP1rmYCSURwyyrgggokj5W23fCkHOswL7tB59/vrN3+Pnu Z4ef7ty708zXkku7D/YfbcOFurF791atmV8xjLFnMITllVs2ONGAT4Hdca6zWupVnpXP42mlXIZu i/lKEROZE1hQ4tTB4ektxqaUR1xMYB0+u1d6g1EUhDiyVKRn+cRsBIETBb4PLak1xiIK8eWpYWAq KV/CyBxGXIBtBQ/A8iTIN26IJkR4s5AXm5s423KRv0hlO8bMPDQP3LvzrVPR9EAY0BeLey2sFPVl BDiD12EBWRzM/eirSWJ6BqkXcXF82vdqkt4m6w6i9hnEzdAUYH3IFDpESb1xYyZ7F0EbXMotOiX/ i2W73tH1+P+16urU+X+1Pvf/r6Vd1P5TRaLOUPEDuGSJUcWSgk2GKQ8+hnRmI+nYbKw361PKqLHO LmBHrLNqoiLh2lTO/SVDJT3gy1knk2+aWZiogAGvb2N0EynX2V3eqvjsKOqQh/u7dw8fPNzbeXAf 9Mn+/T1TJ528ZtXI8QO/fJqU90xh+fHp43L4pC8XqJnwZyCbB1NdAQg+8sqqmTqRMuZnVolAy8X0 EVaT/qal+5mlWLjihsi/JhCLy80TE8+jcOQm18EhAYtjj7SSHs3lML+75IkbolYsIsqBNC6pS+bt +9dm6P9R2csV1YCcl//ZWFmfqv9an7//81raVdR/iNimR4qGXJn1f7H6a6yag5/OfRf1HONbZ0bV GM8B9y5QNTYKB8eqxlIQ2aqxzMXLVY3N2P9Xmfqlds7+36iuT53/12qr8/1/He2i+79Fz24OAjsI wpjO/WK7o3iPUyiK9fHTWaDELcGksc4FpSUADXwDDG0ifPmLFYIaoC+BPL7ktkuzxThsm47E4ItF Tdcx6dOxzAIo9KIQHs+wJSgqJfltMnTCN7XU5L06iepIshwEJ3u+LH4yFK5s2/jUMdwf6mc1WpQl y+DC73MB2OdgQv2oqms2Gm+FBL2NYHg+EjbODlHAEOdOX2HAytmJJL1bqJyZlMChRj5r7fwGmYsu P3k76RWSwJXBkLC/GCr8KhsIb3jFs3ACiJ6WrfTx0tNQ4uyRXgUKLwstvfuW3k0Bcb6h9wi/nwj2 CBgMfkURbBP+vmImA3fttoyHbKu5CIEyDxhr3N55ZIqnm5x00FHEbaJHNAjGXqiVhhVOBo2yDiN4 oFjKHJSX+LSazDi9MGoo9IQ0GcIfHyzyVXztE778idcDX3gxW8Wk5+jEerQMTQkItkK+wKNHvxnI 1DIHaM4bZ8w6PWnCB9Ikk4rjQnUwmf5FY0rkLwQiO6BoTIrqeSAm+49hAXv5EihAbz061RYXGp32 pmIgJ33LUxBmk/mGLvfBSwA2KbGsvSiMRLeS6W8WDR0mZwZSsGzuB8mb0ZItZy6LN8KEIVoWlpeX xUMeNnagQKakaytWEJL2/bhYYPycZBxJONghhnUrzvRp8cMtjV5NuVzGj5LAOh1Qn9q7jEP9Hi+B rwVrlw30dZvmRV81Zia1RYmsYyErgshIPd86JJbod4Zx5Vn2huafHVu0dCtO8OfyMU3hZMuVkglp MGcm6P+JQJNU+d/2rj7GjeO6nyzYzW3TooCbDxcpsL274u5kkrezy+WScs6qdG7ifMhK7RhOIsvy cjnkseJxaS55PkVWgbQFUhTtHwVcJMgXkqAFWgRFi6Yt2v7j2GmDJAbygXw4CfJP/2kSIIUDpGmA okk6783M7nLJ45I83jLSzU+gdEft7szOm/fmvTfvvTmTE8kNmIvYb+cHVk72JVPyu5DkxyXZ2g3x 0+pq9IybUTWzJP8MRE7Jl1yOERRU+2SrOX1toNWczNwdWDTAeR/NFekpiZ78KBsFLHcDix8TQy6b TflAv7KO8xjX43i8EJglbgOU5+hZ8cJh6IOJjxsnDx83MS34iMWHImTC1IF4QC6VfLWe4o3H9hI5 GLqYpGu8lyGzJwPdElGTck7p9+uJiMlEnTZOWvYa6/KWdfYqUGPvOq9BFxRGUOwidmOKMUglFT8K ZXCOC20hHAG5EkXcyKbKylpSBuMFY+i3I9UKV7RwdBLK3o+YacmXGFp0pplv8+ovV7GS492DkMRI 3xp9wyhmGrpvHu+aeOqRXvoM7+95WfEU83U3moEM0ot/f25TGxBOvGoY9/j22xBL2MYFCXz0YUkx WGUipoONc7hiUJzz3oWdS6x0b2i2m7ivehuUO1RI4JD9vz3abcwtCyQ1/3d4/89R8X/Z4JjzP3Ae ZZT+0eM5gJBfcKg7GPtzhHSQOF+McO9GXlppuCRTqsBpq4mICem8PfTaY8z7lTh0/7/KLIBM8r8I KRbNofxfW+3/ZIJB/t/xO9e7zcZuT9/wNnWTieYc/F3W39xvN319R3/Q3XPbfriFsxLNlZUwXRQc SvGAL+EI5heJbBpMc8BsrUD/Xb+aw61/yHiQRb7jDij0SLGntlHnQu2/J8uiQzXYQWExXAZ22uLu vCRr0GPaOPeEBUz4gY/PDcDug+hn6FIhLOmOybpcF+S5R/xta/oGsxJ5NhfGMODXstaYKEUrbtyM FaUfV/ycCbKmF7kdMZ4C47K5ZYTRjN0G39lab9OD3rrsGY5ig/Z6sQ7mwgg7Vw4JRkQ+jd48UTmz Geu4NMA6/WoLlUKddRjNKE0T321Dqxo8Xjiq0HMp4ytW1lbBCjJFMAW+zvZKzFQB1yZ3V/D/w0iy 4Ppe1W81vTwos5BL96T+zDPCNWPo961CRaSaj1o4xm11+51e1OkaM54xBA2z8GLuDWwBvRmxDpw7 twVKOVOC4Z/xTWAyEOTzxlTmh7BMI0/moW5LTlSwG2K0G5wo7DaoLsUWKaag81M3IR4ygEXs0lu4 Fg8Xst/PaZjlLUIy+SMZTVotYRWf03DA2LTBwco/Fb1nIkd55SHGMn3oCu+RuCyWnAzpQoFoo96H JqLJxXt5TmMDcrXZvsp/TRZrF9Uxt/02xfDKJ/hlYZee1AZC5AaeJeNtov7ym4CjR3fmPjaovZ7w 0+/DYBXCtxEU5G5qngvZ7IX5713KjTi9w+QSUwxEqpR8dyjnFWsNJvg5jBMOfPT/iE1smBtYr1nM O1AxIOvtKtxwlSQGJxyLJyR91m4IFroJEYt+t/dk7HbzkNsjjLg94rpYP7ibIvZkOdJi+GN8F7YW dZI3+yTWsBqinJxBwnweRTopQfod9IWCAofsIYm+PBPB5EkFwkQF+1r4PHnH4EVTJ2dsAKMJupyI zoSQV149jb/Str4GNasvG1dk9b+9AGsln5FX4Lkn4qwK+fbRZMImpVQ4ywv+Yq3D34x1HQoe7rkd Xgh064mNy0a+4ubrV+7d1LF84PIGW7m279cJVgS7qQedVrO3sfV4eysnukeu4H+B2xKLJrbonr4R PjLxTKh0uMYfvHyZP3nNxPcb+WzziqjTjHXNfoM75/S1WP9vYIP5+9ko3RSX8hpoENwgfl8eqOsN /8M7sNxv18CFEX5xUxu6ekWXDZArYgjxMvZZj+TfSrxLK8PyJr4D9PrXP/7ApZ2rWAw1vihzi8Wt 00bf7daCketxWOtdi5bJWGJylz4Nib2YhsoruNdhdrvMuoHNCzG5IcXzjH4JyvcmVg5QQcTO+4ro ei78CdkC5BUYGWKW4U41FB2EXEx9gzb5viqmZjMxyqYE1Afkv8GJKIe0G8pdj40BbP5CBf5YC2Fn NL71C5UP0cMmTu0BSdmmfNZX+81WLbbm8Z0Rz+9CL+B+6nZbTZC6bC6512iQE5X2kz3i7lU0OOui Fr6LD8DVsdmRqSKyc7GwfRDX/KQD9k5t6oEZ2b2OIka8AQS94hpMmUCnWNr4GqUdeJOuVHx4xCvl w/YYk3u4WMTfFaUkZGXzycDv5gWa0TjFV4IW5SzKCTMVM9r50PIZyy8QE4fb5jmZ7R5a7jk2/7o1 z5dZG7JZMWZg2GrccOdP5TKV04uNxj5UJpABv+EWX7+LJjL7Ty00V8Xm3x6Fd2kGTB/WHuMqNnuS nNZ8d5jrk3KbBDyVbHpvkE29UCiArZ6YaSAxcRj5gQmhrOQdZiR8J2OgBprRCf4DEwLZL2DmeLMW Tp9YL7ouTH+82cMtfrYSCUtFDBUbT26QoOs1ztR8hWeMrSe4i2eFD3QDMkXYtGFzS1oD4hgnvNmt 1/lxFjKhHBPMIUIAMmyA+zhFQgkSG0h8AK9CyweUSZQmJOuwhVDbMMeNKg5oUnsKeQMfjBW1wwR0 7kfHCLqLMERsskOiOxyhkUvoPnj3CMZmBlL8HTGIRK6D4g04NZAl5KDjqRdRAQf+Ji6c6cEr/cjE cuAmvD2ShUwra8bETVj1m7NcToys0BVF4yA8Yg1tsMV+1+0EkdEYgEMImGeT0Y5ZRrthoASfh1zU REOpvZXCxi+WYXVFtIfg0LMar9rr5/P51I+Y9HjHltD05L9DP8NV8IXL7oRPVT8/8qKtxHcjrol9 Cx+PPS386BeGr9yKfSI8PnRh/LoqdnFn4Epx3ZY+/pFbOOqTDGA0kHKd17TzOfYKwOE7aKcNChEu ys8jv0BWXb15IOroo0sxkJzDNVghk/CeC3hPXeyX8Iy20Vwn7pWLNla/59IY3gt+xQ0kYBEuq+VK iu3s4FNBAiRlI0w1piyDKKYJqct16B3xvNABwIxEsP/P50QpE6Zwd90G1S4MNfx2WKD3On0mD5jo hkk80iB5go8megFGXyGAV3A7go06yIUeHCcWKc2xF2y28fLo9eKdMYc7I2zoAl9bRSN82Ud/jBQC h4tCTap/i/bQHS8G/L8iney3H3jT2y8+8sa5tcH3eA4//9kwnMT5z0VLnf+VDXZ4EvSiu6GwIAzw Py8pNvcToNP2f41Y/Vdx/rtDbHX+cxYYSX/TnusUmIb+puOA/Ce2on8mOIz+jufZpaLpVYlr2MW6 Ufa8slU3a5WiRe1SvWbRKq1UJmsDCFwct/6b1iD/m7glrNb/DHBw6i2f/9ylhw33wRe/+J07ll71 6OkLi+6SQoYYyf9efWHyX+r/hpL/meAw+huOW3dc17Ztg3p2mf1Wdmzq1L2KZ1Fat0mpUnMmFNCp 8r9kJOV/yVTyPxMcnLp3880XHzVKNaMIpbh/568+v+W+7W8qH/j4J586/9n3fuTu//nXR77/wk+/ 9V8fXF763z/55f9cdH8V5ouR/A/ZunNcAabS/zH+r1gC/U/J/+PHSPpDcc0F0992FP2zwEj6G3TR +p9pEkX/LHAY/Q3PtU3iEqb72dTyyuUis8lLrmXXSb1KnLJXJKQ4YWR4mv5HYvWfhf5HHEfpf1ng 4NSH//S89oLxK0vb33nVjdfUHvlm+/TK768/f+nf+nefLr1n7SfPfezSD8qnP/3gO1/66vPmr7/7 0TuXP3v/3/34gT888w+vfNf7n/2DcuUTd/39J29Yv/bcjy799Q/++x+fX33jza/96o2vvPJ9L7/t e6/+4dcf+svP3PuNe9adu1r/8Ud3f/zPfvLNHz33rW//+Nv/t9T7cuXLi355hUH+5xE9c28jbf+P WIn6z+yLkqr/nAkue36XXoFcWpmsCsdauL192oUj4/VtHk3bont+Dc6zxlMllqsQNbENJ4JAjG3L b7itFgQSYNJpIC9b9LsppGOA/2MVMebZRir/E5LU/21L+X8ywXDJlPtkRTyZ+7gemxbrmP8gD7OJ VVFQzH5rYoD/52z3S0xv/1vsX2X/ZYFh+tMDLPk/xzbS5L9VGvb/GEr/ywS82H0rwDJQUOKepzSy H8Q8yEOY8/bQ9NBW9bfCWabDFb1X1zGmVhzigAXC3+BDAUFRrkvf8wPIuGi29Z1cIh+XR6xCaT9+ lgIcTejXsTQAtgrR3z3abQf6Rj9+VO5e8uQ2CGmF7zfPspvPFC777hX44ffUMpXAAP9jFuz825hF /lvK/58JhunPs6Dn2cYM/l/LUP7/THAY/Xkc/HzaSFv/DZsk6G/bplr/M4FBJ/P0q4Xz9sQw/2PR x7m2McP+L3EMJf+zwAD9oT7KMbSRKv9NJ0F/0yElJf+zAGN5rMM/uO4raX9SIPmffcgxmH6IqfR/ xvgGiAHl/8sEA/Rnf5kLtv/h4F9m/xOzqOifBYbpv9vAL+bYxjT0L1nC/lf+n0xwKP2r7pys/0ny v4tJ+jvq/LdsUPd9peydYBzK/4XdxrzWgKns/6KJ/G8r+Z8JxtK/3675BTh8tt8p1ODoabc3y75w qvx3YvF/FrvONBxT2f8/V3Dhr58JsB9Ps4VjwV1SmAPG8v8ReD6O6fgf67/bRMX/Z4Jf+MTySw9f 23jphZ996Xsv//sv3XH+xX+6Puq69tLSe/6C/Xvn1T9+9oNLiv9vF0yw/vv+tT23ey2YuY10+y+p /zklxf/ZYCz9n/agbv6RzYDp9f+SaSj/XyaYhP54cmer2b6WZ0PVoL1p25ia/01iWer870wwMf2b AZxWNFMbyP+ETEZ/i4D9Z5UU/TPBVPw/YxtIf6jrNjH/W5j/bR5V8EwCRf/J6N/2j8T/E8t/8P8z /ncU/2eCSei/57abdRr0oFhyjx708Nsp2kijPzHsBP+btqHOf8wE5F0vL9EbH/rSR2tXX/Hdb9zz 9N+e/vNn2Nd5MO89WreqZYNUip5BPKNsWJWyV7WIUbWr1Yptlh1SIeViTW0g3bpIt/8h+/NobaTK /3j+L7f/7KKy/zOBoXmqAvgJxgT8f+RNgOn0P3adxf4w/Y9ksTl5wvl/7BDPx/03i//PUPXfs8EE 9Ofn4pj5gHb3aW2GNlL1f6uU0P8Nu6j0/0xgOG7VqNQc2yxVzXLN8cx6vWbQCq17tlEzzCLxqtWS U9ENbeJLfb1G626/pZSKn39MwP/dKpy7vB/k98lsbaTr/0P7f46j4n8yAez/L7oPCovDhPwPJZ9m FgDp+r+TXP+Jpc7/ygRipV50NxQWhLH836VP9ZtdOnvkD0cq/zvR+T8m4f4/S9V/yAQ1vwdnftao Vm+juNcatE27bqtGWz1XY3pfy2/sEy3osPen/FcNDr5WFSFuC0zgYkPz/yhtTL3+EwdEguL/DKDW /5ONsfzfcoNenin+gdughd7BrLNkavvfZNer/b9MIM7/VYv5CcVY/kc9byH7P8RQ9T8ywQT0Ry2w s+sy9d/3ezMYg1Pt//L4b2Kr+u+ZYAL6C8Nw9jbS138rqf8XiaJ/Jqi5PXer7vuFplIBTiIm4H/D kAHAhdkYIHX/347v/2P8t6n8fxnh9NIp8VOBffLya5nqf0h8cIi+ChS+pTGp/scD7fCQgKnbSOV/ w0rqf6at7P9MYGpLcdXe0JZCdc/QOi232V4KgytHRlwaiqlvZUzA/6giHqWN6e1/xyCq/n8mmJT+ aCLM2Ea6/C8NxX/ZSv/LBpH+dxf73Cm/lvrfF374z6ee/dTrXnH6/S+SX7z8Lw+/957XXozf3r/g dtXhb7cuJrL/vF233aAtvzGbCEjjf9Ma2v+xisr/kw1Ohfz/DvZ5TH4t+T+tPlTfIrZL64zAtlOt eDXDZaS260aZlmtlUnEct86sQdvxNBzA3zrwC412Pyj43YZGSoZZYTPBKut5xzQMDYqRanxHKssh OMmYgP+P4vpHpPp/7aT9xyxAFf+dCYg+aVqHWuRvR0zo/zlSG+n8X0zu/zIDQPF/FogZd4Y24OmH X+OKn3L03I4Yy/9H1vw5UvnfIYn4b6YNqvU/K9yh1/p7e9f1kNZwgG6nS/fhcN1+AOfywim9fouf Eq+33Ot+XynotwcO5f851vdNj/+xB+t/kSKUi1P8nwGU++5kQ/L/apW2vd0Cba3Ov400/i9G/n+L 2Hj+Nymq/M9MsIF0h/re+W6/rRNGDk3XN/Yh5T/o+O2gWW3RPGz60nZNX9nq7XW2xp0ZtbK5qW0Y haJjlIlZqZQlidmTdaNgOCXTsS27XBHY1LThHoztQBDsngW7tEmDs5P1xiyUTbtSKlUshzfq6JUK 60yFmIZZLJfszRMsAOXovds/Po0uff2P2f8Onv9ISsr+zwTq/K+TDcn/cvk/jjbS1//Q/28Z6P+z DFPt/2WCY1r/bVK2iqZZssQ6rxO24BLbrNimbRX5KkycbFZ/x7BLlWKpbOol1olyxS7BjiT2oVy2 TvLir6CgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgcEvi/wGO7JgpAGgBAA== --=-=-=-- From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 07:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160291885218347 (code B ref 42966); Sat, 17 Oct 2020 07:15:01 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 07:14:12 +0000 Received: from localhost ([127.0.0.1]:33127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgPs-0004lr-4U for submit@debbugs.gnu.org; Sat, 17 Oct 2020 03:14:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgPq-0004le-Te for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 03:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yaq9+ePmnT14OgC42mUmBrCif/Ft0VWjMAmp4nKixaQ=; b=V/DTO7tMNEri9vs7zR1G2e3Oya O4EXp2b1I/gB/0LRxPUE4lvqOLZRQuCyI1P/oM0M/pjYc7a2lWad8qHTUChuQmEPoqcLpuV3TM9KG tIfwqQ/6Ady3Vypm/O/zWeysOyTQBcFLyJa5yN0bbbNTJQtKVR9kjcISIahw5HUulhYU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTgPg-0000Xg-LT; Sat, 17 Oct 2020 09:14:04 +0200 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEVUUE1hXVjNybjb 2MWJhXuoo5Xu7Nb9/etEQD/BvKtva2aCfnVBPT3///+oZfybAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QKEQYQIJY1lUQAAADySURBVDjLY2BAAEYBRgZBIA2kwDSylCAQgEh0CbAMWBZdAiwmgEUCohqL BANOCUaSJYCewSEBk8IiIcCIQwJiE3YJbP6A6GCESygpO4CosDRFqGEwifTyCCDJWl5ehGaEWnkA kGQuDysTQJXghOpQq2RAlwjgCg3hSi8vwZRgLa9kLncuX4ApUVYqXr643AFVohNouaAgU3k5uuWs aSBXMU5L00LzBzyQGIgEHLgkRJcuEQllCQkNcQ3dgCKxLFxp0aQmI6VMtWkBKBKLZwpNDT2qqaka FIQqAXSdAJAAJmdGhlEwtAAsXwsgmAsFV61aBQBdBy4XxoN/QAAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0xMC0xN1QwNjoxNjozMiswMDowMGbBCBIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAt MTdUMDY6MTY6MzIrMDA6MDAXnLCuAAAAAElFTkSuQmCC X-Now-Playing: Various's _1-8 Split Series_: "Merzbow - Ab Hunter" Date: Sat, 17 Oct 2020 09:13:59 +0200 In-Reply-To: <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> (Dmitry Gutov's message of "Fri, 16 Oct 2020 17:44:20 +0300") Message-ID: <875z79z5mw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: And here's the benching with the patch applied: (benchmark-run 1000 (vc-responsible-backend "/tmp/git-dir/dir1/dir2/hg-dir/bar")) => (0.375446369 10 0.07836344099999998) (benchmark-run 100 (vc-responsible-backend "/ssh:stories:/tmp/git-dir/dir1/dir2/hg-dir/bar")) => (3.485639896 110 1.00616348) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) And here's the benching with the patch applied: (benchmark-run 1000 (vc-responsible-backend "/tmp/git-dir/dir1/dir2/hg-dir/bar")) => (0.375446369 10 0.07836344099999998) (benchmark-run 100 (vc-responsible-backend "/ssh:stories:/tmp/git-dir/dir1/dir2/hg-dir/bar")) => (3.485639896 110 1.00616348) Er... the local version is now faster? Is a throw expensive, somehow? Probably not very significant. But as expected, the tramp version is slower, because it does more lookups remotely. But not hugely. diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 39d0fab391..899f260089 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -979,12 +979,20 @@ vc-responsible-backend If NO-ERROR is nil, signal an error that no VC backend is responsible for the given file." (or (and (not (file-directory-p file)) (vc-backend file)) - (catch 'found - ;; First try: find a responsible backend. If this is for registration, - ;; it must be a backend under which FILE is not yet registered. - (dolist (backend vc-handled-backends) - (and (vc-call-backend backend 'responsible-p file) - (throw 'found backend)))) + ;; First try: find a responsible backend. If this is for registration, + ;; it must be a backend under which FILE is not yet registered. + (let ((dirs (delq nil + (mapcar + (lambda (backend) + (vc-call-backend backend 'responsible-p file)) + vc-handled-backends)))) + ;; Just a single response (or none); use it. + (if (< (length dirs) 2) + (car dirs) + ;; Several roots; we seem to have one vc inside another's + ;; directory. Choose the most specific. + (car (sort dirs (lambda (d1 d2) + (< (length d2) (length d1))))))) (unless no-error (error "No VC backend is responsible for %s" file)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 07:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160291916518881 (code B ref 42966); Sat, 17 Oct 2020 07:20:02 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 07:19:25 +0000 Received: from localhost ([127.0.0.1]:33150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgUu-0004uT-Ub for submit@debbugs.gnu.org; Sat, 17 Oct 2020 03:19:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgUs-0004uG-WE for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 03:19:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jBa1MoRfRlWNgnK3+Mdd5IN7CB02l+VFfjlIXhVXYjo=; b=YRxAzezEKbDxkkSrgVU7hjHjC/ 9ZZrq3Itc4c9+bFVH4fSwo7Nj7dguv7PBM4yb+flJKWSMUzGnXtNFpXWqi1afR1AGxSlxZLGuymj0 5XgLP1eZ1aLvjXoLt5k9ELJTz8pO6T7SDdT+DPGqSeyo7edaZlEw6+Ksw+sRetMua1co=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTgUk-0000a3-AJ; Sat, 17 Oct 2020 09:19:16 +0200 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEVUUE1hXVjNybjb 2MWJhXuoo5Xu7Nb9/etEQD/BvKtva2aCfnVBPT3///+oZfybAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QKEQYQIJY1lUQAAADySURBVDjLY2BAAEYBRgZBIA2kwDSylCAQgEh0CbAMWBZdAiwmgEUCohqL BANOCUaSJYCewSEBk8IiIcCIQwJiE3YJbP6A6GCESygpO4CosDRFqGEwifTyCCDJWl5ehGaEWnkA kGQuDysTQJXghOpQq2RAlwjgCg3hSi8vwZRgLa9kLncuX4ApUVYqXr643AFVohNouaAgU3k5uuWs aSBXMU5L00LzBzyQGIgEHLgkRJcuEQllCQkNcQ3dgCKxLFxp0aQmI6VMtWkBKBKLZwpNDT2qqaka FIQqAXSdAJAAJmdGhlEwtAAsXwsgmAsFV61aBQBdBy4XxoN/QAAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0xMC0xN1QwNjoxNjozMiswMDowMGbBCBIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAt MTdUMDY6MTY6MzIrMDA6MDAXnLCuAAAAAElFTkSuQmCC X-Now-Playing: Various's _1-8 Split Series_: "Merzbow - Ab Hunter" Date: Sat, 17 Oct 2020 09:19:13 +0200 In-Reply-To: <875z79z5mw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 17 Oct 2020 09:13:59 +0200") Message-ID: <871rhxz5e6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > And here's the benching with the patch applied: Fixed patch: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > And here's the benching with the patch applied: Fixed patch: diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 39d0fab391..8def7da377 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -979,12 +979,22 @@ vc-responsible-backend If NO-ERROR is nil, signal an error that no VC backend is responsible for the given file." (or (and (not (file-directory-p file)) (vc-backend file)) - (catch 'found - ;; First try: find a responsible backend. If this is for registration, - ;; it must be a backend under which FILE is not yet registered. - (dolist (backend vc-handled-backends) - (and (vc-call-backend backend 'responsible-p file) - (throw 'found backend)))) + ;; First try: find a responsible backend. If this is for registration, + ;; it must be a backend under which FILE is not yet registered. + (let ((dirs (delq nil + (mapcar + (lambda (backend) + (when-let ((dir (vc-call-backend + backend 'responsible-p file))) + (cons backend dir))) + vc-handled-backends)))) + ;; Just a single response (or none); use it. + (if (< (length dirs) 2) + (caar dirs) + ;; Several roots; we seem to have one vc inside another's + ;; directory. Choose the most specific. + (caar (sort dirs (lambda (d1 d2) + (< (length (cdr d2)) (length (cdr d1)))))))) (unless no-error (error "No VC backend is responsible for %s" file)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Glenn Morris , sds@gnu.org, 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160296488020098 (code B ref 42966); Sat, 17 Oct 2020 20:02:02 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 20:01:20 +0000 Received: from localhost ([127.0.0.1]:35599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTsOG-0005E6-B2 for submit@debbugs.gnu.org; Sat, 17 Oct 2020 16:01:20 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:39080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTsOE-0005Ds-5i for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 16:01:18 -0400 Received: by mail-wr1-f47.google.com with SMTP id y12so7149156wrp.6 for <42966@debbugs.gnu.org>; Sat, 17 Oct 2020 13:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FT7BVyM6ypVHke1YPu3KrVeOVvbQZUndWUGhu+0lPgg=; b=p3rzPrKH125uqLjyIqMnx1ziamP68DxNsFVM905zhECkyQOCpDULa9OzEt8kc0nXmw CdPcMy0tyPhJKbG3J9ls5+zy6Y11juWelPUSgDJOyBrzLA2d9H8Wlsi04m7VcwLBerKh DS5TlhXKlZ1f+47ko+5gyKozm8ETu7PoSvugxcn/8ln/8ph0w6RUNj5ia7PXRwECEyFD rP5Ii/MU1HKxcfgqgv+d85xhy61DvdOsQS95N+jhnxJhYLUYKZnJBHDpJDexO02RePg6 8bHP0JvJZixF4TRWQ6u6Evg9PcW3GAQp1cpUYa1tLOvaI+7WrpaXXKM7+3SfT7yfJMAm 59Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FT7BVyM6ypVHke1YPu3KrVeOVvbQZUndWUGhu+0lPgg=; b=tlf8ko+Vga2NZ0kNJGed2e1aP3jcwCn3J3YeAQIn5f1XTEo3D/Zyxtac1kKfOn95Tx c9nFJ5QrwXx8gN47YBsi41Uv9zdVzyFGjbZZPS06fis6VaKIFh7YQPiSXI5x9IqyUZkJ ROYpiNnnKdWonU/fEDRWOmk+X+LfhvwqHLto6Szu5K/ctz8DwrUc6DXAyQZDN6vx3HBJ OkHkBlfzuohDTOczEBD2F6vQBFfAiLCPMuPbDu88qiFOZDy+LiHIHmoq/7mIGDmVXUnF TqeOsjngDJaVvwuwRRp5Mq/djLpnfdlsNoOgJzPtNxWdPtZmqRgrBIbcJvEXylfwyTdu jyzQ== X-Gm-Message-State: AOAM532gICeZlltGFV8ym0wnjrGv8EfGNWXfipnWIkOiaTRWW2UyDnbz 3uLu7S0nTC1IMwxTHnxByW4mr2T3kP4H0g== X-Google-Smtp-Source: ABdhPJzNHCaMGsi1jbtTsetxte0474S03Us7/kD+hmr1/j+Xra+pWInQnhk5SxnlDhqV8qnAPGUXfQ== X-Received: by 2002:adf:f0c3:: with SMTP id x3mr11494485wro.343.1602964871998; Sat, 17 Oct 2020 13:01:11 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id z18sm6248018wrs.82.2020.10.17.13.01.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Oct 2020 13:01:11 -0700 (PDT) References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Sat, 17 Oct 2020 23:01:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn5h1j4b.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 17.10.2020 09:06, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 16.10.2020 18:35, Glenn Morris wrote: >>> See eghttps://debbugs.gnu.org/3807#21 from 11 years ago. >> >> Stefan's suggestion is pretty sensible. >> >> Though it'll require a rework of the corresponding VC backend >> actions. Not sure if it's possible to do in a backward-compatible >> fashion. > > (The suggestion is to recurse upwards and ask each backend "are you > responsible for this directory, then?") Or, more low-level, if we find that every backend follows the pattern of aliasing vc-xyz-responsible-p to vc-xyz-root, and calling vc-find-root in the latter's implementation, we could opt for creating a backend action that returns the "witness" file name (e.g. ".git"), and then construct a regexp from all witness file names, and pass it to 'directory-files' as MATCH. Depending on the cost of certain things, this could end up being much faster, both locally and remotely. > That makes sense, but it's just a performance hack, isn't it? The > result should be the same as the less invasive "loop over all the > backends and collect the most specific one". Pretty much. Except it should naturally limit the traversal up the directory tree, so it feels like a good architecture, not just a "hack". The backward compatibility headache might not be worth it, though. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160296729423871 (code B ref 42966); Sat, 17 Oct 2020 20:42:02 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 20:41:34 +0000 Received: from localhost ([127.0.0.1]:35638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTt1C-0006Cx-9g for submit@debbugs.gnu.org; Sat, 17 Oct 2020 16:41:34 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:34874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTt1A-0006Ck-NP for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 16:41:33 -0400 Received: by mail-wm1-f48.google.com with SMTP id q5so8965006wmq.0 for <42966@debbugs.gnu.org>; Sat, 17 Oct 2020 13:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gZD9TvbZBBYE4q/OOcOHbtMlBXjRSlejeZSunsDntCE=; b=WfSc9ohCmfPmUAuIexU63WsSLC4foSeay5BufEzjDdtEiuWqi9najJSU+qxQDsQyoT UCaRrNG3/P2oXDAy8u5CoXjghajVyyH3HVpTJ+v2td2OAAd5rAlresJV6Cf2Hn7O8L0r lGdDQD5m23CCEgah0vlajpHl+8CTlSP9xcjfikeNg+m0orNfKDnH6BIFItcYe1XQp9nB 0zfd+he6SmOOTRA4hFjf8mkAapLlinHfrjuUVT5ftYVJYw3apzES2W/YOfRMxpOhcWIQ cOJD9BQwytrY/ZwvZaIsppsJEvl3JZ1/aDLsF8VqvPvyw0WDaGc4UzqNZuu1RTgB4ZI9 l6zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gZD9TvbZBBYE4q/OOcOHbtMlBXjRSlejeZSunsDntCE=; b=A/7u7gIx3nGaNRWjn5SwTDeNUPbgPaXJx/gEqa9L3Cve123cfMUtGCfRTXxjDLBrEp xMgg+hSqB61ekv4+26d2yXgTvjBJbiQHrjUjCBk+BVnGpbcomOfaJDmSLdCy7+Mm5IKU N/YVsnzuXCEy0KdByCEyGFHvk63fy2idAEwhFZJ6iTr2mJQQL5POPfV94pYGIWjFaPWM uYHsxfDvgRw/g/jpYpkKs0U13iUhWv7G497FeBM56i1Dhyw1mKBcAEKPlZrrzLPz+bpV CsXEgF0RPYdP3IJdLYqRpRrThLclnuMvlIzF8deLEhafvr7ZfmxqfdGhtBCojO7uOeCF Csdw== X-Gm-Message-State: AOAM531XUi6AaS1lc2EHMmAkhL8bmv4Mh9DFPhrbJA7kdNTFNjctJOwl 0cvHZiuU//9lVJrsbvnrV274HoPqb5vc6w== X-Google-Smtp-Source: ABdhPJyIV3qQsWS0co+s2XwKyxONXWKwkAb/dG09cgpFle2VLuhCVXct6Lk1VXB1TTVvmRvH3GcD5g== X-Received: by 2002:a1c:c90b:: with SMTP id f11mr9914782wmb.54.1602967286664; Sat, 17 Oct 2020 13:41:26 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id u15sm8489035wml.21.2020.10.17.13.41.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Oct 2020 13:41:25 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <871rhxz5e6.fsf@gnus.org> From: Dmitry Gutov Message-ID: <3b9fda56-3f37-99ae-7f5e-1739a9c16020@yandex.ru> Date: Sat, 17 Oct 2020 23:41:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <871rhxz5e6.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 17.10.2020 10:19, Lars Ingebrigtsen wrote: > Fixed patch: Could you send an attachment? If I just copy this, diff-apply-hunk first proposes to fix whitespace, and then doesn't apply anything. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160296745224126 (code B ref 42966); Sat, 17 Oct 2020 20:45:01 +0000 Received: (at 42966) by debbugs.gnu.org; 17 Oct 2020 20:44:12 +0000 Received: from localhost ([127.0.0.1]:35642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTt3k-0006H4-M9 for submit@debbugs.gnu.org; Sat, 17 Oct 2020 16:44:12 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:56183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTt3j-0006Gr-2S for 42966@debbugs.gnu.org; Sat, 17 Oct 2020 16:44:11 -0400 Received: by mail-wm1-f42.google.com with SMTP id a72so6655180wme.5 for <42966@debbugs.gnu.org>; Sat, 17 Oct 2020 13:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=p8VPAqrE6kKS8O+TkMjoz9S0JlrabcUmPbJtrE3e43U=; b=q7ZHUykYRuxGfe5IJBNYLXM+g02jRKyTQFONsvAvqx6Y83u+qyW4JSreqxYS0XCFYv CDLKQXV9CQ3EIrCv2WfYonTu9lBcykzBu+d7I8BRVJdPNYqq9jl1ybTcyjH3KWwo14ac lCFTiQTgURWpAuUnF6tOEm+Orxnfld5IaBDA2Qkm5TGWRa8BPKwYWcs4+E7N71N/1nWN YAg/5yc4LYj5sQFuTEaJfWyZU0Sqj3TuHXckQDYCDHVoOKNDBO66xhbv2B+1tVXU+aMJ yzkvFWc4nB50YMzZ1i/HwACfN9Wr4P6xXahUm0Dy2DABu9MokvoX5i1AfHQkOaLK27/Q wO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p8VPAqrE6kKS8O+TkMjoz9S0JlrabcUmPbJtrE3e43U=; b=gKWtBdsGbyybLwFjQCpJBFZkDXYXM3Y23kmHtXosfQ9+yVA3J7P4Uf2izkWjc3DJSM niKP4VpiJ9S//QfgXYtalRP0QIMUbcpM3TNz9+s8G40Fvmcd8FB5SQX9E5L6KlelNuMh 0JdStmcwi7+p6iKXA+5Bd7WeNCtTo2HEhLlL1mK9VKJP6DsxfaS7vbklXb5QDOGrdGDv /4FOEv1zAJRinbtCeXSKrAJdqLiW8RX9i6Ed4tbn+aeS6046Fo60ey4VQqAprxsY8JLN /5z5Hp08dQc+cFizEOErwQsp40GpmQDp7uy40VmNqwt/P4RveW7EWBFJ1gg+jtQzRyKj BW6Q== X-Gm-Message-State: AOAM530rjxE1bb9+rrWVaO8VD9D8pMmUH2RpxW5oey83j4y8Ki/ZsqVR 5X4o4sxPCTLXi1sQVxj3QHm9plqcbAtWOA== X-Google-Smtp-Source: ABdhPJzUiQTMIskM6T1QacYzu2X0h/HPeMZcraelwpFyPwVJyEmdcXOpP2xfTCg1SS/MlyzdMeNGmA== X-Received: by 2002:a7b:c112:: with SMTP id w18mr9681476wmi.62.1602967445231; Sat, 17 Oct 2020 13:44:05 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id v8sm9149324wmb.20.2020.10.17.13.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Oct 2020 13:44:04 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> From: Dmitry Gutov Message-ID: <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> Date: Sat, 17 Oct 2020 23:44:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z79z5mw.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 17.10.2020 10:13, Lars Ingebrigtsen wrote: > And here's the benching with the patch applied: > > (benchmark-run 1000 > (vc-responsible-backend "/tmp/git-dir/dir1/dir2/hg-dir/bar")) > => (0.375446369 10 0.07836344099999998) > > (benchmark-run 100 > (vc-responsible-backend "/ssh:stories:/tmp/git-dir/dir1/dir2/hg-dir/bar")) > => (3.485639896 110 1.00616348) > > Er... the local version is now faster? Is a throw expensive, somehow? > Probably not very significant. Is it possible that you didn't restart Emacs between the tests? vc-git-root (at least) does some caching, which muddies the waters. Or try this test, with both versions of code: (benchmark-run 1000 (progn (vc-file-clearprops FILE) (vc-responsible-backend FILE))) > But as expected, the tramp version is slower, because it does more > lookups remotely. But not hugely. By 23%? That's a bit more than I expected just by looking at vc-handled-backends, which has 9 elements. 1/9 => 11%. I don't have a strong opinion on the remote performance, but we might want to ask Michael. Looking at the code, it seems to have forced him to unfortunate measures in the past (such as adding said caching to vc-git-root). From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Oct 2020 07:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160300673312502 (code B ref 42966); Sun, 18 Oct 2020 07:39:01 +0000 Received: (at 42966) by debbugs.gnu.org; 18 Oct 2020 07:38:53 +0000 Received: from localhost ([127.0.0.1]:36093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU3HJ-0003FZ-5e for submit@debbugs.gnu.org; Sun, 18 Oct 2020 03:38:53 -0400 Received: from mout.gmx.net ([212.227.15.15]:43839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU3HH-0003FL-4R for 42966@debbugs.gnu.org; Sun, 18 Oct 2020 03:38:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603006724; bh=//NwpOOFgEQjA6xMpd2awhhAFQS483efYT6LIDRZp2g=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=JbSB47xky8YqN/Kkp2TkkXx9m6t6QR2vNUiq7BORCaRthOXIX4n7fME1P0/4o0Y3i X7+Sz9FHJSHqn+z92WMKdjxLYfnp6709AYvY0FqcOyeFOr7wRDw4+tMEvUrPq4ZhjV 1LY0eesnTAxB2dekjI4Nzmvw+aQhlIjJU/NJXeAk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.52.21]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgNh7-1jxBlr1AUx-00hro7; Sun, 18 Oct 2020 09:38:44 +0200 From: Michael Albinus References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> Date: Sun, 18 Oct 2020 09:38:42 +0200 In-Reply-To: <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> (Dmitry Gutov's message of "Sat, 17 Oct 2020 23:44:03 +0300") Message-ID: <87wnzonful.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:cNACdyYLI3ul8CRfGDd9/mQmoc7S7IEwUDnowNcB6qL3zhWVYEd 7J0XZDISD6AKXu/RfFm8PBH2WGsdbFr6gMWxbOyp318iA2att9oZSfNxRJu04PbU8NdPGrE askh6pHzMU6UfFGAzIYoS1VCv5gjq+qcoYCpirLPZeNiqAXbjNX7ro1CMBEVPEOd72fDMGl HFDn+VsTjuqWCqO/f8Gzw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4xZWLodkVGQ=:/L3Ul0QvHFd4zi2RfpF4o3 LO3vYi5x4pPZl7IRp45yX8ECXCrgrDmKguenyAHXMacaEdxl7raMh6Opm19t4o8hFrPbLoF4u p5w826/Kn1Vi/k7gxot4/KbLy7QKSTfYFleC8r5QRAsN0rOXsGr51o2fVS/ffVa0l3rL16jtf xcuo8IpAYGflteW5bKPu/dtG0WjPp7NWheeazwYwwF4OarV1DeED7J4vr7pJqXaXwo97RvjKm i/y2J+BG7dlfCNtL/PGZs1YSSCc5WKa4svQCeGY7neYjashbAE/wceYEYL7aRhjC6GxsHA3Ax 92ZegtASS9Eaot/kmaT/lCBa4XFctTR3O7CQCTUg9rzfLuXBIcT+Am+i4LdHKBT+v2kwdR13z sZ7RZdbR+NeK99EhjouopYLD+pzoxjcgq6kRiNCobbxoQh+mZOShrx0c2/XpUJkTOEqlvXNw2 PKrP05njga2BEXj5RhIuB0imj/DGKXcJ61bFkpZ8DlF//Ry5n3J2XdeJw96Kg3J89s+6Ai7Yu rIjxA22mH4RvzPtYAMX8t5h8c56nUCXP+avV1E6y+ToeWwpiFQH+PZjAgXM1LkzyiqeU2YjUq nf0icrrfONSWd9rHxBmoMIw1afsJP85B2MRqWPEW29CPzaJkafIHRrx14M2ZDxtCMwlobPQds eoY9C5LJZkLenO6djb+CrH0JcldjnD/5MMPPt1BH7TIKYQr1i+tqU8+YxGIcac0Bcgk4Ka/OD YgnOFOXc6vTjbG0zHXNI9PQou0pQy0ZR3wnUyaImtdXudxnxXRC3n7VVJP5NZKDClV05R+Sk3 SAiXIsfHC6rkp0iw3p5J0oCwN897hwadahk7Gf3qQ1P/mXEpt+gkZ4oKaWEKm64APkFnbyqy8 zaZFP6YuH7TmuNuLejwQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: Hi Dmitry, > I don't have a strong opinion on the remote performance, but we might > want to ask Michael. Looking at the code, it seems to have forced him > to unfortunate measures in the past (such as adding said caching to > vc-git-root). I didn't follow the thread closely. Could you pls explain, what you find unfortunate in Tramp, and how to fix it? Best regards, Michael. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Oct 2020 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160300960925192 (code B ref 42966); Sun, 18 Oct 2020 08:27:02 +0000 Received: (at 42966) by debbugs.gnu.org; 18 Oct 2020 08:26:49 +0000 Received: from localhost ([127.0.0.1]:36149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU41h-0006YG-L9 for submit@debbugs.gnu.org; Sun, 18 Oct 2020 04:26:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU41g-0006Y3-Nd for 42966@debbugs.gnu.org; Sun, 18 Oct 2020 04:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sNOMgX6ddPa3Ss9tgB8afphl2Hayg+WXpH4DCUvq/Zs=; b=i452oVcoaqjf8hcAAEGNhd3lrW LCzmRjcv1TQ9O4HE/lQV6z8odz1WOZ/68vRX4G+KiZeWbETJTY2dcgTHUWzFkWb4LkquDQm7pnzZ0 hQyZ7iXnMxD5SpmFZDvXxjpyN+YZg+j+dFkwW8RGVt1dCkryk/bHGHCWmIcuH9+Ysu/c=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kU41Y-0006QM-F1; Sun, 18 Oct 2020 10:26:43 +0200 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <871rhxz5e6.fsf@gnus.org> <3b9fda56-3f37-99ae-7f5e-1739a9c16020@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVDNUhYT2KHdIYf GCT0zK+oXWX////KAn60AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QKEgciIGgyBOwAAAG7SURBVDjL XZRBcsMgDEWlquzBHvY2SfakTA/Qjr13Oub+V6mEwNAyWWT0pP9BCAMAoHV1TZQSB6z8Iv+BC9yS LECnoFVMISRdkg14FTgXbqmhCBYHsAzAdXMX1g6InTq4UwMp4VhxXzqA0eP+TQ1E7CCE+zZ386sk CLhdQCuwgu/5OmIBVk4Z2GNu5qjnsKI3jQcEBQQqlkYgyaCdWUZQmkjFy7awycXcWqBS0uJ+24oU WydJqDuKHFeA5V7AaTfAnwr6BZd05/N2ASpAlPBV8qsUJQHISv5lNN5AqWPXPNd4ATMUQNHl/Lnl LkUVPH0+TB6kSDdFbz4TXlLcQQUoIJpt8KCyW5yRwXsHFitIi8/QAceoaGGyJhszANSOTOTM8e4H DwbiFGg1x3mMB+Qbj8iPZkV77gOQKREaA1q//QM8IPNHsHB5XyC4eXossfV2yxVMqyOew96RrHfq pgViCKuFP8AKwGd4vJz1/yr4UcXw+Fmduu/b0QDPFLKWU5PcgeMR4We+Kjh3HajyDig9xV7BVywf DlAgYk7c9/OQgUYlc5m2qQJTkgWgTnpEnsM9v7wagzyoOtEK8i+W2o66dNtRxAAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0xMC0xOFQwNzozNDozMiswMDowMGkk31EAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMTAtMThUMDc6MzQ6MzIrMDA6MDAYeWftAAAAAElFTkSuQmCC X-Now-Playing: Rocket To The Sky's _Cigars_: "Cigars" Date: Sun, 18 Oct 2020 10:26:39 +0200 In-Reply-To: <3b9fda56-3f37-99ae-7f5e-1739a9c16020@yandex.ru> (Dmitry Gutov's message of "Sat, 17 Oct 2020 23:41:24 +0300") Message-ID: <87pn5gj5xc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Could you send an attachment? Included here. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Dmitry Gutov writes: > Could you send an attachment? Included here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-root.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 39d0fab391..8def7da377 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -979,12 +979,22 @@ vc-responsible-backend If NO-ERROR is nil, signal an error that no VC backend is responsible for the given file." (or (and (not (file-directory-p file)) (vc-backend file)) - (catch 'found - ;; First try: find a responsible backend. If this is for registration, - ;; it must be a backend under which FILE is not yet registered. - (dolist (backend vc-handled-backends) - (and (vc-call-backend backend 'responsible-p file) - (throw 'found backend)))) + ;; First try: find a responsible backend. If this is for registration, + ;; it must be a backend under which FILE is not yet registered. + (let ((dirs (delq nil + (mapcar + (lambda (backend) + (when-let ((dir (vc-call-backend + backend 'responsible-p file))) + (cons backend dir))) + vc-handled-backends)))) + ;; Just a single response (or none); use it. + (if (< (length dirs) 2) + (caar dirs) + ;; Several roots; we seem to have one vc inside another's + ;; directory. Choose the most specific. + (caar (sort dirs (lambda (d1 d2) + (< (length (cdr d2)) (length (cdr d1)))))))) (unless no-error (error "No VC backend is responsible for %s" file)))) --=-=-=-- From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Oct 2020 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Glenn Morris , sds@gnu.org, 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160300991031937 (code B ref 42966); Sun, 18 Oct 2020 08:32:02 +0000 Received: (at 42966) by debbugs.gnu.org; 18 Oct 2020 08:31:50 +0000 Received: from localhost ([127.0.0.1]:36153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU46Y-0008Il-9F for submit@debbugs.gnu.org; Sun, 18 Oct 2020 04:31:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU46W-0008DG-Ct for 42966@debbugs.gnu.org; Sun, 18 Oct 2020 04:31:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vuqWUXsKmSUEzMAIKuOSEYZ7EjZMkeFwQomyh3VltJc=; b=Ev/CoW3xqV9A7EXjDwx486EIlZ GTS8v+KqE2q+yfdsohgwyyaVpjEB5If9WRliwd48cuQWFvvQlTUpXLYYJMXp9YsGoKxltZIVTWsGq IH1qF9ddtqcTFwZdXUyQhXu956/6xQpH+EGP3OulXaLI5nFhBQhH9X211o5gqyH0oPi4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kU46N-0006UO-P8; Sun, 18 Oct 2020 10:31:42 +0200 From: Lars Ingebrigtsen References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVDNUhYT2KHdIYf GCT0zK+oXWX////KAn60AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QKEgciIGgyBOwAAAG7SURBVDjL XZRBcsMgDEWlquzBHvY2SfakTA/Qjr13Oub+V6mEwNAyWWT0pP9BCAMAoHV1TZQSB6z8Iv+BC9yS LECnoFVMISRdkg14FTgXbqmhCBYHsAzAdXMX1g6InTq4UwMp4VhxXzqA0eP+TQ1E7CCE+zZ386sk CLhdQCuwgu/5OmIBVk4Z2GNu5qjnsKI3jQcEBQQqlkYgyaCdWUZQmkjFy7awycXcWqBS0uJ+24oU WydJqDuKHFeA5V7AaTfAnwr6BZd05/N2ASpAlPBV8qsUJQHISv5lNN5AqWPXPNd4ATMUQNHl/Lnl LkUVPH0+TB6kSDdFbz4TXlLcQQUoIJpt8KCyW5yRwXsHFitIi8/QAceoaGGyJhszANSOTOTM8e4H DwbiFGg1x3mMB+Qbj8iPZkV77gOQKREaA1q//QM8IPNHsHB5XyC4eXossfV2yxVMqyOew96RrHfq pgViCKuFP8AKwGd4vJz1/yr4UcXw+Fmduu/b0QDPFLKWU5PcgeMR4We+Kjh3HajyDig9xV7BVywf DlAgYk7c9/OQgUYlc5m2qQJTkgWgTnpEnsM9v7wagzyoOtEK8i+W2o66dNtRxAAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0xMC0xOFQwNzozNDozMiswMDowMGkk31EAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMTAtMThUMDc6MzQ6MzIrMDA6MDAYeWftAAAAAElFTkSuQmCC X-Now-Playing: Rocket To The Sky's _Cigars_: "Cigars" Date: Sun, 18 Oct 2020 10:31:38 +0200 In-Reply-To: (Dmitry Gutov's message of "Sat, 17 Oct 2020 23:01:09 +0300") Message-ID: <87eelwj5p1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Or, more low-level, if we find that every backend follows the pattern > of aliasing vc-xyz-responsible-p to vc-xyz-root, and calling > vc-find-root in the latter's implementation, we could opt for c [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Or, more low-level, if we find that every backend follows the pattern > of aliasing vc-xyz-responsible-p to vc-xyz-root, and calling > vc-find-root in the latter's implementation, we could opt for creating > a backend action that returns the "witness" file name (e.g. ".git"), > and then construct a regexp from all witness file names, and pass it > to 'directory-files' as MATCH. Depending on the cost of certain > things, this could end up being much faster, both locally and > remotely. That does sound a lot faster. Let's see... ./lisp/obsolete/vc-arch.el491:(defalias 'vc-arch-responsible-p 'vc-arch-root) ./lisp/vc/vc-git.el873:(defalias 'vc-git-responsible-p 'vc-git-root) ./lisp/vc/vc-bzr.el646:(defalias 'vc-bzr-responsible-p 'vc-bzr-root ./lisp/vc/vc-hg.el1177:(defalias 'vc-hg-responsible-p 'vc-hg-root) ./lisp/vc/vc-svn.el313:(defalias 'vc-svn-responsible-p 'vc-svn-root) ./lisp/vc/vc-mtn.el201:(defun vc-mtn-responsible-p (file) (vc-mtn-root file)) Then: ./lisp/vc/vc-rcs.el284:(defun vc-rcs-responsible-p (file) (defun vc-rcs-responsible-p (file) (file-directory-p (expand-file-name "RCS" (if (file-directory-p file) file (file-name-directory file))))) So, basically the same. ./lisp/vc/vc-dav.el142:(defun vc-dav-responsible-p (url) (defun vc-dav-responsible-p (url) t) :-/ ./lisp/vc/vc-src.el248:(defun vc-src-responsible-p (file) (defun vc-src-responsible-p (file) (file-directory-p (expand-file-name ".src" (if (file-directory-p file) file (file-name-directory file))))) ./lisp/vc/vc-sccs.el218:(defun vc-sccs-responsible-p (file) This one is more complicated: (defun vc-sccs-responsible-p (file) (or (file-directory-p (expand-file-name "SCCS" (file-name-directory file))) (stringp (vc-sccs-search-project-dir (or (file-name-directory file) "") (file-name-nondirectory file))))) ./lisp/vc/vc-cvs.el319:(defun vc-cvs-responsible-p (file) (defun vc-cvs-responsible-p (file) (file-directory-p (expand-file-name "CVS" (if (file-directory-p file) file (file-name-directory file))))) So it looks like the only possibly problematic backend is SCCS? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Oct 2020 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.16030099821501 (code B ref 42966); Sun, 18 Oct 2020 08:34:01 +0000 Received: (at 42966) by debbugs.gnu.org; 18 Oct 2020 08:33:02 +0000 Received: from localhost ([127.0.0.1]:36157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU47h-0000O8-SL for submit@debbugs.gnu.org; Sun, 18 Oct 2020 04:33:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU47f-0000Nc-KP for 42966@debbugs.gnu.org; Sun, 18 Oct 2020 04:32:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jI0fSxckzMVxGa7oZcyZ4/ta3fKyo5QQQln3EQLP614=; b=mR3oCpFIx1Txs6dOMfmPRQ98Zr J+I0M5ttEl5iyvuW5Fj7+XnRoCQl1dthZOxhkZRoRdoIHIAfRu1j6dBdegD6xrhDvkV3bpbziRnFH KcVuJAHz/r0gkTe38rZjaBAVSRvaKTqCXxY44EIdUstzjApDIel/P/KH92onXAgTOjMY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kU47X-0006Uy-Et; Sun, 18 Oct 2020 10:32:53 +0200 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVDNUhYT2KHdIYf GCT0zK+oXWX////KAn60AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QKEgciIGgyBOwAAAG7SURBVDjL XZRBcsMgDEWlquzBHvY2SfakTA/Qjr13Oub+V6mEwNAyWWT0pP9BCAMAoHV1TZQSB6z8Iv+BC9yS LECnoFVMISRdkg14FTgXbqmhCBYHsAzAdXMX1g6InTq4UwMp4VhxXzqA0eP+TQ1E7CCE+zZ386sk CLhdQCuwgu/5OmIBVk4Z2GNu5qjnsKI3jQcEBQQqlkYgyaCdWUZQmkjFy7awycXcWqBS0uJ+24oU WydJqDuKHFeA5V7AaTfAnwr6BZd05/N2ASpAlPBV8qsUJQHISv5lNN5AqWPXPNd4ATMUQNHl/Lnl LkUVPH0+TB6kSDdFbz4TXlLcQQUoIJpt8KCyW5yRwXsHFitIi8/QAceoaGGyJhszANSOTOTM8e4H DwbiFGg1x3mMB+Qbj8iPZkV77gOQKREaA1q//QM8IPNHsHB5XyC4eXossfV2yxVMqyOew96RrHfq pgViCKuFP8AKwGd4vJz1/yr4UcXw+Fmduu/b0QDPFLKWU5PcgeMR4We+Kjh3HajyDig9xV7BVywf DlAgYk7c9/OQgUYlc5m2qQJTkgWgTnpEnsM9v7wagzyoOtEK8i+W2o66dNtRxAAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0xMC0xOFQwNzozNDozMiswMDowMGkk31EAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMTAtMThUMDc6MzQ6MzIrMDA6MDAYeWftAAAAAElFTkSuQmCC X-Now-Playing: Rocket To The Sky's _Cigars_: "Cigars" Date: Sun, 18 Oct 2020 10:32:50 +0200 In-Reply-To: <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> (Dmitry Gutov's message of "Sat, 17 Oct 2020 23:44:03 +0300") Message-ID: <87a6wkj5n1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Is it possible that you didn't restart Emacs between the tests? No, I restarted between tests... But perhaps I should have done more iterations. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Is it possible that you didn't restart Emacs between the tests? No, I restarted between tests... But perhaps I should have done more iterations. >> But as expected, the tramp version is slower, because it does more >> lookups remotely. But not hugely. > > By 23%? That's a bit more than I expected just by looking at > vc-handled-backends, which has 9 elements. 1/9 => 11%. Yes, it's a larger slowdown than expected. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Oct 2020 23:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160349722914867 (code B ref 42966); Fri, 23 Oct 2020 23:54:01 +0000 Received: (at 42966) by debbugs.gnu.org; 23 Oct 2020 23:53:49 +0000 Received: from localhost ([127.0.0.1]:58704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW6sX-0003ri-BB for submit@debbugs.gnu.org; Fri, 23 Oct 2020 19:53:49 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:38944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW6sR-0003rQ-U0 for 42966@debbugs.gnu.org; Fri, 23 Oct 2020 19:53:48 -0400 Received: by mail-ej1-f66.google.com with SMTP id qh17so4653786ejb.6 for <42966@debbugs.gnu.org>; Fri, 23 Oct 2020 16:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8GYQoIF/xwmB4uL3p9VVFI64xXgWc4J6FetzGTdjuLc=; b=bn5nB578MUevrywibnbxdixaObtcB96QEkWS87Q8HyZle3Wn/l99o52jn5u8hf4fuV 5dWqVtIaG5R6d51PXNW4joqjyFtHNwKNyvjP+vquYGs1jXf6eWZCoyjukhODbm+AmEer oKyjq3uWBawH7Bb++t75Q/P0NmC1opPgNWm+tbx3zmBqyZqtaImQj5RZdD0I0mo20B9v 7yZSMNEl73y/moXLlK36JpaPsWKO5PAHb3f3hlI6hqSjj3bisYgEdSbDZT4cnMAfniIC EG77IluwgIBw+3Rxej28S00I3Myh1XaEW90vuowrsN4gsjRAFrcy6obHIxNoCUZJCGjW EcPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8GYQoIF/xwmB4uL3p9VVFI64xXgWc4J6FetzGTdjuLc=; b=myQN4dE3oL1usUSzMDfTp7eZyeYbvN/7/TF9oJI+8fQ+hVSAVixeCoi4ldSR9yy1wA /c4dFBS/KkUorkFcMpa4PhtjEzXhlivwoBM5GEKqJmafsmZfcw3lbGFQQ0X8JHgg99oP G3eQeJOTfEDyfrbQUWgqtix6DB0waSkZ/J+HKtnMEXjpnUZdwNnV+tAta9KUseS12uaO 4RByqXMifV0vpjXgcMjbLeBGHvXRiaoG0nmYVUgzYBkpozEQKCXNfvSeTpfuE8hpLSQN zFdOO1Pc4NYdxty/0ZLrmyvJxwCM5UEqN/y+5Vy94fumKD5tCp8aKmbUymLPIk3ApmNp 6zdA== X-Gm-Message-State: AOAM532hpBk1xcUBW6zNeSXnlWoO1G4rYDaLmue9cS7kf7pHfdC2eR9a bi6VFDO7BOVpuSgqDi+MNeMzaDIH1f9BWA== X-Google-Smtp-Source: ABdhPJxZ3AIHIZWMLoUnuXXsTr+45Sh8kIj/Zhr2KG6XIzzX0e031Yq/o6quyN8g4oll9oS0rxSBmA== X-Received: by 2002:a17:907:43c0:: with SMTP id ok24mr4420391ejb.385.1603497217557; Fri, 23 Oct 2020 16:53:37 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id j22sm1390095edp.77.2020.10.23.16.53.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2020 16:53:36 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Sat, 24 Oct 2020 02:53:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87wnzonful.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi Michael, On 18.10.2020 10:38, Michael Albinus wrote: >> I don't have a strong opinion on the remote performance, but we might >> want to ask Michael. Looking at the code, it seems to have forced him >> to unfortunate measures in the past (such as adding said caching to >> vc-git-root). > > I didn't follow the thread closely. Could you pls explain, what you find > unfortunate in Tramp, and how to fix it? Not in Tramp, but I see an old change in VC that was most likely informed by a performance problem in Tramp. See the commit a40c87a0093. It adds caching of the result of vc-git-root to a VC property 'git-root' on the file name. There are a couple problems with that: - If FILE is a directory, this cache will never be invalidated (for plain files, vc-file-clearprops is called from a number of functions, including vc-refresh-state). - We don't do this for any other backends, which leads to inconsistencies in behavior, as well as surprising results, like when we did that performance test earlier. I think this is the reason for it. If we did this uniformly for all backends, we could perhaps find better opportunities for caching and invalidation. But before we look into that, could you try reproducing the original problem? Does the change below still make some scenario perceptibly slower? diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index b1880c0f7b..91554bb6d8 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1573,8 +1573,7 @@ vc-git-extra-menu (defun vc-git-extra-status-menu () vc-git-extra-menu-map) (defun vc-git-root (file) - (or (vc-file-getprop file 'git-root) - (vc-file-setprop file 'git-root (vc-find-root file ".git")))) + (vc-find-root file ".git")) ;; grep-compute-defaults autoloads grep. (declare-function grep-read-regexp "grep" ()) From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2020 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160354691129596 (code B ref 42966); Sat, 24 Oct 2020 13:42:01 +0000 Received: (at 42966) by debbugs.gnu.org; 24 Oct 2020 13:41:51 +0000 Received: from localhost ([127.0.0.1]:32974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJnr-0007hH-Fl for submit@debbugs.gnu.org; Sat, 24 Oct 2020 09:41:51 -0400 Received: from mout.gmx.net ([212.227.17.20]:41241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJno-0007h2-Ez for 42966@debbugs.gnu.org; Sat, 24 Oct 2020 09:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603546901; bh=3gtweTNjb6kWW0WHIAgEH7t6OZwzdCUPcamMaSJ6a28=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ku4WpHyeNKgzGtpXL/2EVjB9HWX5lC2Y0kIc/Lto8DtdPOWxjZcqlQye71vJMbwfG nNF4jTc8ZxxbGOibnKf1UIiF9sli/7yg5Nx5OrGLVVomUXgW7JNpq27sPehDwGUuie VC5g6A5KzKA31izTF55im5mGGs6GHIJypi3cSi1U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.44]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJVHU-1kqB4P2ZeS-00JqOQ; Sat, 24 Oct 2020 15:41:41 +0200 From: Michael Albinus References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> Date: Sat, 24 Oct 2020 15:41:38 +0200 In-Reply-To: (Dmitry Gutov's message of "Sat, 24 Oct 2020 02:53:35 +0300") Message-ID: <87y2jvwxkd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:cYfYIVPzWF4o8MY4M0UFlADT4YNFnaWyXXSogseVqUfBwz9BL5e bDrjVC6y13wKLcJ1LJk6tO6jnmsSZ+vkAN6mQ79JnioIWZQ9USq1LMtiF97gWnGRbjsseFH 3YL62H9tCebQFtbrQVfbYk5oqmmXzHjSpTM6j+vcXd+9nnyFf9bg/Y7z1C0EDjE1JWJarff kzlmurGiFpwlerzNOIQ/g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:31AwNA3xtKY=:hFW/42XOOj+/wTf3u47ihr CJwHObKgQVuFhHg5dyH8FfOkXo8QVJTfRFJzQScG//GONf9ng6HQ/V9ueCUlAe1o/PzOSf/Hb z5dNyZndIR9/m/cYs5QNqEoAGzn5FyzbquiqEwH9TrTbm5FzYqHw+T87w5c5r2g3mX4eFSyeI ROmXhYmyIaHEz76T/6/1Q+Hr2cFO2+iUAxqf+/1Qq2U2TkaPV5/Xmlk9KO3QHJLMOzFwWQEzY iPL6owW+Y9ku/LEqkc01ZdgWYCfUGib8jKMPUh9dcVsd1AZBtSxLBQ8GVBYLS8Jh/GEOkF3vs M0gCTQdYLaUKLGptskXiTkPIAwMkitnBR5NIJDmtFtSRWnLdEwBCXOxJfPbwWJdkSHChu3Qdp h17hO6yv4h3suR33uUIr9IKJtJnvqNjDrrMnR+w1EUe2WtShupmfJaNfgQUMrT9xgngRhvTkM 0hzrBDScA8VQxi3werAqPMIK6tLmUMp79xj5UO1FD4wRBA8OsGTjbBLqfzX5RIragralQhkn6 TN5ECxMHmwcYKN9AsMGcfAon73aSxh65Mu5BvRPiry04/8ItqxvXOzJE150PtMUVAq+x2ep8+ 4+uk859ijsUKnFIltsLnXAzXf20REls2aVLN02RLXRATxge6TsuygYp2u+TVubY6l4nfsSpl4 aRhZqQIOwVXC5n5wbDUihNHFju3ssJn+rYDJYI8CNxZnOmzw+R30mqmSw7o98SwF5cPUn1Oun b3bTE5yA1ID0aIelGRcHmfb69WS6fN2qlGhVK6cevC+3qjyuPQW45orKGlQ4MepR1lDhAFGik PQ5npplCQ3sNCzYEv8cyjeSs8eT51X4VsTYBZN6r380qXZdJFCPKga8Ifm5Q7LicudOgYiBu7 z73ikptRRoiWrC+eLMgg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: > Hi Michael, Hi Dmitry, > Not in Tramp, but I see an old change in VC that was most likely > informed by a performance problem in Tramp. > > See the commit a40c87a0093. It adds caching of the result of > vc-git-root to a VC property 'git-root' on the file name. This seems to be bug#11757. > Does the change below still make some scenario perceptibly slower? > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index b1880c0f7b..91554bb6d8 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1573,8 +1573,7 @@ vc-git-extra-menu > (defun vc-git-extra-status-menu () vc-git-extra-menu-map) > > (defun vc-git-root (file) > - (or (vc-file-getprop file 'git-root) > - (vc-file-setprop file 'git-root (vc-find-root file ".git")))) > + (vc-find-root file ".git")) > > ;; grep-compute-defaults autoloads grep. > (declare-function grep-read-regexp "grep" ()) I haven't tested. But this means to call process-file several times, it would be a performance degradation, for sure. Best regards, Michael. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2020 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.1603568588887 (code B ref 42966); Sat, 24 Oct 2020 19:44:01 +0000 Received: (at 42966) by debbugs.gnu.org; 24 Oct 2020 19:43:08 +0000 Received: from localhost ([127.0.0.1]:35163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWPRU-0000EF-G3 for submit@debbugs.gnu.org; Sat, 24 Oct 2020 15:43:08 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:36107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWPRR-0000DU-RR for 42966@debbugs.gnu.org; Sat, 24 Oct 2020 15:43:07 -0400 Received: by mail-ej1-f68.google.com with SMTP id w27so7383421ejb.3 for <42966@debbugs.gnu.org>; Sat, 24 Oct 2020 12:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZCDsTFgQtp8tB/s0gM9c9hoLVyNV30J1hSIpPpQSEM0=; b=P2BlYF1LXxsXh/sKsQ48DB+jynJKxehtZpyVlEnsRsI8Apy6ylTFFulb7luKi04c91 ygSqAqoL+Uy3L3ULgRyXvwCSoYoZQgR5wUysJ9Dfm8h20N/yx3LqsHqin0ldmKYVA1Af g5+GdziTF6h9aNnPxJ1qp/HZTfGkNtsORn/ya4jvgeYvB+xuQnrhRSN9ipgXVvpz0mbf Ma6NI/PbaAlIVyZjJ6lnFajLRKZ122ogNCh0sfAB2uCB1TC3+d29my5ae86zb+JYmSbD JquSeZ3NhRlW5sInAlZnWFA3q6nCN2TrMvWn+T3vv60cU6PRYGm7ZEhyu4Kczdkiz2BE 40lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZCDsTFgQtp8tB/s0gM9c9hoLVyNV30J1hSIpPpQSEM0=; b=i7jPw0gPg8QSvUNSz8UOSFjlNEAzL325RcaAiWvF006+5FhCLSHPtbulZJH/kzR5fx 0J1J6PCVtZbrUY1V0vYoPuccOV6FCyugVdvi/AOXK/Z/UmgEwQkI29RKsPKKvYl17IwH +LlkZGnXO0LOfpgLOlm5lo8ZYH8ag9j0iaaKkgnE5egK1t36GhZRbKYiLjXbqfbw4I3b auZnHorpJWRBTrbvisDEOcBqBMH5obIOpwmYs6p8o1zyxG97bcc1JL8spc9qfocgiCkN 4qIw8QHHvIBXU8xn5Z4WRO+nBYXSr1rrvNb+zY+etVDT/wOfevNKmfZPhSjDr9wpH8VK eOaQ== X-Gm-Message-State: AOAM530dovh6FLx3gez2rJfxGGGg6cRMGljZswup2ogouvQkOnIxdkix KyibuLc++9AFnEVFpCh8GKtpFG/SQQ94Hw== X-Google-Smtp-Source: ABdhPJzD0Jar4qUPGHCp/lA2nW9tea70czBVLpw6d2eJECOjJhwFdCQ0tAkkysPUCS542OddRsWfBg== X-Received: by 2002:a17:906:9483:: with SMTP id t3mr8575442ejx.390.1603568579642; Sat, 24 Oct 2020 12:42:59 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id i4sm2792826ejz.62.2020.10.24.12.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Oct 2020 12:42:58 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> From: Dmitry Gutov Message-ID: <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> Date: Sat, 24 Oct 2020 22:42:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87y2jvwxkd.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 24.10.2020 16:41, Michael Albinus wrote: > Dmitry Gutov writes: > >> Hi Michael, > > Hi Dmitry, > >> Not in Tramp, but I see an old change in VC that was most likely >> informed by a performance problem in Tramp. >> >> See the commit a40c87a0093. It adds caching of the result of >> vc-git-root to a VC property 'git-root' on the file name. > > This seems to be bug#11757. Huh. Looks familiar ;-) But that report was about process calls (and git.cmd being expensive), whereas vc-git-root doesn't call any external programs, it just traverses the filesystem. >> Does the change below still make some scenario perceptibly slower? >> >> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el >> index b1880c0f7b..91554bb6d8 100644 >> --- a/lisp/vc/vc-git.el >> +++ b/lisp/vc/vc-git.el >> @@ -1573,8 +1573,7 @@ vc-git-extra-menu >> (defun vc-git-extra-status-menu () vc-git-extra-menu-map) >> >> (defun vc-git-root (file) >> - (or (vc-file-getprop file 'git-root) >> - (vc-file-setprop file 'git-root (vc-find-root file ".git")))) >> + (vc-find-root file ".git")) >> >> ;; grep-compute-defaults autoloads grep. >> (declare-function grep-read-regexp "grep" ()) > > I haven't tested. But this means to call process-file several times, > it would be a performance degradation, for sure. Could you test it, please? AFAICT locate-dominating-file doesn't call process-file. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Oct 2020 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.16036481858200 (code B ref 42966); Sun, 25 Oct 2020 17:50:02 +0000 Received: (at 42966) by debbugs.gnu.org; 25 Oct 2020 17:49:45 +0000 Received: from localhost ([127.0.0.1]:37601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWk9J-00028B-C5 for submit@debbugs.gnu.org; Sun, 25 Oct 2020 13:49:45 -0400 Received: from mout.gmx.net ([212.227.15.18]:50503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWk9H-00027v-50 for 42966@debbugs.gnu.org; Sun, 25 Oct 2020 13:49:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603648176; bh=Gtin8g1qy5F6cjvQwhCdDubesGrcVVTNX4+zdPuc55I=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=V2GyaTXZeFWShsD11TptBXi6xsB+s0L5Nto2yry58R29J2nzL3Cs4/SRqZ8mkz3M8 KMVYQ8xQpP0ggy9pp8kOqG7nWe16U7NaQAMZUNld3r8vlEzFYv90VFzBSqyOqDVHoy hOXOK01KMxjSanVoMx8R1WxwRZOowHh/vzc4TtUw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.118.142]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mqs0R-1k1Tv71tK5-00mtoX; Sun, 25 Oct 2020 18:49:36 +0100 From: Michael Albinus References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> Date: Sun, 25 Oct 2020 18:49:35 +0100 In-Reply-To: <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> (Dmitry Gutov's message of "Sat, 24 Oct 2020 22:42:57 +0300") Message-ID: <87o8kqurf4.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:u1dVekRPRwcQAa7OW/cF/n9G4+1lPMvNwL2UnYzHUaSXhtq8yhm GALknqouby6Sqx9D+IUXEry1cnbOZ7QEDXSTxSc8Q/sOgNcd8EoXFK8x7CCE9LCEDbewCgW aXaHnCF2qneqNpHPocn6z8MO6qLMzwd9z6FQ1LpFtGg+NUPUsFjqRqYJpH5RXkZchREnlbh Leu1ihvxF7bIAY7Gb+pVA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XyWLdSXT8y8=:8+iIUy5nM7qmr4ZYI49Dwe S7I7AhYM8khkue7C+1nLCJiImv0a0X5lVBX61Tawl06AZfUDKuLE/ZrMBVvGXU81yQpFLh9hF QbiCG8zwpNPXuF5WooBmFB0OD1F7+DlKH7Gl7DGiKxoMi4djx76snT7jTC2zGRULBH2lK8sJQ imYInxjyp7uEfvy6q8kHjZry83bvOh+EhDGsJDaDbhDGR1nu/pIKyeT/z8iIdYAnXV/grXjcO mrifYF2fH9gRpLPBWHzTY0usjyo8HOzlo0OCFl8wI7mPACwUIAAmjvOwjC+sdO/w1HPGcB00V XTeMtMTasqbAPndZ6kbHkbwmKLgzp4DI1K0Pzcue6nV9GT3eA+SGAAfZ+dW+j4gnrQkyIWL2C CRNRlnl59DHGud03A94+bP8//02cJpmdmtc04J31O7GMbnwUD8OWu3DPQgU1iW9SK/QlvdZZo Mv3pgiYPkUw7oG0OZgobCE6j46McZdCSAKQ/FVDLF5fjWyrEMeCLbsl4AI12/BOSvtjlY5EoT s9of/n1MlKV/5iKTKplW7ohkaeTzoK9C7KbqmrJhe29Sp90tNy4jl+CntwJI1IUk3R6TxJWl6 ynCUWuPMa0yDZs44HNdlA+RH7Knssw26vraxTRdYUfded7eZlABcIAk/PE18BgIrglj0FYMl6 HQRWK9uaNebLSmZDLQ3bld0p8F97vny98qjJlnUf8DllpQz5QOnvE/ByRSb3TZCCpnpoILuBN 36IssaS8eDcXHvMZ6lcL/xSW8s2PzaIr6nl01SUbN2pQOLUOnwQjHIePTiE6DEmVZwUR7usvI xtzl/yIMCDw30LL6upI1fNKw88/APbLmPo9TA1aOpkFRs3pp2ydE+zNVn3EBVD8IHddrgpQaD PQEPAPGr+yncG3IwVTjw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: Hi Dmitry, >> I haven't tested. But this means to call process-file several times, >> it would be a performance degradation, for sure. > > Could you test it, please? > > AFAICT locate-dominating-file doesn't call process-file. I've tried benchmark over vc-registered and over vc-git-root, with and w/o that change. Results are similar. Best regards, Michael. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160372255316192 (code B ref 42966); Mon, 26 Oct 2020 14:30:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 14:29:13 +0000 Received: from localhost ([127.0.0.1]:40718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX3Un-0004D5-Hn for submit@debbugs.gnu.org; Mon, 26 Oct 2020 10:29:13 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:37391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX3Ul-0004Cr-Ol for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 10:29:12 -0400 Received: by mail-wm1-f44.google.com with SMTP id c16so12694053wmd.2 for <42966@debbugs.gnu.org>; Mon, 26 Oct 2020 07:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CZadaQqgk7oPjMBhukAd5UhFVWbpt73KjXQ/MZeys1o=; b=cHMW+fg7JsXSfhdJaxioM+eO9LrSTmRu8jVoFAJxLGbJW58yqV9HzpFMGZx/D1H/mJ 9kWUYORuGAjDr3tg1fucsENr2GaxBnFxwUVYvPvDKZvLTdC1WjQ6zHMVfUELywBsAbho gEe1HfuzfXthbTPz8EZIlzd0wTYTNOpo5x0Jpmu871bTVmo3nJVKVpNYfF4Ca0/pWs+v NJnIAoopVtZ47hLESkqxQ5UH1ydwlzeZuAkwmXdON2zQKlEBIgHjbWeG1Ym5xvZDppmG XmI4UXOSULpgrPmGe52dIFXq1lu8/L7v/Fu6Zh3w5Qs6qNO6NcxjUtj6/FgNff84atoS I7xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CZadaQqgk7oPjMBhukAd5UhFVWbpt73KjXQ/MZeys1o=; b=U481m38GXTFV1R35WQhY4AlA/fAZSVAwaXLj90jeiSJ4uT9hF6Un2ZtVhYn6JWTVrz tleXrxD4ihjFHmT0kTVPZwgp5IhQl8LWHMIpmmKUF2qK2nYtxq87K/kCBqjjM4E3k/qJ vW6OrVosGWMUGHZA1FOkQyHiBk9W99L8h8cgblFoFKDB/iVJXHznWdNN+IQI1nyHqkVu voWMUsrdz7b6FPdg4SsbKLaqi3zkeHcI5hoKnu4HKh35W+PSMZx5Fk5i8TCVxGc2+ktw wu3fUrq7YR1O+Xkf5WZ0vLE21A2QrWXjhNdoNxO13QjO4lmHLnHrZswwJUkgfnQoQWbD Z2xA== X-Gm-Message-State: AOAM5326S2jH5GGqmxML5Phmt62p0JKAxjuVEnjSPsflxRZ+Fptuk6dM dRbb1l6c2cgFgIdlmbgGjpRlMMzACwDxRg== X-Google-Smtp-Source: ABdhPJwYQMcuZHnssPsVCO9ZOuSvuDaGEB/r/FSgejQ/6842+B8L6dH2kGJ+PRKgrPA4zo90SrCBUQ== X-Received: by 2002:a7b:c8d1:: with SMTP id f17mr16298838wml.30.1603722545678; Mon, 26 Oct 2020 07:29:05 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id y206sm22764051wmd.34.2020.10.26.07.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 07:29:04 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> From: Dmitry Gutov Message-ID: <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> Date: Mon, 26 Oct 2020 16:29:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87o8kqurf4.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hi Michael, On 25.10.2020 19:49, Michael Albinus wrote: > I've tried benchmark over vc-registered and over vc-git-root, with and > w/o that change. Results are similar. So, we can safely apply that change? From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160372546229035 (code B ref 42966); Mon, 26 Oct 2020 15:18:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 15:17:42 +0000 Received: from localhost ([127.0.0.1]:40798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX4Fh-0007YF-Pi for submit@debbugs.gnu.org; Mon, 26 Oct 2020 11:17:41 -0400 Received: from mout.gmx.net ([212.227.17.21]:34877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX4Ff-0007Y0-GO for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 11:17:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603725453; bh=LfmsKPms5aNXh+U4QTgui9w4iTcet6BvmVXg895CaSw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Fq0Spce/7Y6PFkzKUqrntb54GpnxfpJWeiutEZo3HWNWdvK/WrWJuvlAD7QPYLOyH EOPqncAygT/LRA2m46kUrXoaBy36Sm8pikQslyIahgC70pgin9p6k+Uq0vUapcMAmV smE9fex6cksMvBFPnVf8P6FY76czbiUWDRxXEKO8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.197]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBDj4-1kgNed1Smc-00ClOz; Mon, 26 Oct 2020 16:17:33 +0100 From: Michael Albinus References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> Date: Mon, 26 Oct 2020 16:17:32 +0100 In-Reply-To: <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> (Dmitry Gutov's message of "Mon, 26 Oct 2020 16:29:03 +0200") Message-ID: <87eelluicz.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:5RzsQgdfalSzwad1+qgrB0CNQQSyHmrDlbxg7qmWJ6A5L7/E+lR CLeRqZCkpXN9voUQJ2N6ZWv0wT7PsuJ8P5JtCzbzl5/PXlV1oW0xHa6x5c48qOJkltJ82Vx cVmlN4vp32K3YIr6hYP2CXaByHzDVGHaBbalhIB6nsNmYIOo4jAXHFarWBcMsLRR35H/x4A fo7wZBlEO/0Hhk/4eM7nA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KRHvb85qJqs=:3GqG3mSpTV6lNvQxDWibdV 6uFnZjM4OVj1Pd9OtWMzRIYLqe8vvn/fBeijDv6PSry6a9etK7snltJbSeggLt3/whjkzotIm +o+bkcYmhVQwNwrC5N14OyCtKN5oEMHr0j6JBERADRmhGTgDBpmws6wTjpvDMqv5ZYVSUdAOb Fsl7yfiyq6NxXL8GD+wLky1zuF0Xel2msZFyrFnn1NtRPnVK1sQnXTeNMfaak/4nRyJ2w1BAz cLr54JVSLZIH2OcROQBx4GRyYP7tUItzntGdsKdE3wxQymIJqlkX94UDvclbQ/eFjvqdwW3Yx CuQaAsvETCdafY0y8AzakX2ZUhb/F4feyTSe2OMD7nx/lK6oa0jRUSwMM6Zf5NP0svLUL4iEI 3sHOPQJ/EF5Ers0LwHMggAWg9HSZo2vvtVZ67daBVX4fcR/KqeJRkTJApwfSu1XOrz1KAOUiY l4aLCU0a92+IFgN+Qs72HUC0B7xnlYqjV4NrvIbo6K2ZTUsZiAeCkwXn2i6GKVFtqxEFW6mk8 p9ry12M1m2BiNyDpYbsqLp0UTGhw47RXnv7TsqM6NKvnJkqD7cgsTnB3Yo7ktfy8MwetSXGhC 1B3QXT4dY6iH8zp2ND7SSF2SgLi/Rd/f0cOEduVuHXSai4f2JlfGuVCSY7Y4MEZ5/jq+J3Vg6 grNRChKof8idyTzX1lrnePRlzjmIigo4gPPk+v9xZbq7gepyUrNHsuXmNNdBweF9hv6HAl8Oy /87tPMSeH/CXhzoPqEk3QHk9011mWEweTVCxBAVi47FqS6qehb6xl9krvqScU9ZXcc+wrvQwb BnYgsXL+NA5XdT4Ht+DzATiT2Ykss5KXs9FCw47fCBJM64MaeT/A7fjbq7+dnagLoI997Pl8Q kh7YWqyhHdvoGSnmdLsg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: > Hi Michael, Hi Dmitry, >> I've tried benchmark over vc-registered and over vc-git-root, with and >> w/o that change. Results are similar. > > So, we can safely apply that change? I don't know whether we can apply it "safely". But I agree we shall do it. And then, we will observe, whether there are regression reports. Best regards, Michael. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: (no subject) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Sam Steingold , 42966@debbugs.gnu.org, Dmitry Gutov Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.16037431332007 (code B ref 42966); Mon, 26 Oct 2020 20:13:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 20:12:13 +0000 Received: from localhost ([127.0.0.1]:41488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8qj-0000WJ-75 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 16:12:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8qh-0000W2-0u for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 16:12:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Cc:To:From:Sender:Reply-To:Subject:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wtt0W/93gMaRZNz2m96mDt0Uy7Av6j9+vLmLc07cfGE=; b=R8zeRh2u06GzHENNYp+fESx4A+ phy8cCjTrP+Tw/0ONQx6CX4og+Z5QkaF7It9QcapSKGQMWrh6Np55MzU99o6X0Ig+R6tqyUm2MMXk ZTN2BDQEhmY1nCAOyi2gNE3NyYdDLDNW5SOA7v+QRczhuDX635jHrjEE6lkeCHXbEoFU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX8qX-0005Ib-Vp; Mon, 26 Oct 2020 21:12:04 +0100 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> <87eelluicz.fsf@gmx.de> X-Now-Playing: Neil Young's _The Times_: "Lookin' for a Leader 2020" Date: Mon, 26 Oct 2020 21:12:00 +0100 In-Reply-To: <87eelluicz.fsf@gmx.de> (Michael Albinus's message of "Mon, 26 Oct 2020 16:17:32 +0100") Message-ID: <87a6w8wxv3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. OK; I've now pushed the change. Content analysis details: (-1.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 1.8 MISSING_SUBJECT Missing Subject: header X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Michael Albinus writes: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. OK; I've now pushed the change. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [95.216.78.240 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Michael Albinus writes: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. OK; I've now pushed the change. There was some discussion about implementing this "inside out", which sounds like a good idea, but would mainly be a performance tweak. So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 16:12:20 2020 Received: (at control) by debbugs.gnu.org; 26 Oct 2020 20:12:20 +0000 Received: from localhost ([127.0.0.1]:41491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8qq-0000Wd-GP for submit@debbugs.gnu.org; Mon, 26 Oct 2020 16:12:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8qn-0000WH-Ph for control@debbugs.gnu.org; Mon, 26 Oct 2020 16:12:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J/PrQ0vnKjWL1SpYHEtRnqzkvUtSxOgw9YZ2tG5rY5k=; b=Bl5jl7awCbdU90ntiBHqQwy7RK Uu3xss7bjrif/pCtlQB38KtsHV/5vDh/r3Za/p7SPlnXJIciZsj8eKwTsDwz9+1CBOfTeS8FTj1vI Od610vy9M26LNa6Jj1ZA5Y2MbYYJvFFPljstLwH3E+54G5Z/5qpTZoVB0cM8yGBa4l6M=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX8qg-0005Ir-5p for control@debbugs.gnu.org; Mon, 26 Oct 2020 21:12:12 +0100 Date: Mon, 26 Oct 2020 21:12:08 +0100 Message-Id: <878sbswxuv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #42966 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 42966 fixed close 42966 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 42966 fixed close 42966 28.1 quit From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: (no subject) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Michael Albinus Cc: Sam Steingold , 42966@debbugs.gnu.org, Dmitry Gutov Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.16037432002185 (code B ref 42966); Mon, 26 Oct 2020 20:14:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 20:13:20 +0000 Received: from localhost ([127.0.0.1]:41504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8rn-0000ZB-QJ for submit@debbugs.gnu.org; Mon, 26 Oct 2020 16:13:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8rj-0000Yt-SV for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 16:13:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Cc:To:From:Sender:Reply-To:Subject:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=whJLTPa31Q8gb4mivybx1yThT/0K76SneDVjKRGM2Ac=; b=kIe+6b7sfTSxIyz59l40qhwm3b 9IkgtrLsX/Boq7waNy8HELiCHH+RwNFC0fRHs2mAmErBnneiHwL5IqFIfsEmq3VuHubtCPOp1j8sW KH75ujfPZ66NdIey67xKdUdVOCvuO9n2YgcdfATchiZyelO5c0U5HGMG7AbNrbEWtXmc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX8rb-0005JE-AK; Mon, 26 Oct 2020 21:13:10 +0100 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> <87eelluicz.fsf@gmx.de> X-Now-Playing: Neil Young's _The Times_: "Lookin' for a Leader 2020" Date: Mon, 26 Oct 2020 21:13:06 +0100 In-Reply-To: <87eelluicz.fsf@gmx.de> (Michael Albinus's message of "Mon, 26 Oct 2020 16:17:32 +0100") Message-ID: <874kmgwxt9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. Oops; you were talking about the other cache patch here, not my proposed patch. Oh, well. Content analysis details: (-1.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 1.8 MISSING_SUBJECT Missing Subject: header X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Michael Albinus writes: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. Oops; you were talking about the other cache patch here, not my proposed patch. Oh, well. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [95.216.78.240 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Michael Albinus writes: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. Oops; you were talking about the other cache patch here, not my proposed patch. Oh, well. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 16:14:41 2020 Received: (at control) by debbugs.gnu.org; 26 Oct 2020 20:14:41 +0000 Received: from localhost ([127.0.0.1]:41523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8t6-0000cT-Uv for submit@debbugs.gnu.org; Mon, 26 Oct 2020 16:14:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8t2-0000bz-2U for control@debbugs.gnu.org; Mon, 26 Oct 2020 16:14:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CDHcNPAss6lqSekRUJFw8csXGFiPTaguppZi3Ow0vbw=; b=SVdKWslV/6n2IWx7OyZYLex+Q1 54TqXEGMcrzt4+KVaqlZ2+TIeba5uXsguQVll0pIxDLneKtw6u0ee876znVSF5lWjjveUrCEWUVqf L3r4ZrBxVBr4xrzgKF5+dsiVvgESyaghY5R3J4JRtkp0fKsi6RVoGqy2RsiN8DBpagmk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX8su-0005K6-DZ for control@debbugs.gnu.org; Mon, 26 Oct 2020 21:14:30 +0100 Date: Mon, 26 Oct 2020 21:14:27 +0100 Message-Id: <87y2jsvj6k.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #3807 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 3807 fixed close 3807 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 3807 fixed close 3807 28.1 quit From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen , Michael Albinus Cc: Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374574530933 (code B ref 42966); Mon, 26 Oct 2020 20:56:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 20:55:45 +0000 Received: from localhost ([127.0.0.1]:41614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9Wr-00082r-9A for submit@debbugs.gnu.org; Mon, 26 Oct 2020 16:55:45 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9Wp-00082X-HE for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 16:55:43 -0400 Received: by mail-wr1-f41.google.com with SMTP id n15so14408295wrq.2 for <42966@debbugs.gnu.org>; Mon, 26 Oct 2020 13:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WKNoOWkc9puQvHLTfb657seRBG/Lf4vKe03EgyzwA+A=; b=nVfY8/2WZNG0Sr4g2sORIRq9U/RgHQPhAU5/sYNcmltVwxsMTHmECaAkms/R90NNUA P87LNOtxVOxRZ8F62Rd/nHeoEDQVyqn9spS5psiqi1o3QHn1j/5nuHnKHwGtdE+FZK7O JBkCJpCpDAdJJDDzbLQ+kvXNNWW+9xYZzt6MFQ+TE5fORAKlHH8x6iE8mNBZBAQ1e76E UVeq+3nq6qDiiVqDzoE+lfFaaOAlSibb6nC8dXBd+NI0mg3EPjV4jmzVjWusQA+fDJ/1 e6BOvGLe4EO4QbuGH/B/3VZTtzdM+HA227Qw9YeO8KLAeeSbGZPD/snGKX/HTaU1s+FN iAeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WKNoOWkc9puQvHLTfb657seRBG/Lf4vKe03EgyzwA+A=; b=WXZSV8pU3kLe4qgbhR3vbjD5lXAsILxsKQpmlz3IRDHTdVu393Cro/ljecqpLa8/ic wJtQFJ3bTJ+mMsGIY22+SwE8XwDaNR4H7nzj3DaxscJSBkzLr37/8hiCVCuAWsCskV1S QNg9uRS0RixjGv86D9jEZlVidW47asd18WCkhfG/IK5IDADJ2dXdWHRs+aQfgr5wF6o2 sMGvUI3kuu55zxUSt7JDkf2bQ1wqO2LdJ9mwjF1Ot9M6nOKn6PQR/pFwM2iHDt09DgSM w0o1Kb+NiSbE94xcz3Jg3BYrDh0hTZcg1ayX++ktaV1gwo9gBWmpf4dQiLdRjDTK7kAj zetA== X-Gm-Message-State: AOAM530b2D1SpsLOBLnBpcFVQpBZmaiXmNV/gYcgQjgDnNuvyDiUlxQy nevfn1z3/v7es2VkHSH/n7CpZAgbKNVhWg== X-Google-Smtp-Source: ABdhPJzyQ4SIB2k2QGpQflp+dATt9A4aPvsqmXHrs1tURTe6TMYZOU/SLINZE/YVxE3fZGJrh59WFg== X-Received: by 2002:adf:f3d2:: with SMTP id g18mr19627744wrp.367.1603745737315; Mon, 26 Oct 2020 13:55:37 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id v123sm21184176wme.7.2020.10.26.13.55.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 13:55:36 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> <87eelluicz.fsf@gmx.de> <874kmgwxt9.fsf@gnus.org> From: Dmitry Gutov Message-ID: <10a8d7cd-2b67-10aa-da1f-7c380b1f1828@yandex.ru> Date: Mon, 26 Oct 2020 22:55:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874kmgwxt9.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 26.10.2020 22:13, Lars Ingebrigtsen wrote: > Oops; you were talking about the other cache patch here, not my proposed > patch. Oh, well. Yes, it was a side investigation to clear up the irregularity in your testing. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Dmitry Gutov Cc: 42966@debbugs.gnu.org, Sam Steingold , Michael Albinus Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374614531671 (code B ref 42966); Mon, 26 Oct 2020 21:03:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 21:02:25 +0000 Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9dJ-0008El-A0 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:02:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9dH-0008EZ-Gz for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 17:02:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E/wLGQfBA8Aoz5LTCk/D0C9bDfQYE/DKaSF5p4ZRi8c=; b=uPsKh7EbCiM0l3QOyPUNRQBZaw /iaPz3ZDL1GMvTCupKFZ9ZbLSBUpzygxqYudfVzj/YHy71IgaquxijReIG+LIOD7HH3/OH/MMSz74 GgXK7APKAG1yPowQU3NP6F//dtBeNmmrBjg1vSlMZLjvseXKlTC5G0ZA0y6eN+wJoq70=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX9d8-0005lP-3A; Mon, 26 Oct 2020 22:02:17 +0100 From: Lars Ingebrigtsen References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> <87eelluicz.fsf@gmx.de> <874kmgwxt9.fsf@gnus.org> <10a8d7cd-2b67-10aa-da1f-7c380b1f1828@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWdypd5tIRkoHEY JSX////pchdQAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKGRAuK509oJwAAAGxSURBVDjLdZNhouMg CITFEwC9gOAFXsP977YDatLX3bXNj/g5DCBpJNJIWiNuTZjaXtSUiJS6sxiz5Q4vrIJtISEWlgHd ESVQuV+f5aLqBZjXjsE1FQZkfMxXqHy0pXn7e8EDv/8BhKUhYiOL4lWUZ6gsEek2rjq2wlyhUN0K 6rzMvTyQsaBAIyb0SAqYQrEAKmE5AJtproIw4r4KKoB3PM4wnxFhv8wdP6gil/xSkELxKjBOE/eC Yha4Tq+QxlbEDUpheRrpGiyuJPd9VFb5jyEOwF8KeLPofADalHUU4A/FThf90OAUPEALoH1h5T4O oG0uIfEDyc/dkjJHgeExAN6rwBxQ5ey1vIa0BVaovj2aDu5xgzVwWYejpGzwew+cYBjW7PZhrycr WOMsrTtXnx+gmo6s3KZks95y98prhFzmyMu69vi40BaZX3W7V0nCEfdco8e+LHwY955i23xuFA/I 488+gGT0HCC83bEKoA7MYsfh+QmQJnWrO415fYSy9blVzX7FA6jVJ1tBtuA6CnSz+3yibI+GMZTu 8bWQFSGrf4Icqn4CPZVjPBBK57fiDzF0aGQ0w9opAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEw LTI1VDE2OjQ2OjQyKzAwOjAwVGYy2AAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMC0yNVQxNjo0 Njo0MiswMDowMCU7imQAAAAASUVORK5CYII= X-Now-Playing: Blaine Reiniger's _Songs From The Rain Palace_: "Pere Lachaise" Date: Mon, 26 Oct 2020 22:02:12 +0100 In-Reply-To: <10a8d7cd-2b67-10aa-da1f-7c380b1f1828@yandex.ru> (Dmitry Gutov's message of "Mon, 26 Oct 2020 22:55:34 +0200") Message-ID: <875z6wvgyz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 26.10.2020 22:13, Lars Ingebrigtsen wrote: >> Oops; you were talking about the other cache patch here, not my proposed >> patch. Oh, well. > > Yes, it was a side investigation to clear up the irr [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 26.10.2020 22:13, Lars Ingebrigtsen wrote: >> Oops; you were talking about the other cache patch here, not my proposed >> patch. Oh, well. > > Yes, it was a side investigation to clear up the irregularity in your > testing. I guess we'll find out if my patch leads to performance regressions now, then. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Michael Albinus Cc: Lars Ingebrigtsen , Sam Steingold , 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374671232583 (code B ref 42966); Mon, 26 Oct 2020 21:12:01 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 21:11:52 +0000 Received: from localhost ([127.0.0.1]:41667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9mR-0008TT-Rt for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:11:52 -0400 Received: from mail-ej1-f50.google.com ([209.85.218.50]:40848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9mQ-0008TH-Or for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 17:11:51 -0400 Received: by mail-ej1-f50.google.com with SMTP id z5so15833751ejw.7 for <42966@debbugs.gnu.org>; Mon, 26 Oct 2020 14:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3bBO5tOcJoSA+ErurymaUBoSoroEwyKgd66rfMMotSk=; b=NUGFsSLr1lQMnVYCh2zp5/WOR1p1vJni6zZZ2jO31Vyyl4W3z+U7gHbfZ8EsuksLer XUsTfTuEDcaJCtSbE+61N2MpfYSpWLMqXVxTqi40YY4B3oZW9VFaKQhPxlRyWD8/xK7E 7qcDJ1kWCv4mf7CxUmX3VgkP8q+0mYTgFAtamki4L80FBvLGce1475hTPGt0S57RRj95 fxQEJhbrnumUedYRGw7EQ6vbuuLU8xXNGRzABufkPc0nnCDKPtoAUI1ehDWkEf0gwFJX 7BD40PcCnUXTrlZGvTChMJpXXfkf6IjEwxAJb24OtjTPwJBT4lDc8G85/SpvP8S376rP v1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3bBO5tOcJoSA+ErurymaUBoSoroEwyKgd66rfMMotSk=; b=Ftfs/+TxNJvkEZG0400Jytz7j4cupd4cjrIGvZKputA9yNNizsSwptByvY02P/ochM 2AwpEyn3iYKwOQU5Tw0R9C1txDZLHEbGH6FwJ06nP4pOqDZAyGGnFfGew0kU7b4NoktG OKRE5qyElFJ3AW3mPG1PkpL32OHytRmJNaHDEpShlFjArvVD7vIxsAUyiD0j8MFvt17I 5hmO0z9A6kxxAycy30CvmSTW+djbB4n7kfDZW5n0lqzNaj91RSDRKIf3T3h8pUxFX6mo GjxJnEnoGU0w3up0L26DCwVbN0fokmxTuQk/1KMB6ghV01hQQHU7cI4BjE1M9j2GlDTR sp7g== X-Gm-Message-State: AOAM530ba6u9lNmder5dhG3XuYRG2i9L2rOjN9AtCRTidMbJUJi2IJqD E7whaOHxIvAYlrNSry1SqL/V9CwxSaf/bw== X-Google-Smtp-Source: ABdhPJyi4dLONgR057Fj/swGR1aZPabdhnI6JS0plAXvAh6dMscbNyp8VUzcW4w0XGBhMe5uOC6Lcg== X-Received: by 2002:a17:907:2090:: with SMTP id pv16mr17250222ejb.506.1603746704804; Mon, 26 Oct 2020 14:11:44 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id g23sm5799058edp.33.2020.10.26.14.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 14:11:44 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> <87eelluicz.fsf@gmx.de> From: Dmitry Gutov Message-ID: <0e30364a-1bb1-5c22-1009-453458d2d161@yandex.ru> Date: Mon, 26 Oct 2020 23:11:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87eelluicz.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 26.10.2020 17:17, Michael Albinus wrote: > I don't know whether we can apply it "safely". But I agree we shall do > it. And then, we will observe, whether there are regression reports. And done. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: 42966@debbugs.gnu.org, Sam Steingold , Michael Albinus Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374870712167 (code B ref 42966); Mon, 26 Oct 2020 21:46:01 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 21:45:07 +0000 Received: from localhost ([127.0.0.1]:41744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAId-00039t-H5 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:45:07 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:36827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAIb-00032x-Q5 for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 17:45:06 -0400 Received: by mail-wm1-f44.google.com with SMTP id e2so13996400wme.1 for <42966@debbugs.gnu.org>; Mon, 26 Oct 2020 14:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CTBmOsnPbdbMYJx2U03ca4zHPCjqp30a3dFTRpAzpdg=; b=lx+QH1hCMv46nHxIIpNEAl2YXzVyjAfq/xbIemgI21rhDnBs0JM1WmTtNrxiJRqiHw p3fge41t7JT8H9up82jF+ltlbhDwc9BFE67AlH1HSoZwpwyhCtU3x43FBdgWUHu/tgzt 9U4ukFwREayVPGdMq7buPhrXH2CPCDgG2uBhEGtEgFvuL9kwCNAfNFWkjag73Ql35ZMd zoZX8z6gBMkYlUgveilYcs/bJjB7zG3rxOrGQqqpL8jDsAxD5AvnJ1ewU8wHg7fI6IkF KkQIteIG5L2JuM7zRfKrMHupBm45nNLk9vE+JNIyAv4+j6/f6egzdb2+QpYjyakFZke2 WzEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CTBmOsnPbdbMYJx2U03ca4zHPCjqp30a3dFTRpAzpdg=; b=KCsBCszrKWqzI7kPGFl946W9dba8frQjy3jPKKYw5Uy4VKCMjpLVH5/0k21sFUESNP eJkcYN561w6oDmnKwZQsDZmHpHKNtiVhjjCC5Hz0aQUx1DeecqswVIEG+2kcmjWSFfmc d/jBUY88BRB1FAL7vmebPeMSVZv0XC7tEjTp2/t+nlg1vXH4g4J8z7Avo0GII+GrODP3 qCTHMfUX2nqgyTjEIkNkdG0obM2g7IkbYwW6IJChgs4y8J2CVoqj0I3qnElWumQDFlh0 ql1S0tnE0wpkTn978te0QwyMc/fZRBJ8GF5GXkO8+ZMPvOk5JtlZfpMlJXTlH4cCFpoy HJlw== X-Gm-Message-State: AOAM533VBYYVXj8PudtNTVe3pTlrBMyLiUhTfTAehzUnam95D8j8e+88 VzuarIm9zTO1JuJVxlyZcoEaIYxIQJZWDQ== X-Google-Smtp-Source: ABdhPJzZi5G3b6Lyh9ZeecGRZeLmLR/58WmZ0TnTenexmVMrgutXJTgFHsd755jWb2T+0fWn2niXug== X-Received: by 2002:a1c:c906:: with SMTP id f6mr18995343wmb.9.1603748699655; Mon, 26 Oct 2020 14:44:59 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id t7sm23589163wrx.42.2020.10.26.14.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 14:44:58 -0700 (PDT) References: <87d01imtwl.fsf@gnus.org> <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> <87v9fa44im.fsf@gnus.org> <1e9908c7-337d-9790-cd37-5232bc04233c@yandex.ru> <875z79z5mw.fsf@gnus.org> <52df0404-979f-872b-a60e-5259c0893f15@yandex.ru> <87wnzonful.fsf@gmx.de> <87y2jvwxkd.fsf@gmx.de> <057dedcd-8f2f-615e-f660-389b9013336a@yandex.ru> <87o8kqurf4.fsf@gmx.de> <40bfcc66-dd6e-1acd-4236-c3a6723ce6c7@yandex.ru> <87eelluicz.fsf@gmx.de> <874kmgwxt9.fsf@gnus.org> <10a8d7cd-2b67-10aa-da1f-7c380b1f1828@yandex.ru> <875z6wvgyz.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Mon, 26 Oct 2020 23:44:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z6wvgyz.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 26.10.2020 23:02, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 26.10.2020 22:13, Lars Ingebrigtsen wrote: >>> Oops; you were talking about the other cache patch here, not my proposed >>> patch. Oh, well. >> >> Yes, it was a side investigation to clear up the irregularity in your >> testing. > > I guess we'll find out if my patch leads to performance regressions now, > then. :-) Yeah, all right. In my testing locally it's fast enough (1000 iterations is plenty). I'd test with an actual remote host, though: when the ping is >100ms (a regular occurrence in my life: ping 8.8.8.8 is 73ms, though I don't often use Tramp), the cost of one process call would look different. But anyway, if Michael doesn't object to this change, I definitely won't argue. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend In-Reply-To: Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Dmitry Gutov Cc: Lars Ingebrigtsen , sds@gnu.org, 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374926720886 (code B ref 42966); Mon, 26 Oct 2020 21:55:01 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 21:54:27 +0000 Received: from localhost ([127.0.0.1]:41781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXARf-0005Qo-5i for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:54:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXARe-0005Qb-1T for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 17:54:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36023) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXARY-0003jZ-Gy; Mon, 26 Oct 2020 17:54:20 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kXARX-0004gL-OG; Mon, 26 Oct 2020 17:54:19 -0400 From: Glenn Morris References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> X-Spook: AMEMB Domestic security Failure Tehrik-i-Taliban Pakistan X-Ran: .3=0&K=6B,^T}GX\xg*$q7Op/v0P(-Y$8%[q)&$1A*(7(F:(>T)>RH% User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov wrote: >> That makes sense, but it's just a performance hack, isn't it? The >> result should be the same as the less invasive "loop over all the >> backends and collect the most specific one". > > Pretty much. Except it should naturally limit the traversal up the > directory tree, so it feels like a good architecture, not just a > "hack". Indeed, it just seems like the Right Thing to Do, not a hack. Not having been paying attention, I was surprised to see the adopted solution goes for "loop over every VC backend, and every directory up the tree, then filter the results", rather than "walk up the directory tree, stopping when a backend claims responsibility". I would think efficiency matters in such a frequent operation. As a (completely unscientific) data point, my first single core bootstrap build after this change took about 5% longer than before (22m5s v 21m4s). But of course a single measurement means nothing. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Glenn Morris Cc: sds@gnu.org, 42966@debbugs.gnu.org, Dmitry Gutov Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374954021376 (code B ref 42966); Mon, 26 Oct 2020 21:59:01 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 21:59:00 +0000 Received: from localhost ([127.0.0.1]:41801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAW3-0005Yi-NH for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:58:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAW2-0005YS-82 for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 17:58:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ztQHOTAHWaUtyRrKiEg1sHcJJEKKaQIEYyEHZjLnn9Y=; b=O4b68Bz4p/d0RaireiIcuVQ2pg YkxJIAZPpRYUTT9eKE1/DR6Y3vl4ArJP0GVfLaGUWfmjiZv32RM7E9kBgLRi30Hpd1vIkpZfPZnyR Q54U7s5/3EoPUZwxjkcz256QrK/PMFkJt+xwAwtKYCBOav9pg/szD/U4yqgD6dvOEHwk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXAVs-0006Rj-8D; Mon, 26 Oct 2020 22:58:51 +0100 From: Lars Ingebrigtsen References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEU6KhyiYCTRlCl9 ik3///+AXhrdAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKGRIVJDK0hlsAAAGBSURBVDjLdVMBkoMw CAT9AOAHGvoBNf//2y3ERHPe0ZnWZlkgu0gUoapW8KVCV2j7Ye1xnXPPwIm5lzdgyg7ARqkeTBwM khdCyVB6UzQBmRCJ6RrjnqsBKnGekN8UFuYYNkLNbeQHPS6dFzEftaIu44Mz9PABsEW2JODBkgdB WbTN6zfDUlQAV3sv0gGLe7EiO0kd0EP9aJK3gbsnuulZ0SVNSWA0t63iIiJL3GICyhFsYYjLhZ/j xh/+sAfxAVi6gPwSBYeEaPgFH4liYzkaYGchWqG9TzZxM4cLlE9rHm7kohUICMmWe+U2S68hDirq o3kJFSAW2Wefmi8hIm8LxfYCvxG0FP0KmUyLKIq/ekBs0+c5APSwuqPSvIXNhcoHFHl2IHdLb/T0 J2MlbEF7PKdS+/34q/etmfk/wFjntV5G9a3wzwT49UrwVy+gXgzRNv1Wx6StdkmC0JYTrmPOVon7 a7nWThQNw1le72tulTC9As0z9wX1CsPUdV//TOjxA3KlKy2pWrTWAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIwLTEwLTI1VDE4OjIxOjM2KzAwOjAwWmPCWAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0x MC0yNVQxODoyMTozNiswMDowMCs+euQAAAAASUVORK5CYII= X-Now-Playing: Prince's _Sign 'O' the Times (1)_: "Slow Love" Date: Mon, 26 Oct 2020 22:58:46 +0100 In-Reply-To: (Glenn Morris's message of "Mon, 26 Oct 2020 17:54:19 -0400") Message-ID: <871rhktzs9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > Indeed, it just seems like the Right Thing to Do, not a hack. > Not having been paying attention, I was surprised to see the adopted solution > goes for "loop over every VC backend, and every direct [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Indeed, it just seems like the Right Thing to Do, not a hack. > Not having been paying attention, I was surprised to see the adopted solution > goes for "loop over every VC backend, and every directory up the tree, > then filter the results", rather than "walk up the directory tree, > stopping when a backend claims responsibility". That would be the natural thing to do, but would be an incompatible interface change. (Only important for out-of-tree backends, though.) And it would require tweaking a handful of the in-tree backends; see the overview I posted the other week, but it didn't look complicated. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Glenn Morris Cc: Lars Ingebrigtsen , sds@gnu.org, 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160375027830865 (code B ref 42966); Mon, 26 Oct 2020 22:12:01 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 22:11:18 +0000 Received: from localhost ([127.0.0.1]:41823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAhy-00081l-11 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 18:11:18 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:42190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAhw-00081V-Ib for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 18:11:16 -0400 Received: by mail-ed1-f49.google.com with SMTP id v19so11305224edx.9 for <42966@debbugs.gnu.org>; Mon, 26 Oct 2020 15:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W8TpQA6DA5mqc9CrfDEPpT1P+dgWzQcQf5N/VRzdjs4=; b=SzowyJ6qSS3ookf8JsnzIph4nzykIJgqEJ7JIBvnYiXr3WT5dyyPRGF54OsryATJCC 3SojDuIJlr6eotVaD7Any4jpIM0+7vEWZoxXOZFlHYTrQ8/PCw9TZ05JFKm2AlSdMN9p AuuNGMfhgrJLumTOj06Z7D+BWpTEqAMrvCcRkvLYJ4+6dQyuOsOWCdf9pIm8NvNgJZD1 zqqbWrssw/9qUQ5vDVBs7oKYYr5A6dlKtMZZwc4QR8MyUKsuR1ZTeX3Wq1dhZbQkkNK9 L+bYzHMQzm9FnqtjwcJvgdL6SVdZEe5fUk6L4qzAlXEoyt7XI8s2tUbNqoPRzqCdLDFL H1xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W8TpQA6DA5mqc9CrfDEPpT1P+dgWzQcQf5N/VRzdjs4=; b=DkAOQ0MJDjVWqDsRZH+o2PTgAy+rHM+OtKKoRNFt/qjpy0YkWpo+S/taMY25KCwk2f zskrMkKATw7UT6aB4CwwiM14MJ3SDpAj4+OhNY5PortM0ArBZCRBfzGVGIDLEbfDd1bE xhRahbJbdJ5yUDAl6CMohIE2uFwGdqwY04rb1cSAjMS4O3TRMHfy4xHavrBQDNmWqcOW SNj2sXiOIc/D9ZIudDvGuZJLIERUZZFeWmQpF/uiKVC9TRX42g/rbJ7SVWbdXbfUoQ9f F9ESoyAEsTTeKVmRB8wA/NJOv4NN0tRMPpvEzw6Rq3aipwlsSyQJRJlGMB19RNk2JPb9 dWrQ== X-Gm-Message-State: AOAM532Ws/96qsFhSJ5cmEoS2bs12IIQ20G6xyV3msc7P8srP39b/yIN CbCEtxeAoS//DeR2FZknvsaPjaltLluaMw== X-Google-Smtp-Source: ABdhPJzMEnpmE+Vm49UwrFNkkwOeCT0abMR9q8ZdsdULG764iQfVFMs2tiFajPitKGRluvYuUXUF3Q== X-Received: by 2002:aa7:d658:: with SMTP id v24mr14670802edr.327.1603750270224; Mon, 26 Oct 2020 15:11:10 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id i14sm6538393ejp.2.2020.10.26.15.11.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 15:11:09 -0700 (PDT) References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> From: Dmitry Gutov Message-ID: <29720047-f8e3-e2aa-076c-2743a46c0925@yandex.ru> Date: Tue, 27 Oct 2020 00:11:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 26.10.2020 23:54, Glenn Morris wrote: > Dmitry Gutov wrote: > >>> That makes sense, but it's just a performance hack, isn't it? The >>> result should be the same as the less invasive "loop over all the >>> backends and collect the most specific one". >> >> Pretty much. Except it should naturally limit the traversal up the >> directory tree, so it feels like a good architecture, not just a >> "hack". > > Indeed, it just seems like the Right Thing to Do, not a hack. > Not having been paying attention, I was surprised to see the adopted solution > goes for "loop over every VC backend, and every directory up the tree, > then filter the results", rather than "walk up the directory tree, > stopping when a backend claims responsibility". I didn't want to insist on it because upon some thinking it seemed to me that the remote case might be the only problematic one. And one-traversal-per-backend might be more optimizable by Tramp (e.g. via a mini-program) than one-check-per-directory-level. But perhaps the latter could be optimized using a file handler or an advice just as well. > I would think efficiency matters in such a frequent operation. > As a (completely unscientific) data point, my first single core > bootstrap build after this change took about 5% longer than before > (22m5s v 21m4s). But of course a single measurement means nothing. Was that with a rotating disk? A few more experiments should help, to establish whether that was a fluke or not. From unknown Sun Jun 15 09:02:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42966: 28.0.50; vc-dir: wrong backend Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen , Glenn Morris Cc: sds@gnu.org, 42966@debbugs.gnu.org Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160375047531165 (code B ref 42966); Mon, 26 Oct 2020 22:15:02 +0000 Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 22:14:35 +0000 Received: from localhost ([127.0.0.1]:41827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAl9-00086b-G5 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 18:14:35 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:37904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAl8-00086N-2u for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 18:14:34 -0400 Received: by mail-ej1-f47.google.com with SMTP id ce10so16117833ejc.5 for <42966@debbugs.gnu.org>; Mon, 26 Oct 2020 15:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c4TSrVrV5am7eBECk8RUtS5ib21UvPF+6Eye7lOc1tc=; b=FyncQvlUNP3EpqGxaCwdilmPgayQ6DJ0WI5/kMaOgbrgNZZfZiaaAXvPbO2+r+krTz Spq5mPfqlk4fexY5ejlMDQYtMUOTdnt0jpNXmYaTBNJWfB+MerxRMa/ujIDnwLO5+p0I bWXB/gtb/jtzfFU/6MvGTlP7PmOLvoXcF7uHHVfZNmKqqao828LVPwtVLKr/+AB6Rr3E M1L0vpJ13YLL83l4KE3PA9/Oc/YTvyVg6wPbHZUBMHyIN0eMiDwPAFFADItQsWTfpQrc 9Hr0eE4iNWtnEXmn/7e4gPrIazh/jVAVLaOnDpiRuKYYAB5XKtNB9L148lx8BUHHAbLf x70Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c4TSrVrV5am7eBECk8RUtS5ib21UvPF+6Eye7lOc1tc=; b=pbCuxd8+VepomCatVWsY0mEBf4kEFj+awpg/zzyPXyV9NWTDIXzdwN1VfriXfAiEdZ wxtdOjGa3KL7BEdn1vrasQJ+QpFwo1Tt0TykHRIuq8Cj3dSl58PWbIrp4qEt/ASxlKlL dZC8plj+7sOLe0lVB2yeh9zK+WswFTsNRENHNT+6HjRqC59aNMfXFXq7kGbREnzHLN1X /aPDiAHczFfQ94vu54SQYXR3xPbKAtPT98av5iol+nkN/ReYc+sqWf4XaWMvSzjah+Aj dl1O1DrJu7FZOW41fYDO3Yu8/mSxHUYNwCNk2RHqVrs4/c7CLhL+3pCicczWaKD66Ocw m/NQ== X-Gm-Message-State: AOAM531689mVVIEkEHpg1rTq0oE2K6p3Mxrwr7K1pmJS6Kv/jb5ljnKM XJxr8VFAKSKj+YZhl248Fjd+Ejrr15q7Ew== X-Google-Smtp-Source: ABdhPJwQME97GHO9go4QpYnqnAuglRvhsC/edOaBsB473jKd6Nu5f9DafFeoeqcsKg1u7YQa5IvpqA== X-Received: by 2002:a17:906:bc4b:: with SMTP id s11mr18356697ejv.437.1603750468121; Mon, 26 Oct 2020 15:14:28 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id f23sm6568892ejd.5.2020.10.26.15.14.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 15:14:27 -0700 (PDT) References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> <871rhktzs9.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Tue, 27 Oct 2020 00:14:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <871rhktzs9.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 26.10.2020 23:58, Lars Ingebrigtsen wrote: > And it would require tweaking a handful of the in-tree backends; see the > overview I posted the other week, but it didn't look complicated. If only we could delete some problematic older backends as well. ;-)