GNU bug report logs - #42937
[PATCH] * lisp/net/goto-addr.el: Add global minor mode for goto-addr-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42937 in the body.
You can then email your comments to 42937 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: noah swainland <noah <at> distinctly.pink>
To: bug-gnu-emacs <at> gnu.org
Cc: noah swainland <noah <at> distinctly.pink>
Subject: [PATCH] * lisp/net/goto-addr.el: Add global minor mode for
 goto-addr-mode.
Date: Wed, 19 Aug 2020 12:49:22 +0100

Found that I couldn't enable goto-addr either globally or through the
customize interface, so added it.

I found it unclear which version I should add in the key-value lines,
if this is wrong please let me know and I'll send another patch.
---
 lisp/net/goto-addr.el | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el
index 9436f45aa3..95f8a43144 100644
--- a/lisp/net/goto-addr.el
+++ b/lisp/net/goto-addr.el
@@ -280,6 +280,16 @@ Also fontifies the buffer appropriately (see `goto-address-fontify-p' and
       (widen)
       (goto-address-unfontify (point-min) (point-max)))))
 
+(defun turn-on-goto-addr-mode ()
+  (when (not goto-address-mode)
+    (goto-address-mode 1)))
+
+;;;###autoload
+(define-globalized-minor-mode global-goto-address-mode
+  goto-address-mode turn-on-goto-addr-mode
+  :group 'goto-address
+  :version "27.1")
+
 ;;;###autoload
 (define-minor-mode goto-address-prog-mode
   "Like `goto-address-mode', but only for comments and strings."
-- 
2.28.0


-- Email domain proudly hosted at https://migadu.com

Message #8 received at 42937 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: noah swainland <noah <at> distinctly.pink>
Cc: 42937 <at> debbugs.gnu.org
Subject: Re: bug#42937: [PATCH] * lisp/net/goto-addr.el: Add global minor
 mode for goto-addr-mode.
Date: Thu, 20 Aug 2020 15:19:48 +0200

noah swainland <noah <at> distinctly.pink> writes:

> Found that I couldn't enable goto-addr either globally or through the
> customize interface, so added it.

Makes sense to me.

> I found it unclear which version I should add in the key-value lines,
> if this is wrong please let me know and I'll send another patch.

Thanks; I altered it to "28.1" and applied it to the trunk.

The patch was small enough that it could be applied without doing a
copyright assignment, but further Emacs improvements would need an
assignment.  If you think that's likely, would you be willing to sign a
copyright assignment to the FSF?  If so, here's the way to get started:



Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.